Re: [libvirt] [RFC PATCH] lxc: Up back the veth interfaces by default

2018-01-12 Thread Benjamin Cama
Hi again, Le jeudi 11 janvier 2018 à 18:08 +0100, Benjamin Cama a écrit : > Upping an interface without configuring it is not a “cardinal sin” but a > sensible way to achieve auto-configuration, e.g. with IPv6 SLAAC (RFC > 4862). If NetworkManager has troube with interfaces having only

[libvirt] [RFC PATCH] lxc: Up back the veth interfaces by default

2018-01-11 Thread Benjamin Cama
c3cf3c43a0bb2e0e4909c32821e20f607635ec85. Signed-off-by: Benjamin Cama <b.c...@kerlink.fr> --- Hi, The patch that I propose to revert basically broke my workflow for light stateless containers, where they could be auto-configured on IPv6-only network through SLAAC. Of course, fully-fledged containers can br

Re: [libvirt] [PATCH 1/3] Only check for IP forwarding, do not enable it

2012-10-17 Thread Benjamin Cama
Hi everyone, Le lundi 15 octobre 2012 à 09:36 -0700, Cole Robinson a écrit : On 10/15/2012 12:04 PM, Cole Robinson wrote: On 10/15/2012 10:54 AM, Michal Privoznik wrote: On 15.10.2012 12:26, Benjamin Cama wrote: static int networkSetIPv6Sysctls(virNetworkObjPtr network

Re: [libvirt] [PATCH 2/3] Add a forward family option

2012-10-17 Thread Benjamin Cama
Hi, First, thanks Michal for your review. Le lundi 15 octobre 2012 à 11:31 -0700, Laine Stump a écrit : On 10/15/2012 10:54 AM, Michal Privoznik wrote: On 15.10.2012 12:27, Benjamin Cama wrote: It allows to specify forwarding only for IPv4 or IPv6. Not specifying it enables forwarding

[libvirt] [PATCH 0/3] Add option to selectively enable IPv4/v6 forwarding

2012-10-15 Thread Benjamin Cama
forwarding was enabled in my back. Regards, Benjamin Cama (3): Only check for IP forwarding, do not enable it Add a forward family option Take the forwarding family into account src/conf/network_conf.c | 58 ++- src/conf/network_conf.h |1 + src

[libvirt] [PATCH 1/3] Only check for IP forwarding, do not enable it

2012-10-15 Thread Benjamin Cama
Enabling IP forwarding without the administrator's consent is bad. Only check for forwarding, do not enable it. --- src/network/bridge_driver.c | 56 +-- 1 files changed, 43 insertions(+), 13 deletions(-) diff --git a/src/network/bridge_driver.c

[libvirt] [PATCH 3/3] Take the forwarding family into account

2012-10-15 Thread Benjamin Cama
Only add iptables rules for this family, and also only check for forwarding for this family. --- src/network/bridge_driver.c | 27 +-- 1 files changed, 21 insertions(+), 6 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index

[libvirt] [PATCH 2/3] Add a forward family option

2012-10-15 Thread Benjamin Cama
It allows to specify forwarding only for IPv4 or IPv6. Not specifying it enables forwarding for both protocols. --- src/conf/network_conf.c | 58 ++- src/conf/network_conf.h |1 + 2 files changed, 58 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH v3] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on recent kernels

2012-09-28 Thread Benjamin Cama
Le jeudi 27 septembre 2012 à 11:18 -0600, Eric Blake a écrit : ACK with those changes, so I fixed it and pushed, along with your .mailmap update. Thanks a lot! -- Benjamin Cama benjamin.c...@telecom-bretagne.eu -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

Re: [libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on recent kernels

2012-09-27 Thread Benjamin Cama
Le vendredi 21 septembre 2012 à 12:24 -0600, Eric Blake a écrit : On 09/21/2012 11:04 AM, Benjamin Cama wrote: Ping? Thanks. BTW, if this patch is commited, I'm already in AUTHORS under another email address, which is OK. Our syntax checker wants us to add a .mailmap listing, so

Re: [libvirt] [PATCH] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on recent kernels

2012-09-26 Thread Benjamin Cama
Hi, Le vendredi 21 septembre 2012 à 16:28 -0400, Laine Stump a écrit : On 09/21/2012 02:45 PM, Eric Blake wrote: From: Benjamin Cama benjamin.c...@telecom-bretagne.eu Le mercredi 20 juin 2012 à 11:05 +0100, Daniel P. Berrange a écrit : I think you also need to have a VIR_FOFRCE_CLOSE

[libvirt] [PATCH v3] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on recent kernels

2012-09-26 Thread Benjamin Cama
, -- Benjamin Cama benjamin.c...@telecom-bretagne.eu -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on recent kernels

2012-09-21 Thread Benjamin Cama
net-start, with the latest backport (0.9.12) with kernel 3.2.0. Le mercredi 20 juin 2012 à 14:27 +0100, Daniel P. Berrange a écrit : On Wed, Jun 20, 2012 at 01:49:30PM +0200, Benjamin Cama wrote: Le mercredi 20 juin 2012 à 11:05 +0100, Daniel P. Berrange a écrit : I think you also need

[libvirt] [PATCH] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on recent kernels

2012-06-19 Thread Benjamin Cama
*tapfd) + int *tapfd, + bool persist) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) ATTRIBUTE_RETURN_CHECK; -- Benjamin Cama benjamin.c...@telecom-bretagne.eu -- libvir-list mailing list libvir-list

[libvirt] [PATCH] Misleading error message when name is missing

2012-02-23 Thread Benjamin Cama
Hi, [forwarding this here from RH bug #796732] When creating a network (virsh net-create) with an erroneous XML containing an empty name element, the error message is misleading: error: Failed to create network from foo.xml error: missing domain name information It took me a bit of time to

Re: [libvirt] [PATCH] Misleading error message when name is missing

2012-02-23 Thread Benjamin Cama
Le jeudi 23 février 2012 à 16:32 -0700, Eric Blake a écrit : On 02/23/2012 09:37 AM, Benjamin Cama wrote: [forwarding this here from RH bug #796732] Thanks for taking the time to contribute, and for putting up with our split personality on bug reports to BZ vs. patches to the list