Re: [PATCH 2/3] qemu: Update to new design of 'block-export-add'

pname"))) > +if (!(nbddata = qemuBlockExportGetNBDProps("nodename", "exportname", > true, bitmaps))) > return -1; > > if (qemuMonitorTestAddItem(test, "block-export-add", "{\"return\":{}}") > < 0) > Still waiting on qemu, but once that is in, the code changes plus your respin to fix the commit message and testsuite are good enough to add: Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 3/3] qemu: capabilities: Re-enable detection of QEMU_CAPS_BLOCK_EXPORT_ADD

-o-b when the commit message is fixed. Code-wise: Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 1/3] qemu: capabilities: Disable detection of QEMU_CAPS_BLOCK_EXPORT_ADD

ilities.c | 1 - > tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 - > 2 files changed, 2 deletions(-) Reviewed-by: Eric Blake Safe for libvirt now no matter what happens in qemu's soft freeze this week. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH v5 06/12] nbd: Update qapi to support exporting multiple bitmaps

On 10/26/20 5:50 AM, Peter Krempa wrote: > On Fri, Oct 23, 2020 at 13:36:46 -0500, Eric Blake wrote: >> Since 'nbd-server-add' is deprecated, and 'block-export-add' is new to >> 5.2, we can still tweak the interface. Allowing 'bitmaps':['str

Re: [PATCH 5/6] qemu: Add infrastructure for 'block-export-add' to export NBD

On 10/19/20 3:25 PM, Peter Krempa wrote: > On Mon, Oct 19, 2020 at 13:32:32 -0500, Eric Blake wrote: >> On 10/14/20 5:04 AM, Peter Krempa wrote: >>> Add the monitor code, corresponding generator of properties for NBD and >>> tests validating it against the schema. &

[PATCH v5 06/12] nbd: Update qapi to support exporting multiple bitmaps

le bitmaps as distinct metadata contexts that the NBD client may request, but the actual support for more than one will require a further patch to the server. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/system/deprecated.rst | 4 +++- qapi/block-export.json

Re: [libvirt PATCH] docs: Mention GPG key used for signing releases

ng their append-only nature, which makes them no longer an ideal way to get a key. I'd recommend making it available for download here in addition to the keyservers. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 5/6] qemu: Add infrastructure for 'block-export-add' to export NBD

27;], and retiring '*bitmap':'str' when nbd-server-add goes away: https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg02713.html so you'll need to tweak this to match. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH v4 11/11] TODO: Add news entry

On 9/24/20 6:43 AM, Peter Krempa wrote: --- TODO | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 TODO diff --git a/TODO b/TODO new file mode 100644 index 00..e69de29bb2 TODO: add my review here... -- Eric Blake, Principal Software Engineer Red Hat, Inc

Re: [PATCH v4 03/11] qemu: snapshot: Introduce helpers for creating overlays on disks

src/qemu/qemu_snapshot.h | 5 +++ 2 files changed, 95 insertions(+), 1 deletion(-) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 12/13] virDomainSnapshotAlignDisks: refactor extension to all disks

ids the sorting step and thus even the need to store the index of the domain disk altogether. Signed-off-by: Peter Krempa --- src/conf/snapshot_conf.c | 48 +++- 1 file changed, 18 insertions(+), 30 deletions(-) Nice cleanup. Reviewed-by: Eric Blake -- Eric B

Re: [PATCH 11/13] virDomainSnapshotAlignDisks: clarify handing of snapshot location

e code is doing. Signed-off-by: Peter Krempa --- src/conf/snapshot_conf.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH] tests: avoid close of bad file handle in commandtest

changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake diff --git a/tests/commandtest.c b/tests/commandtest.c index 42225a8ef2..cbbcda4e5f 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c @@ -1091,8 +1091,8 @@ static int test27(const void *unused G_GNUC_UNUSED) printf

Re: [libvirt PATCH] tests: don't mix FILE* and UNIX FD I/O on same stream

roach. Signed-off-by: Daniel P. Berrangé --- tests/commandhelper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) With typos fixed, Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH] docs/system: clarify deprecation scheduled

which it was deprecated and one further release. After these two releases, the feature is liable to be removed. Longer, but definitely conveys more information in an easier-to-understand format. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualiz

Re: [RFC PATCH 0/3] qemu: Propagate cluster size to new qcow2 images

adccidentally creating an overlay with 64k clusters atop a base image with 1M clusters. Series: Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [libvirt PATCH] tests: fix license blurb in virsh-undefine

On 8/4/20 1:28 PM, Ján Tomko wrote: Assume commit 0466ff28f2 used case-insensitive replace s/OUT/EXP/ by mistake and this file is still licensed under GPLv2.0+ Undo the change. Signed-off-by: Ján Tomko FIxes: 0466ff28f23f4c430906efd5859f87672cf08782 Cc: Cole Robinson Cc: Eric Blake Cc: Pino

Re: [libvirt PATCH 00/20] Use SPDX-License-Identifier

So NACK to this change. While wholesale replacement of the text is legally problematic, _adding_ the SPDX tag (in addition to what is already present), should not be an issue, if you want to respin a lighter-weight patch along those lines. -- Eric Blake, Principal Software Engineer Red Hat, In

Re: [PATCH] qemu: snapshot: Collect 'query-named-block-nodes' prior to memory migration

iver.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0ad6359102..b655df8c98 100644 --- a/src/qemu/qemu_driver.c Reviewed-by: Eric Blake I'll leave it up to you to decide if this is a mandator

Re: [PATCH v2 2/4] tests: qemu: Split NBD and VXHS protocol tests

On 7/30/20 10:49 AM, Peter Krempa wrote: QEMU is going to drop 'vxhs' in the upcomming release so we'll need to upcoming track these separately to prevent test suite breakage. Signed-off-by: Peter Krempa --- -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [PATCH v2 1/4] tests: qemuxml2argv: Use only modern versions of 'disk-network-tlsx509' test

On 7/30/20 10:49 AM, Peter Krempa wrote: We already test with real caps so there's no real need for this special case. While it technically tested the state without TLS encryption key secrets, it doesn't really matter that much.t s/t&// Signed-off-by: Peter Krempa ---

Re: [PATCH 10/10] virDomainSetBlockThreshold: Mention that the event can be registered for

written sector of an image in the bulk stats API Reviewed-by: Eric Blake * (virConnectGetAllDomainStats/virDomainListGetStats) as * "block..allocation" in the VIR_DOMAIN_STATS_BLOCK group. The current -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 09/10] qemuDomainGetStorageSourceByDevstr: Look also in 'mirror' chain

ions(+), 4 deletions(-) Reviewed-by: Eric Blake Hmm, when doing a pull-mode backup, do we ever want a write-threshold on the temporary image? Or is this only for actual block-copy mirroring, and not backups? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtu

Re: [PATCH 08/10] qemuDomainDiskLookupByNodename: Look also for 'mirror' node names

-by: Eric Blake diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ed7ec77ed4..18fd445e30 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11492,6 +11492,14 @@ qemuDomainDiskLookupByNodename(virDomainDefPtr def, return def->disk

Re: [PATCH 07/10] virStorageSourceFindByNodeName: Remove unused 'idx' argument

(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 06/10] qemuDomainDiskLookupByNodename: Remove unused 'idx'

(-) Another fun code cleanup. All this refactoring work is getting somewhere... Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 05/10] virDomainSetBlockThreshold: Clarify values of @dev the event is fired for

or disk target with index ( * vda[4]). Without the index the top image in the backing chain will have the With fixes, Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 04/10] qemuProcessHandleBlockThreshold: Report correct indexes

show_bug.cgi?id=1857204 Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) With typos fixed, Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226

Re: [PATCH 02/10] qemuDomainDiskBackingStoreGetName: Remove unused argument

On 7/15/20 8:10 AM, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 1 - src/qemu/qemu_domain.h | 1 - src/qemu/qemu_process.c | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red

Re: [PATCH 03/10] qemuDomainDiskBackingStoreGetName: Eliminate temp variable

Whichever way is fine. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 01/10] virDomainSetBlockThreshold: Document values of '@dev' better

On 7/15/20 8:10 AM, Peter Krempa wrote: Mention where to obtain the index and how it's treated. Signed-off-by: Peter Krempa --- src/libvirt-domain.c | 6 ++ 1 file changed, 6 insertions(+) Reviewed-by: Eric Blake diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c

Re: [PATCH 5/5] qemuDomainBlockPivot: Ignore failures of creating active layer bitmap

resulting merge. In turn, your incremental backup might be larger than it needs to be, but you have not lost any data. I agree this is safe. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff -

Re: [PATCH 4/5] qemuDomainBlockPivot: Rename 'actions' to 'bitmapactions'

ions(+), 7 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 1/5] qemu: blockjob: Don't base bitmap handling of active-layer block commit on QEMU_CAPS_BLOCKDEV_REOPEN

| 6 +- 2 files changed, 3 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 2/5] qemu: blockjob: Actually delete temporary bitmap on failed active commit

, building up the command structure doesn't help if you don't run it ;) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 3/5] qemu: block: Remove 'active-write' bitmap even if there are no bitmaps to merge

mmit in <20a7abc2d2d> and for block copy in <7bfff40fdfe5>. The actual bug originates from <4fa8654ece>. https://bugzilla.redhat.com/show_bug.cgi?id=1857735 Signed-off-by: Peter Krempa --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc

Re: [PATCH v6 08/10] iotests: Specify explicit backing format where sensible

On 7/7/20 11:07 AM, Kevin Wolf wrote: Am 06.07.2020 um 22:39 hat Eric Blake geschrieben: There are many existing qcow2 images that specify a backing file but no format. This has been the source of CVEs in the past, but has become more prominent of a problem now that libvirt has switched to

Re: [PATCH 4/4] backup: Allow configuring incremental backup per-disk individually

829829 Signed-off-by: Peter Krempa --- v2: - backupmode=full incremental="..." is now rejected by the RNG schema - test output changes as we now validate virDomainBackupAlignDisks - typo fix Reviewed-by: Eric Blake -- Eric Blake, Principal Software Eng

Re: [PATCH 3/4] backupxml2xmltest: Call 'virDomainBackupAlignDisks' before formatting output

dextradisk'. Signed-off-by: Peter Krempa --- More testing is always useful. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 2/4] virDomainBackupDiskDefFormat: Format internal disk state only when valid

On 7/7/20 10:23 AM, Peter Krempa wrote: Format the disk state only when it isn't _NONE. Signed-off-by: Peter Krempa --- src/conf/backup_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/src/conf/backup_conf.c b/src/conf/backup_c

Re: [PATCH 1/4] backupxml2xmltest: Remove output symlink of 'backup-pull-internal-invalid'

(+), 1 deletion(-) mode change 12 => 100644 tests/domainbackupxml2xmlout/backup-pull-internal-invalid.xml Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 1/3] qemu: implementation of transient option for qcow2 file

atter, external snapshots should be blocked if there is a transient disk. One nice-to-have but not required modification would be to allow configuration of the transient disk's overlay path. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

[PATCH v6 10/10] qemu-img: Deprecate use of -b without -F

than defaulting to our new default of recording a probed format, so it needs an update. While touching it, expand it to cover all of the various warnings enabled by this patch. iotest 293 also shows a change to qcow messages. Signed-off-by: Eric Blake --- docs/system/deprecated.rst

[PATCH v6 07/10] qcow2: Deprecate use of qemu-img amend to change backing file

unrelated to the backing chain. Signed-off-by: Eric Blake --- docs/system/deprecated.rst | 12 docs/tools/qemu-img.rst| 4 block/qcow2.c | 5 + tests/qemu-iotests/061.out | 1 + tests/qemu-iotests/082.out | 2 ++ 5 files changed, 24 insertions(+) diff -

[PATCH v6 01/10] qemu-img: Flush stdout before before potential stderr messages

an error message. Several iotests demonstrate the resulting ordering change now that the merged outputs now reflect chronology. (An even better fix would be to avoid printf from within block.c altogether, but that's much more invasive...) Signed-off-by: Eric Blake --- block.c

[PATCH v6 02/10] block: Finish deprecation of 'qemu-img convert -n -o'

It's been two releases since we started warning; time to make the combination an error as promised. There was no iotest coverage, so add some. While touching the documentation, tweak another section heading for consistent style. Signed-off-by: Eric Blake --- docs/system/deprecated.rst

[PATCH v6 04/10] vmdk: Add trivial backing_fmt support

rejecting all other explicit formats (note that this is only for QemuOpts usage; there is no change to the QAPI to allow a format through -blockdev). Signed-off-by: Eric Blake --- block/vmdk.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index

[PATCH v6 03/10] sheepdog: Add trivial backing_fmt support

rejecting all other explicit formats (note that this is only for QemuOpts usage; there is no change to the QAPI to allow a format through -blockdev). Signed-off-by: Eric Blake --- block/sheepdog.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/block

[PATCH v6 06/10] block: Error if backing file fails during creation without -u

didn't mention the word "deprecated", we never actually remembered to document it as such. But the warning has been around long enough that I don't see prolonging it another two releases. Signed-off-by: Eric Blake --- docs/system/deprecated.rst | 12 block.c

[PATCH v6 09/10] block: Add support to warn on backing file change without format

For now, this is a mechanical addition; all callers pass false. But the next patch will use it to improve 'qemu-img rebase -u' when selecting a backing file with no format. Signed-off-by: Eric Blake Reviewed-by: Peter Krempa Reviewed-by: Ján Tomko --- include/block/block.h | 4 ++-

[PATCH v6 05/10] qcow: Tolerate backing_fmt=

and to make it easier to show the improvements made in the next patch. Signed-off-by: Eric Blake --- block/qcow.c | 20 - tests/qemu-iotests/293 | 88 ++ tests/qemu-iotests/293.out | 60 ++ tests/qemu-iotests/gr

[PATCH v6 00/10] Tighten qemu-img rules on missing backing format

07/10:[0004] [FC] 'qcow2: Deprecate use of qemu-img amend to change backing file' 008/10:[0059] [FC] 'iotests: Specify explicit backing format where sensible' 009/10:[] [-C] 'block: Add support to warn on backing file change without format' 010/10:[0027] [FC] 

Re: [RFC PATCH 1/2] hw/sd/ssi-sd: Deprecate the SPI to SD card 'adapter'

; (SSI to SD card adapter) device is deprecated. What is the recommended replacement? Or at least document if it is disappearing with no replacement. + System emulator machines -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 24/24] qemu: backup: Setup TLS environment for pull-mode backup jobs

should work even if it is not a trivial setup. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 23/24] conf: backup: Add 'tls' attribute for 'server' element

he files as configured in qemu.conf? Knowing how the server is keyed is important for writing a client that can connect over TLS to the server. But the overall idea makes sense. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 22/24] qemu: conf: Add configuration of TLS environment for NBD transport of pull-backups

++ src/qemu/qemu_conf.c | 17 ++ src/qemu/qemu_conf.h | 5 src/qemu/test_libvirtd_qemu.aug.in | 3 +++ 6 files changed, 71 insertions(+) Aha - answering my question from 21/24 ;) Reviewed-by: Eric Blake -- Eric Blake

Re: [PATCH 21/24] conf: backup: Store 'tlsAlias' and 'tlsSecretAlias' as internals of a backup

without NBD encryption, this is a nice improvement. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 19/24] checkpoint: Mention that VIR_DOMAIN_CHECKPOINT_XML_SIZE is expensive and stale

(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 20/24] testCompareBackupXML: Add infrastructure for testing internal fields

hanged, 24 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 18/24] qemu: checkpoint: Implement VIR_DOMAIN_CHECKPOINT_XML_SIZE

simpler (my original implementation only grabbed this information for the most recent checkpoint, because the work to merge bitmaps for older bitmaps was tougher). Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 17/24] conf: checkpoint: Add a flag storing whether disk 'size' is valid

eckpoint_conf.c | 2 +- src/conf/checkpoint_conf.h | 1 + tests/qemudomaincheckpointxml2xmltest.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualiza

Re: [PATCH 16/24] docs: checkpoint: Convert XML documentation to RST

(+), 198 deletions(-) delete mode 100644 docs/formatcheckpoint.html.in create mode 100644 docs/formatcheckpoint.rst Again, I'm not strong in .rst, but the conversion seems sane. Reviewed-by: Eric Blake +second full backup would require. Most disk checkpoints are created in +conjunction

Re: [PATCH 15/24] qemu: backup: integrate with blockpull

file changed, 37 insertions(+) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 14/24] backup: Allow configuring incremental backup per-disk individually

diff --git a/tests/domainbackupxml2xmlout/backup-pull.xml b/tests/domainbackupxml2xmlout/backup-pull.xml index 24fce9c0e7..d2f84cda7a 100644 --- a/tests/domainbackupxml2xmlout/backup-pull.xml +++ b/tests/domainbackupxml2xmlout/backup-pull.xml @@ -6,5 +6,17 @@ + + + + + + +

Re: [PATCH 13/24] docs: backup: Convert XML documentation to RST

(+), 191 deletions(-) delete mode 100644 docs/formatbackup.html.in create mode 100644 docs/formatbackup.rst I'm not an rst expert, but the conversion seems sane enough. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualiz

Re: [PATCH 12/24] conf: backup: Don't explicitly forbid backup of read-only disk

?id=1840053 Signed-off-by: Peter Krempa --- src/conf/backup_conf.c | 7 --- 1 file changed, 7 deletions(-) Reviewed-by: Eric Blake diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index 92106d8aaa..e9eea5af75 100644 --- a/src/conf/backup_conf.c +++ b/src/conf/backup_conf.c

Re: [PATCH 11/24] tests: qemuxml2argv: Test encrypted TLS key for nbd/vxhs disks

/qemuxml2argvtest.c | 2 ++ 3 files changed, 29 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 06/24] virQEMUDriverConfigLoadSpecificTLSEntry: Split up fetching of server-only config options

support of 'nbd' and 'vxhs' disks which are client only we can reuse the existing macros. Signed-off-by: Peter Krempa --- src/qemu/qemu_conf.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Princ

Re: [PATCH 09/24] qemu: conf: Add configuration of TLS key encryption for 'vxhs' and 'nbd' disks

| 19 +++ src/qemu/qemu_conf.c | 13 + src/qemu/qemu_conf.h | 2 ++ src/qemu/test_libvirtd_qemu.aug.in | 2 ++ 5 files changed, 34 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Re

Re: [PATCH 10/24] qemu: domain: Setup secret for TLS key for nbd/vxhs disks

(+), 13 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 07/24] qemu: domain: Add infrastructure passing in TLS key's decryption key via 'secret'

the other elements use '-' but this one uses ' '? Otherwise, Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 08/24] qemu block: Add internals for handling 'secret' corresponding to TLS key

++- 3 files changed, 24 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 05/24] virQEMUDriverConfigLoadSpecificTLSEntry: Move fetching of 'chardev_tls' above macro

On 7/2/20 9:39 AM, Peter Krempa wrote: Move the extraction of the config value so that it makes more sense after upcoming refactors. Signed-off-by: Peter Krempa --- src/qemu/qemu_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake

Re: [PATCH 04/24] qemu: conf: Move 'nbd' and 'vxhs' tls config variables together with rest of tls setup

On 7/2/20 9:39 AM, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/libvirtd_qemu.aug | 12 ++-- src/qemu/qemu_conf.h | 12 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red

Re: [PATCH 03/24] qemu.conf: Remove misleading mention of 'migrate_tls'

On 7/2/20 9:39 AM, Peter Krempa wrote: There's no such parameter. Reword the sentence to account for enabling TLS-encrypted migration using API flags. Signed-off-by: Peter Krempa --- src/qemu/qemu.conf | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Eric

Re: [PATCH 02/24] qemuDomainDiskHasEncryptionSecret: unexport

On 7/2/20 9:39 AM, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domain.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301

Re: [PATCH 01/24] qemu: domain: Introduce helper for always fetching virStorageSource private data

(+) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 6/6] kbase: incrementalbackupinternals: Describe 'block commit'

chain removing all +images in the subchain . Drop space before . Does oVirt care about block pull, or only block commit? But block pull can be a separate patch if we need more information; this one is useful as-is (well, with typos fixed). Reviewed-by: Eric Blake -- Eric Blake, Prin

Re: [PATCH 5/6] kbase: incrementalbackupinternals: Replace bash with pseudocode

. Signed-off-by: Peter Krempa --- docs/kbase/incrementalbackupinternals.rst | 44 ++- 1 file changed, 11 insertions(+), 33 deletions(-) Nice! Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization

Re: [PATCH 4/6] kbase: incrementalbackupinternals: Add section on 'qemu-img bitmap' use

NAME`` +Deletes bitmap ``NAME``. + +``--merge SRCBITMAP -b SRCFILE -F SRCFILEFMT DSTBITMAP`` +Merges bitmap ``SRCBITMAP`` from ``SRCFILE`` into ``DSTBITMAP``. + Checking bitmap health -- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat

Re: [PATCH 3/6] kbase: incrementalbackupinternals: Add secion on bitmap handling in shell

** + (See also the ``qemuBlockBitmapChainIsValid`` helper method in ``src/qemu/qemu_block.c``) With fixes, Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 2/6] kbase: incrementalbackupinternals: Clarify language in snapshots section

same granularity. After taking a snapshot of the ``vda`` disk from the example above placed into ``vda-2.qcow2`` the following topology will be created: With the fixes, Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qem

Re: [PATCH 1/6] kbase: incrementalbackupinternals: Add snapshot terminology

o usually described +as ``base image``. + +The topmost overlay is the image which is being written to by the VM and is also +described as the ``active`` layer or image. Maybe it's also worth a paragraph mentioning how diagramming the chains we typically use <- for 'Backed by'

Re: [PATCH v4 20/20] audio: set default value for pcspk.iobase property

: Gerd Hoffmann --- include/hw/audio/pcspk.h | 6 +- hw/audio/pcspk.c | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH v4 18/20] audio: add soundhw deprecation notice

;''''''' + +Sound card devices should be created using ``-device`` instead. The +names are the same for most devices. The exceptions are ``hda`` which +needs two devices (``-device intel-hda --device hda-duplex``) and Both spellings work, but it looks inconsis

Re: [PATCH v5 3/7] qcow: Tolerate backing_fmt=, but warn on backing_fmt=raw

On 5/5/20 10:30 AM, Eric Blake wrote: On 5/5/20 2:35 AM, Kevin Wolf wrote: Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: qcow has no space in the metadata to store a backing format, and there are existing qcow images backed both by raw or by other formats (usually qcow) images, reliant on

Re: [RFC PATCH 28/41] qemuDomainStorageSourcePrivate: Add per-source private blockjob

ockjob-populate command allow multiple destination bitmaps grouped into one job? Or is that just trading reduced libvirt complexity for too much QMP complexity? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [RFC PATCH 26/41] qemucapabilitiestest: Bump qemu-5.1 caps on x86_64 for 'dirty-bitmap-populate'

/refs/tags/bitmap-pop-v3 -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [RFC PATCH 18/41] qemu: snapshot: Don't propagate bitmaps to upper layers

l want to keep supporting qemu 5.0 where it was not present, and therefore need code for propagating bitmaps during snapshot creation? Or is the plan that you won't enable incremental backup support in libvirt unless you detect new enough qemu including bitmap-populate support? -- E

Re: [PATCH 32/32] kbase: Add document outlining internals of incremental backup in qemu

#x27;.flags[]' <<< "$BACKING_BITMAP_") + BITMAP_NAME=$(jq -r '.name' <<< "$BACKING_BITMAP_") + + if grep 'in-use' <<< "$BITMAP_FLAGS" || + grep -v 'auto' <<< "$BITMAP_FLAGS"; then + continue + fi + + qemu-img bitmap -f "$SNAP_FMT" "$SNAP_IMG" --add "$BITMAP_NAME" Do you want to also copy the --granularity of the bitmaps being added? + + done -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 31/32] qemublocktest: Add test cases for handling bitmaps during block-copy

blockcopy/basic-deep-out.json create mode 100644 tests/qemublocktestdata/bitmapblockcopy/basic-shallow-out.json create mode 100644 tests/qemublocktestdata/bitmapblockcopy/snapshots-deep-out.json create mode 100644 tests/qemublocktestdata/bitmapblockcopy/snapshots-shallow-out.json Rev

Re: [PATCH 30/32] qemu: Rewrite bitmap handling for block copy

++- src/qemu/qemu_blockjob.c | 40 ++ src/qemu/qemu_driver.c | 13 ++--- tests/qemublocktest.c| 6 ++- 4 files changed, 57 insertions(+), 115 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301

Re: [PATCH 29/32] qemu: blockjob: Remove 'disabledBitmapsBase' field from commit job private data

job.h | 3 -- src/qemu/qemu_domain.c| 22 -- src/qemu/qemu_driver.c| 3 +- .../blockjob-blockdev-in.xml | 4 -- 5 files changed, 1 insertion(+), 75 deletions(-) Reviewed-by: Eric Blake Another sign o

Re: [PATCH 28/32] qemublocktest: Add 'snapshots' tests for block commit bitmap handling

mbinations, but that serves for good regression prevention. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 27/32] qemublocktest: Add 'basic' tests for commit bitmap handling

et": "b", + "bitmaps": [ +{ + "node": "libvirt-1-format", + "name": "b" +}, +{ + "node": "libvirt-2-format", + "name": "libvirt-tmp-act

Re: [PATCH 26/32] qemu: Rewrite bitmap handling for block commit

bledBitmapsBase) + virJSONValuePtr *actions) { Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 25/32] qemublocktest: Add 'snapshots' tests for backup bitmap handling

ode 100644 tests/qemublocktestdata/backupmerge/snapshots-deep-out.json create mode 100644 tests/qemublocktestdata/backupmerge/snapshots-flat-out.json create mode 100644 tests/qemublocktestdata/backupmerge/snapshots-intermediate-out.json Reviewed-by: Eric Blake -- Eric Blake, Principa

Re: [PATCH 24/32] qemublocktest: Add 'basic' tests for backup bitmap handling

p-out.json create mode 100644 tests/qemublocktestdata/backupmerge/basic-flat-out.json create mode 100644 tests/qemublocktestdata/backupmerge/basic-intermediate-out.json Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization:

Re: [PATCH 23/32] qemu: backup: Rewrite backup bitmap handling to the new bitmap semantics

+++--- src/qemu/qemu_backup.h| 12 +- tests/qemublocktest.c | 86 ++- .../backupmerge/empty-out.json| 4 +- 4 files changed, 63 insertions(+), 259 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal

Re: [PATCH 22/32] qemu: block: Add universal helper for merging dirty bitmaps for all scenarios

this once instead of per-bitmap; I'm guessing that means that writebitmapsrc can only be used when bitmapname is non-NULL. Should there be a check for that? + +if (virJSONValueArraySize(act) > 0) +*actions = g_steal_pointer(&act); + +return 0; +} + + Otherwise, it seems to make sense as a generalized tool. We'll see how later patches use it. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

<    1   2   3   4   5   6   7   8   9   10   >