+++
Looks reasonable; you're deleting the bitmap across all files in the
chain where it appears, and don't have to mess around with which bitmaps
to re-enable or merge into.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
On 6/15/20 12:10 PM, Peter Krempa wrote:
Also rename the helper struct and function.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
Mechanical.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
| 153 ++---
src/qemu/qemu_checkpoint.h | 1 -
tests/qemublocktest.c | 7 +-
3 files changed, 25 insertions(+), 136 deletions(-)
No kidding about the simplification.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualiz
persist:1 inconsist:0 gran:65536 dirty:0
Looks like a pretty decent set of awkward setups; libvirt should not
ever produce these, but being robust to whatever happened to the qcow2
files externally to libvirt is worthwhile.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Re
On 6/15/20 12:10 PM, Peter Krempa wrote:
Now that we've updated both the test data and the validator to new
semantics we can start testing again.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 12
1 file changed, 12 insertions(+)
Reviewed-by: Eric Blake
--
rwise,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
).
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
:0 busy:0 persist:1 inconsist:0 gran:65536 dirty:0
-b: record:0 busy:0 persist:1 inconsist:0 gran:65536 dirty:0
- a: record:0 busy:0 persist:1 inconsist:0 gran:65536 dirty:0
+d: record:1 busy:0 persist:1 inconsist:0 gran:65536 dirty:0
+c: record:1 busy:0 persist:1 inconsist:0 gran:65536 dirty:0
+b: record:1 busy:0 persist:1 inconsist:0 gran:65536 dirty:0
+a: record:1 busy:0 persist:1 inconsist:0 gran:65536 dirty:0
And this reflects that libvirt is parsing the qemu output according to
libvirt's new paradigm.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
C2 is b2,
the incremental from C3 is b3.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
file changed, 18 insertions(+), 9 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
| 6 -
7 files changed, 1818 deletions(-)
Same comment as for the previous patch - if we get to the end of the
series without major issues, then this temporary deletion to make the
rewrite easier is fine.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
ng support back in, but unless something major turns up in the rest
of the series, the approach of a clean slate followed by a new
implementation is reasonable enough.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
changed, 3 insertions(+)
create mode 100644 tests/qemublocktestdata/bitmapblockcopy/empty-deep-out.json
create mode 100644
tests/qemublocktestdata/bitmapblockcopy/empty-shallow-out.json
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301
+++--
.../checkpointdelete/empty-out.json | 1 +
2 files changed, 8 insertions(+), 6 deletions(-)
create mode 100644 tests/qemublocktestdata/checkpointdelete/empty-out.json
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
| 19 ++-
.../backupmerge/empty-out.json| 1 +
2 files changed, 11 insertions(+), 9 deletions(-)
create mode 100644 tests/qemublocktestdata/backupmerge/empty-out.json
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1
+
3 files changed, 75 insertions(+)
create mode 100644 tests/qemublocktestdata/bitmap/empty.json
create mode 100644 tests/qemublocktestdata/bitmap/empty.out
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org
nts(vm,
dd->backupdisk->incremental)))
Another long line, but here it is harder to suggest a short alternative.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
w disk.
Signed-off-by: Peter Krempa
---
src/conf/backup_conf.c | 8
src/conf/backup_conf.h | 1 +
2 files changed, 9 insertions(+)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
HECKPOINT_TYPE_BITMAP;
+
I'm not quite sure how this test change matches the code change above,
but the code change looked reasonable.
checkpoint->parent.name = g_strdup(name);
return (virDomainMomentDefPtr) checkpoint;
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
bitmapname, diskdst, from->id);
+return -1;
+}
+
+*actions = g_steal_pointer(&ret);
Maybe s/ret/act/.
Otherwise, this looks like a sane refactoring.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
memdev``, which does the same as ``mem`` and adds
+means to actualy manage node RAM on the host side. Use parameter ``memdev``
s/actualy/actually/
+with *memory-backend-ram* backend as an replacement for parameter ``mem``
s/an/a/
+to achieve the same fake NUMA effect or a properly configured
+*memory-backend-file* backend to actually benefit from NUMA configuration.
+In future new machine versions will not accept the option but it will still
If this sentence is still true:
s/In future new/New/
If the sentence is false (that is, we completely dropped 'mem' even for
old machine versions), drop it.
+work with old machine types. User can check QAPI schema to see if the legacy
s/check/check the/
+option is supported by looking at MachineInfo::numa-mem-supported property.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
x27; to a later section of the document 'has been
removed', so that the history is not lost. But this diffstat says you
just deleted, rather than moved, that hunk.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
on't see any problem with your approach.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
/qemu_process.c | 30 --
1 file changed, 12 insertions(+), 18 deletions(-)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
t to avoid -blockdev if you still need to
supply -snapshot behind libvirt's back.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
x27;s done just for the _CAPS versions of tests but
commenting out a line in the test file allows to validate even cases
which don't use real capabilities.
Signed-off-by: Peter Krempa
---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-91
| 3 ++
2 files changed, 45 insertions(+), 22 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
+-
tests/testutilsqemuschema.h | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
eter Krempa
---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
Krempa
---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
. But in the meantime, yes, this looks like you are
properly handling existing quirks correctly.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
:10.0.2.1:4600-chardev:charchannel0,guestfwd=...
But the idea makes sense - the QMP form uses quite a bit of nesting
(although actual qapfication of netdev occurred late, the hand-rolled
parser for netdev predated many of the best practices learned for other
interfaces, and the CLI does not refle
3 +++-
3 files changed, 119 insertions(+), 69 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
r props);
+
int virQEMUBuildObjectCommandlineFromJSON(virBufferPtr buf,
virJSONValuePtr objprops);
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
ll be necessary for QMP schema
validation tests.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvtest.c | 158 +--
1 file changed, 86 insertions(+), 72 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +
/virjson.h | 2 ++
3 files changed, 20 insertions(+)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
| 23 +++
src/util/vircommand.h| 1 +
3 files changed, 25 insertions(+)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
a single spelling we could use for all
boolean CLI parameters across all supported qemu versions. But this is
certainly the most conservative way to deal with the fact that some of
the CLI parameters are ad hoc rather than sharing common code, and thus
inconsistent on which spellings work where.
anged, 29 insertions(+), 13 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
ned-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 20 ++--
tests/qemuxml2argvdata/net-user-addr.args | 3 ++-
2 files changed, 12 insertions(+), 11 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +
src/qemu/qemu_hotplug.c | 18 +-
3 files changed, 36 insertions(+), 21 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
-
1 file changed, 11 insertions(+), 21 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
On 5/15/20 10:27 AM, Peter Krempa wrote:
Cover all cases of the enum.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301
found,
* NULL is be placed into corresponding place in retvalues.
While you are touching this, s/is be placed into/will be placed into the/
With that,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
work.xml | 9 -
5 files changed, 16 insertions(+), 26 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
already
supports, rather than inventing yet another syntax.
thanks,
Gerd
PS: background: https://bugzilla.redhat.com/show_bug.cgi?id=1595525
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
On 5/5/20 2:35 AM, Kevin Wolf wrote:
Am 03.04.2020 um 19:58 hat Eric Blake geschrieben:
qcow has no space in the metadata to store a backing format, and there
are existing qcow images backed both by raw or by other formats
(usually qcow) images, reliant on probing to tell the difference.
While
On 4/3/20 12:58 PM, Eric Blake wrote:
v4 was here:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg03775.html
In v5:
- fix 'qemu-img convert -B' to actually warn [Kashyap]
- squash in followups
- a couple more iotest improvements
If we decide this is not 5.0 material, then
0)
virQEMUCapsSet(qemuCaps, QEMU_CAPS_TCG);
+
+if (qemuCaps->version >= 550)
+virQEMUCapsSet(qemuCaps, QEMU_CAPS_COMPAT_DEPRECATED);
}
And of course, this will be reworked if your request to the qemu list to
make it introspectible is resolved.
--
Eric Blake, Principal
en that's okay. I was just pointing out that anything mentioned in
the man page should also mention the need for proper shell quoting.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
they don't have PCI vendor IDs.
...to just what you are replying to.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
27;, the unquoted command will see the
argument 'vda1')
error: Scaled numeric value 'vda[1]' for <--bandwidth> option is
malformed or out of range
# virsh blockpull fedora vda 1024 vda[1]
Block Pull started
I'll change to [bandwidth [--bytes] [base]]
--
Eric
#x27;s of MB in size. Thus
this adds 64 KB of padding after the XML which should cope with any
plausible modifications a user will want to make.
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_driver.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
Reviewed
On 4/24/20 10:18 AM, Peter Krempa wrote:
On Fri, Apr 24, 2020 at 09:52:00 -0500, Eric Blake wrote:
On 4/24/20 4:24 AM, Peter Krempa wrote:
The implementation was never finished in libvirt. Remove it.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 19 ++-
1
" \n"
+ "\n");
nbd+unix:///?socket=/tmp/sock:
+TEST_BACKING_PARSE("nbd:unix:/tmp/sock::exportname=:",
+ "\n"
+ " \n"
+ "\n");
nbd+unix://
qcow2 file with the
extension header set, at which point we can error out and tell the user
their image is unsupported, rather than trying to use it without the
data file?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
eft on device
https://bugzilla.redhat.com/show_bug.cgi?id=1812827
Signed-off-by: Peter Krempa
---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
On 4/16/20 4:55 AM, Peter Krempa wrote:
The field can be used by jobs to add an optional error message to a
completed (failed) job.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 3 +++
src/qemu/qemu_domain.h | 2 ++
2 files changed, 5 insertions(+)
Reviewed-by: Eric Blake
cting it in virsh.
Signed-off-by: Peter Krempa
---
include/libvirt/libvirt-domain.h | 9 +
tools/virsh-domain.c | 8
2 files changed, 17 insertions(+)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301
r the liveness check in block job implementations.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualiz
_new0 as it includes the
type and thus it's very easy to grep for all the allocations of a given
type.
Signed-off-by: Peter Krempa
---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
: Peter Krempa
---
src/remote/remote_daemon_dispatch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
On 4/14/20 2:06 PM, Peter Krempa wrote:
On Tue, Apr 14, 2020 at 12:36:56 -0500, Eric Blake wrote:
On 4/14/20 4:22 AM, Peter Krempa wrote:
It was never implemented and for now I don't think there's demand to do
it. Remove the reference.
https://bugzilla.redhat.com/show_bug.cgi?
clined to NACK this patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
the only correct behavior.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
rejecting all other explicit formats (note that
this is only for QemuOpts usage; there is no change to the QAPI to
allow a format through -blockdev).
Signed-off-by: Eric Blake
---
block/sheepdog.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/block
For now, this is a mechanical addition; all callers pass false. But
the next patch will use it to improve 'qemu-img rebase -u' when
selecting a backing file with no format.
Signed-off-by: Eric Blake
Reviewed-by: Peter Krempa
Reviewed-by: Ján Tomko
---
include/block/block.h | 4 ++-
change to qcow messages; note that the fact that we now
make a probed format of 'raw' explicit now results in a double
warning, but no one should be creating new qcow images so it is not
worth cleaning up.
Signed-off-by: Eric Blake
---
docs/system/deprecated.rst | 20 +
rejecting all other explicit formats (note that this
is only for QemuOpts usage; there is no change to the QAPI to allow a
format through -blockdev).
Signed-off-by: Eric Blake
---
block/vmdk.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/block/vmdk.c b/block/vmdk.c
index
unrelated to the
backing chain.
Signed-off-by: Eric Blake
---
docs/system/deprecated.rst | 12
docs/tools/qemu-img.rst| 4
block/qcow2.c | 5 +
tests/qemu-iotests/061.out | 1 +
tests/qemu-iotests/082.out | 2 ++
5 files changed, 24 insertions(+)
diff -
Note that this is only for QemuOpts usage; there is no
change to the QAPI to allow a format through -blockdev.
Add a new iotest 290 just for qcow, to demonstrate the new warning.
Signed-off-by: Eric Blake
---
block/qcow.c | 16 -
tests/qemu-iotests/290
.1/ as the start of the deprecation clock.
Eric Blake (7):
sheepdog: Add trivial backing_fmt support
vmdk: Add trivial backing_fmt support
qcow: Tolerate backing_fmt=, but warn on backing_fmt=raw
qcow2: Deprecate use of qemu-img amend to change backing file
iotests: Specify explicit back
ile?
Otherwise,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
On 3/12/20 2:28 PM, Eric Blake wrote:
v3 was here:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg01730.html
In v4:
- old patch 1 was reworked into new patch 1-3, with stricter rules
on which backing formats are accepted [Kevin]
- patch 4 is new: amend is handled differently from
file changed, 4 insertions(+)
Reviewed-by: Eric Blake
diff --git a/src/conf/checkpoint_conf.c b/src/conf/checkpoint_conf.c
index 26bcfc16b7..d557fada49 100644
--- a/src/conf/checkpoint_conf.c
+++ b/src/conf/checkpoint_conf.c
@@ -550,6 +550,10 @@ virDomainCheckpointRedefinePrep(virDomainObjPtr
+), 9 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
/qemu/qemu_checkpoint.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
We just did the same thing for CheckpointDelete :)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
rempa
Would be nice to mention which commit id introduced the bug.
---
src/qemu/qemu_backup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake
diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c
index 8b66ee8d1f..9a056fa407 100644
--- a/src/qemu/qemu_bac
/qemu/qemu_checkpoint.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake
diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
index 76f10a701e..62b6e87b53 100644
--- a/src/qemu/qemu_checkpoint.c
+++ b/src/qemu/qemu_checkpoint.c
@@ -771,15 +7
compile with clang:
As pointed out here, my recommendation is for John to send a v2 pull
request with one more patch added:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg05969.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization
s://github.com/GNOME/glib/commit/b41bff1f
(2.57.2) added G_GNUC_UNUSED to all of the functions declared during
G_DEFINE_AUTOPTR_CLEANUP_FUNC. Which version of glib is on the NetBSD
machine?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
d to shut the compiler up?
On IRC, danpb pointed me to libvirt's solution:
https://libvirt.org/git/?p=libvirt.git;a=commit;h=44e7f029
Maybe we just write our own macro wrapper around
G_DEFINE_AUTOPTR_CLEANUP_FUNC which takes care of adding necessary
annotations and use that instead (and our m
dded if the variable already contains some
value. Similarly, appending an empty string does not
add a trailing space.
[/quote]
This patch tries a new trick to get a single whitespace by
getting make to expand two non-existant variables separated
by a space.
Reviewed-by: Eric Blake
https://
On 3/12/20 2:28 PM, Eric Blake wrote:
Creating an image that requires format probing of the backing image is
inherently unsafe (we've had several CVEs over the years based on
probes leaking information to the guest on a subsequent boot, although
these days tools like libvirt are aware o
On 3/9/20 10:31 AM, Kashyap Chamarthy wrote:
On Fri, Mar 06, 2020 at 04:51:21PM -0600, Eric Blake wrote:
Creating an image that requires format probing of the backing image is
inherently unsafe (we've had several CVEs over the years based on
+qemu-img backing file without format (
BlockdevCreateOptions *create_options = NULL;
-QDict *qdict, *location_qdict;
+QDict *qdict = NULL, *location_qdict;
Visitor *v;
-char *redundancy;
+char *redundancy = NULL;
Error *local_err = NULL;
int ret;
char *backing_fmt = NULL;
--
Eric Blake, Principal Softwa
ould be creating new qcow images so it is not
worth cleaning up.
Signed-off-by: Eric Blake
---
docs/system/deprecated.rst | 19 +++
block.c| 21 -
qemu-img.c | 2 +-
tests/qemu-iotests/114 | 11 +++
tests/qemu-
For now, this is a mechanical addition; all callers pass false. But
the next patch will use it to improve 'qemu-img rebase -u' when
selecting a backing file with no format.
Signed-off-by: Eric Blake
Reviewed-by: Peter Krempa
Reviewed-by: Ján Tomko
---
include/block/block.h | 4 ++-
rejecting all other explicit formats (note that
this is only for QemuOpts usage; there is no change to the QAPI to
allow a format through -blockdev).
Signed-off-by: Eric Blake
---
block/sheepdog.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/block/sheepdog.c b/block
v3 was here:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg01730.html
In v4:
- old patch 1 was reworked into new patch 1-3, with stricter rules
on which backing formats are accepted [Kevin]
- patch 4 is new: amend is handled differently from rebase [Kashyap]
- rebase to master
Eric
rejecting all other explicit formats (note that this
is only for QemuOpts usage; there is no change to the QAPI to allow a
format through -blockdev).
Signed-off-by: Eric Blake
---
block/vmdk.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/block/vmdk.c b/block/vmdk.c
index
Note that this is only for QemuOpts usage; there is no
change to the QAPI to allow a format through -blockdev.
Add a new iotest 290 just for qcow, to demonstrate the new warning.
Signed-off-by: Eric Blake
---
block/qcow.c | 16 -
tests/qemu-iotests/290
unrelated to the
backing chain.
Signed-off-by: Eric Blake
---
docs/system/deprecated.rst | 12
docs/tools/qemu-img.rst| 4
block/qcow2.c | 5 +
tests/qemu-iotests/061.out | 1 +
tests/qemu-iotests/082.out | 2 ++
5 files changed, 24 insertions(+)
diff -
t was deleted.
Signed-off-by: Peter Krempa
---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
leave it disabled rather than
trying to re-enable it (just to have it be re-disabled on the retry
attempt).
But on the grounds of trying to leave things as close to what they were
before failure, I'm okay with this patch, if you can straighten out my
confusion on naming.
Reviewed-by: E
adOnly(vm, job->data.commit.base, asyncJob) < 0)
+return -1;
Earlier in the series, you ignored failure to restore readonly (leaving
things read-write isn't ideal, but isn't a show-stopper to correct
operation). Any reason why that use was different than this where yo
job->data.commit.base,
+ blockNamedNodeData,
+ &actions,
+
job->data.commit.disabledBitmapsBase) < 0)
+ return -1;
+}
+
Reviewed-by: Eric Blake
he same whether we write bits in one or multiple bitmaps as part of the
commit operation). But code wise, this looks accurate.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
201 - 300 of 17651 matches
Mail list logo
