flags & VIR_MIGRATE_OFFLINE))" conditional, so let's move
it there.
Fixes: 156e99f686690855be4e45d9b8b3194191a8bc31
Signed-off-by: Laine Stump
---
src/qemu/qemu_migration.c | 34 ++
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_mig
off-by: Laine Stump
---
src/qemu/qemu_migration.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 6fc5791f61..4ad5b7af39 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -148
On 7/20/22 12:05 PM, Eugenio Pérez wrote:
since qemu 6.0, if migration is blocked for some reason, 'query-migrate'
will return an array of error strings describing the migration blockers.
This can be used to check whether there are any devices blocking
migration, etc.
Enable qemu monitor to
On 7/20/22 12:05 PM, Eugenio Pérez wrote:
vDPA devices will be migratable soon. Since they are not migratable
before qemu 6.0, and qemu pre-6.0 didn't have the capability of asking
for migration blockers, let it hardcoded in that case.
Otherwise, ask qemu about the explicit blocker.
I
On 7/20/22 12:05 PM, Eugenio Pérez wrote:
since qemu 6.0, if migration is blocked for some reason, 'query-migrate'
will return an array of error strings describing the migration blockers.
This can be used to check whether there are any devices blocking
migration, etc.
Enable
This all looks good except a couple small nits that I've noted in
separate messages for the individual patches.
I've already made these minor changes locally and pushed them here:
https://gitlab.com/lainestump/libvirt/-/commits/REVIEW
If it all looks okay to you, I'll push it as soon as I
On 7/19/22 2:38 PM, Eugenio Perez Martin wrote:
On Tue, Jul 19, 2022 at 6:43 PM Laine Stump wrote:
On 7/19/22 12:01 PM, Laine Stump wrote:
On 7/19/22 11:09 AM, Eugenio Perez Martin wrote:
On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote:
On 7/18/22 11:15 AM, Jiri Denemark wrote:
On Mon
On 7/19/22 12:01 PM, Laine Stump wrote:
On 7/19/22 11:09 AM, Eugenio Perez Martin wrote:
On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote:
On 7/18/22 11:15 AM, Jiri Denemark wrote:
On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote:
On Mon, Jul 18, 2022 at 10:25 AM Jiri
On 7/19/22 11:09 AM, Eugenio Perez Martin wrote:
On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote:
On 7/18/22 11:15 AM, Jiri Denemark wrote:
On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote:
On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote:
Which in ideal case would
On 7/18/22 11:15 AM, Jiri Denemark wrote:
On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote:
On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote:
Which in ideal case would mean only a QMP command (such as
hotplugging a non-migratable device) is the only way to add migration
as already acked it, but still
Reviewed-by: Laine Stump
+++-
1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Laine Stump
(too bad there's not an elegant automated way of pointing out when a new
field is added that can't be updated at runtime)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 24df66cc9f
On 5/12/22 2:00 PM, Daniel P. Berrangé wrote:
On Wed, May 11, 2022 at 11:41:51AM -0400, Eric Garver wrote:
This series fixes routed networks when a newer firewalld (>= 1.0.0) is
present [1]. Firewalld 1.0.0 included a change that disallows implicit
forwarding between zones [2]. libvirt was
On 5/12/22 12:53 PM, Eric Garver wrote:
On Wed, May 11, 2022 at 05:15:25PM +0100, Daniel P. Berrangé wrote:
On Wed, May 11, 2022 at 11:41:52AM -0400, Eric Garver wrote:
Convert the existing behavior into policies.
Has this split of .zone vs .policy been something firewalld
always supported,
properly testing
this aspect in the past
Daniel P. Berrangé (2):
nwfilter: drop support for legacy iptables match syntax
nwfilter: drop support for legacy iptables conntrack direction
Reviewed-by: Laine Stump
for both.
ual
patch mails:
https://listman.redhat.com/archives/libvir-list/2022-March/229089.html
Anyone else who responds to any of the mail on this thread should fix
the qemu-devel address accordingly.
On 3/8/22 10:33 AM, Laine Stump wrote:
On 3/8/22 1:39 AM, Ani Sinha wrote:
Changelog:
v2 - rebased
On 3/8/22 1:39 AM, Ani Sinha wrote:
Changelog:
v2 - rebased the patch series to latest master.
I am re-introducing the patchset for which got
reverted here few months back:
https://www.spinics.net/linux/fedora/libvir/msg224089.html
The reason for the reversal was that there seemed to be some
On 3/2/22 3:29 AM, Peter Krempa wrote:
On Tue, Mar 01, 2022 at 09:40:30 -0700, Jim Fehlig wrote:
On 2/17/22 04:56, Michal Privoznik wrote:
When I implemented user aliases I've invented this
virDomainDefFeatures flag so that individual drivers can signal
support for user provided aliases. The
On 2/25/22 10:30 AM, Daniel P. Berrangé wrote:
The virNWFilterTechDriverForName & virNWFilterUpdateInstantiateFilter
methods are only used within the same source file, so don't need to
be exported.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
(again, I didn't even
-by: Daniel P. Berrangé
The proof is in the successful compile without it :-)
Reviewed-by: Laine Stump
to that short
period (and certainly never across a call to the NWFilter binding API)
I'm fairly certain this (along with the previous patch) is safe from
creating any new deadlocks.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
---
src/lxc/lxc_driver.c | 6 --
src/qemu
serialized for the whole VM, but
rather for each NIC. This should not be a problem since
the virt drivers already need to cope with tearing down
a partially created VM where only some of the NICs are
setup.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
(I considered this patch
On 2/25/22 10:30 AM, Daniel P. Berrangé wrote:
The virNWFilterLockIface method is only called from one place,
the learnIPAddressThread method.
nwfilter_gentech_driver.c:virNWFilterDoInstantiate() and
_virNWFilterTeardownFilter() also call virNWFilterLockIface.
And there is this call chain
On 2/3/22 10:52 AM, Michal Prívozník wrote:
On 2/3/22 15:45, Laine Stump wrote:
On 2/2/22 1:04 PM, Michal Prívozník wrote:
Laine, any thoughts?
I somehow thought this had already been pushed, so I was surprised when
it showed up again :-/
I think the only issue I had before was that I
On 2/2/22 1:04 PM, Michal Prívozník wrote:
Laine, any thoughts?
I somehow thought this had already been pushed, so I was surprised when
it showed up again :-/
I think the only issue I had before was that I thought the new unit
tests were more testing the test setup than the actual code,
-by: Laine Stump
but beware the slippery slope (e.g. - if you're going to move this one,
then what about virIndexToDiskName and virDiskNameToIndex - they just
operate on a string too...). Do we really want such specific functions
in a file made for generally useful string functions? (Maybe we
On 1/27/22 4:33 PM, Ján Tomko wrote:
We used to validate that the first character of the hostname is a
letter. Later, RFC1123 relaxed the requirements to allow a number
as well.
Drop the validation completely, since we do not care about the
following characters, and neither does dnsmasq (even
in
vim).
Signed-off-by: Michal Privoznik
Reviewed-by: Laine Stump
On 1/14/22 3:29 PM, Ján Tomko wrote:
On a Friday in 2022, Laine Stump wrote:
Since it's Friday and we're talking about personal preferences - I
personally dislike the use of i and j (and anything else with a single
letter) as variable names, because it makes using a text search for
occurences
On 1/14/22 10:56 AM, Ján Tomko wrote:
On a Friday in 2022, Tim Wiederhake wrote:
This was not mentioned before.
Signed-off-by: Tim Wiederhake
---
docs/coding-style.rst | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/coding-style.rst b/docs/coding-style.rst
index
On 1/4/22 7:57 AM, Daniel P. Berrangé wrote:
On Sun, Jan 02, 2022 at 09:41:37PM -0500, Laine Stump wrote:
I'm currently working on switching the backend of the network driver from
using iptables to using nftables. Due to some functionality that is not
available with nftables (the rule
...)
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2036895
Signed-off-by: Michal Privoznik
Reviewed-by: Laine Stump
---
src/lxc/lxc_driver.c | 10 +-
src/qemu/qemu_driver.c | 8
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/lxc/lxc_driver.c b/src
(this probably will make no sense to anyone who hasn't spent time
looking at daemonConfig*, in which case you can go ahead and hit Delete
now. At any rate I'm just tossing this out into the void to see if
anyone has any ideas/opinions, so in *any* case feel free to hit delete!)
Happy New
year's end
Ugh, I had managed to repress the memories of this, and now it's come
back :-O
tests: virtimetest: Mention GLib version containing fix
tests/virtimetest.c | 58 ++---
1 file changed, 28 insertions(+), 30 deletions(-)
Reviewed-by: Laine
I noted in 03/17 and 08/17
Reviewed-by: Laine Stump
/me ponders what I should idly suggest be removed next...
On 12/14/21 2:09 PM, Ján Tomko wrote:
Introduced by:
"Introduced by dnsmasq commit:"
commit c4cd95df68b573b63d234ecdb675228657d65353
Author: Simon Kelley
CommitDate: 2013-10-10 20:58:11 +0100
Add --ra-param and remove --force-fast-ra
git describe: v2.67rc3-3-gc4cd95d contains:
On 12/14/21 2:09 PM, Ján Tomko wrote:
All the capabilities should be supported in 2.67.
Make this the minimum version, since even the oldest
distros we support have moved on:
Debian 8: 2.72
CentOS 7: 2.76
Ubuntu 18.04: 2.79
Signed-off-by: Ján Tomko
---
src/util/virdnsmasq.c | 13
On 12/14/21 2:09 PM, Ján Tomko wrote:
Signed-off-by: Ján Tomko
---
src/util/virdnsmasq.c | 22 ++
src/util/virdnsmasq.h | 4
2 files changed, 2 insertions(+), 24 deletions(-)
diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c
index efe65174f8..016d9d64a8
On 12/13/21 1:58 PM, Ján Tomko wrote:
Use two variables with automatic cleanup instead of reusing one.
Remove the pointless cleanup label.
Signed-off-by: Ján Tomko
---
src/util/virdnsmasq.c | 37 -
1 file changed, 16 insertions(+), 21 deletions(-)
diff
is more generally useful.
Signed-off-by: Laine Stump
---
src/libvirt_private.syms | 1 +
src/util/viriptables.c | 41 +
src/util/virsocketaddr.c | 44
src/util/virsocketaddr.h | 3 +++
4 files changed, 53 insertions
This function doesn't have anything to do with manipulating
virFirewall objects, but rather should be called in response to dbus
events about the firewalld service. Move this function into
virfirewalld.c, and rename it to virFirewallDSynchronize().
Signed-off-by: Laine Stump
---
src
This function doesn't need to check for a backend - synchronization
with firewalld should always be done whenever firewalld is registered
and available, not just when the firewalld backend is selected.
Signed-off-by: Laine Stump
---
src/util/virfirewall.c | 54
Since the currentBackend (direct vs. firewalld) setting is no longer
used for anything, we don't need to set it (either explicitly from
tests, or implicitly during init), and can completely remove it.
Signed-off-by: Laine Stump
---
src/libvirt_private.syms | 1 -
src/util/virfirewall.c
Since commit b19863640 both useful cases of the switch statement in
this function have made the same call (and the other/default case is
just an error that can never happen). Eliminate the switch to help
eliminate use of currentBackend.
Signed-off-by: Laine Stump
---
src/util/virfirewall.c | 25
There is no longer anything to initialize at binary startup time.
Signed-off-by: Laine Stump
---
src/util/virfirewall.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c
index 98d78857df..70092f2ef6 100644
to
execute it, which seems like it should just as good (or at least good
enough, especially since we eventually want to get rid of iptables
completely).
So let's remove it!
Signed-off-by: Laine Stump
---
src/util/virfirewall.c | 25 -
1 file changed, 25 deletions(-)
diff
he
iptables/nftables operators they signify, i.e. INSERT and DELETE, just
to eliminate confusion (in particular, in case someone ever decides
that we need to also use the nftables "add" operator, which appends a
rule to a chain rather than inserting it at the beginning of the
chain).
S
-off-by: Laine Stump
---
tests/networkxml2firewalltest.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/networkxml2firewalltest.c b/tests/networkxml2firewalltest.c
index e4f86bc3fc..68a82e60d6 100644
--- a/tests/networkxml2firewalltest.c
+++ b/tests/networkxml2firewalltest.c
Several functions were simplified to remove the only cleanup code at
the cleanup label, making it unnecessary.
Signed-off-by: Laine Stump
---
tests/virfirewalltest.c | 92 ++---
1 file changed, 31 insertions(+), 61 deletions(-)
diff --git a/tests
e none of the tests
use dbus (for now we ensure that by explicitly setting the virfirewall
backend to DIRECT before any of the tests have run. Eventually the
concept of a "firewalld backend" will disappear completely, but that's
for another patch.)
Signed-off-b
all
object rather than per-process) so almost all of the existing code
won't be applicable anyway.)
Laine Stump (12):
network: eliminate code that uses default iptables chains
util: rename/move iptablesFormatNetwork to
virSocketAddrFormatWithPrefix
util: rename iptables operators to some
it is now
safe to remove this code.
Signed-off-by: Laine Stump
---
src/libvirt_private.syms | 1 -
src/network/bridge_driver_linux.c | 37 ++-
src/util/viriptables.c| 104 --
src/util/viriptables.h| 2 -
4 files changed, 49
further to virPCIGetNetName(),
where it really belongs!
Resolves: https://bugzilla.redhat.com/2025432
Fixes: 795e9e05c3b6b9ef3abe6f6078a6373a136ec23b
Signed-off-by: Laine Stump
---
src/util/virnetdev.c | 6 +-
src/util/virpci.c| 16 ++--
src/util/virpci.h| 2 +-
3 files
, and concentrates all
calls to virNetDevGetPhysPortID() into a single function
(virPCIGetNetName(), duh).
Laine Stump (2):
util: fix erroneous requirement for phys_port_id to get ifname of a VF
util: call virNetDevGetPhysPortID() in less places
src/util/virnetdev.c | 24 +++-
src
to virNetDevGetPhysPortID() in
all the callers of virPCIGetNetName(), lets just have all those
callers send the NetDevName whose physPortID they want down to
virPCIGetNetName(), and let virPCIGetNetName() call
virNetDevGetPhysPortID().
Signed-off-by: Laine Stump
---
src/util/virnetdev.c | 18 ++---
src/util
Instead, add a bool getIfName to the args of
virNetDevGetVirtualFunctionsFull() so that we can still get the ifname
filled in when pfPhysPortID is NULL.
Resolves: https://bugzilla.redhat.com/2025432
Fixes: 795e9e05c3b6b9ef3abe6f6078a6373a136ec23b
Signed-off-by: Laine Stump
---
On one hand
On 11/15/21 1:59 PM, Dmitrii Shcherbakov wrote:
[...]
diff --git a/tests/virnetdevtest.c b/tests/virnetdevtest.c
index aadbeb1ef4..bdaa94e83c 100644
--- a/tests/virnetdevtest.c
+++ b/tests/virnetdevtest.c
Maybe I'm just looking at it too superficially, but it seems like these
test cases are
On 11/8/21 5:18 AM, Michal Prívozník wrote:
On 11/3/21 4:11 AM, jx8zjs wrote:
From: zhangjl02
Fix bug 1826168: bridge type network with ovs bridge can start with Qos
setting which do not take any effect
Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=1826168
Signed-off-by: zhangjl02
On 10/25/21 11:32 AM, Jiri Denemark wrote:
One of the paths returned -1 directly without going through the cleanup
section.
Signed-off-by: Jiri Denemark
Reviewed-by: Laine Stump
indentation for the above function call while at it.
Signed-off-by: Ani Sinha
Reviewed-by: Laine Stump
and pushed.
---
src/qemu/qemu_command.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index d6df50ec73
tplug on pci-root
controller")
Signed-off-by: Ani Sinha
Reviewed-by: Laine Stump
and pushed.
---
src/qemu/qemu_validate.c| 6 +++---
.../pc-i440fx-acpi-root-hotplug-disable.x86_64-5.1.0.err| 2 +-
.../pc-i440fx-acpi-root-hotplug-enable.x86_64
On 10/21/21 1:06 PM, Ján Tomko wrote:
On a Thursday in 2021, Laine Stump wrote:
This reverts commit da896d440c7267e0b4575e4a3f2780bebf3fbfca.
Signed-off-by: Laine Stump
---
...i-hotplug-bridge-disable.x86_64-latest.xml | 36 -
.../pc-i440fx-acpi-hotplug-bridge-disable.xml | 1
litiesdata/caps_6.2.0.x86_64.xml
This file was added after the original commit that we
are reverting, so had to be manually edited to remove
the two capabilities.
Signed-off-by: Laine Stump
---
src/qemu/qemu_capabilities.c | 8 ++--
src/qemu/qemu_capa
the contents don't matter.
tests/qemuxml2argvtest.c
* change in context around removed chunk
Signed-off-by: Laine Stump
---
src/qemu/qemu_command.c | 20 ---
.../aarch64-acpi-hotplug-bridge-disable.err | 1 -
...pc-i440fx-acpi-hotplug-bridge-disable.args | 31
This reverts commit 7300ccc9b3eddb38306868534e7fc2d505a0a13c.
Signed-off-by: Laine Stump
---
docs/formatdomain.rst | 29 --
docs/schemas/domaincommon.rng | 15
src/conf/domain_conf.c| 89 +--
src/conf
This reverts commit 7d074c56830c5d435f87667299cc102650dbbb4f.
Signed-off-by: Laine Stump
---
src/qemu/qemu_validate.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index d3b9691db5..0cb4542efd 100644
--- a/src/qemu
This reverts commit 5ee4f3e1d4f173f7e1b64b745ab9ef5dc8c8f393.
Signed-off-by: Laine Stump
---
NEWS.rst | 8
1 file changed, 8 deletions(-)
diff --git a/NEWS.rst b/NEWS.rst
index f3b9e5f0cb..bbed7a8228 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -32,14 +32,6 @@ v7.9.0 (unreleased
-latest.args
These files are unrelated to the functionality we need to remove, so
they weren't removed, and the associated test cases weren't removed
from qemuxml2argvtest.c
Signed-off-by: Laine Stump
---
...i-hotplug-bridge-enable.x86_64-latest.args | 34 -
...cpi-hotplug-bridge
to use JSON on the commandline at a later
commit than the commit being reverted here (where they were changed
to use latest caps, but the patches to use JSON on the commandline
hadn't been committed yet).
Signed-off-by: Laine Stump
---
...> aarch64-acpi-hotplug-bridge-disable.err} |
This reverts commit da896d440c7267e0b4575e4a3f2780bebf3fbfca.
Signed-off-by: Laine Stump
---
...i-hotplug-bridge-disable.x86_64-latest.xml | 36 -
.../pc-i440fx-acpi-hotplug-bridge-disable.xml | 1 +
...pi-hotplug-bridge-enable.x86_64-latest.xml | 36 -
.../pc-i440fx
This reverts commit bdc3e8f47be108fa552b72a6d913528869e61097.
Signed-off-by: Laine Stump
---
src/qemu/qemu_validate.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 1ffc261c58..d3b9691db5 100644
--- a/src
t course of action for libvirt is to
revert the current , wait until QEMU settles down
with a new workable set of switches, and then re-do libvirt support
based on that.
Laine Stump (10):
Revert "qemu: capabilities: Remove
QEMU_CAPS_PIIX4_ACPI_HOTPLUG_BRIDGE"
Revert "qemuxml
it.
The original commits began with commit
58ba0f6a3d7342fba29edbbf2bb9cb5497c870e5. The other original commit
IDs are documented in each revert commit.
Signed-off-by: Laine Stump
---
src/qemu/qemu_capabilities.c | 4 +++-
src/qemu/qemu_capabilities.h | 3 ++-
src
On 10/18/21 12:31 AM, Ani Sinha wrote:
Error messages must conform to spec as specified here:
https://www.libvirt.org/coding-style.html#error-message-format
This change encloses format specifiers in quotes and unbreaks error messages.
Fixes: 8eadf82fb5 ("conf: introduce option to
Reviewed-by: Laine Stump
I'm going to push this later today after I put it through CI (and get
back from a mandatory 4 hour drive).
On 10/8/21 2:42 AM, Ani Sinha wrote:
changelog:
v7: Laine's suggestions from v6 incorporated. rebased the patchset to latest
master.
v6: rebased
On 10/5/21 1:51 AM, Ani Sinha wrote:
This change introduces a new libvirt sub-element under that
can be used to configure all pci related features.
Currently the only sub-sub element supported by this sub-element is
'acpi-bridge-hotplug' as shown below:
The above option is
ACPI based
PCI hotplug for cold plugged bridges. It is only applicable for x86
guests using qemu driver.
Reviewed-by: Laine Stump
+
* **Improvements**
* **Bug fixes**
low
this one).
Assuming that is the case, then this patch also seems fine to me
Reviewed-by: Laine Stump
I may want to make the documentation in formatdomain.rst a bit more
clear, but I can do that as a separate patch after these (since I know
you're leaving on a vacation so won't be arou
On 10/7/21 11:12 PM, Laine Stump wrote:
@@ -27932,6 +27995,30 @@ virDomainDefFormatFeatures(virBuffer *buf,
virDomainIBSTypeToString(def->features[i]));
break;
+ case VIR_DOMAIN_FEATURE_PCI:
+ if (def->feat
use all of Tim's
nice helper functions) in order to detect unknown subelements at parse
time (which we usually don't do (and which has always kind of bothered
me)), or there was some issue that required more thought so it was left
as an exercise for later, in which case this new function cou
e files are required.
Signed-off-by: Ani Sinha
Reviewed-by: Laine Stump
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 2 ++
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.x86_
On 10/3/21 10:10 PM, Douglas, William wrote:
On Sun, 2021-10-03 at 15:52 -0400, Laine Stump wrote:
On 10/3/21 3:43 PM, Laine Stump wrote:
cleanup:
+ if (mon)
+ virCHMonitorClose(mon);
Oops, I also meant to point out that the "if (mon)" is unnecessary
here,
because (a
"piix4.acpi-root-pci-hotplug", /*
QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG */
Since the enum matched the capability name exactly except that one is
"piix4" and the other is "PIIX", I changed the enum to match this new
name before pushing.
Reviewed-by: Laine Stump
Will be pushed in a few minute
On 10/4/21 1:05 PM, Andrea Bolognani wrote:
On Mon, Oct 04, 2021 at 10:19:17PM +0530, Ani Sinha wrote:
On Mon, 4 Oct 2021, Andrea Bolognani wrote:
On Fri, Oct 01, 2021 at 02:59:45PM +0530, Ani Sinha wrote:
+++ b/src/qemu/qemu_capabilities.c
+ /* 410 */
+
On 10/3/21 3:43 PM, Laine Stump wrote:
cleanup:
+ if (mon)
+ virCHMonitorClose(mon);
Oops, I also meant to point out that the "if (mon)" is unnecessary here,
because (as with all similar functions in libvirt) virCHMonitorClose()
can be called with a null argument, and
up;
+return -1;
}
return 0;
-
- cleanup:
-virJSONValueFree(memory);
-return -1;
}
static int
Reviewed-by: Laine Stump
I'll add the extra empty lines before pushing.
can resend
two separate patches for it, with log messages of your choice. Let me
know which you prefer.
Otherwise:
Reviewed-by: Laine Stump
Signed-off-by: William Douglas
---
src/ch/ch_monitor.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/ch
On 10/1/21 2:12 PM, William Douglas wrote:
In virCHMonitorBuildKernelRelatedJson there are two cases of json
value objects being lost after the pointer being redefined. This
change removes the needless redefinition.
Signed-off-by: William Douglas
Reviewed-by: Laine Stump
On 10/1/21 5:29 AM, Ani Sinha wrote:
changelog:
v7: rebased the patches post libvirt release 7.8. Adjusted NEWS.rst to reflect
7.9 (unreleased)
version. Changed version info for new config option in formatdomain.rst as
well.
Added reviewed-by tags. Also in formatdomain.rst added
On 9/27/21 3:30 PM, Dmitrii Shcherbakov wrote:
[...]
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
[...]
+
+static void
+virNodeDeviceCapVPDResourceFormat(virBuffer *buf, virPCIVPDResource *res)
+{
+GEnumValue *resRype = NULL;
+void (*resFormatFunc)(virBuffer
On 10/1/21 5:57 AM, Daniel P. Berrangé wrote:
On Mon, Sep 27, 2021 at 10:30:47PM +0300, Dmitrii Shcherbakov wrote:
[...]
+GType
+vir_pci_vpd_resource_type_get_type(void)
I know you had asked about using under_scored_naming in a reply to Peter
pointing out "non-standard" names in V3 of
On 9/30/21 1:09 PM, Laurent Vivier wrote:
If we want to save a snapshot of a VM to a file, we used to follow the
following steps:
1- stop the VM:
(qemu) stop
2- migrate the VM to a file:
(qemu) migrate "exec:cat > snapshot"
3- resume the VM:
(qemu) cont
After that we can restore
On 9/30/21 2:16 AM, Ani Sinha wrote:
On Fri, Sep 24, 2021 at 2:16 AM Laine Stump wrote:
On 9/11/21 11:26 PM, Ani Sinha wrote:
The above two options are only available for qemu driver and that too for x86
guests only. Both of them are global options.
``acpi-hotplug-bridge`` option enables
On 9/28/21 12:54 PM, Ani Sinha wrote:
On Tue, Sep 28, 2021 at 10:17 PM Laine Stump <mailto:la...@redhat.com>> wrote:
On 9/28/21 4:44 AM, Daniel P. Berrangé wrote:
> On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote:
>> This change introduces l
On 9/28/21 4:44 AM, Daniel P. Berrangé wrote:
On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote:
This change introduces libvirt xml support for the following two pm options:
+``acpi-hotplug-bridge``
+ :since:`Since 7.8.0` This option enables or disables BIOS ACPI based
On 9/27/21 12:54 AM, Ani Sinha wrote:
On Sun, 26 Sep 2021, Laine Stump wrote:
+QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG);
+DO_TEST_PARSE_ERROR_NOCAPS("pc-i440fx-acpi-root-hotplug-enable");
Ah, now I understand the origin of pc-i440fx-acpi-root-hotplug-
On 9/27/21 4:05 AM, Ján Tomko wrote:
On a Monday in 2021, Ani Sinha wrote:
This change introduces libvirt xml support to enable/disable hotplug
on the
pci-root controller. It adds a 'target' subelement for the pci-root
controller
with a 'hotplug' property. This property can be used to enable
On 9/26/21 10:35 AM, Ani Sinha wrote:
This change adds qemu backend command line support for enabling or disabling
hotplug on the pci-root controller using the 'target' sub-element of the
pci-root controller as shown below:
'' is only valid for pc (x86) machines and turns on
the
On 9/26/21 10:35 AM, Ani Sinha wrote:
This change introduces libvirt xml support to enable/disable hotplug on the
pci-root controller. It adds a 'target' subelement for the pci-root controller
with a 'hotplug' property. This property can be used to enable or disable
hotplug for the pci-root
es files has already
been updated as a part of regular refreshing them when a new qemu version is
released. Hence, no updates to those files are required.
Signed-off-by: Ani Sinha
Reviewed-by: Laine Stump
(also needs rebasing due to the other capability added)
---
src/qemu
201 - 300 of 6183 matches
Mail list logo
