even if I use user networking, guestfwd will create a separate
netdev, which isn't connected to any peer (both at cold and hot plug
time)
How is it supposed to work?
thanks
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
wait' with client sockets.
Fixes: 767abe7f49e8be14d29da5db3527817b5d696a52
Cc: Daniel P. Berrangé
Signed-off-by: Marc-André Lureau
---
chardev/char-socket.c | 12
qemu-deprecated.texi | 5 +
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/chardev/char-so
On Mon, Apr 15, 2019 at 6:27 PM Daniel P. Berrangé wrote:
>
> On Mon, Apr 15, 2019 at 06:21:29PM +0200, Marc-André Lureau wrote:
> > Commit 767abe7 ("chardev: forbid 'wait' option with client sockets")
> > is a bit too strict. Current libvirt always set wai
wait' with client sockets.
Fixes: 767abe7f49e8be14d29da5db3527817b5d696a52
Cc: Daniel P. Berrangé
Signed-off-by: Marc-André Lureau
---
chardev/char-socket.c | 10 +++---
qemu-deprecated.texi | 5 +
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/chardev/char-so
a
> platform portability layer, so that we can add impls for non-Linux based
> equivalents in future.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Marc-André Lureau
> ---
> MAINTAINERS | 7 +
> Makefile.objs | 2 +-
> include/qemu/fil
Hi
On Mon, Nov 12, 2018 at 8:03 PM Daniel P. Berrangé wrote:
>
> On Wed, Nov 07, 2018 at 07:13:11PM +0400, Marc-André Lureau wrote:
> > As discussed during "[PATCH v4 00/29] vhost-user for input & GPU"
> > review, let's define a common set of backend conventi
Hi
On Thu, Nov 15, 2018 at 5:56 PM Michal Privoznik wrote:
>
> On 11/15/2018 12:55 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Hi,
> >
> > This is an alternative series from "[PATCH 0/5] Use memfd if
> > poss
On Thu, Nov 15, 2018 at 5:55 PM Michal Privoznik wrote:
>
> On 11/15/2018 12:55 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Check availability of "-object memory-backend-memfd".
> >
> > Reviewed-by: John Ferlan
> &
Hi
On Thu, Nov 8, 2018 at 4:40 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Mon, Sep 17, 2018 at 5:15 PM wrote:
> >
> > From: Marc-André Lureau
> >
> > Hi,
> >
> > This is an alternative series from "[PATCH 0/5] Use memfd if
> > possible&
Hi
On Mon, Sep 17, 2018 at 5:15 PM wrote:
>
> From: Marc-André Lureau
>
> Hi,
>
> This is an alternative series from "[PATCH 0/5] Use memfd if
> possible". Instead of automatically using memfd for anonymous memory
> when available (as suggested by Daniel),
clude/sysemu/vhost-user-backend.h
diff --git a/docs/interop/vhost-user.json b/docs/interop/vhost-user.json
new file mode 100644
index 00..91b5bf499e
--- /dev/null
+++ b/docs/interop/vhost-user.json
@@ -0,0 +1,219 @@
+# -*- Mode: Python -*-
+#
+# Copyright (C) 2018 Red Hat, Inc.
+#
+# Authors
Hi
On Wed, Oct 31, 2018 at 8:05 PM Daniel P. Berrangé wrote:
>
> On Wed, Oct 31, 2018 at 07:44:36PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, Oct 16, 2018 at 4:14 PM Daniel P. Berrangé
> > wrote:
> > > > > It just reinv
Hi
On Tue, Oct 16, 2018 at 4:14 PM Daniel P. Berrangé wrote:
> > > It just reinvents the chardev unix socket syntax, but in a
> > > different adhoc manner, which is repeating the mistake we have
> > > made time & again in QEMU. Using QAPI we can directly accept
> > > the ChardevSocket syntax we a
Hi
On Fri, Oct 12, 2018 at 1:56 PM Daniel P. Berrangé wrote:
>
> On Fri, Oct 12, 2018 at 01:43:39PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Thu, Oct 11, 2018 at 7:49 PM Daniel P. Berrangé
> > wrote:
> > >
> > > Adding Markus since we&
Hi
On Thu, Oct 11, 2018 at 7:49 PM Daniel P. Berrangé wrote:
>
> Adding Markus since we're talking about new CLI argument and capability
> reporting standards.
>
> On Fri, Sep 14, 2018 at 05:52:30PM +0400, Marc-André Lureau wrote:
> > As discussed during "[PATCH
Hi
On Fri, Oct 5, 2018 at 7:59 PM Hoffmann, Gerd wrote:
>
> Hi,
>
> > For example, "virgl" support may not be implemented. This
> > --print-capabilities is a simple way to check what the backend
> > implements.
>
> What is the expected behavior in case virgl is implemented by the
> backend, but
Hi
On Fri, Oct 5, 2018 at 5:51 PM Ján Tomko wrote:
>
> On Fri, Sep 14, 2018 at 05:52:30PM +0400, Marc-André Lureau wrote:
> >As discussed during "[PATCH v4 00/29] vhost-user for input & GPU"
> >review, let's define a common set of backend convent
Hi
On Wed, Sep 19, 2018 at 5:58 PM Michal Privoznik wrote:
>
> On 09/19/2018 12:03 PM, Marc-André Lureau wrote:
> > Hi
> >
> > On Wed, Sep 19, 2018 at 1:41 PM Michal Privoznik
> > wrote:
> >>
> >> On 09/17/2018 03:14 PM, marcandre.lur...
Hi
On Wed, Sep 19, 2018 at 5:31 PM Michal Privoznik wrote:
>
> On 09/19/2018 01:43 PM, Jiri Denemark wrote:
> BTW: what features does this new memfd backend provides that can't be
> achieved via traditional -file or -ram backends?
2 things stand out:
- no need for files & mountpoint
- sealing, p
Hi
On Wed, Sep 19, 2018 at 1:41 PM Michal Privoznik wrote:
>
> On 09/17/2018 03:14 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Add a new memoryBacking source type "memfd", supported by QEMU (when
> > the apability is avai
Hi
On Mon, Sep 17, 2018 at 3:07 PM, Michal Privoznik wrote:
> On 09/17/2018 11:30 AM, Marc-André Lureau wrote:
>> Hi
>>
>> On Fri, Sep 14, 2018 at 11:44 AM, Michal Prívozník
>> wrote:
>>> On 09/13/2018 11:51 PM, John Ferlan wrote:
>>>>
>
Hi
On Fri, Sep 14, 2018 at 11:44 AM, Michal Prívozník wrote:
> On 09/13/2018 11:51 PM, John Ferlan wrote:
>>
>>
>> On 09/13/2018 10:09 AM, John Ferlan wrote:
>>>
>>>
>>> On 09/13/2018 03:39 AM, Marc-André Lureau wrote:
>>>> Hi
&
bvir-list@redhat.com
Cc: Gerd Hoffmann
Cc: Daniel P. Berrangé
Cc: Changpeng Liu
Cc: Dr. David Alan Gilbert
Cc: Felipe Franciosi
Cc: Gonglei
Cc: Maxime Coquelin
Cc: Michael S. Tsirkin
Cc: Victor Kaplansky
Signed-off-by: Marc-André Lureau
---
docs/interop/vhost-user.txt | 109
Hi
On Fri, Sep 14, 2018 at 2:55 PM, Gerd Hoffmann wrote:
> Hi,
>
>> +* --pidfile=PATH
>> +
>> +Write the process id (PID) to the given file PATH. This is mostly
>> +useful if the backend daemonize/fork itself.
>
> Is there any reason to daemonize itself?
>
> If not: shoud we disallow it and dro
Liu
Cc: Dr. David Alan Gilbert
Cc: Felipe Franciosi
Cc: Gonglei
Cc: Maxime Coquelin
Cc: Michael S. Tsirkin
Cc: Victor Kaplansky
Signed-off-by: Marc-André Lureau
---
docs/interop/vhost-user.txt | 106 +++-
1 file changed, 104 insertions(+), 2 deletions(-)
diff -
Hi
On Thu, Sep 13, 2018 at 2:25 AM, John Ferlan wrote:
>
> [...]
>
>>>
>>> So all that's "left":
>>>
>>> 1. "Add" a check in qemuDomainABIStabilityCheck to ensure we're not
>>> changing from memory-backend-ram to memory-backend-memfd. We already
>>> check that "(src->mem.source != dst->mem.sour
Hi
On Wed, Sep 12, 2018 at 4:01 AM, John Ferlan wrote:
>
>
> On 09/11/2018 04:48 AM, Marc-André Lureau wrote:
>> Hi
>>
>> On Tue, Sep 11, 2018 at 2:57 AM, John Ferlan wrote:
>>>
>>>
>>> On 09/07/2018 07:32 AM, marcandre.lur...@redhat.co
; Signed-off-by: John Ferlan
Reviewed-by: Marc-André Lureau
> ---
> src/conf/domain_conf.c | 14 --
> src/qemu/qemu_domain.c | 27 ++-
> 2 files changed, 22 insertions(+), 19 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/dom
On Tue, Sep 11, 2018 at 5:36 PM John Ferlan wrote:
>
> Commit bc6d3121a was far too terse when describing the new
> elements, attributes, and allow values. Provide a few more
> words to help describe.
>
> Signed-off-by: John Ferlan
Reviewed-by: Marc-André Lure
Hi
On Tue, Sep 11, 2018 at 7:39 PM, John Ferlan wrote:
>
>
> On 09/11/2018 09:45 AM, Marc-André Lureau wrote:
>> Hi
>>
>> On Tue, Sep 11, 2018 at 5:21 PM, John Ferlan wrote:
>>>
>>> [...]
>>>
>>>>>> diff --git a/tes
Hi
On Tue, Sep 11, 2018 at 5:21 PM, John Ferlan wrote:
>
> [...]
>
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 35df63b2ac..76008a8d07 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -2928,6 +2928,11 @@ mymain(void)
Hi
On Tue, Sep 11, 2018 at 5:14 PM, Igor Mammedov wrote:
> On Tue, 11 Sep 2018 12:49:12 +0100
> "Dr. David Alan Gilbert" wrote:
>
>> * Marc-André Lureau (marcandre.lur...@redhat.com) wrote:
>> > Hi
>> >
>> > On Tue, Sep 11, 2018 at 3:26 P
Hi
On Tue, Sep 11, 2018 at 3:26 PM, Dr. David Alan Gilbert
wrote:
> * Marc-André Lureau (marcandre.lur...@redhat.com) wrote:
>> Hi
>>
>> On Tue, Sep 11, 2018 at 2:32 PM, Dr. David Alan Gilbert
>> wrote:
>> > * Marc-André Lureau (marcandre.lur...@redhat.com
Hi
On Tue, Sep 11, 2018 at 2:32 PM, Dr. David Alan Gilbert
wrote:
> * Marc-André Lureau (marcandre.lur...@redhat.com) wrote:
>> Hi
>>
>> On Tue, Sep 11, 2018 at 12:37 PM, Michal Privoznik
>> wrote:
>> > On 09/11/2018 12:46 AM, John Ferlan wrote
Hi
On Tue, Sep 11, 2018 at 12:37 PM, Michal Privoznik wrote:
> On 09/11/2018 12:46 AM, John Ferlan wrote:
>>
>> On 09/07/2018 07:32 AM, marcandre.lur...@redhat.com wrote:
>>> From: Marc-André Lureau
>>>
>>
>> Would be nice to have a few more word
Hi
On Tue, Sep 11, 2018 at 2:57 AM, John Ferlan wrote:
>
>
> On 09/07/2018 07:32 AM, marcandre.lur...@redhat.com wrote:
>> From: Marc-André Lureau
>>
>> Check anonymous memory is backed by memfd if qemu is capable.
>>
>> Signed-off-by: Marc-André Lureau
Hi
On Tue, Sep 11, 2018 at 2:56 AM, John Ferlan wrote:
>
> "non-anonymous"
>
> On 09/07/2018 07:32 AM, marcandre.lur...@redhat.com wrote:
>> From: Marc-André Lureau
>>
>> memfd is able to allocate hugepage anonymous memory.
>>
>> S
Hi
On Tue, Sep 11, 2018 at 2:46 AM, John Ferlan wrote:
>
> On 09/07/2018 07:32 AM, marcandre.lur...@redhat.com wrote:
>> From: Marc-André Lureau
>>
>
> Would be nice to have a few more words here. If you provide them I can
> add them... The if statement is difficult t
Hi
On Thu, Aug 30, 2018 at 2:25 PM, Ján Tomko wrote:
> On Thu, Aug 30, 2018 at 02:09:41PM +0200, marcandre.lur...@redhat.com wrote:
>>
>> From: Marc-André Lureau
>>
>> With qemu <= 3.0, when using "-seccomp on", the seccomp policy is only
>> appl
Hi
On Thu, Aug 16, 2018 at 12:48 PM Daniel P. Berrangé wrote:
>
> On Fri, Jul 13, 2018 at 03:28:08PM +0200, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > When a domain is configured with 'shared' memory backing:
> >
> >
Hi
On Thu, Aug 16, 2018 at 4:35 AM, John Ferlan wrote:
>
>
> On 07/13/2018 09:28 AM, marcandre.lur...@redhat.com wrote:
>> From: Marc-André Lureau
>>
>> When a domain is configured with 'shared' memory backing:
>>
>>
>>
>>
ping
On Fri, Jul 13, 2018 at 3:28 PM wrote:
>
> From: Marc-André Lureau
>
> Hi,
>
> This series of patches add support for running a virtio GPU in a
> seperate process, using vhost-user.
>
> The QEMU series "[PATCH v4 00/29] vhost-user for input & GPU" is
ld be better for my case)
Any opinion on how to change that?
thanks
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Hi
- Original Message -
> On Mon, Nov 06, 2017 at 01:09:09PM +0100, marcandre.lur...@redhat.com wrote:
> >From: Marc-André Lureau
> >
> >Starting from qemu 2.11, the `-device vmcoreinfo` will create a fw_cfg
> >entry for a guest to store dump details, necessar
ping, please review/comment
On Mon, Nov 6, 2017 at 1:09 PM, wrote:
> From: Marc-André Lureau
>
> Starting from qemu 2.11, the `-device vmcoreinfo` will create a fw_cfg
> entry for a guest to store dump details, necessary to process kernel
> dump with KASLR enabled and provi
Hi
On Thu, Jun 29, 2017 at 7:01 PM Stefan Berger
wrote:
> TPM 2 does not implement sysfs files for cancellation of commands.
> We therefore use /dev/null for the cancel path passed to QEMU.
>
> Signed-off-by: Stefan Berger
>
Reviewed-by: Marc-André Lureau
---
> src
- Original Message -
> On Wed, Jul 12, 2017 at 01:49:04PM +0200, Martin Kletzander wrote:
> > On Wed, Jul 12, 2017 at 01:10:08PM +0200, Martin Kletzander wrote:
> > > On Wed, Jul 12, 2017 at 11:14:16AM +0100, Daniel P. Berrange wrote:
> > > > This reverts commit e4b980c853d2114b25fa805a84
On Wed, Jul 12, 2017 at 1:54 AM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Mon, Jul 10, 2017 at 1:14 PM Peter Krempa wrote:
>
>> On Wed, Jul 05, 2017 at 12:58:51 +0100, Daniel Berrange wrote:
>> > Currently all mockable functions
| 2 +-
> > src/util/virutil.h | 10 +-
> > src/util/viruuid.h | 2 +-
> > 21 files changed, 58 insertions(+), 45 deletions(-)
>
> ACK
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
}
> +
> +VIR_DEBUG("Setup all graphics");
> +return 0;
> +}
> +
> +
> static int
> qemuDomainSetupInput(virQEMUDriverPtr driver ATTRIBUTE_UNUSED,
> virDomainInputDefPtr input,
> @@ -7679,6 +7715,9 @@ qemuDomainBuildNamespace(virQEMUDriverPtr driver,
> if (qemuDomainSetupTPM(driver, vm, devPath) < 0)
> goto cleanup;
>
> +if (qemuDomainSetupAllGraphics(driver, vm, devPath) < 0)
> +goto cleanup;
> +
> if (qemuDomainSetupAllInputs(driver, vm, devPath) < 0)
> goto cleanup;
>
Looks good,
Reviewed-by: Marc-André Lureau
> --
> 2.11.0
>
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Hi
- Original Message -
> With recent DRM device addition we report more devices. I happen
> to have some on my system therefore add the nodedev XMLs intou
> our test suite so that we make sure we won't break it.
>
> Signed-off-by: Michal Privoznik
Isn't it redundant with drm_renderD129
> either all devices or just those with specified capability. Well,
> DRM capability is missing there.
>
> Signed-off-by: Michal Privoznik
looks good,
Reviewed-by: Marc-André Lureau
> ---
> include/libvirt/libvirt-nodedev.h | 1 +
> src/conf/node_device_conf.c | 3 +
> +if (qemuDomainSetupVideo(driver,
> + vm->def->videos[i],
> + devPath) < 0)
> + return -1;
> +}
> +
> +VIR_DEBUG("Setup all videos");
> +return 0;
> +}
> +
> +
> static int
> qemuDomainSetupInput(virQEMUDriverPtr driver ATTRIBUTE_UNUSED,
> virDomainInputDefPtr input,
> @@ -7657,6 +7718,9 @@ qemuDomainBuildNamespace(virQEMUDriverPtr driver,
> if (qemuDomainSetupTPM(driver, vm, devPath) < 0)
> goto cleanup;
>
> +if (qemuDomainSetupAllVideos(driver, vm, devPath) < 0)
> +goto cleanup;
> +
> if (qemuDomainSetupAllInputs(driver, vm, devPath) < 0)
> goto cleanup;
>
> --
> 2.11.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ne VFIO devices assigned to it,
> this function does not clean /dev/vfio/vfio in CGroup nor in the
> namespace. But that doesn't matter.
>
> Signed-off-by: Michal Privoznik
>
Fine approach to me,
Reviewed-by: Marc-André Lureau
> ---
> src/qemu/qemu_cgroup.c | 87
hen starting the domain (or
> hotplugging a hostdev) create & allow /dev/vfio/vfio too (if
> needed).
>
> Signed-off-by: Michal Privoznik
>
looks good to me,
Reviewed-by: Marc-André Lureau
> ---
> src/qemu/qemu.conf | 2 +-
>
: Michal Privoznik
>
Reviewed-by: Marc-André Lureau
---
> src/qemu/qemu_cgroup.c | 147
> +
> src/qemu/qemu_domain.c | 31 +--
> src/qemu/qemu_domain.h | 4 ++
> 3 files changed, 43 insertions(+), 139 deletions(-)
>
ainGetHostdevPath() to get path and call
> virCgroupAllowDevicePath() directly.
>
> Signed-off-by: Michal Privoznik
>
Reviewed-by: Marc-André Lureau
> ---
> src/qemu/qemu_cgroup.c | 33 +++--
> 1 file changed, 11 insertions(+), 22 deletions(-)
>
) to get path and call
> virCgroupAllowDevicePath() directly.
>
> Signed-off-by: Michal Privoznik
>
Reviewed-by: Marc-André Lureau
> ---
> src/qemu/qemu_cgroup.c | 38 +-
> 1 file changed, 13 insertions(+), 25 deletions(-)
>
> di
ath() to get path and call
> virCgroupAllowDevicePath() directly.
>
> Signed-off-by: Michal Privoznik
>
Reviewed-by: Marc-André Lureau
---
> src/qemu/qemu_cgroup.c | 34 +-
> 1 file changed, 9 insertions(+), 25 deletions(-)
>
> diff
Hi
- Original Message -
> On Mon, Feb 13, 2017 at 08:08:20AM -0500, Marc-André Lureau wrote:
> > Hi
> >
> > - Original Message -
> > > On Mon, Feb 13, 2017 at 07:19:04AM -0500, Marc-André Lureau wrote:
> > > > Hi
> > > >
>
Hi
- Original Message -
> On Mon, Feb 13, 2017 at 07:19:04AM -0500, Marc-André Lureau wrote:
> > Hi
> >
> > - Original Message -
> > > On Mon, Feb 13, 2017 at 03:51:48PM +0400, marcandre.lur...@redhat.com
> > > wrote:
> > > > Fro
Hi
- Original Message -
> On Mon, Feb 13, 2017 at 03:51:48PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > I am working on a WIP series to add QEMU Spice/virgl rendernode option.
> > Since rendernodes are not stable across r
Hi
- Original Message -
> Hi
>
> - Original Message -
> > When a serial port writes data to a pty that's disconnected, drop the
> > data and return the length dropped. This avoids triggering pointless
> > retries in callers like the 16550A serial_xmit(), and causes
> > qemu_chr_fe
Hi
- Original Message -
> When a serial port writes data to a pty that's disconnected, drop the
> data and return the length dropped. This avoids triggering pointless
> retries in callers like the 16550A serial_xmit(), and causes
> qemu_chr_fe_write() to write all data to the log file, rat
I'm afraid of specifically with this cgroups issue is people will work
> around it with a custom cgroup_device_acl, then some time later when we
> bump
> the default list to make some new qemu feature work, suddenly that old
> cgroup
> list doesn't cut it and the user get's weird errors with new qemu, which we
> have to debug. svirt and dac workarounds are less scary in that regard
>
> - Cole
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
; +
> +hvm
> +
> +
> +
> + destroy
> + restart
> + destroy
> +
> +/usr/bin/qemu
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
> index 43deebd..4bf5249 100644
> --- a/tests/qemuxml2argvtest.c
> +++ b/tests/qemuxml2argvtest.c
> @@ -941,6 +941,12 @@ mymain(void)
> QEMU_CAPS_DEVICE_QXL_VGA,
> QEMU_CAPS_DEVICE_QXL,
> QEMU_CAPS_SPICE_FILE_XFER_DISABLE);
> +DO_TEST("graphics-spice-socket",
> +QEMU_CAPS_SPICE,
> +QEMU_CAPS_SPICE_UNIX);
> +DO_TEST("graphics-spice-auto-socket",
> +QEMU_CAPS_SPICE,
> +QEMU_CAPS_SPICE_UNIX);
>
> DO_TEST("input-usbmouse", NONE);
> DO_TEST("input-usbtablet", NONE);
> diff --git
> a/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-auto-socket.xml
> b/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-auto-socket.xml
> new file mode 100644
> index 000..931ec0f
> --- /dev/null
> +++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-auto-socket.xml
> @@ -0,0 +1,35 @@
> +
> + QEMUGuest1
> + c7a5fdbd-edaf-9455-926a-d65c16db1809
> + 219100
> + 219100
> + 1
> +
> +hvm
> +
> +
> +
> + destroy
> + restart
> + destroy
> +
> +/usr/bin/qemu
> +
> + function='0x2'/>
> +
> +
> + function='0x1'/>
> +
> +
> +
> +
> +
> +
> +
> +
> +
> + function='0x0'/>
> +
> +
> +
> +
> diff --git
> a/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-socket.xml
> b/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-socket.xml
> new file mode 100644
> index 000..dd672ed
> --- /dev/null
> +++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-socket.xml
> @@ -0,0 +1,35 @@
> +
> + QEMUGuest1
> + c7a5fdbd-edaf-9455-926a-d65c16db1809
> + 219100
> + 219100
> + 1
> +
> +hvm
> +
> +
> +
> + destroy
> + restart
> + destroy
> +
> +/usr/bin/qemu
> +
> + function='0x2'/>
> +
> +
> + function='0x1'/>
> +
> +
> +
> +
> +
> +
> +
> +
> +
> + function='0x0'/>
> +
> +
> +
> +
> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
> index b67d687..172fbf9 100644
> --- a/tests/qemuxml2xmltest.c
> +++ b/tests/qemuxml2xmltest.c
> @@ -441,6 +441,8 @@ mymain(void)
> DO_TEST("graphics-spice");
> DO_TEST("graphics-spice-compression");
> DO_TEST("graphics-spice-qxl-vga");
> +DO_TEST("graphics-spice-socket");
> +DO_TEST("graphics-spice-auto-socket");
> DO_TEST("nographics-vga");
> DO_TEST("input-usbmouse");
> DO_TEST("input-usbtablet");
> --
> 2.8.2
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Other than that, looks good
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
gt; --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket.args
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket.args
> @@ -16,7 +16,5 @@ QEMU_AUDIO_DRV=none \
> -no-acpi \
> -boot c \
> -usb \
> --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-i
On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_process.c | 123
> ++--
> 1 file changed, 77 insertions(+), 46 deletions(-)
>
Reviewed-by: Marc-André Lureau
>
er VNC tests.
>
> Signed-off-by: Pavel Hrdina
Reviewed-by: Marc-André Lureau
> ---
> .../qemuxml2argv-graphics-vnc-auto-socket-cfg.args | 22
> .../qemuxml2argv-graphics-vnc-auto-socket-cfg.xml | 34 ++
> .../qemuxml2argv-graphics
gt; b/tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-spice-gl.args
> index b80ad16..edecca1 100644
> --- a/tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-spice-gl.args
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-spice-gl.args
> @@ -19,6 +19,6 @@ QEMU_AUDIO_DRV=spice \
> -drive file=/var/lib/libvirt/images/QEMUGuest1,format=qcow2,if=none,\
> id=drive-ide0-0-0,cache=none \
> -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \
> --spice gl=on \
> +-spice port=0,gl=on \
> -device virtio-vga,id=video0,virgl=on,bus=pci.0,addr=0x2 \
> -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3
> diff --git
> a/tests/qemuxml2xmloutdata/qemuxml2xmlout-video-virtio-gpu-spice-gl.xml
> b/tests/qemuxml2xmloutdata/qemuxml2xmlout-video-virtio-gpu-spice-gl.xml
> index fd260ea..9fb533a 100644
> --- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-video-virtio-gpu-spice-gl.xml
> +++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-video-virtio-gpu-spice-gl.xml
> @@ -29,8 +29,8 @@
>
>
>
> -
> -
> +
> +
>
>
>
> --
> 2.8.2
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Other than that, looks good to me
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
function='0x1'/>
> +
> +
> +
> +
> +
> +
> +
> +
> +
> + function='0x0'/>
> +
> +
> +
> +
> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
> index 49bf557..9db7ddd 100644
> --- a/tests/qemuxml2xmltest.c
> +++ b/tests/qemuxml2xmltest.c
> @@ -449,6 +449,10 @@ mymain(void)
> DO_TEST("graphics-spice-qxl-vga");
> DO_TEST("graphics-spice-socket");
> DO_TEST("graphics-spice-auto-socket");
> +cfg->spiceAutoUnixSocket = true;
> +DO_TEST_FULL("graphics-spice-auto-socket-cfg", WHEN_INACTIVE, NONE);
> +cfg->spiceAutoUnixSocket = false;
> +
> DO_TEST("nographics-vga");
> DO_TEST("input-usbmouse");
> DO_TEST("input-usbtablet");
> --
> 2.8.2
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
num {
> QEMU_CAPS_DEVICE_TRAY_MOVED, /* DEVICE_TRAY_MOVED event */
> QEMU_CAPS_NEC_USB_XHCI_PORTS, /* -device nec-usb-xhci.p3 ports setting */
> QEMU_CAPS_VIRTIO_SCSI_IOTHREAD, /* virtio-scsi-{pci,ccw}.iothread */
> +QEMU_CAPS_SPICE_UNIX, /* -spice unix */
>
> QEMU_
> is not network"));
> + _("'network' attribute is valid only for listen "
> + "type 'network'"));
> goto error;
> }
Reviewed-by: Marc-André Lureau
> def-
ore familiar with libvirt & network code, and migration support,
should do a more thorough review.
Tested-by: Marc-André Lureau
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
>
> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml
> b/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml
> index 9c2b9e3..8eba88f 100644
> --- a/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml
> +++ b/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml
> @@ -42,7 +42,9 @@
>
>
>
> -
> +
> +
> +
>
>
>
> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv.xml
> b/tests/sexpr2xmldata/sexpr2xml-fv.xml
> index 9c2b9e3..8eba88f 100644
> --- a/tests/sexpr2xmldata/sexpr2xml-fv.xml
> +++ b/tests/sexpr2xmldata/sexpr2xml-fv.xml
> @@ -42,7 +42,9 @@
>
>
>
> -
> +
> +
> +
>
>
>
> diff --git a/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml
> b/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml
> index 97d9482..89dd87f 100644
> --- a/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml
> +++ b/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml
> @@ -47,7 +47,9 @@
>
>
>
> -
> +
> +
> +
>
>
>
> diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml
> b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml
> index c1acba1..e8b1cd5 100644
> --- a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml
> +++ b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml
> @@ -31,7 +31,9 @@
>
>
>
> -
> +
> +
> +
>
>
>
> diff --git a/tests/sexpr2xmldata/sexpr2xml-vif-rate.xml
> b/tests/sexpr2xmldata/sexpr2xml-vif-rate.xml
> index 45887e5..1e9d60b 100644
> --- a/tests/sexpr2xmldata/sexpr2xml-vif-rate.xml
> +++ b/tests/sexpr2xmldata/sexpr2xml-vif-rate.xml
> @@ -46,7 +46,9 @@
>
>
>
> -
> +
> +
> +
>
>
>
> diff --git a/tests/vmx2xmldata/vmx2xml-graphics-vnc.xml
> b/tests/vmx2xmldata/vmx2xml-graphics-vnc.xml
> index 8501907..3c57579 100644
> --- a/tests/vmx2xmldata/vmx2xml-graphics-vnc.xml
> +++ b/tests/vmx2xmldata/vmx2xml-graphics-vnc.xml
> @@ -11,7 +11,9 @@
>restart
>destroy
>
> - passwd='password'/>
> + passwd='password'>
> +
> +
>
>
>
> diff --git a/tests/xmconfigdata/test-no-source-cdrom.xml
> b/tests/xmconfigdata/test-no-source-cdrom.xml
> index d4c2fd6..61cfb75 100644
> --- a/tests/xmconfigdata/test-no-source-cdrom.xml
> +++ b/tests/xmconfigdata/test-no-source-cdrom.xml
> @@ -47,7 +47,9 @@
>
>
>
> -
> +
> +
> +
>
>
>
> diff --git a/tests/xmconfigdata/test-pci-devs.xml
> b/tests/xmconfigdata/test-pci-devs.xml
> index 4c3f5f2..3bc263f 100644
> --- a/tests/xmconfigdata/test-pci-devs.xml
> +++ b/tests/xmconfigdata/test-pci-devs.xml
> @@ -47,7 +47,9 @@
>
>
>
> -
> +
> +
> +
>
>
>
> --
> 2.8.2
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Other than that,
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
quot;graphics listen attribute %s must match address "
> - "attribute of first listen element (found %s)"),
> - listenAddr, address->address);
> -goto error;
> +if (newListen.address &&
> +
+ret = 0;
> +goto error;
> +}
Even if we keep the for compatibility purposes, perhaps there
is a log/warning to give that it is ignored.
Reviewed-by: Marc-André Lureau
> +
> /* parse the subelements for graphics types that su
and generation in seperate function
- fix syntax-check
- fix leak
v1->v2:
- drop the configuration, enable debug-thread automatically
Marc-André Lureau (2):
qemu: check for debug-threads capability
qemu: enable debug threads
src/qemu/qemu_capabilities.c | 2 ++
When debug-threads is enabled, individual threads are given a separate
name (on Linux)
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1140121
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c| 34 +-
.../qemuxml2argv-debug
From: Marc-André Lureau
QEMU (somewhere around 2.0) added a new sub-option to the -name flag
-name debug-threads=on.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata
eak
v1->v2:
- drop the configuration, enable debug-thread automatically
Marc-André Lureau (2):
qemu: check for debug-threads capability
qemu: enable debug threads
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1
When debug-threads is enabled, individual threads are given a separate
name (on Linux)
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1140121
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 40
1 file changed, 32 insertions(+), 8
From: Marc-André Lureau
QEMU (somewhere around 2.0) added a new sub-option to the -name flag
-name debug-threads=on.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata
Hi
On Thu, Mar 10, 2016 at 5:12 PM, Marc-André Lureau
wrote:
> +virCommandAddArg(cmd, virBufferContentAndReset(&name_opts));
and there is a leak here, fixed in v3
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Hi
- Original Message -
> On Thu, Mar 10, 2016 at 17:12:24 +0100, Marc-André Lureau wrote:
> > When debug-threads is enabled, individual threads are given a separate
> > name (on Linux)
> >
> > Fixes:
> > https://bugzilla.redhat.com/show_bug.cgi?id=114
Hi
- Original Message -
> On Thu, Mar 10, 2016 at 17:12:23 +0100, Marc-André Lureau wrote:
> > From: Marc-André Lureau
> >
> > QEMU (somewhere around 2.0) added a new sub-option to the -name flag
> > -name debug-threads=on.
> >
> > Signed-off-
From: Marc-André Lureau
QEMU (somewhere around 2.0) added a new sub-option to the -name flag
-name debug-threads=on.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata
When debug-threads is enabled, individual threads are given a separate
name (on Linux)
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1140121
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src
ng it easy to figure
out which thread is which.
The following 2 patches add a capability check and enable
debug-threads if supported.
Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1140121
cheers
v1->v2:
- drop the configuration, enable debug-thread automatically
Marc-André Lureau
Hi
On Thu, Mar 10, 2016 at 2:00 PM, Jiri Denemark wrote:
> On Thu, Mar 10, 2016 at 13:54:57 +0100, Marc-André Lureau wrote:
>> QEMU (somewhere around 2.0) added a new sub-option to the -name flag
>> -name debug-threads=on
>>
>> This causes the naming of individual QEMU
ng it easy to figure
out which thread is which.
The following 2 patches add a capability check and a qemu-conf key to
enable debug-threads.
Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1140121
cheers
Marc-André Lureau (2):
qemu: check for debug-threads capability
qemu_conf: add se
When debug-threads is enabled, individual threads are given a separate
name (on Linux)
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1140121
Signed-off-by: Marc-André Lureau
---
src/qemu/libvirtd_qemu.aug | 1 +
src/qemu/qemu.conf | 6 ++
src/qemu
From: Marc-André Lureau
QEMU (somewhere around 2.0) added a new sub-option to the -name flag
-name debug-threads=on.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata
The idle source is not always removed and may crash next tests
Signed-off-by: Marc-André Lureau
---
tests/test-events.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/test-events.c b/tests/test-events.c
index 8afb557..0c0e929 100644
--- a/tests/test-events.c
Signed-off-by: Marc-André Lureau
---
examples/config-demo.py| 2 +-
libvirt-gconfig/libvirt-gconfig-domain-video.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/examples/config-demo.py b/examples/config-demo.py
index 952640a..3fdc367 100644
--- a
Learn to set the accel3d attribute on video model.
Signed-off-by: Marc-André Lureau
---
examples/config-demo.py| 1 +
libvirt-gconfig/libvirt-gconfig-domain-video.c | 18 ++
libvirt-gconfig/libvirt-gconfig-domain-video.h | 2 ++
libvirt-gconfig/libvirt
Learn to set "gl" on spice (to have -spice gl=on on qemu)
Signed-off-by: Marc-André Lureau
---
examples/config-demo.py | 1 +
libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 9 +
libvirt-gconfig/libvirt-gconfig-domain-graphics-s
Enable GIR warnings and fix them, since they are all useful.
Signed-off-by: Marc-André Lureau
---
libvirt-gconfig/Makefile.am | 1 +
libvirt-glib/Makefile.am | 1 +
libvirt-gobject/Makefile.am | 1 +
libvirt-gobject/libvirt-gobject
A few fixes followed by spice gl and virtio-gpu config patches. (libvirt "spice
gl" support is pending merge after the release)
thanks
Marc-André Lureau (5):
build-sys: fix gir introspection warnings
tests: fix potential crash
config: add spice gl child
config: add virtio v
Hi
- Original Message -
> > VIR_ENUM_DECL(virTristateBool)
> > VIR_ENUM_DECL(virTristateSwitch)
> >
> > +/* the two enums must be in sync to be able to use helpers interchangeably
> > in
> > + * some special cases */
> > +verify((int)VIR_TRISTATE_BOOL_YES == (int)VIR_TRISTATE_SWITCH_ON
101 - 200 of 532 matches
Mail list logo
