Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Paweł Krześniak
On Fri, Mar 25, 2011 at 22:02, Laine Stump la...@laine.org wrote: As a matter of fact, I think that not only is this useful, but configuring other capabilities presented by dnsmasq would be good. I think you'll find a kindred spirit in Paweł Krześniak, who was also wanting some other dnsmasq

[libvirt] [PATCHv4] bridge_driver: handle DNS over IPv6

2011-01-31 Thread Paweł Krześniak
* dnsmasq listens on all defined IPv[46] addresses for network * Add ip6tables rules to allow DNS traffic to host --- src/network/bridge_driver.c | 51 ++ 1 files changed, 41 insertions(+), 10 deletions(-) diff --git a/src/network/bridge_driver.c

Re: [libvirt] [PATCHv3] handle DNS over IPv6

2011-01-12 Thread Paweł Krześniak
2011/1/7 Daniel P. Berrange berra...@redhat.com: Practically no apps will be do this and so they typically can't make use of the link-local address. I agree. v2 of patch attached. -- Pawel handle-dns.patch Description: Binary data -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCHv2] handle DNS over IPv6

2011-01-06 Thread Paweł Krześniak
2011/1/6 Daniel P. Berrange berra...@redhat.com: While it is shorter to just use '--interface brname' this comes at the price of loosing compatibility with older dnsmasq which we still wish to support. sure. RHEL5 is important target :) If we used  '--listen-address $IPV4ADDR

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2011-01-05 Thread Paweł Krześniak
2011/1/4 Daniel P. Berrange berra...@redhat.com: NB, there was a discussion with the dnsmsaq maintainer a few months back now about changing the dnsmasq architecture such that we only need one dnsmasq process. is this consistent with Laine's arguments about radvd? read last paragraph of this:

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2011-01-05 Thread Paweł Krześniak
2011/1/4 Daniel P. Berrange berra...@redhat.com: On Wed, Dec 22, 2010 at 10:09:54AM +0100, Paweł Krześniak wrote: I want to create isolated environment for guests - they will be connected to one bridge and will use private DNS data. No single packet from this isolated network can reach

Re: [libvirt] [PATCHv2] handle DNS over IPv6

2011-01-03 Thread Paweł Krześniak
Thanks for comments. v2 attached. Sorry, but my two previous patches don't apply because of line-wrapping issues. -- Pawel commit 41aedffa7bb30ba4e4357e220f071dab35c8e36c Author: Pawel Krzesniak pawel.krzesn...@gmail.com Date: Mon Jan 3 09:46:02 2011 +0100 handle DNS over IPv6

Re: [libvirt] [PATCH] qemu: improve efficiency of dd during snapshots

2010-12-30 Thread Paweł Krześniak
On Wed, Dec 22, 2010 at 22:06, Eric Blake ebl...@redhat.com wrote: diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 7877731..284f9c4 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -1695,10 +1695,11 @@ int

[libvirt] [PATCH] Support ipv[46]routing network parameters

2010-12-27 Thread Paweł Krześniak
Support for optional parameters ipv[46]routing in XML network definition. These parameters allows to set up alternative binary or script to be run during network start. Such customization allows to run additional services for started network (besides default DHCP/DNS/NDP) or modify/pass additional

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2010-12-27 Thread Paweł Krześniak
2010/12/23 Eric Blake ebl...@redhat.com: Rather than tying the element name to our current choice of program, can we come up with something more generic? network  namexxxnet/name  ipv4routing/usr/local/bin/my-dnsmasq/ipv4routing  ipv6routing/usr/local/bin/my-radvd/ipv6routing /network

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2010-12-23 Thread Paweł Krześniak
On Wed, Dec 22, 2010 at 16:50, Laine Stump la...@laine.org wrote: I agree with Eric that this should be discussed with Dan Berrange and/or Daniel Veillard before comitting anything to the tree (definitely it needs doing in some manner, though). Another idea came to my mind: Following logic

Re: [libvirt] [PATCHv2 09/13] Change virtual network XML parsing/formatting to support IPv6

2010-12-23 Thread Paweł Krześniak
On Thu, Dec 23, 2010 at 09:31, Laine Stump la...@laine.org wrote: The new IPv6 regexp (constructed by first de-constructing the old regexp, then removing the IPv4 sub-expressions and replacing them with the fixed version from ipv4-addr, and finally concatenating everything back together):

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2010-12-22 Thread Paweł Krześniak
2010/12/22 Eric Blake ebl...@redhat.com: On 12/21/2010 03:40 PM, Paweł Krześniak wrote: This patch adds possibility to run customized DNS/DHCP environment, by spawning dnsmasq with alternative configuration file if such file exists. This allows you to set any parameter described in dnsmasq(8

Re: [libvirt] boot time delay for domains?

2010-12-22 Thread Paweł Krześniak
On Wed, Dec 22, 2010 at 13:32, Harald Dunkel harald.dun...@aixigo.de wrote: Is there a global boot time delay configuration parameter to make sure that the autostart domains are not started all in parallel at boot time? AFAIK there is no such option. Any helpful comment would be highly

[libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2010-12-21 Thread Paweł Krześniak
By default dnsmasq is spawned with option --conf-file= which disables reading of global configuration file -- this is fine for most situations. This patch adds possibility to run customized DNS/DHCP environment, by spawning dnsmasq with alternative configuration file if such file exists. This

[libvirt] [PATCH] bridge_driver: cleanup improvements in dhcpStartDhcpDaemon()

2010-12-21 Thread Paweł Krześniak
Run VIR_FREE only for non-NULL pointers. --- src/network/bridge_driver.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index b0834ae..f2857b4 100644 --- a/src/network/bridge_driver.c +++

[libvirt] [PATCH] bridge: avoid double free

2010-12-20 Thread Paweł Krześniak
--- src/network/bridge_driver.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index c3f32d7..b0834ae 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -557,7 +557,6 @@

Re: [libvirt] [PATCH] bridge: avoid double free

2010-12-20 Thread Paweł Krześniak
On Mon, Dec 20, 2010 at 14:30, Laine Stump la...@laine.org wrote: On 12/20/2010 06:31 AM, Paweł Krześniak wrote: I added your name to the AUTHORS file and pushed the result. thanks, but it was so trivial change. Thanks for picking this out! Since it seems you've been looking through

Re: [libvirt] [PATCH 01/13] New virSocketAddr utility functions

2010-12-20 Thread Paweł Krześniak
On Mon, Dec 20, 2010 at 09:03, Laine Stump la...@laine.org wrote: diff --git a/src/util/network.c b/src/util/network.c index 1abe78b..e4791b9 100644 --- a/src/util/network.c +++ b/src/util/network.c @@ -288,6 +288,73 @@ int virSocketAddrIsNetmask(virSocketAddrPtr netmask) {  }  /** + *

Re: [libvirt] [PATCH 07/13] Replace brSetInetAddress/brSetInetNetmask with brAddInetAddress

2010-12-20 Thread Paweł Krześniak
On Mon, Dec 20, 2010 at 09:03, Laine Stump la...@laine.org wrote: brSetInetAddress can only set a single IP address on the bridge, and uses a method (ioctl(SIOCSETIFADDR)) that only works for IPv4. Replace it and brSetInetNetmask with a single function that uses the external ip addr add

Re: [libvirt] [PATCH 13/13] Run radvd for virtual networks with IPv6 addresses

2010-12-20 Thread Paweł Krześniak
On Mon, Dec 20, 2010 at 09:03, Laine Stump la...@laine.org wrote: There are two possible solutions for this: 1) Don't attempt to immediately read the pidfile and store the pid in   memory. Instead, just read the pidfile later when we want to kill   radvd. (This could still lead to a race if

Re: [libvirt] ruby-libvirt issue

2010-11-24 Thread Paweł Krześniak
On Tue, Nov 23, 2010 at 14:28, Chris Lalancette clala...@redhat.com wrote: In terms of making this automatically happen during connection closing, I'm not entirely sure what we can (and should) do.  I guess we could keep some sort of list of objects that depend on this connection object, and