[libvirt] libvirt URI for UNIX abstract namespace?

2013-10-11 Thread Philipp Hahn
;done 1. is there a way to specify an libvirt URI using the abstract ns? 2. Does anybody know another/better way to simulate many hosts with many VMs? Thanks in advance. Philipp PS: libvirt-0.9.12 -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbH

[libvirt] [PATCH] doc: storage pool permission copy-paste fix

2013-08-13 Thread Philipp Hahn
. Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatstorage.html.in |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index f4d561f..1fcfb6b 100644 --- a/docs/formatstorage.html.in +++ b/docs

[libvirt] [PATCH] doc: Fix copy-paste-error in virNodeGetMemoryStats

2013-07-22 Thread Philipp Hahn
The description seems to be copied from virNodeGetCpuState. Change wrong 'cpu' to 'memory'. Signed-off-by: Philipp Hahn h...@univention.de --- src/libvirt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt.c b/src/libvirt.c index bc1694a..12f9c41 100644

[libvirt] [PATCH] doc: Fix reference to #elementsUSB

2013-06-28 Thread Philipp Hahn
aae0fc2a922b3e31dae7648c547fca2ac2587625 removed the #elementsUSB anchor but did not update the links to point to the new section #elementsHostDev. Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatdomain.html.in |2 +- docs/formatnode.html.in |2 +- 2 files changed, 2

[libvirt] [PATCH 2/4] doc/schema: Support iqn for storage pools

2013-03-20 Thread Philipp Hahn
... /pool Add IscsiQualifiedName type and allow its use in sourceiscsi. Signed-off-by: Philipp Hahn h...@univention.de --- docs/schemas/storagepool.rng |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/schemas/storagepool.rng b/docs/schemas/storagepool.rng index 2b1f08d

[libvirt] [PATCH 1/4] doc/schema: add ocfs2 to storage pool

2013-03-20 Thread Philipp Hahn
Add ocfs2 for disk pool. Signed-off-by: Philipp Hahn h...@univention.de --- docs/schemas/storagevol.rng |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/schemas/storagevol.rng b/docs/schemas/storagevol.rng index ba95c55..765c5a5 100644 --- a/docs/schemas

[libvirt] [PATCH 4/4] doc/schema: disk storage volume formats

2013-03-20 Thread Philipp Hahn
The storage volume formats supported by the disk storage pool are missing from the allowed values. Add partition types. Signed-off-by: Philipp Hahn h...@univention.de --- docs/schemas/storagevol.rng | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/schemas

[libvirt] [PATCH 3/4] doc: storage: Fix grammar

2013-03-20 Thread Philipp Hahn
Remove 'are' before 'have'. Signed-off-by: Philipp Hahn h...@univention.de --- docs/storage.html.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/storage.html.in b/docs/storage.html.in index 7712c80..3777474 100644 --- a/docs/storage.html.in +++ b/docs

Re: [libvirt] [PATCH 4/4] storage: fix uid_t|gid_t handling on 32 bit Linux

2013-02-26 Thread Philipp Hahn
Hello, Am Montag 25 Februar 2013, 15:58:50 schrieb Michal Privoznik: On 22.02.2013 17:55, Philipp Hahn wrote: uid_t and gid_t are opaque types, ranging from s32 to u32 to u64. ... This one breaks storagevolxml2xmltest: TEST: storagevolxml2xmltest ... ... OK 7) Storage Vol XML-2-XML vol

[libvirt] [PATCH 0/4] doc: storage.html updates

2013-02-26 Thread Philipp Hahn
Hello, some documentation updates for new storage pools and volumes. Philipp Hahn (4): doc: document new storage volume/pool types doc: add storage format entries doc: fix writing of QEMU doc: white space changes docs/storage.html.in | 40 +--- 1

[libvirt] [PATCH 2/4] doc: add storage format entries

2013-02-26 Thread Philipp Hahn
Add format/@type entries to examples to show what the text is talking about. Signed-off-by: Philipp Hahn h...@univention.de --- docs/storage.html.in |4 1 file changed, 4 insertions(+) diff --git a/docs/storage.html.in b/docs/storage.html.in index 92d7842..930d603 100644 --- a/docs

[libvirt] [PATCH 1/4] doc: document new storage volume/pool types

2013-02-26 Thread Philipp Hahn
Add qed for dirfs pool. Add ocfs2 for disk pool. Add lvm2 for disk and logical pool. Add cifs and glusterfs for netfs pool. Note: POOL_DISK_LVM2 can not be created by parted mklabel, but is only returned from auto-detection on disk pools. Signed-off-by: Philipp Hahn h...@univention.de --- docs

[libvirt] [PATCH 3/4] doc: fix writing of QEMU

2013-02-26 Thread Philipp Hahn
QEMU should be written all upper case. Signed-off-by: Philipp Hahn h...@univention.de --- docs/storage.html.in | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/storage.html.in b/docs/storage.html.in index 930d603..8391f85 100644 --- a/docs/storage.html.in

[libvirt] [PATCH 4/4] doc: white space changes

2013-02-26 Thread Philipp Hahn
use two blank line before the next h2, which helps reading the source file. I find the html file still hard to read as there is no clear separation between different storage pool types. Some CSS tweaks would be appreciated. Signed-off-by: Philipp Hahn h...@univention.de --- docs/storage.html.in

[libvirt] [PATCHv2] storage: fix uid_t|gid_t handling on 32 bit Linux

2013-02-26 Thread Philipp Hahn
for owner and group in schema for storage volumes. Change UINT_MAX in one test case to -1 to follow the changes from above. Signed-off-by: Philipp Hahn h...@univention.de --- [v2] - change schema for storage volume to accept -1 for owner and group - Use UINT_MAX instead of ALLONE - Windows64 uses

[libvirt] [PATCH] schema: Restrict mode to ocal

2013-02-26 Thread Philipp Hahn
virStrToLong(..., 8, ...) already requires the mode to be octal. Change the relax-ng schema to check for octal as well. Signed-off-by: Philipp Hahn h...@univention.de --- docs/schemas/basictypes.rng |6 ++ docs/schemas/storagepool.rng |2 +- docs/schemas/storagevol.rng |2 +- 3

Re: [libvirt] [PATCH 2/4] doc: add storage format entries

2013-02-26 Thread Philipp Hahn
Hello Eric, Am Mittwoch 27 Februar 2013, 02:00:07 schrieb Eric Blake: On 02/26/2013 05:42 AM, Philipp Hahn wrote: Add format/@type entries to examples to show what the text is talking about. Signed-off-by: Philipp Hahn h...@univention.de --- docs/storage.html.in |4 1

[libvirt] [PATCH 2/4] storage: Cast uid_t|gid_t to unsigned int

2013-02-22 Thread Philipp Hahn
uid_t and gid_t are opaque types, ranging from s32 to u32 to u64. Explicitly cast them to unsigned int for printing. Signed-off-by: Philipp Hahn h...@univention.de --- src/storage/storage_backend.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/storage

[libvirt] [PATCH 0/4] uid_t|gid_t fixes for 32 bit Linux

2013-02-22 Thread Philipp Hahn
hopefully nobody uses it. Should this be documented somewhere? - Some regression test? Philipp Hahn (4): util: Fix printf format for uid_t|gid_t storage: Cast uid_t|gid_t to unsigned int storage: cast -1 for uid_t|gid_t storage: fix uid_t|gid_t handling on 32 bit Linux src/conf

[libvirt] [PATCH 1/4] util: Fix printf format for uid_t|gid_t

2013-02-22 Thread Philipp Hahn
The uid_t|gid_t values are explicitly casted to unsigned long, but the printf() still used %d, which is for signed values. Change the format to %u. Signed-off-by: Philipp Hahn h...@univention.de --- src/util/virutil.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH 4/4] storage: fix uid_t|gid_t handling on 32 bit Linux

2013-02-22 Thread Philipp Hahn
-by: Philipp Hahn h...@univention.de --- src/conf/storage_conf.c | 74 ++- 1 file changed, 60 insertions(+), 14 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 9134a22..b267f00 100644 --- a/src/conf/storage_conf.c +++ b/src

[libvirt] [PATCH 3/4] storage: cast -1 for uid_t|gid_t

2013-02-22 Thread Philipp Hahn
uid_t and gid_t are opaque types, ranging from s32 to u32 to u64. Explicitly cast the magic -1 to the appropriate type. Signed-off-by: Philipp Hahn h...@univention.de --- src/conf/storage_conf.c |8 src/storage/storage_backend.c | 16 src/util/virutil.c

[libvirt] [BUG] qemu internal snapshot with raw image not aborted

2013-02-15 Thread Philipp Hahn
but also exists in git, QEMU 1.1.2 Tracked at https://forge.univention.org/bugzilla/show_bug.cgi?id=30472 -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen

[libvirt] [PATCH] qemu: handle not supported writable devices

2013-02-15 Thread Philipp Hahn
. Add does not support snapshots as an additional error condition. Signed-off-by: Philipp Hahn h...@univention.de --- src/qemu/qemu_monitor_text.c |4 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index bc0a11d..5880ab9 100644

Re: [libvirt] [PATCH] qemu: handle not supported writable devices

2013-02-15 Thread Philipp Hahn
Hello Eric, Am Freitag 15 Februar 2013, 17:26:30 schrieb Eric Blake: On 02/15/2013 07:13 AM, Philipp Hahn wrote: If the running VM contains a writable raw image, creating snapshot fails internally in QEMU, but the error is not detected by libvirt. Success is still reported to the user, who

[libvirt] FYI: Upgrade from pc-0.12 / pc-014 vs. savevm section kvmclock

2012-11-23 Thread Philipp Hahn
to do any harm. If someone has a better fix, I'm open to suggestions. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen

[libvirt] [BUG] storage.xml: owner|group=-1 → 2^32-1 on 32 Bit

2012-11-23 Thread Philipp Hahn
XML. Care to revert that change? Patch is attached. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22

[libvirt] RFC: xml-snapshot-data out-of-sync to .qcow2 data

2012-11-15 Thread Philipp Hahn
, but that doesn't work as you see ;-) Comments? Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99

Re: [libvirt] [BUG] in [PATCHv3 10/19] storage: remember relative names in backing chain

2012-11-07 Thread Philipp Hahn
when doing a 'virsh vol-dumpxml' on such a broken image file, for which I'm currently working on a patch. That patch works fine with my older version of libvirt, but I noticed that with 1.0.0+git I can't no longer start that pool containing my broken test image. Sincerely Philipp -- Philipp

[libvirt] [PATCH] storage: fix broken backing chain

2012-11-07 Thread Philipp Hahn
:700 #6 virStoragePoolCreate () at libvirt.c:12471 ... Treat files which miss their backing file as standalone files. Signed-off-by: Philipp Hahn h...@univention.de --- src/util/storage_file.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util/storage_file.c

Re: [libvirt] [PATCHv4 24/51] snapshot: prevent stranding snapshot data on domain destruction

2012-11-05 Thread Philipp Hahn
-- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http

[libvirt] [PATCH] [trivial] documentation: HTML tag fix

2012-10-26 Thread Philipp Hahn
Replace '%' by '' for correct escaping of '' in Domain specification. Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatdomain.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 2417943

Re: [libvirt] [PATCHv4 24/51] snapshot: prevent stranding snapshot data on domain destruction

2012-10-26 Thread Philipp Hahn
() is not available externally. And iterating over all snapshots to just delete them seems to be wasteful, especially when you use qcow2 with its reference counting issues. See the attached patch for my proposal. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h

Re: [libvirt] [PATCHv4 24/51] snapshot: prevent stranding snapshot data on domain destruction

2012-10-26 Thread Philipp Hahn
Hello Eoric, Forget my previous mail, that was a patched version. qemuDomainRemoveInactive() is deleting the snapshots, but still: I would prefer to check for snapshots to extend for inactive domains as well. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h

Re: [libvirt] [PATCH v11] support offline migration

2012-10-26 Thread Philipp Hahn
; +            } +            if (!(flags VIR_MIGRATE_PERSIST_DEST)) { +                virReportError(VIR_ERR_OPERATION_INVALID, +                               %s, _(VIR_MIGRATE_OFFLINE should combined with VIR_MIGRATE_PERSIST_DEST)); ^ be ? or even should - must be? Sincerely Philipp -- Philipp Hahn

[libvirt] [PATCH] [trivial] Fix spelling mistake

2012-09-05 Thread Philipp Hahn
provably - probably Signed-off-by: Philipp Hahn h...@univention.de --- cfg.mk |2 +- src/libvirt.c |2 +- tools/virsh.pod |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cfg.mk b/cfg.mk index 4cdfd1b..8fd9462 100644 --- a/cfg.mk +++ b/cfg.mk @@ -379,7

[libvirt] [PATCH] xen-xs: fix uuid of renamed domain

2012-08-24 Thread Philipp Hahn
144ad19d-dfb4-2f80-8045-09196bb8784f-3 -----16 The patch adds truncation of the UUID as read from the XenStore path before passing it to virUUIDParse(). The same issue is reported at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=666135 Signed-off-by: Philipp Hahn h

Re: [libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Philipp Hahn
$LIBVIRTP/clientkey.pem` Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-04-13 Thread Philipp Hahn
Hello Guido, Am Freitag 13 April 2012 15:10:49 schrieb Guido Günther: könntest Du das als richtigen Patch schicken, dann apply ich das. [Guido asks me to send a full patch, so he can apply it.] Sure, see the attached patch. Sincerely Philipp -- Philipp Hahn Open Source Software

Re: [libvirt] [PATCH] test: fix segfault in networkxml2argvtest

2012-04-05 Thread Philipp Hahn
the credit for finding this bug and pointing out the valgrind report. Look good. Reviewd-by: Philipp Hahn h...@univention.de Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0

Re: [libvirt] [PATCHv5 3/3] Xen: Adapt clock tests

2012-04-03 Thread Philipp Hahn
Hello Eric, On Monday 02 April 2012 17:43:23 Eric Blake wrote: ACK and squashed into 2/3, then series pushed. Thanks for your review, I appreciate your work. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-04-03 Thread Philipp Hahn
to compile with virtual port support... no checking for LIBNL... yes There was some discussion some time ago on libvirt about puting the check for IFLA_VF_* in configure instead of in the *.c files, but I haven't found a patch yet. Sincerely Philipp -- Philipp Hahn Open Source Software

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-04-02 Thread Philipp Hahn
Hello Daniel, On Saturday 31 March 2012 13:53:32 you wrote: On Mon, Mar 26, 2012 at 09:18:53AM +0200, Philipp Hahn wrote: On Monday 26 March 2012 04:32:23 Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git

[libvirt] [PATCHv5 0/3] Xen: Fix clock handling

2012-04-02 Thread Philipp Hahn
+ update version numbers to 0.9.11 Since v3: + Add missing offset=VARIALE for adjustment='$timeDelta' conversion. Since v4: + Rebase against v0.9.11-rc2-6-ga465031 (unmodified) Philipp Hahn (3): Support clock=variable relative to localtime Xen: Fix clock handling Xen: Adapt clock tests docs

[libvirt] [PATCHv5 1/3] Support clock=variable relative to localtime

2012-04-02 Thread Philipp Hahn
the new 'basis' attribute in the HTML documentation. Adapt test for the new attribute. Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatdomain.html.in | 18 +- docs/schemas/domaincommon.rng | 30 -- src/conf/domain_conf.c

[libvirt] [PATCHv5 2/3] Xen: Fix clock handling

2012-04-02 Thread Philipp Hahn
as a shortcut to offset='variable' with basis='...'. Signed-off-by: Philipp Hahn h...@univention.de --- src/xenxs/xen_sxpr.c | 167 ++ src/xenxs/xen_xm.c | 123 + 2 files changed, 225 insertions(+), 65 deletions

Re: [libvirt] Constantly changing USB product ID

2012-03-29 Thread Philipp Hahn
: Initially the start without a firmware (so the manufacurer doesn't need to put a flash chip on the device) an USB-ID A. Windows detects the device using the ID and uploads the firmware to the device, which then soft-resets itself and re-appears with USB-ID B. Sincerely Philipp -- Philipp

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-03-26 Thread Philipp Hahn
RTC clock is still waiting for review (since before 0.9.10). Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49

Re: [libvirt] [PATCH] libvirt: xen: do not use ioemu type for any emulated NIC

2012-03-21 Thread Philipp Hahn
the NIC model when installing the Windows GPLPV drivers, I hope that little bit is helpful to others, since it cost my some time to find that out myself the hard way. Corrections are appreciated. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de

Re: [libvirt] booting a snapshot

2012-03-21 Thread Philipp Hahn
the delta is zero. Hope that helps. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99

Re: [libvirt] [PATCHv4 0/3] Xen: Fix clock handling

2012-03-21 Thread Philipp Hahn
Hello, On Tuesday 28 February 2012 13:42:05 Philipp Hahn wrote: On Tuesday 14 February 2012 19:07:21 Philipp Hahn wrote: Before version 3.1 xen only implemented clock/@offset='utc' and 'localtime'. With the introduction of managed domains in 3.1 xend keeps track of the rtc_timeoffset, even

Re: [libvirt] [PATCH] libvirt: xen: do not use ioemu type for any emulated NIC

2012-03-21 Thread Philipp Hahn
, is a different matter. I would appreciate a change in that behaviour as well, so +1 for your work. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359

Re: [libvirt] [PATCHv4 0/3] Xen: Fix clock handling

2012-02-28 Thread Philipp Hahn
Hello, On Tuesday 14 February 2012 19:07:21 Philipp Hahn wrote: Before version 3.1 xen only implemented clock/@offset='utc' and 'localtime'. With the introduction of managed domains in 3.1 xend keeps track of the rtc_timeoffset, even over reboots. This translates to  libvirts clock/@offset

[libvirt] [PATCHv3 0/3] Xen: Fix clock handling

2012-02-14 Thread Philipp Hahn
+ update version numbers to 0.9.11 Philipp Hahn (3): Support clock=variable relative to localtime Xen: Fix clock handling Xen: Adapt clock tests docs/formatdomain.html.in | 18 ++- docs/schemas/domaincommon.rng | 30 +++- src/conf/domain_conf.c

Re: [libvirt] [PATCHv2 0/3] Xen: Fix clock handling

2012-02-14 Thread Philipp Hahn
an attribute to force the parser to the old behaviour of utc/localtime, which was perfectly clear. But if it improves compatibility, I'm fine with this solution. Thank you for your feedback so far. BYtE Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention

[libvirt] [PATCHv3 1/3] Support clock=variable relative to localtime

2012-02-14 Thread Philipp Hahn
the new 'basis' attribute in the HTML documentation. Adapt test for the new attribute. Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatdomain.html.in | 18 +- docs/schemas/domaincommon.rng | 30 -- src/conf/domain_conf.c

[libvirt] [PATCHv3 2/3] Xen: Fix clock handling

2012-02-14 Thread Philipp Hahn
as a shortcut to offset='variable' with basis='...'. Signed-off-by: Philipp Hahn h...@univention.de --- src/xenxs/xen_sxpr.c | 167 ++ src/xenxs/xen_xm.c | 123 + 2 files changed, 225 insertions(+), 65 deletions

Re: [libvirt] [PATCHv3 1/3] Support clock=variable relative to localtime

2012-02-14 Thread Philipp Hahn
Hi, forgot one line to commit On Monday 06 February 2012 14:59:16 Philipp Hahn wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index aa4b32d..5508fc9 100644 ... @@ -7467,10 +7471,52 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps, def-clock.offset

[libvirt] [PATCHv4 1/3] Support clock=variable relative to localtime

2012-02-14 Thread Philipp Hahn
the new 'basis' attribute in the HTML documentation. Adapt test for the new attribute. Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatdomain.html.in | 18 +- docs/schemas/domaincommon.rng | 30 -- src/conf/domain_conf.c

[libvirt] [PATCHv4 2/3] Xen: Fix clock handling

2012-02-14 Thread Philipp Hahn
as a shortcut to offset='variable' with basis='...'. Signed-off-by: Philipp Hahn h...@univention.de --- src/xenxs/xen_sxpr.c | 167 ++ src/xenxs/xen_xm.c | 123 + 2 files changed, 225 insertions(+), 65 deletions

[libvirt] [PATCHv4 0/3] Xen: Fix clock handling

2012-02-14 Thread Philipp Hahn
+ update version numbers to 0.9.11 Since v3: + Add missing offset=VARIALE for adjustment='$timeDelta' conversion. Philipp Hahn (3): Support clock=variable relative to localtime Xen: Fix clock handling Xen: Adapt clock tests docs/formatdomain.html.in | 18 ++- docs

Re: [libvirt] [PATCHv2 0/3] Xen: Fix clock handling

2012-02-12 Thread Philipp Hahn
though that is a valid input form. This is the only point I (slightly) dislike, since then there would be two ways to archive the same configuration, but I think this is worth paying for the price of backward compatibility. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software

[libvirt] [PATCHv2 1/3] Support clock=variable relative to localtime

2012-02-09 Thread Philipp Hahn
'qemu' to the new name. Extend the RelaxNG schema accordingly. Document the new 'basis' attribute in the HTML documentation. Adapt test for the new attribute. Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatdomain.html.in |7 - docs/schemas

[libvirt] [PATCHv2 3/3] Xen: Adapt clock tests

2012-02-09 Thread Philipp Hahn
localtime = 0 is always inserted, because otherwise on updates the value is not changed within XenD. Some statements change their order becaus code was moved around. Signed-off-by: Philipp Hahn h...@univention.de --- tests/xmconfigdata/sexpr2xml-pv-bootloader.cfg |1 + tests

[libvirt] [PATCHv2 2/3] Xen: Fix clock handling

2012-02-09 Thread Philipp Hahn
implements: The RTC is NOT reset back to the specified time on next restart, but the previous offset is kept. Signed-off-by: Philipp Hahn h...@univention.de --- src/xenxs/xen_sxpr.c | 161 + src/xenxs/xen_xm.c | 116

[libvirt] [PATCHv2 0/3] Xen: Fix clock handling

2012-02-09 Thread Philipp Hahn
should probably receive some more testing, so for 0.9.10 it's too late. If it's not included, I'd need to update the reference to the version when this patch will get in. Philipp Hahn (3): Support clock=variable relative to localtime Xen: Fix clock handling Xen: Adapt clock tests docs

[libvirt] [PATCH] xen_xm: Fix SIGSEGV in xenXMDomainDefineXML

2012-02-06 Thread Philipp Hahn
-off-by: Philipp Hahn h...@univention.de --- src/xen/xm_internal.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index a34e906..02a0e1d 100644 --- a/src/xen/xm_internal.c +++ b/src/xen/xm_internal.c @@ -1196,7 +1196,8

[libvirt] [PATCH] xen-xm: fix data loss in domain edit

2012-02-06 Thread Philipp Hahn
-off-by: Philipp Hahn h...@univention.de --- src/xen/xm_internal.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index 02a0e1d..3cb315a 100644 --- a/src/xen/xm_internal.c +++ b/src/xen/xm_internal.c @@ -1073,6 +1073,7

[libvirt] [PATCH] xen-xm: SIGSEGV in xenXMDomainDefineXML: filename

2012-02-06 Thread Philipp Hahn
filename is not initialized to NULL while it's unconditionally freed in the error path. Signed-off-by: Philipp Hahn h...@univention.de --- src/xen/xm_internal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index 3cb315a

[libvirt] [PATCH] virterror.c: Fix several spelling mistakes

2012-02-03 Thread Philipp Hahn
compat{a-i}bility erron{-e}ous nec{c-}essary. Either the or a. Signed-off-by: Philipp Hahn h...@univention.de --- ChangeLog-old | 36 ++-- docs/drvlxc.html.in |2 +- docs/formatdomain.html.in |4 ++-- docs/locking.html.in

Re: [libvirt] [PATCH] xen_xs: name xendConfigVersion magic numbers

2012-02-01 Thread Philipp Hahn
Hello Eric, Am Donnerstag 02 Februar 2012 00:28:37 schrieben Sie: On 01/31/2012 10:08 AM, Philipp Hahn wrote: ... +#define XEND_CONFIG_VERSION_3_0_2 1 +#define XEND_CONFIG_VERSION_3_0_3 2 +#define XEND_CONFIG_VERSION_3_0_4 3 +#define XEND_CONFIG_VERSION_3_1_0 4 This fails 'make syntax

Re: [libvirt] [PATCH] tests: virnettlscontexttest needs gnutls-2.6.0

2012-01-31 Thread Philipp Hahn
|GNUTLS_1_0_COMPAT|GNUTLS_FSAN_APPEND' /usr/include/gnutls/* /usr/include/gnutls/compat.h:#define LIBGNUTLS_VERSION_NUMBER GNUTLS_VERSION_NUMBER /usr/include/gnutls/gnutls.h:#define GNUTLS_VERSION_NUMBER 0x020806 /usr/include/gnutls/x509.h:#define GNUTLS_FSAN_APPEND 1 BYtE Philipp -- Philipp Hahn

Re: [libvirt] [PATCH] tests: dynamically replace dnsmasq path

2012-01-31 Thread Philipp Hahn
end of the buffer, as long as we have a trailing NUL to stop us in time. Fine with me for this simple test case, but if that would be generalized and be used in other places, this might become a problem. I'll add a comment. Sincerely Philipp -- Philipp Hahn Open Source Software

Re: [libvirt] [PATCH] tests: virnettlscontexttest needs gnutls-2.6.0

2012-01-31 Thread Philipp Hahn
Hello, On Monday 30 January 2012 18:44:13 Philipp Hahn wrote: +#if !defined WIN32 HAVE_LIBTASN1_H !defined GNUTLS_1_0_COMPAT LIBGNUTLS_VERSION_NUMBER 0x020600 That should probably be = instead of , but I haven't checked the gnutls source code history. Sincerely Philipp -- Philipp Hahn

[libvirt] [PATCH v2] tests: virnettlscontexttest needs gnutls-2.6.0

2012-01-31 Thread Philipp Hahn
of GNUTLS is at least 2.6.0. v2: greater-equal 2.6.0 instead of strictly greater. Signed-off-by: Philipp Hahn h...@univention.de --- tests/virnettlscontexttest.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c

[libvirt] [PATCH v2] tests: dynamically replace dnsmasq path

2012-01-31 Thread Philipp Hahn
-by: Philipp Hahn h...@univention.de --- tests/networkxml2argvdata/isolated-network.argv|2 +- .../networkxml2argvdata/nat-network-dns-hosts.argv |2 +- .../nat-network-dns-srv-record-minimal.argv|2 +- .../nat-network-dns-srv-record.argv|2 +- .../nat-network

Re: [libvirt] [PATCH] Xen: Fix clock handling

2012-01-31 Thread Philipp Hahn
Hello Daniel, On Tuesday 17 January 2012 22:24:11 Daniel P. Berrange wrote: On Tue, Jan 17, 2012 at 05:02:14PM +0100, Philipp Hahn wrote: For PV, Xen implements the clock offset='utc' and clock offset='localtime' behaviour, while for HV it implements clock offset='variable

[libvirt] [PATCH] xen_xs: name xendConfigVersion magic numbers

2012-01-31 Thread Philipp Hahn
-by: Philipp Hahn h...@univention.de --- .../0013-improve-getting-xen-vcpu-counts.patch |2 +- .../0014-improve-setting-xen-vcpu-counts.patch |6 +- docs/api_extension/0015-remove-dead-xen-code.patch |2 +- src/xen/xen_driver.c | 14 ++-- src/xen

[libvirt] [PATCH] tests: virnettlscontexttest needs gnutls-2.6.0

2012-01-30 Thread Philipp Hahn
of GNUTLS is at least 2.6.0. Signed-off-by: Philipp Hahn h...@univention.de --- tests/virnettlscontexttest.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c index 51f75b4..6dd42d4 100644 --- a/tests

[libvirt] [PATCH] tests: dynamically replace dnsmasq path

2012-01-30 Thread Philipp Hahn
single one, which I consider less flexible.) Signed-off-by: Philipp Hahn h...@univention.de --- tests/networkxml2argvdata/isolated-network.argv|2 +- .../networkxml2argvdata/nat-network-dns-hosts.argv |2 +- .../nat-network-dns-srv-record-minimal.argv|2 +- .../nat-network

[libvirt] [PATCH] XenXs: Update documentation

2012-01-30 Thread Philipp Hahn
Fix several references to now renamed functions and parameters when the functions were moved from src/xen/ to src/xenxs/. Signed-off-by: Philipp Hahn h...@univention.de --- src/xenxs/xen_sxpr.c | 222 + 1 files changed, 185 insertions(+), 37

Re: [libvirt] [libvirt-glib] Prefer 'for' over 'while'

2012-01-25 Thread Philipp Hahn
; Your changed version only has the same behaviour, if the user-passed-in function iter_func() never changes it-next, which you can't guarentee here. You need to keep the next copy. BYtE Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbH

Re: [libvirt] [BUG] EPOLL_CLOEXEC undeclared

2012-01-23 Thread Philipp Hahn
disabled or refuses to compile. I did NOT test if it still compiles on newer systems. Reported by Philipp Hahn. You may add a Testes-by: me if needed. Thank you for your work and the patch. BYtE Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbH

Re: [libvirt] [PATCH] Xen: Fix clock handling

2012-01-18 Thread Philipp Hahn
Hello Daniel, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jan 17, 2012 at 05:02:14PM +0100, Philipp Hahn wrote: For PV, Xen implements the clock offset='utc' and clock offset='localtime' behaviour, while for HV it implements clock offset='variable'. This difference is important

Re: [libvirt] [BUG] EPOLL_CLOEXEC undeclared

2012-01-18 Thread Philipp Hahn
Hello Eric, Eric Blake ebl...@redhat.com wrote: On 01/17/2012 04:42 AM, Philipp Hahn wrote: And what kernel is that system running? 2.6.32 We already refuse to compile lxc for RHEL 5 (kernel 2.6.18), as that particular kernel is too old to usefully support namespace and other operations

Re: [libvirt] [BUG] EPOLL_CLOEXEC undeclared

2012-01-17 Thread Philipp Hahn
Hello Eric, thank you for taking a look at my problem. On Monday 16 January 2012 16:36:00 Eric Blake wrote: On 01/16/2012 08:07 AM, Philipp Hahn wrote: $ dpkg-query -W linux-libc-dev linux-libc-dev 2.6.32-35~ucs1.48.201109051614 glibc has supported epoll_create1() and EPOLL_CLOEXEC since

[libvirt] [PATCH] Xen: Fix clock handling

2012-01-17 Thread Philipp Hahn
, but the previous offset is re-used. Xen-HV also supports rtc_timeoffset relative to localtime=1, but currently there is no mapping to libvirts clock syntax; such a configuration will return an error. Signed-off-by: Philipp Hahn h...@univention.de --- src/xenxs/xen_sxpr.c | 85

[libvirt] [PATCH] XenXs: Update documentation

2012-01-17 Thread Philipp Hahn
Fix several references to now renamed functions and parameters when the functions were moved from src/xen/ to src/xenxs/. Signed-off-by: Philipp Hahn h...@univention.de --- src/xenxs/xen_sxpr.c | 222 + 1 files changed, 185 insertions(+), 37

[libvirt] [BUG] EPOLL_CLOEXEC undeclared

2012-01-16 Thread Philipp Hahn
Date: Thu Jan 12 17:03:03 2012 + Re-write LXC controller end-of-file I/O handling yet again Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str

[libvirt] [BUG, PATCH-RFC] libvirt localtime and rtc_timeoffset handling in xen-sexpr/sxpr/sxp

2012-01-11 Thread Philipp Hahn
a statement like Xen-3.x and Xen-4.y are actively supported by libvirt-0.a.b; older versions might still work (by accident ;-) Before I forward-port that change to 0.9.10 I'd like to get some comments. Thanks in advance. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software

Re: [libvirt] [Xen-devel] [BUG, PATCH-RFC] libvirt localtime and rtc_timeoffset handling in xen-sexpr/sxpr/sxp

2012-01-11 Thread Philipp Hahn
Hello Ian, Am Mittwoch 11 Januar 2012 12:54:04 schrieb Ian Campbell: On Wed, 2012-01-11 at 10:20 +, Philipp Hahn wrote: I'm currently tracking a problem in libvirt regarding Xens handling of localtime and rtc_timeoffset. My current understanding (Xen-3.4.3 and Xen-4.1.2 under Linux

Re: [libvirt] [Xen-devel] [BUG] insufficient quoting between tap-ctl list and xend/server/BlktapController.py

2011-12-02 Thread Philipp Hahn
Hello, On Thursday 01 December 2011 19:31:04 Ian Jackson wrote: Philipp Hahn writes (Re: [Xen-devel] [BUG] insufficient quoting between tap-ctl list and xend/server/BlktapController.py): As a quick work-around, the attached patch fixes the problem for me. That is, until tap-ctl changes it's

Re: [libvirt] Upgrade-problems from qemu-0.14.1 + libvirt-0.8.4 to qemu-0.15.1 + libvirt-0.9.6: Why I think multifunction=on is a bad idea...

2011-11-28 Thread Philipp Hahn
invalidate your snapshots and saved state. (*): As Debian does for DFSG-compliance, since it replaces the seabios / vgabios / pxe-bios as shipped with qemu by a version compiled from (different) sources. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de

Re: [libvirt] Upgrade-problems from qemu-0.14.1 + libvirt-0.8.4 to qemu-0.15.1 + libvirt-0.9.6: Why I think multifunction=on is a bad idea...

2011-11-17 Thread Philipp Hahn
-- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http

[libvirt] Upgrade-problems from qemu-0.14.1 + libvirt-0.8.4 to qemu-0.15.1 + libvirt-0.9.6: Why I think multifunction=on is a bad idea...

2011-11-15 Thread Philipp Hahn
the qemu command line from the XML data. Sincerely Philipp PS: I hope that info helps other people when getting those messages. -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville

Re: [libvirt] [PATCH v2 1/4] doc: Add deviceboot capability.

2011-11-03 Thread Philipp Hahn
Hello, Ping? At least this patch should qualify for 0.9.7. Currently it's only used by qemu, but currently there's no test case for qemu, which uses deviceboot, so it was never noticed that it's missing in the schema. On Tuesday 01 November 2011 10:27:47 Philipp Hahn wrote: Allow

Re: [libvirt] [libvirt[]PATCH v2] Fix URI alias prefix matching

2011-11-01 Thread Philipp Hahn
? Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99

[libvirt] [PATCH v2 4/4] test/xen: PyGrub device order using boot/@order

2011-11-01 Thread Philipp Hahn
Adapt all Xen-sexpr tests to now contain the extra '(bootbale [01])' flag. It is explicitly set, otherwise Xend remembers the old state and only ever adds the bootable indicator. Signed-off-by: Philipp Hahn h...@univention.de --- v2: Add deviceboot capability. --- tests/sexpr2xmldata/sexpr2xml

[libvirt] [PATCH v2 0/4] Xen-PV PyGrub support

2011-11-01 Thread Philipp Hahn
review. It might be better to commit the last three patches as one, since bi-section is broken otherwise. Changes since v1: * explicitly sort disks by bootIndex on XML to S-Expr. * Add deviceboot capability. Philipp Hahn (4): doc: Add deviceboot capability. xen: support bootable flag for Xen-PV

[libvirt] [PATCH v2 1/4] doc: Add deviceboot capability.

2011-11-01 Thread Philipp Hahn
Allow /capabilities/guest/features/deviceboot. Signed-off-by: Philipp Hahn h...@univention.de --- docs/schemas/capability.rng |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index 99b4a9a..0a63a1c 100644

<    1   2   3   4   >