Re: [PATCH] qemu: save status xml after generating taint message

2021-07-23 Thread Peter Krempa
On Fri, Jul 23, 2021 at 10:27:47 +0200, Michal Prívozník wrote: > On 7/23/21 5:00 AM, Fangge Jin wrote: > > > > > > On Wed, Jul 21, 2021 at 10:54 PM Michal Prívozník > > wrote: > > > > > > > The bug quoted shows a few examples where we fail to save status. > >

Re: [PATCH] qemu: save status xml after generating taint message

2021-07-23 Thread Michal Prívozník
On 7/23/21 5:00 AM, Fangge Jin wrote: > > > On Wed, Jul 21, 2021 at 10:54 PM Michal Prívozník > wrote: > > > > The bug quoted shows a few examples where we fail to save status. > > > > I'm very surprised we don't save status when hotplugging a NIC or a

Re: [PATCH] qemu: save status xml after generating taint message

2021-07-22 Thread Fangge Jin
On Wed, Jul 21, 2021 at 10:54 PM Michal Prívozník wrote: > > > The bug quoted shows a few examples where we fail to save status. > > > > I'm very surprised we don't save status when hotplugging a NIC or a > > disk, as the BZ suggests. > > I'm not convinced that the steps there are 100% correct.

Re: [PATCH] qemu: save status xml after generating taint message

2021-07-21 Thread Kristina Hanicova
On Wed, Jul 21, 2021 at 2:29 PM Peter Krempa wrote: > On Wed, Jul 21, 2021 at 14:05:05 +0200, Kristina Hanicova wrote: > > We didn't always save status xml after generating new taint > > message, which resulted in it being deleted in case of a libvirtd > > restart. Some taint messages were

Re: [PATCH] qemu: save status xml after generating taint message

2021-07-21 Thread Michal Prívozník
On 7/21/21 3:02 PM, Daniel P. Berrangé wrote: > On Wed, Jul 21, 2021 at 02:29:34PM +0200, Peter Krempa wrote: >> On Wed, Jul 21, 2021 at 14:05:05 +0200, Kristina Hanicova wrote: >>> We didn't always save status xml after generating new taint >>> message, which resulted in it being deleted in case

Re: [PATCH] qemu: save status xml after generating taint message

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 02:29:34PM +0200, Peter Krempa wrote: > On Wed, Jul 21, 2021 at 14:05:05 +0200, Kristina Hanicova wrote: > > We didn't always save status xml after generating new taint > > message, which resulted in it being deleted in case of a libvirtd > > restart. Some taint messages

Re: [PATCH] qemu: save status xml after generating taint message

2021-07-21 Thread Peter Krempa
On Wed, Jul 21, 2021 at 14:05:05 +0200, Kristina Hanicova wrote: > We didn't always save status xml after generating new taint > message, which resulted in it being deleted in case of a libvirtd > restart. Some taint messages were preserved thanks to saving > status xml separately at the end of

[PATCH] qemu: save status xml after generating taint message

2021-07-21 Thread Kristina Hanicova
We didn't always save status xml after generating new taint message, which resulted in it being deleted in case of a libvirtd restart. Some taint messages were preserved thanks to saving status xml separately at the end of the calling functions (which makes sense, because qemuDomainObjTaint was