Re: [PATCH] storage: fix vstorage backend build

2020-07-14 Thread Nikolay Shirokovskiy
On 13.07.2020 12:16, Andrea Bolognani wrote: > On Mon, 2020-07-13 at 11:52 +0300, Nikolay Shirokovskiy wrote: >> On 13.07.2020 09:57, Nikolay Shirokovskiy wrote: >>> On 10.07.2020 21:17, Andrea Bolognani wrote: If you look at the list of packages through the provided "repoview" files,

Re: [PATCH] storage: fix vstorage backend build

2020-07-13 Thread Andrea Bolognani
On Mon, 2020-07-13 at 11:52 +0300, Nikolay Shirokovskiy wrote: > On 13.07.2020 09:57, Nikolay Shirokovskiy wrote: > > On 10.07.2020 21:17, Andrea Bolognani wrote: > > > If you look at the list of packages through the provided "repoview" > > > files, the releases from the second repository contain

Re: [PATCH] storage: fix vstorage backend build

2020-07-13 Thread Nikolay Shirokovskiy
On 13.07.2020 09:57, Nikolay Shirokovskiy wrote: > > > On 10.07.2020 21:17, Andrea Bolognani wrote: >> On Fri, 2020-07-10 at 18:26 +0100, Daniel P. Berrangé wrote: >>> On Fri, Jul 10, 2020 at 06:40:07PM +0200, Andrea Bolognani wrote: That failed with Error: Package:

Re: [PATCH] storage: fix vstorage backend build

2020-07-13 Thread Nikolay Shirokovskiy
On 10.07.2020 21:17, Andrea Bolognani wrote: > On Fri, 2020-07-10 at 18:26 +0100, Daniel P. Berrangé wrote: >> On Fri, Jul 10, 2020 at 06:40:07PM +0200, Andrea Bolognani wrote: >>> That failed with >>> >>> Error: Package: vstorage-libs-shared-7.10.1.5-1.vz7.x86_64 (vz) >>>

Re: [PATCH] storage: fix vstorage backend build

2020-07-13 Thread Nikolay Shirokovskiy
On 10.07.2020 20:26, Daniel P. Berrangé wrote: > On Fri, Jul 10, 2020 at 06:40:07PM +0200, Andrea Bolognani wrote: >> On Fri, 2020-07-10 at 10:10 +0300, Nikolay Shirokovskiy wrote: >>> On 09.07.2020 19:06, Andrea Bolognani wrote: One thing at a time, though. First, how do we get the

Re: [PATCH] storage: fix vstorage backend build

2020-07-13 Thread Nikolay Shirokovskiy
On 10.07.2020 19:40, Andrea Bolognani wrote: > On Fri, 2020-07-10 at 10:10 +0300, Nikolay Shirokovskiy wrote: >> On 09.07.2020 19:06, Andrea Bolognani wrote: >>> One thing at a time, though. First, how do we get the vstorage >>> commands included in the CentOS 7 container? What packages need to

Re: [PATCH] storage: fix vstorage backend build

2020-07-10 Thread Andrea Bolognani
On Fri, 2020-07-10 at 18:26 +0100, Daniel P. Berrangé wrote: > On Fri, Jul 10, 2020 at 06:40:07PM +0200, Andrea Bolognani wrote: > > That failed with > > > > Error: Package: vstorage-libs-shared-7.10.1.5-1.vz7.x86_64 (vz) > > Requires: libjson-c.so.2(libjson-c.so.2)(64bit) > > > >

Re: [PATCH] storage: fix vstorage backend build

2020-07-10 Thread Daniel P . Berrangé
On Fri, Jul 10, 2020 at 06:40:07PM +0200, Andrea Bolognani wrote: > On Fri, 2020-07-10 at 10:10 +0300, Nikolay Shirokovskiy wrote: > > On 09.07.2020 19:06, Andrea Bolognani wrote: > > > One thing at a time, though. First, how do we get the vstorage > > > commands included in the CentOS 7

Re: [PATCH] storage: fix vstorage backend build

2020-07-10 Thread Andrea Bolognani
On Fri, 2020-07-10 at 10:10 +0300, Nikolay Shirokovskiy wrote: > On 09.07.2020 19:06, Andrea Bolognani wrote: > > One thing at a time, though. First, how do we get the vstorage > > commands included in the CentOS 7 container? What packages need to > > be installed, and from what repository? > >

Re: [PATCH] storage: fix vstorage backend build

2020-07-10 Thread Nikolay Shirokovskiy
On 09.07.2020 19:06, Andrea Bolognani wrote: > On Tue, 2020-07-07 at 15:00 +0300, Nikolay Shirokovskiy wrote: >> Add headers with declarations of geteuid/getegid >> and virGetUserName/virGetGroupName. > > Can you share the exact error message you're hitting? Our CI seems to > be perfectly

Re: [PATCH] storage: fix vstorage backend build

2020-07-09 Thread Andrea Bolognani
On Tue, 2020-07-07 at 15:00 +0300, Nikolay Shirokovskiy wrote: > Add headers with declarations of geteuid/getegid > and virGetUserName/virGetGroupName. Can you share the exact error message you're hitting? Our CI seems to be perfectly happy with the current status quo. Specifically, the

[PATCH] storage: fix vstorage backend build

2020-07-07 Thread Nikolay Shirokovskiy
Add headers with declarations of geteuid/getegid and virGetUserName/virGetGroupName. Signed-off-by: Nikolay Shirokovskiy --- src/storage/storage_backend_vstorage.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/storage/storage_backend_vstorage.c