Re: [PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-07-26 Thread Martin Kletzander
On Sun, Jul 24, 2022 at 10:50:36AM +0530, Amneesh Singh wrote: On Fri, Jul 22, 2022 at 07:09:57PM +0200, Paolo Bonzini wrote: On 7/22/22 17:43, Martin Kletzander wrote: > As mentioned before, all these failures do not have to exit the > function, but rather fallback to the old way. You can

Re: [PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-07-23 Thread Amneesh Singh
On Fri, Jul 22, 2022 at 07:09:57PM +0200, Paolo Bonzini wrote: > On 7/22/22 17:43, Martin Kletzander wrote: > > As mentioned before, all these failures do not have to exit the > > function, but rather fallback to the old way. You can even create > > two new functions for the new and old

Re: [PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-07-22 Thread Paolo Bonzini
On 7/22/22 17:43, Martin Kletzander wrote: As mentioned before, all these failures do not have to exit the function, but rather fallback to the old way. You can even create two new functions for the new and old implementations and then call them from here to make the fallback easier to spot

Re: [PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-07-22 Thread Martin Kletzander
On Thu, Jul 14, 2022 at 11:22:04AM +0530, Amneesh Singh wrote: Related: https://gitlab.com/libvirt/libvirt/-/issues/276 This patch uses qemuMonitorQueryStats to query "halt_poll_success_ns" and "halt_poll_fail_ns" for every vCPU. The respective values for each vCPU are then added together.

[PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-07-13 Thread Amneesh Singh
Related: https://gitlab.com/libvirt/libvirt/-/issues/276 This patch uses qemuMonitorQueryStats to query "halt_poll_success_ns" and "halt_poll_fail_ns" for every vCPU. The respective values for each vCPU are then added together. Signed-off-by: Amneesh Singh --- src/qemu/qemu_driver.c | 69

Re: [PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-06-30 Thread Michal Prívozník
On 6/29/22 12:47, Amneesh Singh wrote: > On Wed, Jun 29, 2022 at 09:03:33AM +0200, Michal Prívozník wrote: >> On 6/28/22 22:25, Martin Kletzander wrote: >>> On Tue, Jun 28, 2022 at 10:15:28PM +0530, Amneesh Singh wrote: On Tue, Jun 28, 2022 at 05:23:11PM +0200, Michal Prívozník wrote: >

Re: [PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-06-29 Thread Amneesh Singh
On Wed, Jun 29, 2022 at 09:03:33AM +0200, Michal Prívozník wrote: > On 6/28/22 22:25, Martin Kletzander wrote: > > On Tue, Jun 28, 2022 at 10:15:28PM +0530, Amneesh Singh wrote: > >> On Tue, Jun 28, 2022 at 05:23:11PM +0200, Michal Prívozník wrote: > >>> On 6/24/22 10:14, Amneesh Singh wrote: >

Re: [PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-06-29 Thread Michal Prívozník
On 6/28/22 22:25, Martin Kletzander wrote: > On Tue, Jun 28, 2022 at 10:15:28PM +0530, Amneesh Singh wrote: >> On Tue, Jun 28, 2022 at 05:23:11PM +0200, Michal Prívozník wrote: >>> On 6/24/22 10:14, Amneesh Singh wrote: >>> > Related: https://gitlab.com/libvirt/libvirt/-/issues/276 >>> > >>> >

Re: [PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-06-28 Thread Amneesh Singh
On Tue, Jun 28, 2022 at 10:25:54PM +0200, Martin Kletzander wrote: > On Tue, Jun 28, 2022 at 10:15:28PM +0530, Amneesh Singh wrote: > > On Tue, Jun 28, 2022 at 05:23:11PM +0200, Michal Prívozník wrote: > > > On 6/24/22 10:14, Amneesh Singh wrote: > > > > Related:

Re: [PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-06-28 Thread Martin Kletzander
On Tue, Jun 28, 2022 at 10:15:28PM +0530, Amneesh Singh wrote: On Tue, Jun 28, 2022 at 05:23:11PM +0200, Michal Prívozník wrote: On 6/24/22 10:14, Amneesh Singh wrote: > Related: https://gitlab.com/libvirt/libvirt/-/issues/276 > > This patch uses qemuMonitorQueryStats to query

Re: [PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-06-28 Thread Amneesh Singh
On Tue, Jun 28, 2022 at 05:23:11PM +0200, Michal Prívozník wrote: > On 6/24/22 10:14, Amneesh Singh wrote: > > Related: https://gitlab.com/libvirt/libvirt/-/issues/276 > > > > This patch uses qemuMonitorQueryStats to query "halt_poll_success_ns" > > and "halt_poll_fail_ns" for every vCPU. The

Re: [PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-06-28 Thread Michal Prívozník
On 6/24/22 10:14, Amneesh Singh wrote: > Related: https://gitlab.com/libvirt/libvirt/-/issues/276 > > This patch uses qemuMonitorQueryStats to query "halt_poll_success_ns" > and "halt_poll_fail_ns" for every vCPU. The respective values for each > vCPU are then added together. > > Signed-off-by:

[PATCH 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-06-24 Thread Amneesh Singh
Related: https://gitlab.com/libvirt/libvirt/-/issues/276 This patch uses qemuMonitorQueryStats to query "halt_poll_success_ns" and "halt_poll_fail_ns" for every vCPU. The respective values for each vCPU are then added together. Signed-off-by: Amneesh Singh --- src/qemu/qemu_driver.c | 48