On Wed, Dec 10, 2008 at 06:06:51AM -0500, Itamar Heim wrote:
Sure - probably not a good idea to send patches at such a late hour anyway
:)
Attached diff.
Some more details:
For those using SDL (for some crazy reason as Berrange put it in the
original patch), there is a use for the
sdl xml
(via fullscreen='true' attribute for the graphics element)
On Wed, Dec 10, 2008 at 06:06:51AM -0500, Itamar Heim wrote:
Sure - probably not a good idea to send patches at such a late hour
anyway
:)
Attached diff.
Some more details:
For those using SDL (for some crazy reason
On Thu, Dec 11, 2008 at 12:44:32PM +0100, Daniel Veillard wrote:
On Wed, Dec 10, 2008 at 06:06:51AM -0500, Itamar Heim wrote:
Sure - probably not a good idea to send patches at such a late hour anyway
:)
Attached diff.
Some more details:
For those using SDL (for some crazy reason as
On Thu, Dec 11, 2008 at 06:55:49AM -0500, Itamar Heim wrote:
Thanks!
I assume the tests were added as well apart from the patch?
yes even if they don't show in the patch. Just do a cvs update in
your checkout (assuming cvs) you should get them !
Daniel
--
Daniel Veillard | libxml
variables)
-Original Message-
From: Daniel Veillard [mailto:[EMAIL PROTECTED]
Sent: Wednesday, December 10, 2008 9:49 AM
To: Itamar Heim
Cc: Libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH] add fullscreen support to qemu sdl xml
(via fullscreen='true' attribute for the graphics
On Wed, Dec 10, 2008 at 06:06:51AM -0500, Itamar Heim wrote:
Sure - probably not a good idea to send patches at such a late hour anyway
:)
Attached diff.
Some more details:
For those using SDL (for some crazy reason as Berrange put it in the
original patch), there is a use for the
-Original Message-
From: Daniel Veillard [mailto:[EMAIL PROTECTED]
Looks overall fine to me, the syntactic construct sounds generic
enough.
I would still suggest 2 more changes:
- in virDomainGraphicsDefParseXML check the values coming from
the XML, I guess we should
-Original Message-
From: Daniel P. Berrange [mailto:[EMAIL PROTECTED]
In this bit of the code:
diff --git a/src/domain_conf.h b/src/domain_conf.h
index 51cf6d5..436d0b1 100644
--- a/src/domain_conf.h
+++ b/src/domain_conf.h
@@ -268,6 +268,7 @@ struct _virDomainGraphicsDef {
On Wed, Dec 10, 2008 at 07:49:32AM -0500, Itamar Heim wrote:
-Original Message-
From: Daniel P. Berrange [mailto:[EMAIL PROTECTED]
In this bit of the code:
diff --git a/src/domain_conf.h b/src/domain_conf.h
index 51cf6d5..436d0b1 100644
--- a/src/domain_conf.h
+++
On Wed, Dec 10, 2008 at 06:06:51AM -0500, Itamar Heim wrote:
Sure - probably not a good idea to send patches at such a late hour anyway
:)
Attached diff.
In this bit of the code:
diff --git a/src/domain_conf.h b/src/domain_conf.h
index 51cf6d5..436d0b1 100644
--- a/src/domain_conf.h
+++
Daniel P. Berrange wrote:
And in the struct
int fullscreen : 1;
unsigned int fullscreen : 1;
would be better (so the possible values are 0 and 1).
-jim
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff --git a/src/domain_conf.c b/src/domain_conf.c
index 32ed59f..018d07f 100644
--- a/src/domain_conf.c
+++ b/src/domain_conf.c
@@ -212,6 +212,7 @@ void virDomainGraphicsDefFree(virDomainGraphicsDefPtr
def)
case VIR_DOMAIN_GRAPHICS_TYPE_SDL:
VIR_FREE(def-data.sdl.display);
On Tue, Dec 09, 2008 at 07:12:05PM -0500, Itamar Heim wrote:
diff --git a/src/domain_conf.c b/src/domain_conf.c
Hum, I don't know how you sent the diff, but it got broken when
reaching my mail agent. Please add as an attachment.
Also in general it's a good idea to put some text describing
13 matches
Mail list logo
