Re: [libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

2018-02-09 Thread Chris Friesen
On 02/09/2018 04:15 AM, Daniel P. Berrangé wrote: On Thu, Feb 08, 2018 at 01:24:58PM -0600, Chris Friesen wrote: Given your comment above about "I don't want to see the semantics of that change", it sounds like you're suggesting: 1) If there are any non-shared non-readonly network drives

Re: [libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

2018-02-09 Thread Daniel P . Berrangé
On Thu, Feb 08, 2018 at 01:24:58PM -0600, Chris Friesen wrote: > On 02/08/2018 03:07 AM, Daniel P. Berrangé wrote: > > On Wed, Feb 07, 2018 at 01:11:33PM -0600, Chris Friesen wrote: > > > Are you okay with the other change? > > > > That part of the code was intended to be funtionally identical to

Re: [libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

2018-02-08 Thread Peter Krempa
On Thu, Feb 08, 2018 at 13:24:58 -0600, Chris Friesen wrote: > On 02/08/2018 03:07 AM, Daniel P. Berrangé wrote: > > On Wed, Feb 07, 2018 at 01:11:33PM -0600, Chris Friesen wrote: > > > Are you okay with the other change? > > > > That part of the code was intended to be funtionally identical to

Re: [libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

2018-02-08 Thread Chris Friesen
On 02/08/2018 03:07 AM, Daniel P. Berrangé wrote: On Wed, Feb 07, 2018 at 01:11:33PM -0600, Chris Friesen wrote: Are you okay with the other change? That part of the code was intended to be funtionally identical to what QEMU's previous built-in storage migration code would do. I don't want to

Re: [libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

2018-02-08 Thread Daniel P . Berrangé
On Wed, Feb 07, 2018 at 01:11:33PM -0600, Chris Friesen wrote: > On 02/07/2018 12:05 PM, Daniel P. Berrangé wrote: > > On Wed, Feb 07, 2018 at 11:57:19AM -0600, Chris Friesen wrote: > > > In the current implementation of qemuMigrateDisk() the value of the > > > "nmigrate_disks" parameter wrongly

Re: [libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

2018-02-08 Thread Peter Krempa
On Wed, Feb 07, 2018 at 13:11:33 -0600, Chris Friesen wrote: > On 02/07/2018 12:05 PM, Daniel P. Berrangé wrote: > > On Wed, Feb 07, 2018 at 11:57:19AM -0600, Chris Friesen wrote: > > > In the current implementation of qemuMigrateDisk() the value of the > > > "nmigrate_disks" parameter wrongly

Re: [libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

2018-02-07 Thread Chris Friesen
On 02/07/2018 12:05 PM, Daniel P. Berrangé wrote: On Wed, Feb 07, 2018 at 11:57:19AM -0600, Chris Friesen wrote: In the current implementation of qemuMigrateDisk() the value of the "nmigrate_disks" parameter wrongly impacts the decision whether or not to migrate a disk that is not a member of

Re: [libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

2018-02-07 Thread Daniel P . Berrangé
On Wed, Feb 07, 2018 at 11:57:19AM -0600, Chris Friesen wrote: > In the current implementation of qemuMigrateDisk() the value of the > "nmigrate_disks" parameter wrongly impacts the decision whether or not > to migrate a disk that is not a member of "migrate_disks": > > 1) If "nmigrate_disks" is

[libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

2018-02-07 Thread Chris Friesen
In the current implementation of qemuMigrateDisk() the value of the "nmigrate_disks" parameter wrongly impacts the decision whether or not to migrate a disk that is not a member of "migrate_disks": 1) If "nmigrate_disks" is zero, "disk" is migrated if it's non-shared non-readonly with source. 2)