Re: [libvirt] [PATCH 2/2] snapshot: enforce REVERT_FORCE on qemu

2011-10-05 Thread Eric Blake
On 10/04/2011 04:02 PM, Eric Blake wrote: * src/qemu/qemu_driver.c (qemuDomainRevertToSnapshot): Check for risky situations, and allow force to get past them. ACK. Before pushing this, I'm running some sanity tests. So far, this test sequence (adjusted to the fixed code) shows where force

Re: [libvirt] [PATCH 2/2] snapshot: enforce REVERT_FORCE on qemu

2011-10-05 Thread Eric Blake
On 10/04/2011 04:02 PM, Eric Blake wrote: * src/qemu/qemu_driver.c (qemuDomainRevertToSnapshot): Check for risky situations, and allow force to get past them. ACK. Before pushing this, I'm running some sanity tests. So far, this test sequence (adjusted to the fixed code) shows where force

Re: [libvirt] [PATCH 2/2] snapshot: enforce REVERT_FORCE on qemu

2011-10-04 Thread Laine Stump
On 09/30/2011 02:52 PM, Eric Blake wrote: Implements the documentation for snapshot revert vs. force. Part of the patch tightens existing behavior (previously, reverting to an old snapshot withoutdomain was blindly attempted, now it requires force), while part of it relaxes behavior

Re: [libvirt] [PATCH 2/2] snapshot: enforce REVERT_FORCE on qemu

2011-10-04 Thread Eric Blake
On 10/04/2011 01:26 PM, Laine Stump wrote: On 09/30/2011 02:52 PM, Eric Blake wrote: Implements the documentation for snapshot revert vs. force. Part of the patch tightens existing behavior (previously, reverting to an old snapshot withoutdomain was blindly attempted, now it requires force),

Re: [libvirt] [PATCH 2/2] snapshot: enforce REVERT_FORCE on qemu

2011-10-04 Thread Eric Blake
On 10/04/2011 04:02 PM, Eric Blake wrote: Before pushing this, I'm running some sanity tests. So far, this test sequence (adjusted to the fixed code) shows where force helps with older snapshots (I'll send separate email for showing how force helps active ABI-incompatible snapshots): Test 1: $

[libvirt] [PATCH 2/2] snapshot: enforce REVERT_FORCE on qemu

2011-09-30 Thread Eric Blake
Implements the documentation for snapshot revert vs. force. Part of the patch tightens existing behavior (previously, reverting to an old snapshot without domain was blindly attempted, now it requires force), while part of it relaxes behavior (previously, it was not possible to revert an active