Re: [libvirt] [PATCH 3/9] datatypes: Rename @parent to @parentName in virNodeDevice

2018-04-16 Thread Michal Privoznik
On 04/16/2018 01:53 PM, John Ferlan wrote: > > > On 04/13/2018 10:47 AM, Michal Privoznik wrote: >> In next patches this name will be needed for a different memeber. > > s/memeber/member > >> Also, it makes sense to rename the variable because it does not >> contain reference to parent device,

Re: [libvirt] [PATCH 3/9] datatypes: Rename @parent to @parentName in virNodeDevice

2018-04-16 Thread Michal Privoznik
On 04/16/2018 09:26 AM, Erik Skultety wrote: > On Fri, Apr 13, 2018 at 04:47:10PM +0200, Michal Privoznik wrote: >> In next patches this name will be needed for a different memeber. >> Also, it makes sense to rename the variable because it does not >> contain reference to parent device, just its

Re: [libvirt] [PATCH 3/9] datatypes: Rename @parent to @parentName in virNodeDevice

2018-04-16 Thread Erik Skultety
On Mon, Apr 16, 2018 at 07:53:42AM -0400, John Ferlan wrote: > > > On 04/13/2018 10:47 AM, Michal Privoznik wrote: > > In next patches this name will be needed for a different memeber. > > s/memeber/member > > > Also, it makes sense to rename the variable because it does not > > contain reference

Re: [libvirt] [PATCH 3/9] datatypes: Rename @parent to @parentName in virNodeDevice

2018-04-16 Thread John Ferlan
On 04/13/2018 10:47 AM, Michal Privoznik wrote: > In next patches this name will be needed for a different memeber. s/memeber/member > Also, it makes sense to rename the variable because it does not > contain reference to parent device, just its name. > > Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH 3/9] datatypes: Rename @parent to @parentName in virNodeDevice

2018-04-16 Thread Erik Skultety
On Fri, Apr 13, 2018 at 04:47:10PM +0200, Michal Privoznik wrote: > In next patches this name will be needed for a different memeber. > Also, it makes sense to rename the variable because it does not > contain reference to parent device, just its name. > > Signed-off-by: Michal Privoznik

[libvirt] [PATCH 3/9] datatypes: Rename @parent to @parentName in virNodeDevice

2018-04-13 Thread Michal Privoznik
In next patches this name will be needed for a different memeber. Also, it makes sense to rename the variable because it does not contain reference to parent device, just its name. Signed-off-by: Michal Privoznik --- src/conf/virnodedeviceobj.c | 2 +-