Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Eduardo Habkost
On Wed, Feb 27, 2013 at 05:58:39PM +0100, Paolo Bonzini wrote: > Il 27/02/2013 17:19, Eduardo Habkost ha scritto: > >> > > >> > If it is meant as a prototype only, and the final command-line syntax > >> > would be with repeated keys, that's okay. I think that Eduardo/Markus/I > >> > are focusing

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 17:19, Eduardo Habkost ha scritto: >> > >> > If it is meant as a prototype only, and the final command-line syntax >> > would be with repeated keys, that's okay. I think that Eduardo/Markus/I >> > are focusing on the user interface, you're focusing in the implementation. >> > >> >

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Eduardo Habkost
On Wed, Feb 27, 2013 at 04:57:15PM +0100, Paolo Bonzini wrote: > Il 27/02/2013 16:42, Anthony Liguori ha scritto: > > There's such thing as list support in QemuOpts. The only way > > QemuOptsVisitor was able to implement it was to expose QemuOpts publicly > > via options_int.h and rely on a implem

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Eduardo Habkost
On Wed, Feb 27, 2013 at 09:42:50AM -0600, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 26/02/2013 20:35, Anthony Liguori ha scritto: > >> > >> See also discussion on multi-valued keys in command line option > >> arguments and config files in v1 thread. Hopefully we can

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 16:42, Anthony Liguori ha scritto: > There's such thing as list support in QemuOpts. The only way > QemuOptsVisitor was able to implement it was to expose QemuOpts publicly > via options_int.h and rely on a implementation detail. > > There are fixed types supported by QemuOpts. It

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Anthony Liguori
Paolo Bonzini writes: > Il 26/02/2013 20:35, Anthony Liguori ha scritto: >> >> See also discussion on multi-valued keys in command line option >> arguments and config files in v1 thread. Hopefully we can reach a >> conclusion soon, and then we'll see whether this patch is wh

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-26 Thread Paolo Bonzini
Il 26/02/2013 20:35, Anthony Liguori ha scritto: >>> >> >>> >> See also discussion on multi-valued keys in command line option >>> >> arguments and config files in v1 thread. Hopefully we can reach a >>> >> conclusion soon, and then we'll see whether this patch is what we want. >> > >> > Yeah, le

[libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-21 Thread Eduardo Habkost
This allows ":" to be used a separator between each CPU range, so the command-line may look like: -numa node,cpus=A-B:C-D Note that the following format, currently used by libvirt: -numa nodes,cpus=A-B,C-D will _not_ work, as "," is the option separator for the command-line option parser, a