Re: [libvirt] [PATCH v3 05/35] cfg.mk: no trailing semicolon at line invoking VIR_DEFINE_* cleanup macro

2018-07-10 Thread Sukrit Bhatnagar
On Tue, 10 Jul 2018 at 16:30, Erik Skultety wrote: > > On Sat, Jun 30, 2018 at 02:30:09PM +0530, Sukrit Bhatnagar wrote: > > Add rule to ensure that there is no semicolon at the end of > > the line where a VIR_DEFINE_* cleanup macro is invoked. > > > > Signed-off-by: Sukrit Bhatnagar > > --- > >

Re: [libvirt] [PATCH v3 05/35] cfg.mk: no trailing semicolon at line invoking VIR_DEFINE_* cleanup macro

2018-07-10 Thread Erik Skultety
On Sat, Jun 30, 2018 at 02:30:09PM +0530, Sukrit Bhatnagar wrote: > Add rule to ensure that there is no semicolon at the end of > the line where a VIR_DEFINE_* cleanup macro is invoked. > > Signed-off-by: Sukrit Bhatnagar > --- NACK, the compiler will fail in such case, so the syntax-rule

[libvirt] [PATCH v3 05/35] cfg.mk: no trailing semicolon at line invoking VIR_DEFINE_* cleanup macro

2018-07-01 Thread Sukrit Bhatnagar
Add rule to ensure that there is no semicolon at the end of the line where a VIR_DEFINE_* cleanup macro is invoked. Signed-off-by: Sukrit Bhatnagar --- cfg.mk | 9 + 1 file changed, 9 insertions(+) diff --git a/cfg.mk b/cfg.mk index 7949fc8..d292005 100644 --- a/cfg.mk +++ b/cfg.mk @@