On Tue, Dec 29, 2020 at 10:17:31 -0600, Ryan Gahagan wrote:
> On Tue, Dec 29, 2020 at 10:11 AM Peter Krempa wrote:
>
> > Please don't post screenshots of text. It's pointlessly bloating the
> > mail and I can't respond inline. Please re-post all the relevant bits as
> > text.
I've remembered a
On Tue, Dec 29, 2020 at 10:11 AM Peter Krempa wrote:
> Please don't post screenshots of text. It's pointlessly bloating the
> mail and I can't respond inline. Please re-post all the relevant bits as
> text.
>
Sorry about that, I didn't know what the policy on images was. Basically,
we used the
On Mon, Dec 28, 2020 at 15:49:17 -0600, Ryan Gahagan wrote:
> Our output file (qemuxml2xmloutdata/disk-network-nfs.x86_64-latest.xml) has
> a backingStore on line 35. Test 181 generates an output where this backing
> store does not have an index, but Test 182 generates an output where this
>
On Wed, Dec 23, 2020 at 14:28:04 -0600, Ryan Gahagan wrote:
> On Wed, Dec 23, 2020 at 11:45 AM Peter Krempa wrote:
>
> > For this test,
> > you'll be better off adding a hack to fill in the uid/gid values (e.g.
> > by checking that they start with a + to be safe.
>
>
> Our interpretation of
On Wed, Dec 23, 2020 at 11:45 AM Peter Krempa wrote:
> For this test,
> you'll be better off adding a hack to fill in the uid/gid values (e.g.
> by checking that they start with a + to be safe.
Our interpretation of what you mean here is to add a check in our parse
method (specifically in
On Mon, Dec 21, 2020 at 17:10:35 -0600, Ryan Gahagan wrote:
> We were able to get the testing environment running after some
> trial-and-error. The issue was that the version of libtirpc was out of
> date, causing an error in meson.build when the XDR dependency was being
> read. By updating the
We were able to get the testing environment running after some
trial-and-error. The issue was that the version of libtirpc was out of
date, causing an error in meson.build when the XDR dependency was being
read. By updating the libtirpc-dev package we were able to start building
locally. However,
On Fri, Dec 18, 2020 at 15:14:01 -0600, Ryan Gahagan wrote:
> On Thu, Dec 17, 2020 at 8:00 AM Peter Krempa wrote:
>
> > Also note that the upstream test-suite run in the CI does actually
> > provide the expected output. Obviously you can't use the ENV variable to
> > automatically overwrite your
On Thu, Dec 17, 2020 at 8:00 AM Peter Krempa wrote:
> Also note that the upstream test-suite run in the CI does actually
> provide the expected output. Obviously you can't use the ENV variable to
> automatically overwrite your files, but you certainly can copy out the
> diffs from the CI. Just
On Wed, Dec 16, 2020 at 19:37:48 -0600, Ryan Gahagan wrote:
> We addressed the feedback from our previous RFC patch for the most part.
> Under src/util/virstoragefile.c, we left a cast to an integer pointer
> that Peter mentioned because we were unable to provide a better
Casting uid_t * to int *
We addressed the feedback from our previous RFC patch for the most part.
Under src/util/virstoragefile.c, we left a cast to an integer pointer
that Peter mentioned because we were unable to provide a better
solution. We've written some tests for our code but our testing
environment is not working
11 matches
Mail list logo
