Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-23 Thread Christophe Fergeau
On Thu, Nov 22, 2012 at 11:32:38AM +0100, Ján Tomko wrote: On 11/22/12 11:03, Martin Kletzander wrote: I'll rework it to make it as URI as possible then. Just one question, though (for anyone, I guess); why do we append port as a parameter for spice scheme? Martin I think

Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-23 Thread Martin Kletzander
On 11/23/2012 09:20 AM, Christophe Fergeau wrote: On Thu, Nov 22, 2012 at 11:32:38AM +0100, Ján Tomko wrote: On 11/22/12 11:03, Martin Kletzander wrote: I'll rework it to make it as URI as possible then. Just one question, though (for anyone, I guess); why do we append port as a parameter

Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-22 Thread Martin Kletzander
On 11/21/2012 11:50 PM, Doug Goldstein wrote: On Wed, Nov 21, 2012 at 10:13 AM, Martin Kletzander mklet...@redhat.com wrote: On 11/21/2012 05:06 PM, Ján Tomko wrote: On 11/21/12 16:37, Martin Kletzander wrote: The 'virsh domdisplay' command is able to display the password configured for

Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-22 Thread Ján Tomko
On 11/22/12 11:03, Martin Kletzander wrote: I'll rework it to make it as URI as possible then. Just one question, though (for anyone, I guess); why do we append port as a parameter for spice scheme? Martin I think it's because of what spicy supported initially (since v0.1.0):

Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-21 Thread Daniel P. Berrange
On Wed, Nov 21, 2012 at 04:37:35PM +0100, Martin Kletzander wrote: The 'virsh domdisplay' command is able to display the password configured for spice, but it was missing for vnc type graphics. This is just a simple patch for that to work properly. --- tools/virsh-domain.c | 17

Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-21 Thread Martin Kletzander
On 11/21/2012 04:39 PM, Daniel P. Berrange wrote: On Wed, Nov 21, 2012 at 04:37:35PM +0100, Martin Kletzander wrote: The 'virsh domdisplay' command is able to display the password configured for spice, but it was missing for vnc type graphics. This is just a simple patch for that to work

Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-21 Thread Ján Tomko
On 11/21/12 16:37, Martin Kletzander wrote: The 'virsh domdisplay' command is able to display the password configured for spice, but it was missing for vnc type graphics. This is just a simple patch for that to work properly. --- tools/virsh-domain.c | 17 + 1 file changed,

Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-21 Thread Martin Kletzander
On 11/21/2012 05:06 PM, Ján Tomko wrote: On 11/21/12 16:37, Martin Kletzander wrote: The 'virsh domdisplay' command is able to display the password configured for spice, but it was missing for vnc type graphics. This is just a simple patch for that to work properly. --- tools/virsh-domain.c

Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-21 Thread Ján Tomko
On 11/21/12 17:13, Martin Kletzander wrote: On 11/21/2012 05:06 PM, Ján Tomko wrote: Wouldn't it be better to put the password before the host (vnc://:passwd@host:port) so that at least some clients (krdc from the few that I've tried) can understand the whole URI? Jan TBH, I don't get

Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-21 Thread Doug Goldstein
On Wed, Nov 21, 2012 at 10:13 AM, Martin Kletzander mklet...@redhat.com wrote: On 11/21/2012 05:06 PM, Ján Tomko wrote: On 11/21/12 16:37, Martin Kletzander wrote: The 'virsh domdisplay' command is able to display the password configured for spice, but it was missing for vnc type graphics.