[libvirt] [PATCH] build: submodule machinery now works also when no tag is reachable

2009-07-15 Thread Jim Meyering
Mike Burns wrote: I hit an issue with libvirt autobuild. I am running on an F11 machine and the build stage of libvirt--devel is failing. ... I talked to danpb and he pointed out that there is a difference between .git-module-status and git submodule status: danpb1 $ cat

[libvirt] [PATCH] Update links to bugzilla

2009-07-15 Thread Garry Dolley
* docs/bugs.html[.in]: Red Hat Enterprise Linux 5 specific tickets are under the 'Red Hat Enterprise Linux 5' product category. --- I forgot to update the RHEL 5 links in my previous patch, so here's another. docs/bugs.html|2 +- docs/bugs.html.in |2 +- 2 files changed, 2

[libvirt] [PATCH] 1/3 add support for netcf XML import and export

2009-07-15 Thread Daniel Veillard
Basically this implement the routines to read an netcf XML definition and build the associated internal data structures. It does the checking of the input XML up to making sure all the needed informations are availble in the right place, but does not check for extra data. It should support the

[libvirt] [PATCH] 2/3 Add netcf XML schemas and test data

2009-07-15 Thread Daniel Veillard
Directly imported from netcf-0.1.0 git with the exception that example have been changed to use single quote instead of double quote, otherwise unchanged. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine

[libvirt] [PATCH] 3/3 Add netcf XML validation and input and output tests

2009-07-15 Thread Daniel Veillard
Basic stuff similar to other tests, first we verify the input tests all conform to the provided schemas, then for each test we parse and reserialize verifying the output is identical. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com |

Re: [libvirt] [PATCH 1/4] storage: disk: Fix parthelper '-g' option handling.

2009-07-15 Thread Daniel Veillard
On Fri, Jul 10, 2009 at 03:32:20PM -0400, Cole Robinson wrote: Typo was breaking 'parthelper -g', preventing disk pool definition. --- src/parthelper.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/parthelper.c b/src/parthelper.c index f456ccc..5df46e8

Re: [libvirt] [PATCH 2/4] storage: disk: Fix segfault creating volume without target path

2009-07-15 Thread Daniel Veillard
On Fri, Jul 10, 2009 at 03:32:21PM -0400, Cole Robinson wrote: Remove unneeded target path duplication, which could carelessly dereference NULL. Make it clear where 'key' is actually filled in. Looks fine, ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit

Re: [libvirt] [PATCH 3/4] storage: disk: Default to 'ext2' for new volumes.

2009-07-15 Thread Daniel Veillard
On Fri, Jul 10, 2009 at 03:32:22PM -0400, Cole Robinson wrote: Currently, if no format is specified for a new disk volume, we pass the invalid value none as the FS type to 'parted mkpart'. There doesn't seem to be a way to have parted not format the drive, so just default to using 'ext2' in

Re: [libvirt] [PATCH 4/4] storage: disk: Use capacity, not allocation, when creating volume.

2009-07-15 Thread Daniel Veillard
On Fri, Jul 10, 2009 at 03:32:23PM -0400, Cole Robinson wrote: There isn't any way to dictate allocation when creating disk volumes, so capacity is the only relevant value. Sounds right, ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/

Re: [libvirt] PATCH: Fix libvirtd autostart for test driver

2009-07-15 Thread Daniel Veillard
On Tue, Jul 14, 2009 at 11:36:17AM +0100, Daniel P. Berrange wrote: Ensure test:/// URIs get routed to the non-privileged libvirtd * src/remote_internal.c: Ensure that all test:/// URIs are dealt with by the auto-started, per-user unprivileged libvirtd instances Makes

Re: [libvirt] [PATCH] qemu: Try multiple times to open unix monitor socket

2009-07-15 Thread Daniel Veillard
On Tue, Jul 14, 2009 at 06:22:42PM -0400, Cole Robinson wrote: Unlike the pty monitor (which we know exists since we scrape its path from stdout), we have no way of knowing that the unix monitor socket should exist/ be initialized. As a result, some of my KVM guests randomly fail to start on

Re: [libvirt] [PATCH] build: submodule machinery now works also when no tag is reachable

2009-07-15 Thread Daniel Veillard
On Wed, Jul 15, 2009 at 09:59:33AM +0200, Jim Meyering wrote: Mike Burns wrote: I hit an issue with libvirt autobuild. I am running on an F11 machine and the build stage of libvirt--devel is failing. ... I talked to danpb and he pointed out that there is a difference between

Re: [libvirt] [PATCH] Update links to bugzilla

2009-07-15 Thread Daniel Veillard
On Wed, Jul 15, 2009 at 01:16:30AM -0700, Garry Dolley wrote: * docs/bugs.html[.in]: Red Hat Enterprise Linux 5 specific tickets are under the 'Red Hat Enterprise Linux 5' product category. --- I forgot to update the RHEL 5 links in my previous patch, so here's another. Okidoc,

Re: [libvirt] [PATCH] build: submodule machinery now works also when no tag is reachable

2009-07-15 Thread Jim Meyering
Daniel Veillard wrote: On Wed, Jul 15, 2009 at 09:59:33AM +0200, Jim Meyering wrote: Mike Burns wrote: I hit an issue with libvirt autobuild. I am running on an F11 machine and the build stage of libvirt--devel is failing. ... I talked to danpb and he pointed out that there is a

Re: [libvirt] [PATCH] qemu: Try multiple times to open unix monitor socket

2009-07-15 Thread Daniel P. Berrange
On Wed, Jul 15, 2009 at 11:40:42AM +0200, Daniel Veillard wrote: On Tue, Jul 14, 2009 at 06:22:42PM -0400, Cole Robinson wrote: Unlike the pty monitor (which we know exists since we scrape its path from stdout), we have no way of knowing that the unix monitor socket should exist/ be

Re: [libvirt] [PATCH] 1/3 add support for netcf XML import and export

2009-07-15 Thread Daniel P. Berrange
On Wed, Jul 15, 2009 at 11:15:25AM +0200, Daniel Veillard wrote: +static int +virInterfaceDefParseBasicAttrs(virConnectPtr conn, virInterfaceDefPtr def, + xmlXPathContextPtr ctxt) { +char *tmp; +unsigned long mtu; +int ret; + +tmp =

Re: [libvirt] [PATCH] 2/3 Add netcf XML schemas and test data

2009-07-15 Thread Daniel P. Berrange
On Wed, Jul 15, 2009 at 11:17:54AM +0200, Daniel Veillard wrote: Directly imported from netcf-0.1.0 git with the exception that example have been changed to use single quote instead of double quote, otherwise unchanged. Trivial ACK then Daniel -- |: Red Hat, Engineering, London -o-

Re: [libvirt] [PATCH] 3/3 Add netcf XML validation and input and output tests

2009-07-15 Thread Daniel P. Berrange
On Wed, Jul 15, 2009 at 11:20:00AM +0200, Daniel Veillard wrote: Basic stuff similar to other tests, first we verify the input tests all conform to the provided schemas, then for each test we parse and reserialize verifying the output is identical. ACK, good stuff. Daniel -- Daniel

[libvirt] Fix svirt handling of shared/readonly disks

2009-07-15 Thread Daniel P. Berrange
The patch committed here commit 547147084d03ebf30d09d242a5a721a4df664ffe Author: Mark McLoughlin mar...@redhat.com Date: Fri Jul 3 10:26:37 2009 + was not actually the latest version currently used in Fedora. It causes shared disks to be re-labelled upon VM shutdown, breaking any other

Re: [libvirt] [PATCH] qemu: Try multiple times to open unix monitor socket

2009-07-15 Thread Jim Paris
Daniel P. Berrange wrote: On Wed, Jul 15, 2009 at 11:40:42AM +0200, Daniel Veillard wrote: On Tue, Jul 14, 2009 at 06:22:42PM -0400, Cole Robinson wrote: Unlike the pty monitor (which we know exists since we scrape its path from stdout), we have no way of knowing that the unix monitor

Re: [libvirt] [PATCH] 1/3 add support for netcf XML import and export

2009-07-15 Thread Daniel Veillard
On Wed, Jul 15, 2009 at 11:22:43AM +0100, Daniel P. Berrange wrote: On Wed, Jul 15, 2009 at 11:15:25AM +0200, Daniel Veillard wrote: +static int +virInterfaceDefParseBasicAttrs(virConnectPtr conn, virInterfaceDefPtr def, + xmlXPathContextPtr ctxt) { +char

Re: [libvirt] [PATCH] 3/3 Add netcf XML validation and input and output tests

2009-07-15 Thread Daniel Veillard
On Wed, Jul 15, 2009 at 11:24:59AM +0100, Daniel P. Berrange wrote: On Wed, Jul 15, 2009 at 11:20:00AM +0200, Daniel Veillard wrote: Basic stuff similar to other tests, first we verify the input tests all conform to the provided schemas, then for each test we parse and reserialize

Re: [libvirt] [PATCH] 1/3 add support for netcf XML import and export

2009-07-15 Thread Daniel Veillard
On Wed, Jul 15, 2009 at 05:40:30PM +0200, Daniel Veillard wrote: On Wed, Jul 15, 2009 at 11:22:43AM +0100, Daniel P. Berrange wrote: On Wed, Jul 15, 2009 at 11:15:25AM +0200, Daniel Veillard wrote: +static int +virInterfaceDefParseBasicAttrs(virConnectPtr conn, virInterfaceDefPtr def,

[libvirt] consistency: push update hook vs. make syntax-check

2009-07-15 Thread Jim Meyering
Currently the server side hook that runs git diff --check to prevent pushing a change that adds trailing blanks is more strict than our make syntax-check hook, since the former rejects any change that adds blank lines at the end of a file, while make syntax-check doesn't complain about that. The