Re: [libvirt] [test-API][PATCH 1/2] Fix the undefined local variable problem in remote_exec

2012-08-01 Thread Guannan Ren
On 07/31/2012 04:23 PM, Wayne Sun wrote: * subproc_flag should be global when used between functions * print error msg when exception happened Signed-off-by: Wayne Sun g...@redhat.com --- utils/utils.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [test-API][PATCH 2/2] Define domain from xml should support image format option

2012-08-01 Thread Guannan Ren
On 07/31/2012 04:23 PM, Wayne Sun wrote: * add imageformat as optional param in define * modify define xml for image format support Signed-off-by: Wayne Sun g...@redhat.com --- repos/domain/define.py |1 + repos/domain/xmls/kvm_guest_define.xml |2 +- 2 files

Re: [libvirt] [test-API][PATCH 1/2] Fix the undefined local variable problem in remote_exec

2012-08-01 Thread Guannan Ren
On 07/31/2012 04:23 PM, Wayne Sun wrote: * subproc_flag should be global when used between functions * print error msg when exception happened Signed-off-by: Wayne Sun g...@redhat.com --- utils/utils.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH] Syntax error in src/qemu/qemu_hotplug.c

2012-08-01 Thread Peter Krempa
On 07/31/12 17:20, Ryan Bourgeois wrote: Fixed use of colon as statement terminator. This is against the latest git master. My email client chomps whitespace so I've attached the patch. Ryan Bourgeois Thanks for sending the patch! Unfortunately it's no longer relevant as it's already fixed

Re: [libvirt] New application

2012-08-01 Thread Maciej Nabożny
On Mon, 30 Jul 2012 17:29:05 -0600, Eric Blake ebl...@redhat.com wrote: On 07/16/2012 12:57 PM, Eric Blake wrote: On 07/16/2012 04:17 AM, Maciej Nabożny wrote: Hello, I'm developer of CC1 project in Institute of Nuclear Physics in Cracow. We are creating cloud computing system based on

[libvirt] [PATCH] Add missing parallels_utils.h to Makefile.am

2012-08-01 Thread Daniel Veillard
Otherwise the file is missing from the dist tarball and distcheck fails Pushed under the build breaker rule Daniel diff --git a/src/Makefile.am b/src/Makefile.am index c5dc28a..b48ce65 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -532,7 +532,8 @@ HYPERV_DRIVER_EXTRA_DIST =

[libvirt] [PATCH] Fix rpm build failures

2012-08-01 Thread Daniel Veillard
The 'make check' was rebuilding the binaries just overrided, so for more safety also override the C program Also daemon-conf isn't built anymore so remove it from the list Pushed under the build breaker rule Daniel diff --git a/libvirt.spec.in b/libvirt.spec.in index c642f80..2d86e3c 100644

[libvirt] [PATCH] build: Link security driver into daemon

2012-08-01 Thread Jiri Denemark
Commit aae5cfb69948fddef556f8f5b9f80a444f9c6125 removed security driver from libvirt_la but forgot to link it into libvirtd in case libvirt is built without modules. --- daemon/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index

Re: [libvirt] [PATCH 06/13] Turn virDomainObjPtr into a virObjectPtr

2012-08-01 Thread Hu Tao
void virBlkioDeviceWeightArrayClear(virBlkioDeviceWeightPtr deviceWeights, int ndevices) @@ -723,7 +738,7 @@ virDomainObjListDataFree(void *payload, const void *name ATTRIBUTE_UNUSED) { virDomainObjPtr obj = payload; virDomainObjLock(obj); -

Re: [libvirt] QEMU CPU model versioning/compatibility (was Re: KVM call minutes July 31th)

2012-08-01 Thread Avi Kivity
On 07/31/2012 06:14 PM, Eduardo Habkost wrote: On Tue, Jul 31, 2012 at 04:32:05PM +0200, Juan Quintela wrote: - 1.2 plans for CPU model versioning/compatibility (eduardo) (global properties vs QOM vs qdev) how to do it ? configuration file? moving back to the code? different external

[libvirt] [PATCH v2] build: Link security driver into daemon

2012-08-01 Thread Jiri Denemark
Commit aae5cfb69948fddef556f8f5b9f80a444f9c6125 removed security driver from libvirt_la but forgot to link it into libvirtd in case libvirt is built without modules. --- Hmm, version 1 had the security driver in a wrong place. That's what you get for changing the patch after checking that it

[libvirt] Next release schedule and a snapshot

2012-08-01 Thread Daniel Veillard
Hello everybody, as suggested when we rolled out 0.9.13, I'm planning to make the next release at the end of August. Since we added a driver we should probably bump the medium number and shoot for 0.10.0. Also 2 months without some official tarball to test was quite long so I made a snapshot

[libvirt] [PATCH v2][TCK 1/2] Extend image and memory size for installing guest

2012-08-01 Thread Kyla Zhang
In fedora 17 with less than 512M memory will cause installation hang, also the previous image size is too small, so improve them. --- lib/Sys/Virt/TCK/NetworkHelpers.pm |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Sys/Virt/TCK/NetworkHelpers.pm

[libvirt] [test-API][PATCH] Fix logical volume create problem

2012-08-01 Thread Wayne Sun
* capacity should be int type * delete unused capacity suffix convert * fix xml param name Signed-off-by: Wayne Sun g...@redhat.com --- repos/storage/create_logical_volume.py |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH v2][TCK 2/2] Add test for memory set and get

2012-08-01 Thread Kyla Zhang
Add test for memory/maxmem set and get on domain running/shutdown --- scripts/domain/310-memory-set-get.t | 98 +++ 1 files changed, 98 insertions(+), 0 deletions(-) create mode 100644 scripts/domain/310-memory-set-get.t diff --git

Re: [libvirt] [PATCH v2] build: Link security driver into daemon

2012-08-01 Thread Peter Krempa
On 08/01/12 10:53, Jiri Denemark wrote: Commit aae5cfb69948fddef556f8f5b9f80a444f9c6125 removed security driver from libvirt_la but forgot to link it into libvirtd in case libvirt is built without modules. --- Hmm, version 1 had the security driver in a wrong place. That's what you get for

[libvirt] [PATCH] spec: Remove extra () with return statement

2012-08-01 Thread Jiri Denemark
--- Pushed as trivial. libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 2d86e3c..67b955a 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1328,7 +1328,7 @@ make for i in nodeinfotest seclabeltest do rm -f $i -

Re: [libvirt] [PATCH v10 0/9] Add basic driver for Parallels Cloud Server

2012-08-01 Thread Dmitry Guryanov
On 08/01/2012 08:08 AM, Daniel Veillard wrote: On Tue, Jul 31, 2012 at 10:56:04PM +0400, Dmitry Guryanov wrote: Parallels Cloud Server is a virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server. More information can

[libvirt] [PATCH] Update xml schemas according to libvirt source

2012-08-01 Thread Ján Tomko
capability.rng: Guest features can be in any order. nodedev.rng: Added driver element, capability phys_function and virt_functions for PCI devices. storagepool.rng: Owner or group ID can be -1. --- docs/schemas/capability.rng | 76 +

[libvirt] [PATCH] gitignore: Reorder alphabetically

2012-08-01 Thread Michal Privoznik
One of our latest patches added some files to .gitignore. However, not in the right place leaving the file not sorted. Since my git is set up to sort these files contents, fix this issue as it keeps showing up in git status. --- Pushing under trivial rule. .gitignore |2 +- 1 files changed,

Re: [libvirt] New application

2012-08-01 Thread Eric Blake
On 08/01/2012 02:13 AM, Maciej Nabożny wrote: On Mon, 30 Jul 2012 17:29:05 -0600, Eric Blake ebl...@redhat.com wrote: On 07/16/2012 12:57 PM, Eric Blake wrote: On 07/16/2012 04:17 AM, Maciej Nabożny wrote: Hello, I'm developer of CC1 project in Institute of Nuclear Physics in Cracow. We

Re: [libvirt] on special migration(domain defined, not started yet)

2012-08-01 Thread Eric Blake
On 07/31/2012 09:30 PM, liguang wrote: Hi, All If a VM domain defined, but not started yet, and I want to migrate it to another server, so that It can be started at there, what's should i do? or is it rational? Yes it is rational, and you're not the first to request it. Unfortunately, we

Re: [libvirt] [PATCH] Update xml schemas according to libvirt source

2012-08-01 Thread Eric Blake
On 08/01/2012 05:34 AM, Ján Tomko wrote: capability.rng: Guest features can be in any order. nodedev.rng: Added driver element, capability phys_function and virt_functions for PCI devices. storagepool.rng: Owner or group ID can be -1. --- docs/schemas/capability.rng | 76

Re: [libvirt] [PATCH 02/13] Rewrite virAtomic APIs using GLib's atomic ops code

2012-08-01 Thread Eric Blake
On 07/31/2012 06:09 PM, Eric Blake wrote: On 07/31/2012 10:58 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com There are a few issues with the current virAtomic APIs - They require use of a virAtomicInt struct instead of a plain int type - Several of the

Re: [libvirt] [PATCH] Fix rpm build failures

2012-08-01 Thread Eric Blake
On 08/01/2012 02:17 AM, Daniel Veillard wrote: The 'make check' was rebuilding the binaries just overrided, so for more safety also override the C program Also daemon-conf isn't built anymore so remove it from the list Pushed under the build breaker rule Daniel diff --git

Re: [libvirt] [test-API][PATCH] Fix logical volume create problem

2012-08-01 Thread Osier Yang
On 2012年08月01日 17:43, Wayne Sun wrote: * capacity should be int type * delete unused capacity suffix convert * fix xml param name Signed-off-by: Wayne Sung...@redhat.com --- repos/storage/create_logical_volume.py |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff

Re: [libvirt] [PATCH] Fix rpm build failures

2012-08-01 Thread Daniel Veillard
On Wed, Aug 01, 2012 at 06:45:29AM -0600, Eric Blake wrote: On 08/01/2012 02:17 AM, Daniel Veillard wrote: The 'make check' was rebuilding the binaries just overrided, so for more safety also override the C program Also daemon-conf isn't built anymore so remove it from the list

Re: [libvirt] [PATCH] Syntax error in src/qemu/qemu_hotplug.c

2012-08-01 Thread Ryan Bourgeois
Hah, thanks. I guess my timing was just right to hit the wrong commit when I pulled it down. -Ryan On Wed, Aug 1, 2012 at 2:35 AM, Peter Krempa pkre...@redhat.com wrote: On 07/31/12 17:20, Ryan Bourgeois wrote: Fixed use of colon as statement terminator. This is against the latest git

Re: [libvirt] [PATCH] [libvirt-java] Fix Array IndexOutOfBoundsException for unknown error codes

2012-08-01 Thread Claudio Bley
At Mon, 23 Jul 2012 14:56:55 -0600, Eric Blake wrote: On 07/23/2012 04:31 AM, Claudio Bley wrote: When libvirt returns an error code which is not mapped in enum ErrorNumber, an IndexOutOfBoundsException is thrown. I realize that the freshly released libvirt-java 0.4.8 supports all

Re: [libvirt] [PATCH v10 9/9] parallels: implement VM creation

2012-08-01 Thread Eric Blake
On 07/31/2012 09:34 PM, Daniel Veillard wrote: On Tue, Jul 31, 2012 at 10:56:13PM +0400, Dmitry Guryanov wrote: To create a new VM in Parallels Clud Server we should issue prlctl create command, and give path to the directory, where VM should be created. VM's storage will be in that directory

Re: [libvirt] [PATCH v4] storage: netfs and iscsi need option srcSpec for resource discovery

2012-08-01 Thread Osier Yang
On 2012年07月31日 16:56, Guannan Ren wrote: The option 'srcSpec' to virsh command find-storage-pool-sources is optional for logical type of storage pool, but mandatory for netfs and iscsi type. When missing the option for netfs and iscsi, libvirt reports XML parsing error due to null string option

Re: [libvirt] [PATCH libvirt-java] Add debian packaging for the Java bindings

2012-08-01 Thread Wido den Hollander
On 07/19/2012 07:33 PM, Wido den Hollander wrote: Signed-off-by: Wido den Hollander w...@widodh.nl --- build.xml | 19 +++ debian/control.in |9 + 2 files changed, 28 insertions(+) create mode 100644 debian/control.in diff --git a/build.xml

[libvirt] Generating our docs/search.php with xsltproc

2012-08-01 Thread Martin Kletzander
Hi everyone. TL;DR is there a way to keep PHP code untouched in XSL transformed XML? For a while now, I'm trying to make our 'search.php' file generated like all the '*.html' files (with all the fancy stuff like up-to-date menu, headers and so on). The problem I've been facing looks like an

[libvirt] [PATCH] build: commit to 0.10.0 release naming

2012-08-01 Thread Eric Blake
With 0.10.0-rc0 out the door, we are committed to the next version number. * src/libvirt_public.syms (LIBVIRT_0.9.14): Rename... (LIBVIRT_0.10.0): ...to this. * docs/formatdomain.html.in: Fix fallout. * src/openvz/openvz_driver.c (openvzDriver): Likewise. * src/remote/remote_driver.c

Re: [libvirt] [PATCH] build: commit to 0.10.0 release naming

2012-08-01 Thread Guido Günther
On Wed, Aug 01, 2012 at 11:00:35AM -0600, Eric Blake wrote: With 0.10.0-rc0 out the door, we are committed to the next version number. * src/libvirt_public.syms (LIBVIRT_0.9.14): Rename... (LIBVIRT_0.10.0): ...to this. * docs/formatdomain.html.in: Fix fallout. * src/openvz/openvz_driver.c

Re: [libvirt] [PATCH] build: commit to 0.10.0 release naming

2012-08-01 Thread Eric Blake
On 08/01/2012 01:18 PM, Guido Günther wrote: On Wed, Aug 01, 2012 at 11:00:35AM -0600, Eric Blake wrote: With 0.10.0-rc0 out the door, we are committed to the next version number. * src/libvirt_public.syms (LIBVIRT_0.9.14): Rename... (LIBVIRT_0.10.0): ...to this. *

Re: [libvirt] [PATCH] ESX: Add Byte datatype

2012-08-01 Thread Matthias Bolte
2012/8/1 Ata E Husain Bohra ata.hus...@hotmail.com: Append Byte to set of predefined object data types. Signed-off-by: Ata E Husain Bohra ata.hus...@hotmail.com --- src/esx/esx_vi_generator.py |1 + src/esx/esx_vi_types.c | 57 +++

Re: [libvirt] [PATCH v4 0/3] ESX: Add routines to interface driver

2012-08-01 Thread Matthias Bolte
2012/7/29 Ata E Husain Bohra ata.hus...@hotmail.com: Updated the patch against review comments from Laine and Matthias. Ata E Husain Bohra (3): ESX: Add routines to interface driver ESX: Add routines to interface driver ESX: Add routines to interface driver

[libvirt] [libivrt][PATCH v1] ESX: Add Byte datatype

2012-08-01 Thread Ata E Husain Bohra
Updated as per Matthias comment. Ata E Husain Bohra (1): ESX: Add Byte datatype src/esx/esx_vi_generator.py |1 + src/esx/esx_vi_types.c | 57 +++ src/esx/esx_vi_types.h | 29 ++ 3 files changed, 87 insertions(+)

[libvirt] [PATCH v1] ESX: Add Byte datatype

2012-08-01 Thread Ata E Husain Bohra
Append Byte to set of predefined datatype objects. Signed-off-by: Ata E Husain Bohra ata.hus...@hotmail.com --- src/esx/esx_vi_generator.py |1 + src/esx/esx_vi_types.c | 57 +++ src/esx/esx_vi_types.h | 29 ++ 3 files

Re: [libvirt] [PATCH] daemon: Fix crash in virTypedParameterArrayClear

2012-08-01 Thread Eric Blake
On 07/30/2012 12:03 PM, Jiri Denemark wrote: On Mon, Jul 30, 2012 at 22:52:23 +0800, Osier Yang wrote: On 2012年07月30日 19:55, Jiri Denemark wrote: Daemon uses the following pattern when dispatching APIs with typed parameters: VIR_ALLOC_N(params, nparams); virDomain*(dom,

Re: [libvirt] [PATCH] [libvirt-java] Fix Array IndexOutOfBoundsException for unknown error codes

2012-08-01 Thread Eric Blake
On 08/01/2012 08:11 AM, Claudio Bley wrote: At Mon, 23 Jul 2012 14:56:55 -0600, the old version crashed, and your version leaves code as null (which is a strict improvement, but might cause its own NullPointer issue later on). Having an else branch that sticks in a placeholder would be nicer

Re: [libvirt] [PATCH libvirt-java] Add debian packaging for the Java bindings

2012-08-01 Thread Eric Blake
On 08/01/2012 08:51 AM, Wido den Hollander wrote: On 07/19/2012 07:33 PM, Wido den Hollander wrote: Signed-off-by: Wido den Hollander w...@widodh.nl --- build.xml | 19 +++ debian/control.in |9 + 2 files changed, 28 insertions(+) create mode

Re: [libvirt] [PATCH] shutting down guest vms on host shutdown does not work

2012-08-01 Thread Eric Blake
On 07/30/2012 02:42 AM, Gerd v. Egidy wrote: Hi Eric, Thanks for researching this! ACK and applied. Thanks. Now a followup question - in AUTHORS, you are listed as Gerd von Egidy, but in this commit, your authorship is Gerd v. Egidy. Which do you prefer, and I'll update .mailmap and

[libvirt] [PATCHv2] build: add stubs so mdns code can be unconditionally compiled

2012-08-01 Thread Eric Blake
The recent changes to test exported symbols flushed out the fact that we were unconditionally linking against symbols that were only conditionally compiled under HAVE_AVAHI. * src/Makefile.am (libvirt_net_rpc_server_la_SOURCES): Compile virnetservermdns unconditionally. * configure.ac

Re: [libvirt] [PATCH v4 0/3] ESX: Add routines to interface driver

2012-08-01 Thread Ata E Husain
Please see comments inline. Regards, Ata -Original Message- From: Matthias Bolte [mailto:matthias.bo...@googlemail.com] Sent: Wednesday, August 01, 2012 1:08 PM To: Ata E Husain Bohra Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH v4 0/3] ESX: Add routines to interface

Re: [libvirt] [PATCH v4] storage: netfs and iscsi need option srcSpec for resource discovery

2012-08-01 Thread Guannan Ren
On 08/01/2012 10:51 PM, Osier Yang wrote: On 2012年07月31日 16:56, Guannan Ren wrote: diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index af80427..0f0b21e 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -1093,6 +1093,12 @@ cmdPoolDiscoverSources(vshControl * ctl, const vshCmd