Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 1:07 PM, Osier Yang jy...@redhat.com wrote: [...] Not sure if you planned to request separate projects for these, but I don't think it's deserved for separate projects. They can be just one project, as the work need to do for them is similar. Sure, they are a whole

Re: [libvirt] [RFC] Usage about 'virsh vol-wipe vol_name'

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 12:42 PM, Osier Yang jy...@redhat.com wrote: Hi Osier, On Fri, Apr 12, 2013 at 10:22 AM, harryxiyou harryxi...@gmail.com wrote: Hi all, I am not very clear about the usage of ‘virsh vol-wipe vol_name’. I think if 'virsh vol-wipe vol_name' can just wipe all the

Re: [libvirt] [RFC] Usage about 'virsh vol-wipe vol_name'

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 12:39 PM, Osier Yang jy...@redhat.com wrote: [...] The command is there, and the docs is there too. So you already had the guide, why not to try it? Thanks, i will. Could anyone please give me some suggestions? Thanks in advance. However, if users just want to

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread Michal Privoznik
On 10.04.2013 15:13, harryxiyou wrote: Hi all, I've also got some ideas like following for GSOC 2013. Storage driver jobs. Currently, there is no Libvirt storage API to rename storage volume, storage pool, snapshot, etc. There is also no Libvirt API to move volume from one pool to

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 2:34 PM, Michal Privoznik mpriv...@redhat.com wrote: Hi Michal, I am not sure we want *rename virsh commands. Not only for storage, but in general. And even if we do want these, they don't require a new API. They can be implemented with simple vir*GetXML();

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread Osier Yang
On 12/04/13 14:34, Michal Privoznik wrote: On 10.04.2013 15:13, harryxiyou wrote: Hi all, I've also got some ideas like following for GSOC 2013. Storage driver jobs. Currently, there is no Libvirt storage API to rename storage volume, storage pool, snapshot, etc. There is also no Libvirt API

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 2:34 PM, Michal Privoznik mpriv...@redhat.com wrote: Hi Michal, I am not sure we want *rename virsh commands. Not only for storage, but in general. And even if we do want these, they don't require a new API. They can be implemented with simple vir*GetXML();

[libvirt] [RFC] Fix https://bugzilla.redhat.com/show_bug.cgi?id=461931

2013-04-12 Thread harryxiyou
Hi Osier, From the actual bug messages like fowllowing Actual results: Traceback (most recent call last): File /usr/share/virt-manager/virtManager/createvol.py, line 191, in _async_vol_create poolobj = self.vol.install(meter=meter) File

Re: [libvirt] [PATCH v3 15/16] Add an API for re-mounting cgroups, to isolate the process location

2013-04-12 Thread Daniel P. Berrange
On Fri, Apr 12, 2013 at 10:53:24AM +0800, Gao feng wrote: On 04/10/2013 06:08 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add a virCgroupIsolateMount method which looks at where the current process is place in the cgroups (eg /system/demo.lxc.libvirt) and

Re: [libvirt] [Xen-devel] libvirt libxl driver leaking libxl_event's?

2013-04-12 Thread Ian Campbell
On Thu, 2013-04-11 at 20:35 +0100, Jim Fehlig wrote: On 04/11/2013 07:09 AM, Ian Campbell wrote: On Thu, 2013-04-11 at 13:46 +0100, Ian Campbell wrote: Hi Jim, I don't see any calls to libxl_event_dispose in libvirt.git, actually I think I meant libxl_event_free, but I can't see that

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread Daniel P. Berrange
On Fri, Apr 12, 2013 at 08:34:18AM +0200, Michal Privoznik wrote: On 10.04.2013 15:13, harryxiyou wrote: Hi all, I've also got some ideas like following for GSOC 2013. Storage driver jobs. Currently, there is no Libvirt storage API to rename storage volume, storage pool,

[libvirt] [PATCH 3/4] cleanup: Change datatype of usbdev-allow to boolean

2013-04-12 Thread Osier Yang
--- src/conf/domain_conf.c | 4 ++-- src/conf/domain_conf.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 70df165..79a116f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8557,9 +8557,9 @@

[libvirt] [PATCH 4/4] cleanup: Change datatype of net-stp to boolean

2013-04-12 Thread Osier Yang
--- src/conf/network_conf.c | 2 +- src/conf/network_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 968cf11..75584a0 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -1748,7 +1748,7 @@

[libvirt] [PATCH 2/4] cleanup: Change datatype of graphic's members to boolean

2013-04-12 Thread Osier Yang
--- src/conf/domain_conf.c | 32 src/conf/domain_conf.h | 14 +++--- src/parallels/parallels_driver.c | 4 ++-- src/qemu/qemu_command.c | 6 +++--- src/vbox/vbox_tmpl.c | 6 +++--- src/vmx/vmx.c

[libvirt] [PATCH 0/4] cleanup: Use bool type instead of bitfield - More

2013-04-12 Thread Osier Yang
Which are missed with pattern : 1 in the previous cleanup series. After these, all the bitfield use under src/conf/ are destroyed, except the ones which are required by the existing APIs. Osier Yang (4): cleanup: Change datatype of accel's members to boolean cleanup: Change datatype of

Re: [libvirt] [RFC] Fix https://bugzilla.redhat.com/show_bug.cgi?id=461931

2013-04-12 Thread Osier Yang
On 12/04/13 16:02, harryxiyou wrote: Hi Osier, From the actual bug messages like fowllowing Actual results: Traceback (most recent call last): File /usr/share/virt-manager/virtManager/createvol.py, line 191, in _async_vol_create poolobj = self.vol.install(meter=meter) File

Re: [libvirt] [PATCH v4 11/11] Add test case for TPM passthrough

2013-04-12 Thread Daniel P. Berrange
On Thu, Apr 11, 2013 at 01:24:21PM -0400, Stefan Berger wrote: On 04/11/2013 11:43 AM, Daniel P. Berrange wrote: On Fri, Apr 05, 2013 at 10:06:02AM -0400, Stefan Berger wrote: Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com

[libvirt] [PATCH 1/4] cleanup: Change datatype of accel's members to boolean

2013-04-12 Thread Osier Yang
--- src/conf/domain_conf.c | 8 src/conf/domain_conf.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 68f024f..62f448d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8150,17 +8150,17 @@

Re: [libvirt] [RFC] Fix https://bugzilla.redhat.com/show_bug.cgi?id=461931

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 5:20 PM, Osier Yang jy...@redhat.com wrote: On 12/04/13 16:02, harryxiyou wrote: Hi Osier, From the actual bug messages like fowllowing Actual results: Traceback (most recent call last): File /usr/share/virt-manager/virtManager/createvol.py, line 191, in

Re: [libvirt] [PATCH v4 1/2] Add USB option capability

2013-04-12 Thread Daniel P. Berrange
On Fri, Apr 12, 2013 at 01:56:31PM +0800, Li Zhang wrote: On 2013年04月11日 17:30, Daniel P. Berrange wrote: On Sun, Apr 07, 2013 at 04:31:57PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com To avoid the collision for creating USB controllers in machine-init() and -device xx

Re: [libvirt] [PATCH v5 05/11] Parse TPM passthrough XML in the domain XML

2013-04-12 Thread Daniel P. Berrange
On Thu, Apr 11, 2013 at 04:04:47PM -0400, Stefan Berger wrote: Parse the domain XML with TPM passthrough support. The TPM passthrough XML may look like this: tpm model='tpm-tis' backend type='passthrough' device path='/dev/tpm0'/ /backend /tpm

Re: [libvirt] [PATCH v5 04/11] Helper functions for host TPM support

2013-04-12 Thread Daniel P. Berrange
On Thu, Apr 11, 2013 at 04:04:46PM -0400, Stefan Berger wrote: Implement helper functions to find the TPM's sysfs cancel file. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com Tested-by: Corey Bryant cor...@linux.vnet.ibm.com ---

[libvirt] [libvirt-designer] Fix 'be find' typo in error message

2013-04-12 Thread Christophe Fergeau
--- Pushed under the trivial rule. Christophe examples/virtxml.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/virtxml.c b/examples/virtxml.c index 49a7b4e..20aa621 100644 --- a/examples/virtxml.c +++ b/examples/virtxml.c @@ -547,7 +547,7 @@ main(int argc, char

[libvirt] Shared desktop: grant permission to start/stop/pause/resume guests only

2013-04-12 Thread Thorsten Hesemeyer
Hi all, for a shared desktop configuration, is there an option to grant the permission to start, stop, pause or resume the kvm guest only? User roles in shared desktop environment configuration: Power user - fully manage libvirt / KVM guests Regular user - start, stop, pause and resume

Re: [libvirt] Shared desktop: grant permission to start/stop/pause/resume guests only

2013-04-12 Thread Michal Privoznik
On 12.04.2013 13:24, Thorsten Hesemeyer wrote: Hi all, for a shared desktop configuration, is there an option to grant the permission to start, stop, pause or resume the kvm guest only? Short answer: No. Long answer: No. This question pops up from time to time. Last time it emerged just two

Re: [libvirt] [PATCH] conf: Allow for non-contiguous device boot orders

2013-04-12 Thread Jiri Denemark
On Thu, Apr 04, 2013 at 15:35:57 +0200, Peter Krempa wrote: This patch adds the ability to configure non-contiguous boot orders on boot devices. This allows unplugging devices that have boot order specified without breaking migration. The new code now uses a slightly less memory efficient

Re: [libvirt] [PATCH v5 04/11] Helper functions for host TPM support

2013-04-12 Thread Stefan Berger
On 04/12/2013 06:24 AM, Daniel P. Berrange wrote: On Thu, Apr 11, 2013 at 04:04:46PM -0400, Stefan Berger wrote: Implement helper functions to find the TPM's sysfs cancel file. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com

Re: [libvirt] [PATCH] conf: Allow for non-contiguous device boot orders

2013-04-12 Thread Peter Krempa
On 04/12/13 13:46, Jiri Denemark wrote: On Thu, Apr 04, 2013 at 15:35:57 +0200, Peter Krempa wrote: This patch adds the ability to configure non-contiguous boot orders on boot devices. This allows unplugging devices that have boot order specified without breaking migration. The new code now

Re: [libvirt] [PATCH v5 04/11] Helper functions for host TPM support

2013-04-12 Thread Daniel P. Berrange
On Fri, Apr 12, 2013 at 08:40:18AM -0400, Stefan Berger wrote: On 04/12/2013 06:24 AM, Daniel P. Berrange wrote: On Thu, Apr 11, 2013 at 04:04:46PM -0400, Stefan Berger wrote: Implement helper functions to find the TPM's sysfs cancel file. Signed-off-by: Stefan Berger

[libvirt] [PATCH 2/2] qemu: Report also domain name in error message when domain object wasn't found

2013-04-12 Thread Peter Krempa
Report the errors as: Domain not found: no domain with matching uuid '41414141-4141-4141-4141-414141414141' (crashtest) instead of: Domain not found: no domain with matching uuid '41414141-4141-4141-4141-414141414141' --- src/qemu/qemu_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1

[libvirt] [PATCH v6 03/11] Add documentation and schema for TPM passthrough

2013-04-12 Thread Stefan Berger
Supported TPM passthrough XML may look as follows: tpm model='tpm-tis' backend type='passthrough' device path='/dev/tpm0'/ /backend /tpm Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com Tested-by: Corey Bryant

[libvirt] [PATCH v6 04/11] Helper functions for host TPM support

2013-04-12 Thread Stefan Berger
Implement helper functions to find the TPM's sysfs cancel file. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com Tested-by: Corey Bryant cor...@linux.vnet.ibm.com --- po/POTFILES.in |1 src/Makefile.am |1

[libvirt] [PATCH v6 11/11] Add test case for TPM passthrough

2013-04-12 Thread Stefan Berger
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com Tested-by: Corey Bryant cor...@linux.vnet.ibm.com --- tests/qemuxml2argvdata/qemuxml2argv-tpm-passthrough.args |6 +++ tests/qemuxml2argvdata/qemuxml2argv-tpm-passthrough.xml | 29

[libvirt] [PATCH v6 01/11] Add QMP probing for TPM

2013-04-12 Thread Stefan Berger
Probe for QEMU's QMP TPM support by querying the lists of supported TPM models (query-tpm-models) and backend types (query-tpm-types). The setting of the capability flags following the strings returned from the commands above is only provided in the patch where domain_conf.c gets TPM support due

[libvirt] [PATCH v6 02/11] Add function to find a needle in a string array

2013-04-12 Thread Stefan Berger
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com Tested-by: Corey Bryant cor...@linux.vnet.ibm.com --- src/libvirt_private.syms |1 + src/util/virstring.c | 14 ++ src/util/virstring.h |2 ++ 3 files

[libvirt] [PATCH v6 10/11] TPM support for QEMU command line

2013-04-12 Thread Stefan Berger
For TPM passthrough device support create command line parameters like: -tpmdev passthrough,id=tpm-tpm0,path=/dev/tpm0,cancel-path=/sys/class/misc/tpm0/device/cancel -device tpm-tis,tpmdev=tpm-tpm0,id=tpm0 Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant

[libvirt] [PATCH 0/2] Domain object lookup improvements

2013-04-12 Thread Peter Krempa
This series finishes refactoring of domain object retrieval in the qemu driver and improves error message if the domain object can't be found. This is a prequel for changing of the locking model of virDomain objects. Peter Krempa (2): qemu: Refactor lookup of domain object qemu: Report also

[libvirt] [PATCH v6 00/11] Add support for guests with TPM passthrough device

2013-04-12 Thread Stefan Berger
Hello! The following set of patches adds support to libvirt for adding a TPM passthrough device to a QEMU guest. Support for this was recently accepted into QEMU. This set of patches borrows a lot from the recently added support for rng's. Regards, Stefan --- v5-v6: - followed tree to

[libvirt] [PATCH v6 08/11] Audit the starting of a guest using TPM passthrough

2013-04-12 Thread Stefan Berger
When a VM with a TPM passthrough device is started, the audit daemon logs the following type of message: type=VIRT_RESOURCE msg=audit(1365170222.460:3378): pid=16382 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:virtd_t:s0-s0:c0.c1023 msg='virt=kvm resrc=dev reason=start vm=TPM-PT

Re: [libvirt] [PATCH v4 11/11] Add test case for TPM passthrough

2013-04-12 Thread Stefan Berger
On 04/12/2013 04:47 AM, Daniel P. Berrange wrote: On Thu, Apr 11, 2013 at 01:24:21PM -0400, Stefan Berger wrote: On 04/11/2013 11:43 AM, Daniel P. Berrange wrote: On Fri, Apr 05, 2013 at 10:06:02AM -0400, Stefan Berger wrote: Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com

[libvirt] [PATCH v6 07/11] Add SELinux and DAC labeling support for TPM passthrough

2013-04-12 Thread Stefan Berger
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com Tested-by: Corey Bryant cor...@linux.vnet.ibm.com --- src/security/security_dac.c | 53 ++ src/security/security_selinux.c | 95

[libvirt] [PATCH 1/2] qemu: Refactor lookup of domain object

2013-04-12 Thread Peter Krempa
Use the helper to lookup the domain object in the remaining places. This patch also fixes error reporting when the domain was not found in several functions that were printing the raw UUID buffer instead of the formatted string. The offending functions were: qemuDomainGetInterfaceParameters

[libvirt] [PATCH v6 09/11] QEMU Cgroup support for TPM passthrough

2013-04-12 Thread Stefan Berger
Some refactoring for virDomainChrSourceDef type of devices so we can use common code. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com Tested-by: Corey Bryant cor...@linux.vnet.ibm.com --- src/qemu/qemu_cgroup.c | 53

[libvirt] [PATCH v6 06/11] Convert QMP strings into QEMU capability bits

2013-04-12 Thread Stefan Berger
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com Tested-by: Corey Bryant cor...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c | 58 +++ 1 file changed, 58 insertions(+) Index:

Re: [libvirt] [PATCH v6 00/11] Add support for guests with TPM passthrough device

2013-04-12 Thread Daniel P. Berrange
On Fri, Apr 12, 2013 at 09:25:14AM -0400, Stefan Berger wrote: Hello! The following set of patches adds support to libvirt for adding a TPM passthrough device to a QEMU guest. Support for this was recently accepted into QEMU. This set of patches borrows a lot from the recently added

[libvirt] [PATCH v6 05/11] Parse TPM passthrough XML in the domain XML

2013-04-12 Thread Stefan Berger
Parse the domain XML with TPM passthrough support. The TPM passthrough XML may look like this: tpm model='tpm-tis' backend type='passthrough' device path='/dev/tpm0'/ /backend /tpm Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant

Re: [libvirt] [PATCH 4/4] cleanup: Change datatype of net-stp to boolean

2013-04-12 Thread Laine Stump
On 04/12/2013 05:21 AM, Osier Yang wrote: --- src/conf/network_conf.c | 2 +- src/conf/network_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 968cf11..75584a0 100644 --- a/src/conf/network_conf.c +++

Re: [libvirt] [PATCH v6 00/11] Add support for guests with TPM passthrough device

2013-04-12 Thread Stefan Berger
On 04/12/2013 09:37 AM, Daniel P. Berrange wrote: On Fri, Apr 12, 2013 at 09:25:14AM -0400, Stefan Berger wrote: Hello! The following set of patches adds support to libvirt for adding a TPM passthrough device to a QEMU guest. Support for this was recently accepted into QEMU. This set of

Re: [libvirt] [PATCH 4/4] cleanup: Change datatype of net-stp to boolean

2013-04-12 Thread Eric Blake
On 04/12/2013 08:38 AM, Laine Stump wrote: On 04/12/2013 05:21 AM, Osier Yang wrote: --- Your conversion is fine, but this does highlight that the code here interprets *everything* except off as on (including OFF, no, Off, 0). There are actually many similar instances in the parser code.

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 10:58 AM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, Apr 12, 2013 at 08:34:18AM +0200, Michal Privoznik wrote: On 10.04.2013 15:13, harryxiyou wrote: Hi all, I've also got some ideas like following for GSOC 2013. Storage driver jobs. Currently,

Re: [libvirt] [PATCH v6 00/11] Add support for guests with TPM passthrough device

2013-04-12 Thread Stefan Berger
On 04/12/2013 09:37 AM, Daniel P. Berrange wrote: On Fri, Apr 12, 2013 at 09:25:14AM -0400, Stefan Berger wrote: Hello! The following set of patches adds support to libvirt for adding a TPM passthrough device to a QEMU guest. Support for this was recently accepted into QEMU. This set of

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-12 Thread Laine Stump
On 04/11/2013 07:23 AM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 07:03:56AM -0400, Laine Stump wrote: On 04/10/2013 05:26 AM, Daniel P. Berrange wrote: On Tue, Apr 09, 2013 at 04:06:06PM -0400, Laine Stump wrote: On 04/09/2013 04:58 AM, Daniel P. Berrange wrote: On Mon, Apr 08, 2013

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com wrote: [...] Michal said earlier that virsh vol-move seemed too small a task. Do you think that these 4 tasks together merit a 12-week project? Yes, these 4 tasks should be a whole project which may merit almost a 12-week

Re: [libvirt] [PATCH v6 00/11] Add support for guests with TPM passthrough device

2013-04-12 Thread Eric Blake
On 04/12/2013 09:29 AM, Stefan Berger wrote: On 04/12/2013 09:37 AM, Daniel P. Berrange wrote: On Fri, Apr 12, 2013 at 09:25:14AM -0400, Stefan Berger wrote: Hello! The following set of patches adds support to libvirt for adding a TPM passthrough device to a QEMU guest. Support for this was

Re: [libvirt] [PATCH v6 00/11] Add support for guests with TPM passthrough device

2013-04-12 Thread Daniel P. Berrange
On Fri, Apr 12, 2013 at 11:29:43AM -0400, Stefan Berger wrote: On 04/12/2013 09:37 AM, Daniel P. Berrange wrote: On Fri, Apr 12, 2013 at 09:25:14AM -0400, Stefan Berger wrote: Hello! The following set of patches adds support to libvirt for adding a TPM passthrough device to a QEMU guest.

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 11:47 PM, harryxiyou harryxi...@gmail.com wrote: On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com wrote: [...] Michal said earlier that virsh vol-move seemed too small a task. Do you think that these 4 tasks together merit a 12-week project? Yes,

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 5:56 PM, harryxiyou harryxi...@gmail.com wrote: On Fri, Apr 12, 2013 at 11:47 PM, harryxiyou harryxi...@gmail.com wrote: On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com wrote: [...] Michal said earlier that virsh vol-move seemed too small a task.

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 11:47 PM, harryxiyou harryxi...@gmail.com wrote: On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com wrote: [...] Michal said earlier that virsh vol-move seemed too small a task. Do you think that these 4 tasks together merit a 12-week project? Yes,

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 11:57 PM, Stefan Hajnoczi stefa...@gmail.com wrote: [...] Right, I'm trying to check with danpb, mprivozn, eblake, and osier whether these tasks are worthy of a 12-week project. There needs to be agreement here before we can add this as a project idea to the GSoC wiki

Re: [libvirt] [PATCH 2/2] qemu: Report also domain name in error message when domain object wasn't found

2013-04-12 Thread Daniel P. Berrange
On Fri, Apr 12, 2013 at 03:24:56PM +0200, Peter Krempa wrote: Report the errors as: Domain not found: no domain with matching uuid '41414141-4141-4141-4141-414141414141' (crashtest) instead of: Domain not found: no domain with matching uuid '41414141-4141-4141-4141-414141414141' ---

Re: [libvirt] [libvirt-designer v3] Add Vala API

2013-04-12 Thread Zeeshan Ali (Khattak)
On Thu, Apr 11, 2013 at 6:28 PM, Christophe Fergeau cferg...@redhat.com wrote: On Thu, Apr 11, 2013 at 04:32:30PM +0300, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This is mostly (modified) copypaste from libvirt-glib. --- v3: Added .metadata file to

Re: [libvirt] [PATCH 1/2] qemu: Refactor lookup of domain object

2013-04-12 Thread Daniel P. Berrange
On Fri, Apr 12, 2013 at 03:24:55PM +0200, Peter Krempa wrote: Use the helper to lookup the domain object in the remaining places. This patch also fixes error reporting when the domain was not found in several functions that were printing the raw UUID buffer instead of the formatted string.

Re: [libvirt] Shared desktop: grant permission to start/stop/pause/resume guests only

2013-04-12 Thread Daniel P. Berrange
On Fri, Apr 12, 2013 at 11:17:12AM -0400, Dave Allan wrote: On Fri, Apr 12, 2013 at 01:37:07PM +0200, Michal Privoznik wrote: On 12.04.2013 13:24, Thorsten Hesemeyer wrote: Hi all, for a shared desktop configuration, is there an option to grant the permission to start, stop, pause

[libvirt] [PATCH] Do more complete initialization of libgcrypt

2013-04-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com If libvirt makes any gcry_control() calls, then this prevents gnutls for doing any initialization. As such we must take care to do full initialization of libcrypt on a par with what gnutls would have done. In particular we must disable sec mem for

Re: [libvirt] [PATCH v6 00/11] Add support for guests with TPM passthrough device

2013-04-12 Thread Stefan Berger
On 04/12/2013 11:54 AM, Daniel P. Berrange wrote: On Fri, Apr 12, 2013 at 11:29:43AM -0400, Stefan Berger wrote: On 04/12/2013 09:37 AM, Daniel P. Berrange wrote: On Fri, Apr 12, 2013 at 09:25:14AM -0400, Stefan Berger wrote: Hello! The following set of patches adds support to libvirt for

Re: [libvirt] [PATCH v6 04/11] Helper functions for host TPM support

2013-04-12 Thread Stefan Berger
After a further simplification the patch now looks like this: Implement helper function to create the TPM's sysfs cancel file. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com Tested-by: Corey Bryant cor...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH] Do more complete initialization of libgcrypt

2013-04-12 Thread Eric Blake
On 04/12/2013 10:27 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If libvirt makes any gcry_control() calls, then this prevents gnutls for doing any initialization. As such we must take care to do full initialization of libcrypt on a par with what gnutls would

Re: [libvirt] [PATCH v6 04/11] Helper functions for host TPM support

2013-04-12 Thread Eric Blake
On 04/12/2013 12:47 PM, Stefan Berger wrote: After a further simplification the patch now looks like this: Implement helper function to create the TPM's sysfs cancel file. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey Bryant cor...@linux.vnet.ibm.com

Re: [libvirt] [PATCH v6 04/11] Helper functions for host TPM support

2013-04-12 Thread Stefan Berger
On 04/12/2013 03:40 PM, Eric Blake wrote: On 04/12/2013 12:47 PM, Stefan Berger wrote: After a further simplification the patch now looks like this: Implement helper function to create the TPM's sysfs cancel file. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Corey

Re: [libvirt] [PATCH v3 06/16] Add a test suite for cgroups functionality

2013-04-12 Thread Eric Blake
On 04/10/2013 04:08 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Some aspects of the cgroups setup / detection code are quite subtle and easy to break. It would greatly benefit from unit testing, but this is difficult because the test suite won't have privileges

[libvirt] QEMU/KVM support for non zero PCI domain

2013-04-12 Thread Charles Peri
Hi, I am trying to run Virt-Manager, using KVM on a SGIUV100 system with RHEL 6.1. I am trying to enable PCI pass-thorugh for the Mellanox, but the PCI domain for the device is 0001. 0001:01:00.0 Ethernet controller: Mellanox Technologies MT26448 [ConnectX EN 10GigE, PCIe 2.0 5GT/s] (rev

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread Osier Yang
On 12/04/13 23:57, Stefan Hajnoczi wrote: On Fri, Apr 12, 2013 at 5:56 PM, harryxiyou harryxi...@gmail.com wrote: On Fri, Apr 12, 2013 at 11:47 PM, harryxiyou harryxi...@gmail.com wrote: On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com wrote: [...] Michal said earlier that

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread Osier Yang
On 13/04/13 13:27, Osier Yang wrote: On 12/04/13 23:57, Stefan Hajnoczi wrote: On Fri, Apr 12, 2013 at 5:56 PM, harryxiyou harryxi...@gmail.com wrote: On Fri, Apr 12, 2013 at 11:47 PM, harryxiyou harryxi...@gmail.com wrote: On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread Osier Yang
On 13/04/13 00:05, harryxiyou wrote: On Fri, Apr 12, 2013 at 11:57 PM, Stefan Hajnoczi stefa...@gmail.com wrote: [...] Right, I'm trying to check with danpb, mprivozn, eblake, and osier whether these tasks are worthy of a 12-week project. There needs to be agreement here before we can add this

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread Osier Yang
On 13/04/13 13:35, Osier Yang wrote: On 13/04/13 00:05, harryxiyou wrote: On Fri, Apr 12, 2013 at 11:57 PM, Stefan Hajnoczi stefa...@gmail.com wrote: [...] Right, I'm trying to check with danpb, mprivozn, eblake, and osier whether these tasks are worthy of a 12-week project. There needs to

Re: [libvirt] [PATCH 0/4] cleanup: Use bool type instead of bitfield - More

2013-04-12 Thread Osier Yang
On 12/04/13 22:38, Laine Stump wrote: On 04/12/2013 05:21 AM, Osier Yang wrote: Which are missed with pattern : 1 in the previous cleanup series. After these, all the bitfield use under src/conf/ are destroyed, except the ones which are required by the existing APIs. Osier Yang (4):

Re: [libvirt] [PATCH 4/4] cleanup: Change datatype of net-stp to boolean

2013-04-12 Thread Osier Yang
On 12/04/13 23:17, Eric Blake wrote: On 04/12/2013 08:38 AM, Laine Stump wrote: On 04/12/2013 05:21 AM, Osier Yang wrote: --- Your conversion is fine, but this does highlight that the code here interprets *everything* except off as on (including OFF, no, Off, 0). There are actually many