Re: [libvirt] [PATCH v2 08/15] util: Replace virStoragePoolGetVhbaSCSIHostParent

2017-02-18 Thread Pavel Hrdina
On Sat, Feb 18, 2017 at 03:43:47PM -0500, John Ferlan wrote: > Use the new virNodeDeviceGetParentName instead. Modify the callers to > build the node device scsi_host# name string in order to call the new > function so that proper lookup occurs. > > Signed-off-by: John Ferlan

Re: [libvirt] [PATCH v2 07/15] nodedev: Introduce virNodeDeviceGetParentName

2017-02-18 Thread Pavel Hrdina
On Sat, Feb 18, 2017 at 03:41:31PM -0500, John Ferlan wrote: > Create a function which takes a node device "name" entry to lookup > and returns a string containing the parent name for the node device. > > Signed-off-by: John Ferlan > --- > > Adjustment from v1... Instead of

Re: [libvirt] [PATCH 10/15] tests: Add new fchosttest tests for management of a vHBA

2017-02-18 Thread Pavel Hrdina
On Wed, Jan 25, 2017 at 03:27:36PM -0500, John Ferlan wrote: > Add a test that will mimic creation and destruction of a vHBA > by using node device XML. The design will allow for testing the > multiple mechanisms. > > The first test uses just in the node device XML. This is > somewhat similar to

Re: [libvirt] ARMv7 guest PCI support broken in 3.0.0 onwards

2017-02-18 Thread Andrea Bolognani
On Fri, 2017-02-17 at 15:56 +0100, Andrea Bolognani wrote: > libvirt is picking GICv3 here because QEMU reports it as a > viable emulated GIC; however, as I understand it the > emulated GICv3 doesn't have MSI support, and without that > PCIe can't work. If you manually switch to GICv2 you should >

[libvirt] [PATCH] nodedev: fix build with clang

2017-02-18 Thread Roman Bogorodskiy
Build fails with: conf/node_device_conf.c:825:62: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare] if ((data->drm.type = virNodeDevDRMTypeFromString(type)) < 0) { ^ ~

[libvirt] [PATCH v2 08/15] util: Replace virStoragePoolGetVhbaSCSIHostParent

2017-02-18 Thread John Ferlan
Use the new virNodeDeviceGetParentName instead. Modify the callers to build the node device scsi_host# name string in order to call the new function so that proper lookup occurs. Signed-off-by: John Ferlan --- Changes since v1: This is the replacement/followup for the

[libvirt] [PATCH v2 07/15] nodedev: Introduce virNodeDeviceGetParentName

2017-02-18 Thread John Ferlan
Create a function which takes a node device "name" entry to lookup and returns a string containing the parent name for the node device. Signed-off-by: John Ferlan --- Adjustment from v1... Instead of moving function to virvhba.c, create a new node_device_conf API which

Re: [libvirt] [PATCH 15/15] tests: Add createVHBAByNodeDevice-parent-fabric-wwn to fchosttest

2017-02-18 Thread Pavel Hrdina
On Wed, Jan 25, 2017 at 03:27:41PM -0500, John Ferlan wrote: > Add a test that allows providing the parent fabric_wwn in the input XML > in order to create the vHBA. > > This also fixes a mixed setting of the fabric_wwn field from the read > test driver XML strings. > > Signed-off-by: John

Re: [libvirt] [PATCH 11/15] nodedev: Keep the node device lock longer in nodeDeviceDestroy

2017-02-18 Thread Pavel Hrdina
On Wed, Jan 25, 2017 at 03:27:37PM -0500, John Ferlan wrote: > While perhaps improbable, it could be possible that after finding our > object that another thread running essentially in parallel could attempt > to delete the same vHBA. > > So rather than dropping the lock right after finding the

Re: [libvirt] [PATCH 12/15] nodedev: Rework virNodeDeviceGetParentHost

2017-02-18 Thread Pavel Hrdina
On Wed, Jan 25, 2017 at 03:27:38PM -0500, John Ferlan wrote: > Rework the code to perform the various searches by parent, parent_wwnn/ > parent_wwpn, parent_fabric_wwn, or vport capable in order to return the > 'parent_host' number that is vHBA capable. > > The former virNodeDeviceGetParentHost

Re: [libvirt] [PATCH 13/15] tests: Add createVHBAByNodeDevice-no-parent to fchosttest

2017-02-18 Thread Pavel Hrdina
On Wed, Jan 25, 2017 at 03:27:39PM -0500, John Ferlan wrote: > Add a test that allows not providing a parent in the input XML, but still > being able to create finding a VPORT capable NPIV HBA. > > Signed-off-by: John Ferlan > --- > tests/fchosttest.c | 12 > 1

Re: [libvirt] [PATCH 14/15] tests: Add createVHBAByNodeDevice-parent-wwn to fchosttest

2017-02-18 Thread Pavel Hrdina
On Wed, Jan 25, 2017 at 03:27:40PM -0500, John Ferlan wrote: > Add a test that allows providing the parent wwnn/wwpn in the input XML > in order to create the vHBA. > > Signed-off-by: John Ferlan > --- > tests/fchosttest.c | 14 ++ > 1 file changed, 14