Re: [libvirt] [PATCH perl v2] Remove use of Data::Dumper from example programs

On 02/06/2018 01:10 PM, Daniel P. Berrangé wrote: > Using Data::Dumper in examples does not help devs understand the data > structures that the Perl APIs are returning. Change to explicit field > accesses to illustrate it better > > Signed-off-by: Daniel P. Berrangé > ---

Re: [libvirt] [PATCH perl] Remove use of Data::Dumper from example programs

On 02/06/2018 11:36 AM, Daniel P. Berrangé wrote: > Using Data::Dumper in examples does not help devs understand the data > structures that the Perl APIs are returning. Change to explicit field > accesses to illustrate it better > > Signed-off-by: Daniel P. Berrangé > ---

[libvirt] [PATCH perl v2] Remove use of Data::Dumper from example programs

Using Data::Dumper in examples does not help devs understand the data structures that the Perl APIs are returning. Change to explicit field accesses to illustrate it better Signed-off-by: Daniel P. Berrangé --- examples/dhcp-leases.pl | 7 +-- examples/dom-fsinfo.pl |

Re: [libvirt] [PATCH perl] Remove use of Data::Dumper from example programs

On 02/06/2018 11:36 AM, Daniel P. Berrangé wrote: > Using Data::Dumper in examples does not help devs understand the data > structures that the Perl APIs are returning. Change to explicit field > accesses to illustrate it better > > Signed-off-by: Daniel P. Berrangé

Re: [libvirt] [PATCH perl] Remove use of Data::Dumper from example programs

On Tue, Feb 06, 2018 at 01:01:42PM -0500, Laine Stump wrote: > On 02/06/2018 11:36 AM, Daniel P. Berrangé wrote: > > Using Data::Dumper in examples does not help devs understand the data > > structures that the Perl APIs are returning. Change to explicit field > > accesses to illustrate it better

[libvirt] [PATCH 2/2] lockd: Install the admin sockets

Commit id 'ce7ae55e' added support for the lockd admin socket, but forgot to add the socket to the make and spec files for installation purposes. Signed-off-by: John Ferlan --- libvirt.spec.in | 8 ++-- src/Makefile.am | 19 +++ 2 files changed, 21

[libvirt] [PATCH] conf: Check for user aliases duplicates only

When validating a device XML config we check if user provided alias is unique. We do this by maintaining a hash table of device aliases as we iterated over all devices defined for the domain. However, it may happen that what appears as two devices in domain XML is in fact just one interface in

Re: [libvirt] [PATCH] conf: Check for user aliases duplicates only

On Tue, Feb 06, 2018 at 03:40:18PM +0100, Michal Privoznik wrote: > When validating a device XML config we check if user provided > alias is unique. We do this by maintaining a hash table of device > aliases as we iterated over all devices defined for the domain. > However, it may happen that what

[libvirt] [PATCH 01/11] qemu: Move feature verification from PostParse() to Validate()

We want to perform all feature verification in a single spot, but some of it (eg. GIC) is currently being performed at command line generation time, and moving it to PostParse() would cause guests to disappear. Moving verification to Validate() allows us to side-step the issue. Signed-off-by:

[libvirt] [PATCH 02/11] qemu: Use switch in qemuDomainDefValidateFeatures()

The compiler can make sure we are handling all features. While reworking the logic, also change error messages to a more consistent style. Signed-off-by: Andrea Bolognani --- src/libvirt_private.syms | 2 ++ src/qemu/qemu_domain.c | 57

[libvirt] [PATCH 04/11] conf: Use switch in virDomainDefFeaturesCheckABIStability()

The compiler can make sure we are handling all features. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 41 + 1 file changed, 33 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c

Re: [libvirt] [PATCH] conf: Check for user aliases duplicates only

On 02/06/2018 03:52 PM, Daniel P. Berrangé wrote: > On Tue, Feb 06, 2018 at 03:40:18PM +0100, Michal Privoznik wrote: >> When validating a device XML config we check if user provided >> alias is unique. We do this by maintaining a hash table of device >> aliases as we iterated over all devices

[libvirt] [PATCH 06/11] conf: Integrate all features ABI checks in the switch

There are a few stray checks which still live outside of the switch in virDomainDefFeaturesCheckABIStability() for no good reason. Move them inside the switch, and update the error messages to be consistent while at it. Signed-off-by: Andrea Bolognani ---

[libvirt] [PATCH 03/11] qemu: Move GIC checks to qemuDomainDefValidateFeatures()

Keep them along with other arch/machine type checks for features instead of waiting until command line generation time. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 7 --- src/qemu/qemu_domain.c | 11 ++- tests/qemuxml2argvtest.c | 12

[libvirt] [PATCH 08/11] qemu: Fix GIC behavior for the default case

When no GIC version is specified, we currently default to GIC v2; however, that's not a great default, since guests will fail to start if the hardware only supports GIC v3. Change the behavior so that a sensible default is chosen instead. That basically means using the same algorithm whether the

[libvirt] [PATCH 11/11] tests: Clean up HPT tests

Give them better names and remove some redundancy. Signed-off-by: Andrea Bolognani --- ...es-hpt-resizing.args => pseries-features-hpt.args} | 1 - .../pseries-features-hpt.xml} | 0 ...chine.xml => pseries-features-invalid-machine.xml} | 2 +-

[libvirt] [PATCH 10/11] conf: Improve HPT feature handling

Instead of storing separately whether the feature is enabled or not and what resizing policy should be used, store both of them in a single place. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 26 -- src/conf/domain_conf.h | 4 ++--

[libvirt] [PATCH 09/11] conf: Improve IOAPIC feature handling

Instead of storing separately whether the feature is enabled or not and what driver should be used, store both of them in a single place. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 29 + src/conf/domain_conf.h | 11 ++-

[libvirt] [PATCH 00/11] Fixes and improvements to feature handling

This series is the result of shaving many a yak while implementing support for pSeries optional features (first attempt at [1], respin coming right after I send this). Quick summary of the changes: * handle more sanely cases where the GIC capability has been enabled but no GIC version has been

[libvirt] [PATCH 07/11] tests: Improve GIC tests

Account for the fact that the default might change based on what GIC versions are supported by QEMU. That's not the case at the moment, but it will be soon. Signed-off-by: Andrea Bolognani --- tests/qemuxml2argvdata/aarch64-gic-default-both.args | 1 +

[libvirt] [PATCH 05/11] conf: Validate VIR_DOMAIN_FEATURE_CAPABILITIES properly

Unlike most other features, VIR_DOMAIN_FEATURE_CAPABILITIES is of type virDomainCapabilitiesPolicy instead of virTristateSwitch, so we need to handle it separately for the error message to make sense. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 13

[libvirt] [PATCH RFCv2 2/4] qemu: Implement the SBBC pSeries feature

This is the first pSeries-specific optional feature that is used to represent a hardware bug and to control how it will be exposed to the guest. Signed-off-by: Andrea Bolognani --- docs/schemas/domaincommon.rng | 15 +++ src/conf/domain_conf.c

Re: [libvirt] [PATCH tck] Relabel SELinux when customizing virt-builder image

On 02/06/2018 10:53 AM, Pino Toscano wrote: > On Tuesday, 6 February 2018 16:40:04 CET Daniel P. Berrangé wrote: >> When you tell virt-builder to install extra RPMs, this potentially >> looses the SELinux labelling that Anaconda had originally setup. Thus we >> must tell virt-builder to enable

Re: [libvirt] [PATCH perl] Remove use of Data::Dumper from example programs

On Tue, Feb 06, 2018 at 01:05:52PM -0500, John Ferlan wrote: > > > On 02/06/2018 11:36 AM, Daniel P. Berrangé wrote: > > Using Data::Dumper in examples does not help devs understand the data > > structures that the Perl APIs are returning. Change to explicit field > > accesses to illustrate it

[libvirt] [PATCH 1/2] logd: Install the admin sockets

Commit id '85d45ff0' added support for the logd admin socket, but forgot to add the socket to the make and spec files for installation purposes. NB: Includes breaking up the long %systemd_ lists across multiple lines for ease of reading Signed-off-by: John Ferlan ---

[libvirt] [PATCH 0/2] Add {lockd|logd} admin sockets to install

Hopefully I covered what's necessary... Essentially a bunch of copying of existing examples... I haven't been able to actually build an RPM locally for a long time, but this does work with make install at least (or at least it worked in the environment I tried it on). John Ferlan (2): logd:

Re: [libvirt] [PATCH v2] virt-aa-helper: Set the supported features

On Mon, Feb 5, 2018 at 6:44 PM, Peter Krempa wrote: > On Mon, Feb 05, 2018 at 18:39:24 +0530, Shivaprasad bhat wrote: > > Thanks for the reply Peter, Christian > > > > On Fri, Feb 2, 2018 at 3:21 PM, Peter Krempa wrote: > > > > > On Fri, Feb 02, 2018 at

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

On 01.02.2018 21:26, Eduardo Habkost wrote: > On Thu, Feb 01, 2018 at 09:15:15PM +0100, Radim Krčmář wrote: >> 2018-02-01 12:54-0500, Luiz Capitulino: >>> >>> Libvirt needs to know when a vCPU is halted. To get this information, >> >> I don't see why upper level management should care about that,

Re: [libvirt] [PATCH v2] virt-aa-helper: Set the supported features

On Tue, Feb 06, 2018 at 15:11:10 +0530, Shivaprasad bhat wrote: > On Mon, Feb 5, 2018 at 6:44 PM, Peter Krempa wrote: > > > On Mon, Feb 05, 2018 at 18:39:24 +0530, Shivaprasad bhat wrote: > > > Thanks for the reply Peter, Christian > > > > > > On Fri, Feb 2, 2018 at 3:21 PM,

Re: [libvirt] [PATCH] qemu: Limit refresh of CPU halted state to s390

On Tue, Feb 06, 2018 at 11:55:07 +0100, Peter Krempa wrote: > On Tue, Feb 06, 2018 at 11:18:56 +0100, Viktor Mihajlovski wrote: > > Refreshing the halted state can cause VM performance issues. Since > > s390 is currently the only architecture with a known interest in > > the halted state, we're

Re: [libvirt] [RFC v2 REPOST] arm64: KVM: KVM API extensions for SVE

On Mon, Feb 05, 2018 at 05:13:08PM +0100, Christoffer Dall wrote: > Hi Dave, > > On Fri, Jan 26, 2018 at 05:28:49PM +, Dave Martin wrote: > > New feature KVM_ARM_VCPU_SVE: > > > > * enables exposure of SVE to the guest > > > > * enables visibility of / access to KVM_REG_ARM_SVE_*() via

[libvirt] [PATCH] qemu: Check for down limit of SLIRP prefix too

https://bugzilla.redhat.com/show_bug.cgi?id=1515533 We're already checking if IPv4 prefix isn't too long. But we are not checking if it isn't too short. QEMU supports prefixes longer than 4 (including). I haven't find anything similar related to IPv6 in qemu sources. Signed-off-by: Michal

[libvirt] [python PATCH] event-test.py: Remove extra ( in --help output

Signed-off-by: Jiri Denemark --- Pushed as trivial. examples/event-test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/event-test.py b/examples/event-test.py index 2587226..3de333c 100755 --- a/examples/event-test.py +++

Re: [libvirt] [PATCH v3 1/4] util: introduce helper to parse /proc/net/arp

At 2018-01-29 20:01:30, "Peter Krempa" wrote: >On Mon, Jan 29, 2018 at 16:35:33 +0800, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> introduce helper to parse /proc/net/arp and >> store it in struct virArpTable. >> >> Signed-off-by: Chen Hanxiao

[libvirt] [PATCH] util: netlink: fix the mismatch parameter description of functions

From: Chen Hanxiao Some of netlink functions don't have the right @parameters description according to the declaration of function. This patch fix them. Signed-off-by: Chen Hanxiao --- src/util/virnetlink.c | 35

[libvirt] [PATCH] qemu: Limit refresh of CPU halted state to s390

Refreshing the halted state can cause VM performance issues. Since s390 is currently the only architecture with a known interest in the halted state, we're avoiding to call QEMU on other platforms. Signed-off-by: Viktor Mihajlovski --- src/qemu/qemu_domain.c | 4

Re: [libvirt] [PATCH] qemu: Limit refresh of CPU halted state to s390

On Tue, Feb 06, 2018 at 11:18:56 +0100, Viktor Mihajlovski wrote: > Refreshing the halted state can cause VM performance issues. Since > s390 is currently the only architecture with a known interest in > the halted state, we're avoiding to call QEMU on other platforms. > > Signed-off-by: Viktor

Re: [libvirt] [PATCH] qemu: Limit refresh of CPU halted state to s390

On Tue, Feb 06, 2018 at 12:00:31PM +0100, Peter Krempa wrote: > On Tue, Feb 06, 2018 at 11:55:07 +0100, Peter Krempa wrote: > > On Tue, Feb 06, 2018 at 11:18:56 +0100, Viktor Mihajlovski wrote: > > > Refreshing the halted state can cause VM performance issues. Since > > > s390 is currently the

Re: [libvirt] [PATCH] qemu: Limit refresh of CPU halted state to s390

On Tue, Feb 06, 2018 at 11:05:06 +, Daniel Berrange wrote: > On Tue, Feb 06, 2018 at 12:00:31PM +0100, Peter Krempa wrote: > > On Tue, Feb 06, 2018 at 11:55:07 +0100, Peter Krempa wrote: > > > On Tue, Feb 06, 2018 at 11:18:56 +0100, Viktor Mihajlovski wrote: > > > > Refreshing the halted state

Re: [libvirt] [PATCH] conf: Check for NUMA distances in validity check

On Tue, Feb 06, 2018 at 17:23:47 +0100, Michal Privoznik wrote: > NUMA distances are part of guest ABI (guests can read it > directly!) and therefore as such shouldn't change throughout the > lifetime of domain. > > Signed-off-by: Michal Privoznik > --- >

[libvirt] ANNOUNCE: virt-manager 1.5.0 released

I'm happy to announce the release of virt-manager 1.5.0! virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from: http://virt-manager.org/download/ This release includes: - python3 prep work (Radostin Stoyanov, Cole

[libvirt] [PATCH v5 3/3] nwfilter: Remove need for nwfilterDriverLock in some API's

Now that nwfilters object list is self locking, it's no longer necessary to hold the driver level lock for certain API's. However, for the DefineXML, Undefine, and Reload processing keeping that lock ensures for serialization required in order to process the filter Instantiation properly.

[libvirt] [PATCH v5 0/3] nwfilter common object adjustments

v4: https://www.redhat.com/archives/libvir-list/2017-December/msg00282.html But more recently reviewed: https://www.redhat.com/archives/libvir-list/2018-February/msg00022.html https://www.redhat.com/archives/libvir-list/2018-February/msg00015.html

[libvirt] [PATCH v5 2/3] nwfilter: Convert _virNWFilterObjList to use virObjectRWLockable

Implement the self locking object list for nwfilter object lists that uses two hash tables to store the nwfilter object by UUID or by Name. As part of this alter the uuid argument to virNWFilterObjLookupByUUID to expect an already formatted uuidstr. Alter the existing list traversal code to

[libvirt] [PATCH v5 1/3] nwfilter: Convert _virNWFilterObj to use virObjectRWLockable

Unlike it's counterparts, the nwfilter object code needs to be able to support recursive read locks while processing and checking new filters against the existing environment. Thus instead of using a virObjectLockable which uses pure mutexes, use the virObjectRWLockable and primarily use

Re: [libvirt] [PATCH RFCv2 0/4] Add optional pSeries features

On Tue, Feb 06, 2018 at 17:54:55 +0100, Andrea Bolognani wrote: > Applies on top of [req]. > > RFC because we still don't have a way of probing QEMU to figure > out whether the relevant toggles are available. Plus, there's no > documentation yet :) I wanted to moan about missing docs and sub-par

Re: [libvirt] [PATCH tck] Relabel SELinux when customizing virt-builder image

On Tuesday, 6 February 2018 16:40:04 CET Daniel P. Berrangé wrote: > When you tell virt-builder to install extra RPMs, this potentially > looses the SELinux labelling that Anaconda had originally setup. Thus we > must tell virt-builder to enable SELinux relabelling. > > Signed-off-by: Daniel P.

[libvirt] [PATCH RFCv2 1/4] qemu: Implement the HTM pSeries feature

This is the first in a list of pSeries-specific optional features that have recently been introduced in QEMU. Along with the feature proper, some generic code that will make it easier to implement subsequent features is introduced as well. Signed-off-by: Andrea Bolognani ---

[libvirt] [PATCH RFCv2 0/4] Add optional pSeries features

Applies on top of [req]. RFC because we still don't have a way of probing QEMU to figure out whether the relevant toggles are available. Plus, there's no documentation yet :) Changes from [RFCv1]: * don't nest features inside a element; * implement all optional features. [req]

Re: [libvirt] [PATCH] apparmor: allow libvirt to send term signal to unconfined

On Thu, Jan 25, 2018 at 9:09 PM, Jamie Strandboge wrote: > On Wed, 2018-01-24 at 10:41 +0100, intrigeri wrote: >> Hi, >> >> >> Guido Günther: >> > --- a/examples/apparmor/usr.sbin.libvirtd >> > +++ b/examples/apparmor/usr.sbin.libvirtd >> > @@ -63,7 +63,7 @@ >> >signal

Re: [libvirt] [PATCH 2/2] qemu: Add and use qemuProcessEventFree for freeing qemuProcessEvents

On Mon, Feb 05, 2018 at 01:12 PM +0100, Michal Privoznik wrote: > On 02/05/2018 12:32 PM, Marc Hartmayer wrote: >> On Mon, Feb 05, 2018 at 11:31 AM +0100, Michal Privoznik >> wrote: >>> On 02/05/2018 11:17 AM, Marc Hartmayer wrote: On Mon, Feb 05,

[libvirt] [PATCH] conf: Check for NUMA distances in validity check

NUMA distances are part of guest ABI (guests can read it directly!) and therefore as such shouldn't change throughout the lifetime of domain. Signed-off-by: Michal Privoznik --- src/conf/numa_conf.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff

[libvirt] [PATCH perl] Remove use of Data::Dumper from example programs

Using Data::Dumper in examples does not help devs understand the data structures that the Perl APIs are returning. Change to explicit field accesses to illustrate it better Signed-off-by: Daniel P. Berrangé --- Virt.xs | 1 - examples/dhcp-leases.pl | 2 --

[libvirt] [PATCH RFCv2 3/4] qemu: Implement the CFPC pSeries feature

Signed-off-by: Andrea Bolognani --- docs/schemas/domaincommon.rng | 5 src/conf/domain_conf.c | 4 src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 4

[libvirt] [PATCH RFCv2 4/4] qemu: Implement the IBS pSeries feature

Signed-off-by: Andrea Bolognani --- docs/schemas/domaincommon.rng | 5 src/conf/domain_conf.c| 4 src/conf/domain_conf.h| 1 + src/qemu/qemu_capabilities.c | 2 ++

[libvirt] [PATCH 4/4] qemu: Limit refresh of CPU halted state to s390

From: Viktor Mihajlovski Refreshing the halted state can cause VM performance issues. Since s390 is currently the only architecture with a known interest in the halted state, we're avoiding to call QEMU on other platforms. Signed-off-by: Viktor Mihajlovski

[libvirt] [PATCH 3/4] qemu: domain: Store vcpu halted state as a tristate

Since it may be possible that the state is unknown in some cases we should store it as a tristate so that other code using it can determine whether the state was updated. --- src/qemu/qemu_domain.c | 3 ++- src/qemu/qemu_domain.h | 2 +- src/qemu/qemu_driver.c | 13 - 3 files

[libvirt] [PATCH 1/4] qemu: driver: Extract vcpu halted state directly

Don't extract the halted state into a separate array, but rater access the vcpu structures directly. We still need to call the vcpu helper to retrieve the performance statistics though. --- src/qemu/qemu_driver.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff

[libvirt] [PATCH 0/4] qemu: Don't refresh 'halted' state for domain stats

The halted state information is useless on most platforms and calling 'query-cpus' is very expensive. Don't report the info on platforms where it does not make sense. Peter Krempa (3): qemu: driver: Extract vcpu halted state directly qemu: Remove unused 'cpuhalted' argument from

[libvirt] [PATCH 2/4] qemu: Remove unused 'cpuhalted' argument from qemuDomainHelperGetVcpus

The halted state is no longer extracted using this helper so the argument can be removed. --- src/qemu/qemu_driver.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 172a8a3f73..eaa6049fee 100644 ---

[libvirt] [PATCH tck] Relabel SELinux when customizing virt-builder image

When you tell virt-builder to install extra RPMs, this potentially looses the SELinux labelling that Anaconda had originally setup. Thus we must tell virt-builder to enable SELinux relabelling. Signed-off-by: Daniel P. Berrangé --- lib/Sys/Virt/TCK.pm | 2 +- 1 file

Re: [libvirt] [PATCH] apparmor: allow libvirt to send term signal to unconfined

On 02/06/2018 03:54 PM, Christian Ehrhardt wrote: > On Thu, Jan 25, 2018 at 9:09 PM, Jamie Strandboge wrote: >> On Wed, 2018-01-24 at 10:41 +0100, intrigeri wrote: >>> Hi, >>> >>> >>> Guido Günther: --- a/examples/apparmor/usr.sbin.libvirtd +++

Re: [libvirt] [PATCH] apparmor: allow libvirt to send term signal to unconfined

On Tue, Feb 6, 2018 at 5:28 PM, Michal Privoznik wrote: > On 02/06/2018 03:54 PM, Christian Ehrhardt wrote: >> On Thu, Jan 25, 2018 at 9:09 PM, Jamie Strandboge >> wrote: >>> On Wed, 2018-01-24 at 10:41 +0100, intrigeri wrote: Hi,

Re: [libvirt] [PATCH 0/4] qemu: Don't refresh 'halted' state for domain stats

On 06.02.2018 16:30, Peter Krempa wrote: > The halted state information is useless on most platforms and calling > 'query-cpus' is very expensive. Don't report the info on platforms where > it does not make sense. > > Peter Krempa (3): > qemu: driver: Extract vcpu halted state directly >

[libvirt] [PATCH v2 5/6] port allocator: remove release functionality from set used

Let's use virPortAllocatorRelease instead of virPortAllocatorSetUsed(false). --- src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_process.c | 2 +- src/qemu/qemu_process.c| 16 src/util/virportallocator.c| 22 ++

[libvirt] [PATCH v2 6/6] port allocator: make port range constant object

--- src/libxl/libxl_conf.h | 4 ++-- src/qemu/qemu_conf.h| 6 +++--- src/util/virportallocator.c | 2 +- src/util/virportallocator.h | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index ee09b7e..0e85dff 100644

[libvirt] [PATCH v2 0/6] port allocator: make used port bitmap global etc

This patch set addresses issue(s) described in [1] and the core of changes go to the first patch. The others are cleanups and refactorings. Diff from v1: - rename virPortRange to virPortAllocatorRange (virPortRange is occupied) - release ports in libxl and bhyve tests - overload bind syscall for

[libvirt] [PATCH v2 3/6] port allocator: remove range check in release function

Range check in virPortAllocatorSetUsed is not useful anymore when we manage ports for entire unsigned short range values. --- src/bhyve/bhyve_process.c | 3 +-- src/libxl/libxl_domain.c | 3 +-- src/libxl/libxl_migration.c| 4 ++-- src/qemu/qemu_migration.c | 12

[libvirt] [PATCH v2 2/6] port allocator: remove range on manual port reserving

Range check in virPortAllocatorSetUsed is not useful anymore when we manage ports for entire unsigned short range values. --- src/bhyve/bhyve_command.c | 4 +--- src/bhyve/bhyve_process.c | 4 +--- src/qemu/qemu_process.c| 41 +++--

[libvirt] [PATCH v2 4/6] port allocator: drop skip bind check flag

This flag is only used for tests. Let's instead overload bind syscall in mocks where it is not done yet. --- src/bhyve/bhyve_driver.c | 2 +- src/libxl/libxl_driver.c | 5 ++--- src/qemu/qemu_driver.c | 9 +++-- src/util/virportallocator.c| 14 --

[libvirt] [PATCH v2 1/6] port allocator: make used port bitmap global

Host tcp4/tcp6 ports is a global resource thus we need to make port accounting also global or we have issues described in [1] when port allocator ranges of different instances are overlapped (which is by default for qemu for example). Let's have only one global port allocator object that take

[libvirt] [PATCH v4] virt-aa-helper: Set the supported features

The virt-aa-helper fails to parse the xmls with the memory/cpu hotplug features or user assigned aliases. Set the features in xmlopt->config for the parsing to succeed. Signed-off-by: Shivaprasad G Bhat --- src/conf/domain_conf.h|2 ++

Re: [libvirt] [RFC v2 REPOST] arm64: KVM: KVM API extensions for SVE

On Tue, Feb 06, 2018 at 11:43:16AM +, Dave Martin wrote: > On Mon, Feb 05, 2018 at 05:13:08PM +0100, Christoffer Dall wrote: > > Hi Dave, > > > > On Fri, Jan 26, 2018 at 05:28:49PM +, Dave Martin wrote: > > > New feature KVM_ARM_VCPU_SVE: > > > > > > * enables exposure of SVE to the

Re: [libvirt] [PATCH v4] virt-aa-helper: Set the supported features

On Tue, Feb 06, 2018 at 08:08:14 -0500, Shivaprasad G Bhat wrote: > The virt-aa-helper fails to parse the xmls with the memory/cpu > hotplug features or user assigned aliases. Set the features in > xmlopt->config for the parsing to succeed. > > Signed-off-by: Shivaprasad G Bhat

Re: [libvirt] [PATCH v4] virt-aa-helper: Set the supported features

Actually Christian On 02/06/2018 07:12 PM, Peter Krempa wrote: On Tue, Feb 06, 2018 at 08:08:14 -0500, Shivaprasad G Bhat wrote: The virt-aa-helper fails to parse the xmls with the memory/cpu hotplug features or user assigned aliases. Set the features in xmlopt->config for the parsing to

Re: [libvirt] [PATCH v4] virt-aa-helper: Set the supported features

On Tue, Feb 6, 2018 at 2:42 PM, Peter Krempa wrote: > On Tue, Feb 06, 2018 at 08:08:14 -0500, Shivaprasad G Bhat wrote: >> The virt-aa-helper fails to parse the xmls with the memory/cpu >> hotplug features or user assigned aliases. Set the features in >> xmlopt->config for the

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

On Tue, 6 Feb 2018 11:29:46 +0100 Viktor Mihajlovski wrote: > On 01.02.2018 21:26, Eduardo Habkost wrote: > > On Thu, Feb 01, 2018 at 09:15:15PM +0100, Radim Krčmář wrote: > >> 2018-02-01 12:54-0500, Luiz Capitulino: > >>> > >>> Libvirt needs to know when a vCPU

[libvirt] [PATCH] qemu: Initialize @priv in qemuDomainCoreDumpWithFormat

Fix for a CI build failure Signed-off-by: John Ferlan --- Pushed under build breaker rule. src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index dda8b4cbf..bff49e7be 100644 ---

Re: [libvirt] [PATCH v4] virt-aa-helper: Set the supported features

On Tue, Feb 06, 2018 at 14:48:23 +0100, Christian Ehrhardt wrote: > On Tue, Feb 6, 2018 at 2:42 PM, Peter Krempa wrote: > > On Tue, Feb 06, 2018 at 08:08:14 -0500, Shivaprasad G Bhat wrote: > >> The virt-aa-helper fails to parse the xmls with the memory/cpu > >> hotplug