On Tue, Jul 10, 2018 at 01:45:33PM +0200, Peter Krempa wrote:
> On Tue, Jul 10, 2018 at 13:37:34 +0200, Simon Kobyda wrote:
> > XML shmem name will not include characters '/', '.' or '..', as shmem name
> > is used in a path
> > https://bugzilla.redhat.com/show_bug.cgi?id=1192400
> > ---
> >
On Wed, 2018-06-13 at 15:01 +0200, Andrea Bolognani wrote:
> We can reasonably expect the next major release of CentOS
> to be somewhat close to current Fedora releases in terms of
> packaging, and to ditch the soon-to-be-unsupported Python 2
> in favor of Python 3.
>
> Rewrite some of the
On Sat, Jun 30, 2018 at 02:30:10PM +0530, Sukrit Bhatnagar wrote:
> Alias virString to (char *) so that the new cleanup macros
> can be used for a list of strings (char **).
>
> Signed-off-by: Sukrit Bhatnagar
> ---
> src/util/virstring.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
On Sat, Jun 30, 2018 at 02:30:14PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOFREE macro for declaring scalar variables, majority
> of the VIR_FREE calls can be dropped, which in turn leads to
> getting rid of most of our cleanup sections.
On Sat, Jun 30, 2018 at 02:30:13PM +0530, Sukrit Bhatnagar wrote:
> The include directive for viralloc.h is added in vircommand.h
> in a previous patch.
How about:
"viralloc.h is pulled in by vircommand.h"
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Sat, Jun 30, 2018 at 02:30:15PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of
On Sat, Jun 30, 2018 at 02:30:19PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of
On Sat, Jun 30, 2018 at 02:30:24PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOFREE macro for declaring scalar variables, majority
> of the VIR_FREE calls can be dropped, which in turn leads to
> getting rid of most of our cleanup sections.
On Sat, Jun 30, 2018 at 02:30:23PM +0530, Sukrit Bhatnagar wrote:
> The include directive for viralloc.h is added in virauthconfig.h
> in a previous patch.
Same as patch 9.
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Sat, Jun 30, 2018 at 02:30:30PM +0530, Sukrit Bhatnagar wrote:
> Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
> src/util/viralloc.h, define a new wrapper around an existing
> cleanup function which will be called when a variable declared
> with VIR_AUTOPTR macro goes out of scope.
>
>
On Sat, Jun 30, 2018 at 02:30:31PM +0530, Sukrit Bhatnagar wrote:
> The include directive for viralloc.h is added in virbitmap.h
> in a previous patch.
Same as patch 9.
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On 07/09/2018 06:24 PM, Erik Skultety wrote:
> Since 2.10 QEMU supports a new display type egl-headless which uses the
> drm nodes for OpenGL rendering copying back the rendered bits back to
> QEMU into a dma-buf which can be accessed by standard "display" apps
> like VNC or SPICE. Although this
On 07/09/2018 06:24 PM, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> docs/news.xml | 10 ++
> 1 file changed, 10 insertions(+)
ACK
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 07/09/2018 06:24 PM, Erik Skultety wrote:
> QEMU 2.12 introduced a new type of display for mediated devices using
> vfio-pci backend which allows a mediated device to be used as a VGA
> compatible device as an alternative to an emulated video device. QEMU
> exposes this feature via a vfio
On Wed, Jul 04, 2018 at 01:21:44PM +0200, Boris Fiuczynski wrote:
Add support and tests for vhost-vsock-ccw.
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_command.c | 15 +++--
src/qemu/qemu_domain_address.c| 7 +++-
.../vhost-vsock-ccw-auto.args
On 07/09/2018 06:24 PM, Erik Skultety wrote:
> Since QEMU 2.12, QEMU understands a new vfio-pci device option 'display'
> which can be used to turn on display capabilities on vgpu-enabled
> mediated devices, IOW emulated GPU devices like QXL will no longer be
> needed with vgpu-enable mdevs.
>
On 07/09/2018 06:24 PM, Erik Skultety wrote:
> Since QEMU 2.10, it's possible to use a new type of display -
> egl-headless which uses drm nodes to provide OpenGL support. This patch
> adds a capability for that. However, since QEMU doesn't provide a QMP
> command to probe it, this is only a
On 07/09/2018 06:24 PM, Erik Skultety wrote:
> A simple helper which will loop through all the graphics elements and
> checks whether at least one of them enables OpenGL support, either by
> containing or being of type 'egl-headless'.
>
> Signed-off-by: Erik Skultety
> ---
>
XML shmem name will not include characters '/', '.' or '..', as shmem name
is used in a path
https://bugzilla.redhat.com/show_bug.cgi?id=1192400
---
src/conf/domain_conf.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
On Tue, Jul 10, 2018 at 13:37:34 +0200, Simon Kobyda wrote:
> XML shmem name will not include characters '/', '.' or '..', as shmem name
> is used in a path
> https://bugzilla.redhat.com/show_bug.cgi?id=1192400
> ---
> src/conf/domain_conf.c | 13 +
> 1 file changed, 13 insertions(+)
On Sat, Jun 30, 2018 at 02:30:11PM +0530, Sukrit Bhatnagar wrote:
> Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
> src/util/viralloc.h, define a new wrapper around an existing
> cleanup function which will be called when a variable declared
> with VIR_AUTOPTR macro goes out of scope.
>
>
On Sat, Jun 30, 2018 at 02:30:12PM +0530, Sukrit Bhatnagar wrote:
> Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
> src/util/viralloc.h, define a new wrapper around an existing
> cleanup function which will be called when a variable declared
> with VIR_AUTOPTR macro goes out of scope.
>
>
On Sat, Jun 30, 2018 at 02:30:18PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOFREE macro for declaring scalar variables, majority
> of the VIR_FREE calls can be dropped, which in turn leads to
> getting rid of most of our cleanup sections.
On Sat, Jun 30, 2018 at 02:30:20PM +0530, Sukrit Bhatnagar wrote:
> Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
> src/util/viralloc.h, define a new wrapper around an existing
> cleanup function which will be called when a variable declared
> with VIR_AUTOPTR macro goes out of scope.
>
>
On Sat, Jun 30, 2018 at 02:30:21PM +0530, Sukrit Bhatnagar wrote:
> The include directive for viralloc.h is added in virauthconfig.h
> in a previous patch.
Same suggestion as in patch 9.
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Sat, Jun 30, 2018 at 02:30:22PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOFREE macro for declaring scalar variables, majority
> of the VIR_FREE calls can be dropped, which in turn leads to
> getting rid of most of our cleanup sections.
On Sat, Jun 30, 2018 at 02:30:27PM +0530, Sukrit Bhatnagar wrote:
> The include directive for viralloc.h is added in virjson.h
> in a previous patch.
Same as patch 9.
Reviewed-by: Erik Skultety (patches 22-23)
--
libvir-list mailing list
libvir-list@redhat.com
On Sat, Jun 30, 2018 at 02:30:25PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of
On Thu, Jul 05, 2018 at 09:44:37 +0200, Michal Privoznik wrote:
> This function fetches status of all pr-managers. So far, qemu
> reports only a single attribute "connected" but that fits our
> needs.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_monitor.c | 25 +
>
On Thu, Jul 05, 2018 at 09:44:34 +0200, Michal Privoznik wrote:
> Rather than rejecting the user provided path and alias for the
> managed PR reservation we will ignore the provided path. The
> reason is that migration XML does contain path even for managed
> reservations.
>
> Signed-off-by:
On Thu, Jul 05, 2018 at 09:44:35 +0200, Michal Privoznik wrote:
> If there are managed reservations for a disk source, the path to
> the pr-helper socket is generated automatically by libvirt when
> needed and points somewhere under priv->libDir. Therefore it is
> very unlikely that the path will
On Sat, Jun 30, 2018 at 02:30:07PM +0530, Sukrit Bhatnagar wrote:
> Add rule to ensure that there is exactly one blank space between
> the type name and the asterisk when passed as the argument to the
> VIR_AUTOFREE macro.
>
> Signed-off-by: Sukrit Bhatnagar
> ---
We would have to enforce this
On Mon, Jul 09, 2018 at 04:12:35PM +0200, Peter Krempa wrote:
QEMU recently added support for passing RBD credentials also for
-blockdev/blockdev-add.
First two patches remove the need for a separate stash for the QMP
schema data, patch 3 adds new capabilities and finally the last patch
adds
On Mon, Jul 09, 2018 at 05:56:20PM +0200, Peter Krempa wrote:
This series requires the qemu 3.0.0 capabilities that I've sent with
https://www.redhat.com/archives/libvir-list/2018-July/msg00454.html
Peter Krempa (4):
tests: qemuxml2argv: Unify all tests for disk error policy
tests:
On Thu, Jul 05, 2018 at 09:44:38 +0200, Michal Privoznik wrote:
> If qemu-pr-helper process died while libvirtd was not running no
> event is emitted. Therefore, when reconnecting to the monitor we
> must check the qemu-pr-helper process status and act accordingly.
>
> Signed-off-by: Michal
On Thu, Jul 05, 2018 at 09:44:36 +0200, Michal Privoznik wrote:
> This event is emitted on the monitor if one of pr-managers lost
> connection to its pr-helper process. What libvirt needs to do is
> restart the pr-helper process iff it corresponds to managed
> pr-manager.
>
> Signed-off-by:
On Thu, Jul 05, 2018 at 09:44:33 +0200, Michal Privoznik wrote:
> Users have possibility to disable qemu namespace feature (e.g.
> because they are running on *BSD which lacks Linux NS support).
> If that's the case we should not try to move qemu-pr-helper into
> the same namespace as qemu is in.
On Sat, Jun 30, 2018 at 02:30:06PM +0530, Sukrit Bhatnagar wrote:
> A variable, which is never assigned a value in the function, might get
> passed into the cleanup function which may or may not raise any errors.
>
> To maintain the correct usage, the variable must be initialized, either
> with a
On Sat, Jun 30, 2018 at 02:30:08PM +0530, Sukrit Bhatnagar wrote:
> Add rule to ensure that each variable declaration made using
> a cleanup macro is in its own separate line.
>
> Sometimes a variable might be initialized from a value returned
> by a macro or a function, which may take on more
On Sat, Jun 30, 2018 at 02:30:09PM +0530, Sukrit Bhatnagar wrote:
> Add rule to ensure that there is no semicolon at the end of
> the line where a VIR_DEFINE_* cleanup macro is invoked.
>
> Signed-off-by: Sukrit Bhatnagar
> ---
NACK, the compiler will fail in such case, so the syntax-rule
Hi. Thanks for dbus based interface to libvirt. Now i'm able to
automatic generate bindings for go
https://godoc.org/sdstack.com/sdstack/go-libvirt
Code generator is ugly (gen.go and template.tpl) but package already
able to do basic operations.
Thanks again for you work.
--
Vasiliy Tolstov,
On 07/10/2018 09:15 AM, Shichangkuo wrote:
> When re-defining an active storage pool, the configfile has not changed. This
> issue was introduced by bfcd8fc9,
> storage: Use virStoragePoolObjGetDef accessor for driver. So we prefer using
> newDef to save configfile.
>
> Signed-off-by: Changkuo
Hello Michel,
I agree with you that we could integrate these two APIs into one. If so, I
think we should change the API name virFileIsCDROM to **virFileCheckCDROM**
or **virFileCdromState**. virFileIsCDROM is confusing and doesn't indicate
the function of checking state.
On Tue, Jul 10, 2018 at
On Tue, Jul 10, 2018 at 16:24:55 +0300, Vasiliy Tolstov wrote:
> Hi. Thanks for dbus based interface to libvirt. Now i'm able to
> automatic generate bindings for go
> https://godoc.org/sdstack.com/sdstack/go-libvirt
> Code generator is ugly (gen.go and template.tpl) but package already
> able to
Sorry, it should be virFileCdromStatus not virFileCdromState :)
On Tue, Jul 10, 2018 at 9:28 PM, Han Han wrote:
> Hello Michel,
> I agree with you that we could integrate these two APIs into one. If so, I
> think we should change the API name virFileIsCDROM to **virFileCheckCDROM**
> or
On Thu, Jul 05, 2018 at 01:44:40PM -0400, Anya Harter wrote:
> so that gchar *nodeDevPath; line appears in alphabetical order with the
> rest of the lines
>
> Signed-off-by: Anya Harter
> ---
> src/connect.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks pushed now.
Pavel
On Mon, Jul 09, 2018 at 04:22:57PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> tests/test_connect.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, pushed now.
Pavel
signature.asc
Description: PGP signature
--
libvir-list mailing list
Add new functions to generate zPCI command string and append it to
QEMU command line. And the related tests are added.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
Reviewed-by: Bjoern Walk
---
src/qemu/qemu_command.c| 115
Let's introduce zPCI capability.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
Reviewed-by: Bjoern Walk
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
This patch adds new functions for reservation, assignment and release
to handle the uid/fid. If the uid/fid is defined in the domain XML,
they will be reserved directly in collecting phase. If any of them is
not defined, we will find out an available value for it from zPCI
address hashtable, and
This patch provides a caching mechanism for the device address
extensions uid and fid on S390. For efficient sparse address allocation,
we introduce two hash tables for uid/fid which hold the address set
information per domain. Also in order to improve performance of
searching available value, we
Update 'Device address' section to describe the 'uid' and 'fid'
attributes.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
---
docs/formatdomain.html.in | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
QEMU on s390 supports PCI multibus since forever. But zPCI, as extension
of PCI device on s390, is the significant capability. Only when zPCI
capability is existing, we consider QEMU supports PCI multibus properly.
So let enable PCI multibus only if zPCI is supported.
Signed-off-by: Yi Min Zhao
The pci-root depends on zpci capability. So autogenerate pci-root if
zpci exists.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
Reviewed-by: Bjoern Walk
---
src/qemu/qemu_domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git
This commit adds hotplug support for PCI devices on S390 guests.
There's no need to implement hot unplug for zPCI as QEMU implements
an unplug callback which will unplug both PCI and zPCI device in a
cascaded way.
Currently, the following PCI devices are supported:
virtio-blk-pci
This patch introduces new XML parser/formatter functions. Uid is
16-bit and non-zero. Fid is 32-bit. They are added as two new
attributes of PCI address, and parsed/formatted along with PCI
address parser/formatter. The related test is also added.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris
This patch introduces a new attribute PCI address extension flag
to deal with the extension PCI attributes such as 'uid' and 'fid'
on the S390 platform.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
---
src/conf/device_conf.h | 1 +
src/conf/domain_addr.h | 5 ++
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 773c95b0da..bcdf350e55 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,17
On Fri, Jul 06, 2018 at 05:36:41PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/Makefile.am | 1 +
> data/org.libvirt.Interface.xml | 7 +++
> src/Makefile.am| 2 +
> src/connect.c | 6 +++
> src/connect.h
On Fri, Jul 06, 2018 at 05:36:44PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Interface.xml | 4
> src/interface.c| 22 ++
> 2 files changed, 26 insertions(+)
>
> diff --git a/data/org.libvirt.Interface.xml
On Fri, Jul 06, 2018 at 05:36:45PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 6 ++
> src/connect.c| 38
> 2 files changed, 44 insertions(+)
[...]
> diff --git a/src/connect.c
Thank u for reviewing. I will give patch v2 later.
On Tue, Jul 10, 2018 at 2:38 PM, Michal Privoznik
wrote:
> On 07/03/2018 04:29 AM, Han Han wrote:
> > This private API helps check cdrom drive status via ioctl().
> >
> > Signed-off-by: Han Han
> > ---
> > src/libvirt_private.syms | 1 +
> >
When re-defining an active storage pool, the configfile has not changed. This
issue was introduced by bfcd8fc9,
storage: Use virStoragePoolObjGetDef accessor for driver. So we prefer using
newDef to save configfile.
Signed-off-by: Changkuo Shi
---
src/storage/storage_driver.c |6 --
1
Abstract
The PCI representation in QEMU has recently been extended for S390
allowing configuration of zPCI attributes like uid (user-defined
identifier) and fid (PCI function identifier).
The details can be found here:
https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg07262.html
Add zPCI definitions in preparation of extending the PCI address
with parameters uid (user-defined identifier) and fid (PCI function
identifier).
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
Reviewed-by: Bjoern Walk
Reviewed-by: Ján Tomko
---
On Fri, Jul 06, 2018 at 05:36:43PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Interface.xml | 5 +
> src/interface.c| 22 ++
> 2 files changed, 27 insertions(+)
>
> diff --git a/data/org.libvirt.Interface.xml
Collection of patches which make sense without the rest of the -blockdev
series.
Peter Krempa (9):
qemu: domain: Remove code assuming disk format probing
qemu: domain: Reject copy_on_read for read-only disks
tests: Remove disk from 'serial-unix-chardev' test
qemu: command: Rename and
After commit c95f50cb021ea9a297 we always set a disk format in the
post parse callback so the code that madates use of explicit format for
shareable disks no longer makes sense.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 20 ++--
1 file changed, 6 insertions(+), 14
Aggregate the code for the two separate formats used according to the
machine type and add some supporting code so that the function is
actually readable.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 58 -
1 file changed, 28
SD card hotplug should not be implemented until they can be used via
-blockdev.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 23f6d1daba..69f599f575 100644
---
qemuBulildFloppyCommandLineOptions built it's own version of the -drive
alias. Replace it by qemuAliasDiskDriveFromDisk.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_command.c
Change the semantics to exactly opposite and rename it to
qemuDiskBusNeedsDriveArg. This will be necessary as some devices can't
be used with -blockdev.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 23 +--
src/qemu/qemu_command.h | 1 +
2 files changed, 14
We are testing character devices so the disk is not necessary. Minimize
the configuration. This will prevent changes when switching to blockdev.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/serial-unix-chardev.args | 2 --
It builds the string for '-device' from a virDomainDiskDef.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 12 ++--
src/qemu/qemu_command.h | 10 +-
src/qemu/qemu_hotplug.c | 2 +-
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git
On Fri, Jul 06, 2018 at 05:36:50PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 6 ++
> src/connect.c| 29 +
> 2 files changed, 35 insertions(+)
[...]
> diff --git a/src/connect.c b/src/connect.c
The sectors read from the backing image need to be written to the top
level image. If a disk is marked read-only the image can't be written.
QEMU handled that by disabling copy_on_read and reporting a warning:
-drive file=/var/lib/libvirt/images/c,format=qcow2,if=none,
On Fri, Jul 06, 2018 at 05:36:51PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 6 ++
> src/connect.c| 29 +
> 2 files changed, 35 insertions(+)
>
> diff --git a/data/org.libvirt.Connect.xml
Further split qemuBuildDiskCommandLine to separate formatting of the
source part.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 37 ++---
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
On Mon, Jul 09, 2018 at 04:56:04PM -0400, Jason Baron wrote:
>
>
> On 07/05/2018 12:10 PM, Daniel P. Berrangé wrote:
> > On Thu, Jul 05, 2018 at 10:20:16AM -0400, Jason Baron wrote:
> >> Hi,
> >>
> >> Opening tap devices, such as macvtap, that are created in containers is
> >> problematic
On Mon, 2018-07-09 at 16:59 +0200, Michal Privoznik wrote:
> After my change to the original patch that resulted in commit
> 8ed874b39b3 it was brought to my attention that all three defines
> are the same: FICLONE = BTRFS_IOC_CLONE = XFS_IOC_CLONE.
I'd mention that this is documented in
On Fri, Jul 06, 2018 at 05:36:40PM -0400, Anya Harter wrote:
> https://libvirt.org/html/libvirt-libvirt-interface.html
>
> The following functions have been implemented:
>
> - virConnectListAllInterfaces (connect method)
> - virInterfaceChangeBegin (connect
On Mon, Jul 09, 2018 at 05:00:49PM -0400, Jason Baron wrote:
>
>
> On 07/08/2018 02:01 AM, Martin Kletzander wrote:
> > On Thu, Jul 05, 2018 at 06:24:20PM +0200, Roman Mohr wrote:
> >> On Thu, Jul 5, 2018 at 4:20 PM Jason Baron wrote:
> >>
> >>> Hi,
> >>>
> >>> Opening tap devices, such as
On Mon, Jul 09, 2018 at 17:56:20 +0200, Peter Krempa wrote:
> This series requires the qemu 3.0.0 capabilities that I've sent with
>
> https://www.redhat.com/archives/libvir-list/2018-July/msg00454.html
As the capability patch did not make it through the moderation queue you
can fetch this
On Mon, Jul 09, 2018 at 16:12:35 +0200, Peter Krempa wrote:
> QEMU recently added support for passing RBD credentials also for
> -blockdev/blockdev-add.
>
> First two patches remove the need for a separate stash for the QMP
> schema data, patch 3 adds new capabilities and finally the last patch
>
On Tue, Jul 10, 2018 at 10:44:42AM +0200, Peter Krempa wrote:
The sectors read from the backing image need to be written to the top
level image. If a disk is marked read-only the image can't be written.
QEMU handled that by disabling copy_on_read and reporting a warning:
-drive
On Tue, Jul 10, 2018 at 10:44:41AM +0200, Peter Krempa wrote:
After commit c95f50cb021ea9a297 we always set a disk format in the
post parse callback so the code that madates use of explicit format for
mandates
shareable disks no longer makes sense.
Signed-off-by: Peter Krempa
---
On Tue, Jul 10, 2018 at 10:44:43AM +0200, Peter Krempa wrote:
We are testing character devices so the disk is not necessary. Minimize
the configuration. This will prevent changes when switching to blockdev.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/serial-unix-chardev.args
On Tue, Jul 10, 2018 at 10:44:44AM +0200, Peter Krempa wrote:
Change the semantics to exactly opposite and rename it to
qemuDiskBusNeedsDriveArg. This will be necessary as some devices can't
be used with -blockdev.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 23
On Tue, Jul 10, 2018 at 10:44:45AM +0200, Peter Krempa wrote:
SD card hotplug should not be implemented until they can be used via
-blockdev.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 3 +++
1 file changed, 3 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
On Tue, Jul 10, 2018 at 10:44:46AM +0200, Peter Krempa wrote:
Further split qemuBuildDiskCommandLine to separate formatting of the
source part.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 37 ++---
1 file changed, 26 insertions(+), 11 deletions(-)
On Tue, Jul 10, 2018 at 10:44:47AM +0200, Peter Krempa wrote:
qemuBulildFloppyCommandLineOptions built it's own version of the -drive
*its
alias. Replace it by qemuAliasDiskDriveFromDisk.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 19 ++-
1 file changed, 14
On Tue, Jul 10, 2018 at 10:44:48AM +0200, Peter Krempa wrote:
Aggregate the code for the two separate formats used according to the
machine type and add some supporting code so that the function is
actually readable.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 58
On Tue, Jul 10, 2018 at 10:44:49AM +0200, Peter Krempa wrote:
It builds the string for '-device' from a virDomainDiskDef.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 12 ++--
src/qemu/qemu_command.h | 10 +-
src/qemu/qemu_hotplug.c | 2 +-
3 files changed, 12
On Tue, Jul 10, 2018 at 11:27:51 +0200, Ján Tomko wrote:
> On Tue, Jul 10, 2018 at 10:44:48AM +0200, Peter Krempa wrote:
> > Aggregate the code for the two separate formats used according to the
> > machine type and add some supporting code so that the function is
> > actually readable.
> >
> >
On 07/03/2018 04:29 AM, Han Han wrote:
> This private API helps check cdrom drive status via ioctl().
>
> Signed-off-by: Han Han
> ---
> src/libvirt_private.syms | 1 +
> src/util/virfile.c | 52
> src/util/virfile.h | 10
> 3 files
On Mon, Jul 02, 2018 at 04:47:00PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> I've CC'd all those who introduced the changes mentioned below,
> both to give them a chance to point out any mistake I might have
> made and to possibly annoy them into updating the
On 07/03/2018 04:29 AM, Han Han wrote:
> Implement virFileCdromStatus() in virStorageBackendVolOpen to show
> detailed errors or warnings of cdrom instead of general Input/output error.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1596096
> Signed-off-by: Han Han
> ---
>
On Mon, Jul 09, 2018 at 06:24:12PM +0200, Erik Skultety wrote:
> RFC here:
> https://www.redhat.com/archives/libvir-list/2018-May/msg02218.html
>
> Since v1 [1]:
> - remodeled egl-headless to be a standalone graphics element instead of a
> result of some automagic with graphic's element
> -
These are only needed for RHEL5 builds, which are no longer supported
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/CMCUBB4SWS3URHTRRS3OPFM4HF5CGKBW/
https://fedoraproject.org/wiki/RPMGroups
Signed-off-by: Cole Robinson
---
libvirt-python.spec.in | 5 -
Signed-off-by: Anya Harter
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index ca9e4e1..b2021d4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -44,3 +44,4 @@ vgcore.*
/src/org.libvirt.service
/tests/test_util
+**/.pytest_cache
--
2.17.1
--
1 - 100 of 143 matches
Mail list logo
