Re: [libvirt PATCH 5/9] spec: Introduce with_dmidecode

On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani wrote: > > To keep things maintainable, we want to have architecture handling > all in one spot instead of sprinkling %ifarch conditionals all over > the place. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 7 ++- > 1 file

Re: [libvirt PATCH 6/9] spec: Move _vpath_builddir definition

On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani wrote: > > It belongs before package-specific feature flags are defined. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libvirt.spec.in

Re: [PATCH v2 00/10] hyperv: implement new APIs & more

On Mon, Oct 5, 2020 at 12:20 PM Matt Coleman wrote: > > These patches fix a couple bugs, consolidate duplicate code, and > implement several APIs. > > Currently, some interactions with Hyper-V systems fail when the system > is not configured for the "en-US" locale. Additionally, some CPU names >

[libvirt PATCH 2/4] virsh: use g_new0 instead of vsh[CM]alloc

Signed-off-by: Ján Tomko --- tools/virsh-checkpoint.c | 5 +++-- tools/virsh-domain-monitor.c | 11 +-- tools/virsh-domain.c | 24 tools/virsh-host.c | 22 +++--- tools/virsh-interface.c | 8

[libvirt PATCH 0/4] virsh: use g_new0 (glib chronicles)

Ján Tomko (4): virsh: do not add bools into size calculations virsh: use g_new0 instead of vsh[CM]alloc virsh: delete vsh[CM]alloc virsh: network-port: remove pointless comment tools/virsh-checkpoint.c | 11 +++ tools/virsh-domain-monitor.c | 11 +--

[libvirt PATCH 3/4] virsh: delete vsh[CM]alloc

Signed-off-by: Ján Tomko --- tools/vsh.c | 18 -- tools/vsh.h | 6 -- 2 files changed, 24 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index 98066d17bf..ca92bcd78c 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -100,24 +100,6 @@ vshPrettyCapacity(unsigned long long

[libvirt PATCH 02/12] util: split out VIR_ALLOC calls

To make the following commits simpler. Signed-off-by: Ján Tomko --- src/util/vircommand.c | 6 -- src/util/virxml.c | 10 -- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 859d6b0ce5..8060cdfada 100644 ---

Re: [libvirt PATCH 3/9] spec: bash completion actually defaults to on

On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani wrote: > > Remove the red herring. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 4572044d2d..9e4c5d2b81 100644 >

Re: [libvirt PATCH 4/9] spec: Move with_numactl definition

On Mon, Oct 5, 2020 at 2:40 PM Andrea Bolognani wrote: > > Keep it close to similar ones. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 9e4c5d2b81..65df7dc79f

Re: [libvirt PATCH 2/9] spec: firewalld is always enabled

On Mon, Oct 5, 2020 at 2:40 PM Andrea Bolognani wrote: > > Knowing this, we can remove some code. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index

Re: [libvirt PATCH 1/9] spec: Simplify setting features off by default

On Mon, Oct 5, 2020 at 2:40 PM Andrea Bolognani wrote: > > The right-hand side of these expressions will always evaluate to > zero. Stop obfuscating this fact. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-)

Re: [libvirt PATCH 9/9] spec: Introduce arches_*

On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani wrote: > > With this commit, all architecture lists that we base feature > enablement decisions on are defined within a few lines of each > other, increasing maintainability. > > Additionally, generic architecture lists that appear in the >

Re: [PATCH v2 04/10] hyperv: replace generic WMI class list helpers with a macro

On Mon, Oct 5, 2020 at 12:21 PM Matt Coleman wrote: > > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 39 -- > src/hyperv/hyperv_wmi.c| 83 -- > src/hyperv/hyperv_wmi.h| 28 ++--- > 3 files changed, 36

Re: [PATCH v2 06/10] hyperv: implement connectGetMaxVcpus

On Mon, Oct 5, 2020 at 12:21 PM Matt Coleman wrote: > > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 34 ++ > 1 file changed, 34 insertions(+) > > diff --git a/src/hyperv/hyperv_driver.c

Re: [PATCH v2 05/10] hyperv: implement connectGetCapabilities

On Mon, Oct 5, 2020 at 12:21 PM Matt Coleman wrote: > > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 90 + > src/hyperv/hyperv_private.h | 2 + > 2 files changed, 92 insertions(+) > > diff --git

[PATCH] mailmap: consolidate my email addresses

Signed-off-by: Matt Coleman --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 2b080568bc..9dfb7a832b 100644 --- a/.mailmap +++ b/.mailmap @@ -47,6 +47,7 @@ + # Name consolidation: # Preferred author spelling -- 2.27.0

Re: [PATCH v2 07/10] hyperv: fix Win32_OperatingSystem WMI queries

On Mon, Oct 5, 2020 at 12:21 PM Matt Coleman wrote: > > CurrentTimeZone's type is a signed integer, not unsigned. > > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_wmi_generator.input | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v2 08/10] hyperv: implement connectGetVersion

On Mon, Oct 5, 2020 at 12:22 PM Matt Coleman wrote: > > Hyper-V version numbers are not compatible with the encoding in > virParseVersionString(): > https://gitlab.com/libvirt/libvirt/-/blob/master/src/util/virutil.c#L246 > > For example, the Windows Server 2016 Hyper-V version is 10.0.14393: its

Re: [PATCH v2 10/10] news: document new Hyper-V features and bug fixes

On Mon, Oct 5, 2020 at 12:22 PM Matt Coleman wrote: > > Signed-off-by: Matt Coleman > --- > NEWS.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index b2ed661c8e..e708f06e9e 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -19,10 +19,20 @@ v6.9.0

Re: [PATCH v2 09/10] hyperv: implement domainGetAutostart

On Mon, Oct 5, 2020 at 12:21 PM Matt Coleman wrote: > > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 40 ++ > 1 file changed, 40 insertions(+) > > diff --git a/src/hyperv/hyperv_driver.c

Re: [PATCH] mailmap: consolidate my email addresses

On Mon, Oct 5, 2020 at 3:15 PM Matt Coleman wrote: > > Signed-off-by: Matt Coleman > --- > .mailmap | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.mailmap b/.mailmap > index 2b080568bc..9dfb7a832b 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -47,6 +47,7 @@ > > > > + > > #

Re: [libvirt PATCH 8/9] spec: Refactor qemu_kvm_arches definition

On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani wrote: > > There's no need to set a default for it if we're going to override > it immediately afterwards anyway, and setting with_qemu_tcg at the > same time only makes things more confusing. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt PATCH 7/9] spec: Drop s390 architecture from conditionals

On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani wrote: > > Neither Fedora nor RHEL build packages on this architecture. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in >

Re: [PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

On Mon, Oct 5, 2020 at 12:21 PM Matt Coleman wrote: > > There are two specific WQL queries we're using to get either a list of > virtual machines or the hypervisor host itself from Msvm_ComputerSystem. > Those queries rely on filtering results based on the "Description" > field. Since the

Re: [PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

On Mon, Oct 5, 2020 at 9:13 PM Matt Coleman wrote: > > > On Oct 5, 2020, at 8:54 PM, Neal Gompa wrote: > > > > Should we require a bump to openwsman 2.6 for this? > > That won’t make any difference: openwsman 2.6+ supports specifying the > locale, but Windows ignores it. So, this patch changes

Re: [PATCH v2 03/10] hyperv: break out common lookups into separate functions

On Mon, Oct 5, 2020 at 12:21 PM Matt Coleman wrote: > > This eliminates some duplicate code and simplifies the driver functions. > > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 489 - > 1 file changed, 259

Re: [PATCH v2 02/10] hyperv: fix nodeGetInfo failures caused by long CPU names

On Mon, Oct 5, 2020 at 12:21 PM Matt Coleman wrote: > > Some CPU model names were too long for _virNodeInfo.model. > For example: Intel Xeon CPU E5-2620 v2 @ 2.10GHz > This commit removes the clock frequency suffix. > > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 4 >

Re: [PATCH] rpm: Enable Xen support on AArch64

On Mon, Oct 5, 2020 at 6:18 AM Andrea Bolognani wrote: > > On Sun, 2020-10-04 at 22:16 -0400, Neal Gompa wrote: > > +++ b/libvirt.spec.in > > +# Xen is available only on i386 x86_64 ia64 aarch64 > > +%ifnarch %{ix86} x86_64 ia64 aarch64 > > %define with_libxl 0 > > %endif > > The code

[libvirt PATCH 01/12] util: resctrl fix spacing in comment

Signed-off-by: Ján Tomko --- src/util/virresctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index aea3fe8687..2535627d63 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -1879,7 +1879,7 @@

[libvirt PATCH 05/12] util: sysinfo: use g_new0

Signed-off-by: Ján Tomko --- src/util/virsysinfo.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 0e9b281caf..217f842a37 100644 --- a/src/util/virsysinfo.c +++ b/src/util/virsysinfo.c @@

[libvirt PATCH 03/12] util: resctrl: use g_new0

Signed-off-by: Ján Tomko --- src/util/virresctrl.c | 77 ++- 1 file changed, 25 insertions(+), 52 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 2535627d63..400c8e9981 100644 --- a/src/util/virresctrl.c +++

[libvirt PATCH 07/12] util: netdev: use g_new0

Signed-off-by: Ján Tomko --- src/util/virnetdev.c | 25 + src/util/virnetdevbandwidth.c| 22 -- src/util/virnetdevip.c | 3 +-- src/util/virnetdevmacvlan.c | 6 ++ src/util/virnetdevtap.c | 3 +--

[libvirt PATCH 08/12] util: systemd: use g_new0

Signed-off-by: Ján Tomko --- src/util/virsystemd.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 8456085476..8373ee6509 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -364,8 +364,7

[libvirt PATCH 04/12] util: storagefile: use g_new0

Signed-off-by: Ján Tomko --- src/util/virstoragefile.c | 82 --- 1 file changed, 25 insertions(+), 57 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 459a7be5e4..82388ae544 100644 --- a/src/util/virstoragefile.c +++

[libvirt PATCH 00/12] util: use g_new0 (glib chronicles)

Ján Tomko (12): util: resctrl fix spacing in comment util: split out VIR_ALLOC calls util: resctrl: use g_new0 util: storagefile: use g_new0 util: sysinfo: use g_new0 util: command: use g_new0 util: netdev: use g_new0 util: systemd: use g_new0 util: firewall: use g_new0 util:

[libvirt PATCH 10/12] util: conf: use g_new0

Signed-off-by: Ján Tomko --- src/util/virconf.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/src/util/virconf.c b/src/util/virconf.c index 8575dd8849..e983a769ee 100644 --- a/src/util/virconf.c +++ b/src/util/virconf.c @@ -163,8 +163,7 @@

[libvirt PATCH 09/12] util: firewall: use g_new0

Signed-off-by: Ján Tomko --- src/util/virfirewall.c | 9 +++-- src/util/virfirewalld.c | 6 ++ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index 22e717bce4..f6a8beec95 100644 --- a/src/util/virfirewall.c +++

[libvirt PATCH 11/12] util: a-n: use g_new0

Signed-off-by: Ján Tomko --- src/util/iohelper.c | 3 +-- src/util/virarptable.c | 3 +-- src/util/virauthconfig.c | 6 ++ src/util/virbitmap.c | 4 +--- src/util/vircgroup.c | 7 ++- src/util/vircrypto.c | 6 ++ src/util/virdnsmasq.c| 12

[libvirt PATCH 12/12] util: o-z: use g_new0

Signed-off-by: Ján Tomko --- src/util/virpci.c | 12 src/util/virperf.c | 3 +-- src/util/virpolkit.c| 3 +-- src/util/virportallocator.c | 3 +-- src/util/virprocess.c | 3 +-- src/util/virrotatingfile.c | 15

[libvirt PATCH 06/12] util: command: use g_new0

Signed-off-by: Ján Tomko --- src/util/vircommand.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 8060cdfada..6350e77523 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@

Re: [PATCH] rpm: Enable Xen support on AArch64

On Mon, 2020-10-05 at 12:33 -0400, Neal Gompa wrote: > On Mon, Oct 5, 2020 at 6:18 AM Andrea Bolognani wrote: > > On Sun, 2020-10-04 at 22:16 -0400, Neal Gompa wrote: > > > +++ b/libvirt.spec.in > > > +# Xen is available only on i386 x86_64 ia64 aarch64 > > > +%ifnarch %{ix86} x86_64 ia64 aarch64

[PATCH v2 02/10] hyperv: fix nodeGetInfo failures caused by long CPU names

Some CPU model names were too long for _virNodeInfo.model. For example: Intel Xeon CPU E5-2620 v2 @ 2.10GHz This commit removes the clock frequency suffix. Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v2 00/10] hyperv: implement new APIs & more

These patches fix a couple bugs, consolidate duplicate code, and implement several APIs. Currently, some interactions with Hyper-V systems fail when the system is not configured for the "en-US" locale. Additionally, some CPU names also contain the clock frequency, making it too long for

[PATCH v2 04/10] hyperv: replace generic WMI class list helpers with a macro

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 39 -- src/hyperv/hyperv_wmi.c| 83 -- src/hyperv/hyperv_wmi.h| 28 ++--- 3 files changed, 36 insertions(+), 114 deletions(-) diff --git a/src/hyperv/hyperv_driver.c

[PATCH v2 06/10] hyperv: implement connectGetMaxVcpus

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 93e08c54c0..bbe892fd62 100644 ---

[PATCH v2 03/10] hyperv: break out common lookups into separate functions

This eliminates some duplicate code and simplifies the driver functions. Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 489 - 1 file changed, 259 insertions(+), 230 deletions(-) diff --git

[PATCH v2 05/10] hyperv: implement connectGetCapabilities

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 90 + src/hyperv/hyperv_private.h | 2 + 2 files changed, 92 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index

[PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

There are two specific WQL queries we're using to get either a list of virtual machines or the hypervisor host itself from Msvm_ComputerSystem. Those queries rely on filtering results based on the "Description" field. Since the "Description" field is locale sensitive, the queries will fail if the

[PATCH v2 07/10] hyperv: fix Win32_OperatingSystem WMI queries

CurrentTimeZone's type is a signed integer, not unsigned. Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi_generator.input | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hyperv/hyperv_wmi_generator.input b/src/hyperv/hyperv_wmi_generator.input index

[PATCH v2 10/10] news: document new Hyper-V features and bug fixes

Signed-off-by: Matt Coleman --- NEWS.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index b2ed661c8e..e708f06e9e 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -19,10 +19,20 @@ v6.9.0 (unreleased) local file-backed disks to configure a disk which discards

[PATCH v2 09/10] hyperv: implement domainGetAutostart

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 528c826e16..dcde469442 100644 ---

[PATCH v2 08/10] hyperv: implement connectGetVersion

Hyper-V version numbers are not compatible with the encoding in virParseVersionString(): https://gitlab.com/libvirt/libvirt/-/blob/master/src/util/virutil.c#L246 For example, the Windows Server 2016 Hyper-V version is 10.0.14393: its micro is over 14 times larger than the encoding allows. This

Re: [libvirt PATCH 9/9] spec: Introduce arches_*

On Mon, 2020-10-05 at 20:40 +0200, Andrea Bolognani wrote: > +++ b/libvirt.spec.in > @@ -17,10 +17,22 @@ > %define _vpath_builddir %{_target_platform} > %endif > > +%define arches_64bitx86_64 %{power64} aarch64 s390x riscv64 > +%define arches_x86 %{ix86} x86_64 > +

Re: [PATCH V4] Modify virCPUarmCompare to perform compare actions

On 10/2/20 3:45 PM, Daniel Henrique Barboza wrote: On 9/24/20 11:12 AM, Zhenyu Zheng wrote: Modify virCPUarmCompare in cpu_arm.c to perform compare action. This patch only adds host to host CPU compare, the rest cases remains the same. This is useful for source and destination host compare

Re: [libvirt PATCH] rpm: include aarch64 & riscv64 in systemtap 64-bit arch tapset rename

On Mon, Oct 5, 2020 at 8:55 AM Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > --- > libvirt.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 682d43c290..d13aae5cf5 100644 > --- a/libvirt.spec.in > +++

[libvirt PATCH 4/4] virsh: network-port: remove pointless comment

We do not have a legacy API for listing network ports so there's nothing to fall back on. Signed-off-by: Ján Tomko --- tools/virsh-network.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index c5347660de..745afc537d 100644 ---

[libvirt PATCH 1/4] virsh: do not add bools into size calculations

Switch the allocation in virshSnapshotListCollect and its cargo-culted Checkpoint counterpart to two separate g_new0 calls and move the boolean expression to the if condition that chooses between them. Signed-off-by: Ján Tomko --- tools/virsh-checkpoint.c | 6 -- tools/virsh-snapshot.c |

[PATCHv3 4/5] qemu: add docs for 'fmode' and 'dmode' options

Adds documentation for QEMU 9pfs 'fmode' and 'dmode' options. Signed-off-by: Brian Turek --- docs/formatdomain.rst | 12 1 file changed, 12 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index cc4f91d4ea..085f29ef8f 100644 --- a/docs/formatdomain.rst +++

[PATCHv3 1/5] qemu: capabilities: add QEMU_CAPS_FSDEV_CREATEMODE

The QEMU 9pfs 'fmode' and 'dmode' options have existed since QEMU 2.10. Probe QEMU's command line set to check whether these options are available, and if yes, enable this new QEMU_CAPS_FSDEV_CREATEMODE capability on libvirt side. Signed-off-by: Brian Turek --- src/qemu/qemu_capabilities.c

Re: restrictions for virtiofs (related to commit: 88957116c9 for libvirt 6.9.0)

On Mon, Oct 05, 2020 at 10:50:08AM +0200, Michal Privoznik wrote: > On 10/3/20 1:15 AM, Masayoshi Mizuma wrote: > > On Fri, Oct 02, 2020 at 11:31:32AM -0400, Masayoshi Mizuma wrote: > > > Hello Jan, and Michal, > > > > > > commit: 88957116c9 ("qemu: Use memory-backend-* for regular guest > > >

[PATCHv3 3/5] qemu: add schema 'fmode' and 'dmode' options

Adds schema to validate the 'fmode' and 'dmode' attributes on a 'fileystem' node. Checks to ensure that the values are 1-4 octal digits long. Signed-off-by: Brian Turek --- docs/schemas/domaincommon.rng | 16 1 file changed, 16 insertions(+) diff --git

[PATCHv3 2/5] qemu: add support for 'fmode' and 'dmode' options

Expose QEMU's 9pfs 'fmode' and 'dmode' options via attributes on the 'filesystem' node in the domain XML. These options control the creation mode of files and directories, respectively, when using accessmode=mapped. QEMU defaults to creating files with mode 0600 and directories with mode 0700.

[libvirt PATCHv3 0/4] Add support for QEMU's fmode and dmode

Apologies for the second submission here. I got a kickback on two of the emails saying it was "rejected due to security policies." This third version of the patches fixes a bug where QEMU interpreted the command line value passed to it as base-10 rather than base-8. This new version ensures

[libvirt PATCHv3 3/4] qemu: add schema 'fmode' and 'dmode' options

Adds schema to validate the 'fmode' and 'dmode' attributes on a 'fileystem' node. Checks to ensure that the values are 1-4 octal digits long. Signed-off-by: Brian Turek --- docs/schemas/domaincommon.rng | 16 1 file changed, 16 insertions(+) diff --git

[libvirt PATCHv3 2/4] qemu: add support for 'fmode' and 'dmode' options

Expose QEMU's 9pfs 'fmode' and 'dmode' options via attributes on the 'filesystem' node in the domain XML. These options control the creation mode of files and directories, respectively, when using accessmode=mapped. QEMU defaults to creating files with mode 0600 and directories with mode 0700.

[libvirt PATCH 9/9] spec: Introduce arches_*

With this commit, all architecture lists that we base feature enablement decisions on are defined within a few lines of each other, increasing maintainability. Additionally, generic architecture lists that appear in the conditions for multiple features are defined, so that repetition is reduced.

[libvirt PATCH 6/9] spec: Move _vpath_builddir definition

It belongs before package-specific feature flags are defined. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 2401404008..d8f689e651 100644 --- a/libvirt.spec.in +++

[libvirt PATCHv3 1/4] qemu: capabilities: add QEMU_CAPS_FSDEV_CREATEMODE

The QEMU 9pfs 'fmode' and 'dmode' options have existed since QEMU 2.10. Probe QEMU's command line set to check whether these options are available, and if yes, enable this new QEMU_CAPS_FSDEV_CREATEMODE capability on libvirt side. Signed-off-by: Brian Turek --- src/qemu/qemu_capabilities.c

[libvirt PATCHv3 4/4] qemu: add docs for 'fmode' and 'dmode' options

Adds documentation for QEMU 9pfs 'fmode' and 'dmode' options. Signed-off-by: Brian Turek --- docs/formatdomain.rst | 12 1 file changed, 12 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index cc4f91d4ea..085f29ef8f 100644 --- a/docs/formatdomain.rst +++

[libvirt PATCH 4/9] spec: Move with_numactl definition

Keep it close to similar ones. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 9e4c5d2b81..65df7dc79f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -68,8 +68,6 @@

[libvirt PATCH 0/9] spec: Improve feature and architecture handling

Make things more maintainable. Andrea Bolognani (9): spec: Simplify setting features off by default spec: firewalld is always enabled spec: bash completion actually defaults to on spec: Move with_numactl definition spec: Introduce with_dmidecode spec: Move _vpath_builddir definition

[libvirt PATCH 1/9] spec: Simplify setting features off by default

The right-hand side of these expressions will always evaluate to zero. Stop obfuscating this fact. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index

[libvirt PATCH 2/9] spec: firewalld is always enabled

Knowing this, we can remove some code. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 815ab246e9..4572044d2d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -88,7

[libvirt PATCH 5/9] spec: Introduce with_dmidecode

To keep things maintainable, we want to have architecture handling all in one spot instead of sprinkling %ifarch conditionals all over the place. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in

[libvirt PATCH 7/9] spec: Drop s390 architecture from conditionals

Neither Fedora nor RHEL build packages on this architecture. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index d8f689e651..e036307d30 100644 --- a/libvirt.spec.in +++

[libvirt PATCH 3/9] spec: bash completion actually defaults to on

Remove the red herring. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 4572044d2d..9e4c5d2b81 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -84,6 +84,9 @@ %define

[libvirt PATCH 8/9] spec: Refactor qemu_kvm_arches definition

There's no need to set a default for it if we're going to override it immediately afterwards anyway, and setting with_qemu_tcg at the same time only makes things more confusing. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 26 +- 1 file changed, 13

Re: [PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

> On Oct 5, 2020, at 8:54 PM, Neal Gompa wrote: > > Should we require a bump to openwsman 2.6 for this? That won’t make any difference: openwsman 2.6+ supports specifying the locale, but Windows ignores it. So, this patch changes the queries to not use localized strings. -- Matt

[libvirt][PATCH v1 1/1] introduce an attribute "migratable" to numatune memory element

Attribute ``migratable`` will be 'no' by default, and 'yes' indicates that it allows operating system or hypervisor migrating the memory pages between different memory nodes, that also means we will not rely on hypervisor to set the memory policy or memory affinity, we only

[libvirt][PATCH v1 0/1] introduce an attribute "migratable" to numatune memory element

RFC discussion record link: https://www.redhat.com/archives/libvir-list/2020-August/msg00960.html Luyao Zhong (1): introduce an attribute "migratable" to numatune memory element docs/formatdomain.rst | 8 +++- docs/schemas/domaincommon.rng | 5 +++

Re: [libvirt PATCH] news: move section about downscript to v6.4.0

On Sun, Oct 04, 2020 at 10:28:25PM +0200, Ján Tomko wrote: > The feature was merged in v6.3.0-175-g61ba6f09b1 > > Signed-off-by: Ján Tomko > Fixes: 4eda71a8d05d968e73ab9b0fdc8a90123c57d39e > --- > NEWS.rst | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Erik

Re: [libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion

On Wed, 2020-09-30 at 14:11 +0200, Peter Krempa wrote: > On Wed, Sep 30, 2020 at 13:54:58 +0200, Tim Wiederhake wrote: > > On Tue, 2020-09-29 at 11:22 +0200, Peter Krempa wrote: > > > On Mon, Sep 21, 2020 at 15:07:32 +0200, Tim Wiederhake wrote: > > > > Signed-off-by: Tim Wiederhake > > > > --- >

Re: [PATCH 1/1] Optional free-page-reporting can be enabled/disabled for memballon device of model 'virtio'.

On Fri, Oct 02, 2020 at 11:59:43 -0400, Nico Pache wrote: > xml: > > according to what you state in the cover-letter this is a 'virtio-balloon-pci' feature. We usually put stuff which depends on a specific model of the device into the subelement of the device element. > > > qemu: > qemu

Re: [libvirt PATCH 8/8] build: lower maximum frame size to 1792

On Mon, Oct 05, 2020 at 12:21:45AM +0200, Ján Tomko wrote: > This number is the closest multiple of 1 ^^^ Huh ? > above the largest frame value reported by clang > in the current codebase. > > Signed-off-by: Ján Tomko > --- > meson.build | 7

Re: [PATCH 03/15] virBitmapToString|virBitmapNewString: Clarify semantics of the 'string'

On a Monday in 2020, Peter Krempa wrote: On Fri, Oct 02, 2020 at 17:44:13 +0200, Ján Tomko wrote: On a Friday in 2020, Peter Krempa wrote: > On Fri, Oct 02, 2020 at 13:17:17 +0200, Ján Tomko wrote: > > On a Friday in 2020, Peter Krempa wrote: > > > Clarify which bit is considered most

[libvirt PATCH 8/9] qemu: firmware: use g_new0

Signed-off-by: Ján Tomko --- src/qemu/qemu_firmware.c | 34 -- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 480ce0b00d..eebe6fcf78 100644 --- a/src/qemu/qemu_firmware.c +++

[libvirt PATCH 9/9] qemu: use g_new0

Signed-off-by: Ján Tomko --- src/qemu/qemu_agent.c | 6 ++ src/qemu/qemu_block.c | 15 +-- src/qemu/qemu_cgroup.c | 6 ++ src/qemu/qemu_conf.c | 20 src/qemu/qemu_domain_address.c | 3 +-- src/qemu/qemu_hotplug.c

Re: [libvirt PATCH] vmware: use g_new0 instead of VIR_ALLOC (glib chronicles)

On Mon, Oct 05, 2020 at 12:23:25AM +0200, Ján Tomko wrote: > Signed-off-by: Ján Tomko > --- Reviewed-by: Erik Skultety

[libvirt PATCH 1/9] qemu: separate out VIR_ALLOC calls

Move them to separate conditions to reduce churn in following patches. Signed-off-by: Ján Tomko --- src/qemu/qemu_domain.c | 6 -- src/qemu/qemu_monitor_json.c | 6 -- src/qemu/qemu_process.c | 23 --- 3 files changed, 20 insertions(+), 15 deletions(-)

[libvirt PATCH 4/9] qemu: driver: use g_new0

Signed-off-by: Ján Tomko --- src/qemu/qemu_driver.c | 62 ++ 1 file changed, 21 insertions(+), 41 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 85b6a6a321..e622da56bd 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt PATCH 0/9] qemu: use g_new0 (glib chronicles)

With the exception of qemu_migrate_cookie and qemu_slirp which should be dealt with by Peter's series. Ján Tomko (9): qemu: separate out VIR_ALLOC calls qemu: capabilities: use g_new0 qemu: domain: use g_new0 qemu: driver: use g_new0 qemu: monitor: json: use g_new0 qemu: process: use

[libvirt PATCH 3/9] qemu: domain: use g_new0

Signed-off-by: Ján Tomko --- src/qemu/qemu_domain.c | 53 ++ 1 file changed, 17 insertions(+), 36 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 491fb0ed3d..15912317de 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt PATCH 2/9] qemu: capabilities: use g_new0

Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 48 1 file changed, 16 insertions(+), 32 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 5dcfcd574d..2e0e4492a4 100644 --- a/src/qemu/qemu_capabilities.c

[libvirt PATCH 7/9] qemu: command: use g_new0

Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 35 +-- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e9ba81d82f..476cf6972e 100644 --- a/src/qemu/qemu_command.c +++

[libvirt PATCH 6/9] qemu: process: use g_new0

Signed-off-by: Ján Tomko --- src/qemu/qemu_process.c | 56 + 1 file changed, 18 insertions(+), 38 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 93cbb37986..94b44f1c5c 100644 --- a/src/qemu/qemu_process.c +++

[libvirt PATCH 5/9] qemu: monitor: json: use g_new0

Signed-off-by: Ján Tomko --- src/qemu/qemu_monitor_json.c | 110 --- 1 file changed, 36 insertions(+), 74 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index c399100dbe..26ac499fc5 100644 --- a/src/qemu/qemu_monitor_json.c

Re: [PATCH 03/15] virBitmapToString|virBitmapNewString: Clarify semantics of the 'string'

On Fri, Oct 02, 2020 at 17:44:13 +0200, Ján Tomko wrote: > On a Friday in 2020, Peter Krempa wrote: > > On Fri, Oct 02, 2020 at 13:17:17 +0200, Ján Tomko wrote: > > > On a Friday in 2020, Peter Krempa wrote: > > > > Clarify which bit is considered most significant in the bitmap and > > > >

Re: [PATCH] rpm: Enable Xen support on AArch64

On Sun, 2020-10-04 at 22:16 -0400, Neal Gompa wrote: > +++ b/libvirt.spec.in > +# Xen is available only on i386 x86_64 ia64 aarch64 > +%ifnarch %{ix86} x86_64 ia64 aarch64 > %define with_libxl 0 > %endif The code change is okay, but duplicating the list of architectures in the comment is

Re: [libvirt PATCH 0/4] vz: use g_new0 (glib chronicles)

On Mon, Oct 05, 2020 at 12:23:55AM +0200, Ján Tomko wrote: > Ján Tomko (4): > vz: separate if conditions in vzEatCookie > vz: vzEatCookie: use distinct 'tmp' variables > vz: vzEatCookie: separate allocation > vz: use g_new0 instead of VIR_ALLOC > > src/vz/vz_driver.c | 49

Re: [PATCH] qemu: Taint cpu host-passthrough only after migration

On Sun, Oct 04, 2020 at 03:10:52PM -0400, Cole Robinson wrote: > From a discussion last year[1], Dan recommended libvirt drop the tain > flag for cpu host-passthrough, unless the VM has been migrated. > > This repurposes the existing host-cpu taint flag to do just that. > > [1]: >

  1   2   >