Re: [libvirt PATCH v2 0/8] meson: Improve handling of tests

2023-10-26 Thread Martin Kletzander
On Wed, Oct 25, 2023 at 07:06:53PM +0200, Andrea Bolognani wrote: Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1049326523 Changes from [v1] * fix test suite on macOS and ensure it is run as part of the pipeline (with the previous version it would just always fail); *

Entering freeze for libvirt-9.9.0

2023-10-26 Thread Jiri Denemark
I have just tagged v9.9.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to

Re: hdd kills vm

2023-10-26 Thread Martin Kletzander
On Wed, Oct 25, 2023 at 03:06:55PM +0200, daggs wrote: Sent: Tuesday, October 24, 2023 at 5:28 PM From: "Martin Kletzander" To: "daggs" Cc: libvir-list@redhat.com Subject: Re: hdd kills vm On Mon, Oct 23, 2023 at 04:59:08PM +0200, daggs wrote: >Greetings Martin, > >> Sent: Sunday, October 22,

[PATCH v2 2/3] qemu: hotplug: Setup host side of VDPA device for disk hotplug

2023-10-26 Thread Peter Krempa
The code which opens the VDPA device and prepares it for FD passing was not called in the hotplug code path, preventing hotplug of VDPA disks with: error: internal error: argument key 'path' must not have null value Use the new helper qemuProcessPrepareHostStorageDisk to setup the VDPA

[PATCH v2 0/3] qemu: Fix hotplug and blockcopy to VDPA disks

2023-10-26 Thread Peter Krempa
Content-type: text/plain v2: - also deal with blockcopy (requires more helpers) Peter Krempa (3): qemu: process: Extract host setup of disk device into helpers qemu: hotplug: Setup host side of VDPA device for disk hotplug qemu: Setup host side of VDPA device for block copy

[PATCH v2 1/3] qemu: process: Extract host setup of disk device into helpers

2023-10-26 Thread Peter Krempa
Currently the code sets up only VDPA backends but will be used later in hotplug code too. This patch also uses normal forward iteration in the loop in qemuProcessPrepareHostStorage as we don't need to remove disks from the disk list at that point. Signed-off-by: Peter Krempa ---

Re: [PATCH] docs: formatdomain: Clarify that the SLIC ACPI table config is available for all modes

2023-10-26 Thread Ján Tomko
On a Thursday in 2023, Peter Krempa wrote: Move the docs for the element under a common section as it's not specific for direct kernel boot. In fact the original use was for Windows activation. Fixes: 72f652da63255c7f1a9914625cce617dde9128d0 Signed-off-by: Peter Krempa ---

Re: [PATCH 0/2] qemu: Fix hotplug of VDPA disks

2023-10-26 Thread Peter Krempa
On Thu, Oct 26, 2023 at 15:15:15 +0200, Peter Krempa wrote: > Peter Krempa (2): > qemu: process: Extract host setup of disk device into a helper > qemu: hotplug: Setup host side of VDPA device for disk hotplug > > src/qemu/qemu_hotplug.c | 3 +++ > src/qemu/qemu_process.c | 42

[PATCH v2 3/3] qemu: Setup host side of VDPA device for block copy

2023-10-26 Thread Peter Krempa
Setup the VDPA bits of the appropriate part of the image chain for block copy. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 4 src/qemu/qemu_driver.c | 12 2 files changed, 16 insertions(+) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index

RFC: Switch to a date-based versioning scheme

2023-10-26 Thread Andrea Bolognani
Since we're just a few months away from the 10.0.0 release, I thought it would be a good time to bring up this idea. Can we move to date-based version numbers? I suggest having libvirt 24.01.0 instead of 10.0.0 24.03.010.1.0 24.04.010.2.0

[PATCH] docs: formatdomain: Clarify that the SLIC ACPI table config is available for all modes

2023-10-26 Thread Peter Krempa
Move the docs for the element under a common section as it's not specific for direct kernel boot. In fact the original use was for Windows activation. Fixes: 72f652da63255c7f1a9914625cce617dde9128d0 Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 29 + 1

[PATCH 0/2] qemu: Fix hotplug of VDPA disks

2023-10-26 Thread Peter Krempa
Peter Krempa (2): qemu: process: Extract host setup of disk device into a helper qemu: hotplug: Setup host side of VDPA device for disk hotplug src/qemu/qemu_hotplug.c | 3 +++ src/qemu/qemu_process.c | 42 - src/qemu/qemu_process.h | 3 +++ 3 files

[PATCH 2/2] qemu: hotplug: Setup host side of VDPA device for disk hotplug

2023-10-26 Thread Peter Krempa
The code which opens the VDPA device and prepares it for FD passing was not called in the hotplug code path, preventing hotplug of VDPA disks with: error: internal error: argument key 'path' must not have null value Use the new helper qemuProcessPrepareHostStorageDisk to setup the VDPA

[PATCH 1/2] qemu: process: Extract host setup of disk device into a helper

2023-10-26 Thread Peter Krempa
Currently the code sets up only VDPA backends but will be used later in hotplug code too. This patch also uses normal forward iteration in the loop in qemuProcessPrepareHostStorage as we don't need to remove disks from the disk list at that point. Signed-off-by: Peter Krempa ---

Re: [PATCH 00/22] qemu: Refactor blockdev protocol JSON generators ('raw' driver removal part 2)

2023-10-26 Thread Ján Tomko
On a Wednesday in 2023, Peter Krempa wrote: Second part cleans up tests and various bits and refactors the protocol blockdev JSON configuration generator to be reusable. This still doesn't change the configuration of the blockdevs, just reorders some arguments. Peter Krempa (22):

Re: [PULL 19/39] hw/s390x/s390-skeys: Don't call register_savevm_live() during instance_init()

2023-10-26 Thread Thomas Huth
On 24/10/2023 15.12, Juan Quintela wrote: From: Thomas Huth Since the instance_init() function immediately tries to set the property to "true", the s390_skeys_set_migration_enabled() tries to register a savevm handler during instance_init(). However, instance_init() functions can be called

Re: RFC: Switch to a date-based versioning scheme

2023-10-26 Thread Daniel P . Berrangé
On Thu, Oct 26, 2023 at 06:48:28AM -0700, Andrea Bolognani wrote: > Since we're just a few months away from the 10.0.0 release, I thought > it would be a good time to bring up this idea. > > Can we move to date-based version numbers? I suggest having > > libvirt 24.01.0 instead of 10.0.0 >

Re: [PULL 00/39] Migration 20231024 patches

2023-10-26 Thread Juan Quintela
Stefan Hajnoczi wrote: > On Tue, 24 Oct 2023 at 23:45, Juan Quintela wrote: >> >> The following changes since commit a95260486aa7e78d7c7194eba65cf03311ad94ad: >> >> Merge tag 'pull-tcg-20231023' of https://gitlab.com/rth7680/qemu into >> staging (2023-10-23 14:45:46 -0700) >> >> are available

Re: [PULL 20/39] hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled" property

2023-10-26 Thread Thomas Huth
On 24/10/2023 15.12, Juan Quintela wrote: From: Thomas Huth There's no need for dedicated handlers here if they don't do anything special. Acked-by: David Hildenbrand Reviewed-by: Eric Farman Acked-by: Juan Quintela Signed-off-by: Thomas Huth Signed-off-by: Juan Quintela Message-ID: