RE: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)

2008-12-10 Thread Itamar Heim
Sure - probably not a good idea to send patches at such a late hour anyway :) Attached diff. Some more details: For those using SDL (for some crazy reason as Berrange put it in the original patch), there is a use for the fullscreen option, causing the qemu window to open in full screen, change

Re: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)

2008-12-10 Thread Daniel Veillard
On Wed, Dec 10, 2008 at 06:06:51AM -0500, Itamar Heim wrote: Sure - probably not a good idea to send patches at such a late hour anyway :) Attached diff. Some more details: For those using SDL (for some crazy reason as Berrange put it in the original patch), there is a use for the

Re: [libvirt] [PATCH] Fix 'virsh pool-list' locking issue

2008-12-10 Thread Daniel Veillard
On Wed, Dec 10, 2008 at 11:23:35AM +, Daniel P. Berrange wrote: On Wed, Dec 10, 2008 at 08:38:15AM +0100, Daniel Veillard wrote: On Tue, Dec 09, 2008 at 01:50:37PM -0500, Cole Robinson wrote: Running 'virsh pool-list' seems to deadlock libvirtd. Dan gave me some debugging tips, and I

RE: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)

2008-12-10 Thread Itamar Heim
-Original Message- From: Daniel Veillard [mailto:[EMAIL PROTECTED] Looks overall fine to me, the syntactic construct sounds generic enough. I would still suggest 2 more changes: - in virDomainGraphicsDefParseXML check the values coming from the XML, I guess we should

Re: [libvirt] [PATCH] Fix 'virsh pool-list' locking issue

2008-12-10 Thread Daniel P. Berrange
On Wed, Dec 10, 2008 at 01:07:47PM +0100, Daniel Veillard wrote: On Wed, Dec 10, 2008 at 11:23:35AM +, Daniel P. Berrange wrote: On Wed, Dec 10, 2008 at 08:38:15AM +0100, Daniel Veillard wrote: On Tue, Dec 09, 2008 at 01:50:37PM -0500, Cole Robinson wrote: Running 'virsh pool-list'

RE: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)

2008-12-10 Thread Itamar Heim
-Original Message- From: Daniel P. Berrange [mailto:[EMAIL PROTECTED] In this bit of the code: diff --git a/src/domain_conf.h b/src/domain_conf.h index 51cf6d5..436d0b1 100644 --- a/src/domain_conf.h +++ b/src/domain_conf.h @@ -268,6 +268,7 @@ struct _virDomainGraphicsDef {

Re: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)

2008-12-10 Thread Daniel P. Berrange
On Wed, Dec 10, 2008 at 07:49:32AM -0500, Itamar Heim wrote: -Original Message- From: Daniel P. Berrange [mailto:[EMAIL PROTECTED] In this bit of the code: diff --git a/src/domain_conf.h b/src/domain_conf.h index 51cf6d5..436d0b1 100644 --- a/src/domain_conf.h +++

Re: [libvirt] [PATCH] Fix 'virsh pool-list' locking issue

2008-12-10 Thread Daniel P. Berrange
On Wed, Dec 10, 2008 at 08:38:15AM +0100, Daniel Veillard wrote: On Tue, Dec 09, 2008 at 01:50:37PM -0500, Cole Robinson wrote: Running 'virsh pool-list' seems to deadlock libvirtd. Dan gave me some debugging tips, and I managed to track it down to the poolGetAutostart function. The

Re: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)

2008-12-10 Thread Daniel P. Berrange
On Wed, Dec 10, 2008 at 06:06:51AM -0500, Itamar Heim wrote: Sure - probably not a good idea to send patches at such a late hour anyway :) Attached diff. In this bit of the code: diff --git a/src/domain_conf.h b/src/domain_conf.h index 51cf6d5..436d0b1 100644 --- a/src/domain_conf.h +++

Re: [libvirt] [PATCH] avoid format string warnings

2008-12-10 Thread Jim Meyering
Daniel Veillard [EMAIL PROTECTED] wrote: On Tue, Dec 09, 2008 at 06:00:22PM +0100, Jim Meyering wrote: * src/openvz_conf.c (openvzGetNodeCPUs): Add %s arg before _(...). * src/uml_driver.c (umlDomainBlockPeek): Likewise. Sure, +1 ! Thanks. Committed. -- Libvir-list mailing list

Re: [libvirt] Deploying latest libvirt in rhel / centos 5.2

2008-12-10 Thread Marco Sinhoreli
I need the libvirt 0.5.1 to work with the oVirt and prepare this solution to work over Xen. Do you know if I do a backport of the Xen from fc9 or fc10 or perhaps Xen 3.3.0 the libvirt could to work? Regards, On Tue, Dec 9, 2008 at 12:16 PM, Daniel Veillard [EMAIL PROTECTED] wrote: On Tue, Dec

[libvirt] [PATCH] avoid a new make distcheck failure

2008-12-10 Thread Jim Meyering
I noticed that make distcheck was failing. This fixes it: From b80b724feb30ba46c5481e5b1198bbdfc2bfe428 Mon Sep 17 00:00:00 2001 From: Jim Meyering [EMAIL PROTECTED] Date: Wed, 10 Dec 2008 17:45:32 +0100 Subject: [PATCH] avoid a new make distcheck failure Distribute the new file,

Re: [libvirt] [PATCH] Add copy-on-write image support

2008-12-10 Thread Daniel P. Berrange
On Tue, Dec 09, 2008 at 05:28:57PM +, Miloslav Trma?? wrote: the attached patch adds support for copy-on-write images: creating them, deleting them, identifying them. Nice - thanks for working on this feature ! I'll put a few comments inline Index: docs/formatstorage.html.in

Re: [libvirt] [PATCH] avoid a new make distcheck failure

2008-12-10 Thread Jim Meyering
Cole Robinson [EMAIL PROTECTED] wrote: Jim Meyering wrote: I noticed that make distcheck was failing. This fixes it: ACK, one of two fixes needed to get rpm builds working again. (I'll post the other fix in a moment) Thanks. committed -- Libvir-list mailing list Libvir-list@redhat.com

[libvirt] [PATCH] Fix rpm building with new logrotate file

2008-12-10 Thread Cole Robinson
The attached patch teaches the rpm spec about the new logrotate file, which unbreaks rpm builds. Thanks, Cole diff --git a/libvirt.spec.in b/libvirt.spec.in index cddf5c8..c9dbc8b 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -320,6 +320,7 @@ fi %{_sysconfdir}/rc.d/init.d/libvirtd

Re: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)

2008-12-10 Thread Jim Paris
Daniel P. Berrange wrote: And in the struct int fullscreen : 1; unsigned int fullscreen : 1; would be better (so the possible values are 0 and 1). -jim -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Fix locking issue in testVolumeLookupByPath

2008-12-10 Thread Cole Robinson
The attached patch fixes a locking issue in the test driver, specifically testStorageVolumeLookupByPath. We were only unlocking the pool object if it was running. This fixed a deadlock I was seeing while adding some new tests to virtinst's test framework. Thanks, Cole diff --git a/src/test.c

[libvirt] [PATCH] virConnectGetHostname: return a fully qualified hostname

2008-12-10 Thread David Lutterkort
The attached patch makes virConnectGetHostname try a little harder to get a FQDN on systems where gethostname only returns a short name without a domain (which is pretty useless). The behavior is equivalent to 'hostname --fqdn'. From 2ae57d0c8c68c453b3f9715fcc9f83af0ebe84a0 Mon Sep 17 00:00:00