Re: [libvirt] virsh migrate with libvirt-0.6.2: failed to start listening VM

2009-09-21 Thread Chris Lalancette
David Wilcox wrote: On the other machine, the log file that gets created under /var/log/libvirt/qemo/windowsxp.log LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin /usr/bin/qemu-kvm -S -M pc -m 512 -smp 1 -name windowsxp -uuid 24d2fd62-ed4f-a321-e264-200b347cfa6c -monitor pty -pidfile

Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-21 Thread Chris Lalancette
Daniel P. Berrange wrote: 1) Immediately after starting the stream, I get a virStreamRecv() callback on the destination side. The problem is that this is wrong for migration; there's no data that I can read *from* the destination qemu process which makes any sense. While I could

[libvirt] Re: Fix Xen virConnectPtr leak

2009-09-21 Thread Chris Lalancette
Matthias Bolte wrote: The fix for this problem is simple: remove the virConnectRef/virUnrefConnect calls from the Xen subdrivers (see attached patch). Maybe someone could explain why the Xen Inotify and Xen Store driver do this extra ref-counting, but none of the other Xen subdrivers. It

Re: [libvirt] Some problem with the save function

2009-09-21 Thread Chris Lalancette
Charles Duffy wrote: Chris Lalancette wrote: No, you are right. This was part of the refactoring, and I just didn't re-read the code. I would prefer to move prog to the top of the block myself, and add args there; it just seems tidier. I agree that it's tidier -- but looking at

Re: [libvirt] Fix Xen virConnectPtr leak

2009-09-21 Thread Daniel P. Berrange
On Sat, Sep 19, 2009 at 11:50:21AM +0200, Matthias Bolte wrote: The commit cb51aa48a777ddae6997faa9f28350cb62655ffd Fix up connection reference counting. changed the driver closing and virConnectPtr unref-logic in virConnectClose(). Before this commit virConnectClose() closed all drivers of

Re: [libvirt] [PATCH 1/2] Fix net/disk hot-unplug segfault

2009-09-21 Thread Daniel P. Berrange
On Thu, Sep 17, 2009 at 04:02:10PM +0100, Mark McLoughlin wrote: When we hot-unplug the last device, we're currently double-freeing the device definition. Reported by Michal Nowak here: https://bugzilla.redhat.com/523953 * src/qemu_driver.c: fix double free --- src/qemu_driver.c |

Re: [libvirt] [PATCH 2/2] Fix leak in PCI hostdev hot-unplug

2009-09-21 Thread Daniel P. Berrange
On Thu, Sep 17, 2009 at 04:03:00PM +0100, Mark McLoughlin wrote: * src/qemu_driver.c: sync the hostdev hot-unplug code with the disk/net code. --- src/qemu_driver.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/qemu_driver.c

Re: [libvirt] qemu_driver migrateuri handling broken?

2009-09-21 Thread Daniel P. Berrange
On Wed, Sep 16, 2009 at 05:42:50PM +0200, Gregor Schaffrath wrote: Hi all. Short summary on DV's request ;) I ran into a problem migrating kvm machines with libvirt-0.6.5: 1) At first, using the same syntax for the migrateuri as with xen (just the IP) did not work... looking into the

Re: [libvirt] [PATCH] lxc: suspend/resume support

2009-09-21 Thread Daniel P. Berrange
On Thu, Sep 17, 2009 at 12:42:08AM +0900, Ryota Ozaki wrote: +static int lxcDomainSuspend(virDomainPtr dom) +{ +lxc_driver_t *driver = dom-conn-privateData; +virDomainObjPtr vm; +virDomainEventPtr event = NULL; +int ret = -1; + +lxcDriverLock(driver); +vm =

Re: [libvirt] ESX [01/12]: Add esxNodeGetFreeMemory()

2009-09-21 Thread Daniel P. Berrange
On Mon, Sep 14, 2009 at 02:40:13AM +0200, Matthias Bolte wrote: * src/esx/esx_driver.c: add esxNodeGetFreeMemory(), cache IP address * src/esx/esx_vi.[ch]: refactor resource pool query into esxVI_GetResourcePool() * src/esx/esx_vi_types.[ch]: bind VI type ResourcePoolResourceUsage ACK, to

[libvirt] [PATCH] Remove an unnecessary variable from remoteIOReadMessage().

2009-09-21 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- src/remote_internal.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index dd7b31e..b89d45d 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -6942,10

[libvirt] [PATCH] Fix up 'neccessary - necessary' in a comment.

2009-09-21 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- src/virterror.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/virterror.c b/src/virterror.c index 77b295c..e421ab7 100644 --- a/src/virterror.c +++ b/src/virterror.c @@ -641,7 +641,7 @@

[libvirt] [PATCH] Don't do virSetConnError when virDrvSupportsFeature is successful.

2009-09-21 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- src/libvirt.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 4a11688..fa59dc7 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1349,8 +1349,11 @@ virDrvSupportsFeature

[libvirt] [PATCH] Fix a double-free in qemudRunLoop()

2009-09-21 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- qemud/qemud.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemud/qemud.c b/qemud/qemud.c index 00b9859..087f5da 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -2270,7 +2270,6 @@ cleanup: }

[libvirt] [PATCH] Fix up comments for domainXML{To,From}Native.

2009-09-21 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- src/esx/esx_driver.c |4 ++-- src/lxc_driver.c |4 ++-- src/phyp/phyp_driver.c |4 ++-- src/test.c |4 ++-- src/uml_driver.c |4 ++-- src/vbox/vbox_tmpl.c |4 ++-- src/xen_unified.c |

[libvirt] [PATCH] Simple fix of a comment in qemuStringToArgvEnv.

2009-09-21 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- src/qemu_conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu_conf.c b/src/qemu_conf.c index f92bcef..273aeca 100644 --- a/src/qemu_conf.c +++ b/src/qemu_conf.c @@ -2363,7 +2363,7 @@ static int

[libvirt] [PATCH] add doc for graphic and video elements

2009-09-21 Thread Florian Vichot
Hello The title says it all. Here's some doc explaining the new syntax of the video and graphic elements in the domain XML. It (probably) won't get me any literary awards but, eh, it's a start :) Florian diff --git a/docs/formatdomain.html b/docs/formatdomain.html index a715457..f95f72b 100644

Re: [libvirt] [PATCH] Fix up 'neccessary - necessary' in a comment.

2009-09-21 Thread Daniel P. Berrange
On Mon, Sep 21, 2009 at 02:53:25PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/virterror.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/virterror.c b/src/virterror.c index 77b295c..e421ab7 100644 ---

Re: [libvirt] [PATCH] Don't do virSetConnError when virDrvSupportsFeature is successful.

2009-09-21 Thread Daniel P. Berrange
On Mon, Sep 21, 2009 at 02:53:31PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/libvirt.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 4a11688..fa59dc7 100644 ---

Re: [libvirt] [PATCH] Fix a double-free in qemudRunLoop()

2009-09-21 Thread Daniel P. Berrange
On Mon, Sep 21, 2009 at 02:53:37PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- qemud/qemud.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemud/qemud.c b/qemud/qemud.c index 00b9859..087f5da 100644 --- a/qemud/qemud.c

Re: [libvirt] [PATCH] Fix up comments for domainXML{To,From}Native.

2009-09-21 Thread Daniel P. Berrange
On Mon, Sep 21, 2009 at 02:53:43PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/esx/esx_driver.c |4 ++-- src/lxc_driver.c |4 ++-- src/phyp/phyp_driver.c |4 ++-- src/test.c |4 ++-- src/uml_driver.c |

Re: [libvirt] [PATCH] Simple fix of a comment in qemuStringToArgvEnv.

2009-09-21 Thread Daniel P. Berrange
On Mon, Sep 21, 2009 at 02:53:49PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/qemu_conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu_conf.c b/src/qemu_conf.c index f92bcef..273aeca 100644 ---

Re: [libvirt] [PATCH] add doc for graphic and video elements

2009-09-21 Thread Daniel P. Berrange
On Mon, Sep 21, 2009 at 03:31:44PM +0200, Florian Vichot wrote: Hello The title says it all. Here's some doc explaining the new syntax of the video and graphic elements in the domain XML. It (probably) won't get me any literary awards but, eh, it's a start :) Florian diff --git

Re: [libvirt] [PATCH] Remove an unnecessary variable from remoteIOReadMessage().

2009-09-21 Thread Daniel P. Berrange
On Mon, Sep 21, 2009 at 02:53:17PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/remote_internal.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index dd7b31e..b89d45d

Re: [libvirt] [PATCH] Remove an unnecessary variable from remoteIOReadMessage().

2009-09-21 Thread Chris Lalancette
Daniel P. Berrange wrote: On Mon, Sep 21, 2009 at 02:53:17PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/remote_internal.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c

Re: [libvirt] [PATCH] Remove an unnecessary variable from remoteIOReadMessage().

2009-09-21 Thread Daniel P. Berrange
On Mon, Sep 21, 2009 at 03:44:51PM +0200, Chris Lalancette wrote: Daniel P. Berrange wrote: On Mon, Sep 21, 2009 at 02:53:17PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/remote_internal.c |3 +-- 1 files changed, 1 insertions(+), 2

Re: [libvirt] [PATCH: 0/MANY] Re-arrange files in the source tree

2009-09-21 Thread Daniel P. Berrange
On Wed, Sep 16, 2009 at 07:38:14PM +0100, Daniel P. Berrange wrote: This is a followup to http://www.redhat.com/archives/libvir-list/2009-September/msg00477.html I am not actually going to spam the list with all the patches, since it'd generate a HUGE series of mails. Instead I have

Re: [libvirt] [PATCH] lxc: suspend/resume support

2009-09-21 Thread Ryota Ozaki
On Mon, Sep 21, 2009 at 9:05 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Sep 17, 2009 at 12:42:08AM +0900, Ryota Ozaki wrote: +static int lxcDomainSuspend(virDomainPtr dom) +{ +    lxc_driver_t *driver = dom-conn-privateData; +    virDomainObjPtr vm; +    virDomainEventPtr

Re: [libvirt] [PATCH] Power Hypervisor now with libssh2

2009-09-21 Thread Eduardo Otubo
Daniel Veillard wrote: On Wed, Aug 26, 2009 at 03:53:01AM -0300, Eduardo Otubo wrote: Hello friends, This is the new version of phyp driver now using libssh2. I also did some other changes: * Added some debug information. Sometimes its worth to know which command is being executed and

[libvirt] [PATCH] network: add 'bootp' and 'tftp' config

2009-09-21 Thread Paolo Bonzini
Currently, libvirtd will start a dnsmasq process for the virtual network, but (aside from killing the dnsmasq process and replacing it), there's no way to define tftp boot options. This change introduces the appropriate tags to the dhcp configuration: network namedefault/name bridge

Re: [libvirt] [PATCH] network: add 'bootp' and 'tftp' config

2009-09-21 Thread Daniel P. Berrange
On Mon, Sep 21, 2009 at 10:50:25PM +0200, Paolo Bonzini wrote: Currently, libvirtd will start a dnsmasq process for the virtual network, but (aside from killing the dnsmasq process and replacing it), there's no way to define tftp boot options. This change introduces the appropriate tags to