[libvirt] How many functions that can't be used within libvirt

2011-04-01 Thread SanitYey o
Hello, I've tested some functions of libvirt don't work. Could some people give me a reasonable explanation about these functions? Why do these function don't work? Or if there is anything wrong of my understanding. 1.virsh # migrate 1 xen+ssh://root@172.16.201.183/Password: error: POST

Re: [libvirt] [PATCHv8 2/4] libvirt/qemu - synchronous update of device definition

2011-04-01 Thread Wen Congyang
At 04/01/2011 12:19 PM, KAMEZAWA Hiroyuki Write: From 229cfc90781bfd7024f79db1aed8bea5963757e3 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Thu, 31 Mar 2011 18:52:24 +0900 Subject: [PATCHv8 2/4] libvirt/qemu - synchronous update of device definition.

Re: [libvirt] [PATCHv8 2/4] libvirt/qemu - synchronous update of device definition

2011-04-01 Thread KAMEZAWA Hiroyuki
On Fri, 01 Apr 2011 14:10:18 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 04/01/2011 12:19 PM, KAMEZAWA Hiroyuki Write: From 229cfc90781bfd7024f79db1aed8bea5963757e3 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Thu, 31 Mar 2011 18:52:24 +0900

Re: [libvirt] [PATCHv8 2/4] libvirt/qemu - synchronous update of device definition

2011-04-01 Thread Wen Congyang
At 04/01/2011 02:16 PM, KAMEZAWA Hiroyuki Write: On Fri, 01 Apr 2011 14:10:18 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 04/01/2011 12:19 PM, KAMEZAWA Hiroyuki Write: From 229cfc90781bfd7024f79db1aed8bea5963757e3 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki

Re: [libvirt] [PATCH v2] qemu: Ignore libvirt debug messages in qemu log

2011-04-01 Thread Jiri Denemark
On Thu, Mar 31, 2011 at 09:06:43 -0600, Eric Blake wrote: On 03/31/2011 02:40 AM, Jiri Denemark wrote: qemu driver uses a 4K buffer for reading qemu log file. This is enough when only qemu's output is present in the log file. However, when debugging messages are turned on, intermediate

Re: [libvirt] [PATCHv8 2/4] libvirt/qemu - synchronous update of device definition

2011-04-01 Thread KAMEZAWA Hiroyuki
On Fri, 01 Apr 2011 14:33:23 +0800 Wen Congyang we...@cn.fujitsu.com wrote: I found that virDomainObjAssignDef() can work. We can call it like this: virDomainObjAssignDef(vm, copy, false). We modify vm-newdef if domain is active, and modify vm-def if domain is inactive. Okay, here is a

[libvirt] Libvirt potentially in GSoC 2011 through CERN

2011-04-01 Thread Justin Clift
Hi all, Just came across this interesting Google Summer of Code 2011 potential at CERN, where they specifically mention libvirt improvements in more than one project: http://cernvm.cern.ch/portal/gsoc11 Nifty eh? :) Regards and best wishes, Justin Clift -- libvir-list mailing list

Re: [libvirt] [PATCHv8 1/4] libvirt/qemu - persistent modification of inactive domans.

2011-04-01 Thread Wen Congyang
At 04/01/2011 12:17 PM, KAMEZAWA Hiroyuki Write: From 1ffbe73b1663719414367abbdebc8f31b9592331 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Thu, 31 Mar 2011 16:20:05 +0900 Subject: [PATCHv8 1/4] libvirt/qemu - persistent modification of devices. Now,

Re: [libvirt] [PATCHv8 1/4] libvirt/qemu - persistent modification of inactive domans.

2011-04-01 Thread KAMEZAWA Hiroyuki
On Fri, 01 Apr 2011 15:30:13 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 04/01/2011 12:17 PM, KAMEZAWA Hiroyuki Write: From 1ffbe73b1663719414367abbdebc8f31b9592331 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Thu, 31 Mar 2011 16:20:05 +0900

Re: [libvirt] [libvirt-php] Remove strip from installation

2011-04-01 Thread Michal Novotny
On 04/01/2011 07:25 AM, Lyre wrote: Make it able to generate debuginfo package. Thanks, pushed now! I don't know why this is not there but maybe I added this to f14 branch only since it's necessary to generate debuginfo packages for Fedora. However I applied your patch to master branch :)

Re: [libvirt] [PATCH 3/4] vcpupin: implement the remote protocol to address the new API

2011-04-01 Thread Hu Tao
On Thu, Mar 31, 2011 at 02:39:52PM +0900, Taku Izumi wrote: This patch implements the remote protocol to address the new API (virDomainPinVcpuFlags). Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- daemon/remote.c | 37 +

[libvirt] [PATCH] virsh: Fix documentation for memtune command

2011-04-01 Thread Jiri Denemark
Commit 78ba748ef14c520ff1c4af2b5b0a44586ac49c8c claims to fix documentation for swap_hard_limit virsh memtune option but it only fixes documentation in formatdomain.html and libvirt.h. This patch completes the task by fixing virsh help memtune output and memtune section of virsh man page. ---

Re: [libvirt] [libvirt-php] Remove strip from installation

2011-04-01 Thread Lyre
于 2011年04月01日 16:33, Michal Novotny 写道: On 04/01/2011 07:25 AM, Lyre wrote: Make it able to generate debuginfo package. Thanks, pushed now! I don't know why this is not there but maybe I added this to f14 branch only since it's necessary to generate debuginfo packages for Fedora. However I

[libvirt] [libvirt-php] API to add/remove disk to/from domain

2011-04-01 Thread Conor Murphy
Hi, How do I add/remove a disk to a domain using the libvirt-php API? Thanks, Conor -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php] Remove strip from installation

2011-04-01 Thread Michal Novotny
On 04/01/2011 11:23 AM, Lyre wrote: 于 2011年04月01日 16:33, Michal Novotny 写道: On 04/01/2011 07:25 AM, Lyre wrote: Make it able to generate debuginfo package. Thanks, pushed now! I don't know why this is not there but maybe I added this to f14 branch only since it's necessary to generate

Re: [libvirt] [PATCH] virsh: Fix documentation for memtune command

2011-04-01 Thread Daniel P. Berrange
On Fri, Apr 01, 2011 at 10:47:29AM +0200, Jiri Denemark wrote: Commit 78ba748ef14c520ff1c4af2b5b0a44586ac49c8c claims to fix documentation for swap_hard_limit virsh memtune option but it only fixes documentation in formatdomain.html and libvirt.h. This patch completes the task by fixing virsh

Re: [libvirt] [PATCH] Fix several formatting mistakes in doc

2011-04-01 Thread Daniel P. Berrange
On Fri, Apr 01, 2011 at 09:25:45AM +0800, Daniel Veillard wrote: On Thu, Mar 31, 2011 at 11:15:34AM -0600, Eric Blake wrote: On 03/31/2011 07:58 AM, Daniel P. Berrange wrote: - We run xmllint, but failures in xmllint validation are not causing a build failure We already have

Re: [libvirt] [PATCH] virsh: fix mingw failure on creating nonblocking pipe

2011-04-01 Thread Daniel P. Berrange
On Thu, Mar 31, 2011 at 04:12:09PM -0600, Eric Blake wrote: On 03/31/2011 04:03 PM, Eric Blake wrote: * .gnulib: Update to latest, for nonblocking module. * bootstrap.conf (gnulib_modules): Add nonblocking. * src/util/util.c (virSetBlocking): Defer to gnulib. --- Matthias, does this

[libvirt] [PATCH] Fix libxl driver startup

2011-04-01 Thread Daniel Veillard
When you happen to have a libvirtd binary compiled with the libxenlight driver (say you have installed xen-4.1 libraries) but not running a xen enabled system, then libvirtd fails to start. The cause is that libxlStartup() returns -1 when failing to initialize the library, and this propagates

[libvirt] [PATCH] add sendevent command and related APIs

2011-04-01 Thread Lai Jiangshan
Enable libvirt send some events to the guest. This command currently only supports NMI and key events. Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- daemon/remote.c | 52 + daemon/remote_dispatch_args.h |2

[libvirt] [PATCH v2 0/5] Add TXT record and hosts support for DNS service and dnsmasq command-line regression testing

2011-04-01 Thread Michal Novotny
Hi, this is the patch to introduce the TXT record and DNS hosts support for the DNS service on the virtual network. This can be defined using the txt-record subelement in the dns element of the network XML description. The definition of TXT record names containing spaces is rejected with the error

[libvirt] [PATCH v2 4/5] Network: Add additional hosts internal infrastructure

2011-04-01 Thread Michal Novotny
Hi, this is the patch to introduce the internal infrastructure for additional hosts for network bridge driver using the addnhosts* API functions. This is necessary for next part of the patch to support DNS hosts definition in the network XML description. Michal Signed-off-by: Michal Novotny

[libvirt] [PATCH v2 1/5] Network: Add TXT record support for virtual DNS service

2011-04-01 Thread Michal Novotny
Make: passed Make check: passed Make syntax-check: passed Hi, this is the patch to add support for adding TXT records to the DNS service running on the virtual network. This has been tested on Fedora-14 i386 box and tests are also added to RelaxNG schema and test XML files. Since spaces are not

[libvirt] [PATCH v2 2/5] Network: Add regression tests for the command line arguments

2011-04-01 Thread Michal Novotny
Make: passed Make check: passed Make syntax-check: passed Hi, this is the patch that is adding regression tests for the network bridge driver command-line arguments similar way it is done for QEMU driver. This is checking the built dnsmasq parameters (using networkBuildDhcpDaemonCommandLine()

[libvirt] [PATCH v2 3/5] Network: Move dnsmasqContext creation to networkSaveDnsmasqHostsfile() and pass to dnsmasq only if applicable

2011-04-01 Thread Michal Novotny
Make: passed Make check: passed Make syntax-check: passed Hi, this is the patch to move the dnsmasqContext creation to the networkSaveDnsmasqHostsfile() function and also it passes the hosts-file and addn-hosts to the file only if applicable, i.e. if it's already set. Originally I wanted to call

[libvirt] [PATCH v2 5/5] Network: Add support for DNS hosts definition to the network XML

2011-04-01 Thread Michal Novotny
Make: passed Make check: passed Make syntax-check: passed Hi, this is the patch to add support for DNS hosts definition in the network XML description to generate the the hosts file. This patch uses the addnhosts* APIs implemented to the src/util/dnsmasq.c by part 2 of this patch series. Also,

Re: [libvirt] [PATCH] Fix libxl driver startup

2011-04-01 Thread Daniel P. Berrange
On Fri, Apr 01, 2011 at 05:34:27PM +0800, Daniel Veillard wrote: When you happen to have a libvirtd binary compiled with the libxenlight driver (say you have installed xen-4.1 libraries) but not running a xen enabled system, then libvirtd fails to start. The cause is that libxlStartup()

Re: [libvirt] [libvirt-snmp][PATCH v4 4/4] Add SNMP trap/notification support.

2011-04-01 Thread Daniel P. Berrange
On Wed, Mar 30, 2011 at 01:20:30PM +0200, Michal Privoznik wrote: This patch adds support for domain lifecycle notification support over SNMP traps. SNMP subagent monitors any domain events and when something interesting happens, it sends a trap. Monitoring is done in a joinable thread using

Re: [libvirt] [libvirt-php] API to add/remove disk to/from domain

2011-04-01 Thread Michal Novotny
On 04/01/2011 11:11 AM, Conor Murphy wrote: Hi, How do I add/remove a disk to a domain using the libvirt-php API? Thanks, Conor -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list Hi Conor, you have to edit the domain XML file manually,

Re: [libvirt] [PATCH] virsh: Fix documentation for memtune command

2011-04-01 Thread Jiri Denemark
On Fri, Apr 01, 2011 at 10:24:46 +0100, Daniel P. Berrange wrote: On Fri, Apr 01, 2011 at 10:47:29AM +0200, Jiri Denemark wrote: Commit 78ba748ef14c520ff1c4af2b5b0a44586ac49c8c claims to fix documentation for swap_hard_limit virsh memtune option but it only fixes documentation in

Re: [libvirt] [PATCH] Fix libxl driver startup

2011-04-01 Thread Daniel Veillard
On Fri, Apr 01, 2011 at 12:17:58PM +0100, Daniel P. Berrange wrote: On Fri, Apr 01, 2011 at 05:34:27PM +0800, Daniel Veillard wrote: When you happen to have a libvirtd binary compiled with the libxenlight driver (say you have installed xen-4.1 libraries) but not running a xen enabled

Re: [libvirt] [libvirt-php] Remove strip from installation

2011-04-01 Thread Eric Blake
On 03/31/2011 11:25 PM, Lyre wrote: Make it able to generate debuginfo package. install-exec-local: - $(INSTALL) -m 644 -D --strip $(PACKAGE).so $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so + $(INSTALL) -m 644 -D $(PACKAGE).so $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so $(INSTALL) -m 755 -d

Re: [libvirt] [PATCH] virsh: fix mingw failure on creating nonblocking pipe

2011-04-01 Thread Eric Blake
On 04/01/2011 03:44 AM, Daniel P. Berrange wrote: On Thu, Mar 31, 2011 at 04:12:09PM -0600, Eric Blake wrote: On 03/31/2011 04:03 PM, Eric Blake wrote: * .gnulib: Update to latest, for nonblocking module. * bootstrap.conf (gnulib_modules): Add nonblocking. * src/util/util.c (virSetBlocking):

[libvirt] [PATCH 0/7] Add support for taking screenshots

2011-04-01 Thread Michal Privoznik
This patch series implements screenshots taking feature, which is accessible via new virDomainScreenshot API and 'screenshot' command in virsh. By now, 'flags' argument is not used, but can be later when specifying say image output format, etc. Talking of - output is hypervisor specific. QEMU

[libvirt] [PATCH 5/7] screenshot: Expose the new API in virsh

2011-04-01 Thread Michal Privoznik
--- tools/virsh.c | 49 + tools/virsh.pod |4 2 files changed, 53 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 19e3449..6f6883d 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1881,6 +1881,54 @@

[libvirt] [PATCH 3/7] screenshot: Implementing the public API

2011-04-01 Thread Michal Privoznik
--- src/libvirt.c | 77 + 1 files changed, 77 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 8be18d4..9f8f2e6 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -2445,6 +2445,83 @@ error: } /** + *

[libvirt] [PATCH 2/7] screenshot: Defining the internal API

2011-04-01 Thread Michal Privoznik
--- src/driver.h |5 + src/esx/esx_driver.c |1 + src/libxl/libxl_driver.c |1 + src/lxc/lxc_driver.c |1 + src/openvz/openvz_driver.c |1 + src/phyp/phyp_driver.c |1 + src/qemu/qemu_driver.c |1 + src/remote/remote_driver.c |

[libvirt] [PATCH 1/7] screenshot: Defining the public API

2011-04-01 Thread Michal Privoznik
--- include/libvirt/libvirt.h.in |7 +++ src/libvirt_public.syms |1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index bd36015..42711e6 100644 --- a/include/libvirt/libvirt.h.in +++

[libvirt] [PATCH 6/7] qemu: Implement the driver methods

2011-04-01 Thread Michal Privoznik
--- src/qemu/qemu_driver.c | 107 +- src/qemu/qemu_monitor.c | 20 src/qemu/qemu_monitor.h |3 + src/qemu/qemu_monitor_json.c | 23 + src/qemu/qemu_monitor_json.h |4 ++ src/qemu/qemu_monitor_text.c | 31

[libvirt] [PATCH 4/7] screenshot: Implementing the remote protocol

2011-04-01 Thread Michal Privoznik
--- daemon/remote.c | 26 ++ daemon/remote_dispatch_args.h |1 + daemon/remote_dispatch_prototypes.h |8 daemon/remote_dispatch_table.h |5 + src/remote/remote_driver.c | 27 ++-

[libvirt] [PATCH 7/7] vbox: Implement the driver methods

2011-04-01 Thread Michal Privoznik
--- src/vbox/vbox_tmpl.c | 96 ++ 1 files changed, 96 insertions(+), 0 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 390fc3b..5c9c271 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -36,6 +36,9 @@

[libvirt] [PATCH] Use gnulib's manywarnings warnings modules

2011-04-01 Thread Daniel P. Berrange
Remove custom code for checking compiler warnings, using gl_WARN_ADD instead. Don't list all flags ourselves, use gnulib's gl_MANYWARN_ALL_GCC to get all possible GCC flags, then turn off the ones we don't want yet. This patch alone doesn't buy us much. What we want is some more followup patches,

Re: [libvirt] [PATCH 1/7] screenshot: Defining the public API

2011-04-01 Thread Eric Blake
On 04/01/2011 09:29 AM, Michal Privoznik wrote: --- include/libvirt/libvirt.h.in |7 +++ src/libvirt_public.syms |1 + 2 files changed, 8 insertions(+), 0 deletions(-) Hmm, we've already declared 0.9.0 feature freeze; +++ b/src/libvirt_public.syms @@ -428,6 +428,7 @@

[libvirt] [PATCH] build: detect potentential uninitialized variables

2011-04-01 Thread Eric Blake
Even with -Wuninitialized (which is part of autobuild.sh --enable-compile-warnings=error), gcc does NOT catch this use of an uninitialized variable: { if (cond) goto error; int a = 1; error: printf(%d, a); } which prints 0 (if the stack was previously wiped) if cond was true. Clang

Re: [libvirt] [PATCH] Use gnulib's manywarnings warnings modules

2011-04-01 Thread Eric Blake
On 04/01/2011 09:39 AM, Daniel P. Berrange wrote: Remove custom code for checking compiler warnings, using gl_WARN_ADD instead. Don't list all flags ourselves, use gnulib's gl_MANYWARN_ALL_GCC to get all possible GCC flags, then turn off the ones we don't want yet. This patch alone doesn't

Re: [libvirt] [PATCH 1/7] screenshot: Defining the public API

2011-04-01 Thread Daniel P. Berrange
On Fri, Apr 01, 2011 at 05:29:15PM +0200, Michal Privoznik wrote: --- include/libvirt/libvirt.h.in |7 +++ src/libvirt_public.syms |1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index

[libvirt] [PATCH] nwfilters: support for TCP flags evaluation

2011-04-01 Thread Stefan Berger
This patch adds support for the evaluation of TCP flags in nwfilters. It adds documentation to the web page and extends the tests as well. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- docs/formatnwfilter.html.in | 10 ++ docs/schemas/nwfilter.rng

[libvirt] [TCK][PATCH] nwfilter: test support for TCP flags evaluation

2011-04-01 Thread Stefan Berger
This patch extends an existing test with test cases for the TCP flags. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- scripts/nwfilter/nwfilterxml2fwallout/tcp-test.fwall |4 scripts/nwfilter/nwfilterxml2xmlin/tcp-test.xml | 12 2 files changed, 16

Re: [libvirt] [PATCH 1/6] virNodeGetCpuTime: Expose new API

2011-04-01 Thread Eric Blake
On 03/31/2011 07:55 PM, Minoru Usui wrote: virNodeGetCpuTime: Expose new API include/libvirt/libvirt.h.in | 26 ++ src/libvirt_public.syms |1 + 2 files changed, 27 insertions(+), 0 deletions(-) +/** + * virNodeCpuTime: + * + * a virNodeCpuTime is

Re: [libvirt] [TCK][PATCH] nwfilter: test support for TCP flags evaluation

2011-04-01 Thread Daniel P. Berrange
On Fri, Apr 01, 2011 at 12:17:32PM -0400, Stefan Berger wrote: This patch extends an existing test with test cases for the TCP flags. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- scripts/nwfilter/nwfilterxml2fwallout/tcp-test.fwall |4

Re: [libvirt] [PATCH] do not lock vm while allocating memory

2011-04-01 Thread Eric Blake
On 03/30/2011 01:46 AM, Wen Congyang wrote: There is no need to lock vm while allocating memory. If allocating memory failed, we forgot to unlock vm. --- src/qemu/qemu_process.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_process.c

Re: [libvirt] [PATCH] fix memory leak in qemuProcessHandleGraphics()

2011-04-01 Thread Eric Blake
On 03/30/2011 01:46 AM, Wen Congyang wrote: If strdup(x509dname) or strdup(saslUsername) success, but strdup(x509dname) or strdup(saslUsername) failed, subject-nidentity is not the num elements of subject-identities, and we will leak some memory. --- src/qemu/qemu_process.c | 12

Re: [libvirt] [BUG] Managed save qemu state gets deleted after failed resume

2011-04-01 Thread Eric Blake
On 03/30/2011 02:24 AM, Philipp Hahn wrote: Hello, I haven't had time to provide a fix, but still want you to inform you about a bug: If resuming a saved VM fails with Qemu-0.14, the managed save state file /var/lib/libvirt/qemu/save/$VM.save is still deleted. I think it would be better

Re: [libvirt] [PATCH v2 0/4] configure inactive domains' maximum memory size

2011-04-01 Thread Eric Blake
On 03/30/2011 11:19 PM, Taku Izumi wrote: Hi all, This patchset enables us to configure inactive domain's maximum memory size. I redesigned according to Daniel-san's commnet. The following patchset is the prerequisite of these. =

Re: [libvirt] How many functions that can't be used within libvirt

2011-04-01 Thread Eric Blake
On 04/01/2011 12:10 AM, SanitYey o wrote: Hello, I've tested some functions of libvirt don't work. Could some people give me a reasonable explanation about these functions? Why do these function don't work? Or if there is anything wrong of my understanding. 1.virsh # migrate 1

Re: [libvirt] [PATCH 1/4] vcpupin: inroduce a new libvir API (virDomainPinVcpuFlags)

2011-04-01 Thread Eric Blake
On 03/30/2011 11:38 PM, Taku Izumi wrote: This patch introduces a new libvirt API (virDomainPinVcpuFlags) Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com /** + * virDomainPinVcpuFlags: + * @domain: pointer to domain object, or NULL for Domain0 + * @vcpu: virtual CPU number + *

Re: [libvirt] [PATCH 2/4] vcpupin: implement the code to address the new API in the qemu driver

2011-04-01 Thread Eric Blake
On 03/31/2011 01:33 AM, Osier Yang wrote: This allows both LIVE and CONFIG are set, and you use two if clauses later for both of them, ( if (flags VIR_DOMAIN_VCPU_CONFIG), and if (flags VIR_DOMAIN_VCPU_LIVE) ) so there should be problem. IMHO it should be: Exactly one of LIVE or CONFIG

Re: [libvirt] [PATCH] add sendevent command and related APIs

2011-04-01 Thread Eric Blake
On 04/01/2011 03:51 AM, Lai Jiangshan wrote: Enable libvirt send some events to the guest. This command currently only supports NMI and key events. Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com Would you mind resending this split into several patches? For example, see how

Re: [libvirt] [PATCH] nwfilters: support for TCP flags evaluation

2011-04-01 Thread Eric Blake
On 04/01/2011 10:17 AM, Stefan Berger wrote: This patch adds support for the evaluation of TCP flags in nwfilters. It adds documentation to the web page and extends the tests as well. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com It would help to list a sample xml snippet in the

Re: [libvirt] [PATCH] Fix several formatting mistakes in doc

2011-04-01 Thread Eric Blake
On 03/31/2011 07:27 PM, Daniel Veillard wrote: $ SGML_CATALOG_FILES='/etc/xml/catalog' /usr/bin/xmllint --catalogs --nonet --format --valid formatcaps.html.in /dev/null formatcaps.html.in:1: validity error : Validation failed: no DTD found ! html ^ just drop --valid from the

Re: [libvirt] [PATCH 1/6] virNodeGetCpuTime: Expose new API

2011-04-01 Thread Matthias Bolte
2011/4/1 Eric Blake ebl...@redhat.com: On 03/31/2011 07:55 PM, Minoru Usui wrote: virNodeGetCpuTime: Expose new API  include/libvirt/libvirt.h.in |   26 ++  src/libvirt_public.syms      |    1 +  2 files changed, 27 insertions(+), 0 deletions(-) +/** + *

Re: [libvirt] [PATCH] nwfilters: support for TCP flags evaluation

2011-04-01 Thread Stefan Berger
On 04/01/2011 01:53 PM, Eric Blake wrote: On 04/01/2011 10:17 AM, Stefan Berger wrote: This patch adds support for the evaluation of TCP flags in nwfilters. It adds documentation to the web page and extends the tests as well. Signed-off-by: Stefan Bergerstef...@linux.vnet.ibm.com It would

[libvirt] [PATCH] docs: correct invalid xml

2011-04-01 Thread Eric Blake
* docs/internals.html.in: Fix xml errors. * docs/formatstorageencryption.html.in: Likewise. * docs/drvesx.html.in: Likewise. * docs/archnetwork.html.in: Likewise. * docs/logging.html.in: Likewise. * docs/drvvmware.html.in: Likewise. * docs/api.html.in: Likewise. * docs/formatnwfilter.html.in:

[libvirt] [RFC PATCH] build: detect doc build errors

2011-04-01 Thread Eric Blake
I'm still stumped by xsltproc complaining about nbsp; not being a valid XML entity, hence the (hackish) exemption in docs/Makefile.am that adds --html for a couple of .html.in files. But for the remaining files, this does make input validation stricter, and caught several bugs. Hence, this is an

[libvirt] [PATCH] docs: fix typo

2011-04-01 Thread Eric Blake
* docs/formatdomain.html.in: Fix KVM name. --- Pushing under the trivial rule. docs/formatdomain.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6c624ab..574fee5 100644 --- a/docs/formatdomain.html.in

[libvirt] [libvirt-php] Fixed set_error when argument is NULL

2011-04-01 Thread Lyre
Avoid freeing a NULL pointer --- src/libvirt-php.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 6a76f45..66b1de9 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -237,12 +237,16 @@ PHP_MINFO_FUNCTION(libvirt)

Re: [libvirt] [PATCH] Fix several formatting mistakes in doc

2011-04-01 Thread Daniel Veillard
On Fri, Apr 01, 2011 at 12:04:04PM -0600, Eric Blake wrote: On 03/31/2011 07:27 PM, Daniel Veillard wrote: $ SGML_CATALOG_FILES='/etc/xml/catalog' /usr/bin/xmllint --catalogs --nonet --format --valid formatcaps.html.in /dev/null formatcaps.html.in:1: validity error : Validation failed: no