[libvirt] [PATCH] schedinfo: update man page about virsh schedinfo command

2011-08-26 Thread Taku Izumi
This patch updates the man page about virsh schedinfo command. - fix typo: 1844674407370955 - 18446744073709551 - describe the value 0 of vcpu_period and vcpu_quota parameters Signd-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- tools/virsh.pod |5 +++-- 1 file changed, 3

Re: [libvirt] [test-API][PATCH] Fix the missing ret variable problem

2011-08-26 Thread Guannan Ren
On 08/23/2011 06:18 PM, Wayne Sun wrote: --- repos/remoteAccess/tls_setup.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/repos/remoteAccess/tls_setup.py b/repos/remoteAccess/tls_setup.py index 80d6b42..4e7f24e 100644 --- a/repos/remoteAccess/tls_setup.py +++

[libvirt] [PATCH v3 0/3] Correctly label migration TCP socket

2011-08-26 Thread Jiri Denemark
With current libvirt and qemu, migration is not working if SELinux is in enforcing mode, since the TCP socket we pass to qemu is not labeled in a way that would allow qemu to read from it. After this patchset, migration works even in enforcing mode. Jiri Denemark (3): security: Rename

[libvirt] [PATCH v3 3/3] qemu: Correctly label migration TCP socket

2011-08-26 Thread Jiri Denemark
--- Notes: Version 3: - use virSecurityManagerSetSocketLabel/virSecurityManagerClearSocketLabel pair around virNetSocketNewConnectTCP to label the newly created socket with svirt_t Version 2: - use virSecurityManagerSetProcessFDLabel instead of

[libvirt] [PATCH v3 1/3] security: Rename SetSocketLabel APIs to SetDaemonSocketLabel

2011-08-26 Thread Jiri Denemark
The APIs are designed to label a socket in a way that the libvirt daemon itself is able to access it (i.e., in SELinux the label is virtd_t based as opposed to svirt_* we use for labeling resources that need to be accessed by a vm). The new name reflects this. --- Notes: Version 3: - new

[libvirt] [PATCH v3 2/3] security: Introduce SetSocketLabel

2011-08-26 Thread Jiri Denemark
This API labels all sockets created until ClearSocketLabel is called in a way that a vm can access them (i.e., they are labeled with svirt_t based label in SELinux). --- Notes: Version 3: - new patch src/libvirt_private.syms|1 + src/security/security_dac.c |9

Re: [libvirt] [test-API][PATCH] add imagetype argument for guest installation testcases

2011-08-26 Thread Nan Zhang
On 08/17/2011 09:13 PM, Guannan Ren wrote: Add disk format argument to installation test scripts. With them, we can test snapshot testing. The following is the conf file sample. domain:install_linux_cdrom guestname test-api-guest ... imagetype qcow2 ...

Re: [libvirt] [PATCH v3 1/3] security: Rename SetSocketLabel APIs to SetDaemonSocketLabel

2011-08-26 Thread Daniel Veillard
On Fri, Aug 26, 2011 at 10:23:46AM +0200, Jiri Denemark wrote: The APIs are designed to label a socket in a way that the libvirt daemon itself is able to access it (i.e., in SELinux the label is virtd_t based as opposed to svirt_* we use for labeling resources that need to be accessed by a

Re: [libvirt] [PATCH v3 2/3] security: Introduce SetSocketLabel

2011-08-26 Thread Daniel Veillard
On Fri, Aug 26, 2011 at 10:23:47AM +0200, Jiri Denemark wrote: This API labels all sockets created until ClearSocketLabel is called in a way that a vm can access them (i.e., they are labeled with svirt_t based label in SELinux). --- Notes: Version 3: - new patch

Re: [libvirt] [PATCH v3 3/3] qemu: Correctly label migration TCP socket

2011-08-26 Thread Daniel Veillard
On Fri, Aug 26, 2011 at 10:23:48AM +0200, Jiri Denemark wrote: --- Notes: Version 3: - use virSecurityManagerSetSocketLabel/virSecurityManagerClearSocketLabel pair around virNetSocketNewConnectTCP to label the newly created socket with svirt_t Version 2: - use

[libvirt] [PATCH] virsh: Clarify documentation of -d option

2011-08-26 Thread Jiri Denemark
The default is 4, not 0. --- tools/virsh.pod |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index e17f309..9355d6c 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -72,7 +72,8 @@ instead of the default connection. =item B-d,

Re: [libvirt] [PATCH] Ignore unused streams in virStreamAbort

2011-08-26 Thread Jiri Denemark
On Tue, Aug 16, 2011 at 08:33:27 -0600, Eric Blake wrote: On 08/16/2011 04:44 AM, Jiri Denemark wrote: When virStreamAbort is called on a stream that has not been used yet, quite confusing error is returned: this function is not supported by the connection driver. Let's just ignore such

Re: [libvirt] [PATCH] Do not try to cancel non-existent migration on source

2011-08-26 Thread Jiri Denemark
On Thu, Aug 25, 2011 at 13:30:43 -0600, Eric Blake wrote: On 08/25/2011 01:03 PM, Jiri Denemark wrote: On Tue, Aug 16, 2011 at 21:39:41 +0200, Jiri Denemark wrote: On Tue, Aug 16, 2011 at 08:33:04 -0600, Eric Blake wrote: On 08/16/2011 04:44 AM, Jiri Denemark wrote: Shouldn't

Re: [libvirt] [PATCH v3 1/3] security: Rename SetSocketLabel APIs to SetDaemonSocketLabel

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 10:23:46AM +0200, Jiri Denemark wrote: The APIs are designed to label a socket in a way that the libvirt daemon itself is able to access it (i.e., in SELinux the label is virtd_t based as opposed to svirt_* we use for labeling resources that need to be accessed by a

[libvirt] [test-API][PATCH] Add 2 functions to support get and set the scheduler parameters flag

2011-08-26 Thread Nan Zhang
Add 2 functions into domain API get_sched_params_flags() set_sched_params_flags() --- lib/domainAPI.py | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py index 5667c20..a6efab7 100644 --- a/lib/domainAPI.py +++

Re: [libvirt] [PATCH v3 3/3] qemu: Correctly label migration TCP socket

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 10:23:48AM +0200, Jiri Denemark wrote: --- Notes: Version 3: - use virSecurityManagerSetSocketLabel/virSecurityManagerClearSocketLabel pair around virNetSocketNewConnectTCP to label the newly created socket with svirt_t Version 2: - use

Re: [libvirt] [PATCH v3 2/3] security: Introduce SetSocketLabel

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 10:23:47AM +0200, Jiri Denemark wrote: This API labels all sockets created until ClearSocketLabel is called in a way that a vm can access them (i.e., they are labeled with svirt_t based label in SELinux). --- Notes: Version 3: - new patch

Re: [libvirt] [test-API][PATCH v2] Add ownership_test.py test case

2011-08-26 Thread Guannan Ren
On 08/25/2011 07:42 PM, Wayne Sun wrote: * Save a domain to a file, check the ownership of the file after save and restore operation --- repos/domain/ownership_test.py | 302 1 files changed, 302 insertions(+), 0 deletions(-) create mode

[libvirt] [PATCH 1/2] virterror: Fix error message for VIR_ERR_INVALID_ARG

2011-08-26 Thread Michal Privoznik
When a detail message is presented, nobody expects prefix 'invalid argument in' but something more general, like 'invalid argument:'. --- src/util/virterror.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/virterror.c b/src/util/virterror.c index

[libvirt] [PATCH 2/2 v3] remote: Refuse connecting to remote socket

2011-08-26 Thread Michal Privoznik
If users wants to connect to remote unix socket, e.g. 'qemu+unix://remote/system' currently the remote part is ignored, ending up connecting to localhost. Connecting to remote socket is not supported and user should have used TLS/TCP/SSH instead. --- Although v2 was ACKed I send v3 so we have

Re: [libvirt] [PATCH 1/2] Fix keymap used to talk with QEMU

2011-08-26 Thread Daniel P. Berrange
On Thu, Aug 25, 2011 at 11:20:18AM -0600, Eric Blake wrote: On 08/25/2011 10:49 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The QEMU 'sendkey' command expects keys to be encoded in the same way as the RFB extended keycode set. Specfically it wants extended

Re: [libvirt] [PATCH] virsh: Clarify documentation of -d option

2011-08-26 Thread Michal Privoznik
On 26.08.2011 11:10, Jiri Denemark wrote: The default is 4, not 0. --- tools/virsh.pod |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index e17f309..9355d6c 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -72,7 +72,8 @@

Re: [libvirt] [test-API][PATCH] Add 2 functions to support get and set the scheduler parameters flag

2011-08-26 Thread Guannan Ren
On 08/26/2011 05:42 PM, Nan Zhang wrote: Add 2 functions into domain API get_sched_params_flags() set_sched_params_flags() --- lib/domainAPI.py | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py index

Re: [libvirt] [PATCH v3 0/3] Correctly label migration TCP socket

2011-08-26 Thread Jiri Denemark
On Fri, Aug 26, 2011 at 10:23:45 +0200, Jiri Denemark wrote: With current libvirt and qemu, migration is not working if SELinux is in enforcing mode, since the TCP socket we pass to qemu is not labeled in a way that would allow qemu to read from it. After this patchset, migration works even

Re: [libvirt] [PATCH] virsh: Clarify documentation of -d option

2011-08-26 Thread Jiri Denemark
On Fri, Aug 26, 2011 at 13:08:16 +0200, Michal Privoznik wrote: On 26.08.2011 11:10, Jiri Denemark wrote: The default is 4, not 0. --- tools/virsh.pod |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index e17f309..9355d6c

Re: [libvirt] [PATCHv2 3/5] hyperv: Add OpenWSMAN based client for the Hyper-V WMI API

2011-08-26 Thread Matthias Bolte
2011/8/20 Eric Blake ebl...@redhat.com: On 08/03/2011 09:00 AM, Matthias Bolte wrote: Add a generator script to generate the structs and serialization information for OpenWSMAN. openwsman.h collects workarounds for problems in OpenWSMAN= 2.2.6. There are also disabled sections that would

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-26 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 3:06 PM, Eric Blake ebl...@redhat.com wrote: On 08/25/2011 05:54 AM, Stefan Hajnoczi wrote: On Tue, Aug 23, 2011 at 4:47 PM, Eric Blakeebl...@redhat.com  wrote: On 08/23/2011 09:35 AM, Stefan Hajnoczi wrote: On Tue, Aug 23, 2011 at 4:18 PM, Eric

Re: [libvirt] [PATCHv2 4/5] hyperv: Add basic driver for Microsoft Hyper-V

2011-08-26 Thread Matthias Bolte
2011/8/20 Eric Blake ebl...@redhat.com: On 08/03/2011 09:00 AM, Matthias Bolte wrote: Domain listing, basic information retrieval and domain life cycle management is implemented. But currently the domian XML output s/domian/domain/ lacks the complete devices section. The driver uses

[libvirt] [PATCH 0/3 TCK] Some tests for snapshot management

2011-08-26 Thread Daniel P. Berrange
All these tests fail with current GIT, but are intended to work with Eric's snapshot series applied. The first test in this list, however, does not pass. Eric's current tree forbids calling 'Destroy' on a transient guest which has snapshots present. IMHO this is wrong, because the guest may

[libvirt] [PATCH 1/3] Add test for transient domain snapshot management

2011-08-26 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The test case validates the core lifecycle operations on persistent domains with snapshots. A transient domain should allow snapshots to be created while running. It should be possible to destory and restart the domain and still have snapshots present.

[libvirt] [PATCH 3/3] Add test for recursive deletion of snapshot lists

2011-08-26 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The test case validates it recursive deletion of snapshots cleans up all children and leaves no orphans behind. --- .../domain-snapshot/100-delete-snapshot-children.t | 101 1 files changed, 101 insertions(+), 0 deletions(-)

[libvirt] [PATCH 2/3] Add test for persistent domain snapshot management

2011-08-26 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The test case validates the core lifecycle operations on persistent domains with snapshots. A persistent domain should allow snapshots to be created deleted while both running and shutoff. It should forbid undefine of the domain when it has snapshots

Re: [libvirt] [BUGFIX][PATCH] remove saved garbages after persistent migration

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 12:15:37PM +0900, KAMEZAWA Hiroyuki wrote: From e1e8d5ceb4a9f7c59e20dfb8c168b781435c1613 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Fri, 26 Aug 2011 12:08:11 +0900 Subject: [PATCH] Fix persistent migration config save When a

Re: [libvirt] [PATCH] libvirtd: create run dir when running at non-root user

2011-08-26 Thread Eric Blake
On 08/26/2011 03:51 AM, x...@linux.vnet.ibm.com wrote: From: soulxusoulxu@soulxu-ThinkPad-T410.(none) Signed-off-by: Xu He Jiex...@linux.vnet.ibm.com When libvirtd is running at non-root user, it won't create ${HOME}/.libvirt. It will show error message: 17:44:16.838: 7035: error :

Re: [libvirt] [PATCH 1/2] virterror: Fix error message for VIR_ERR_INVALID_ARG

2011-08-26 Thread Eric Blake
On 08/26/2011 03:56 AM, Michal Privoznik wrote: When a detail message is presented, nobody expects prefix 'invalid argument in' but something more general, like 'invalid argument:'. --- src/util/virterror.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH 2/2 v3] remote: Refuse connecting to remote socket

2011-08-26 Thread Eric Blake
On 08/26/2011 03:56 AM, Michal Privoznik wrote: If users wants to connect to remote unix socket, e.g. 'qemu+unix://remote/system' currently theremote part is ignored, ending up connecting to localhost. Connecting to remote socket is not supported and user should have used TLS/TCP/SSH instead.

Re: [libvirt] [PATCH 1/2] Fix keymap used to talk with QEMU

2011-08-26 Thread Eric Blake
On 08/26/2011 04:41 AM, Daniel P. Berrange wrote: +extern int (*codeOffsetVerify(void)) [verify_true (ARRAY_CARDINALITY(codeOffset) == VIR_KEYCODE_SET_LAST)]; \ Why the trailing backslash? Also, open-coding this verify is dangerous; gcc warnings have changed over time, rendering certain

Re: [libvirt] [PATCHv2 3/5] hyperv: Add OpenWSMAN based client for the Hyper-V WMI API

2011-08-26 Thread Eric Blake
On 08/26/2011 06:10 AM, Matthias Bolte wrote: I pointed out a couple of nits, but nothing jumped out at me as a showstopper. ACK, and I'm happy if you push without posting a v3. Here's the interdiff I'm going to apply, before I push the whole series. Looks good. ACK to the interdiff.

Re: [libvirt] [PATCHv2 4/5] hyperv: Add basic driver for Microsoft Hyper-V

2011-08-26 Thread Eric Blake
On 08/26/2011 06:35 AM, Matthias Bolte wrote: Conditional ACK - I pointed out a couple more flag-variant functions that are trivially implemented. I'm okay if you post a delta patch for review, then squash it in before pushing, since that would be shorter than a full-blown v3. Here's

Re: [libvirt] [PATCH 0/3 TCK] Some tests for snapshot management

2011-08-26 Thread Eric Blake
On 08/26/2011 08:16 AM, Daniel P. Berrange wrote: All these tests fail with current GIT, but are intended to work with Eric's snapshot series applied. The first test in this list, however, does not pass. Eric's current tree forbids calling 'Destroy' on a transient guest which has snapshots

Re: [libvirt] [PATCH 1/3] Add test for transient domain snapshot management

2011-08-26 Thread Eric Blake
On 08/26/2011 08:16 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The test case validates the core lifecycle operations on persistent domains with snapshots. A transient domain should allow snapshots to be created while running. It should be possible to destory and

Re: [libvirt] [PATCH 0/3 TCK] Some tests for snapshot management

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 08:57:54AM -0600, Eric Blake wrote: On 08/26/2011 08:16 AM, Daniel P. Berrange wrote: All these tests fail with current GIT, but are intended to work with Eric's snapshot series applied. The first test in this list, however, does not pass. Eric's current tree

[libvirt] [PATCH] rpc: Don't close connection if program is unknown

2011-08-26 Thread Jiri Denemark
In case we add a new program in the future (we did that in the past and we are going to do it again soon) current daemon will behave badly with new client that wants to use the new program. Before the RPC rewrite we used to just sent an error reply to any request with unknown program. With the RPC

Re: [libvirt] [PATCH 0/3 TCK] Some tests for snapshot management

2011-08-26 Thread Eric Blake
On 08/26/2011 09:03 AM, Daniel P. Berrange wrote: IMHO, we should be allowed to call 'virDomainDestroy' on a transient guest with snapshots, and then later 'virDomainCreateXML' to re-create the guest and still have access to the snapshots But leaving the snapshot metadata files behind is

Re: [libvirt] [PATCH] rpc: Don't close connection if program is unknown

2011-08-26 Thread Eric Blake
On 08/26/2011 09:11 AM, Jiri Denemark wrote: In case we add a new program in the future (we did that in the past and we are going to do it again soon) current daemon will behave badly with new client that wants to use the new program. Before the RPC rewrite we used to just sent an error reply to

Re: [libvirt] [PATCH 0/3 TCK] Some tests for snapshot management

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 09:15:43AM -0600, Eric Blake wrote: On 08/26/2011 09:03 AM, Daniel P. Berrange wrote: IMHO, we should be allowed to call 'virDomainDestroy' on a transient guest with snapshots, and then later 'virDomainCreateXML' to re-create the guest and still have access to the

Re: [libvirt] [PATCH 2/3] Add test for persistent domain snapshot management

2011-08-26 Thread Eric Blake
On 08/26/2011 08:16 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The test case validates the core lifecycle operations on persistent domains with snapshots. A persistent domain should allow snapshots to be created deleted while both running and shutoff. This test

Re: [libvirt] [PATCH 3/3] Add test for recursive deletion of snapshot lists

2011-08-26 Thread Eric Blake
On 08/26/2011 08:16 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The test case validates it recursive deletion of snapshots cleans up all children and leaves no orphans behind. --- .../domain-snapshot/100-delete-snapshot-children.t | 101 1

Re: [libvirt] [PATCH] rpc: Don't close connection if program is unknown

2011-08-26 Thread Jiri Denemark
On Fri, Aug 26, 2011 at 09:17:50 -0600, Eric Blake wrote: On 08/26/2011 09:11 AM, Jiri Denemark wrote: In case we add a new program in the future (we did that in the past and we are going to do it again soon) current daemon will behave badly with new client that wants to use the new

Re: [libvirt] [BUGFIX][PATCH] remove saved garbages after persistent migration

2011-08-26 Thread Eric Blake
On 08/26/2011 08:25 AM, Daniel P. Berrange wrote: On Fri, Aug 26, 2011 at 12:15:37PM +0900, KAMEZAWA Hiroyuki wrote: From e1e8d5ceb4a9f7c59e20dfb8c168b781435c1613 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyukikamezawa.hir...@jp.fujitsu.com Date: Fri, 26 Aug 2011 12:08:11 +0900 Subject:

Re: [libvirt] [PATCHv2 5/5] hyperv: Add basic documentation

2011-08-26 Thread Matthias Bolte
2011/8/20 Eric Blake ebl...@redhat.com: On 08/03/2011 09:00 AM, Matthias Bolte wrote: --- v2: - move microsoft.com link to drvhyperv.html.in  docs/drivers.html.in   |    1 +  docs/drvhyperv.html.in |  112  docs/index.html.in     |    3 +

Re: [libvirt] [PATCH] schedinfo: update man page about virsh schedinfo command

2011-08-26 Thread Eric Blake
On 08/26/2011 12:48 AM, Taku Izumi wrote: This patch updates the man page about virsh schedinfo command. - fix typo: 1844674407370955 - 18446744073709551 - describe the value 0 of vcpu_period and vcpu_quota parameters Signd-off-by: Taku Izumiizumi.t...@jp.fujitsu.com ---

[libvirt] [PATCH] build: simplify use of verify

2011-08-26 Thread Eric Blake
Back in 2008 when this line of util.h was written, gnulib's verify module didn't allow the use of multiple verify() in one file in combination with our choice of gcc -W options. But that has since been fixed in gnulib, and newer gnulib even maps verify() to the C1x feature of _Static_assert,

Re: [libvirt] [PATCHv2 0/5] Add basic driver for Microsoft Hyper-V

2011-08-26 Thread Matthias Bolte
2011/8/20 Eric Blake ebl...@redhat.com: On 08/03/2011 09:00 AM, Matthias Bolte wrote: Version 2 of the Hyper-V driver. See the individual patches for the changes from version 1. Complete version 1 can be found here https://www.redhat.com/archives/libvir-list/2011-July/msg00766.html This

Re: [libvirt] [PATCHv2 3/5] hyperv: Add OpenWSMAN based client for the Hyper-V WMI API

2011-08-26 Thread Matthias Bolte
2011/8/26 Eric Blake ebl...@redhat.com: On 08/26/2011 06:10 AM, Matthias Bolte wrote:  I pointed out a couple of nits, but nothing jumped out at me as a  showstopper.  ACK, and I'm happy if you push without posting a v3. Here's the interdiff I'm going to apply, before I push the whole

[libvirt] [PATCH] Fix generator to cope with call-by-ref long types

2011-08-26 Thread Jim Fehlig
From: Matthias Bolte matthias.bo...@googlemail.com Tested-by: Jim Fehlig jfeh...@novell.com Matthias provided this patch to fix an issue I encountered in the generator with APIs containing call-by-ref long type, e.g. int virDomainMigrateGetMaxSpeed(virDomainPtr domain,

Re: [libvirt] [PATCH] Fix generator to cope with call-by-ref long types

2011-08-26 Thread Eric Blake
On 08/26/2011 11:58 AM, Jim Fehlig wrote: From: Matthias Boltematthias.bo...@googlemail.com Tested-by: Jim Fehligjfeh...@novell.com Matthias provided this patch to fix an issue I encountered in the generator with APIs containing call-by-ref long type, e.g. int

Re: [libvirt] [PATCH] Fix generator to cope with call-by-ref long types

2011-08-26 Thread Jim Fehlig
Eric Blake wrote: On 08/26/2011 11:58 AM, Jim Fehlig wrote: From: Matthias Boltematthias.bo...@googlemail.com Tested-by: Jim Fehligjfeh...@novell.com Matthias provided this patch to fix an issue I encountered in the generator with APIs containing call-by-ref long type, e.g. int

[libvirt] [PATCH 4/8] Impl virDomainMigrateGetMaxSpeed in qemu driver

2011-08-26 Thread Jim Fehlig
--- src/qemu/qemu_driver.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f21122d..b932e67 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8256,6 +8256,38 @@

[libvirt] [PATCH 1/8] Add on_migrate element to domainXML

2011-08-26 Thread Jim Fehlig
on_migrate can be used to modify default parameters used when migrating a domain. --- docs/formatdomain.html.in | 21 docs/schemas/domain.rng | 13 ++ tests/domainschemadata/migration-params.xml | 34 +++

[libvirt] [PATCH 8/8] Use max speed specified in domain conf when migrating

2011-08-26 Thread Jim Fehlig
Prefer qemuMigrationRun() 'resource' parameter, but consider value set in domain conf if 'resource' is 0. --- src/qemu/qemu_migration.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 910cd8d..878d163 100644

[libvirt] [PATCH 6/8] Save migration speed to domain conf in qemuDomainMigrateSetMaxSpeed

2011-08-26 Thread Jim Fehlig
Now that migration speed is represented in XML, save the new value to domain conf when invoking qemuDomainMigrateSetMaxSpeed(). Allow setting migration speed on inactive domain too. --- src/qemu/qemu_driver.c | 45 - 1 files changed, 24

[libvirt] [PATCH 3/8] Add max migration bandwidth to domain_conf

2011-08-26 Thread Jim Fehlig
--- src/conf/domain_conf.c | 11 +++ src/conf/domain_conf.h |2 ++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 44212cf..4bf32e9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6263,6

[libvirt] [PATCH 7/8] Set qemu migration speed unlimited when migrating to file

2011-08-26 Thread Jim Fehlig
The qemu migration speed default is 32MiB/s as defined in migration.c /* Migration speed throttling */ static int64_t max_throttle = (32 20); The only reason to throttle migration when targeting a file is user request. If user has not changed the qemu default, set migration speed to unlimited

[libvirt] [PATCH 0/8] Add virDomainMigrateGetMaxSpeed API

2011-08-26 Thread Jim Fehlig
As per previous request [1], this patch series introduces virDomainMigrateGetMaxSpeed API. Patches 1-5 contain usual new API stuff. In patch 6, qemuDomainMigrateSetMaxSpeed is made to work with inactive domains and set the new value in domain conf. Patch 7 changes migration speed to unlimited

[libvirt] [PATCH 5/8] virsh: Expose virDomainMigrateGetMaxSpeed API

2011-08-26 Thread Jim Fehlig
--- tools/virsh.c | 41 + tools/virsh.pod |4 2 files changed, 45 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 15b9bdd..f6d65c7 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -5194,6 +5194,45 @@ done:

[libvirt] [PATCH 2/8] Add public API for getting migration speed

2011-08-26 Thread Jim Fehlig
Includes impl of python binding since the generator was not able to cope. Note: Requires gendispatch.pl patch from Matthias Bolte https://www.redhat.com/archives/libvir-list/2011-August/msg01367.html --- docs/apibuild.py|3 +- include/libvirt/libvirt.h.in|4 +++

[libvirt] [PATCH] maint: fix spelling errors on lose

2011-08-26 Thread Eric Blake
* docs/drvqemu.html.in: Fix typo. * src/libvirt.c (virDomainCreateXML, virDomainCreateWithFlags): Likewise. --- Pushing under the trivial rule. I lose my sanity when people are too loose with their spelling, resulting in this common typo :) docs/drvqemu.html.in |2 +- src/libvirt.c

Re: [libvirt] [PATCH 0/3] Enable automatic kill of running guests

2011-08-26 Thread Eric Blake
On 06/23/2011 07:11 AM, Eric Blake wrote: On 06/23/2011 07:03 AM, Daniel P. Berrange wrote: On Thu, Jun 23, 2011 at 06:52:47AM -0600, Eric Blake wrote: On 06/23/2011 04:58 AM, Daniel P. Berrange wrote: I am building an application which uses KVM to run specific tasks, rather than as a general

[libvirt] [PATCH] snapshot: forbid snapshot on autodestroy domain

2011-08-26 Thread Eric Blake
There is no reason to forbid pausing an autodestroy domain (not to mention that 'virsh start --paused --autodestroy' succeeds in creating a paused autodestroy domain). Meanwhile, qemu was failing to enforce the API documentation that autodestroy domains cannot be saved. And while the original

[libvirt] [PATCHv3.5 01/43] snapshot: better events when starting paused

2011-08-26 Thread Eric Blake
There are two classes of management apps that track events - one that only cares about on/off (and only needs to track EVENT_STARTED and EVENT_STOPPED), and one that cares about paused/running (also tracks EVENT_SUSPENDED/EVENT_RESUMED). To keep both classes happy, any transition that can go from