Re: [libvirt] [RFC PATCH] lxc: don't return error on GetInfo when cgroups not yet set up

2011-10-04 Thread Daniel P. Berrange
On Mon, Oct 03, 2011 at 02:03:18PM -0500, Serge E. Hallyn wrote: Quoting Daniel P. Berrange (berra...@redhat.com): The LXC controller 'main' method received the handshake FD and invokes lxcControllerRun(). This method does various setup tasks, in particular the following:

Re: [libvirt] [PATCH] Document that ff callbacks need to be invoked from a clean stack

2011-10-04 Thread Daniel P. Berrange
On Mon, Oct 03, 2011 at 10:41:17PM +0200, Guido Günther wrote: On Tue, Aug 16, 2011 at 02:24:53PM +0200, Guido Günther wrote: Hi Daniel, On Sat, Aug 13, 2011 at 08:57:45PM -0700, Daniel P. Berrange wrote: On Fri, Aug 12, 2011 at 11:54:28PM +0200, Guido Günther wrote: [..snip..] In

[libvirt] [PATCH] qemu: Fix migration with dname

2011-10-04 Thread Jiri Denemark
Destination libvirtd remembers the original name in the prepare phase and clears it in the finish phase. The original name is used when comparing domain name in migration cookie. --- Notes: Originally, I wanted to transfer the new name in migration cookie but that appeared to be much more

Re: [libvirt] [RFC] Adding new filesystem 'proxy' to 9p

2011-10-04 Thread M. Mohan Kumar
That is the case if the proxy helper code is perfectly written. I am trying to think about the scenario where there is a bug (eg heap corruption / stack overflow) which allows a malicious non-root QEMU process to exploit the proxy helper to run code that it was *not* intended to run. If

Re: [libvirt] [PATCH] Add AHCI support to qemu driver

2011-10-04 Thread Adam Litke
On Mon, Oct 03, 2011 at 10:46:18PM -0600, Jim Fehlig wrote: Adam Litke wrote: Hi Jim. I was testing this and found that I could not boot from the sata disks I defined. When I switch them back to ide, they can be booted just fine. Perhaps something is missing from the boot order logic?

Re: [libvirt] [PATCH] network: fill in bandwidth from portgroup for all forward modes

2011-10-04 Thread Daniel P. Berrange
On Tue, Oct 04, 2011 at 12:17:27AM -0400, Laine Stump wrote: This patch is a fix for: https://bugzilla.redhat.com/show_bug.cgi?id=743176 which was discovered by Dan Berrange while making bandwidth configuration work for LXC guests. Background: Although virtportprofile data from a

[libvirt] [PATCH] Make LXC work with new network configuration types

2011-10-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com If using one of the new non-NAT/routed virtual network configurations, the LXC driver would not know how to setup the VETH devices. Adding in calls to setup the actual network configuration at VM startup and cleanup when shutting down fixes this. *

Re: [libvirt] [PATCH] qemu: Fix migration with dname

2011-10-04 Thread Daniel P. Berrange
On Tue, Oct 04, 2011 at 12:06:10PM +0200, Jiri Denemark wrote: Destination libvirtd remembers the original name in the prepare phase and clears it in the finish phase. The original name is used when comparing domain name in migration cookie. What is the actual error we get ? Is it that the

Re: [libvirt] [PATCH] network: fill in bandwidth from portgroup for all forward modes

2011-10-04 Thread Laine Stump
On 10/04/2011 08:49 AM, Daniel P. Berrange wrote: On Tue, Oct 04, 2011 at 12:17:27AM -0400, Laine Stump wrote: This patch is a fix for: https://bugzilla.redhat.com/show_bug.cgi?id=743176 which was discovered by Dan Berrange while making bandwidth configuration work for LXC guests.

Re: [libvirt] [PATCH] qemu: Fix migration with dname

2011-10-04 Thread Jiri Denemark
On Tue, Oct 04, 2011 at 14:03:34 +0100, Daniel P. Berrange wrote: On Tue, Oct 04, 2011 at 12:06:10PM +0200, Jiri Denemark wrote: Destination libvirtd remembers the original name in the prepare phase and clears it in the finish phase. The original name is used when comparing domain name in

Re: [libvirt] [PATCH] Make LXC work with new network configuration types

2011-10-04 Thread Laine Stump
On 10/04/2011 08:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com If using one of the new non-NAT/routed virtual network configurations, the LXC driver would not know how to setup the VETH devices. Adding in calls to setup the actual network configuration at VM

Re: [libvirt] [PATCH] qemu: Fix migration with dname

2011-10-04 Thread Jiri Denemark
On Tue, Oct 04, 2011 at 15:16:28 +0200, Jiri Denemark wrote: On Tue, Oct 04, 2011 at 14:03:34 +0100, Daniel P. Berrange wrote: On Tue, Oct 04, 2011 at 12:06:10PM +0200, Jiri Denemark wrote: Destination libvirtd remembers the original name in the prepare phase and clears it in the finish

Re: [libvirt] bug: try to take disk snapshot for LVM2 Volume

2011-10-04 Thread MATSUDA, Daiki
On 09/29/2011 11:26 PM, MATSUDA, Daiki wrote: I tried the new snapshot function implemented by Eric Blake. It works very well for QCOW2 disk image system. But I often use LVM2 volume for QEMU virtual machines and tried to take disk snapshot by virsh command ( snapshot-create DOMNAME

Re: [libvirt] [PATCH] qemu: Fix migration with dname

2011-10-04 Thread Eric Blake
On 10/04/2011 07:48 AM, Jiri Denemark wrote: IIUC, you are trying to fix this, by making sure that the 'Finish' method encodes the original name in the cookie, not the new name ? Yes, although the complete picture is that incoming (from the POV of destination libvirtd) cookie is checked

[libvirt] [PATCH] build: fix 'make distcheck' with pdwtags installed

2011-10-04 Thread Eric Blake
I am getting this failure with 'make distcheck': GEN../../src/remote_protocol-structs /bin/sh: ../../src/remote_protocol-structs-t: Permission denied make[4]: *** [../../src/remote_protocol-structs] Error 1 since it attempts a sub-run of a VPATH 'make check' where $(srcdir) is

[libvirt] [PATCH] init: raise default system aio limits

2011-10-04 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=740899 documents that if qemu uses aio=native for its disks, then it consumes 128 aio requests per disk. On a host with multiple guests, this can quickly run out of kernel aio requests with the default aio-max-nr of 65536. Kernel developers have

Re: [libvirt] [RFC] security_dac: don't chown iso file

2011-10-04 Thread Serge E. Hallyn
Quoting Serge E. Hallyn (serge.hal...@canonical.com): isos are read-only, so libvirt doesn't need to chown them. In one of our testing setups, libvirt uses mirrorred isos. Since libvirt chowns the files, (and especially does not chown them back) the mirror refuses to update the iso. This

[libvirt] [PATCH 0/2] qemu: fix disk error_policy problems

2011-10-04 Thread Laine Stump
These two patches are related to: https://bugzilla.redhat.com/show_bug.cgi?id=730909 The first removes the obvious problem of attempting to feed qemu invalid options. The second makes it possible to specify a different policy for read errors and write errors. 1/2 is written such that 2/2 will

[libvirt] [PATCH 2/2] qemu: add separate rerror_policy for disk errors

2011-10-04 Thread Laine Stump
libvirt's XML only had a single attribute, error_policy to control both read and write error policy, but qemu has separate settings for these. In one case (enospc) a policy is allowed for write errors but not read errors. This patch adds a separate attribute that sets only the read error policy.

[libvirt] [PATCH 1/2] qemu: correct misspelled 'enospc' option, and only use for werror

2011-10-04 Thread Laine Stump
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=730909 When support for setting the qemu disk error policy to 'enospc' was added, it was inadvertantly as enospace. This patch corrects that on the qemu commandline (while retaining the enospace spelling for libvirt's XML. Also,

Re: [libvirt] [PATCH] init: raise default system aio limits

2011-10-04 Thread Laine Stump
On 10/04/2011 12:59 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=740899 documents that if qemu uses aio=native for its disks, then it consumes 128 aio requests per disk. On a host with multiple guests, this can quickly run out of kernel aio requests with the default

Re: [libvirt] [PATCH] Document that ff callbacks need to be invoked from a clean stack

2011-10-04 Thread Guido Günther
On Tue, Oct 04, 2011 at 09:00:17AM +0100, Daniel P. Berrange wrote: On Mon, Oct 03, 2011 at 10:41:17PM +0200, Guido Günther wrote: On Tue, Aug 16, 2011 at 02:24:53PM +0200, Guido Günther wrote: Hi Daniel, On Sat, Aug 13, 2011 at 08:57:45PM -0700, Daniel P. Berrange wrote: On Fri, Aug

Re: [libvirt] [RFC PATCH] snapshot: better virsh handling of missing current, parent

2011-10-04 Thread Laine Stump
On 09/30/2011 12:19 PM, Eric Blake wrote: Previously, virsh 'snapshot-parent' and 'snapshot-current' were completely silent in the case where the code conclusively proved there was no parent or current snapshot, but differed in exit status; this silence caused some confusion on whether the

Re: [libvirt] [PATCH 1/2] qemu: correct misspelled 'enospc' option, and only use for werror

2011-10-04 Thread Eric Blake
On 10/04/2011 12:35 PM, Laine Stump wrote: This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=730909 When support for setting the qemu disk error policy to 'enospc' was added, it was inadvertantly as enospace. This patch corrects that on spelling and grammar

Re: [libvirt] [PATCH 1/2] snapshot: add REVERT_FORCE to API

2011-10-04 Thread Laine Stump
On 09/30/2011 02:52 PM, Eric Blake wrote: Although reverting to a snapshot is a form of data loss, this is normally expected. However, there are two cases where additional surprises (failure to run the reverted state, or a break in connectivity to the domain) can come into play. Requiring

Re: [libvirt] [PATCH 2/2] snapshot: enforce REVERT_FORCE on qemu

2011-10-04 Thread Laine Stump
On 09/30/2011 02:52 PM, Eric Blake wrote: Implements the documentation for snapshot revert vs. force. Part of the patch tightens existing behavior (previously, reverting to an old snapshot withoutdomain was blindly attempted, now it requires force), while part of it relaxes behavior

Re: [libvirt] [PATCH 1/2] snapshot: add REVERT_FORCE to API

2011-10-04 Thread Eric Blake
On 10/04/2011 01:24 PM, Laine Stump wrote: - if (virDomainRevertToSnapshot(snapshot, flags) 0) + result = virDomainRevertToSnapshot(snapshot, flags); + if (result 0 force + last_error-code == VIR_ERR_SNAPSHOT_REVERT_RISKY) { + flags |= VIR_DOMAIN_SNAPSHOT_REVERT_FORCE; Are you not adding the

Re: [libvirt] [PATCH 2/2] qemu: add separate rerror_policy for disk errors

2011-10-04 Thread Eric Blake
On 10/04/2011 12:35 PM, Laine Stump wrote: libvirt's XML only had a single attribute, error_policy to control both read and write error policy, but qemu has separate settings for these. In one case (enospc) a policy is allowed for write errors but not read errors. This patch adds a separate

Re: [libvirt] [RFC PATCH] snapshot: better virsh handling of missing current, parent

2011-10-04 Thread Eric Blake
On 10/04/2011 12:54 PM, Laine Stump wrote: On 09/30/2011 12:19 PM, Eric Blake wrote: Previously, virsh 'snapshot-parent' and 'snapshot-current' were completely silent in the case where the code conclusively proved there was no parent or current snapshot, but differed in exit status; this

Re: [libvirt] [PATCH 2/2] snapshot: enforce REVERT_FORCE on qemu

2011-10-04 Thread Eric Blake
On 10/04/2011 01:26 PM, Laine Stump wrote: On 09/30/2011 02:52 PM, Eric Blake wrote: Implements the documentation for snapshot revert vs. force. Part of the patch tightens existing behavior (previously, reverting to an old snapshot withoutdomain was blindly attempted, now it requires force),

Re: [libvirt] [PATCH 2/2] snapshot: enforce REVERT_FORCE on qemu

2011-10-04 Thread Eric Blake
On 10/04/2011 04:02 PM, Eric Blake wrote: Before pushing this, I'm running some sanity tests. So far, this test sequence (adjusted to the fixed code) shows where force helps with older snapshots (I'll send separate email for showing how force helps active ABI-incompatible snapshots): Test 1: $

Re: [libvirt] Connection does not support host device enumeration

2011-10-04 Thread Kaushal Shriyan
2011/10/1 Kaushal Shriyan kaushalshri...@gmail.com: 2011/9/29 Kaushal Shriyan kaushalshri...@gmail.com: 2011/9/27 Osier Yang jy...@redhat.com: 于 2011年09月27日 01:13, Kaushal Shriyan 写道: Hi, Kaushal I don't use CentOS, so don't known it, though I guess it's the intention or mistake of the

[libvirt] Qemu/KVM guest boots 2x slower with vhost_net

2011-10-04 Thread Reeted
Hello all, for people in qemu-devel list, you might want to have a look at the previous thread about this topic, at http://www.spinics.net/lists/kvm/msg61537.html but I will try to recap here. I found that virtual machines in my host booted 2x slower (on average it's 2x slower, but probably

[libvirt] [PATCH 1.5/2] snapshot: use qemu-img on disks in use at time of snapshot

2011-10-04 Thread Eric Blake
Once we know which set of disks belong to a snapshot, reverting or deleting that snapshot should visit just those disks, rather than also visiting disks that were hot-plugged in the meantime or skipping disks that were hot-unplugged in the meantime. * src/qemu/qemu_domain.c

Re: [libvirt] Connection does not support host device enumeration

2011-10-04 Thread Dave Allan
On Wed, Oct 05, 2011 at 04:10:07AM +0530, Kaushal Shriyan wrote: 2011/10/1 Kaushal Shriyan kaushalshri...@gmail.com: 2011/9/29 Kaushal Shriyan kaushalshri...@gmail.com: 2011/9/27 Osier Yang jy...@redhat.com: 于 2011年09月27日 01:13, Kaushal Shriyan 写道: Hi, Kaushal I don't use CentOS, so

Re: [libvirt] [PATCH 1/2] qemu: correct misspelled 'enospc' option, and only use for werror

2011-10-04 Thread Laine Stump
On 10/04/2011 03:17 PM, Eric Blake wrote: On 10/04/2011 12:35 PM, Laine Stump wrote: This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=730909 When support for setting the qemu disk error policy to 'enospc' was added, it was inadvertantly as enospace. This patch corrects that on