On 05/20/2013 05:08 PM, Michal Privoznik wrote:
On 20.05.2013 11:59, Ján Tomko wrote:
In my review of 31532ca I missed the fact that VIR_STRDUP
now returns 1 on success, and 0 if the source was NULL.
(This still doesn't add proper OOM error handling.)
---
src/vbox/vbox_tmpl.c | 12
Hello,
I'm re-sending this patch for reviewing.
If necessary I'm willing to make
some changes to those patches.
I'm currently working on a better management for snapshots with virtualbox,
and my work is based on Virtualbox 4.2 so that's why I'm re sending this patch.
Regards,
Manuel VIVES
From: ryan woodsmall rwoodsm...@gmail.com
---
src/vbox/vbox_tmpl.c | 90 --
1 file changed, 80 insertions(+), 10 deletions(-)
diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index d37888c..5bef956 100644
--- a/src/vbox/vbox_tmpl.c
+++
From: ryan woodsmall rwoodsm...@gmail.com
---
src/vbox/vbox_driver.c |8
1 file changed, 8 insertions(+)
diff --git a/src/vbox/vbox_driver.c b/src/vbox/vbox_driver.c
index a68f33d..9d07574 100644
--- a/src/vbox/vbox_driver.c
+++ b/src/vbox/vbox_driver.c
@@ -61,6 +61,9 @@ extern
From: ryan woodsmall rwoodsm...@gmail.com
---
src/vbox/vbox_V4_2.c | 13 +
1 file changed, 13 insertions(+)
create mode 100644 src/vbox/vbox_V4_2.c
diff --git a/src/vbox/vbox_V4_2.c b/src/vbox/vbox_V4_2.c
new file mode 100644
index 000..8c5b61c
--- /dev/null
+++
From: ryan woodsmall rwoodsm...@gmail.com
---
src/Makefile.am |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 430a356..467ec5d 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -593,7 +593,8 @@ VBOX_DRIVER_SOURCES =
In this case, domain memory cgroup path is hardcoded and fail the
case after cgroup path changed recently. To avoid such failure, add
check function for lscgroup command before run this case, if check
fail then skip this case.
Signed-off-by: Wayne Sun g...@redhat.com
---
On 05/22/2013 01:50 PM, Ján Tomko wrote:
On 05/21/2013 04:31 PM, Guannan Ren wrote:
v3-v4
add missing .args, .xml files
(I raw it in git Untracked files this morning and
thought about it for a while, then git-cleaned them...)
rebase work.
v2-v3
rebase work.
v1-v2:
changed
Don't free the stream on error if we've successfully added it
to the hash table, since it will be freed by virChrdevHashEntryFree
callback.
Preserve the error message before calling virStreamFree, since it
resets the error.
Reported by Sergey Fionov on libvir-list.
---
src/conf/virchrdev.c | 15
---
src/conf/storage_conf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 073099b..6f89f1c 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -672,7 +672,7 @@
It's for parsing login attribute of auth.
---
src/conf/storage_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 6cb98bf..bd8eef0 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -447,7 +447,7 @@
Any string returned from virXPathString should be freed.
---
src/conf/storage_conf.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index bd8eef0..073099b 100644
--- a/src/conf/storage_conf.c
+++
And improve the error message
---
src/conf/storage_conf.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 6f89f1c..5c8577e 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -975,9 +975,11
Changes:
* Free all the strings at cleanup, instead of freeing them
in the middle
* Remove xmlFree
* s/tmppath/target_path/, to make it more sensible
* Add new goto label error
---
src/conf/storage_conf.c | 54 -
1 file
Changes:
* Add a new goto label error
* Free the strings at cleanup
* Remove the unnecessary frees
---
src/conf/storage_conf.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index
Trivial, but it allows the error message to have more spaces.
---
src/conf/storage_conf.c | 95 -
1 file changed, 47 insertions(+), 48 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 5c8577e..76dae52 100644
---
---
src/conf/storage_conf.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 1f376ef..44ecb2a 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -888,11 +888,8 @@
And error out if the casted value is not same with the original
one, which prevents the bug on platform(s) where uid_t/gid_t
has different size with long.
---
src/conf/storage_conf.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/conf/storage_conf.c
s/VIR_ERR_INTERNAL_ERROR/VIR_ERR_XML_ERROR/.
---
src/conf/storage_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 76dae52..efe02e8 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -829,7 +829,7
Part of v1 are pushed, the left patches are splitted
Osier Yang (12):
storage_conf: Fix the wrong error message
storage_conf: Don't leak uuid in virStoragePoolDefParseAuthCephx
storage_conf: Remove the useless casting
storage_conf: Use xmlStrEqual instead of STREQ
storage_conf: Put %s
---
src/conf/storage_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 4c08cea..1f376ef 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -1485,7 +1485,7 @@
virStoragePoolDefParseSource:
* Better error message
virStoragePoolObjLoad:
* Break the line line
---
src/conf/storage_conf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 44ecb2a..a62629e 100644
---
On 22/05/13 20:05, Osier Yang wrote:
And error out if the casted value is not same with the original
one, which prevents the bug on platform(s) where uid_t/gid_t
has different size with long.
---
src/conf/storage_conf.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff
On 05/22/2013 08:55 AM, Deepak C Shetty wrote:
Hi All,
I was looking at virsh attach-disk and i see the below
[snip]
DESCRIPTION
Attach new disk device.
OPTIONS
[--domain] string domain name, id or uuid
[--source] string source of disk device
[--target]
Jim Fehlig wrote:
Jim Fehlig wrote:
Laine Stump wrote:
On 04/10/2013 05:10 AM, Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
This can be useful for route or NAT networks, or any other
Peter Maydell peter.mayd...@linaro.org writes:
On 22 May 2013 14:15, Anthony Liguori aligu...@us.ibm.com wrote:
Paolo Bonzini pbonz...@redhat.com writes:
You
don't need to know what targets were supported in the version that you
compiled from. Only one target is supported in this executable
Jim Fehlig wrote:
Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
---
src/libxl/libxl_conf.c | 72
++
src/libxl/libxl_conf.h | 2 ++
2 files changed, 74 insertions(+)
Marek Marczykowski wrote:
For now only for PCI devices. Mostly copy-paste from old xen driver.
This one is (or will be) covered by Chanyan's work as well right?
Regards,
Jim
---
src/libxl/libxl_driver.c | 193
+++
1 file changed, 193
Il 22/05/2013 16:29, Anthony Liguori ha scritto:
Peter Maydell peter.mayd...@linaro.org writes:
On 22 May 2013 14:15, Anthony Liguori aligu...@us.ibm.com wrote:
Paolo Bonzini pbonz...@redhat.com writes:
You
don't need to know what targets were supported in the version that you
compiled
On 05/22/2013 05:37 AM, Ján Tomko wrote:
Don't free the stream on error if we've successfully added it
to the hash table, since it will be freed by virChrdevHashEntryFree
callback.
Preserve the error message before calling virStreamFree, since it
resets the error.
Reported by Sergey
Marek Marczykowski wrote:
On 19.04.2013 13:10, Stefano Stabellini wrote:
On Thu, 11 Apr 2013, Marek Marczykowski wrote:
On 11.04.2013 09:52, Ian Campbell wrote:
On Thu, 2013-04-11 at 05:09 +0100, Jim Fehlig wrote:
+/* This will fill xenstore info about free and
Marek Marczykowski wrote:
At least Xen supports backend drivers in another domain (aka driver
domain). This patch introduces XML config option for such setting as
'domain' element with 'name' attribute. Verification its content is left
for the driver.
In the future some option will be needed
On 2013年05月22日 04:01, Anthony Liguori wrote:
Daniel P. Berrange berra...@redhat.com writes:
On Tue, May 21, 2013 at 11:12:26AM -0600, Eric Blake wrote:
I have also argued in the past that it would be useful for libvirt to
support the idea of a template, where you can specify a domain XML that
On 21.05.2013 18:37, Laine Stump wrote:
On 05/21/2013 10:18 AM, Michal Privoznik wrote:
In order to learn libvirt multiqueue several things must be done:
1) The '/dev/net/tun' device needs to be opened multiple times with
IFF_MULTI_QUEUE flag passed to ioctl(fd, TUNSETIFF, ifr);
2) Similar,
In my previous patches I enabled the IFF_MULTI_QUEUE flag every
time the user requested multiqueue TAP device. However, this
works only at runtime. During build time the flag may be
undeclared.
---
src/util/virnetdevtap.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
On 05/21/2013 11:24 PM, Eric Blake wrote:
Since neither getpwuid_r() nor initgroups() are safe to call in
between fork and exec (they obtain a mutex, but if some other
thread in the parent also held the mutex at the time of the fork,
the child will deadlock), we have to split out the
On 05/22/2013 10:37 AM, Michal Privoznik wrote:
In my previous patches I enabled the IFF_MULTI_QUEUE flag every
time the user requested multiqueue TAP device. However, this
works only at runtime. During build time the flag may be
undeclared.
---
src/util/virnetdevtap.c | 9 -
1
On 22.05.2013 18:50, Eric Blake wrote:
On 05/22/2013 10:37 AM, Michal Privoznik wrote:
In my previous patches I enabled the IFF_MULTI_QUEUE flag every
time the user requested multiqueue TAP device. However, this
works only at runtime. During build time the flag may be
undeclared.
---
On 05/22/2013 10:49 AM, Laine Stump wrote:
On 05/21/2013 11:24 PM, Eric Blake wrote:
Since neither getpwuid_r() nor initgroups() are safe to call in
between fork and exec (they obtain a mutex, but if some other
thread in the parent also held the mutex at the time of the fork,
the child will
On 21.05.2013 01:20, Eric Blake wrote:
On 05/20/2013 11:55 AM, Michal Privoznik wrote:
For future work we need _virDomainEventGraphicsAddress and
_virDomainEventGraphicsSubjectIdentity members to be char * not
const char *. We are strdup()ing them anyway, so they should have
been char *
On Wed, 22 May 2013, Jim Fehlig wrote:
Marek Marczykowski wrote:
On 19.04.2013 13:10, Stefano Stabellini wrote:
On Thu, 11 Apr 2013, Marek Marczykowski wrote:
On 11.04.2013 09:52, Ian Campbell wrote:
On Thu, 2013-04-11 at 05:09 +0100, Jim Fehlig wrote:
+
On 05/21/2013 11:24 PM, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=964358
POSIX states that multi-threaded apps should not use functions
that are not async-signal-safe between fork and exec, yet we
were using getpwuid_r and initgroups. Although rare, it is
possible to hit
It seems that if we want to have the release at the end of the month
we ought to enter freeze next Monday the 27 for a release on the 3rd
(I may have a hard time making the release on Friday 31 or w.e.).
Is there any problem with freezing next Monday ? If not let's proceed
that way, in that case
On 05/20/2013 11:55 AM, Michal Privoznik wrote:
---
src/qemu/qemu_capabilities.c | 79 +++-
src/qemu/qemu_cgroup.c | 4 +-
src/qemu/qemu_command.c | 428
+--
src/qemu/qemu_conf.c | 64 +++
src/qemu/qemu_domain.c
On 05/20/2013 11:55 AM, Michal Privoznik wrote:
---
src/remote/remote_driver.c | 114
+
1 file changed, 44 insertions(+), 70 deletions(-)
@@ -497,24 +497,21 @@ doRemoteOpen(virConnectPtr conn,
...
if (conn-uri conn-uri-user
-
On 05/21/2013 09:15 PM, Zhang Xiaohe wrote:
Don't print 'OPTION' if there's no options. Just behaves as DESCRIPTION
does.
This mostly affects 'interface' command group.
Signed-off-by: Zhang Xiaohe zhan...@cn.fujitsu.com
Reported-by: Li Yang liyang.f...@cn.fujitsu.com
---
tools/virsh.c |
Hi,
We run nvidia devices inside libvirt-managed LXC containers.
It used to be that simply doing:
$ echo 'c 195:* rwm' /sys/fs/cgroup/devices/libvirt/lxc
Then, after booting the container, we would do:
$ mknod -m 666 /dev/nvidia0 c 195 0
would be good enough to run our CUDA
On 05/20/2013 11:55 AM, Michal Privoznik wrote:
---
src/rpc/gendispatch.pl | 21
src/rpc/virnetclient.c | 16 -
src/rpc/virnetmessage.c | 27 +--
src/rpc/virnetsaslcontext.c | 6 ++--
src/rpc/virnetserver.c | 6 ++--
I tested on 1.0.5 patched version and vm with 2 vfs working fine.
I have another problem
When i set max_vfs=63:
internal error missing IFLA_VF_INFO in netlink response
Its working when max_vfs=31
--
Dominik
21 maj 2013 15:19, Dominik Mostowiec dominikmostow...@gmail.com
napisał(a):
Hmm,
It
On 05/20/2013 11:55 AM, Michal Privoznik wrote:
---
src/security/security_apparmor.c | 20 ++
src/security/security_dac.c | 21 +++
src/security/security_nop.c | 7 +---
src/security/security_selinux.c | 79
+++-
One theory I had was that the virDomainObjListSearchName method could
be a bottleneck, becaue that acquires a lock on every single VM. This
is invoked when starting a VM, when we call virDomainObjListAddLocked.
I tried removing this locking though didn't see any performance
On 22.05.2013 16:36, Jim Fehlig wrote:
Marek Marczykowski wrote:
For now only for PCI devices. Mostly copy-paste from old xen driver.
This one is (or will be) covered by Chanyan's work as well right?
Right.
Regards,
Jim
---
src/libxl/libxl_driver.c | 193
On 22.05.2013 16:33, Jim Fehlig wrote:
Jim Fehlig wrote:
Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
---
src/libxl/libxl_conf.c | 72
++
src/libxl/libxl_conf.h | 2 ++
2 files
On 22.05.2013 18:58, Stefano Stabellini wrote:
On Wed, 22 May 2013, Jim Fehlig wrote:
Marek Marczykowski wrote:
On 19.04.2013 13:10, Stefano Stabellini wrote:
On Thu, 11 Apr 2013, Marek Marczykowski wrote:
On 11.04.2013 09:52, Ian Campbell wrote:
On Thu, 2013-04-11 at 05:09
The same issue as (already fixed) in virDomainCreate -
REMOTE_PROC_DOMAIN_CREATE_WITH_FLAGS doesn't return new domain ID, only
-1 on error or 0 on success.
Besides this one fix it is more general problem - local domain object
ID can desynchronize with the real one, for example in case of another
于 2013年05月23日 06:19, Eric Blake 写道:
On 05/21/2013 09:15 PM, Zhang Xiaohe wrote:
Don't print 'OPTION' if there's no options. Just behaves as DESCRIPTION
does.
This mostly affects 'interface' command group.
Signed-off-by: Zhang Xiaohezhan...@cn.fujitsu.com
Reported-by: Li
container will create /dev/pts directory in /dev.
the owner of /dev should be the root user of container.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/lxc/lxc_controller.c
Otherwise we will fail to mount the meminfo file.
This patch also allows any users to access the
fuse mount point.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_fuse.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/lxc/lxc_fuse.c b/src/lxc/lxc_fuse.c
index
Make sure the mapping line contains the root user of container
is the first element of idmap array. So we can get the real
user id on host for the container easily.
This patch also check the map information, User must map
the root user of container to any user of host.
Signed-off-by: Gao feng
Since these tty devices will be used by container,
the owner of them should be the root user of container.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 43 +--
1 file changed, 37 insertions(+), 6 deletions(-)
diff --git
This two files are created for container,
the owner should be the root user of container.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/src/lxc/lxc_controller.c
User namespace will be enabled only when the idmap exist
in configuration.
If you want disable user namespace,just remove these
elements from XML.
If kernel doesn't support user namespace and idmap exist
in configuration file, libvirt lxc will start failed and
return Kernel doesn't support user
This patchset try to add userns support for libvirt lxc.
Since userns is nearly completed in linux-3.9, the old
kernel doesn't support userns, I add some New XML elements
to let people decide if enable userns.The userns is enabled
only when user configure the XML.
The format of user namespace
Make codes clearer and reduce some virAsprintf.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 44 +++-
1 file changed, 19 insertions(+), 25 deletions(-)
diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index
user namespace doesn't allow to create devices in
uninit userns. We should create devices on host side.
We first mount tmpfs on dev directroy under state dir
of container. then create devices under this dev dir.
Finally in container, mount the dev directroy created
on host to the /dev/ directroy
This patch introduces new helper function
virLXCControllerSetupUserns, in this function,
we set the files uid_map and gid_map of the init
task of container.
lxcContainerSetID is used for creating cred for
tasks running in container. Since after setuid/setgid,
we may be a new user. This patch
use virLXCControllerChown to make codes clearer.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 81 ++--
1 file changed, 31 insertions(+), 50 deletions(-)
diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
Since these devices are created for the container.
the owner should be the root user of the container.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/lxc/lxc_controller.c
This patch introduces new element idmap for
user namespace. for example
idmap
uid start='0' target='1000' count='10'/
gid start='0' target='1000' count='10'/
/idmap
this new element is used for setting proc files
/proc/pid/{uid_map,gid_map}.
This patch also supports multiple uid/gid
Hi!
- Ursprüngliche Mail -
Since these tty devices will be used by container,
the owner of them should be the root user of container.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 43
+--
1 file changed, 37
Hi!
- Ursprüngliche Mail -
Since these devices are created for the container.
the owner should be the root user of the container.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 14 ++
1 file changed, 14 insertions(+)
diff --git
Hi!
- Ursprüngliche Mail -
This two files are created for container,
the owner should be the root user of container.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 30 ++
1 file changed, 30 insertions(+)
diff --git
72 matches
Mail list logo
