On 07/23/2013 04:56 PM, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 10:47:46AM -0400, John Ferlan wrote:
On 07/23/2013 10:18 AM, Ján Tomko wrote:
On 07/22/2013 10:31 PM, John Ferlan wrote:
---
src/storage/storage_backend_iscsi.c | 111
+++-
1 file
Both virStoragePoolFree and virStorageVolFree reset the last error,
which might lead to the cryptic message:
An error occurred, but the cause is unknown
When the volume wasn't found, virStorageVolFree was called with NULL,
leading to an error:
invalid storage volume pointer in virStorageVolFree
As we do for other errors with an extra string.
---
src/util/virerror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virerror.c b/src/util/virerror.c
index b92c6d1..ca25678 100644
--- a/src/util/virerror.c
+++ b/src/util/virerror.c
@@ -730,7 +730,7 @@
On 24.05.2013 22:25, Martin Kletzander wrote:
Parsing 'user:group' is useful even outside the DAC security driver,
so expose the most abstract function which has no DAC security driver
bits in itself.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/libvirt_private.syms|
On 24.05.2013 22:25, Martin Kletzander wrote:
There were some places in the code, where files were being opened with
uid:gid of the daemon instead of the qemu process related to the file.
First patch exposes the parseIds() function in order for it to be used
somewhere else in the code than
On 07/24/2013 04:43 PM, Ján Tomko wrote:
Both virStoragePoolFree and virStorageVolFree reset the last error,
which might lead to the cryptic message:
An error occurred, but the cause is unknown
When the volume wasn't found, virStorageVolFree was called with NULL,
leading to an error:
invalid
On 24.07.2013 10:47, Ján Tomko wrote:
As we do for other errors with an extra string.
---
src/util/virerror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virerror.c b/src/util/virerror.c
index b92c6d1..ca25678 100644
--- a/src/util/virerror.c
+++
On 24/07/13 16:25, Ján Tomko wrote:
On 07/23/2013 04:56 PM, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 10:47:46AM -0400, John Ferlan wrote:
On 07/23/2013 10:18 AM, Ján Tomko wrote:
On 07/22/2013 10:31 PM, John Ferlan wrote:
---
src/storage/storage_backend_iscsi.c | 111
https://bugzilla.redhat.com/show_bug.cgi?id=981094
The commit 0ad9025ef introduce qemu flag QEMU_CAPS_DEVICE_VIDEO_PRIMARY
for using -device VGA, -device cirrus-vga, -device vmware-svga and
-device qxl-vga. In use, for -device qxl-vga, mouse doesn't display
in guest window like the desciption in
On Tue, Jul 23, 2013 at 05:02:54PM -0600, Eric Blake wrote:
On 07/18/2013 07:27 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Doing DBus method calls using libdbus.so is tedious in the
extreme. systemd developers came up with a nice high level
API for DBus
On Tue, Jul 23, 2013 at 10:22:23PM -0600, Eric Blake wrote:
On 07/15/2013 03:04 PM, Richard W.M. Jones wrote:
On Mon, Jul 15, 2013 at 05:57:12PM +0800, Fam Zheng wrote:
Hi all,
QEMU-KVM BZ 955734, and libvirt BZ 905125 are about feature Read-only
point-in-time throwaway snapshot. The
Il 24/07/2013 07:38, Wenchao Xia ha scritto:
Because libvirt would use a local (Unix) socket to communicate with QEMU
and pass the file descriptor, there is no need to authenticate the NBD
connection. There is no need for ticketing, though if necessary we can
make QEMU only accept
Both virStoragePoolFree and virStorageVolFree reset the last error,
which might lead to the cryptic message:
An error occurred, but the cause is unknown
When the volume wasn't found, virStorageVolFree was called with NULL,
leading to an error:
invalid storage volume pointer in virStorageVolFree
On Tue, Jul 23, 2013 at 09:40:56PM -0600, Eric Blake wrote:
[replying with useful information from another off-list email]
On 07/15/2013 03:04 PM, Richard W.M. Jones wrote:
On Mon, Jul 15, 2013 at 05:57:12PM +0800, Fam Zheng wrote:
Hi all,
QEMU-KVM BZ 955734, and libvirt BZ 905125 are
On Wed, Jul 24, 2013 at 11:12:18AM +0800, Osier Yang wrote:
On 24/07/13 01:11, Paolo Bonzini wrote:
Il 23/07/2013 18:47, John Ferlan ha scritto:
On 07/23/2013 12:18 PM, Paolo Bonzini wrote:
Il 23/07/2013 18:01, Daniel P. Berrange ha scritto:
On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo
On Wed, Jul 24, 2013 at 10:25:06AM +0200, Ján Tomko wrote:
On 07/23/2013 04:56 PM, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 10:47:46AM -0400, John Ferlan wrote:
On 07/23/2013 10:18 AM, Ján Tomko wrote:
On 07/22/2013 10:31 PM, John Ferlan wrote:
---
On Tue, Jul 23, 2013 at 06:18:14PM -0400, Laine Stump wrote:
On 07/23/2013 11:24 AM, Daniel P. Berrange wrote:
I'm thinking that it would probably be better to move all the re-indented
code out into a qemuValidateDevicePCISlotsPIIX3() and just call that
function from
On Tue, Jul 23, 2013 at 07:28:38PM +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 17:32:42 +0100, Daniel Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote:
---
src/qemu/qemu_monitor.c| 21 +++
src/qemu/qemu_monitor.h
On Tue, Jul 23, 2013 at 05:14:20PM -0600, Eric Blake wrote:
dbus 1.2.24 (on RHEL 6) lacks DBUS_TYPE_UNIX_FD; but as we aren't
trying to pass one of those anyways, we can just drop support for
it in our wrapper. Solves this build error:
CC libvirt_util_la-virdbus.lo
On Wed, Jul 24, 2013 at 10:51:35AM +0100, Daniel P. Berrange wrote:
I'm wondering if we could instead try to utilize the virStreamPtr
APIs for this task. From a libvirt's RPC POV this much more efficient
because once you open the region with a stream API, you don't have any
round trips at all
There's a race in lxc driver causing a deadlock. If a domain is
destroyed immediately after started, the deadlock can occur. When domain
is started, the even loop tries to connect to the monitor. If the
connecting succeeds, virLXCProcessMonitorInitNotify() is called with
@mon-client locked. The
On Wed, Jul 24, 2013 at 11:12:01AM +0100, Richard W.M. Jones wrote:
On Wed, Jul 24, 2013 at 10:51:35AM +0100, Daniel P. Berrange wrote:
I'm wondering if we could instead try to utilize the virStreamPtr
APIs for this task. From a libvirt's RPC POV this much more efficient
because once you
Il 24/07/2013 11:54, Daniel P. Berrange ha scritto:
but anyway, we provide good enough documentations, so if one wants to
use direct mode, he can still change the xml to use it, any big problems
here? though defaulting to direct is more convenient for these users.
Defaulting to direct is
On Wed, Jul 24, 2013 at 12:15:32PM +0200, Michal Privoznik wrote:
There's a race in lxc driver causing a deadlock. If a domain is
destroyed immediately after started, the deadlock can occur. When domain
is started, the even loop tries to connect to the monitor. If the
connecting succeeds,
On Wed, Jul 24, 2013 at 12:25:17PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 11:54, Daniel P. Berrange ha scritto:
but anyway, we provide good enough documentations, so if one wants to
use direct mode, he can still change the xml to use it, any big problems
here? though defaulting to direct
Il 24/07/2013 12:31, Daniel P. Berrange ha scritto:
On Wed, Jul 24, 2013 at 12:25:17PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 11:54, Daniel P. Berrange ha scritto:
but anyway, we provide good enough documentations, so if one wants to
use direct mode, he can still change the xml to use it,
On Wed, Jul 24, 2013 at 12:37:10PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 12:31, Daniel P. Berrange ha scritto:
On Wed, Jul 24, 2013 at 12:25:17PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 11:54, Daniel P. Berrange ha scritto:
but anyway, we provide good enough documentations, so if one
Il 24/07/2013 12:39, Daniel P. Berrange ha scritto:
On Wed, Jul 24, 2013 at 12:37:10PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 12:31, Daniel P. Berrange ha scritto:
breaking the default config for QEMU's without iSCSI support.
Understood, that's why I suggested not having a default config
On Wed, Jul 24, 2013 at 12:41:49PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 12:39, Daniel P. Berrange ha scritto:
On Wed, Jul 24, 2013 at 12:37:10PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 12:31, Daniel P. Berrange ha scritto:
breaking the default config for QEMU's without iSCSI support.
Il 24/07/2013 12:46, Daniel P. Berrange ha scritto:
On Wed, Jul 24, 2013 at 12:41:49PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 12:39, Daniel P. Berrange ha scritto:
On Wed, Jul 24, 2013 at 12:37:10PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 12:31, Daniel P. Berrange ha scritto:
breaking
On Wed, Jul 24, 2013 at 12:59:27PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 12:46, Daniel P. Berrange ha scritto:
On Wed, Jul 24, 2013 at 12:41:49PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 12:39, Daniel P. Berrange ha scritto:
On Wed, Jul 24, 2013 at 12:37:10PM +0200, Paolo Bonzini
Define an new API virDomainInterfacesAddresses, which returns
the address information of a running domain's interfaces(s).
If no interface name is specified, it returns the information
of all interfaces, otherwise it only returns the information
of the specificed interface. The address information
On Tue, Jul 23, 2013 at 03:58:30PM -0600, Eric Blake wrote:
On 07/23/2013 09:21 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Add protection such that the virCgroupRemove and
virCgroupKill* do not do anything to the root cgroup.
Killing all PIDs in the
By querying the qemu guest agent with the QMP command
guest-network-get-interfaces and converting the received
JSON output to structured objects.
src/qemu/qemu_agent.h:
* Define qemuAgentGetInterfaces
src/qemu/qemu_agent.c:
* Implement qemuAgentGetInterface
src/qemu/qemu_driver.c:
* New
Use virDomainInterfacesAddresses in virsh
tools/virsh-domain-monitor.c
* Introduce new command : domifaddr
Example Usage: domifaddr domain-name interface-name (optional)
tools/virsh.pod
* Document new command
---
tools/virsh-domain-monitor.c | 103
This feature has been requested for a very long time. Since qemu guest
agent gives us reliable results, now the wait is over.
The RFC was first proposed by Michal Privoznik:
http://www.mail-archive.com/libvir-list@redhat.com/msg51857.html
A patch was submitted, using structs:
Implement RPC calls for virDomainInterfacesAddresses
daemon/remote.c
* Define remoteSerializeDomainInterfacePtr,
remoteDispatchDomainInterfacesAddresses
src/remote/remote_driver.c
* Define remoteDomainInterfacesAddresses
src/remote/remote_protocol.x
* New RPC procedure:
Expose virDomainInterfacesAddresses to python binding
examples/python/Makefile.am:
* Add new file domipaddrs.py
examples/python/README:
* Add documentation for the python example
python/libvirt-override-api.xml:
* Add new symbol for virDomainInterfacesAddresses
python/libvirt-override.c:
Il 24/07/2013 13:03, Daniel P. Berrange ha scritto:
Can you make the pool active, but at the same time not expose it as
devices on the host? LUNs can be discovered by talking directly to the
target (similar to the iscsi-ls command included with libiscsi).
I've never considered that
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the libxlMakeChrdevStr function
which was deleted in commit dfa1e1dd.
Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com
---
Changes since V3:
implicity forbit dev_name pass to libxl driver.
On 24.07.2013 12:29, Daniel P. Berrange wrote:
On Wed, Jul 24, 2013 at 12:15:32PM +0200, Michal Privoznik wrote:
There's a race in lxc driver causing a deadlock. If a domain is
destroyed immediately after started, the deadlock can occur. When domain
is started, the even loop tries to connect
On 23.07.2013 23:20, Jim Fehlig wrote:
One comment below in addition to Konrad's...
Konrad Rzeszutek Wilk wrote:
On Mon, Jul 22, 2013 at 12:51:05PM +0200, Stefan Bader wrote:
This fixes the basic setup but there is likely more to do if things
like manual CPU hirarchy (nodes, cores,
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the libxlMakeChrdevStr function
which was deleted in commit dfa1e1dd.
Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com
---
Changes since V3:
implicity forbit dev_name pass to libxl driver due
On Wed, Jul 24, 2013 at 01:43:02PM +0200, Michal Privoznik wrote:
On 24.07.2013 12:29, Daniel P. Berrange wrote:
On Wed, Jul 24, 2013 at 12:15:32PM +0200, Michal Privoznik wrote:
There's a race in lxc driver causing a deadlock. If a domain is
destroyed immediately after started, the
Otherwise libvirtd fails to load the lockd plugin.
---
src/libvirt_private.syms | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 5a5d112..526010f 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1095,8
On 07/24/13 14:02, Ján Tomko wrote:
Otherwise libvirtd fails to load the lockd plugin.
---
src/libvirt_private.syms | 3 +++
1 file changed, 3 insertions(+)
Oops :/
Ack.
Peter
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
virCgroupAvailable() implementation calls getmntent_r
without checking if HAVE_GETMNTENT_R is defined, so it fails
to build on platforms without getmntent_r support.
Make virCgroupAvailable() just return false without
HAVE_GETMNTENT_R.
---
src/util/vircgroup.c | 4 +++-
1 file changed, 3
On Wed 24 Jul 2013 10:56:56 AM CEST, Michal Privoznik wrote:
On 24.05.2013 22:25, Martin Kletzander wrote:
There were some places in the code, where files were being opened with
uid:gid of the daemon instead of the qemu process related to the file.
First patch exposes the parseIds() function
link_addr detection in configure always reports that
link_addr is missing because it uses link_addr(NULL, NULL) in
AC_LINK_IFELSE check with limited set of headers that doesn't
define NULL.
Fix by replacing 'NULL' with just '0'.
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1
于 2013-7-24 17:44, Paolo Bonzini 写道:
Il 24/07/2013 07:38, Wenchao Xia ha scritto:
Because libvirt would use a local (Unix) socket to communicate with QEMU
and pass the file descriptor, there is no need to authenticate the NBD
connection. There is no need for ticketing, though if necessary we
On 07/24/2013 03:02 PM, Roman Bogorodskiy wrote:
link_addr detection in configure always reports that
link_addr is missing because it uses link_addr(NULL, NULL) in
AC_LINK_IFELSE check with limited set of headers that doesn't
s/doesn't/don't/
define NULL.
Fix by replacing 'NULL' with just
On 07/24/2013 02:30 PM, Roman Bogorodskiy wrote:
virCgroupAvailable() implementation calls getmntent_r
without checking if HAVE_GETMNTENT_R is defined, so it fails
to build on platforms without getmntent_r support.
Make virCgroupAvailable() just return false without
HAVE_GETMNTENT_R.
---
On 07/24/2013 11:22 AM, Michal Privoznik wrote:
On 24.07.2013 10:47, Ján Tomko wrote:
As we do for other errors with an extra string.
---
src/util/virerror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK
Thanks, pushed.
Jan
--
libvir-list mailing list
On 07/24/2013 02:08 PM, Peter Krempa wrote:
On 07/24/13 14:02, Ján Tomko wrote:
Otherwise libvirtd fails to load the lockd plugin.
---
src/libvirt_private.syms | 3 +++
1 file changed, 3 insertions(+)
Oops :/
Ack.
Thanks, now pushed.
Jan
--
libvir-list mailing list
Martin Kletzander wrote:
On 07/24/2013 03:02 PM, Roman Bogorodskiy wrote:
link_addr detection in configure always reports that
link_addr is missing because it uses link_addr(NULL, NULL) in
AC_LINK_IFELSE check with limited set of headers that doesn't
s/doesn't/don't/
doesn't was
Stefan Bader wrote:
On 23.07.2013 23:20, Jim Fehlig wrote:
[...]
You are using the driver-wide libxl_ctx in libxlDriverPrivate here, but
should be using the per-domain libxl_ctx in libxlDomainObjPrivate
structure IMO.
It looks like libxlBuildDomainConfig, which calls
On Tue, Jul 23, 2013 at 05:19:03PM +0100, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:35PM +0200, Jiri Denemark wrote:
Since QEMU and kvm may filter some host CPU features or add efficiently
emulated features, asking QEMU binary for host CPU data provides
better results when we
On Tue, Jul 23, 2013 at 07:32:46PM +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 19:28:38 +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 17:32:42 +0100, Daniel Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote:
---
src/qemu/qemu_monitor.c
On Wed, Jul 24, 2013 at 11:03:03AM +0100, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 07:28:38PM +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 17:32:42 +0100, Daniel Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote:
---
[Problem]
Currently, guest OS's messages can be logged to a local disk of host OS
by creating chadevs with options below.
-chardev file,id=charserial0,path=log file's path -device
isa-serial,chardev=chardevserial0,id=serial0
When a hardware failure happens in the disk, qemu-kvm can't create
On 07/24/2013 05:57 AM, Daniel P. Berrange wrote:
On Wed, Jul 24, 2013 at 10:25:06AM +0200, Ján Tomko wrote:
...snip...
Both secret and qemu drivers are registered after the storage driver on
libvirtd startup, so autostarting these pools will only work on storage
driver
reload. On libvirtd
[adding qemu-devel]
On 07/24/2013 03:41 AM, Guannan Ren wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=981094
The commit 0ad9025ef introduce qemu flag QEMU_CAPS_DEVICE_VIDEO_PRIMARY
for using -device VGA, -device cirrus-vga, -device vmware-svga and
-device qxl-vga. In use, for -device
On 07/24/2013 03:47 AM, Ján Tomko wrote:
Both virStoragePoolFree and virStorageVolFree reset the last error,
which might lead to the cryptic message:
An error occurred, but the cause is unknown
When the volume wasn't found, virStorageVolFree was called with NULL,
leading to an error:
Bamvor Jian Zhang wrote:
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the libxlMakeChrdevStr function
which was deleted in commit dfa1e1dd.
Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com
---
Changes since V3:
implicity forbit
On 07/24/2013 04:15 AM, Michal Privoznik wrote:
There's a race in lxc driver causing a deadlock. If a domain is
destroyed immediately after started, the deadlock can occur. When domain
is started, the even loop tries to connect to the monitor. If the
s/even/event/
connecting succeeds,
On 06/17/2013 04:40 AM, Sandro Bonazzola wrote:
Fixed virConnect destructor checking for attribute
existance before trying to use it.
s/existance/existence/
Avoids:
Exception AttributeError: AttributeError(virConnect instance has no
attribute 'domainEventCallbacks',) in bound method
since sizeof(size_t) != sizeof(long long) on 32bit archs.
This unbreaks virdbustest which otherwise fails like:
(gdb) bt
#0 __strlen_sse2_bsf () at ../sysdeps/i386/i686/multiarch/strlen-sse2-bsf.S:50
#1 0x405907d2 in ?? () from /lib/i386-linux-gnu/libdbus-1.so.3
#2 0x4057c140 in ?? ()
On 07/22/2013 08:48 AM, Ján Tomko wrote:
Check if PCI bridges with duplicate indexes are rejected.
PCI root controllers with non-zero indexes or addresses should
also be rejected.
---
.../qemuxml2argv-pci-bridge-duplicate-index.xml | 16
Hi,
I am new to libvirt and I am trying to compile libvirt from the git
repository. I mainly plan to use it for managing ESX server. However I get
the following error during make.
*libvirt undefined reference to virNetTLSInit*
Here are the steps which I took.
1. Get the code. git clone
On 07/24/2013 03:29 PM, Guido Günther wrote:
since sizeof(size_t) != sizeof(long long) on 32bit archs.
This unbreaks virdbustest which otherwise fails like:
+++ b/tests/virdbustest.c
@@ -195,7 +195,7 @@ static int testMessageArray(const void *args
ATTRIBUTE_UNUSED)
if
On 07/22/2013 08:52 AM, Ján Tomko wrote:
Reindent them to put the input volume on a separate line.
---
tests/storagevolxml2argvtest.c | 64
+-
1 file changed, 44 insertions(+), 20 deletions(-)
diff --git a/tests/storagevolxml2argvtest.c
On 07/22/2013 08:52 AM, Ján Tomko wrote:
Reuse the pool definition from storagepoolxml2xmlin.
---
tests/storagevolxml2argvdata/pool-dir.xml | 18 --
tests/storagevolxml2argvtest.c| 2 +-
2 files changed, 1 insertion(+), 19 deletions(-)
delete mode 100644
On 07/22/2013 08:52 AM, Ján Tomko wrote:
Reuse the XML files in storagevolxml2xmlin.
(This requires changing a few backing files to /dev/null,
since virStorageBackendCreateQemuImgCmd checks for its
presence)
Fair enough; it's a bit annoying that we rely on the actual file system,
but
On 07/22/2013 08:53 AM, Ján Tomko wrote:
This allows testing the command line for cloning file-based
volumes into logical volumes and vice versa.
---
.../storagevolxml2argvdata/logical-from-qcow2.argv | 2 +
.../storagevolxml2argvdata/qcow2-from-logical.argv | 2 +
Reminder, there's one week left to submit proposals for the
virtualization micro-conference at LPC. Please see below for details
and note the update to submit proposals through the Linux Plumbers
website:
http://www.linuxplumbersconf.org/2013/ocw/events/LPC2013/proposals/new
Thanks,
Alex
On
75 matches
Mail list logo
