Re: [libvirt] [Qemu-devel] Close the BlockDriverState when guest eject the media

2014-10-20 Thread Gonglei
On 2014/10/21 13:53, Weidong Huang wrote: > On 2014/10/20 19:39, Kevin Wolf wrote: > >> Am 20.10.2014 um 13:27 hat Weidong Huang geschrieben: >>> On 2014/10/20 17:41, Kevin Wolf wrote: >>> Am 18.10.2014 um 12:02 hat Weidong Huang geschrieben: > Hi ALL: > > There are two ways to e

Re: [libvirt] [Qemu-devel] spec, RFC: TLS support for NBD

2014-10-20 Thread Wouter Verhelst
On Mon, Oct 20, 2014 at 01:56:43PM +0200, Florian Weimer wrote: > I cannot comment on whether the proposed STARTTLS command is at the correct > stage of the NBD protocol. If there is a protocol description for NBD, I > can have a look. To make this discussion in that regard a bit easier, I've com

Re: [libvirt] [Qemu-devel] spec, RFC: TLS support for NBDµ

2014-10-20 Thread Wouter Verhelst
On Mon, Oct 20, 2014 at 01:51:43PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Mon, Oct 20, 2014 at 08:58:14AM +0100, Daniel P. Berrange wrote: > >> On Sat, Oct 18, 2014 at 07:33:22AM +0100, Richard W.M. Jones wrote: > >> > On Sat, Oct 18, 2014 at 12:03:23AM +0200, Wouter V

Re: [libvirt] [PATCH] Fix cast errors with clang

2014-10-20 Thread Eric Blake
On 10/18/2014 10:41 AM, Roman Bogorodskiy wrote: > Build with clang fails with: > > CC util/libvirt_util_la-virsocketaddr.lo > util/virsocketaddr.c:904:17: error: cast from 'struct sockaddr *' to > 'struct sockaddr_in *' increases required alignment from 1 to 4 > [-Werror,-Wcast-align] >

Re: [libvirt] [Qemu-devel] spec, RFC: TLS support for NBD

2014-10-20 Thread Florian Weimer
On 10/20/2014 01:51 PM, Markus Armbruster wrote: Furthermore, STARTTLS is vulnerable to active attacks: if you can get between the peers, you can make them fall back to unencrypted silently. How do you plan to guard against that? The usual way to deal with this is to use different syntax for T

Re: [libvirt] [libvirt-python v3 PATCH] Improve error output when use getTime with a nonzero flags.

2014-10-20 Thread Pavel Hrdina
On 10/20/2014 03:55 PM, Luyao Huang wrote: When give a nonzero flags to getTime, c_retval will get -1 and goto cleanup. Try to wrap the lines to 76 columns. But py_retval still is NULL,so set py_retval = VIR_PY_NONE. s/NULL,so/NULL, so/ This will make the output message more correct. er

[libvirt] [libvirt-python v3 PATCH] Improve error output when use getTime with a nonzero flags.

2014-10-20 Thread Luyao Huang
When give a nonzero flags to getTime, c_retval will get -1 and goto cleanup. But py_retval still is NULL,so set py_retval = VIR_PY_NONE. This will make the output message more correct. error will disappear: SystemError: error return without exception set v2: https://www.redhat.com/archives/libvi

Re: [libvirt] [libvirt-python v2 PATCH] Improve error output when use getTime with a nonzero flags.

2014-10-20 Thread Peter Krempa
On 10/20/14 15:06, Luyao Huang wrote: > Thanks your help and useful messages. > > This issue is so small and i just want to fix the ret = NULL with no > exception. That's why I've suggested to return VIR_PY_NONE which should fix the issue in a proper way. > > So i want to make ret = -1 and mak

Re: [libvirt] [libvirt-python v2 PATCH] Improve error output when use getTime with a nonzero flags.

2014-10-20 Thread Luyao Huang
Thanks your help and useful messages. This issue is so small and i just want to fix the ret = NULL with no exception. So i want to make ret = -1 and make the "SystemError: error return without exception set" disappear. Thanks, Luyao Huang - Original Message - From: "Peter Krempa" To:

Re: [libvirt] [Qemu-devel] spec, RFC: TLS support for NBD

2014-10-20 Thread Richard W.M. Jones
On Mon, Oct 20, 2014 at 01:56:43PM +0200, Florian Weimer wrote: > On 10/20/2014 01:51 PM, Markus Armbruster wrote: > >Furthermore, STARTTLS is vulnerable to active attacks: if you can get > >between the peers, you can make them fall back to unencrypted silently. > >How do you plan to guard against

Re: [libvirt] [Qemu-devel] spec, RFC: TLS support for NBD

2014-10-20 Thread Daniel P. Berrange
On Mon, Oct 20, 2014 at 01:51:43PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Mon, Oct 20, 2014 at 08:58:14AM +0100, Daniel P. Berrange wrote: > >> On Sat, Oct 18, 2014 at 07:33:22AM +0100, Richard W.M. Jones wrote: > >> > On Sat, Oct 18, 2014 at 12:03:23AM +0200, Wouter V

Re: [libvirt] [Qemu-devel] spec, RFC: TLS support for NBD

2014-10-20 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, Oct 20, 2014 at 08:58:14AM +0100, Daniel P. Berrange wrote: >> On Sat, Oct 18, 2014 at 07:33:22AM +0100, Richard W.M. Jones wrote: >> > On Sat, Oct 18, 2014 at 12:03:23AM +0200, Wouter Verhelst wrote: >> > > Hi all, >> > > >> > > (added rjones from nbdkit fame -

Re: [libvirt] [PATCH/RFC] Add missing delta from Ubuntu to apparmor profiles

2014-10-20 Thread Stefan Bader
On 19.10.2014 17:07, intrigeri wrote: > Hi Stefan, > > Stefan Bader wrote (19 Oct 2014 11:07:40 GMT) : >> Yeah, I actually did but it felt a bit hackish but then I am told anything >> looks >> a bit hackish when it involves autoconf. These are again against upstream >> libvirt mostly because the

Re: [libvirt] [PATCH v5 0/7] qemu: Introduce support for new the block_set_io_throttle parameters add in the version 1.7 of qemu.

2014-10-20 Thread Matthias Gatto
On Tue, Oct 7, 2014 at 1:14 PM, Matthias Gatto wrote: > This series of patches add support for bps_max, bps_rd_max, bps_wr_max, > bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions > qemuDomainSetBlockIoTune and qemuDomainGetBlockIoTune. > The last patch add support for these paramet

Re: [libvirt] spec, RFC: TLS support for NBD

2014-10-20 Thread Stefan Hajnoczi
On Mon, Oct 20, 2014 at 08:58:14AM +0100, Daniel P. Berrange wrote: > On Sat, Oct 18, 2014 at 07:33:22AM +0100, Richard W.M. Jones wrote: > > On Sat, Oct 18, 2014 at 12:03:23AM +0200, Wouter Verhelst wrote: > > > Hi all, > > > > > > (added rjones from nbdkit fame -- hi there) > > > > [I'm happy t

[libvirt] Implement quorum support.

2014-10-20 Thread Matthias Gatto
Hello, I'm implementing quorum in libvirt. I've try to follow this proposal: http://www.redhat.com/archives/libvir-list/2014-May/msg00546.html At this point I've done this: - add all the field need by quorum in _virStorageSource (nBackingStores, threshold). - handle more than one backing store in

[libvirt] [libvirt-python PATCH] Add a type check for time in libvirt_virDomainSetTime

2014-10-20 Thread Luyao Huang
When pass a number or other things to setTime,no error output,but set time to 0. Add a type check and give a clear error messages: TypeError: time must be dict Signed-off-by: Luyao Huang --- libvirt-override.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libvirt-override.c b/libvirt

Re: [libvirt] spec, RFC: TLS support for NBD

2014-10-20 Thread Daniel P. Berrange
On Sat, Oct 18, 2014 at 07:33:22AM +0100, Richard W.M. Jones wrote: > On Sat, Oct 18, 2014 at 12:03:23AM +0200, Wouter Verhelst wrote: > > Hi all, > > > > (added rjones from nbdkit fame -- hi there) > > [I'm happy to implement whatever you come up with, but I've added > Florian Weimer to CC who i

Re: [libvirt] [PATCH] tests: fix incorrect caps for shmem-invalid-size, shmem-small-size

2014-10-20 Thread Peter Krempa
On 10/17/14 18:05, Maxime Leroy wrote: > VIR_TEST_DEBUG=2 ./qemuxml2argvtest generates the following output: > > 409) QEMU XML-2-ARGV shmem-invalid-size > ... Got expected error: unsupported configuration: ivshmem device is not \ >supported with this QEMU binary > OK > 410) QEMU XML-2-ARGV

Re: [libvirt] [PATCH] conf: tests: fix virDomainNetDefFormat for vhost-user in client mode

2014-10-20 Thread Peter Krempa
On 10/17/14 18:45, Maxime Leroy wrote: > The mode attribute is required for the source element of vhost-user. Thus > virDomainNetDefFormat should always generate a xml with it, and > not only when the mode is server. > > The commit fixes the issue. And it adds a vhostuser interface in 'client' mod