[libvirt] [PATCH] docs: Add yet another libvirt based app

As announced on the list [1], Cherrypop is a management application based on libvirt. It's a decentralized cloud software with nice scaling ability. 1: https://www.redhat.com/archives/libvir-list/2015-September/msg00670.html Signed-off-by: Michal Privoznik --- @Gustav:

Re: [libvirt] [PATCH] Remove unused variables.

On Thu, 2015-09-24 at 09:35 +0200, Martin Kletzander wrote: > I was playing with coccinelle tool the other day and just for the fun of > it, I tried removing some useless things from our code. And look what > came up. No functional change, and we're down in the number of lines by > about a

Re: [libvirt] [PATCH RFC 3/7] libxl: implement virDomainInterfaceStats

On 09/23/2015 08:18 PM, Jim Fehlig wrote: > Joao Martins wrote: >> Introduce support for domainInterfaceStats API call for querying >> network interface statistics. Consequently it also enables the >> use of `virsh domifstat ` command. >> >> For getting statistics we resort to

Re: [libvirt] [libvirt-test-api][PATCHv2] Add new test case for allocPages API

On 09/22/2015 10:34 AM, Luyao Huang wrote: Signed-off-by: Luyao Huang --- cases/test_connection.conf | 10 repos/virconn/connection_allocPages.py | 84 ++ 2 files changed, 94 insertions(+) create mode 100644

Re: [libvirt] [PATCH RFC 4/7] libxl: implement virDomainBlockStats

On 09/23/2015 11:24 PM, Jim Fehlig wrote: > Joao Martins wrote: >> Introduce initial support for domainBlockStats API call that >> allow us to query block device statistics. openstack nova >> uses this API call to query block statistics, alongside >> virDomainMemoryStats and

[libvirt] [PATCH] Remove unused variables.

I was playing with coccinelle tool the other day and just for the fun of it, I tried removing some useless things from our code. And look what came up. No functional change, and we're down in the number of lines by about a hundred. Signed-off-by: Martin Kletzander ---

Re: [libvirt] [PATCH 1/6] Avoid Coverity FORWARD_NULL prior to strtok_r calls

On Wed, Sep 23, 2015 at 07:18:28PM -0400, John Ferlan wrote: > The 'strtok_r' function requires passing a NULL as the first parameter > on subsequent calls in order to ensure the code picks up where it left > off on a previous call. However, Coverity doesn't quite realize this > and points out

[libvirt] [PATCH] Remove redundand assignment

I initially added this in order to keep the code more error-prone to following additions, but it seems it's still frowned upon. Signed-off-by: Martin Kletzander --- Pushed as really, really trivial. src/qemu/qemu_domain.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [libvirt] [libvirt-test-api][PATCH] Add a new test case for setUserPassword

On 09/21/2015 03:43 PM, Luyao Huang wrote: Signed-off-by: Luyao Huang --- cases/linux_domain.conf | 22 repos/domain/set_user_passwd.py | 111 2 files changed, 133 insertions(+) create mode 100644

Re: [libvirt] [PATCH] docs: Add yet another libvirt based app

On Thu, Sep 24, 2015 at 08:13:43AM +0200, Michal Privoznik wrote: As announced on the list [1], Cherrypop is a management application based on libvirt. It's a decentralized cloud software with nice scaling ability. 1: https://www.redhat.com/archives/libvir-list/2015-September/msg00670.html

Re: [libvirt] [PATCH 6/6] qemu: Resolve Coverity RESOURCE_LEAK

On Wed, Sep 23, 2015 at 07:18:33PM -0400, John Ferlan wrote: > This seemed to be more of a false positive as for some reason Coverity > was missing the "ret < 0" goto error condition and somehow believing that > event could be overwritten. At first I thought it was just the ret != 0 > condition

Re: [libvirt] [PATCH 3/6] tests: Resolve Coverity RESOURCE_LEAK

On Wed, Sep 23, 2015 at 07:18:30PM -0400, John Ferlan wrote: > The cleanup path did not clear the reference for sk1 and sk2 > > Signed-off-by: John Ferlan > --- > tests/virnetdaemontest.c | 2 ++ > 1 file changed, 2 insertions(+) ACK Jan signature.asc Description:

Re: [libvirt] [PATCH 2/6] tests: Resolve Coverity RESOURCE_LEAK

On Wed, Sep 23, 2015 at 07:18:29PM -0400, John Ferlan wrote: > In the error path need to unref the 'caps' as well > > Signed-off-by: John Ferlan > --- > tests/qemucaps2xmltest.c | 1 + > 1 file changed, 1 insertion(+) ACK Jan signature.asc Description: Digital signature

Re: [libvirt] [PATCH 5/6] qemu: Resolve Coverity CHECKED_RETURN

On Wed, Sep 23, 2015 at 07:18:32PM -0400, John Ferlan wrote: > Coverity complains that return from virHookCall is not checked in > one place in qemuProcessStop. Since the comment notes that we cannot > stop the operation even it if fails, just added the ignore_value. > > Signed-off-by: John

Re: [libvirt] [PATCH 4/6] virsh: Resolve Coverity DEADCODE

On Wed, Sep 23, 2015 at 07:18:31PM -0400, John Ferlan wrote: > Use 'dead_error_condition' instead of 'dead_error_begin' > Just wondering - what is the difference? Doesn't dead_error_begin require a dead_error_end? > Signed-off-by: John Ferlan > --- > tools/virsh.c | 2 +- >

[libvirt] [libvirt-sandbox][PATCH] configure: Get static libs for static linking

So you wanna build libvirt-sandbox, right? And you think you have everything you need. Dang, you don't! Because we check for libz and liblzma for dynamic linking. However, libvirt-sandbox-init-qemu is linked statically. Therefore, we need to ask pkg-config to fetch us the list of libs for static

Re: [libvirt] [PATCH v2 2/4] virDomainCreateXML: Make domain definition transient

On Wed, Sep 23, 2015 at 03:00:35PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=871452 So, you want to create a domain from XML. The domain already exists in libvirt's database of domains. It's okay, because name and UUID matches. However, on domain startup,

Re: [libvirt] [PATCH v2 0/4] Couple of 'virsh create' fixes

On Wed, Sep 23, 2015 at 03:00:33PM +0200, Michal Privoznik wrote: And this time 'virsh restore' too. The diff to v1 is that more drivers is fixed. Michal Privoznik (4): virDomainCreateXML: Don't remove persistent domains on error virDomainCreateXML: Make domain definition transient qemu:

Re: [libvirt] [PATCH v2 3/4] qemu: Move vm->persistent check into qemuDomainRemoveInactive

On Wed, Sep 23, 2015 at 03:00:36PM +0200, Michal Privoznik wrote: So far we have the following pattern occurring over and over again: if (!vm->persistent) qemuDomainRemoveInactive(driver, vm); You could've done that earlier so you would save some lines in the patches before. Anyway,

Re: [libvirt] [libvirt-sandbox][PATCH] configure: Get static libs for static linking

On Thu, Sep 24, 2015 at 10:42:20AM +0200, Michal Privoznik wrote: > So you wanna build libvirt-sandbox, right? And you think you have > everything you need. Dang, you don't! Because we check for libz > and liblzma for dynamic linking. However, > libvirt-sandbox-init-qemu is linked statically.

Re: [libvirt] [PATCH] Use daemon log facility for journald

On Wed, Sep 23, 2015 at 08:13:02PM +0200, Guido Günther wrote: > otherwise messages end up in /var/log/kern.log if journald forwards to > syslog. > > Closes: #799633 Please use the full URL: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=799633 > --- > src/util/virlog.c | 1 + > 1 file

Re: [libvirt] [libvirt-test-api][PATCH 2/2] Add a new test case for fsinfo API

On 09/14/2015 11:43 AM, Luyao Huang wrote: Signed-off-by: Luyao Huang --- cases/linux_domain.conf | 10 + repos/domain/fsinfo.py | 103 2 files changed, 113 insertions(+) create mode 100644 repos/domain/fsinfo.py

[libvirt] [libvirt-python PATCH 01/23] update virDomainGetVcpus xml API description

Python api returns a tuple with the vcpus information. Signed-off-by: Pavel Hrdina --- libvirt-override-api.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-override-api.xml b/libvirt-override-api.xml index d1a9c26..1a0e314 100644 ---

[libvirt] [libvirt-python PATCH 11/23] Return correct python object

In case of error without setting an python exception we need to return a correct python object. For functions that returns anything else than a number the return value is 'None', otherwise it's '-1'. Signed-off-by: Pavel Hrdina --- libvirt-override.c | 29

[libvirt] [libvirt-python PATCH 04/23] drop unnecessary goto

Signed-off-by: Pavel Hrdina --- libvirt-override.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 114104b..b18196f 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -476,27

Re: [libvirt] [PATCH 1/6] Avoid Coverity FORWARD_NULL prior to strtok_r calls

On 09/24/2015 04:13 AM, Ján Tomko wrote: > On Wed, Sep 23, 2015 at 07:18:28PM -0400, John Ferlan wrote: >> The 'strtok_r' function requires passing a NULL as the first parameter >> on subsequent calls in order to ensure the code picks up where it left >> off on a previous call. However,

Re: [libvirt] [PATCH 6/6] qemu: Resolve Coverity RESOURCE_LEAK

On 09/24/2015 03:45 AM, Ján Tomko wrote: > On Wed, Sep 23, 2015 at 07:18:33PM -0400, John Ferlan wrote: >> This seemed to be more of a false positive as for some reason Coverity >> was missing the "ret < 0" goto error condition and somehow believing that >> event could be overwritten. At first

Re: [libvirt] [PATCH 4/6] virsh: Resolve Coverity DEADCODE

On 09/24/2015 03:47 AM, Ján Tomko wrote: > On Wed, Sep 23, 2015 at 07:18:31PM -0400, John Ferlan wrote: >> Use 'dead_error_condition' instead of 'dead_error_begin' >> > > Just wondering - what is the difference? Perhaps just the one condition and not a set of conditions or lines? Not quite

Re: [libvirt] [PATCH] domain: Fix migratable XML with graphics/@listen

On Wed, Sep 23, 2015 at 22:48:14 +0200, Jiri Denemark wrote: > As of commit 6992994, we set graphics/@listen attribute according to the > first listen child element even if that element is of type='network'. > This was done for backward compatibility with applications which only > support the

[libvirt] [PATCH] vsh: create a noinstall libvirt_shell library

Instead of referencing vsh sources in all relevant client targets, create a library that the client can link against. --- tools/Makefile.am | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 03e9339..08aebec

[libvirt] [libvirt-python PATCH 15/23] all Py*_New function has to be checked for return value

If the function fails, we need to cleanup memory and return NULL. Signed-off-by: Pavel Hrdina --- libvirt-lxc-override.c | 10 +- libvirt-override.c | 269 + 2 files changed, 190 insertions(+), 89 deletions(-) diff --git

[libvirt] [libvirt-python PATCH 05/23] Move utils and shared code into libvirt-utils

Signed-off-by: Pavel Hrdina --- libvirt-lxc-override.c | 7 - libvirt-override.c | 413 libvirt-qemu-override.c | 7 - libvirt-utils.c | 406 +++ libvirt-utils.h

[libvirt] [libvirt-python PATCH 16/23] change the order of some statements

This change makes it easier to free allocated object especially for python objects. We can benefit from the fact, that if you call Py_DECREF on eny python object it will also remove reference for all assigned object to the root object. For example, calling Py_DECREF on dict will also remove

[libvirt] [libvirt-python PATCH 00/23] Cleanup of the libvirt-python C code

This patch series tries to cleanup the libvirt-python C code and also make it more readable. It also fixes places, where we didn't checked for return values and where we also returned wrong values in case of errors. There are some other minor issues, that I've found. Pavel Hrdina (23): update

[libvirt] [libvirt-python PATCH 09/23] wrap lines to 80 columns

Signed-off-by: Pavel Hrdina --- libvirt-override.c | 148 ++--- 1 file changed, 95 insertions(+), 53 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index cf4fedb..2a50f19 100644 --- a/libvirt-override.c +++

[libvirt] [libvirt-python PATCH 02/23] refactor the function to not override python exceptions

Signed-off-by: Pavel Hrdina --- libvirt-override.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 4dfe332..14aa0e9 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -8263,38

[libvirt] [libvirt-python PATCH 06/23] cleanup functions definition

Follow the libvirt hacking guide and make the code consistent. Signed-off-by: Pavel Hrdina --- libvirt-lxc-override.c | 3 +- libvirt-override.c | 305 +--- libvirt-qemu-override.c | 6 +- libvirt-utils.c | 25

[libvirt] [libvirt-python PATCH 19/23] utils: introduce new macro helpers for tuple, list and dict objects

Signed-off-by: Pavel Hrdina --- libvirt-utils.h | 82 + 1 file changed, 82 insertions(+) diff --git a/libvirt-utils.h b/libvirt-utils.h index 9f80133..f74654c 100644 --- a/libvirt-utils.h +++ b/libvirt-utils.h @@ -155,6

[libvirt] [libvirt-python PATCH 07/23] indent labels by one space

Signed-off-by: Pavel Hrdina --- libvirt-lxc-override.c | 2 +- libvirt-override.c | 112 libvirt-qemu-override.c | 2 +- libvirt-utils.c | 4 +- 4 files changed, 60 insertions(+), 60 deletions(-) diff --git

[libvirt] [libvirt-python PATCH 10/23] Return NULL if python exception is set

There is a rule, python API fails, it also in those cases sets an exception. We should follow those rules and in those cases return NULL. Signed-off-by: Pavel Hrdina --- libvirt-lxc-override.c | 2 +- libvirt-override.c | 143

Re: [libvirt] [PATCH v2] lxc: fuse mount for /proc/cpuinfo

On Thu, Sep 24, 2015 at 02:41:49PM +, Serge Hallyn wrote: > Quoting Fabio Kung (fabio.k...@gmail.com): > > On Wed, Sep 16, 2015 at 12:29 PM, Serge Hallyn > > wrote: > > > > > > Ok, so I could create a project on github, but that doesn't come with > > > a m-l. Last I

[libvirt] [libvirt-python PATCH 14/23] use Py_CLEAR instead of Py_XDECREF followed by NULL assignment

Signed-off-by: Pavel Hrdina --- libvirt-override.c | 69 ++ 1 file changed, 23 insertions(+), 46 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 4d0fb92..0df6844 100644 --- a/libvirt-override.c +++

[libvirt] [libvirt-python PATCH 22/23] use VIR_PY_DICT_SET_GOTO

Signed-off-by: Pavel Hrdina --- libvirt-override.c | 275 +++-- libvirt-utils.c| 13 +-- 2 files changed, 99 insertions(+), 189 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 1f795d9..3192e74

[libvirt] [libvirt-python PATCH 18/23] improve usage of cleanup paths

This removes several code duplicates and also some unusual code structures. Signed-off-by: Pavel Hrdina --- libvirt-override.c | 159 +++-- 1 file changed, 68 insertions(+), 91 deletions(-) diff --git a/libvirt-override.c

Re: [libvirt] [PATCH] vsh: create a noinstall libvirt_shell library

On Thu, Sep 24, 2015 at 03:33:25PM +0200, Erik Skultety wrote: Instead of referencing vsh sources in all relevant client targets, create a library that the client can link against. --- tools/Makefile.am | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] [PATCH] vsh: create a noinstall libvirt_shell library

>> virsh_SOURCES =\ >> -$(virt_shell_SOURCES)\ >> virsh.c virsh.h\ >> virsh-console.c virsh-console.h\ >> virsh-domain.c virsh-domain.h\ >> @@ -210,14 +224,13 @@ virsh_LDADD =

[libvirt] [libvirt-python PATCH 08/23] fix indentation

Signed-off-by: Pavel Hrdina --- libvirt-lxc-override.c | 30 ++-- libvirt-override.c | 125 ++-- libvirt-qemu-override.c | 41 typewrappers.c | 8 ++-- 4 files changed, 96 insertions(+),

[libvirt] [libvirt-python PATCH 03/23] remove useless check for NULL before Py_XDECREF

Signed-off-by: Pavel Hrdina --- libvirt-override.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 14aa0e9..114104b 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -2303,12 +2303,9 @@

[libvirt] [libvirt-python PATCH 20/23] use VIR_PY_TUPLE_GOTO

Signed-off-by: Pavel Hrdina --- libvirt-override.c | 304 +++-- 1 file changed, 155 insertions(+), 149 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 205f0dd..c2e9fb9 100644 --- a/libvirt-override.c +++

Re: [libvirt] [PATCH v2] lxc: fuse mount for /proc/cpuinfo

Quoting Fabio Kung (fabio.k...@gmail.com): > On Wed, Sep 16, 2015 at 12:29 PM, Serge Hallyn > wrote: > > > > Ok, so I could create a project on github, but that doesn't come with > > a m-l. Last I used it, sf was problematic. Any other suggestions for > > where to host

[libvirt] [libvirt-python PATCH 23/23] coverity: resolve dead_error_condition

Coverity cannot introspect the cpython code and it thinks, that if the PyTuple_New or similar will always give the same result. In functions where the python function is called more than once with the same arguments, it will assume that if the first call don't return NULL, then also the every

[libvirt] [libvirt-python PATCH 21/23] use VYR_PY_LIST_SET_GOTO and VIR_PY_LIST_APPEND_GOTO

Signed-off-by: Pavel Hrdina --- libvirt-lxc-override.c | 13 +- libvirt-override.c | 615 - 2 files changed, 350 insertions(+), 278 deletions(-) diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c index

[libvirt] [libvirt-python PATCH 13/23] Use VIR_PY_NONE instead

Signed-off-by: Pavel Hrdina --- libvirt-override.c | 9 +++-- typewrappers.c | 54 ++ 2 files changed, 21 insertions(+), 42 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index d2279de..4d0fb92

[libvirt] [libvirt-python PATCH 17/23] drop unnecessary py_retval variable

Signed-off-by: Pavel Hrdina --- libvirt-override.c | 140 - 1 file changed, 43 insertions(+), 97 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 63a469b..8afe7d7 100644 --- a/libvirt-override.c +++

[libvirt] [libvirt-python PATCH 12/23] Return NULL and set an exception if allocation fails

This is a recommended work-flow for allocation failures and we should follow it. Signed-off-by: Pavel Hrdina --- libvirt-override.c | 53 +++-- 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/libvirt-override.c

[libvirt] [PATCH 2/2] Create a shallow copy for volume building only if supported

Since the previous commit, the shallow copy is only used inside the if (backend->buildVol) if. --- src/storage/storage_driver.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index

Re: [libvirt] [PATCH v2] lxc: fuse mount for /proc/cpuinfo

Quoting Daniel P. Berrange (berra...@redhat.com): > On Thu, Sep 24, 2015 at 02:41:49PM +, Serge Hallyn wrote: > > Quoting Fabio Kung (fabio.k...@gmail.com): > > > On Wed, Sep 16, 2015 at 12:29 PM, Serge Hallyn > > > wrote: > > > > > > > > Ok, so I could create a

Re: [libvirt] [PATCH] domain: Fix migratable XML with graphics/@listen

On Thu, Sep 24, 2015 at 15:27:43 +0200, Peter Krempa wrote: > On Wed, Sep 23, 2015 at 22:48:14 +0200, Jiri Denemark wrote: > > As of commit 6992994, we set graphics/@listen attribute according to the > > first listen child element even if that element is of type='network'. > > This was done for

[libvirt] [PATCH 0/2] Update pool allocation with new values on volume creation

https://bugzilla.redhat.com/show_bug.cgi?id=1163091 Ján Tomko (2): Update pool allocation with new values on volume creation Create a shallow copy for volume building only if supported src/storage/storage_driver.c | 38 -- 1 file changed, 20

[libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

https://bugzilla.redhat.com/show_bug.cgi?id=1257844 Imagine an user who is trying to attach a disk to a domain with the following XML: The XML is obviously wrong. It's trying to attach a virtio disk onto non-PCI bus. We should forbid that. Signed-off-by: Michal

[libvirt] [PATCH 1/2] Update pool allocation with new values on volume creation

Since commit e0139e3, we update the pool allocation with the user-provided allocation values. For qcow2, the allocation is ignored for volume building, but we still subtracted it from pool's allocation. This can result in interesting values if the user-provided allocation is large enough:

Re: [libvirt] [PATCH v2] lxc: fuse mount for /proc/cpuinfo

On Thu, Sep 24, 2015 at 03:53:24PM +, Serge Hallyn wrote: > Quoting Daniel P. Berrange (berra...@redhat.com): > > On Thu, Sep 24, 2015 at 02:41:49PM +, Serge Hallyn wrote: > > > Quoting Fabio Kung (fabio.k...@gmail.com): > > > > On Wed, Sep 16, 2015 at 12:29 PM, Serge Hallyn > > > >

[libvirt] [PATCH] virsh: Preserve startupPolicy in change-media command

https://bugzilla.redhat.com/show_bug.cgi?id=1250331 Even after my rework of startupPolicy handling, one command slipped my attention. The change-media command has a very unique approach to constructing disk XML. However, it will not preserve startupPolicy attribute. Signed-off-by: Michal

Re: [libvirt] [FIRST-PATCH] updated the negation STREQ to STRNEQ

Dear Sir, The cfg.mk link isn't working for me sir.. >From what I understand Makefile will have the following: target: dependency1 dependency2 ... [TAB] action1 [TAB] action2 Does the syntax-check rule have to be in place of 'actions' in the form of a shell command, and then raise an error

Re: [libvirt] [PATCH RFC 4/7] libxl: implement virDomainBlockStats

Joao Martins wrote: > On 09/23/2015 11:24 PM, Jim Fehlig wrote: > >> Joao Martins wrote: >> [...] >>> +static int >>> +libxlDomainBlockStatsVBD(virDomainObjPtr vm, >>> + const char *dev, >>> + libxlBlockStatsPtr stats) >>> +{ >>> +int ret

Re: [libvirt] [PATCH] maint: Remove control characters from LGPL license file

On Thu, Jun 11, 2015 at 03:15:19PM +0200, Andrea Bolognani wrote: > --- > COPYING.LESSER | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > ACK :) Pavel -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC 3/7] libxl: implement virDomainInterfaceStats

Joao Martins wrote: > On 09/23/2015 08:18 PM, Jim Fehlig wrote: > >> Joao Martins wrote: >> >>> Introduce support for domainInterfaceStats API call for querying >>> network interface statistics. Consequently it also enables the >>> use of `virsh domifstat ` command. >>> >>> For getting