Re: [libvirt] OSX Homebrew support note ;)

Justin Clift wrote: > On 23 Jan 2017, at 11:38, Daniel P. Berrange wrote: > > On Wed, Dec 21, 2016 at 09:55:53AM +, Justin Clift wrote: > > > > > I'm looking at (what I hope is the correct) configuration file for the > > build: > > > >

Re: [libvirt] [PATCH v2 1/2] util: virhostdev: disallow assigning a pci-bridge to a guest

On 01/23/2017 11:34 AM, Martin Kletzander wrote: On Mon, Jan 23, 2017 at 07:06:29PM +0530, Shivaprasad G Bhat wrote: Non-endpoint devices like pci-bridges cannot be passedthrough to guests. "disallow" is a mouthful, I would also use "assigned" instead of "passedthrough". Correct -

Re: [libvirt] [PATCH 0/3] support setting MTU of libvirt networks

On 23.01.2017 16:35, Laine Stump wrote: > This has been requested several times in #virt on IRC, and on > libvirt-users, and a comment posted to > https://bugzilla.redhat.com/1224348 reminded me that there's even an > open BZ for it, so I finally sat down and wrote the patches for it. > > The

Re: [libvirt] [PATCH v2 1/2] util: virhostdev: disallow assigning a pci-bridge to a guest

On Mon, Jan 23, 2017 at 07:06:29PM +0530, Shivaprasad G Bhat wrote: Non-endpoint devices like pci-bridges cannot be passedthrough to guests. "disallow" is a mouthful, I would also use "assigned" instead of "passedthrough". Prevent such attempts. Signed-off-by: Shivaprasad G Bhat

Re: [libvirt] [PATCH v2 2/2] util: disallow resetting a pci-bridge device

On Mon, Jan 23, 2017 at 07:07:10PM +0530, Shivaprasad G Bhat wrote: It is destructive to attempt reset on a pci-bridge, the host can crash. The bridges won't contain any guest data and neither they can be passed through using vfio/stub. So, no point in allowing a reset on them. We should note

Re: [libvirt] OSX Homebrew support note ;)

On 23 Jan 2017, at 11:38, Daniel P. Berrange wrote: > On Wed, Dec 21, 2016 at 09:55:53AM +, Justin Clift wrote: > > I'm looking at (what I hope is the correct) configuration file for the > build: > >

[libvirt] [PATCH 0/3] support setting MTU of libvirt networks

This has been requested several times in #virt on IRC, and on libvirt-users, and a comment posted to https://bugzilla.redhat.com/1224348 reminded me that there's even an open BZ for it, so I finally sat down and wrote the patches for it. The idea of the patches is that an *empty* bridge device

Re: [libvirt] [PATCH go] Fix segfault in Connect.GetMemoryStats

On Mon, Jan 23, 2017 at 01:49:59AM +0300, Matvey Kruglov wrote: > --- > connect.go | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/connect.go b/connect.go > index 35eb7fd..6730171 100644 > --- a/connect.go > +++ b/connect.go > @@ -1688,7 +1688,7 @@ func (c *Connect)

[libvirt] [PATCH 1/3] util: add MTU arg to virNetDevTapCreateInBridgePort()

virNetDevTapCreateInBridgePort() has always set the new tap device to the current MTU of the bridge it's being attached to. There is one case where we will want to set the new tap device to a different (usually larger) MTU - if that's done with the very first device added to the bridge, the

[libvirt] [PATCH 2/3] conf: support mtu attribute in a network's element

Example: ... ... If mtu is unset, it's assumed that we want the default for whatever is the underlying transport (usually this is 1500). This setting isn't yet wired in, so it will have no effect. This partially resolves: https://bugzilla.redhat.com/1224348 ---

[libvirt] [PATCH 3/3] network: honor mtu setting when creating network

This resolves: https://bugzilla.redhat.com/1224348 --- src/network/bridge_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 7a7bdaf..f383779 100644 --- a/src/network/bridge_driver.c +++

[libvirt] [PATCH go] Fix segfault in Connect.GetMemoryStats

--- connect.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connect.go b/connect.go index 35eb7fd..6730171 100644 --- a/connect.go +++ b/connect.go @@ -1688,7 +1688,7 @@ func (c *Connect) GetMemoryStats(cellNum int, flags uint32) (*NodeMemoryStats, e }

[libvirt] [PATCH go] Fix segfault in Connect.GetMemoryStats

*** BLURB HERE *** Matvey Kruglov (1): Fix segfault in Connect.GetMemoryStats connect.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] perf: introduce option --reset

On Mon, Jan 23, 2017 at 07:26:58PM +0530, Nitesh Konkar wrote: > Hi Daniel, > > > On Mon, Jan 23, 2017 at 4:08 PM, Daniel P. Berrange > wrote: > > > On Mon, Jan 23, 2017 at 04:03:21PM +0530, Nitesh Konkar wrote: > > > > > @@ -9570,16 +9570,17 @@

Re: [libvirt] [PATCH] perf: introduce option --reset

Hi Daniel, On Mon, Jan 23, 2017 at 4:08 PM, Daniel P. Berrange wrote: > On Mon, Jan 23, 2017 at 04:03:21PM +0530, Nitesh Konkar wrote: > > > @@ -9570,16 +9570,17 @@ qemuDomainSetPerfEvents(virDomainPtr dom, > > if (def) { > > for (i = 0; i < nparams; i++) { >

Re: [libvirt] [PATCH v2] util: disallow assigning or resetting a pci-bridge device

Hi Laine, On 01/21/2017 01:50 AM, Laine Stump wrote: On 01/18/2017 11:10 AM, Martin Kletzander wrote: On Wed, Jan 18, 2017 at 07:29:29PM +0530, Shivaprasad G Bhat wrote: It is destructive to attempt reset on a pci-bridge, the host can crash. The bridges won't contain any guest data and

[libvirt] [PATCH v2 2/2] util: disallow resetting a pci-bridge device

It is destructive to attempt reset on a pci-bridge, the host can crash. The bridges won't contain any guest data and neither they can be passed through using vfio/stub. So, no point in allowing a reset on them. Signed-off-by: Shivaprasad G Bhat --- src/util/virpci.c |

[libvirt] [PATCH v2 1/2] util: virhostdev: disallow assigning a pci-bridge to a guest

Non-endpoint devices like pci-bridges cannot be passedthrough to guests. Prevent such attempts. Signed-off-by: Shivaprasad G Bhat --- src/util/virhostdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c

Re: [libvirt] OSX Homebrew support note ;)

On Wed, Dec 21, 2016 at 09:55:53AM +, Justin Clift wrote: > Hi all, > > Compiling Libvirt directly from latest git master head is now supported on > OSX Homebrew. It's as simple as: > > $ brew install --HEAD libvirt > ... > $ virsh -v > 3.0.0 > > This should make development of

Re: [libvirt] [PATCH] perf: introduce option --reset

On Mon, Jan 23, 2017 at 04:03:21PM +0530, Nitesh Konkar wrote: > @@ -9570,16 +9570,17 @@ qemuDomainSetPerfEvents(virDomainPtr dom, > if (def) { > for (i = 0; i < nparams; i++) { > virTypedParameterPtr param = [i]; > -enabled = param->value.b; > +

[libvirt] [PATCH] perf: introduce option --reset

Currently you can either enable or disable a perf event. This patch allows you to reset the perf event using command line option --reset. Eg: virsh perf domainName --reset cpu_cycles Signed-off-by: Nitesh Konkar --- Example: virsh domstats Fedora --perf Domain: