Re: [libvirt] [PATCH] docs, rng: Allow a pool name to be line domain name

On 09/28/2017 10:17 AM, Peter Krempa wrote: > On Thu, Sep 28, 2017 at 10:03:55 -0400, John Ferlan wrote: >> >> >> On 09/28/2017 09:47 AM, Peter Krempa wrote: >>> On Wed, Sep 27, 2017 at 15:07:35 -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1475250 It's

Re: [libvirt] [libvirt-jenkins-ci PATCH 03/18] ansible: Add libosinfo project

On Mon, Oct 02, 2017 at 05:10:41PM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > ansible/host_vars/libvirt-centos-7/main.yml | 1 + > ansible/host_vars/libvirt-debian-8/main.yml | 1 + > ansible/host_vars/libvirt-debian-9/main.yml

Re: [libvirt] [libvirt-jenkins-ci PATCH 05/18] ansible: Add libvirt-cim project

On Mon, Oct 02, 2017 at 05:10:43PM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > ansible/host_vars/libvirt-centos-6/main.yml | 1 + > ansible/host_vars/libvirt-centos-7/main.yml | 1 + > ansible/host_vars/libvirt-fedora-25/main.yml

Re: [libvirt] [PATCH alt] conf: Allow user define their own alias

On Fri, Sep 29, 2017 at 3:49 PM, Michal Privoznik wrote: > On 09/29/2017 01:16 PM, Peter Krempa wrote: > > On Fri, Sep 29, 2017 at 12:57:29 +0200, Michal Privoznik wrote: > >> On 09/29/2017 09:52 AM, Peter Krempa wrote: > >>> On Fri, Sep 29, 2017 at 09:06:01 +0200, Michal

[libvirt] [libvirt-jenkins-ci PATCH 16/18] ansible: Add virt-viewer project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 14/18] ansible: Add osinfo-db-tools project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 10/18] ansible: Add libvirt-python project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-6/main.yml | 1 + ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 18/18] ansible: Add documentation

Signed-off-by: Andrea Bolognani --- ansible/README.markdown| 71 + ansible/mappings/commands.yml | 77 ++ ansible/mappings/libraries.yml | 228 + ansible/mappings/misc.yml | 13 +++

[libvirt] [libvirt-jenkins-ci PATCH 05/18] ansible: Add libvirt-cim project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-6/main.yml | 1 + ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 + ansible/host_vars/libvirt-fedora-26/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 01/18] ansible: Add initial support

This commit adds just enough to bootstrap Jenkins workers and install packages required to build any project, such as gcc and make. Ubuntu 12-16 are supported, even though they're not actually used in libvirt CI, because there's a lot of overlap between this and Travis CI, which only supports

[libvirt] [libvirt-jenkins-ci PATCH 13/18] ansible: Add osinfo-db project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 + ansible/host_vars/libvirt-fedora-26/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 11/18] ansible: Add libvirt-sandbox project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 + ansible/host_vars/libvirt-fedora-26/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 07/18] ansible: Add libvirt-go project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 06/18] ansible: Add libvirt-glib project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 00/18] Ansible all the things!

See patch 18 for information about the purpose and scope of these changes. Andrea Bolognani (18): ansible: Add initial support ansible: Add initial support for building projects ansible: Add libosinfo project ansible: Add libvirt project ansible: Add libvirt-cim project ansible: Add

[libvirt] [libvirt-jenkins-ci PATCH 03/18] ansible: Add libosinfo project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 +

Re: [libvirt] Entering freeze for 3.8.0

On Sun, Oct 01, 2017 at 08:40:48PM +0200, Daniel Veillard wrote: > On Sat, Sep 30, 2017 at 11:51:47PM +0200, Guido Günther wrote: > > Hi, > > On Fri, Sep 29, 2017 at 09:55:00AM +0200, Daniel Veillard wrote: > > > Done, I have tagged RC1 in git, pushed signed tarball and rpms at the > > > usual

[libvirt] [PATCH 2/7] qemuDomainInterfaceStats: Check for the actual type of interface

Users might have configured interface so that it's type of network, but the corresponding network plugs interfaces into an OVS bridge. Therefore, we have to check for the actual type of the interface instead of the configured one. Signed-off-by: Michal Privoznik ---

[libvirt] [PATCH 0/7] Fix reversed stats/QoS for macvtap

This is initiated by: https://bugzilla.redhat.com/show_bug.cgi?id=1497410 Long story short, in some cases host and domain are on the same side of RX/TX stats/QoS. Michal Privoznik (7): lxc: Drop useless ifdef __linux__ qemuDomainInterfaceStats: Check for the actual type of interface conf:

[libvirt] [PATCH 6/7] QoS: Set classes and filters in proper direction

Similarly to previous patch, for some types of interface domain and host are on the same side of RX/TX barrier. In that case, we need to set up the QoS differently. Well, swapped. Signed-off-by: Michal Privoznik --- src/lxc/lxc_driver.c | 3 ++-

[libvirt] [PATCH 4/7] src: Use virDomainNetFindByName

Signed-off-by: Michal Privoznik --- src/libxl/libxl_driver.c | 22 +- src/lxc/lxc_driver.c | 22 +- src/openvz/openvz_driver.c | 22 +- src/qemu/qemu_driver.c | 11 +-- src/test/test_driver.c

[libvirt] [PATCH 1/7] lxc: Drop useless ifdef __linux__

This code compiles only on Linux. Therefore the condition we check is always true. Signed-off-by: Michal Privoznik --- src/lxc/lxc_driver.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index

Re: [libvirt] [PATCH] docs: Document the real behaviour of suspend-to-{mem, disk}

On Fri, Sep 29, 2017 at 02:55:05PM +0200, Martin Kletzander wrote: > We get a question every now and then about why hibernation works when > suspend-to-disk is disabled and similar. Let's hope that, by documenting the > obvious more blatantly, people will get more informed. > > Signed-off-by:

[libvirt] [libvirt-jenkins-ci PATCH 17/18] ansible: Install and configure Jenkins agent

The agent is downloaded and configured to start at boot. The secrets needed to prove the workers' identity to the Jenkins server are stored inside Ansible vaults. Signed-off-by: Andrea Bolognani --- ansible/ansible.cfg| 1 +

[libvirt] [libvirt-jenkins-ci PATCH 12/18] ansible: Add libvirt-tck project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 + ansible/host_vars/libvirt-fedora-26/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 15/18] ansible: Add virt-manager project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 09/18] ansible: Add libvirt-perl project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-6/main.yml | 1 + ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 08/18] ansible: Add libvirt-go-xml project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 04/18] ansible: Add libvirt project

Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-6/main.yml | 1 + ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 +

[libvirt] [libvirt-jenkins-ci PATCH 02/18] ansible: Add initial support for building projects

Building projects is entirely controlled by Jenkins in a production environment, but it can be useful to trigger builds via Ansible during development to figure out build dependencies and for sanity checking purposes. Signed-off-by: Andrea Bolognani ---

[libvirt] [PATCH 5/7] virNetDevTapInterfaceStats: Allow caller to not swap the statistics

https://bugzilla.redhat.com/show_bug.cgi?id=1497410 The comment in virNetDevTapInterfaceStats() implementation for Linux states that packets transmitted by domain are received by the host and vice versa. Well, this is true but not for all types of interfaces. For instance, for macvtaps when TAP

[libvirt] [PATCH 7/7] libvirt-domain: Document interface stats POV

Interestingly enough, we don't document the point of view of the interface statistics. Therefore it's unknown to users if for instance rx_packets is the number of packets received by domain or received by host (from domain). Document this explicitly. Signed-off-by: Michal Privoznik

[libvirt] [PATCH 3/7] conf: Introduce virDomainNetFindByName

Small wrapper to lookup interface in domain definition by its name. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 29 +++-- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 + 3 files changed, 25 insertions(+), 6

Re: [libvirt] [PATCH v4 5/7] nodedev: Disable/re-enable polling on the udev fd

[...] > > Even though I came with another proposal, I personally still like the > > previous > > version with one-by-one event version, since despite (perhaps) being a bit > > slower, it's a more transparent and consistent (minus the event counter) > > solution than the one I proposed the last

Re: [libvirt] [PATCH v4 5/7] nodedev: Disable/re-enable polling on the udev fd

On 10/02/2017 03:19 AM, Erik Skultety wrote: > On Fri, Sep 29, 2017 at 09:46:48AM -0400, John Ferlan wrote: >> >> >> On 09/28/2017 06:00 AM, Erik Skultety wrote: >>> [...] >>> > > nodeDeviceLock(); > +priv = driver->privateData; > udev_monitor =

Re: [libvirt] [PATCH v2] qemu: add the print of page size in cmd domjobinfo

On Fri, Sep 29, 2017 at 09:07:15AM -0400, John Ferlan wrote: > > >On 09/28/2017 04:32 AM, Chao Fan wrote: >> The command "info migrate" of qemu outputs the dirty-pages-rate during >> migration, but page size is different in different architectures. So >> page size should be output to calculate

[libvirt] [PATCH go-xml] extend chardev source to include networking

This will extend the DomainChardevSource to also support networked backends. Signed-off-by: Jeroen Simonetti --- domain.go | 26 +- domain_test.go | 20 2 files changed, 37 insertions(+), 9 deletions(-) diff --git

Re: [libvirt] [PATCH 2/2] nwfilter: Fix memory leak and error path

On Fri, Sep 29, 2017 at 09:31:09AM -0400, John Ferlan wrote: > Found by Coverity. If virNWFilterHashTablePut, then the 3rd arg @val > must be free'd since it would be leaked. > > This also fixes potential problem on the error path where the caller > could assume the virNWFilterHashTablePut was

Re: [libvirt] [PATCH go-xml] qemu: extend serial console source

On Mon, Oct 02, 2017 at 11:34:18AM +, Jeroen Simonetti wrote: > October 2 2017 12:47 PM, "Daniel P. Berrange" wrote: > >> This will change the type of `DomainSerial.Source` from > >> `*DomainChardevSource` to a new `*DomainSerialSource`. > >> > >> This is done to add

Re: [libvirt] [PATCH go-xml] qemu: extend serial console source

October 2 2017 12:47 PM, "Daniel P. Berrange" wrote: >> This will change the type of `DomainSerial.Source` from >> `*DomainChardevSource` to a new `*DomainSerialSource`. >> >> This is done to add support for networked serial ports and >> keep the original DomainChardevSource

[libvirt] [PATCH 3/3] virDomainNetFindIdx: Ignore auto generated MAC addresses

When detaching an from domain, it's MAC address is parsed and if not present one is generated. If, however, no corresponding interface is found in the domain, the following error is reported: error: operation failed: no device matching mac address 52:54:00:75:32:5b found where the MAC address

[libvirt] [PATCH 2/3] virmacaddr: Track if MAC address is autogenerated

It will come handy to know if the MAC address was generated (e.g. during XML parse) or if it was parsed since provided by user in the XML. Signed-off-by: Michal Privoznik --- src/util/virmacaddr.c | 5 + src/util/virmacaddr.h | 2 ++ tests/bhyveargv2xmlmock.c |

[libvirt] [PATCH 1/3] qemuParseCommandLineNet: Make more readable

Signed-off-by: Michal Privoznik --- src/qemu/qemu_parse_command.c | 32 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c index c9112dd90..37e1149c0 100644 ---

[libvirt] [PATCH 0/3] Couple of improvements

https://bugzilla.redhat.com/show_bug.cgi?id=1343919 Michal Privoznik (3): qemuParseCommandLineNet: Make more readable virmacaddr: Track if MAC address is autogenerated virDomainNetFindIdx: Ignore auto generated MAC addresses src/conf/domain_conf.c| 45

Re: [libvirt] [PATCH 1/2] nwfilter: Clean up virNWFilterDetermineMissingVarsRec returns

On Fri, Sep 29, 2017 at 09:31:08AM -0400, John Ferlan wrote: > Rather than using loop break;'s in order to force a return > of rc = -1, let's just return -1 immediately on the various > error paths and then return 0 on the success path. > > Signed-off-by: John Ferlan > --- >

Re: [libvirt] [PATCH go-xml] qemu: extend serial console source

On Mon, Oct 02, 2017 at 12:10:40PM +0200, Jeroen Simonetti wrote: > *Warning* this is a BWC breaking change! That's fine - we don't promise API compat for this module. > This will change the type of `DomainSerial.Source` from > `*DomainChardevSource` to a new `*DomainSerialSource`. > > This is

[libvirt] [PATCH go-xml] qemu: extend serial console source

*Warning* this is a BWC breaking change! This will change the type of `DomainSerial.Source` from `*DomainChardevSource` to a new `*DomainSerialSource`. This is done to add support for networked serial ports and keep the original DomainChardevSource unchanged. DomainSerialSource contains all

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

On Sat, Sep 30, 2017 at 12:16:55AM +0300, Michael S. Tsirkin wrote: > On Fri, Sep 29, 2017 at 02:48:45PM -0500, Richard Relph wrote: > > On 9/29/17 2:34 PM, Michael S. Tsirkin wrote: > > > On Wed, Sep 27, 2017 at 02:06:10PM -0500, Richard Relph wrote: > > > > Whether the "BIOS" is a "static shim"

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

On Fri, Sep 29, 2017 at 02:48:45PM -0500, Richard Relph wrote: > On 9/29/17 2:34 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 27, 2017 at 02:06:10PM -0500, Richard Relph wrote: > > > Whether the "BIOS" is a "static shim" as Michael suggests, or a full BIOS, > > > or even a BIOS+kernel+initrd is

Re: [libvirt] [PATCH] docs: Add some changes to news.xml for this release

On Mon, Oct 02, 2017 at 10:07:01AM +0200, Andrea Bolognani wrote: On Fri, 2017-09-29 at 16:49 +0200, Martin Kletzander wrote: + + While waiting for a write to disk to be finished, e.g. during save, + even simple operations like virsh list would be blocking +

Re: [libvirt] [PATCH v2 0/2] Clean up the nwfilter mess I created

On Fri, Sep 29, 2017 at 04:02:48PM -0400, John Ferlan wrote: v1: https://www.redhat.com/archives/libvir-list/2017-September/msg01072.html Changes: * Patch1: No change, ACK'd, but not safe to push yet either.. * Patch2: Rather than have virNWFilterIPAddrMapAddIPAddr consume the input

Re: [libvirt] [PATCH] docs: Add some changes to news.xml for this release

On Fri, 2017-09-29 at 16:49 +0200, Martin Kletzander wrote: > + > + While waiting for a write to disk to be finished, e.g. during save, > + even simple operations like virsh list would be > blocking > + due to domain lock. This is now resolved by unlocking the

Re: [libvirt] [PATCH v4 5/7] nodedev: Disable/re-enable polling on the udev fd

On Fri, Sep 29, 2017 at 09:46:48AM -0400, John Ferlan wrote: > > > On 09/28/2017 06:00 AM, Erik Skultety wrote: > > [...] > > > >>> > >>> nodeDeviceLock(); > >>> +priv = driver->privateData; > >>> udev_monitor = DRV_STATE_UDEV_MONITOR(driver); > >>> > >>> if