Re: [libvirt] [PATCH v6.1 2/9] libxl: pass driver config to libxlMakeDomBuildInfo

On Wed, Mar 28, 2018 at 01:42:47PM -0600, Jim Fehlig wrote: > On 03/27/2018 05:55 PM, Marek Marczykowski-Górecki wrote: > > diff --git a/tests/virmocklibxl.c b/tests/virmocklibxl.c > > index 747f9f8..28281b6 100644 > > --- a/tests/virmocklibxl.c > > +++ b/tests/virmocklibxl.c > > @@ -27,6 +27,7 @@

[libvirt] [qemu RFC] qapi: add "firmware.json"

Add a schema that describes the properties of virtual machine firmware. Each firmware executable installed on a host system should come with a JSON file that conforms to this schema, and informs the management applications about the firmware's properties. In addition, a configuration directory

[libvirt] Permissions and ownership on /dev/kvm keep reverting after starting a vm

Hey guys, /dev/kvm permissions and ownership keeps reverting after starting a vm. The ownership and permissions keep going back to crw-rw—— root root After starting a vm. I have to revert the perms and ownership to: crw-crw-crw root kvm To start any vm but it goes back to the

Re: [libvirt] [PATCH v2] docs: add page describing goals for host platform version support

On 04/05/2018 04:05 AM, Daniel P. Berrangé wrote: Described how we decide which host platforms to support for libvirt, which in turn makes it easier to decide when a platform / software version can be dropped. Signed-off-by: Daniel P. Berrangé --- docs/index.html.in

Re: [libvirt] [PATCH 0/7] Remove the legacy xen driver

On 04/03/2018 08:26 AM, Daniel P. Berrangé wrote: On Wed, Mar 28, 2018 at 08:58:25PM -0600, Jim Fehlig wrote: Long overdue first cut at remove the old xen driver. The first 3 patches move existing tests to WITH_LIBXL since we'll want to continue supporting conversion of the various xen config

[libvirt] [PATCH V2 1/8] tests: move xml2sexpr tests to WITH_LIBXL

In preparation of removing the legacy Xen driver, move the xml2sexpr tests from WITH_XEN to WITH_LIBXL. Even though the legacy driver will be removed, we'll want to maintain the ability to convert sexpr <-> XML. There is some test file fallout due to differences in handling of default values

[libvirt] [PATCH V2 4/8] Remove xencaps tests and data files

Signed-off-by: Jim Fehlig --- tests/Makefile.am | 20 --- tests/testutilsxen.c | 64 - tests/testutilsxen.h | 2 - tests/vircapstest.c| 34 -

[libvirt] [PATCH V2 2/8] tests: move sexpr2xml tests to WITH_LIBXL

In preparation of removing the legacy Xen driver, move the sexpr2xml tests from WITH_XEN to WITH_LIBXL. Even though the legacy driver will be removed, we'll want to maintain the ability to convert sexpr to XML. Requires fixing up the tests to account for different behavior of Xen vs libxl post

[libvirt] [PATCH V2 0/8] Remove the legacy xen driver

Long overdue removal the old xen driver. The first 3 patches move existing tests to WITH_LIBXL since we'll want to continue supporting conversion of the various xen config formats. The remain patches remove the cruft. Patch8, new to V2, updates the Xen driver page. Jim Fehlig (8): tests: move

[libvirt] [PATCH V2 7/8] spec: remove legacy xen driver

Signed-off-by: Jim Fehlig --- libvirt.spec.in | 57 - 1 file changed, 4 insertions(+), 53 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 97143c68a..5090dfa2a 100644 --- a/libvirt.spec.in +++

[libvirt] [PATCH V2 6/8] docs: remove mention of legacy Xen driver

Signed-off-by: Jim Fehlig --- V2: Fix small typo docs/architecture.html.in | 28 -- docs/bugs.html.in | 3 +- docs/uri.html.in | 74 --- docs/windows.html.in | 2 +- 4 files changed, 9

[libvirt] [PATCH V2 8/8] docs: update Xen driver information

Now that the old Xen driver is removed, update the drvxen page with current information on the libxl drvier and remove all the old cruft. Signed-off-by: Jim Fehlig --- New patch in V2 to update the Xen driver page. docs/drvxen.html.in | 91

[libvirt] [PATCH V2 3/8] tests: move xmconfig tests to WITH_LIBXL

In preparation of removing the legacy Xen driver, move the xmconfig tests from WITH_XEN to WITH_LIBXL. Even though the legacy driver will be removed, we'll want to maintain the ability to convert xm config to XML. Requires fixing up the tests to account for different behavior of Xen vs libxl post

Re: [libvirt] [PATCH 1/4] conf: Use virDomainChrSourceDefNew for vhostuser

On 04/06/2018 01:31 PM, Laine Stump wrote: > On 04/06/2018 12:53 PM, John Ferlan wrote: >> Rather than using VIR_ALLOC, use the New API since we already >> use the virDomainChrSourceDefFree function when done. >> >> -if (VIR_ALLOC(def->data.vhostuser) < 0) >> +if

Re: [libvirt] [PATCH 2/4] qemu: Use virDomainChrSourceDefNew for monConfig

On 04/06/2018 12:53 PM, John Ferlan wrote: > Rather than VIR_ALLOC, use the New function for allocation. We > already use the Free function anyway. > > Signed-off-by: John Ferlan > --- > src/conf/domain_conf.c | 2 +- > src/conf/domain_conf.h | 3 +++ >

Re: [libvirt] [PATCH 1/4] conf: Use virDomainChrSourceDefNew for vhostuser

On 04/06/2018 12:53 PM, John Ferlan wrote: > Rather than using VIR_ALLOC, use the New API since we already > use the virDomainChrSourceDefFree function when done. > > Signed-off-by: John Ferlan > --- > src/conf/domain_conf.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [libvirt] [PATCH 03/11] conf: Remove dubious code from virDomainPCIAddressSetGrow()

On 04/04/2018 04:54 AM, Andrea Bolognani wrote: > On Tue, 2018-04-03 at 22:44 -0400, Laine Stump wrote: > >> In the meantime, if I remove that code (and don't apply any of your >> patches) then a pure pcie domain *can* be successfully edited to add a >> single pci-bridge (as long as you specify an

Re: [libvirt] [RFC] Defining firmware (OVMF, et al) metadata format & file

On 04/06/18 20:10, Eric Blake wrote: > On 04/06/2018 12:28 PM, Laszlo Ersek wrote: > >> I've created an RFC-level "qapi/firmware.json" schema file, based on >> this discussion. It "builds", and the generated documentation looks >> acceptable, superficially speaking. >> >> Before I post

Re: [libvirt] [RFC] Defining firmware (OVMF, et al) metadata format & file

On 04/06/2018 12:28 PM, Laszlo Ersek wrote: > I've created an RFC-level "qapi/firmware.json" schema file, based on > this discussion. It "builds", and the generated documentation looks > acceptable, superficially speaking. > > Before I post "qapi/firmware.json" for getting comments, I'd like to

Re: [libvirt] [PATCH 3/4] conf: Introduce virDomainObjListAddObjLocked

On 04/06/2018 08:56 AM, Michal Privoznik wrote: > On 03/29/2018 02:34 PM, John Ferlan wrote: >> Create a common helper to add an object to the locked domain >> objlist hash tables and use it. >> >> Signed-off-by: John Ferlan >> --- >> src/conf/virdomainobjlist.c | 64 >>

Re: [libvirt] [PATCH 1/4] conf: Fix error path logic in virDomainObjListAddLocked

On 04/06/2018 08:56 AM, Michal Privoznik wrote: > On 03/29/2018 02:34 PM, John Ferlan wrote: >> If the virHashAddEntry fails, then we need to "careful" about >> how we free the @vm. When virDomainObjNew returns there is one >> reference and the object is locked, so use virDomainObjEndAPI >> when

Re: [libvirt] [RFC] Defining firmware (OVMF, et al) metadata format & file

On 03/08/18 11:17, Daniel P. Berrangé wrote: > On Thu, Mar 08, 2018 at 08:52:45AM +0100, Gerd Hoffmann wrote: >> Hi, >> [*] Open question: Who, between QEMU and libvirt, should define the said firmware metadata format and file? >>> >>> IMHO QEMU should be defining the format, because

[libvirt] [PATCH 4/4] qemu: Obtain reference on monConfig

Because we allow a QEMU_JOB_DESTROY to occur while we're starting up and we drop the @vm lock prior to qemuMonitorOpen, it's possible that a domain destroy operation "wins" the race, calls qemuProcessStop which will free and reinitialize priv->monConfig. Depending on the exact timing either

[libvirt] [PATCH 0/4] Fix a race to using monConfig

As reported by Marc Hartmayer : https://www.redhat.com/archives/libvir-list/2018-March/msg01156.html there is a race to using the priv->monConfig between the Create and destroy domain processing. The patches describe the steps taken to resolve the issue. John Ferlan

[libvirt] [PATCH 3/4] conf: Convert virDomainChrSourceDefNew to return object

Let's use object referencing to handle the ChrSourceDef. A subsequent patch then can allow the monConfig to take an extra reference before dropping the domain lock to then ensure nothing free's the memory that needs to be used. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 2/4] qemu: Use virDomainChrSourceDefNew for monConfig

Rather than VIR_ALLOC, use the New function for allocation. We already use the Free function anyway. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_domain.c | 2 +-

[libvirt] [PATCH 1/4] conf: Use virDomainChrSourceDefNew for vhostuser

Rather than using VIR_ALLOC, use the New API since we already use the virDomainChrSourceDefFree function when done. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] Race condition between qemuDomainCreate and qemuDomainDestroy

On 04/03/2018 07:47 AM, Marc Hartmayer wrote: > On Tue, Mar 20, 2018 at 11:25 AM +0100, Marc Hartmayer > wrote: >> Hi, >> >> there is a race condition between 'qemuDomainCreate' and >> 'qemuDomainDestroy' causing a NULL pointer segmentation fault when >> accessing

Re: [libvirt] [dbus PATCH 9/9] Implement Setter for Autostart property of Network Interface.

On Fri, Apr 06, 2018 at 01:20:34PM +0200, Katerina Koukiou wrote: In $subject remove the period. > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Network.xml | 5 +++-- > src/network.c| 22 +- > test/test_network.py |

Re: [libvirt] [jenkins-ci PATCH 06/10] guests: Move $PATH configuration to shell profile

On Fri, 2018-04-06 at 17:03 +0200, Pavel Hrdina wrote: > On Thu, Apr 05, 2018 at 02:22:16PM +0200, Andrea Bolognani wrote: > > Same as for $MAKE, moving the configuration here makes it > > easier to reproduce issues outside of the CI environment. > > > > Signed-off-by: Andrea Bolognani

Re: [libvirt] [dbus PATCH 5/9] Implement NetworkDefineXML method for Connect interface

On Fri, Apr 06, 2018 at 01:20:30PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 29 + > test/test_connect.py | 12 > 3

Re: [libvirt] [dbus PATCH 8/9] Implement Persistent property for Network Interface.

On Fri, Apr 06, 2018 at 01:20:33PM +0200, Katerina Koukiou wrote: In $subject remove the period. > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Network.xml | 4 > src/network.c| 22 ++ > test/test_network.py |

Re: [libvirt] [dbus PATCH 7/9] Implement Active property for Network Interface.

On Fri, Apr 06, 2018 at 01:20:32PM +0200, Katerina Koukiou wrote: In $subject remove the period. > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Network.xml | 4 > src/network.c| 22 ++ > test/test_network.py |

Re: [libvirt] [dbus PATCH 6/9] Implement GetXMLDesc method for Network Interface.

On Fri, Apr 06, 2018 at 01:20:31PM +0200, Katerina Koukiou wrote: In $subject remove the period. > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Network.xml | 6 ++ > src/network.c| 28 > test/test_network.py

[libvirt] [jenkins-ci PATCH 12/10] guests: Enable bash completion by default

In order for bash completion to be available right after login we need to make sure the corresponding package is installed and, for FreeBSD only, the enviroment script gets sourced. Signed-off-by: Andrea Bolognani --- guests/templates/bashrc | 5 +

Re: [libvirt] [dbus PATCH 4/9] Implement NetworkCreateXML method for Connect interface

On Fri, Apr 06, 2018 at 01:20:29PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 29 + > test/test_connect.py | 26

Re: [libvirt] [dbus PATCH 3/9] Add Domain prefix to DefineXML method, tests and related functions.

On Fri, Apr 06, 2018 at 01:20:28PM +0200, Katerina Koukiou wrote: Same comment for the $subject as in the previous patch. > This method is domain specific and should be clear from the naming, > so that we can later define *DefineXML methods for other entities. > > Signed-off-by: Katerina

Re: [libvirt] [dbus PATCH 2/9] Add Domain prefix to CreateXML method, test and related functions.

On Fri, Apr 06, 2018 at 01:20:27PM +0200, Katerina Koukiou wrote: In the $subject s/, test and related functions.// we don't end the subject with period and the part after comma can be removed. > This method is domain specific and should be clear from the naming, > so that we can later

Re: [libvirt] [dbus PATCH 1/9] tests: Rename minimal_xml to minimal_domain_xml

On Fri, Apr 06, 2018 at 01:20:26PM +0200, Katerina Koukiou wrote: > Needed so as to keep consistent naming when we 'll introduce XML s/we 'll/we'll/ > for other entities. > > Signed-off-by: Katerina Koukiou > --- > test/test_connect.py | 6 +++--- > 1 file changed, 3

Re: [libvirt] [jenkins-ci PATCH 11/10] guests: Move $OSINFO_SYSTEM_DIR configuration to shell profile

On Fri, Apr 06, 2018 at 01:40:18PM +0200, Andrea Bolognani wrote: > This belongs with all the other enviroment settings, but it was > somehow missed the first time around. > > Signed-off-by: Andrea Bolognani > --- > guests/group_vars/all/main.yml | 1 + >

Re: [libvirt] [jenkins-ci PATCH 10/10] guests: Remove per-host make variable

On Thu, Apr 05, 2018 at 02:22:20PM +0200, Andrea Bolognani wrote: > We are figuring out which make binary we should use dynamically > in the shell profile now, so this variable is redundant; plus, > we were not actually using it anywhere. > > Signed-off-by: Andrea Bolognani

Re: [libvirt] [jenkins-ci PATCH 09/10] guests: Add Python configuration to shell profile

On Thu, Apr 05, 2018 at 02:22:19PM +0200, Andrea Bolognani wrote: > This is conceptually identical to how Perl is handled, except > that we still need to override $PYTHONPATH in Jenkins jobs in > order to be able to build projects using both Python 3 and > Python 2 on the same guest. We might want

Re: [libvirt] [jenkins-ci PATCH 06/10] guests: Move $PATH configuration to shell profile

On Thu, Apr 05, 2018 at 02:22:16PM +0200, Andrea Bolognani wrote: > Same as for $MAKE, moving the configuration here makes it > easier to reproduce issues outside of the CI environment. > > Signed-off-by: Andrea Bolognani > --- > guests/group_vars/all/main.yml | 6 -- >

Re: [libvirt] [jenkins-ci PATCH 08/10] guests: Move Perl configuration to shell profile

On Thu, Apr 05, 2018 at 02:22:18PM +0200, Andrea Bolognani wrote: > Same as for $VIRT_PREFIX and friends, we want these to be > tracked along with the rest of the CI setup instead of being a > completely opaque, side-loaded blob. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [jenkins-ci PATCH 07/10] guests: Add more enviroment variables to shell profile

On Thu, Apr 05, 2018 at 02:22:17PM +0200, Andrea Bolognani wrote: > All these are currently defined per-worker at the Jenkins level, > which has several disadvantages: first of all, they are completely > invisible to anyone except people with admin access to the Jenkins > instance; moreover,

Re: [libvirt] [jenkins-ci PATCH 03/10] guests: Add custom shell profile

On Fri, Apr 06, 2018 at 04:39:44PM +0200, Andrea Bolognani wrote: > On Fri, 2018-04-06 at 15:10 +0200, Andrea Bolognani wrote: > > > I think that we should also load the system profile /etc/profile .. in > > > case of 'jenkins' flavor we don't actually need it since that is used in > > > automated

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

On Fri, Apr 06, 2018 at 10:49:23AM -0400, Stefan Berger wrote: > On 04/06/2018 10:12 AM, Daniel P. Berrangé wrote: > > On Fri, Apr 06, 2018 at 07:23:49AM -0400, Stefan Berger wrote: > > > On 04/06/2018 04:26 AM, Daniel P. Berrangé wrote: > > > > On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

On 04/06/2018 10:12 AM, Daniel P. Berrangé wrote: On Fri, Apr 06, 2018 at 07:23:49AM -0400, Stefan Berger wrote: On 04/06/2018 04:26 AM, Daniel P. Berrangé wrote: On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan Berger wrote: This patch adds support for an external swtpm TPM emulator. The XML

Re: [libvirt] [jenkins-ci PATCH 03/10] guests: Add custom shell profile

On Fri, 2018-04-06 at 15:10 +0200, Andrea Bolognani wrote: > > I think that we should also load the system profile /etc/profile .. in > > case of 'jenkins' flavor we don't actually need it since that is used in > > automated tests but in case of 'test' flavor when developer will > > manually login

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

On Fri, Apr 06, 2018 at 07:23:49AM -0400, Stefan Berger wrote: > On 04/06/2018 04:26 AM, Daniel P. Berrangé wrote: > > On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan Berger wrote: > > > This patch adds support for an external swtpm TPM emulator. The XML for > > > this type of TPM looks as

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

On 04/06/2018 07:23 AM, Stefan Berger wrote: On 04/06/2018 04:26 AM, Daniel P. Berrangé wrote: On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan Berger wrote: This patch adds support for an external swtpm TPM emulator. The XML for this type of TPM looks as follows: The XML will

Re: [libvirt] [jenkins-ci PATCH 0/3] Drop CentOS 6, which makes some nice cleanups possible

On Fri, 2018-04-06 at 14:43 +0100, Daniel P. Berrangé wrote: > > > It just occurred to me that libvirt.org is running on CentOS 6, and we > > > rely on being able to run configure, make & make dist there, so that > > > we can do things like publish the website, create nightly snapshots, > > >

Re: [libvirt] [jenkins-ci PATCH 0/3] Drop CentOS 6, which makes some nice cleanups possible

On Fri, Apr 06, 2018 at 03:38:34PM +0200, Michal Privoznik wrote: > On 04/06/2018 03:20 PM, Daniel P. Berrangé wrote: > > On Fri, Apr 06, 2018 at 01:58:07PM +0200, Andrea Bolognani wrote: > >> This applies on top of > >> > >> https://www.redhat.com/archives/libvir-list/2018-April/msg00410.html >

Re: [libvirt] [jenkins-ci PATCH 0/3] Drop CentOS 6, which makes some nice cleanups possible

On 04/06/2018 03:20 PM, Daniel P. Berrangé wrote: > On Fri, Apr 06, 2018 at 01:58:07PM +0200, Andrea Bolognani wrote: >> This applies on top of >> >> https://www.redhat.com/archives/libvir-list/2018-April/msg00410.html >> >> and, of course, should only be pushed after >> >>

Re: [libvirt] [jenkins-ci PATCH 0/3] Drop CentOS 6, which makes some nice cleanups possible

On Fri, Apr 06, 2018 at 01:58:07PM +0200, Andrea Bolognani wrote: > This applies on top of > > https://www.redhat.com/archives/libvir-list/2018-April/msg00410.html > > and, of course, should only be pushed after > > https://www.redhat.com/archives/libvir-list/2018-April/msg00326.html > >

Re: [libvirt] [jenkins-ci PATCH 05/10] guests: Move make configuration to shell profile

On Thu, Apr 05, 2018 at 02:22:15PM +0200, Andrea Bolognani wrote: > Now that we have our custom shell profile, we can pick the > correct make variant dynamically there instead of doing it > in the Jenkins job definition, so that the $MAKE variable > will also be available when using the guests

Re: [libvirt] [jenkins-ci PATCH 03/10] guests: Add custom shell profile

On Fri, 2018-04-06 at 14:58 +0200, Pavel Hrdina wrote: > > diff --git a/guests/templates/bash_profile b/guests/templates/bash_profile > > new file mode 100644 > > index 000..a82a60e > > --- /dev/null > > +++ b/guests/templates/bash_profile > > @@ -0,0 +1 @@ > > +test -f ~/.bashrc && .

Re: [libvirt] [jenkins-ci PATCH 04/10] guests: Move ccache configuration to shell profile

On Thu, Apr 05, 2018 at 02:22:14PM +0200, Andrea Bolognani wrote: > Now that we have our custom shell profile, making sure ccache > is used is way simpler. > > Signed-off-by: Andrea Bolognani > --- > guests/tasks/users.yml | 18 -- > guests/templates/bashrc

Re: [libvirt] [PATCH 00/68] qemu: Refactor migration parameters

On Wed, Apr 04, 2018 at 16:40:49 +0200, Jiri Denemark wrote: > This series changes the way we handle migration parameters and > capabilities with several goals: > > - make it all consistent and avoid storing the same parameters in > several structs > - reduce the number of QMP commands we use

Re: [libvirt] [PATCH 4/4] news: Update the news file with the log filter wildcard improvement

On Tue, Apr 03, 2018 at 10:45:49AM +0200, Erik Skultety wrote: Signed-off-by: Erik Skultety --- docs/news.xml | 12 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 87f52e83e..6dab4844d 100644 --- a/docs/news.xml +++

Re: [libvirt] [PATCH 3/4] util: virlog: Introduce wildcard to log filters

On Tue, Apr 03, 2018 at 10:45:48AM +0200, Erik Skultety wrote: Since the introduction of log tuning capabilities to virt-admin by @06b91785, this has been a much needed missing improvement on the way to deprecate the global 'log_level'. Signed-off-by: Erik Skultety ---

Re: [libvirt] [PATCH 1/4] virlog: Fix a typo in virLogParseFilter's error msg

On Tue, Apr 03, 2018 at 10:45:46AM +0200, Erik Skultety wrote: This was some copy-paste leftover. Signed-off-by: Erik Skultety --- src/util/virlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK Jano signature.asc Description: Digital signature --

Re: [libvirt] [PATCH 2/4] libvirtd.conf: Document that we do a 'first' match on log filters

On Tue, Apr 03, 2018 at 10:45:47AM +0200, Erik Skultety wrote: When applying the log filters, one has to define the more specific filters before the generic ones, because the first filter that matches will be applied. However, we've been missing this information in the config, so it always has

Re: [libvirt] [jenkins-ci PATCH 03/10] guests: Add custom shell profile

On Thu, Apr 05, 2018 at 02:22:13PM +0200, Andrea Bolognani wrote: > We want to take control of the user's environment. For now the > custom shell profile only sets the prompt, but it will later > be used to influence the build environment. > > Signed-off-by: Andrea Bolognani

Re: [libvirt] [PATCH 1/4] conf: Fix error path logic in virDomainObjListAddLocked

On 03/29/2018 02:34 PM, John Ferlan wrote: > If the virHashAddEntry fails, then we need to "careful" about > how we free the @vm. When virDomainObjNew returns there is one > reference and the object is locked, so use virDomainObjEndAPI > when done. > > Add a virObjectRef in the error path for the

Re: [libvirt] [PATCH 3/4] conf: Introduce virDomainObjListAddObjLocked

On 03/29/2018 02:34 PM, John Ferlan wrote: > Create a common helper to add an object to the locked domain > objlist hash tables and use it. > > Signed-off-by: John Ferlan > --- > src/conf/virdomainobjlist.c | 64 > +++-- > 1 file

Re: [libvirt] [PATCH 0/4] Initial phase of domain obj add/remove cleanup

On 03/29/2018 02:34 PM, John Ferlan wrote: > As evidenced by various code comments, the process of adding and > removing objects to/from the domain object list is problematic. > > Long story short is that the Add logic doesn't generate enough > object references and the Remove logic removes one

Re: [libvirt] [PATCH 0/2] Two almost trivial fixes

On Fri, Apr 06, 2018 at 02:22:45PM +0200, Michal Privoznik wrote: Any review appreciated. Michal Privoznik (2): storageVolLookupData: Drop conn struct member storageDriverAutostart: Drop unused @conn src/storage/storage_driver.c | 9 ++--- src/test/test_driver.c | 5 ++--- 2 files

[libvirt] [PATCH 0/2] Two almost trivial fixes

Any review appreciated. Michal Privoznik (2): storageVolLookupData: Drop conn struct member storageDriverAutostart: Drop unused @conn src/storage/storage_driver.c | 9 ++--- src/test/test_driver.c | 5 ++--- 2 files changed, 4 insertions(+), 10 deletions(-) -- 2.16.1 --

[libvirt] [PATCH 1/2] storageVolLookupData: Drop conn struct member

Since its introduction in 5d5c732d748d64 it has been never used. Signed-off-by: Michal Privoznik --- src/storage/storage_driver.c | 5 ++--- src/test/test_driver.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/storage/storage_driver.c

[libvirt] [PATCH 2/2] storageDriverAutostart: Drop unused @conn

This variable is not actually used in the function. Especially after 31869efe2a8. Signed-off-by: Michal Privoznik --- src/storage/storage_driver.c | 4 1 file changed, 4 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index

Re: [libvirt] [PATCH 02/68] qemu: Rename qemuMigrationAnyCapsGet as qemuMigrationCapsGet

On Wed, Apr 04, 2018 at 04:40:51PM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c| 4 ++-- src/qemu/qemu_migration.c | 10 +- src/qemu/qemu_migration.h | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git

Re: [libvirt] [PATCH 03/68] qemu: Rename qemuMigrationParams

On Wed, Apr 04, 2018 at 04:40:52PM +0200, Jiri Denemark wrote: The function is now called qemuMigrationParamsFromFlags to better reflect what it is doing: taking migration flags and params and producing a struct with QEMU migration parameters. Signed-off-by: Jiri Denemark

Re: [libvirt] [jenkins-ci PATCH 02/10] guests: Enable ~/.bashrc on FreeBSD

On Thu, Apr 05, 2018 at 02:22:12PM +0200, Andrea Bolognani wrote: > Due to the way bash is compiled on FreeBSD, we need to flip an > extra switch in order to convince it to process the shell profile > even when we're running commands non-interactively through ssh. > > Signed-off-by: Andrea

[libvirt] [jenkins-ci PATCH 1/3] guests: Drop CentOS 6 support

Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-centos-6/install.yml | 3 - guests/host_vars/libvirt-centos-6/main.yml| 9 --- guests/inventory | 1 - guests/vars/mappings.yml | 16 +

[libvirt] [jenkins-ci PATCH 2/3] projects: Drop CentOS 6 support

Signed-off-by: Andrea Bolognani --- projects/libvirt-cim.yaml| 1 - projects/libvirt-perl.yaml | 1 - projects/libvirt-python.yaml | 2 -- projects/libvirt.yaml| 3 --- 4 files changed, 7 deletions(-) diff --git a/projects/libvirt-cim.yaml

[libvirt] [jenkins-ci PATCH 0/3] Drop CentOS 6, which makes some nice cleanups possible

This applies on top of https://www.redhat.com/archives/libvir-list/2018-April/msg00410.html and, of course, should only be pushed after https://www.redhat.com/archives/libvir-list/2018-April/msg00326.html or a follow-up version has been pushed. Andrea Bolognani (3): guests: Drop CentOS

[libvirt] [jenkins-ci PATCH 3/3] jobs: Introduce {all_machines} and {rpm_machines}

We're running most of the jobs on all machines, with the major notable exception being the various *-rpm jobs which of course only make sense for RPM-based distributions. Instead of listing machines over and over again, define two list globally and refer to them by name. Ad-hoc machine lists are

Re: [libvirt] [dbus PATCH 0/9] Add more properties and methods for Network

On Fri, 2018-04-06 at 13:20 +0200, Katerina Koukiou wrote: > Katerina Koukiou (9): > tests: Rename minimal_xml to minimal_domain_xml > Add Domain prefix to CreateXML method, test and related functions. I broke tests with this, and I didn't realize because of the known issue with non

Re: [libvirt] [jenkins-ci PATCH 01/10] guests: Rename compat -> kludges

On Thu, Apr 05, 2018 at 02:22:11PM +0200, Andrea Bolognani wrote: > This task only contains workarounds that we shouldn't have to > worry about to begin with, and that hopefully in due time we'll > be able to drop entirely. Rename it to make this more apparent. > > Signed-off-by: Andrea Bolognani

[libvirt] [jenkins-ci PATCH 11/10] guests: Move $OSINFO_SYSTEM_DIR configuration to shell profile

This belongs with all the other enviroment settings, but it was somehow missed the first time around. Signed-off-by: Andrea Bolognani --- guests/group_vars/all/main.yml | 1 + guests/templates/bashrc| 1 + projects/libosinfo.yaml| 2 -- 3 files changed, 2

Re: [libvirt] [PATCH 06/11] qemu: Implement pcie-to-pci-bridge controller

On 04/06/2018 04:15 AM, Andrea Bolognani wrote: > On Wed, 2018-04-04 at 10:58 +0200, Andrea Bolognani wrote: >> On Tue, 2018-04-03 at 19:13 -0400, John Ferlan wrote: >>> Is there something else perhaps a few paragraphs later that could be >>> added to say what this is and how/when/why someone

Re: [libvirt] [PATCH 0/2] Change virCloseCallback typedef to return void

ping? Tks - John On 03/29/2018 08:48 AM, John Ferlan wrote: > Slightly related to some current work to clean up the Add/Remove > domain object list processing - as it turns out the close callbacks > run code didn't even pay attention to what was returned and it > really didn't need to - so

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

On 04/06/2018 04:26 AM, Daniel P. Berrangé wrote: On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan Berger wrote: This patch adds support for an external swtpm TPM emulator. The XML for this type of TPM looks as follows: The XML will currently only start a TPM 1.2. Upon the first

[libvirt] [dbus PATCH 4/9] Implement NetworkCreateXML method for Connect interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + test/test_connect.py | 26 ++ 3 files changed, 61 insertions(+) diff --git

[libvirt] [dbus PATCH 0/9] Add more properties and methods for Network

Katerina Koukiou (9): tests: Rename minimal_xml to minimal_domain_xml Add Domain prefix to CreateXML method, test and related functions. Add Domain prefix to DefineXML method, tests and related functions. Implement NetworkCreateXML method for Connect interface Implement NetworkDefineXML

[libvirt] [dbus PATCH 8/9] Implement Persistent property for Network Interface.

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 4 src/network.c| 22 ++ test/test_network.py | 1 + 3 files changed, 27 insertions(+) diff --git a/data/org.libvirt.Network.xml

[libvirt] [dbus PATCH 9/9] Implement Setter for Autostart property of Network Interface.

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 5 +++-- src/network.c| 22 +- test/test_network.py | 8 3 files changed, 32 insertions(+), 3 deletions(-) diff --git a/data/org.libvirt.Network.xml

Re: [libvirt] [PATCH 0/4] Initial phase of domain obj add/remove cleanup

ping? Tks - John On 03/29/2018 08:34 AM, John Ferlan wrote: > As evidenced by various code comments, the process of adding and > removing objects to/from the domain object list is problematic. > > Long story short is that the Add logic doesn't generate enough > object references and the Remove

[libvirt] [dbus PATCH 6/9] Implement GetXMLDesc method for Network Interface.

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 6 ++ src/network.c| 28 test/test_network.py | 5 + 3 files changed, 39 insertions(+) diff --git a/data/org.libvirt.Network.xml

Re: [libvirt] [PATCH v2 0/9] Be consistent with vir*Obj*Remove* APIs

ping? Tks - John On 03/28/2018 05:19 PM, John Ferlan wrote: > v1: https://www.redhat.com/archives/libvir-list/2018-March/msg01295.html > > NB: This can wait until 4.2.0 is release, but I figured I'd post this > now just to put it on the radar and of course in hopes that someone > will

[libvirt] [dbus PATCH 5/9] Implement NetworkDefineXML method for Connect interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + test/test_connect.py | 12 3 files changed, 47 insertions(+) diff --git a/data/org.libvirt.Connect.xml

[libvirt] [dbus PATCH 7/9] Implement Active property for Network Interface.

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 4 src/network.c| 22 ++ test/test_network.py | 1 + 3 files changed, 27 insertions(+) diff --git a/data/org.libvirt.Network.xml

[libvirt] [dbus PATCH 2/9] Add Domain prefix to CreateXML method, test and related functions.

This method is domain specific and should be clear from the naming, so that we can later define *CreateXML methods for other entities. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 2 +- src/connect.c| 16

[libvirt] [dbus PATCH 3/9] Add Domain prefix to DefineXML method, tests and related functions.

This method is domain specific and should be clear from the naming, so that we can later define *DefineXML methods for other entities. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 2 +- src/connect.c| 16

[libvirt] [dbus PATCH 1/9] tests: Rename minimal_xml to minimal_domain_xml

Needed so as to keep consistent naming when we 'll introduce XML for other entities. Signed-off-by: Katerina Koukiou --- test/test_connect.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test_connect.py b/test/test_connect.py index

Re: [libvirt] [PATCH] util: don't check for parallel iteration in hash-related functions

On 04/06/2018 09:56 AM, Vincent Bernat wrote: > This is the responsability of the caller to apply the correct lock > before using these functions. Moreover, the use of a simple boolean > was still racy: two threads may check the boolean and "lock" it > simultaneously. > > Users of functions from

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan Berger wrote: > This patch adds support for an external swtpm TPM emulator. The XML for > this type of TPM looks as follows: > > > > > > The XML will currently only start a TPM 1.2. > > Upon the first start, libvirt will run

Re: [libvirt] [PATCH 06/11] qemu: Implement pcie-to-pci-bridge controller

On Wed, 2018-04-04 at 10:58 +0200, Andrea Bolognani wrote: > On Tue, 2018-04-03 at 19:13 -0400, John Ferlan wrote: > > Is there something else perhaps a few paragraphs later that could be > > added to say what this is and how/when/why someone should want to use > > it? Including the restriction

[libvirt] [PATCH] util: don't check for parallel iteration in hash-related functions

This is the responsability of the caller to apply the correct lock before using these functions. Moreover, the use of a simple boolean was still racy: two threads may check the boolean and "lock" it simultaneously. Users of functions from src/util/virhash.c have to be checked for correctness.

  1   2   >