On 05/14/2018 06:30 PM, John Ferlan wrote:
On 05/14/2018 03:43 AM, Boris Fiuczynski wrote:
On 05/10/2018 10:52 PM, John Ferlan wrote:
On 05/07/2018 10:41 AM, Boris Fiuczynski wrote:
From: Shalini Chellathurai Saroja
Introduces the vfio-ccw model for mediated devices and prime vfio-ccw
de
On 05/12/2018 09:45 AM, Filip Alac wrote:
Parser assumed extra was always present when root was specified.
Fixed by handling root and extra separately.
Signed-off-by: Filip Alac
Reviewed-by: Jim Fehlig
and pushed. Thanks!
Regards,
Jim
---
src/xenconfig/xen_xm.c | 7 +--
1 file cha
libxlDoDomainSave() is used in both the save and managedsave code
paths but was unconditionally setting hasManagedSave to true on
success. As a result, undefine would fail after a non-managed
save/restore operation. E.g.
virsh define; virsh start
virsh save; virsh restore
virsh shutdown
virsh unde
On 05/14/2018 11:19 AM, Michal Privoznik wrote:
> On 05/14/2018 12:45 PM, Peter Krempa wrote:
>> Rather than always re-generating the alias store it in the definition
>> and in the status XML.
>>
>> Signed-off-by: Peter Krempa
>> ---
>> src/qemu/qemu_command.c | 23 +++
On 05/14/2018 06:45 AM, Peter Krempa wrote:
> Move it out of the formatter function and let the caller decide this.
s/formatter/format/
I cannot recall our current consistency... Some times we seem to have
the lowest routine make the singular check and other times we have the
caller make the c
On 05/14/2018 06:45 AM, Peter Krempa wrote:
> Libvirt only manages one PR daemon. This means that we don't need to
> pass the 'disk' object and also rename the functions dealing with this
> so that it's obvious we only deal with the managed PR daemon.
>
> Signed-off-by: Peter Krempa
On 05/14/2018 06:41 AM, Peter Krempa wrote:
> Rather than always checking which path to use pre-assign it when
> preparing storage source.
>
> This reduces the need to pass 'vm' around too much. For later use the
> path can be retrieved from the status XML.
>
> Signed-off-by: Peter Krempa
> --
On 05/14/2018 06:41 AM, Peter Krempa wrote:
> Everything can be disabled by not using the parent element. There's no
> need to store this explicitly. Additionally it does not add any value
> since any configuration is dropped if enabled='no' is configured.
>
> Drop the attribute and adjust the c
On 05/14/2018 06:41 AM, Peter Krempa wrote:
> Everything can be disabled by not using the parent element. There's no
> need to store this explicitly. Additionally it does not add any value
> since any configuration is dropped if enabled='no' is configured.
>
> Drop the attribute and adjust the c
On 14 May 2018, at 8:51, Roman Bogorodskiy wrote:
> Peter Krempa wrote:
>
>> On Sun, May 13, 2018 at 14:01:25 +0400, Roman Bogorodskiy wrote:
>>> Fabian Freyer wrote:
>>
>> [...]
>>
13 files changed, 134 insertions(+)
create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-wired.a
On 05/14/2018 03:43 AM, Boris Fiuczynski wrote:
> On 05/10/2018 10:52 PM, John Ferlan wrote:
>>
>>
>> On 05/07/2018 10:41 AM, Boris Fiuczynski wrote:
>>> From: Shalini Chellathurai Saroja
>>>
>>> Introduces the vfio-ccw model for mediated devices and prime vfio-ccw
>>> devices such that CCW addr
On 05/11/2018 11:50 AM, Ján Tomko wrote:
A function that keeps the hash in binary form instead of converting
it to human-readable hexadecimal form.
Signed-off-by: Ján Tomko
---
src/util/vircrypto.c | 31 +--
src/util/vircrypto.h | 7 +++
2 files changed, 28
On 05/14/2018 12:41 PM, Peter Krempa wrote:
> Everything can be disabled by not using the parent element. There's no
> need to store this explicitly. Additionally it does not add any value
> since any configuration is dropped if enabled='no' is configured.
>
> Drop the attribute and adjust the cod
On 05/14/2018 12:41 PM, Peter Krempa wrote:
> The XML design for the PR stuff is slightly weird so fix it and refactor
> the code so that it will be much easier to use it with the blockdev
> infrastructure.
>
> Peter Krempa (13):
> qemu: hotplug: Fix spacing around addition operator
> qemu: al
On 05/14/2018 12:45 PM, Peter Krempa wrote:
> Rather than always re-generating the alias store it in the definition
> and in the status XML.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_command.c | 23 +++--
> src/qemu/qemu_command.h |
Hi,
I would like to make the next libvirt-dbus release with stable APIs,
there is a lot of them already implemented and other projects can start
adapting to use libvirt-dbus.
The release version would be 1.0.0 and currently libvirt-dbus will
cover APIs up to libvirt-3.0.0 as a start point because
On Mon, May 14, 2018 at 16:20:53 +0200, Marc Hartmayer wrote:
> On Mon, May 14, 2018 at 01:15 PM +0200, Prerna Saxena
> wrote:
> > This patch is used to interpret domain XML and store the Loader &
> > Nvram's backing definitions as virStorageSource.
> > It also identifies if input XML used old or
On Mon, 2018-05-14 at 16:12 +0200, Michal Privoznik wrote:
> This OSX support is becoming more and more hairy. It's fairly often
> broken and we do nothing but compile test it (we don't even run make
> check there). So we can't be really sure the compiled virsh/client
> library still works there. I
On Mon, May 14, 2018 at 01:15 PM +0200, Prerna Saxena
wrote:
> This patch is used to interpret domain XML and store the Loader &
> Nvram's backing definitions as virStorageSource.
> It also identifies if input XML used old or new-style declaration.
> (This will later be used by the formatter).
>
On 05/14/2018 12:07 PM, Andrea Bolognani wrote:
> numpy (needed by cgal) started having the same issue with
> linking as python, which makes upgrade and thus the entire
> build fail on macOS.
>
> Instead of playing more tricks with linking/unlinking, just
> uninstall the problematic packages (and
On 05/10/2018 11:13 PM, Martin Kletzander wrote:
> Add libvirt.la into qemucapsprobemock_la_LIBADD because that mock uses bunch
> of
> libvirt internal functions. Without this patch the following error occurs:
>
> $ ./qemucapsprobe /usr/bin/qemu-system-x86_64
> ...
> warning : virQEMUCapsL
Historically we matched log filters with strstr(), and when switching to
fnmatch in cbb0fd3cfdc287f6f4653ef1f04a7cfb2ea51b27, it was stated that
we would continue to match substrings, with "foo" being equivalent to
"*foo*". Unfortuntely I forget to provide the code to actually make that
happen. Thi
On 05/14/2018 09:18 AM, Maciej Wolny wrote:
> On 14/05/18 13:40, Martin Kletzander wrote:
>> On Mon, May 14, 2018 at 08:27:35AM -0400, John Ferlan wrote:
>>>
>>>
>>> On 05/14/2018 07:24 AM, Martin Kletzander wrote:
On Fri, May 11, 2018 at 03:09:20PM +0100, Maciej Wolny wrote:
> On 11/05/
On 14/05/18 13:40, Martin Kletzander wrote:
> On Mon, May 14, 2018 at 08:27:35AM -0400, John Ferlan wrote:
>>
>>
>> On 05/14/2018 07:24 AM, Martin Kletzander wrote:
>>> On Fri, May 11, 2018 at 03:09:20PM +0100, Maciej Wolny wrote:
On 11/05/18 09:42, Martin Kletzander wrote:
> On Thu, May 1
On Mon, May 14, 2018 at 11:17:51AM +0200, Michal Privoznik wrote:
On 05/11/2018 05:50 PM, Ján Tomko wrote:
A function that keeps the hash in binary form instead of converting
it to human-readable hexadecimal form.
Signed-off-by: Ján Tomko
---
src/util/vircrypto.c | 31 +---
On Mon, May 14, 2018 at 08:27:35AM -0400, John Ferlan wrote:
On 05/14/2018 07:24 AM, Martin Kletzander wrote:
On Fri, May 11, 2018 at 03:09:20PM +0100, Maciej Wolny wrote:
On 11/05/18 09:42, Martin Kletzander wrote:
On Thu, May 10, 2018 at 11:53:57AM +0100, Maciej Wolny wrote:
Support OpenG
$SUBJ:
docs: Update news.xml with QEMU SDL OpenGL Improvement
On 05/11/2018 10:47 AM, Maciej Wolny wrote:
> Signed-off-by: Maciej Wolny
> ---
> docs/news.xml | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 80181415c..e4a10f667 100644
>
On 05/14/2018 07:24 AM, Martin Kletzander wrote:
> On Fri, May 11, 2018 at 03:09:20PM +0100, Maciej Wolny wrote:
>> On 11/05/18 09:42, Martin Kletzander wrote:
>>> On Thu, May 10, 2018 at 11:53:57AM +0100, Maciej Wolny wrote:
Support OpenGL accelerated rendering when using SDL graphics in th
On Fri, May 11, 2018 at 03:09:20PM +0100, Maciej Wolny wrote:
On 11/05/18 09:42, Martin Kletzander wrote:
On Thu, May 10, 2018 at 11:53:57AM +0100, Maciej Wolny wrote:
Support OpenGL accelerated rendering when using SDL graphics in the
domain config. Add associated test and documentation.
Sign
On Fri, May 11, 2018 at 03:14:26PM +0100, Maciej Wolny wrote:
On 11/05/18 11:34, John Ferlan wrote:> I actually spent some time trying to
figure out which magic incantation
of the virQEMUCaps* would work. I even tried various forms in
virQEMUCapsQMPSchemaQueries, but could not get the flag to b
Signed-off-by: Prerna Saxena
---
src/bhyve/bhyve_command.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
index 9413ae5..2b67014 100644
--- a/src/bhyve/bhyve_command.c
+++ b/src/bhyve/bhyve_command.c
@@ -518,10 +518,
Signed-off-by: Prerna Saxena
---
src/vbox/vbox_common.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c
index 72a24a3..60451a3 100644
--- a/src/vbox/vbox_common.c
+++ b/src/vbox/vbox_common.c
@@ -998,11 +998,16 @@ vbo
Signed-off-by: Prerna Saxena
---
tests/qemuxml2argvdata/bios-nvram-network.args | 31 +++
tests/qemuxml2argvdata/bios-nvram-network.xml | 42 ++
tests/qemuxml2argvtest.c | 1 +
3 files changed, 74 insertions(+)
create mode 100644 te
Given that nvram & loader elements can now be backed by a non-local
source too, adjust all steps leading to generation of
QEMU command line.
Signed-off-by: Prerna Saxena
---
src/qemu/qemu_cgroup.c | 13 +
src/qemu/qemu_command.c | 21 -
src/qemu/q
Signed-off-by: Prerna Saxena
---
src/qemu/qemu_parse_command.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c
index 351425f..9b1a86e 100644
--- a/src/qemu/qemu_parse_command.c
+++ b/
If the initial XML used the old-style declaration as follows:
/path/to/file
we format it as was read.
However, if it used new-style declaration:
The formatter identifies that this is a new-style format
and renders it likewise.
Signed-off-by: Prerna Saxena
---
src/conf/domain_conf.c | 86
Signed-off-by: Prerna Saxena
---
src/security/virt-aa-helper.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
index d0f9876..8217d67 100644
--- a/src/security/virt-aa-helper.c
+++ b/src/security/vir
Today, 'loader' and 'nvram' elements are supposed to be backed by a local disk.
Given that NVRAM data could be network-backed for high availability, this patch
defines XML spec for serving loader & nvram disks via the network.
Signed-off-by: Prerna Saxena
---
docs/schemas/domaincommon.rng | 108
Signed-off-by: Prerna Saxena
---
src/xenapi/xenapi_driver.c | 4 +++-
src/xenconfig/xen_sxpr.c | 19 +++
src/xenconfig/xen_xm.c | 9 ++---
3 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c
index 42b
This patch is used to interpret domain XML and store the Loader &
Nvram's backing definitions as virStorageSource.
It also identifies if input XML used old or new-style declaration.
(This will later be used by the formatter).
Signed-off-by: Prerna Saxena
---
src/conf/domain_conf.c | 131
Signed-off-by: Prerna Saxena
---
docs/formatdomain.html.in | 36 +---
1 file changed, 33 insertions(+), 3 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index caeb14e..b8cb7ac 100644
--- a/docs/formatdomain.html.in
+++ b/docs/forma
Libvirt domain XML today only allows local filepaths that can be
used to specify a loader element or its matching NVRAM disk.
Given that Vms may themselves move across hypervisor hosts, it should be
possible to allocate loaders/NVRAM disks on network storage for
uninterrupted access.
This series e
Augment definition to include virStorageSourcePtr that
more comprehensively describes the nature of backing element.
Also include flags for annotating if input XML definition is
old-style or new-style.
Signed-off-by: Prerna Saxena
---
src/conf/domain_conf.h | 11 +--
1 file changed, 9 in
Rather than always re-generating the alias store it in the definition
and in the status XML.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 23 +++--
src/qemu/qemu_command.h | 3 +--
src/qemu/qemu_domain.c| 16 ++
Move it out of the formatter function and let the caller decide this.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 9 +++--
src/qemu/qemu_hotplug.c | 3 +++
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 7df
The function can be replaced by much simpler logic.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 44 +++-
1 file changed, 3 insertions(+), 41 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 9481123c19..96042b
Extract the lookup code so that it can be reused later.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 21 +
src/conf/domain_conf.h | 3 +++
src/libvirt_private.syms | 1 +
src/qemu/qemu_process.c | 23 ++-
4 files changed, 27 insertions(+
Libvirt only manages one PR daemon. This means that we don't need to
pass the 'disk' object and also rename the functions dealing with this
so that it's obvious we only deal with the managed PR daemon.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 6 +++---
src/qemu/qemu_process.c |
Everything can be disabled by not using the parent element. There's no
need to store this explicitly. Additionally it does not add any value
since any configuration is dropped if enabled='no' is configured.
Drop the attribute and adjust the code accordingly.t
Signed-off-by: Peter Krempa
---
doc
The comment did not accurately describe the arguments.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 24b482efd8..d84cf6dffc 100644
--- a/src/qemu/qemu_comma
To allow storing status information in the XML move the validation that
the 'path' is not valid for managed PR daemon case into
qemuDomainValidateStorageSource and allow parsing of the data even in
case when managed='yes'.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c| 18 ++
For use with blockdev the PR manager will be bound to a virStorageSource
rather than a virDomainDiskDef, so we will need to use the correct
alias.
Allow passing a string rather than the whole disk.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_alias.c | 4 ++--
src/qemu/qemu_alias.h | 2 +-
The function now does not do anything useful. Replace it by the pointer
check.
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 -
src/qemu/qemu_command.c | 4 ++--
src/qemu/qemu_domain.c| 8
src/qemu/qemu_hotplug.c | 2 +-
src/util/virstoragefile.c | 7 ---
src
Rather than always checking which path to use pre-assign it when
preparing storage source.
This reduces the need to pass 'vm' around too much. For later use the
path can be retrieved from the status XML.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 18 +-
src/qemu/q
Disk source definition should be validated in
qemuDomainValidateStorageSource rather than in individual generators of
command line arguments.
Change to the XML2XML test is required since now the definition is
actually validated at define time.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_comma
The XML design for the PR stuff is slightly weird so fix it and refactor
the code so that it will be much easier to use it with the blockdev
infrastructure.
Peter Krempa (13):
qemu: hotplug: Fix spacing around addition operator
qemu: alias: Allow passing alias of parent when generating PR mana
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index f3ff945787..1d748ccffb 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -484,7 +484,7 @@ qemuDom
On Fri, May 11, 2018 at 06:16:56PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Network.xml | 2 +-
> src/network.c| 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP
On Fri, May 11, 2018 at 06:16:55PM +0200, Katerina Koukiou wrote:
> Follow this pattern even if negative values will not
> appear, in order to be consistent with libvirt APIs.
>
> Signed-off-by: Katerina Koukiou
> ---
> Added type change for MemoryStats
>
> data/org.libvirt.Connect.xml | 18
On Fri, May 11, 2018 at 06:16:54PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> src/network.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Some explanation would be nice, something like:
Commit 8eac355f3e removed *TypedToString conversion but missed to
upd
On Fri, May 11, 2018 at 05:49:23PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> Return empty string when variable is NULL
>
> data/org.libvirt.Domain.xml | 8
> src/events.c| 31 +++
> 2 files changed, 39 insertion
On Fri, May 11, 2018 at 05:49:22PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> Return empty string when variable is NULL
>
> data/org.libvirt.Domain.xml | 9 +++
> src/events.c| 60
> +
> src/util.h
On Fri, May 11, 2018 at 05:49:21PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> Use only v2 of BlockJob
>
> data/org.libvirt.Domain.xml | 8
> src/events.c| 28
> 2 files changed, 36 insertions(+)
Reviewed-by: Pa
On Mon, May 14, 2018 at 12:07:45PM +0200, Andrea Bolognani wrote:
> numpy (needed by cgal) started having the same issue with
> linking as python, which makes upgrade and thus the entire
> build fail on macOS.
>
> Instead of playing more tricks with linking/unlinking, just
> uninstall the problema
numpy (needed by cgal) started having the same issue with
linking as python, which makes upgrade and thus the entire
build fail on macOS.
Instead of playing more tricks with linking/unlinking, just
uninstall the problematic packages (and those dragging them
in) before doing anything else.
Signed-
On 05/11/2018 05:50 PM, Ján Tomko wrote:
> A function that keeps the hash in binary form instead of converting
> it to human-readable hexadecimal form.
>
> Signed-off-by: Ján Tomko
> ---
> src/util/vircrypto.c | 31 +--
> src/util/vircrypto.h | 7 +++
> 2 files c
On 05/11/2018 05:50 PM, Ján Tomko wrote:
> Ján Tomko (5):
> vircrypto: provide constants for hash sizes
> Introduce virCryptoHashBuf
> esx: use virCryptoHashBuf
> esx: Use VIR_CRYPTO_HASH_SIZE_MD5
> vircrypto: Rely on GnuTLS for hash functions
>
> bootstrap.conf |
On 05/10/2018 10:52 PM, John Ferlan wrote:
On 05/07/2018 10:41 AM, Boris Fiuczynski wrote:
From: Shalini Chellathurai Saroja
Introduces the vfio-ccw model for mediated devices and prime vfio-ccw
devices such that CCW address will be generated.
Signed-off-by: Shalini Chellathurai Saroja
Rev
On Mon, May 14, 2018 at 09:13:19AM +0200, Andrea Bolognani wrote:
Clang catches the issue:
../../src/connect.c:532:26: error: unused variable 'domain'
[-Werror,-Wunused-variable]
g_autoptr(virDomain) domain = NULL;
^
Signed-off-by: Andrea Bolognani
---
src/conn
Clang catches the issue:
../../src/connect.c:532:26: error: unused variable 'domain'
[-Werror,-Wunused-variable]
g_autoptr(virDomain) domain = NULL;
^
Signed-off-by: Andrea Bolognani
---
src/connect.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/con
On Mon, May 14, 2018 at 12:32:12AM +0200, c...@lse.epita.fr wrote:
From: Clementine Hayat
Follow-up of
https://www.redhat.com/archives/libvir-list/2018-April/msg01591.html
Here is the changes asked by Ján Tomko:
* Refactor also checks when the error message is close to "domain is not
running
71 matches
Mail list logo