Re: [libvirt] Matching the type of mediated devices in the migration

Hi Alex and Kirti: Thanks for your reply and discussion. :) Sorry for my late reply since there quite some work and email needs to be caught up after my vacation. From my point of view, failing the migration because of the mismatch of version in different levels provides different

Re: [libvirt] Missing repo file for virt-preview repo on fedorapeople

On 08/10/2018 04:20 AM, Roman Mohr wrote: On Fri, Aug 10, 2018 at 10:02 AM Andrea Bolognani > wrote: On Fri, 2018-08-10 at 08:54 +0200, Roman Mohr wrote: > Hi everyone, > > Is there a change on how to get the fedora-virt-preview.repo? >

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

On Fri, Aug 10, 2018 at 06:36:46PM +0300, Ivan Mishonov wrote: > Yes, that makes sense. I'll try to find some time next week to redo my code > and send another patch. Since my time for working on libvirt is very limited > can you confirm that the LPC configuration should look like this: > >    >

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

Yes, that makes sense. I'll try to find some time next week to redo my code and send another patch. Since my time for working on libvirt is very limited can you confirm that the LPC configuration should look like this:          Also can you send me an example of how you imagine the

Re: [libvirt] [PATCH 16/17] vircgroup: Introduce virCgroupGetMemoryStat

On Fri, Aug 10, 2018 at 10:44:39AM +0200, Michal Privoznik wrote: > On 08/09/2018 03:44 PM, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/libvirt_private.syms | 1 + > > src/util/vircgroup.c | 88 > > src/util/vircgroup.h |

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

On Fri, Aug 10, 2018 at 06:11:57PM +0300, Ivan Mishonov wrote: > I'd like to hear Roman's opinion on this too since he wrote the initial > implementation. As for the command line arguments I was looking at > since it's doing exactly the same thing and I thought it > would be nice to be consistent

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

I'd like to hear Roman's opinion on this too since he wrote the initial implementation. As for the command line arguments I was looking at since it's doing exactly the same thing and I thought it would be nice to be consistent with it Regards, Ivan On 08/10/2018 05:57 PM, Daniel P. Berrangé

Re: [libvirt] [PATCH v2 20/20] qemu: ensure that memory 'discard' is used if specified in XML

On Fri, Aug 10, 2018 at 09:26:27AM +0200, Michal Privoznik wrote: > On 08/09/2018 02:38 PM, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/qemu/qemu_command.c| 4 +++- > > .../pages-discard-hugepages.args | 11 +++ > >

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

On Fri, Aug 10, 2018 at 05:47:40PM +0300, Ivan Mishonov wrote: > Yes, this is totally doable. I just don't know if it's a good idea to add a > new device type specifically for bhyve LPC and nothing else. Even if we do > it like this I'll still have to send another patch including the bhyve XML >

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

Yes, this is totally doable. I just don't know if it's a good idea to add a new device type specifically for bhyve LPC and nothing else. Even if we do it like this I'll still have to send another patch including the bhyve XML namespace as we need to be able to pass extra command line options

Re: [libvirt] [PATCH] src: Move DLOPEN_LIBS to libraries introducing the dependency

On 08/09/2018 11:45 PM, Michal Privoznik wrote: There are few places where dlopen() is called. This call means we have to link with DLOPEN_LIBS. However, instead of having each final, installable library linking with it, move the directive to the source that introduced the dependency.

Re: [libvirt] [PATCH v2] storage: add wipeVol to iscsi-direct storage backend

On 08/10/2018 03:33 PM, c...@lse.epita.fr wrote: > From: Clementine Hayat > > Change set volume capacity to get volume capacity and put the connection > and helpers in one function to avoid code duplicates. > > Signed-off-by: Clementine Hayat > --- > > Set BLOCK_PER_PACKET to 128. Not sure

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

On Fri, Aug 10, 2018 at 03:41:09PM +0300, Ivan Mishonov wrote: > This is how it's described in bhyve(8). Basically you need to configure one > for each bhyve VM. Otherwise the VM won't boot. I'm not sure if there's an > equivalent device in other Hypervisors. I've used KVM for quite some time >

[libvirt] [jenkins-ci PATCH] projects: Document rationale for skipping jobs

In general, we strive for full coverage and build all projects on all targets; however, in some cases that's simply not feasible and we have to skip the corresponding job. Document the rationale for each such case. Signed-off-by: Andrea Bolognani --- projects/libvirt-dbus.yaml| 3 +++

Re: [libvirt] [PATCH v2] storage: add wipeVol to iscsi-direct storage backend

On Fri, Aug 10, 2018 at 03:33:59PM +0200, c...@lse.epita.fr wrote: From: Clementine Hayat Change set volume capacity to get volume capacity and put the connection and helpers in one function to avoid code duplicates. virStorageBackendISCSIDirectSetConnection addition should be in a separate

Re: [libvirt] [PATCH 1/2] Add API for printing tables.

On 08/10/2018 11:11 AM, Simon Kobyda wrote: > It solves problems with alignment of columns. Width of each column > is calculated by its biggest cell. Should solve unicode bug. > In future, it may be implemented in virsh, virt-admin... > > This API has 5 public functions: > - vshTableNew - adds

Re: [libvirt] [PATCH 2/2] virsh: Implement new table API for virsh list

On 08/10/2018 11:11 AM, Simon Kobyda wrote: > Instead of printing it straight in virsh, it creates table struct > which is filled with header and rows(domains). It allows us to know > more about table before printing to calculate alignment right. > > Signed-off-by: Simon Kobyda > --- >

[libvirt] [jenkins-ci PATCH 1/5] jobs: Call rpmbuild explicitly for Python projects

Instead of using the custom 'rpm' target of setup.py, generate a dist archive using the 'sdist' target and then call rpmbuild ourselves: this way we can define _topdir and stop artifacts from ending up in ~/rpmbuild. Signed-off-by: Andrea Bolognani --- jobs/python-distutils.yaml | 4 +++- 1

[libvirt] [jenkins-ci PATCH 4/5] jobs: Minimize strip_buildrequires

We can drop some entries and tweak some others to be less verbose without losing in functionality. Signed-off-by: Andrea Bolognani --- jobs/defaults.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/jobs/defaults.yaml b/jobs/defaults.yaml index e4d1f2c..bab5bc4 100644

[libvirt] [jenkins-ci PATCH 3/5] jobs: Introduce strip_buildrequires

There's no harm in attempting to strip more BuildRequires than are present in a spec file, so define a shell snippet we can reuse for the the purpose without duplicating the same lines all over the place. Signed-off-by: Andrea Bolognani --- jobs/autotools.yaml| 4 +---

[libvirt] [jenkins-ci PATCH 5/5] jobs: Don't remove non-existing archives

None of our jobs create the archives as a side-effect, so trying to remove them before generating them is pointless. Signed-off-by: Andrea Bolognani --- jobs/autotools.yaml| 1 - jobs/perl-modulebuild.yaml | 1 - jobs/python-distutils.yaml | 1 - 3 files changed, 3 deletions(-) diff

[libvirt] [jenkins-ci PATCH 2/5] jobs: Call rpmbuild and sed consistently

Doing so will allow us to refactor away the common parts. Signed-off-by: Andrea Bolognani --- jobs/autotools.yaml| 8 jobs/perl-modulebuild.yaml | 6 +++--- jobs/python-distutils.yaml | 2 +- projects/osinfo-db.yaml| 2 +- 4 files changed, 9 insertions(+), 9 deletions(-)

[libvirt] [jenkins-ci PATCH 0/5] Drop last use of ~/rpmbuild, other cleanups

Patch 1/5 ensures ~/rpmbuild is no longer used, while the remaining ones increase consistency in the various rules used to build RPMs. Andrea Bolognani (5): jobs: Call rpmbuild explicitly for Python projects jobs: Call rpmbuild and sed consistently jobs: Introduce strip_buildrequires

[libvirt] [PATCH v2] storage: add wipeVol to iscsi-direct storage backend

From: Clementine Hayat Change set volume capacity to get volume capacity and put the connection and helpers in one function to avoid code duplicates. Signed-off-by: Clementine Hayat --- Set BLOCK_PER_PACKET to 128. Not sure about this value. Should be potentially tuned.

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

This is how it's described in bhyve(8). Basically you need to configure one for each bhyve VM. Otherwise the VM won't boot. I'm not sure if there's an equivalent device in other Hypervisors. I've used KVM for quite some time and didn't need to configure anything similar lpc LPC

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

On Fri, Aug 10, 2018 at 03:20:06PM +0300, Ivan Mishonov wrote: > The problem is that LPC is not defined as a device in the XML. Is there a > device type we can use for the LPC slot configuration similarly to disk, NIC > etc? I couldn't find one, but I'm not that familiar with the code so maybe >

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

The problem is that LPC is not defined as a device in the XML. Is there a device type we can use for the LPC slot configuration similarly to disk, NIC etc? I couldn't find one, but I'm not that familiar with the code so maybe I'm missing something Regards, Ivan On 08/10/2018 02:34 PM, Daniel

Re: [libvirt] [jenkins-ci PATCH 1/6] guests: Don't prepare Ubuntu 16.04 for virt-manager

On Fri, 2018-08-10 at 13:16 +0200, Erik Skultety wrote: > To be honest, I kinda was counting on you sending a follow-up regardless of > my comment, because as you said, it's always better to document this properly > in relevant files :). At the same time though, I needed to experience e.g. the >

Re: [libvirt] [PATCH] storage: add wipeVol to iscsi-direct storage backend

On 08/10/2018 01:12 PM, c...@lse.epita.fr wrote: > From: Clementine Hayat > > Change set volume capacity to get volume capacity to avoid code > duplicate. > > Signed-off-by: Clementine Hayat > --- > > Set BLOCK_PER_PACKET to 128. Not sure about this value. Should be > potentially tuned. > >

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

On Fri, Aug 10, 2018 at 02:22:32PM +0300, Ivan Mishonov wrote: > Windows UEFI guests didn't have working keyboard input through VNC > when LPC is on slot 1. The FreeBSD Handbook examples use slot 31 > for UEFI guests. Borrowed most of the code from the qemu:commandline > implementation and made

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

On Fri, Aug 10, 2018 at 10:38:10AM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: > > G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: > > https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits > > Our min

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

On Fri, Aug 10, 2018 at 01:16:20PM +0200, Michal Privoznik wrote: > On 08/10/2018 01:03 PM, Michal Privoznik wrote: > > On 08/10/2018 11:38 AM, Daniel P. Berrangé wrote: > >> On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: > >>> G_ADD_PRIVATE was added in 2.38 and older functions

[libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

Windows UEFI guests didn't have working keyboard input through VNC when LPC is on slot 1. The FreeBSD Handbook examples use slot 31 for UEFI guests. Borrowed most of the code from the qemu:commandline implementation and made LPC slot number configurable e.g. Ivan Mishonov (1): bhyve: Make

[libvirt] [PATCH 1/1] bhyve: Make LPC slot number configurable

Signed-off-by: Ivan Mishonov --- docs/schemas/domaincommon.rng | 15 ++ src/bhyve/bhyve_command.c | 7 ++- src/bhyve/bhyve_conf.c| 12 + src/bhyve/bhyve_conf.h| 9 src/bhyve/bhyve_device.c | 16 --- src/bhyve/bhyve_domain.c | 86

Re: [libvirt] [jenkins-ci PATCH 1/6] guests: Don't prepare Ubuntu 16.04 for virt-manager

On Fri, Aug 10, 2018 at 12:24:46PM +0200, Andrea Bolognani wrote: > On Fri, 2018-08-10 at 10:31 +0200, Erik Skultety wrote: > > On Thu, Aug 09, 2018 at 03:16:38PM +0200, Andrea Bolognani wrote: > > > virt-manager can't be built successfully on the > > > platform, so we shouldn't install the

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

On 08/10/2018 01:03 PM, Michal Privoznik wrote: > On 08/10/2018 11:38 AM, Daniel P. Berrangé wrote: >> On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: >>> G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: >>>

[libvirt] [PATCH] storage: add wipeVol to iscsi-direct storage backend

From: Clementine Hayat Change set volume capacity to get volume capacity to avoid code duplicate. Signed-off-by: Clementine Hayat --- Set BLOCK_PER_PACKET to 128. Not sure about this value. Should be potentially tuned. src/storage/storage_backend_iscsi_direct.c | 152 +++--

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

On 08/10/2018 11:38 AM, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: >> G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: >> https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits > > Our min glib2 version is

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

On Fri, Aug 10, 2018 at 10:38:10AM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: > > G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: > > https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits > > Our min

Re: [libvirt] [jenkins-ci PATCH 1/6] guests: Don't prepare Ubuntu 16.04 for virt-manager

On Fri, 2018-08-10 at 10:31 +0200, Erik Skultety wrote: > On Thu, Aug 09, 2018 at 03:16:38PM +0200, Andrea Bolognani wrote: > > virt-manager can't be built successfully on the > > platform, so we shouldn't install the corresponding > > build dependencies. > > For the sake of history, it would be

Re: [libvirt] [PATCH v1 1/6] virlockspace: Introduce VIR_LOCK_SPACE_ACQUIRE_METADATA flag

On Thu, Aug 09, 2018 at 03:34:39PM +0200, Michal Privoznik wrote: > This flag is going to be used to alter default behaviour of the > lock. Firstly, it means we will lock different offset in the file > (offset 1 instead of 0). Secondly, it means the lock acquiring > will actually wait for the lock

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: > G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: > https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits Our min glib2 version is currently 2.36, since that's what RHEL-7 has. So this change

[libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits Signed-off-by: Michal Privoznik --- This was generated mostly using: sed -i "s/G_DEFINE_TYPE(/G_DEFINE_TYPE_WITH_PRIVATE(/ sed -i

[libvirt] [PATCH 1/2] Add API for printing tables.

It solves problems with alignment of columns. Width of each column is calculated by its biggest cell. Should solve unicode bug. In future, it may be implemented in virsh, virt-admin... This API has 5 public functions: - vshTableNew - adds new table and defines its header - vshTableRowAppend -

[libvirt] [PATCH 2/2] virsh: Implement new table API for virsh list

Instead of printing it straight in virsh, it creates table struct which is filled with header and rows(domains). It allows us to know more about table before printing to calculate alignment right. Signed-off-by: Simon Kobyda --- tools/virsh-domain-monitor.c | 39

Re: [libvirt] [PATCH 05/17] vircgroup: Extract file link resolving into separate function

On 08/09/2018 03:44 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/util/vircgroup.c | 85 +--- > 1 file changed, 48 insertions(+), 37 deletions(-) > > diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c > index

Re: [libvirt] [PATCH 16/17] vircgroup: Introduce virCgroupGetMemoryStat

On 08/09/2018 03:44 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/libvirt_private.syms | 1 + > src/util/vircgroup.c | 88 > src/util/vircgroup.h | 7 > 3 files changed, 96 insertions(+) > > diff --git

Re: [libvirt] [PATCH 00/17] some cgroup cleanup patches

On 08/09/2018 03:43 PM, Pavel Hrdina wrote: > Preparation for cgroupv2 support. > > Pavel Hrdina (17): > docs: List cpuacct in controllers used by QEMU driver > docs: Update how we create cgroup directory names > vircgroup: Rename structs to start with underscore > vircgroup: Introduce

Re: [libvirt] [jenkins-ci PATCH 6/6] projects: Build libvirt-dbus on Debian 8

On Thu, Aug 09, 2018 at 03:16:43PM +0200, Andrea Bolognani wrote: > As with CentOS 7, we can't run 'make check' on the > platform because we don't have a recent enough Python > interpreter, but the daemon itself will build and run > just fine. > > Signed-off-by: Andrea Bolognani > ---

Re: [libvirt] [jenkins-ci PATCH 2/6] guests: Don't prepare CentOS 7 for libvirt-sandbox

On Thu, Aug 09, 2018 at 03:16:39PM +0200, Andrea Bolognani wrote: > libvirt-sandbox can't be built successfully on the > platform, so we shouldn't install the corresponding > build dependencies. Same comment as in patch 1. With that addressed: Reviewed-by: Erik Skultety > > Signed-off-by:

Re: [libvirt] [jenkins-ci PATCH 1/6] guests: Don't prepare Ubuntu 16.04 for virt-manager

On Thu, Aug 09, 2018 at 03:16:38PM +0200, Andrea Bolognani wrote: > virt-manager can't be built successfully on the > platform, so we shouldn't install the corresponding > build dependencies. > For the sake of history, it would be nice to be a bit more detailed as why it can't be built on a

Re: [libvirt] Missing repo file for virt-preview repo on fedorapeople

On Fri, Aug 10, 2018 at 10:02 AM Andrea Bolognani wrote: > On Fri, 2018-08-10 at 08:54 +0200, Roman Mohr wrote: > > Hi everyone, > > > > Is there a change on how to get the fedora-virt-preview.repo? > > > > So far we were referencing > > > > >

Re: [libvirt] Missing repo file for virt-preview repo on fedorapeople

On Fri, 2018-08-10 at 08:54 +0200, Roman Mohr wrote: > Hi everyone, > > Is there a change on how to get the fedora-virt-preview.repo? > > So far we were referencing > > https://fedorapeople.org/groups/virt/virt-preview/fedora-virt-preview.repo > > but that file does not seem to exist anymore.

Re: [libvirt] [PATCH v2 00/20] Fix and improve hugepage code

On 08/09/2018 02:38 PM, Pavel Hrdina wrote: > changes in v2: > - renamed existing test cases to sensible names > - split of some existing test cases > - fixed uncovered issue with memory discard > > v1: https://www.redhat.com/archives/libvir-list/2018-July/msg00667.html > > Pavel

Re: [libvirt] [PATCH v2 20/20] qemu: ensure that memory 'discard' is used if specified in XML

On 08/09/2018 02:38 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_command.c| 4 +++- > .../pages-discard-hugepages.args | 11 +++ > tests/qemuxml2argvdata/pages-discard.args | 18 ++ > 3 files

Re: [libvirt] [PATCH v3 0/3] Don't touch user data from tests

On 07/27/2018 05:24 PM, Michal Privoznik wrote: > v3 of: > > https://www.redhat.com/archives/libvir-list/2018-July/msg00747.html > > diff to v2: > - pushed some already ACKed patches > - dropped controversial line from 1/3 that turned off error reporting > > Michal Prívozník (3): >

[libvirt] Missing repo file for virt-preview repo on fedorapeople

Hi everyone, Is there a change on how to get the fedora-virt-preview.repo? So far we were referencing https://fedorapeople.org/groups/virt/virt-preview/fedora-virt-preview.repo but that file does not seem to exist anymore. Best Regards, Roman -- libvir-list mailing list libvir-list@redhat.com