Signed-off-by: Andrea Bolognani
---
...erfile => fedora-36-cross-mingw32.Dockerfile} | 2 +-
...erfile => fedora-36-cross-mingw64.Dockerfile} | 2 +-
ci/gitlab/builds.yml | 14 +++---
ci/gitlab/containers.yml | 8 --
Signed-off-by: Andrea Bolognani
---
ci/containers/fedora-36.Dockerfile | 108 +
ci/gitlab/builds.yml | 10 +++
ci/gitlab/containers.yml | 7 ++
ci/integration.yml | 16 +
ci/manifest.yml| 2 +
5
Signed-off-by: Andrea Bolognani
---
ci/containers/fedora-34.Dockerfile | 109 -
ci/gitlab.yml | 20 --
ci/integration.yml | 16 -
ci/manifest.yml| 8 ---
4 files changed, 153 deletions(-)
delete
Test pipeline:
https://gitlab.com/abologna/libvirt/-/pipelines/548549670
Matching libvirt-perl MR, needed because the integration tests
download artifacts from there:
https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/63
Andrea Bolognani (4):
ci: Drop Fedora 34
ci: Refresh
Notable changes:
* 'lcitool manifest' now generates GitLab CI rules spread
across a bunch of files;
* container images are built less frequently for the main
repository.
Signed-off-by: Andrea Bolognani
---
ci/gitlab.yml | 747 +-
ci
On Tue, May 24, 2022 at 03:41:47PM +0200, Michal Prívozník wrote:
> On 5/24/22 15:31, Andrea Bolognani wrote:
> > prohibit_doubled_words_ = \
> > -the then in an on if is it but for or at and do to
> > +the then in an on if is it but for or at and do to can
&g
On Tue, May 24, 2022 at 10:02:42AM -0300, Daniel Henrique Barboza wrote:
> Update NEWS.rst with the now added Power10 processor support.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
> NEWS.rst | 4
> 1 file changed, 4 insertions(+)
Reviewed-by: Andrea Bolognani
--
tCPUDef d);
Spurious whitespace change. Please remove it before pushing.
Regardless of whether or not you decide to minimize the input and
output files according to the suggestions above,
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 3ae5abd11a..73f8a21c1b 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
the file will know
the range of gnulib commits that they have to consider.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 4
1 file changed, 4 insertions(+)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 09e7a014a3..3ae5abd11a 100644
--- a/build
Andrea Bolognani (2):
syntax-check: Add versioning information
syntax-check: Pull updates from gnulib
build-aux/syntax-check.mk | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
--
2.35.3
On Fri, May 20, 2022 at 05:49:53PM -0300, Daniel Henrique Barboza wrote:
> On 5/19/22 04:44, Andrea Bolognani wrote:
> > On Tue, May 17, 2022 at 05:32:56PM -0300, Daniel Henrique Barboza wrote:
> > > On 5/12/22 04:52, Andrea Bolognani wrote:
> > > > Don't f
The website no longer exists and the PDF file can't even be
retrieved via archive.org.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 1 -
src/util/virnetdevmacvlan.c | 5 +
src/util/virnetlink.c | 4 +---
3 files changed, 2 insertions(+), 8 deletions(-)
diff --git
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 4 +---
src/conf/nwfilter_conf.c| 4 ++--
src/conf/schemas/basictypes.rng | 2 +-
tests/openvzutilstest.conf | 2 +-
4 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 4
docs/apps.rst | 6 +++---
docs/drvhyperv.rst| 2 +-
3 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index e0012ae82f..e0d2a7fe6c 100644
The MinGW-w64 project has effectively replaced the original
MinGW project, and distributions such as Fedora have been shipping
packages based on the former for years now.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 1 -
ci/README.rst | 6 +++---
docs/windows.rst
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 1 -
docs/drvlxc.rst | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index e0d2a7fe6c..762b2e5ccc 100644
--- a/build-aux/syntax-check.mk
+++ b
It doesn't seem to be a current product: there is no proper
website for it, and the most recent installation instructions
I've been able to locate are targeted at RHEL 6.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 1 -
docs/apps.rst | 6 --
2 files changed
The website is still up, but the software itself was last
updated in 2014.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 1 -
docs/apps.rst | 5 -
2 files changed, 6 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index
The website is still up, although the latency is so high that it
could hardly considered usable; the software itself was last
updated in 2015.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 1 -
docs/apps.rst | 5 -
2 files changed, 6 deletions(-)
diff --git
The project is developed as part of GNOME these days, and the
old URL redirects to GNOME's GitLab instance.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 1 -
docs/uri.rst | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/build-aux/syntax
GNU netcat was last updated in 2004. These days, most operating
systems will include either the nmap or OpenBSD variant of the
tool.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 1 -
docs/remote.rst | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 2 --
1 file changed, 2 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 6b54f830f1..64babd402c 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -907,7 +907,6
Reduce the number of exceptions we keep around by various
means.
Andrea Bolognani (11):
syntax-check: Drop unused http_sites
docs: apps: Drop Tivoli Provisioning Manager
docs: apps: Drop Cracow Cloud One
docs: apps: Drop Snooze
util: Drop references to netlink.pdf
docs: Use more
, but these days we
have meson driving the entire build process and each of the
checks is registered as a separate test, which gives us all of
the features described above for free.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 38 --
1 file changed, 38
All checks are added to the syntax-check suite, and this name is
displayed prominently in the output of 'meson test', so there
really is no need to include the sc_ prefix too.
Signed-off-by: Andrea Bolognani
---
build-aux/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 416 +++---
ci/Makefile | 2 +-
2 files changed, 207 insertions(+), 211 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index b770e89efa..0b832706ba 100644
to the top of the file.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 358 +++---
1 file changed, 182 insertions(+), 176 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 13f565d1b8..a37e43b9f6 100644
The makefile is an implementation detail, so point users towards
the proper way of running syntax-check if they happen to call it
directly.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 5 +
1 file changed, 5 insertions(+)
diff --git a/build-aux/syntax-check.mk b/build
We can assume that VC_LIST_ALWAYS_EXCLUDE_REGEX will not be
defined in a way that would catch backup files.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
Signed-off-by: Andrea Bolognani
---
build-aux/Makefile.in | 1 +
build-aux/meson.build | 3 +++
build-aux/syntax-check.mk | 5 -
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/build-aux/Makefile.in b/build-aux/Makefile.in
index 9ccbec7b1b..7ee4680847 100644
The pattern in build-aux/syntax-check.mk is written specifically
so that it won't match itself, which makes having an exception
for the file unnecessary.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build-aux
It's only used in diagnostics, and even there it's not
particularly useful and can make it more difficult to spot the
actual error message.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 58 ++-
1 file changed, 27 insertions(+), 31 deletions
The file src/util/vireventglib.c doesn't contain a main() function
and so it's not even considered by the check.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax
is used
in all the places where it makes sense, and the sc_bindtextdomain
check was disabled entirely via a blanket exception. Drop it
instead of keeping dead code around.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 11 ---
1 file changed, 11 deletions(-)
diff --git
if the user would need
to provide their own exclude patterns, but that scenario is no
longer relevant to us.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index
n.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 8d30b0e75a..5244d4ee2d 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -69
$ meson test --suite blurb
Andrea Bolognani (13):
syntax-check: Drop sc_bindtextdomain check
syntax-check: Remove sc_gettext_init exception
syntax-check: Remove sc_copyright_usage exception
syntax-check: Improve sc_prohibit_config_h_in_headers check
syntax-check: Use VC_LIST_EXCEPT
We already allow this for OVMF.
Closes: https://gitlab.com/libvirt/libvirt/-/issues/312
Signed-off-by: Andrea Bolognani
---
src/security/apparmor/libvirt-qemu | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/security/apparmor/libvirt-qemu
b/src/security/apparmor/libvirt
he link of qemu driver
> docs: drvqemu: Fix the syntax typo of Hypervisor.framework link
Series
Reviewed-by: Andrea Bolognani
and pushed. Thanks!
--
Andrea Bolognani / Red Hat / Virtualization
as spelling GNOME and GNOME Boxes the
preferred way.
[1] https://gitlab.gnome.org/GNOME/gnome-boxes
[2] https://gnomeboxes.org/
[3] https://apps.gnome.org/app/org.gnome.Boxes/
--
Andrea Bolognani / Red Hat / Virtualization
On Tue, May 17, 2022 at 05:32:56PM -0300, Daniel Henrique Barboza wrote:
> On 5/12/22 04:52, Andrea Bolognani wrote:
> > Don't forget to add the new test case to qemuxml2xmltest too.
> >
> > It would be great if, as a follow-up, you could look into converting
tach-interface since v7.7.0
> news: Add queue_size option to virtio disk
> news: Validation flags for creating net, nwfilter-binding, net port
>
> NEWS.rst | 89 ++++++++
> 1 file changed, 89 insertions(+)
Series
Reviewed-by: And
This is something that certainly made sense in the context of
gnulib, but we don't have a use for it.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index
Now that we have dropped prefixes from the file, it no longer
needs to go through configure_file() and we can use it directly.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk| 6 +++---
po/{POTFILES.in => POTFILES} | 0
po/meson.build | 13 +
Make sure LINGUAS remains sorted correctly.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 8
1 file changed, 8 insertions(+)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 513c147cec..6b54f830f1 100644
--- a/build-aux/syntax-check.mk
+++ b
Signed-off-by: Andrea Bolognani
---
po/LINGUAS | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/po/LINGUAS b/po/LINGUAS
index 889ef80aba..35acd33a87 100644
--- a/po/LINGUAS
+++ b/po/LINGUAS
@@ -28,17 +28,17 @@ nl
or
pa
pl
-pt_BR
pt
+pt_BR
ru
-sr@latin
+si
sr
+sr
when generating POTFILES.
Simplify things by not storing information that we know we're
going to discard later.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 4 +-
po/POTFILES.in| 768 +++---
2 files changed, 386 insertions(+), 386
Changes from [v1]
* instead of checking that the potfile doesn't contain unwanted
comments at syntax-check time, prevent them from being added by
passing all xgettext options explicitly ourselves.
[v1] https://listman.redhat.com/archives/libvir-list/2022-May/231526.html
Andrea
.
Most of the options included in the 'glib' preset are not
applicable to libvirt anyway, so just stop using the preset and
pass a few extra options explicitly instead.
Signed-off-by: Andrea Bolognani
---
po/meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/po
These managed to sneak in as part of ec02f5719a87, when the
potfile was last refreshed, but are not supposed to be there.
Signed-off-by: Andrea Bolognani
---
po/libvirt.pot | 216 -
1 file changed, 216 deletions(-)
diff --git a/po/libvirt.pot b
On Tue, May 17, 2022 at 12:19:07PM +0200, Jiri Denemark wrote:
> On Tue, May 17, 2022 at 10:46:21 +0100, Daniel P. Berrangé wrote:
> > On Tue, May 17, 2022 at 02:34:00AM -0700, Andrea Bolognani wrote:
> > > On Tue, May 17, 2022 at 11:11:00AM +0200, Peter Krempa wrot
On Tue, May 17, 2022 at 10:49:47AM +0100, Daniel P. Berrangé wrote:
> On Tue, May 17, 2022 at 02:23:45AM -0700, Andrea Bolognani wrote:
> > On Tue, May 17, 2022 at 11:12:47AM +0200, Peter Krempa wrote:
> > > On Tue, May 17, 2022 at 10:32:12 +0200, Andrea Bolognani wrote:
>
On Tue, May 17, 2022 at 11:11:00AM +0200, Peter Krempa wrote:
> On Tue, May 17, 2022 at 10:32:11 +0200, Andrea Bolognani wrote:
> > These managed to sneak in as part of ec02f5719a87, when the
> > potfile was last refreshed, but are not supposed to be there.
> >
> > Sign
On Tue, May 17, 2022 at 11:12:47AM +0200, Peter Krempa wrote:
> On Tue, May 17, 2022 at 10:32:12 +0200, Andrea Bolognani wrote:
> > +# Before 0.60, meson would sometimes pass options to xgettext in the
> > +# wrong order, resulting in unwanted comments showing up in the
>
Signed-off-by: Andrea Bolognani
---
po/LINGUAS | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/po/LINGUAS b/po/LINGUAS
index 889ef80aba..35acd33a87 100644
--- a/po/LINGUAS
+++ b/po/LINGUAS
@@ -28,17 +28,17 @@ nl
or
pa
pl
-pt_BR
pt
+pt_BR
ru
-sr@latin
+si
sr
+sr
Make sure LINGUAS remains sorted correctly.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 8
1 file changed, 8 insertions(+)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index e7aa2444bf..e8aea29d64 100644
--- a/build-aux/syntax-check.mk
+++ b
Now that we have dropped prefixes from the file, it no longer
needs to go through configure_file() and we can use it directly.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk| 6 +++---
po/{POTFILES.in => POTFILES} | 0
po/meson.build | 13 +
These managed to sneak in as part of ec02f5719a87, when the
potfile was last refreshed, but are not supposed to be there.
Signed-off-by: Andrea Bolognani
---
po/libvirt.pot | 216 -
1 file changed, 216 deletions(-)
diff --git a/po/libvirt.pot b
when generating POTFILES.
Simplify things by not storing information that we know we're
going to discard later.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 4 +-
po/POTFILES.in| 768 +++---
2 files changed, 386 insertions(+), 386
This is something that certainly made sense in the context of
gnulib, but we don't have a use for it.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index
been added to the potfile.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 11 +++
1 file changed, 11 insertions(+)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 6664763faf..b14e2e57cc 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux
msgid ""
"*** BLURB HERE ***"
msgstr ""
Andrea Bolognani (7):
po: Drop unwanted comments from potfile
syntax-check: Introduce sc_pot_comments
po: Drop prefixes from POTFILES.in
po: Don't generate POTFILES
syntax-check: Don't exclude src/false.c from
We have to always store the state of the feature in the
virDomainDef struct, otherwise
will incorrectly be interpreted as if the element was not
present.
Fixes: eeb94215b074a71b3c8932d5fcaf657f269b2c82
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c
Andrea Bolognani (3):
tests: Update smm=on test
tests: Introduce smm=off test
conf: Fix smm=off handling
src/conf/domain_conf.c| 9 +---
...rgs => machine-smm-off.x86_64-latest.args} | 16 ++
tests/qemuxml2argvdata/machine-smm-off.xml|
This complements the existing smm=on tests. Looking at the output
files, one can immediately see how this case is currently not being
handled correctly. We're going to fix that in the next commit.
Signed-off-by: Andrea Bolognani
---
.../machine-smm-off.x86_64-latest.args| 32
Use DO_TEST_CAPS_LATEST() instead of hardcoding capabilities and
add the xml2xml part, which was missing; finally, rename it to
accomodate the complementary smm=off test that we're about to
introduce.
Signed-off-by: Andrea Bolognani
---
...args => machine-smm-on.x86_64-latest.args} |
ies. Easy enough to fix.
Can you please update the NEWS file to mention the new feature?
--
Andrea Bolognani / Red Hat / Virtualization
8 deletions(-)
> create mode 100644 src/cpu_map/ppc64_POWER10.xml
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
On Mon, May 09, 2022 at 07:27:57AM -0300, Daniel Henrique Barboza wrote:
> On 5/9/22 07:00, Andrea Bolognani wrote:
> > Would you be okay with something like
> >
> >There are no major changes since 7.0.0-rc2, but a few additional
> >features are enabled in thi
ges since 7.0.0-rc2, but a few additional
features are enabled in this build.
? If so, I can amend the commit message and push the patch as
Reviewed-by: Andrea Bolognani
As a side note, it's unfortunate that this sort of small change gets
lost in the noise when updating capabilities. I wonder if
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
Using an updated toolchain means we're likely to catch more
issues.
Signed-off-by: Andrea Bolognani
---
ci/gitlab.yml | 16
ci/manifest.yml | 6 +++---
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/ci/gitlab.yml b/ci/gitlab.yml
index f93f6222e8..07ad36809d
On Fri, May 06, 2022 at 11:10:44AM +0100, Daniel P. Berrangé wrote:
> On Fri, May 06, 2022 at 03:00:14AM -0700, Andrea Bolognani wrote:
> > I'm trying to enable CI coverage for macOS 12, but I'm running into a
> > couple of issues that I'm not sure how to handle.
> >
> &g
On Fri, May 06, 2022 at 07:01:53AM -0300, Daniel Henrique Barboza wrote:
> On 5/6/22 04:51, Andrea Bolognani wrote:
> > It'd be great if the capabilities were updated to the actual 7.0.0
> > release, even if the changes are small.
>
> From 7.0.0-rc2 to what I've done (aft
could
investigate? macOS 12 has been out for a while now so I'd be very
keen to have it added to CI.
Thanks in advance!
[1] https://gitlab.com/libvirt/libvirt/-/jobs/2421455154
--
Andrea Bolognani / Red Hat / Virtualization
tial
to catch more issues, so in that regard it would make sense to move
those jobs from 20.04 to 22.04. I'll prepare a follow-up patch that
does just that.
--
Andrea Bolognani / Red Hat / Virtualization
Signed-off-by: Andrea Bolognani
---
ci/containers/ubuntu-2204.Dockerfile | 101 +++
ci/gitlab.yml| 16 +
ci/manifest.yml | 2 +
3 files changed, 119 insertions(+)
create mode 100644 ci/containers/ubuntu-2204.Dockerfile
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/532731034
Andrea Bolognani (2):
ci: Refresh configuration
ci: Add Ubuntu 22.04
ci/containers/ubuntu-2204.Dockerfile | 101 +++
ci/gitlab.yml| 18 -
ci/manifest.yml
Notable changes:
* use the most recent point release for FreeBSD 12.
Signed-off-by: Andrea Bolognani
---
ci/gitlab.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ci/gitlab.yml b/ci/gitlab.yml
index e2247d0f02..a98ceadd79 100644
--- a/ci/gitlab.yml
+++ b/ci/gitlab.yml
> I'll drop this patch and re-send the other two.
It'd be great if the capabilities were updated to the actual 7.0.0
release, even if the changes are small.
And yes, in general we want to generate capabilities from QEMU
binaries that are full-featured, so please make sure you always
i
recognizes.
Considering that LLVM's linker, which is now used by default on
FreeBSD, supports the same --version-script option as the GNU
linker, that we have introduced special handling for macOS, and
that we don't target Solaris, we can simply drop the branch at
this point.
Signed-off-by: Andrea
for unknown-unsupported file format ( 0x23 0x20 0x57 0x41 ... )
being produced during the build.
Signed-off-by: Andrea Bolognani
---
meson.build | 3 +++
src/admin/meson.build | 14 --
src/meson.build | 42 --
tools/nss/meson.build | 18
This ensures variable names and the overall structure of the
code setting and using them is consistent. It will also make
upcoming changes less disruptive.
Signed-off-by: Andrea Bolognani
---
src/admin/meson.build | 20 ++--
src/meson.build | 104
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/532183411
Andrea Bolognani (3):
meson: Refactor handling of link_args and link_depends
meson: Don't attempt to use version scripts on macOS
meson: Drop support for -Wl,-M
meson.build | 5 +-
src/admin/meson.build
On Thu, May 05, 2022 at 11:40:55AM +0100, Daniel P. Berrangé wrote:
> On Thu, May 05, 2022 at 02:13:15AM -0700, Andrea Bolognani wrote:
> > On Thu, May 05, 2022 at 08:57:04AM +0100, Daniel P. Berrangé wrote:
> > > IMHO it is pretty straightforward for apibuild.p
t; open+closed comment block.
This makes sense, at least in theory. I have no idea how difficult it
would be to actually convince apibuild.py to behave this way though.
I can give it a shot, but I'm concerned about falling into a real
rabbit hole with this one. If I don't manage to bend the script to my
will quickly enough, I'll just give up on the idea and leave things
as they are.
--
Andrea Bolognani / Red Hat / Virtualization
Their presence confuses apibuild.py, which considers them to be
part of the previous comment block and so appends them verbatim
to the documentation for virNetworkUpdate().
Signed-off-by: Andrea Bolognani
---
src/libvirt-network.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Andrea Bolognani (2):
lib: Drop "type hint" comments
include: Explicitly reserve values for overlapping flag types
include/libvirt/libvirt-common.h.in | 19 +--
include/libvirt/libvirt-domain.h| 8
src/libvirt-network.c | 4 ++-
nd results in
comments being parsed correctly.
Signed-off-by: Andrea Bolognani
---
include/libvirt/libvirt-common.h.in | 19 +--
include/libvirt/libvirt-domain.h| 8
2 files changed, 21 insertions(+), 6 deletions(-)
diff --git a/include/libvirt/libvirt-common.h.in
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
include/libvirt/libvirt-network.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/libvirt/libvirt-network.h
b/include/libvirt/libvirt-network.h
index d3e3fdeecf..90cde0cf24 100644
--- a/include/libvirt
On Wed, May 04, 2022 at 01:23:25PM +0200, Victor Toso wrote:
> On Wed, Apr 27, 2022 at 02:17:01AM -0700, Andrea Bolognani wrote:
> > > > One more thing. Right now version tags look like
> > > >
> > > > Since: v1.2.3
> > > >
> >
> src/util/virevent.c | 18 +-
> src/util/virtypedparam-public.c | 38 +-
> 34 files changed, 2213 insertions(+), 2213 deletions(-)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
arch(r"\(?Since: v?(\d+\.\d+\.\d+\.?\d?)\)?",
> +return_match = re.search(r"\(?Since: (\d+\.\d+\.\d+\.?\d?)\)?",
> return_comment)
Needless to say, it would be amazing if this didn't have to be
changed in two separate spots...
On Thu, Apr 28, 2022 at 05:55:41PM +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 28, 2022 at 08:33:46AM -0700, Andrea Bolognani wrote:
> > In other words, the current implementation of g_poll() on macOS
> > doesn't follow the contract defined by GLib itself.
On Thu, Apr 28, 2022 at 02:52:45PM +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 28, 2022 at 06:39:42AM -0700, Andrea Bolognani wrote:
> > Shouldn't GLib be
> > changed to do something like
> >
> > #ifndef BROKEN_POLL
> > if (poll() < 0)
> >
return -1;
#else
if (select() < 0)
if (!EBADF)
return -1;
#endif
instead? If acting on an fd that's already been closed is okay when
using the poll()-based implementation, the same should apply to the
select()-based one as well.
--
Andrea Bolognani / Red Hat / Virtualization
On Tue, Apr 26, 2022 at 06:26:26PM +0200, Victor Toso wrote:
> On Tue, Apr 26, 2022 at 04:06:08PM +0000, Andrea Bolognani wrote:
> > Ideas for follow-up work:
> >
> > * improve the generator so that multi-line comments attached to
> > enum values and macros get a
ut
not having it in the documentation in the first place?
--
Andrea Bolognani / Red Hat / Virtualization
It belongs to the comment for VIR_DOMAIN_AFFECT_CONFIG, not to
the unrelated one immediately after it.
Fixes: 807cdbf75976f88e8a23b26951f263029cc9e5f4
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
include/libvirt/libvirt-domain.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
701 - 800 of 8356 matches
Mail list logo
