Re: [libvirt] [RFC] docs: Discourage usage of cache mode=passthrough

On Thu, Sep 28, 2017 at 09:21:41AM +0100, Daniel P. Berrange wrote: > On Thu, Sep 21, 2017 at 01:14:04PM -0400, Laine Stump wrote: > > On 09/19/2017 03:37 PM, Eduardo Habkost wrote: > > > Cache mode=passthrough can result in a broken cache topology if > > > the dom

Re: [libvirt] [RFC] docs: Discourage usage of cache mode=passthrough

On Mon, Nov 06, 2017 at 01:17:02PM +, Daniel P. Berrange wrote: > On Mon, Nov 06, 2017 at 11:10:00AM -0200, Eduardo Habkost wrote: > > On Thu, Sep 28, 2017 at 09:21:41AM +0100, Daniel P. Berrange wrote: > > > On Thu, Sep 21, 2017 at 01:14:04PM -0400, Laine Stump wrote: > &

Re: [libvirt] [RFC] docs: Discourage usage of cache mode=passthrough

On Mon, Nov 06, 2017 at 02:08:31PM +, Daniel P. Berrange wrote: > On Mon, Nov 06, 2017 at 11:43:49AM -0200, Eduardo Habkost wrote: > > On Mon, Nov 06, 2017 at 01:17:02PM +, Daniel P. Berrange wrote: > > > On Mon, Nov 06, 2017 at 11:10:00AM -0200, Eduardo Habkost wrote: &

Re: [libvirt] [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP

On Fri, Oct 20, 2017 at 10:07:27AM +0100, Daniel P. Berrange wrote: > On Thu, Oct 19, 2017 at 05:56:49PM -0200, Eduardo Habkost wrote: > > On Thu, Oct 19, 2017 at 04:28:59PM +0100, Daniel P. Berrange wrote: > > > On Thu, Oct 19, 2017 at 11:21:22AM -0400, Igor Mammedov wrote: >

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

On Fri, May 18, 2018 at 10:48:31AM +0200, Markus Armbruster wrote: > Cc'ing a few more people. > > Daniel Henrique Barboza writes: > > > When issuing the qmp/hmp 'system_wakeup' command, what happens in a > > nutshell is: > > > > - qmp_system_wakeup_request set runstate

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

On Mon, May 21, 2018 at 04:46:36PM -0300, Daniel Henrique Barboza wrote: > > > On 05/21/2018 03:14 PM, Eduardo Habkost wrote: > > > Issue#2: the flag isn't a property of the target. Due to -no-acpi, it's > > > not even a property of the machine type. If it was,

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

On Wed, May 23, 2018 at 11:17:55AM +0200, Markus Armbruster wrote: > Eduardo Habkost <ehabk...@redhat.com> writes: > > On Mon, May 21, 2018 at 04:46:36PM -0300, Daniel Henrique Barboza wrote: [...] > >> Since no objection was made back then, this logic was put into qu

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

On Fri, May 25, 2018 at 08:30:59AM +0200, Markus Armbruster wrote: > Eduardo Habkost <ehabk...@redhat.com> writes: > > On Wed, May 23, 2018 at 05:53:34PM +0200, Markus Armbruster wrote: [...] > >> >> Worse, a machine type property that is static for all machine types

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

On Wed, May 23, 2018 at 05:53:34PM +0200, Markus Armbruster wrote: > Eduardo Habkost <ehabk...@redhat.com> writes: > > > On Wed, May 23, 2018 at 11:17:55AM +0200, Markus Armbruster wrote: > >> Eduardo Habkost <ehabk...@redhat.com> writes: > >> > On

Re: [libvirt] [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

CCing libvir-list. On Mon, Jun 11, 2018 at 11:29:24PM +0200, Igor Mammedov wrote: > On Mon, 11 Jun 2018 16:06:07 -0300 > Eduardo Habkost wrote: > > > On Mon, Jun 11, 2018 at 03:16:25PM +0200, Igor Mammedov wrote: > > > On Fri, 8 Jun 2018 10:21:05 -0300 >

Re: [libvirt] [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

On Fri, Jun 15, 2018 at 10:03:14AM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 14, 2018 at 11:50:56PM -0300, Eduardo Habkost wrote: > > On Thu, Jun 14, 2018 at 09:09:48AM +0100, Daniel P. Berrangé wrote: > > > On Wed, Jun 13, 2018 at 03:05:08PM -0300, Eduardo Habkost wrote: &g

Re: [libvirt] [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

On Tue, Jun 12, 2018 at 01:50:33PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote: > > We can keep daemonizing flow in QEMU as it's now. > > But Eduardo's idea about libvirt created socked + letting QEMU connect to it > > has a merit. It should fix

Re: [libvirt] [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

On Wed, Jun 13, 2018 at 03:23:09PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 11:17:30AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 12, 2018 at 01:50:33PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote: &

Re: [libvirt] [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

Getting back to this discussion: On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > Add to that shortcuts like -cdrom > > > > stop working, > > > > > > Maybe is fixable. > > > > Already

Re: [libvirt] [PATCH] docs: formatdomain: Note the caveats for CPU policy option "force"

On Tue, Jun 12, 2018 at 10:58:46AM +0200, Kashyap Chamarthy wrote: > Eduardo Habkost has pointed out that the current documentation of > libvirt's CPU feature policy "require" vs. "force" does not match > QEMU's behaviour. > > Update the documentation by spell

Re: [libvirt] [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

On Thu, Jun 14, 2018 at 09:09:48AM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 03:05:08PM -0300, Eduardo Habkost wrote: > > Getting back to this discussion: > > > > On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Ju

Re: [libvirt] What is the strategy to update the CPU Models in src/cpu/cpu_map.xml based on?

CCing Jiri Denemark, who maintains the CPU code in libvirt. On Wed, May 30, 2018 at 06:00:56PM +0800, Dou Liyang wrote: > Hi All, > > I am not sure about the update strategy of CPU models in libvirt. > > IMO, It's depend on the CPU model in qemu-kvm, if some CPU models > were updated in

[libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

(CCing libvir-list) On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > Add to that shortcuts like -cdrom > > > > stop working, > > > > > > Maybe is fixable. > > > > Already fixed for ages.

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 10:06:46AM -0300, Eduardo Habkost wrote: > > (CCing libvir-list) > > > > On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 05, 2018 at 0

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

On Tue, Jun 05, 2018 at 03:44:39PM +0200, Pavel Hrdina wrote: > On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 05, 2018 at 10:06:46AM -0300, Eduardo Habkost wrote: > >

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

On Mon, May 28, 2018 at 09:23:54AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: [...] > > [1] Doing a: > > $ git grep 'STR.*machine, "' > > on libvirt source is enough to find some code demonstrating where > > query-machines is already lacking to

Re: [libvirt] [Qemu-devel] CPU model versioning separate from machine type versioning ?

On Fri, Jun 29, 2018 at 11:19:17AM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 29, 2018 at 09:53:53AM +0100, Dr. David Alan Gilbert wrote: [...] > > We're going to have to say something like: > > 'For the new XYZ vulnerability make sure you're using > > Haswell-3.2 or later, SkyLake-2.6 or

Re: [libvirt] [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

On Mon, Jun 18, 2018 at 08:18:16PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 18, 2018 at 02:14:31PM -0300, Eduardo Habkost wrote: > > > Sure if someone does that, we'll have no choice, but as long as 'pc' is > > > shipped we shouldn't gratuitously break apps by

Re: [libvirt] [Qemu-devel] [PATCH] hw/i386: Deprecate the machine types pc-0.10 and pc-0.11

(CCing Markus and libvir-list) On Wed, Jun 20, 2018 at 08:40:38PM +0200, Thomas Huth wrote: > On 12.06.2018 00:18, Eduardo Habkost wrote: > > On Mon, Jun 11, 2018 at 05:41:04AM +0200, Thomas Huth wrote: > >> The oldest machine type which is still used in a maintained distrib

Re: [libvirt] CPU model versioning separate from machine type versioning ?

On Fri, Jun 29, 2018 at 11:14:17AM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 28, 2018 at 04:52:27PM -0300, Eduardo Habkost wrote: [...] > > I'm not sure what would be the best way to encode two types of > > information, though: > > > > * Fallback/alternatives

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

On Mon, Jan 15, 2018 at 03:25:18PM +0100, Jiri Denemark wrote: > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > CCing libvirt developers. > ... > > This case is slightly more problematic, however: the new feature > > is actually migratable (under very

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

On Thu, Jan 18, 2018 at 05:33:53AM +, Kang, Luwei wrote: > > > > > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > > > > > CCing libvirt developers. > > > > > > > ... > > > > > >

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

On Thu, Jan 18, 2018 at 02:39:57PM +0100, Paolo Bonzini wrote: > On 18/01/2018 14:24, Eduardo Habkost wrote: > > However, if there's a simple way to make it possible to migrate > > between hosts with different CPUID[14h] data, it would be even > > better. With the

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

On Thu, Jan 18, 2018 at 03:44:49PM +0100, Paolo Bonzini wrote: > On 18/01/2018 15:37, Eduardo Habkost wrote: > > On Thu, Jan 18, 2018 at 02:39:57PM +0100, Paolo Bonzini wrote: > >> On 18/01/2018 14:24, Eduardo Habkost wrote: > >>> However, if there's a simple way

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

On Tue, Jan 16, 2018 at 06:10:17AM +, Kang, Luwei wrote: > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > CCing libvirt developers. > > > ... > > > > This case is slightly more problematic, however: the new feature

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

CCing libvirt developers. On Mon, Jan 15, 2018 at 10:33:35AM +0100, Paolo Bonzini wrote: > On 15/01/2018 08:19, Kang, Luwei wrote: > >> If you are forwarding host info directly to the guest, the feature > >> is not migration-safe. The new feature needs to be added to > >>

Re: [libvirt] [PATCH] docs: formatdomain: Document the CPU feature 'name' attribute

On Fri, Jan 12, 2018 at 08:31:16PM +0100, Kashyap Chamarthy wrote: > Currently, the CPU feature 'name' XML attribute, as in: > > [...] > > IvyBridge > Intel > > > [...] > > isn't explicitly documented in formatdomain.html. > > Document it now. > >

Re: [libvirt] [PATCH] docs: formatdomain: Document the CPU feature 'name' attribute

On Wed, Jan 17, 2018 at 09:04:26AM +0100, Kashyap Chamarthy wrote: > On Tue, Jan 16, 2018 at 03:35:20PM -0200, Eduardo Habkost wrote: > > On Fri, Jan 12, 2018 at 08:31:16PM +0100, Kashyap Chamarthy wrote: > > > Currently, the CPU feature 'n

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

On Wed, Jan 17, 2018 at 10:32:56AM +, Kang, Luwei wrote: > > > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > > > CCing libvirt developers. > > > > > ... > > > > > > This case is slightly more proble

Re: [libvirt] [PATCH v2] docs: formatdomain: Document the CPU feature 'name' attribute

On Thu, Jan 25, 2018 at 09:17:22AM -0500, John Ferlan wrote: > [...] > >> > >>> +name attribute. For example, to explicitly specify > >> > >> s/specify/require > > > > I used the verb 'specify' to indicate that there is an _action_ to be > > taken. To my non-native ears: "to explicitly

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

On Fri, Feb 02, 2018 at 03:07:18PM +, Daniel P. Berrangé wrote: > On Fri, Feb 02, 2018 at 12:50:14PM -0200, Eduardo Habkost wrote: > > (CCing qemu-devel) > > > > On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: > > > On Fri, 2 Feb 2018 14:19:38

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

On Fri, Feb 02, 2018 at 02:53:50PM +0100, Viktor Mihajlovski wrote: > On 01.02.2018 21:26, Eduardo Habkost wrote: > > On Thu, Feb 01, 2018 at 09:15:15PM +0100, Radim Krčmář wrote: > >> 2018-02-01 12:54-0500, Luiz Capitulino: > >>> > >>> Libvirt n

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

(CCing qemu-devel) On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: > On Fri, 2 Feb 2018 14:19:38 + > Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Fri, Feb 02, 2018 at 12:15:54PM -0200, Eduardo Habkost wrote: [...] > > > It would be also

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

On Fri, Feb 02, 2018 at 05:19:34PM +0100, Viktor Mihajlovski wrote: > On 02.02.2018 17:01, Luiz Capitulino wrote: [...] > > o Make qemuDomainRefreshVcpuHalted() s390-only in libvirt. This by > >itself fixes the original performance issue > We are normally trying to avoid architecture-specific

Re: [libvirt] [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

On Fri, Feb 02, 2018 at 05:23:59PM +, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > (CCing qemu-devel) > > > > On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: > > > On Fri, 2 Feb 2018 14:19:38 + &

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

On Fri, Feb 02, 2018 at 03:19:45PM -0500, Luiz Capitulino wrote: > On Fri, 2 Feb 2018 18:09:12 -0200 > Eduardo Habkost <ehabk...@redhat.com> wrote: [...] > > Your plan above covers what will happen when using newer QEMU > > versions, but libvirt still needs to work sanely

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

On Fri, Feb 02, 2018 at 01:50:33PM -0500, Luiz Capitulino wrote: > On Fri, 2 Feb 2018 15:42:49 -0200 > Eduardo Habkost <ehabk...@redhat.com> wrote: > > > On Fri, Feb 02, 2018 at 05:19:34PM +0100, Viktor Mihajlovski wrote: > > > On 02.02.2018 17:01, Luiz Capitulino

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

On Thu, Feb 01, 2018 at 09:15:15PM +0100, Radim Krčmář wrote: > 2018-02-01 12:54-0500, Luiz Capitulino: > > > > Libvirt needs to know when a vCPU is halted. To get this information, > > I don't see why upper level management should care about that, a single > bit about halted state that can be

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

On Mon, Feb 05, 2018 at 10:37:01AM -0500, Luiz Capitulino wrote: [...] > However, IMHO, what we really want is to add an API to the guest agent > to export the CPU online bit from the guest userspace sysfs. This will > give the ultimate semantics and move us away from this halted mess. Can't this

[libvirt] [PATCH] qemu_cgroup: Fix 'rc' argument on virDomainAuditCgroupPath() calls

regular files as disk image. Fix all calls to use the return value of virCgroup{Allow,Deny}Device*() directly as the 'rc' argument. Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- src/qemu/qemu_cgroup.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-)

Re: [libvirt] [PATCH] qemu: ensure "pc" machine is always used as default if available

On Fri, Aug 03, 2018 at 01:59:47PM +0100, Daniel P. Berrangé wrote: > It is increasingly likely that some distro is going to change the > default "x86" machine type in QEMU from "pc" to "q35". This will > certainly break existing applications which write their XML on the > assumption that its

Re: [libvirt] [PATCH] qemu: ensure "pc" machine is always used as default if available

On Tue, Aug 07, 2018 at 12:17:33PM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 03, 2018 at 01:05:49PM -0300, Eduardo Habkost wrote: > > On Fri, Aug 03, 2018 at 01:59:47PM +0100, Daniel P. Berrangé wrote: > > > It is increasingly likely that some distro is going to change the

Re: [libvirt] X86CPU "feature-words" property on QEMU (was Re: [PATCH v3 1/3] x86: Data structure changes to support MSR based) features

On Fri, Aug 17, 2018 at 07:59:40PM +0200, Paolo Bonzini wrote: > On 17/08/2018 19:48, Eduardo Habkost wrote: > > So let's do what's necessary to remove it. But I don't think the > > removal of "feature-words" should block the inclusion of this > > series. >

[libvirt] X86CPU "feature-words" property on QEMU (was Re: [PATCH v3 1/3] x86: Data structure changes to support MSR based) features

On Fri, Aug 17, 2018 at 07:34:13PM +0200, Paolo Bonzini wrote: > On 17/08/2018 17:55, Eduardo Habkost wrote: > >> The names will be X86_CPU_FEATURE_WORD_TYPE_CPUID and > >> X86_CPU_FEATURE_WORD_TYPE_MSR. > > I wouldn't like to make this an external API unless really >

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

On Thu, Aug 23, 2018 at 05:26:47PM +0100, Daniel P. Berrangé wrote: [...] > There are countless mistakes in both QEMU & libvirt, but only some of > them are worth the cost of changing. I'm not seeing a compelling reason > why this change is worthwhile. The impact of the design mistake is narrow >

Re: [libvirt] [PATCH] vl.c: make sure maxcpus matches topology to prevent migration failure

On Fri, Aug 24, 2018 at 01:26:54PM +0200, Igor Mammedov wrote: > On Fri, 24 Aug 2018 08:11:48 -0300 > Eduardo Habkost wrote: > > > On Fri, Aug 24, 2018 at 11:13:50AM +0200, Igor Mammedov wrote: > > > On Thu, 23 Aug 2018 18:32:41 +0200 > > > Paolo Bonzini wrote:

Re: [libvirt] [PATCH v2] vl.c deprecate incorrect CPUs topology

On Mon, Aug 27, 2018 at 03:53:26PM +0200, Igor Mammedov wrote: > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > so that total number of logical CPUs [sockets * cores * threads] > would be equal to [maxcpus], however historically we didn't have > such check in QEMU and it is

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

On Wed, Aug 22, 2018 at 02:44:40PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 09:54:55AM -0300, Eduardo Habkost wrote: > > On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote: &

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote: > > On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea Bolognani wrote: > > > On Tue, 2018-08-21 at 14:21 -0400, Laine Stump wrote: > > &g

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea Bolognani wrote: > On Tue, 2018-08-21 at 14:21 -0400, Laine Stump wrote: > > On 08/17/2018 06:35 AM, Andrea Bolognani wrote: > > > If we decide we want to explicitly spell out the options instead > > > of relying on QEMU changing behavior based on

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

On Wed, Aug 22, 2018 at 03:57:20PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 11:18:28AM -0300, Eduardo Habkost wrote: > > On Wed, Aug 22, 2018 at 02:44:40PM +0100, Daniel P. Berrangé wrote: [...] > > > An explicit virtio-transitional device is still two sepa

Re: [libvirt] CPU Support

CCing the AMD people who worked on this. On Wed, Jul 18, 2018 at 12:18:45PM +0200, Pavel Hrdina wrote: > On Wed, Jul 18, 2018 at 10:50:34AM +0100, Daniel P. Berrangé wrote: > > On Wed, Jul 18, 2018 at 12:41:48PM +0300, Hetz Ben Hamo wrote: > > > Hi, > > > > > > I've been looking at the CPU list

Re: [libvirt] [PATCH v5 1/2] vl.c deprecate incorrect CPUs topology

On Wed, Sep 05, 2018 at 11:25:11AM +0200, Igor Mammedov wrote: > On Tue, 4 Sep 2018 23:12:55 -0300 > Eduardo Habkost wrote: > > > On Tue, Sep 04, 2018 at 03:22:35PM +0200, Igor Mammedov wrote: > > > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology &g

Re: [libvirt] [Qemu-devel] [PATCH v5 2/2] vl:c: make sure that sockets are calculated correctly in '-smp X' case

On Tue, Sep 04, 2018 at 05:18:48PM +0200, Andrew Jones wrote: > On Tue, Sep 04, 2018 at 03:22:36PM +0200, Igor Mammedov wrote: > > commit > > (5cdc9b76e3 vl.c: Remove dead assignment) > > removed sockets calculation when 'sockets' weren't provided on CLI > > since there wasn't any users for it

Re: [libvirt] [PATCH v5 1/2] vl.c deprecate incorrect CPUs topology

ake sure that >[sockets * cores * threads] == [maxcpus] > > Signed-off-by: Igor Mammedov > --- > v5: > - extend deprecation doc, adding that maxcpus should be multiple of > present on CLI [sockets/cores/threads] options > (Eduardo Habkost ) > v4: > - mi

Re: [libvirt] [PATCH v5 1/2] vl.c deprecate incorrect CPUs topology

On Thu, Sep 06, 2018 at 10:02:13AM +0200, Igor Mammedov wrote: > On Wed, 5 Sep 2018 10:45:12 -0300 > Eduardo Habkost wrote: > > > On Wed, Sep 05, 2018 at 11:25:11AM +0200, Igor Mammedov wrote: > > > On Tue, 4 Sep 2018 23:12:55 -0300 > > > Eduardo Habkost wrote

Re: [libvirt] [PATCH v2 5/5] qemu: Enable memory-backend-file.discard-data whenever possible

On Tue, Apr 17, 2018 at 01:16:42PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1480668 > > The cases when we cannot enable this optimization are: > 1) nvdimms > 2) if memAccess='shared' The specific use case for discard-data=on uses share=on, see:

Re: [libvirt] [kubevirt-dev] Re: [virt-tools-list] Project for profiles and defaults for libvirt domains

On Thu, Mar 22, 2018 at 09:56:12AM +, Daniel P. Berrangé wrote: > On Wed, Mar 21, 2018 at 04:34:23PM -0300, Eduardo Habkost wrote: > > On Wed, Mar 21, 2018 at 06:39:52PM +, Daniel P. Berrangé wrote: > > > On Wed, Mar 21, 2018 at 03:00:41PM -0300, Eduardo Habkost wrote: &

Re: [libvirt] [virt-tools-list] Project for profiles and defaults for libvirt domains

On Tue, Mar 20, 2018 at 03:10:12PM +, Daniel P. Berrangé wrote: > On Tue, Mar 20, 2018 at 03:20:31PM +0100, Martin Kletzander wrote: > > 1) Default devices/values > > > > Libvirt itself must default to whatever values there were before any > > particular element was introduced due to the fact

Re: [libvirt] [virt-tools-list] Project for profiles and defaults for libvirt domains

On Wed, Mar 21, 2018 at 06:39:52PM +, Daniel P. Berrangé wrote: > On Wed, Mar 21, 2018 at 03:00:41PM -0300, Eduardo Habkost wrote: > > On Tue, Mar 20, 2018 at 03:10:12PM +, Daniel P. Berrangé wrote: > > > On Tue, Mar 20, 2018 at 03:20:31PM +0100, Martin Kletzander wrote:

Re: [libvirt] [Qemu-devel] CPU model versioning separate from machine type versioning ?

On Thu, Jun 28, 2018 at 07:59:38PM +0100, Dr. David Alan Gilbert wrote: [...] > > An application like virt-manager which wants a simple UI can forever be > > happy simply giving users a list of bare CPU model names, and allowing > > libvirt / QEMU to automatically expand to the best versioned

Re: [libvirt] CPU model versioning separate from machine type versioning ?

On Thu, Jun 28, 2018 at 04:45:02PM +0100, Daniel P. Berrangé wrote: [...] > What if we can borrow the concept of versioning from machine types and apply > it to CPU models directly. For example, considering the history of "Haswell" > in QEMU, if we had versioned things, we would by now have: > >

Re: [libvirt] [Qemu-devel] CPU model versioning separate from machine type versioning ?

On Fri, Jun 29, 2018 at 08:06:04AM +0200, Jiri Denemark wrote: > On Thu, Jun 28, 2018 at 16:23:53 -0300, Eduardo Habkost wrote: > > On Thu, Jun 28, 2018 at 07:59:38PM +0100, Dr. David Alan Gilbert wrote: [...] > > > Would you restrict the combinations to cut down the

Re: [libvirt] [Qemu-devel] CPU model versioning separate from machine type versioning ?

On Fri, Jun 29, 2018 at 02:12:51PM +0200, Jiri Denemark wrote: > On Fri, Jun 29, 2018 at 11:14:17 +0100, Daniel P. Berrangé wrote: > > On Thu, Jun 28, 2018 at 04:52:27PM -0300, Eduardo Habkost wrote: > > > On Thu, Jun 28, 2018 at 04:45:02PM +0100, Daniel P. Berrangé wrote: > &

[libvirt] [PULL 44/45] net: xgmac: convert SysBus init method to a realize method

From: Cédric Le Goater Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: Rob Herring Signed-off-by: Cédric Le Goater Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181001063803.22330-12-...@kaod.org> Signed-off-by: Eduardo Habkost --- hw/net/xgmac

[libvirt] [PULL 10/45] hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init

From: Philippe Mathieu-Daudé Move from the legacy SysBusDevice::init method to using DeviceState::realize. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20181002212522.23303-7-f4...@amsat.org> Reviewed-by: Peter Maydell Signed-off-by: Eduardo Habkost --- hw/pci-host/bonito

[libvirt] [PULL 36/45] net: lan9118: convert SysBus init method to a realize method

From: Cédric Le Goater Signed-off-by: Cédric Le Goater Message-Id: <20181001063803.22330-4-...@kaod.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Eduardo Habkost --- hw/net/lan9118.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/lan9118.

[libvirt] [PULL 27/45] memory-device: factor out get_memory_region() from pc-dimm

: <20181005092024.14344-11-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/mem/memory-device.h | 15 +++ include/hw/mem/pc-dimm.h | 4 hw/mem/nvdimm.c| 9 ++--- hw/mem/pc-dimm.c | 27 ++- 4 files chang

[libvirt] [PULL 04/45] numa: Fix QMP command set-numa-node error handling

rror instead. Fixes: f3be67812c226162f86ce92634bd913714445420 Cc: Igor Mammedov Signed-off-by: Markus Armbruster Message-Id: <20181008173125.19678-15-arm...@redhat.com> Reviewed-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- numa.c | 13 + 1 file cha

[libvirt] [PULL 06/45] hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko Reviewed-by: Cédric Le Goater Message-Id: <20181002212522.23303-3-f4...@amsat.org> Signed-off-by: Eduardo Habkost --- hw/timer/sun4v-rtc.c | 13 +++-- hw/timer/trace-events | 4 +

[libvirt] [PULL 40/45] net: opencores_eth: convert SysBus init method to a realize method

From: Cédric Le Goater Cc: Max Filippov Signed-off-by: Cédric Le Goater Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181001063803.22330-8-...@kaod.org> Acked-by: Max Filippov Signed-off-by: Eduardo Habkost --- hw/net/opencores_eth.c | 8 +++-

[libvirt] [PULL 38/45] net: milkymist_minimac2: convert SysBus init method to a realize method

From: Cédric Le Goater Cc: Michael Walle Signed-off-by: Cédric Le Goater Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181001063803.22330-6-...@kaod.org> Acked-by: Michael Walle Signed-off-by: Eduardo Habkost --- hw/net/milkymist-minimac2.c | 9 +++---

[libvirt] [PULL 35/45] net: etraxfs_eth: add a reset method

From: Cédric Le Goater Cc: Edgar E. Iglesias Signed-off-by: Cédric Le Goater Message-Id: <20181001063803.22330-3-...@kaod.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Eduardo Habkost --- hw/net/etraxfs_eth.c | 31 +-- 1 file changed, 25 inse

[libvirt] [PULL 03/45] vl:c: make sure that sockets are calculated correctly in '-smp X' case

hat.com> Signed-off-by: Eduardo Habkost --- vl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 027d04c7ca..2324321d91 100644 --- a/vl.c +++ b/vl.c @@ -1199,11 +1199,14 @@ static void smp_parse(QemuOpts *opts) /* compute missing values, pre

[libvirt] [PULL 07/45] hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init

From: Philippe Mathieu-Daudé Move from the legacy SysBusDevice::init method to using DeviceState::realize. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Cédric Le Goater Message-Id: <20181002212522.23303-4-f4...@amsat.org> Signed-off-by: Eduardo Habkost -

[libvirt] [PULL 42/45] net: stellaris_enet: convert SysBus init method to a realize method

From: Cédric Le Goater Cc: Peter Maydell Cc: qemu-...@nongnu.org Signed-off-by: Cédric Le Goater Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181001063803.22330-10-...@kaod.org> Signed-off-by: Eduardo Habkost --- hw/net/stellaris_enet.c | 8 +++-

[libvirt] [PULL 13/45] hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device'

Tarasenko Message-Id: <20181002212522.23303-10-f4...@amsat.org> Signed-off-by: Eduardo Habkost --- default-configs/sparc64-softmmu.mak | 1 - hw/sparc64/niagara.c| 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/default-configs/sparc64-softmmu.mak b/d

[libvirt] [PULL 45/45] numa: Clean up error reporting in parse_numa()

() internal linkage. Cc: Eduardo Habkost Signed-off-by: Markus Armbruster Message-Id: <20181008173125.19678-26-arm...@redhat.com> Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- include/sysemu/numa.h | 1 - numa.c| 8 +++- 2 files changed, 3 insertions

[libvirt] [PULL 18/45] memory-device: fix alignment error message

From: David Hildenbrand We're missing "x" after the leading 0. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-2-da...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/mem/memory-device.c | 2 +- 1

[libvirt] [PULL 11/45] hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method

From: Philippe Mathieu-Daudé Convert the gt64120_reset() function into a proper Device reset method. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Cédric Le Goater Message-Id: <20181002212522.23303-8-f4...@amsat.org> Signed-off-by: Eduardo Habkost -

[libvirt] [PULL 17/45] machine: fix a typo

From: Li Qiang Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang Message-Id: <20181010161025.34796-1-liq...@163.com> Reviewed-by: Stefano Garzarella Signed-off-by: Eduardo Habkost --- hw/core/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/machi

[libvirt] [PULL 08/45] hw/ssi/xilinx_spi: Use DeviceState::realize rather than SysBusDevice::init

From: Philippe Mathieu-Daudé Move from the legacy SysBusDevice::init method to using DeviceState::realize. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Cédric Le Goater Message-Id: <20181002212522.23303-5-f4...@amsat.org> Signed-off-by: Eduardo Habkost -

[libvirt] [PULL 41/45] net: smc91c111: convert SysBus init method to a realize method

From: Cédric Le Goater Signed-off-by: Cédric Le Goater Message-Id: <20181001063803.22330-9-...@kaod.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Eduardo Habkost --- hw/net/smc91c111.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/net/smc91c1

[libvirt] [PULL 25/45] memory-device: document MemoryDeviceClass

-by: Igor Mammedov Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-9-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/mem/memory-device.h | 36 ++ 1 file changed, 36 insertions(+) diff --git a/include/hw/mem/memory-device.h b/i

[libvirt] [PULL 39/45] net: mipsnet: convert SysBus init method to a realize method

From: Cédric Le Goater Cc: Aleksandar Markovic Signed-off-by: Cédric Le Goater Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181001063803.22330-7-...@kaod.org> Signed-off-by: Eduardo Habkost --- hw/net/mipsnet.c | 9 +++-- 1 file changed, 3 inse

[libvirt] [PULL 30/45] memory-device: complete factoring out pre_plug handling

separately in a follow-up patch. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-14-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/mem/memory-device.h | 5 ++--- hw/mem/memory-device.c

[libvirt] [PULL 28/45] memory-device: drop get_region_size()

() in pc-dimm code to implement get_plugged_size()" Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-12-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/mem/memory-device.h | 1 - hw/mem/memo

[libvirt] [PULL 22/45] memory-device: use memory device terminology in error messages

From: David Hildenbrand While we rephrased most error messages, we missed these. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov Reviewed-by: David Gibson Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-6-da...@redhat.com> Signed-off-by: Eduardo H

[libvirt] [PULL 23/45] memory-device: introduce separate config option

. Reviewed-by: Igor Mammedov Reviewed-by: David Gibson Acked-by: David Gibson Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-7-da...@redhat.com> Signed-off-by: Eduardo Habkost --- default-configs/i386-softmmu.mak | 3 ++- default-configs/ppc64-softmmu.mak | 3 ++- qapi/mis

[libvirt] [PULL 21/45] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug

: <20181005092024.14344-5-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/mem/pc-dimm.h | 6 +++--- hw/i386/pc.c | 6 +++--- hw/mem/pc-dimm.c | 24 +++- hw/ppc/spapr.c | 8 4 files changed, 21 insertions(+), 23 deletions(-) diff

[libvirt] [PULL 29/45] memory-device: add device class function set_addr()

ic Auger Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-13-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/mem/memory-device.h | 8 hw/mem/pc-dimm.c | 7 +++ 2 files changed, 15 insertions(+) diff --git a/include/hw/mem/memory-devic

[libvirt] [PULL 24/45] memory-device: forward errors in get_region_size()/get_plugged_size()

a leftover error check (suggested by Igor). Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Reviewed-by: Eric Auger Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-8-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/mem/memory-device.h | 4 ++--

[libvirt] [PULL 14/45] hw/alpha/typhoon: Remove unuseful code

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20181002212522.23303-11-f4...@amsat.org> Signed-off-by: Eduardo Habkost --- hw/alpha/typhoon.c | 13 - 1 file changed, 13 deletions(-) diff --git a/hw/alpha/typhoon.

[libvirt] [PULL 19/45] memory-device: fix error message when hinted address is too small

d) -> "can't add memory ... beyond..." Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov Reviewed-by: David Gibson Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-3-da...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/mem/memory-dev

[libvirt] [PULL 01/45] hostmem-file: fixed the memory leak while get pmem path.

com> Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- backends/hostmem-file.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c index e64074954f..639c8d4307 100644 --- a/backends/hostmem-file.c +++ b/ba

<    1   2   3   4   5   6   7   8   >