ent as shown by virsh
dumpxml before you try to start the domain as well as the QEMU command
line libvirt used to start the domain (in
/var/log/libvirt/qemu/$VM.log).
> I believe I traced the error back to this commit:
>
> commit 201bd5db639c063862b0c1b1abfab9a9a7c92591
> Author: Jiri De
Signed-off-by: Jiri Denemark
---
src/cpu_map/x86_features.xml| 6 ++
tests/cputestdata/x86_64-cpuid-Cooperlake-enabled.xml | 2 +-
tests/cputestdata/x86_64-cpuid-Cooperlake-json.xml | 1 +
.../cputestdata/x86_64-cpuid-EPYC-7601-32-Core
Signed-off-by: Jiri Denemark
---
src/cpu_map/x86_features.xml | 32 +++
.../x86_64-cpuid-A10-5800K-disabled.xml | 1 +
.../x86_64-cpuid-A10-5800K-enabled.xml| 1 +
.../x86_64-cpuid-A10-5800K-guest.xml | 10 ++
.../x86_64-cpuid-A10
The CPUID data in *-{disabled,enabled}.xml convert feature names from
the corresponding *.json file into raw CPUID and MSR data and thus some
of them may need to be updated when new features are added into the CPU
map.
Signed-off-by: Jiri Denemark
---
src/cpu_map/x86_features.xml
Signed-off-by: Jiri Denemark
---
src/cpu_map/x86_features.xml | 12
.../x86_64-cpuid-Ice-Lake-Server-disabled.xml| 2 +-
.../x86_64-cpuid-Ice-Lake-Server-guest.xml | 1 +
.../x86_64-cpuid-Ice-Lake-Server-host.xml| 1
The features were added to QEMU long ago.
Jiri Denemark (4):
cpu_map: Request test files update when adding x86 features
cpu_map: Add missing x86 features in 0x7 CPUID leaf
cpu_map: Add missing x86 features in 0x8008 CPUID leaf
cpu_map: Add missing AMD SVM features
src/cpu_map
to be locked into RAM
> +with memory page sharing disabled.
> +This is achieved by using the `memory backing config
> `_:
> +
> +::
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +Device configuration
> +
> +
> +Libvirt adds a few devices by default to maintain historical QEMU
> configuration
> +behaviour. It is unlikely these devices are required by real time guests, so
> it
> +is wise to disable them. Remove all USB controllers that may exist in the XML
> +config and replace them with:
> +
> +::
> +
> +
> +
> +Similarly the memory balloon config should be changed to
> +
> +::
> +
> +
> +
> +If the guest had a graphical console at installation time this can also be
> +disabled, with remote access being over SSH, with a minimal serial console
> +for emergencies.
With the above minor issues addressed:
Reviewed-by: Jiri Denemark
--
> src/util/virutil.h | 2 --
> 7 files changed, 31 insertions(+), 36 deletions(-)
Reviewed-by: Jiri Denemark
Signed-off-by: Jiri Denemark
---
.../cputune-cpuset-big-id.x86_64-latest.args | 39 +
.../cputune-cpuset-big-id.xml | 33 ++
tests/qemuxml2argvtest.c | 1 +
.../cputune-cpuset-big-id.x86_64-latest.xml | 43
Domains are now allowed to be pinned to host CPUs with IDs up to 16383.
The new limit is as arbitrary as the old one. It's just bigger.
Signed-off-by: Jiri Denemark
---
src/conf/domain_conf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.h b/src/conf
The tests in patch 2/2 would fail without the first patch.
Jiri Denemark (2):
conf: Increase cpuset length limit for CPU pinning
qemuxml2*test: Add cases for CPU pinning to large host CPU IDs
src/conf/domain_conf.h| 2 +-
.../cputune-cpuset-big-id.x86_64-latest.args
The same functionality can be achieved using migrate-set-parameters QMP
command with xbzrle-cache-size parameter.
https://bugzilla.redhat.com/show_bug.cgi?id=1845012
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_driver.c | 26 +-
src/qemu
These parameters were originally set via dedicated commands which are
now deprecated. We want to use migrate-set-parameters instead if
possible.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 8
src/qemu/qemu_capabilities.h
The same functionality can be achieved using migrate-set-parameters QMP
command with max-bandwidth parameter.
https://bugzilla.redhat.com/show_bug.cgi?id=1829545
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_driver.c | 18 ++---
src/qemu/qemu_migration.c | 53
The same functionality can be achieved using query-migrate-parameters
QMP command and checking the xbzrle-cache-size parameter.
https://bugzilla.redhat.com/show_bug.cgi?id=1829544
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_driver.c | 21 +
tests
Jiri Denemark (5):
qemu: Probe for a few params supported by migrate-set-parameters
qemu: Avoid deprecated migrate_set_speed QMP command
qemu: Avoid deprecated migrate_set_downtime QMP command
qemu: Avoid deprecated query-migrate-cache-size QMP command
qemu: Avoid deprecated migrate-set
The same functionality can be achieved using migrate-set-parameters QMP
command with downtime-limit parameter.
https://bugzilla.redhat.com/show_bug.cgi?id=1829543
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_driver.c | 27 +++
tests/qemumonitorjsontest.c | 2
On Tue, Jun 09, 2020 at 12:35:02 +0200, Michal Privoznik wrote:
> On 6/5/20 8:31 PM, Jiri Denemark wrote:
> >
> > Jiri Denemark (9):
> >conf: Use g_auto* in virCPUDefParseXML
> >qemu: Probe for .migratable property of a CPU
> >qemu: Probe for migr
Signed-off-by: Jiri Denemark
---
docs/formatdomaincaps.html.in | 13 +++--
docs/schemas/domaincaps.rng| 3 +++
src/conf/domain_capabilities.c | 13 -
src/conf/domain_capabilities.h | 1 +
4 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/docs
migratable=on. Let's record the default in domain XML.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domain.c | 14 --
.../migration-in-params-in.xml | 2 +-
.../migration-out-params-in.xml| 2 +-
.../qemuxml2xmlo
Jiri Denemark (9):
conf: Use g_auto* in virCPUDefParseXML
qemu: Probe for .migratable property of a CPU
qemu: Probe for migrtability support in CPU expansion
qemu: Avoid probing unsupported migratable CPU expansion
conf: Introduce migratable attribute for the element
conf: Advertise
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 3 +++
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 1 +
.../caps_2.10.0.s390x.replies | 22 -
.../caps_2.11.0.s390x.replies | 22 -
.../caps_2.12.0.s390x.replies | 22 -
.../caps_2.8.0
The attribute is only allowed for host-passthrough CPUs and it can be
used to request only migratable or all supported features to be enabled
in the virtual CPU.
Signed-off-by: Jiri Denemark
---
docs/formatdomain.html.in | 14 --
docs/schemas/domaincommon.rng | 5 +
src
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 11 ++-
tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml| 6 +-
tests/domaincapsdata/qemu_1.5.3.x86_64.xml| 6 +-
tests/domaincapsdata/qemu_1.6.0-q35.x86_64.xml| 6 +-
tests
Signed-off-by: Jiri Denemark
---
src/conf/cpu_conf.c | 130 +---
1 file changed, 50 insertions(+), 80 deletions(-)
diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 1d02e23175..25648a946c 100644
--- a/src/conf/cpu_conf.c
+++ b/src/conf
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_command.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 419eca5675..d9e99d9d1a 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -6254,6 +6254,21
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 12 +++-
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 +
tests
Signed-off-by: Jiri Denemark
---
I will push this as a build breaker once
https://gitlab.com/jirkade/libvirt/pipelines/149651008 pipeline
succeeds.
src/cpu_map/Makefile.inc.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am
index
All other cpuArchDrivers implements update() and changes guest mode
> to VIR_CPU_MODE_CUSTOM, meaning that PSeries is currently the only
> exception to this logic. Let's make it official.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1660711
>
> Suggested-by: Jiri Denemark
> Signed-o
All other cpuArchDrivers implements update() and changes guest mode
> to VIR_CPU_MODE_CUSTOM, meaning that PSeries is currently the only
> exception to this logic. Let's make it official.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1660711
>
> CC: Jiri Denemark
> Signed-off-by: Dan
> 1 file changed, 17 insertions(+), 33 deletions(-)
Reviewed-by: Jiri Denemark
I pushed patches 1-4.
On Fri, May 22, 2020 at 16:56:18 -0300, Daniel Henrique Barboza wrote:
> Use automatic cleanup of variables.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
> src/cpu/cpu_s390.c | 18 +++---
> 1 file changed, 7 insertions(+), 11 deletions(-)
Reviewed-by: Jiri Denemark
On Fri, May 22, 2020 at 16:56:17 -0300, Daniel Henrique Barboza wrote:
> Use automatic cleanup of variables.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
> src/cpu/cpu_arm.c | 14 +-
> 1 file changed, 5 insertions(+), 9 deletions(-)
Reviewed-by: Jiri Denemark
On Fri, May 22, 2020 at 16:56:16 -0300, Daniel Henrique Barboza wrote:
> Use automatic cleanup of variables.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
> src/conf/cpu_conf.c | 22 +++---
> 1 file changed, 7 insertions(+), 15 deletions(-)
Reviewed-by: Jiri Denemark
Jiri Denemark (3):
cputest: Add data for Cooperlake CPU
cpu_map: Add pschange-mc-no bit in IA32_ARCH_CAPABILITIES MSR
cpu_map: Add Cooperlake x86 CPU model
src/cpu_map/index.xml |1 +
src/cpu_map/x86_Cooperlake.xml| 90 +
src/cpu_map
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
.../x86_64-cpuid-Cooperlake-disabled.xml |7 +
.../x86_64-cpuid-Cooperlake-enabled.xml | 11 +
.../x86_64-cpuid-Cooperlake-guest.xml | 40 +
.../x86_64-cpuid-Cooperlake-host.xml
Signed-off-by: Jiri Denemark
---
src/cpu_map/x86_features.xml | 3 +++
tests/cputestdata/x86_64-cpuid-Cooperlake-guest.xml| 1 +
tests/cputestdata/x86_64-cpuid-Cooperlake-host.xml | 1 +
tests/cputestdata/x86_64-cpuid-Cooperlake-json.xml
The stepping range (10-11) is likely incomplete. QEMU uses 10 and the
CPUID data for Cooperlake show 11. We will update the range if needed
once more details about he CPU are available.
Signed-off-by: Jiri Denemark
---
src/cpu_map/index.xml | 1 +
src/cpu_map
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
src/util/virhostcpu.c | 21 ++-
.../linux-s390x-with-frequency.signature | 1 +
2 files changed, 21 insertions(+), 1 deletion(-)
create mode 100644 tests/virhostcpudata/linux-s390x
=1778819
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 24
src/qemu/qemu_capspriv.h | 1 +
tests/qemucapsprobe.c| 2 +-
3 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
Signed-off-by: Jiri Denemark
---
src/util/virhostcpu.c | 58 ---
.../linux-ppc64-deconf-cpus.signature | 1 +
.../linux-ppc64-subcores1.signature | 1 +
.../linux-ppc64-subcores2.signature | 1 +
.../linux-ppc64-subcores3
in the capabilities cache. In other words for archs
that support host-model CPUs.
Signed-off-by: Jiri Denemark
---
src/libvirt_private.syms | 2 ++
src/util/virhostcpu.c | 37 ++
src/util/virhostcpu.h | 2 ++
src/util/virhostcpupriv.h | 4
tests/virhostcputest.c
Signed-off-by: Jiri Denemark
---
src/util/virhostcpu.c | 50 +--
.../linux-x86_64-test1.signature | 1 +
.../linux-x86_64-test2.signature | 1 +
.../linux-x86_64-test3.signature | 1 +
.../linux-x86_64-test4
Signed-off-by: Jiri Denemark
---
src/util/virfile.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/util/virfile.h b/src/util/virfile.h
index 0a520a7522..7a92364a5c 100644
--- a/src/util/virfile.h
+++ b/src/util/virfile.h
@@ -89,6 +89,7 @@ static inline void virForceCloseHelper(int *fd
=1778819
Jiri Denemark (6):
util: Define g_autoptr callback for FILE
hostcpu: Introduce virHostCPUGetSignature
hostcpu: Implement virHostCPUGetSignature for x86
hostcpu: Implement virHostCPUGetSignature for ppc64
hostcpu: Implement virHostCPUGetSignature for s390
qemu: Invalidate capabilities
Signed-off-by: Jiri Denemark
---
src/util/virhostcpu.c| 16 +++-
.../linux-s390x-with-frequency.signature | 1 +
2 files changed, 16 insertions(+), 1 deletion(-)
create mode 100644 tests/virhostcpudata/linux-s390x-with-frequency.signature
diff
Signed-off-by: Jiri Denemark
---
Pushed. It is trivial and should fix the build on FreeBSD.
src/cpu/cpu_arm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c
index 66f6942ab9..6f6c6a1479 100644
--- a/src/cpu/cpu_arm.c
+++ b/src/cpu/cpu_arm.c
@@ -325,7
PU driver
> cpu_map: Introduce ARM cpu models
Nice, there's a few minor issues that needs fixing, but since I already
did all of them and really checked the code compiles fine after each
patch and tested it can still detect the host CPU, I'll squash the
suggested changes and push the series.
Reviewed-by: Jiri Denemark
On Wed, May 13, 2020 at 18:48:32 +0800, Zhenyu Zheng wrote:
> Add helper functions to parse vendor and model for
> ARM CPUs, and use them as callbacks when load cpu
> maps.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/cpu_arm.c | 159 +-
> 1 file
On Wed, May 13, 2020 at 18:48:34 +0800, Zhenyu Zheng wrote:
> Introduce getHost support for ARM CPU driver,
> read CPU vendor_id, part_id and flags from
> registers directly. These codes will only be
> compiled on aarch64 hardware.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/cpu_arm.c | 162
On Wed, May 13, 2020 at 18:48:36 +0800, Zhenyu Zheng wrote:
> Introduce vendors and some commonly used models
> for ARM arch, these will be used for virConnectionGetCapabilities
> for ARM CPUs.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu_map/Makefile.inc.am | 7 +++
>
On Wed, May 13, 2020 at 18:48:30 +0800, Zhenyu Zheng wrote:
> Introduce virCPUarmData to virCPUData and related
> structs to cpu_arm.c for ARM cpus.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/Makefile.inc.am | 1 +
> src/cpu/cpu.h | 2 ++
> src/cpu/cpu_arm.c | 80
The structure is not specific to x86 and thus its cleanup function
should be defined in cpu.h and be available to all users.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu.h | 1 +
src/cpu/cpu_x86.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/cpu/cpu.h b/src/cpu
On Wed, May 13, 2020 at 12:30:48 +0100, Daniel P. Berrangé wrote:
> On Wed, May 13, 2020 at 01:19:35PM +0200, Andrea Bolognani wrote:
...
> > I completely agree, #nnn is too ambiguous to be useful.
>
> The widespread usage by any other project using GitLab/GitHub proves
> otherwise and libvirt
On Wed, Apr 22, 2020 at 15:11:16 +0800, ZhengZhenyu wrote:
> Introduce vendors and some commonly used models
> for ARM arch, these will be used for virConnectionGetCapabilities
> for ARM CPUs.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu_map/Makefile.inc.am | 7 +++
>
On Wed, Apr 22, 2020 at 15:11:24 +0800, ZhengZhenyu wrote:
> Introduce getHost support for ARM CPU driver, read
> CPU vendor_id, part_id and flags from registers
> directly. These codes will only be compiled on
> aarch64 hardwares.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/cpu_arm.c | 204
On Wed, Apr 22, 2020 at 15:11:22 +0800, ZhengZhenyu wrote:
> Add helper functions to parse vendor and model from
> xml for ARM arch, and use them as callbacks when
> load cpu maps.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/cpu_arm.c | 173 +-
>
On Wed, Apr 22, 2020 at 15:11:20 +0800, ZhengZhenyu wrote:
> Introduce vendor and model struct and related
> cleanup functions for ARM cpu.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/cpu_arm.c | 73 +++
> 1 file changed, 73 insertions(+)
>
>
On Wed, Apr 22, 2020 at 15:11:18 +0800, ZhengZhenyu wrote:
> Introduce virCPUarmData to virCPUData
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/Makefile.inc.am | 1 +
> src/cpu/cpu.h | 2 ++
> src/cpu/cpu_arm_data.h | 31 +++
> 3 files changed, 34
On Wed, Apr 22, 2020 at 15:11:14 +0800, ZhengZhenyu wrote:
> Introduce getHost support for ARM CPU driver. First add
> some data about commonly used ARM CPU models, and their
> vendors into cpu_map, then added some helper methods as
> callbacks to load them. Read and parse vendor_id, part_id
> and
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
...4-cpuid-Ryzen-9-3900X-12-Core-disabled.xml |8 +
...64-cpuid-Ryzen-9-3900X-12-Core-enabled.xml | 10 +
...6_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml | 28 +
...86_64-cpuid-Ryzen-9-3900X-12-Core
in the future. Such enhancement should exclusively use the result
of query-cpu-model-expansion. Until proper host-model support is
implemented for ARM (if ever), we need to make sure the detected host
CPU is not accidentally used for host-model CPUs.
Signed-off-by: Jiri Denemark
---
src/qemu
Hi.
On Wed, Apr 29, 2020 at 16:03:19 +0800, Zhenyu Zheng wrote:
> Hi Jiri，
>
> Thanks alot for the help, I've updated the series to v4 and also attached
> pipeline results for each patch as suggested.
I explicitly said you don't have to send a new version just for that
small issue...
And I
On Wed, Apr 22, 2020 at 15:14:01 +0800, Zhenyu Zheng wrote:
> gitlab CI testing as suggested:
> https://gitlab.com/ZhengZhenyu/libvirt/pipelines/134657317
Sending results of CI pipeline makes sense only when the code submitted
for CI is exactly the same as submitted for review. You should just
On Fri, Apr 17, 2020 at 16:53:18 +0800, Zhenyu Zheng wrote:
> Ping for reviews
Could you please resend the new version of patches as a separate series
(don't forget to update the subject to v3)? Hunting for the new patches
hidden in random replies to the reviewers comments or original patches
is
This fixes build on mingw broken by my previous commit 36e125296a.
Signed-off-by: Jiri Denemark
---
Pushed.
src/util/virdaemon.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/util/virdaemon.c b/src/util/virdaemon.c
index 6182ca3c21..31cc24e703 100644
--- a/src
waiting for child processes) is no longer
needed and it is effectively reverted by this commit.
Signed-off-by: Jiri Denemark
---
src/util/virdaemon.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/util/virdaemon.c b/src/util/virdaemon.c
index 99530fd146
_SIZE].set) {
> *flags |= VIR_MIGRATE_COMPRESSED;
> -return 0;
> }
>
> for (i = 0; i < QEMU_MIGRATION_COMPRESS_LAST; ++i) {
Oops, looks like a leftover from the past when xbzrle-cache-size was
the only parameter.
Reviewed-by: Jiri Denemark
On Thu, Apr 02, 2020 at 17:03:59 +0800, Zhenyu Zheng wrote:
> Introduce getHost support for ARM CPU driver, read
> CPU vendor_id, part_id and flags from registers
> directly.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/cpu_arm.c | 194 +-
> 1 file
On Thu, Apr 09, 2020 at 11:28:04 +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 02, 2020 at 05:03:59PM +0800, Zhenyu Zheng wrote:
> > Introduce getHost support for ARM CPU driver, read
> > CPU vendor_id, part_id and flags from registers
> > directly.
> >
> > Signed-off-by: Zhenyu Zheng
> > ---
>
On Tue, Apr 07, 2020 at 17:36:18 +0200, Ján Tomko wrote:
> On a Friday in 2020, Jiri Denemark wrote:
> >CPU models defined in the cpu_map can use signature/@stepping attribute
> >to match a limited set of stepping numbers. The value is a bitmap for
> >bits 0..15 each corr
On Tue, Apr 07, 2020 at 12:08:37 +0200, Ján Tomko wrote:
> On a Friday in 2020, Jiri Denemark wrote:
> >Signed-off-by: Jiri Denemark
> >---
> > src/cpu/cpu_x86.c | 64 ++-
> > 1 file changed, 24 insertions(+), 40 deletions(-)
On Tue, Apr 07, 2020 at 08:39:10 +0200, Ján Tomko wrote:
> On a Friday in 2020, Jiri Denemark wrote:
> >The hint was introduced a long time ago when broken TSX implementation
> >was found in Haswell and Broadwell CPUs. Since then many more CPUs with
> >TSX were introduced
On Fri, Mar 27, 2020 at 16:51:20 +0100, Peter Krempa wrote:
> Look for the questionmark in the name and move the contents into the
> query portion so that we format the URI back properly.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_block.c | 6 ++
> 1 file changed, 6 insertions(+)
The documentation could confuse people to expect that CPU models with
usable='no' attribute are not usable at all on the current host. But
they cannot be only used without explicitly disabling some features.
Signed-off-by: Jiri Denemark
---
docs/formatdomaincaps.html.in | 8 +---
1 file
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index fce7a2b8c5..d0ef66f1e3 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -771,9 +771,9 @@ x86DataToCPU
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 6758fcc170..e4e21fbed4 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -1848,34 +1848,31
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index a65215caed..16e73b5b98 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -3113,7 +3113,7
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 3f6d889722..a65215caed 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -3059,30 +3059,29 @@ static
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 9f6027ec5c..8da8b3ada2 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -2857,9 +2857,8 @@ static int
Skylake-Server with family 6, model 85, stepping 4, which is currently
mis-detected as Cascadelake-Server CPU model.
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
.../x86_64-cpuid-Xeon-Gold-6130-disabled.xml |7 +
.../x86_64-cpuid-Xeon-Gold-6130
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index ba269df66d..6c3f9fc0be 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -1636,8 +1636,8
Later in this series the function will work on a newly introduced
virCPUx86Signatures structure. Let's move it to the place were all
related functions will be added and rename the function as
virCPUx86SignaturesMatch for easier review of the virCPUx86Signatures
patch.
Signed-off-by: Jiri Denemark
It can be used for separating family, model, and stepping numbers from a
single 32b integer as reported by CPUID.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 46 +-
1 file changed, 17 insertions(+), 29 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 7bd19a1676..ccbae3dabd 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index bcb87d6f93..fce7a2b8c5 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -3123,21 +3123,13 @@ virCPUx86GetModels
Cascadelake-Server with family 6, model 85, stepping 7.
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
...6_64-cpuid-Xeon-Platinum-9242-disabled.xml |7 +
...86_64-cpuid-Xeon-Platinum-9242-enabled.xml | 10 +
.../x86_64-cpuid-Xeon-Platinum-9242
Thanks to glib allocation functions which abort on OOM the function
cannot ever return NULL.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index ed6c1b43d3..51c98efca9
Later in this series the function will work on a newly introduced
virCPUx86Signatures structure. Let's move it to the place were all
related functions will be added and rename the function as
virCPUx86SignaturesFormat for easier review of the virCPUx86Signatures
patch.
Signed-off-by: Jiri
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 26 ++
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 0be2cf517d..3f6d889722 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -3019,45 +3019,39
to stepping='0-15'.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 60 +++
1 file changed, 50 insertions(+), 10 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 51c98efca9..bd224a9d0d 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu
The CPU models in our cpu_map define their signatures using separate
family and model numbers. Let's store the signatures in the same way in
our runtime representation of the cpu_map.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 149 +-
1 file
The signatures of these two CPU model differ only in stepping as both
report family 6 and model 85. Skylake-Server uses stepping 4 or less and
Cascadelake-Server uses stepping 5..7.
https://bugzilla.redhat.com/show_bug.cgi?id=1761678
Signed-off-by: Jiri Denemark
---
src/cpu_map/x86_Cascadelake
The function will be used for freeing virCPUx86Signatures structure
introduced later in this series.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 182d0da97c
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 3b3a428ecd..7bd19a1676 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -2641,18 +2641,18 @@ static int
Later in this series the function will work on a newly introduced
virCPUx86Signatures structure. Let's move it to the place were all
related functions will be added and rename the function as
virCPUx86SignaturesCopy for easier review of the virCPUx86Signatures
patch.
Signed-off-by: Jiri Denemark
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 42 +++---
1 file changed, 15 insertions(+), 27 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 8da8b3ada2..0be2cf517d 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
The signatures of these two CPU model differ only in stepping as both
report family 6 and model 85. Skylake-Server uses stepping 4 or less and
Cascadelake-Server uses stepping 5..7.
https://bugzilla.redhat.com/show_bug.cgi?id=1761678
Jiri Denemark (39):
cpu_x86: Drop noTSX hint
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 26 +-
1 file changed, 9 insertions(+), 17 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index e4e21fbed4..26d872622e 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -2034,15 +2034,14
1001 - 1100 of 7240 matches
Mail list logo
