On Wed, Oct 25, 2023 at 12:24 PM +0200, Martin Kletzander
wrote:
> On Wed, Oct 25, 2023 at 11:03:54AM +0200, Marc Hartmayer wrote:
>>Document the following changes:
>> + added `virsh console --resume` subcommand option
>> + improved `virsh start --console` behavior
>&g
On Tue, Oct 24, 2023 at 09:29 AM -0700, Andrea Bolognani
wrote:
> On Tue, Oct 24, 2023 at 05:14:41PM +0200, Marc Hartmayer wrote:
>> On Tue, Oct 24, 2023 at 02:12 PM +0200, Michal Prívozník
>> wrote:
>> > On 9/28/23 17:37, Marc Hartmayer wrote:
>> >> Ma
Document the following changes:
+ added `virsh console --resume` subcommand option
+ improved `virsh start --console` behavior
+ improved `virsh create --console` behavior
Signed-off-by: Marc Hartmayer
---
NEWS.rst | 15 +++
1 file changed, 15 insertions(+)
diff --git a/NEWS.rst
On Tue, Oct 24, 2023 at 02:12 PM +0200, Michal Prívozník
wrote:
> On 9/28/23 17:37, Marc Hartmayer wrote:
>> Currently, early console output may be lost, e.g. if starting a guest with
>> `virsh start --console` guest, which can make debugging of early failures
>> very
>&
On Wed, Oct 11, 2023 at 10:05 AM +0200, "Marc Hartmayer"
wrote:
> On Thu, Sep 28, 2023 at 05:37 PM +0200, Marc Hartmayer
> wrote:
>> Currently, early console output may be lost, e.g. if starting a guest with
>> `virsh start --console` guest, which can make debuggin
On Thu, Sep 28, 2023 at 05:37 PM +0200, Marc Hartmayer
wrote:
> Currently, early console output may be lost, e.g. if starting a guest with
> `virsh start --console` guest, which can make debugging of early failures very
> difficult
> (like zipl messages or disabled wait conditio
Reviewed-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
---
tools/virsh-domain.c | 34 --
1 file changed, 28 insertions(+), 6 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 36670039444c..2f055df0d97d 100644
--- a/tools/virsh-domain.c
-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
---
tools/virsh-domain.c | 50 +++-
1 file changed, 35 insertions(+), 15 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 5c3c6d18aebf..36670039444c 100644
--- a/tools/virsh-domain.c
side just (re-)connected`
[1]
Changelog:
RFCv1->v1:
+ rebased on current master
+ worked in comments from Daniel
[1] https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg02725.html
Marc Hartmayer (3):
virsh: add `console --resume` support
Improve `virsh start --console` behavior
Impr
e messages.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
---
tools/virsh-console.c | 8
tools/virsh-console.h | 1 +
tools/virsh-domain.c | 14 ++
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/tools/virsh-console.c b/tools/virsh-conso
On Mon, Sep 25, 2023 at 04:15 PM +0100, Daniel P. Berrangé
wrote:
> On Mon, Sep 25, 2023 at 03:39:09PM +0200, Marc Hartmayer wrote:
>> When starting a guest via libvirt (`virsh start --console`), early
>> console output was missed because the guest was started first and then
side just (re-)connected`
[1]
[1] https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg02725.html
Marc Hartmayer (3):
virsh: add `console --resume` support
Improve `virsh start --console` behavior
Improve `virsh create --console` behavior
tools/virsh-console.c | 8
tools/virsh
-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
---
tools/virsh-domain.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 5c3c6d18aebf..3581161c6f53 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
Reviewed-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
---
tools/virsh-domain.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 3581161c6f53..5a97d44190c4 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh
e messages.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
---
tools/virsh-console.c | 8
tools/virsh-console.h | 1 +
tools/virsh-domain.c | 14 ++
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/tools/virsh-console.c b/tools/virsh-conso
test' },
> @@ -308,6 +307,12 @@ tests += [
>{ 'name': 'virmigtest' },
> ]
>
> +if host_machine.endian() == 'little'
> + tests += [
> +{ 'name': 'viracpitest' },
> + ]
> +endif
> +
> if host_machine.system() == 'linux'
>tests += [
> { 'name': 'fchosttest' },
> --
> 2.39.0
LGTM.
Reviewed-by: Marc Hartmayer
quot;));
Not sure if the error message is clear enough… PV also depends on the
kernel cmdline opt-in - `prot_virt=1` has to be set.
> return -1;
> }
> break;
> --
> 2.37.1
>
Reviewed-by: Marc Hartmayer
Thanks for fixing this.
--
Kind regards / Beste
On Tue, Oct 13, 2020 at 07:10 PM +0200, Michal Privoznik
wrote:
> On 10/13/20 6:53 PM, Marc Hartmayer wrote:
>> Halil Pasic (1):
>>Reflect in virtiofs.rst that virtiofs can be used without NUMA
>>
>> Marc Hartmayer (1):
>>qemu: virtiofs can be used witho
From: Halil Pasic
Reflect in the virtiofs documentation that virtiofs can now be used
even without NUMA. While at it, be more precise where and why shared
memory is required.
Signed-off-by: Halil Pasic
Signed-off-by: Marc Hartmayer
---
docs/kbase/virtiofs.rst | 17 -
1 file
-by: Marc Hartmayer
---
src/qemu/qemu_validate.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 27e10d59fd25..bc3043bb3f0d 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -3470,14
Halil Pasic (1):
Reflect in virtiofs.rst that virtiofs can be used without NUMA
Marc Hartmayer (1):
qemu: virtiofs can be used without NUMA nodes
docs/kbase/virtiofs.rst | 17 -
src/qemu/qemu_validate.c | 13 +
2 files changed, 21 insertions(+), 9 deletions
On Tue, Oct 06, 2020 at 06:20 PM +0200, Marc Hartmayer
wrote:
> ...if a machine memory-backend using shared memory is configured for
> the guest. This is especially important for QEMU machine types that
> don't have NUMA but virtiofs support.
>
> An example snippet:
&g
-by: Marc Hartmayer
---
Note: There are still some TODOs left... e.g. adapt the virtiofs
documentation of libvirt.
---
src/qemu/qemu_validate.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index a212605579d2
evlinks = 0x3ff90194670,
caps = 0x3ff90194380
}
Fixes: 05e6cdafa6e0 ("node_device: detect CSS devices")
Reviewed-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/node
.c| 2 +-
>> 3 files changed, 6 insertions(+), 6 deletions(-)
>>
>> --
>> 2.25.1
>>
>
> Reviewed-by: Erik Skultety
>
Thanks.
--
Kind regards / Beste Grüße
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsi
od‘ everything works because
then ‘device-mapper‘ is listed in /proc/devices.
>
> causes the entry to appear, and from that moment on guest startup
> will work as expected regardless of whether or not AppArmor is
> enabled.
>
> I hope the information above can help someone who's familiar with the
> code figure out a fix. I'll provide more if needed, just ask! I can
> also provide prebuilt .deb files for 6.6.0 that consistently trigger
> the issue when added to a bog standard Debian testing installation.
>
> --
> Andrea Bolognani / Red Hat / Virtualization
>
--
Kind regards / Beste Grüße
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM,
> -QEMU_CAPS_VIRTIO_PCI_ATS);
> +QEMU_CAPS_VIRTIO_PCI_ATS,
> +QEMU_CAPS_VIRTIO_PACKED_QUEUES);
>
> DO_TEST("fd-memory-numa-topology", QEMU_CAPS_OBJECT_MEMORY_FILE,
> QEMU_CAPS_KVM);
> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
> index b4c83fcc..756d4e2c 100644
> --- a/tests/qemuxml2xmltest.c
> +++ b/tests/qemuxml2xmltest.c
> @@ -1291,7 +1291,8 @@ mymain(void)
> QEMU_CAPS_DEVICE_VIDEO_PRIMARY,
> QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM,
> QEMU_CAPS_VIRTIO_PCI_ATS,
> -QEMU_CAPS_DEVICE_VHOST_USER_GPU);
> +QEMU_CAPS_DEVICE_VHOST_USER_GPU,
> +QEMU_CAPS_VIRTIO_PACKED_QUEUES);
>
> DO_TEST("fd-memory-numa-topology", QEMU_CAPS_OBJECT_MEMORY_FILE,
> QEMU_CAPS_KVM);
> --
> 2.24.1
Reviewed-by: Marc Hartmayer
ch source '%s'"),
> + virTristateSwitchTypeToString(dst->packed),
> + virTristateSwitchTypeToString(src->packed));
> +return false;
> + }
> return true;
> }
>
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index 2038b54c..22f6990e 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -2417,6 +2417,7 @@ struct _virDomainVsockDef {
> struct _virDomainVirtioOptions {
> virTristateSwitch iommu;
> virTristateSwitch ats;
> +virTristateSwitch packed;
> };
>
> /*
> --
> 2.24.1
Reviewed-by: Marc Hartmayer
emucapabilitiesdata/caps_5.0.0.ppc64.xml
> b/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
> index a6800482..b0891613 100644
> --- a/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
> +++ b/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
> @@ -191,6 +191,7 @@
>
>
>
> +
>4002050
>0
>42900241
> diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
> b/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
> index df3557d1..b73c4efd 100644
> --- a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
> +++ b/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
> @@ -228,6 +228,7 @@
>
>
>
> +
>4002091
>0
>43100241
> --
> 2.24.1
Reviewed-by: Marc Hartmayer
On Fri, Dec 13, 2019 at 03:32 PM -0500, Cole Robinson
wrote:
> On 12/12/19 8:46 AM, Marc Hartmayer wrote:
>> On Wed, Dec 11, 2019 at 08:11 PM -0500, Cole Robinson
>> wrote:
>>> On 11/14/19 12:44 PM, Marc Hartmayer wrote:
>>>> The commit 'close callback: mov
dir());
I would suggest to use 'g_build_path' instead of 'g_strdup_printf'.
E.g.
g_build_path(G_DIR_SEPARATOR_S, g_get_home_dir(), "libvirt");
> }
>
>
> --
> 2.23.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/
On Fri, Dec 13, 2019 at 03:00 PM -0500, Cole Robinson
wrote:
> On 12/12/19 9:13 AM, Marc Hartmayer wrote:
>> On Wed, Dec 11, 2019 at 07:48 PM -0500, Cole Robinson
>> wrote:
>>> On 11/14/19 12:44 PM, Marc Hartmayer wrote:
>>>> To free the structs and save th
On Wed, Dec 11, 2019 at 07:48 PM -0500, Cole Robinson
wrote:
> On 11/14/19 12:44 PM, Marc Hartmayer wrote:
>> To free the structs and save the error, it is not necessary to hold
>> @priv->lock,
>> therefore move these parts after the mutex unlock.
>>
&g
On Wed, Dec 11, 2019 at 08:11 PM -0500, Cole Robinson
wrote:
> On 11/14/19 12:44 PM, Marc Hartmayer wrote:
>> The commit 'close callback: move it to driver' (88f09b75eb99) moved
>> the responsibility for the close callback to the driver. But if the
>> d
On Thu, Nov 14, 2019 at 06:44 PM +0100, Marc Hartmayer
wrote:
> The second patch of this patch series fixes the behavior of
> virConnectRegisterCloseCallback.
>
> The subsequent patches remove the need to have the global variables
> 'qemuProgram' and 'remoteProgram' in libvirtd.
, for example memory leaks, as the caller cannot
differentiate whether the close callback was 'really' registered or
not.
Therefore call directly @freecb if the connectRegisterCloseCallback
API is not supported by the driver used by the connection and update
the documentation.
Signed-off-by: Marc
As a result, you can later determine during the callback which program
was used. This makes it easier to refactor the code in the future and
is less prone to error.
Signed-off-by: Marc Hartmayer
Reviewed-by: Pavel Hrdina
---
src/remote/remote_daemon_dispatch.c | 108
This patch introduces virNetServerGetProgramLocked. It's a function to
determine which program has to be used for a given @msg. This function
will be reused in the next patch.
Signed-off-by: Marc Hartmayer
Reviewed-by: Pavel Hrdina
---
src/rpc/virnetserver.c | 28
This allows us later to get rid of another usage of the global
variable `remoteProgram`.
Signed-off-by: Marc Hartmayer
Reviewed-by: Pavel Hrdina
---
src/remote/remote_daemon_dispatch.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/src/remote
hes
- Added r-b to patch 5
- Worked in comments
- Rebased
- Added patches 7-9
Marc Hartmayer (7):
rpc: use the return value of virObjectRef directly
virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no
connectRegisterCloseCallback
remote: Save reference to program
To free the structs and save the error, it is not necessary to hold @priv->lock,
therefore move these parts after the mutex unlock.
Signed-off-by: Marc Hartmayer
---
src/remote/remote_daemon_dispatch.c | 32 ++---
1 file changed, 16 insertions(+), 16 deletions(-)
d
Use the return value of virObjectRef directly. This way, it's easier
for another reader to identify the reason why the additional reference
is required.
Signed-off-by: Marc Hartmayer
Reviewed-by: John Ferlan
Reviewed-by: Pavel Hrdina
---
src/rpc/virnetserver.c | 3 +--
1 file changed, 1
Use virNetServerGetProgram() to determine the virNetServerProgram
instead of using hard coded global variables. This allows us to remove
the global variables @remoteProgram and @qemuProgram as they're now no
longer necessary.
Signed-off-by: Marc Hartmayer
---
src/libvirt_remote.syms
On Thu, Nov 14, 2019 at 09:20 AM +0100, Pavel Hrdina wrote:
> On Wed, Nov 13, 2019 at 07:12:34PM +0100, Marc Hartmayer wrote:
>> On Wed, Nov 13, 2019 at 09:52 AM +0100, Pavel Hrdina
>> wrote:
>> > On Fri, Nov 01, 2019 at 06:35:48PM +0100, Marc Hartmayer wrote:
>>
On Wed, Nov 13, 2019 at 09:52 AM +0100, Pavel Hrdina wrote:
> On Fri, Nov 01, 2019 at 06:35:48PM +0100, Marc Hartmayer wrote:
>> Use virNetServerGetProgram() to determine the virNetServerProgram
>> instead of using hard coded global variables. This allows us to remove
>>
On Fri, Nov 08, 2019 at 04:52 PM +0100, Pavel Hrdina wrote:
> On Fri, Nov 01, 2019 at 06:35:44PM +0100, Marc Hartmayer wrote:
>> The commit 'close callback: move it to driver' (88f09b75eb99) moved
>> the responsibility for the close callback to the driver. But if the
>> d
This patch introduces virNetServerGetProgramLocked. It's a function to
determine which program has to be used for a given @msg. This function
will be reused in the next patch.
Signed-off-by: Marc Hartmayer
---
src/rpc/virnetserver.c | 28 +---
1 file changed, 21
Use virNetServerGetProgram() to determine the virNetServerProgram
instead of using hard coded global variables. This allows us to remove
the global variables @remoteProgram and @qemuProgram as they're now no
longer necessary.
Signed-off-by: Marc Hartmayer
---
src/libvirt_remote.syms
As a result, you can later determine during the callback which program
was used. This makes it easier to refactor the code in the future and
is less prone to error.
Signed-off-by: Marc Hartmayer
---
src/remote/remote_daemon_dispatch.c | 108 +++-
1 file changed, 59
Use the return value of virObjectRef directly. This way, it's easier
for another reader to identify the reason why the additional reference
is required.
Signed-off-by: Marc Hartmayer
Reviewed-by: John Ferlan
---
src/rpc/virnetserver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
This allows us later to get rid of another usage of the global
variable `remoteProgram`.
Signed-off-by: Marc Hartmayer
---
src/remote/remote_daemon_dispatch.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/src/remote/remote_daemon_dispatch.c
b/src
ere to many changes in the meantime
- Removed accepted patches
- Dropped patches 8 and 9
+ v1->v2:
- Removed accepted patches
- Removed NACKed patches
- Added r-b to patch 5
- Worked in comments
- Rebased
- Added patches 7-9
Marc Hartmayer (6):
rpc: use the return
, for example memory leaks, as the caller cannot
differentiate whether the close callback was 'really' registered or
not.
Therefore call directly @freecb if the connectRegisterCloseCallback
API is not supported by the driver used by the connection.
Signed-off-by: Marc Hartmayer
---
src/libvirt-host.c
On Mon, Feb 25, 2019 at 02:38 PM +0100, Ján Tomko wrote:
> On Wed, Feb 20, 2019 at 09:51:07AM +0100, Marc Hartmayer wrote:
>>Replace virDomainChrSourceDefFree with virObjectUnref.
>>
>>Signed-off-by: Marc Hartmayer
>>Reviewed-by: Boris Fiuczynski
>>---
>
Use refcounting for priv->monConfig instead of asymmetric freeing.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_driver.c | 5 +
src/qemu/qemu_process.c | 6 +++---
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/
On Tue, Feb 12, 2019 at 09:46 PM +0100, John Ferlan wrote:
> On 2/7/19 11:08 AM, Marc Hartmayer wrote:
>> Commit "nodedev: Move device enumumeration out of nodeStateInitialize"
>> (9f0ae0b18e3e620) has moved the heavy task of device enumeration into
>>
Changelog:
+ RFC -> v1:
- Remove the event handle in the error path of nodeStateInitializeEnumerate
- Added patch 2: wake up udev thread in case of an error
Marc Hartmayer (2):
udev: nodeStateInitializeEnumerate: remove watch handle in case of an
error
udev: wake up the udev thr
If the udev thread is stopped, it must be ensured that the watch
handle is also removed from the main loop.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/node_device/node_device_udev.c
b/src/node_device
Signal the udev thread the change of `priv->threadQuit` by using the
thread condition.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/node_device/node_device_udev.c
b/src/node_device/node_device_udev.c
in
On Tue, Feb 12, 2019 at 09:46 PM +0100, John Ferlan wrote:
> On 2/7/19 11:08 AM, Marc Hartmayer wrote:
>> Commit "nodedev: Move device enumumeration out of nodeStateInitialize"
>> (9f0ae0b18e3e620) has moved the heavy task of device enumeration into
>>
Replace virDomainChrSourceDefFree with virObjectUnref.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
cfg.mk| 1 -
src/conf/domain_conf.c| 17 +
src/conf/domain_conf.h| 1 -
src/libvirt_private.syms | 1 -
src
Marc Hartmayer (2):
qemu: Use refcounting for priv->monConfig
qemu: Replace virDomainChrSourceDefFree with virObjectUnref
cfg.mk| 1 -
src/conf/domain_conf.c| 17 +
src/conf/domain_conf.h| 1 -
src/libvirt_private.syms |
ces(3)).
Reviewed-by: Bjoern Walk
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/src/node_device/node_device_udev.c
b/src/node_device/node_device_udev.c
index 299f55260129..eb4d8b3cfe4a 100
On Wed, Feb 13, 2019 at 03:56 PM +0100, John Ferlan wrote:
> On 2/13/19 7:38 AM, Marc Hartmayer wrote:
>> Even if an error is reported by `udev_enumerate_scan_devices`,
>> e.g. because a driver of a device has an bug, we can still enumerate
>> all other devices. Additiona
On Wed, Feb 13, 2019 at 03:03 PM +0100, John Ferlan wrote:
> On 2/13/19 4:34 AM, Marc Hartmayer wrote:
>> On Tue, Feb 12, 2019 at 09:46 PM +0100, John Ferlan
>> wrote:
>>> On 2/7/19 11:08 AM, Marc Hartmayer wrote:
>>>> Commit "nodedev: Move device
ces(3)).
Reviewed-by: Bjoern Walk
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/src/node_device/node_device_udev.c
b/src/node_device/node_device_udev.c
index 299f55260129..90168eb8a969 100
On Tue, Feb 12, 2019 at 09:46 PM +0100, John Ferlan wrote:
> On 2/7/19 11:08 AM, Marc Hartmayer wrote:
>> Commit "nodedev: Move device enumumeration out of nodeStateInitialize"
>> (9f0ae0b18e3e620) has moved the heavy task of device enumeration into
>>
On Thu, Feb 07, 2019 at 05:08 PM +0100, Marc Hartmayer
wrote:
> Commit "nodedev: Move device enumumeration out of nodeStateInitialize"
> (9f0ae0b18e3e620) has moved the heavy task of device enumeration into
> a separate thread. The problem with this commit is that there i
On Thu, Feb 07, 2019 at 05:08 PM +0100, Marc Hartmayer
wrote:
> Commit "nodedev: Move device enumumeration out of nodeStateInitialize"
> (9f0ae0b18e3e620) has moved the heavy task of device enumeration into
> a separate thread. The problem with this commit is that there i
the watch handle is removed from the main
loop.
Fixes: 9f0ae0b18e3e620 ("nodedev: Move device enumumeration out of
nodeStateInitialize")
Signed-off-by: Marc Hartmayer
---
Note: I'm not sure whether we should stop libvirtd (as it would have
been done before) or if this patch i
On Mon, Feb 04, 2019 at 02:37 PM +0100, Marc Hartmayer
wrote:
> On Mon, Feb 04, 2019 at 01:41 PM +0100, Peter Krempa
> wrote:
>> On Mon, Feb 04, 2019 at 13:36:24 +0100, Marc Hartmayer wrote:
>>> For normal starts (no incoming migration) the refresh of the QEMU
>>
On Mon, Feb 04, 2019 at 01:41 PM +0100, Peter Krempa wrote:
> On Mon, Feb 04, 2019 at 13:36:24 +0100, Marc Hartmayer wrote:
>> For normal starts (no incoming migration) the refresh of the QEMU
>> state must be done before the VCPUs getting started since otherwise
>>
ation after
transferring state" (93db7eea1b864).
Signed-off-by: Marc Hartmayer
---
src/qemu/qemu_process.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index dace5aaca102..2a3763f40d49 100644
---
ze audit
> layer"));
> }
> --
> 2.20.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
Thanks for fixing!
Reviewed-by: Marc Hartmayer
--
Kind regards / Beste Grüße
Marc Hartmayer
On Thu, Dec 20, 2018 at 09:15 PM +0100, Michal Prívozník
wrote:
> On 12/20/18 12:48 PM, Marc Hartmayer wrote:
>> On Wed, Dec 19, 2018 at 03:37 PM +0100, Michal Privoznik
>> wrote:
>>> On 12/19/18 2:54 PM, Ján Tomko wrote:
>>>>
>>>> Reviewed-by
).
>>
>> ACK (will wait a day or two for others to chime in before pushing)
>
> No objections were raised, so I've pushed this one.
Thanks.
>
> Michal
>
--
Kind regards / Beste Grüße
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzende des
Michal
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
--
Kind regards / Beste Grüße
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Matthias Hartmann
Geschäftsführun
On Tue, Nov 20, 2018 at 11:00 AM +0100, Marc Hartmayer
wrote:
> On Thu, Nov 01, 2018 at 04:37 PM +0100, Michal Privoznik
> wrote:
>> On 10/30/2018 01:55 PM, Daniel P. Berrangé wrote:
>>> On Tue, Oct 30, 2018 at 10:32:08AM +, Daniel P. Berrangé wrote:
>>>> O
From: Marc Hartmayer
The test driver state (@testDriver) uses it's own reference counting
and locking implementation. Instead of doing that, convert @testDriver
into a virObjectLockable and use the provided functionalities.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
The test driver state (@testDriver) uses it's own reference counting
and locking implementation. Instead of doing that, convert @testDriver
into a virObjectLockable and use the provided functionalities.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
This patch was originally
10/30/2018 10:35 AM, Daniel P. Berrangé wrote:
>>>>> On Tue, Oct 30, 2018 at 09:13:50AM +0100, Michal Privoznik wrote:
>>>>>> On 10/29/2018 06:34 PM, Marc Hartmayer wrote:
>>>>>>> Introduce caching whether /dev/kvm is usable as the QE
>> Matt
>>
>>
>>
>
>
> --
> Regards,
> Longpeng(Mike)
Hi Longpeng,
any updates so far? Is a v5 still planned?
Kind regards / Beste Grüße
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Ko
psPtr qemuCaps,
> qemuMonitorPtr mon);
> diff --git a/tests/qemucapabilitiestest.c b/tests/qemucapabilitiestest.c
> index 8fe5a55e1d..703fb6a125 100644
> --- a/tests/qemucapabilitiestest.c
> +++ b/tests/qemucapabilitiestest.c
> @@ -63,6 +63,9 @@ testQemuCaps(const void *o
gt; virSecuritySELinuxContextListPtr list;
> -int ret = 0;
> +int ret = -1;
>
> list = virThreadLocalGet();
> if (!list)
> --
> 2.18.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
Please apply this patch after the patch
"virSecuritySELinuxTransactionCommit: Don't mask error" from Michal.
---
src/security/security_selinux.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff
On Mon, Nov 12, 2018 at 03:13 PM +0100, "Daniel P. Berrangé"
wrote:
> On Mon, Nov 12, 2018 at 02:48:09PM +0100, Marc Hartmayer wrote:
>> On Mon, Nov 12, 2018 at 01:30 PM +0100, Pavel Hrdina
>> wrote:
>> > On Mon, Nov 12, 2018 at 12:50:41PM +0100, Marc Har
}
> +
> +
> static int
> qemuDomainDeviceDefValidateHostdev(const virDomainHostdevDef *hostdev,
> const virDomainDef *def,
> --
> 2.19.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailma
On Mon, Nov 12, 2018 at 01:30 PM +0100, Pavel Hrdina wrote:
> On Mon, Nov 12, 2018 at 12:50:41PM +0100, Marc Hartmayer wrote:
>> On Thu, Nov 01, 2018 at 09:31 AM +0100, Martin Kletzander
>> wrote:
>
> [...]
>
>> How can you run a machine/QEMU VM under a diff
gé wrote:
>>> >>>>> On Tue, Oct 30, 2018 at 09:13:50AM +0100, Michal Privoznik wrote:
>>> >>>>>> On 10/29/2018 06:34 PM, Marc Hartmayer wrote:
>>> >>>>>>> Introduce caching whether /dev/kvm is usable as t
he QEMU driver. This should
be pretty similar to your proposal with the global static variable.
>
>
> Regards,
> Daniel
> --
> |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o-https://fstop138.
or not and we only need to re-run the
virFileAccessibleAs check if the ctime of /dev/kvm has changed.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Marc Hartmayer
---
src/qemu/qemu_capabilities.c | 54 ++--
1 file changed, 52 insertions(+), 2 deletions(-)
diff --git
or not and we only need to re-run the
virFileAccessibleAs check if the ctime of /dev/kvm has changed.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Marc Hartmayer
---
src/qemu/qemu_capabilities.c | 56 ++--
1 file changed, 54 insertions(+), 2 deletions(-)
diff --git
On Wed, Oct 24, 2018 at 11:43 PM +0200, "Daniel P. Berrangé"
wrote:
> On Thu, Sep 20, 2018 at 07:44:46PM +0200, Marc Hartmayer wrote:
>> For a domain definition there are numerous calls of
>> virQEMUCapsCacheLookup (the same applies to the domain start). This
>&g
]
virFileIsSharedFixFUSE(path, (long *) _type);
Signed-off-by: Marc Hartmayer
---
src/util/virfile.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/util/virfile.c b/src/util/virfile.c
index 2a7e87102a25..6cde4ab6c23b 100644
--- a/src/util/virfile.c
+++ b
Use the correct type in order to fix the following error on s390x:
In function 'virFileIsSharedFSType':
../../src/util/virfile.c:3578:38: error: cast increases required alignment of
target type [-Werror=cast-align]
virFileIsSharedFixFUSE(path, (long *) _type);
Signed-off-by: Marc
On Mon, Oct 01, 2018 at 02:50 PM +0200, Peter Krempa wrote:
> On Mon, Oct 01, 2018 at 14:38:40 +0200, Marc Hartmayer wrote:
>> On Mon, Oct 01, 2018 at 12:41 PM +0200, Peter Krempa
>> wrote:
>> > On Mon, Oct 01, 2018 at 12:27:41 +0200, Marc Hartmayer wrote:
>> >&
g. define a domain). Therefore, it’s
possible that two calls of virQEMUCapsCacheLookup return different QEMU
capabilities.
[…snip]
--
Kind regards / Beste Grüße
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäft
On Mon, Oct 01, 2018 at 12:41 PM +0200, Peter Krempa wrote:
> On Mon, Oct 01, 2018 at 12:27:41 +0200, Marc Hartmayer wrote:
>> On Sat, Sep 29, 2018 at 04:09 AM +0200, John Ferlan
>> wrote:
>> > On 9/20/18 1:44 PM, Marc Hartmayer wrote:
>> >> Move the
On Sat, Sep 29, 2018 at 05:35 PM +0200, John Ferlan wrote:
> On 9/20/18 1:44 PM, Marc Hartmayer wrote:
>> For the usage of the parameter @parseOpqaue within
>> virDomainDefValidate it must be ensured that the parameter
>> @parseOpaque is not NULL. But since there
On Sat, Sep 29, 2018 at 05:34 PM +0200, John Ferlan wrote:
> On 9/20/18 1:44 PM, Marc Hartmayer wrote:
>> Add @parseOpaque argument to virDomainDefValidate and
>> virDomainDefValidateCallback, but don't use it for now since it's not
>> ensured that it's always a non-NULL va
1 - 100 of 481 matches
Mail list logo
