---
src/bhyve/bhyve_command.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
index b9df6d0..2ec97fc 100644
--- a/src/bhyve/bhyve_command.c
+++ b/src/bhyve/bhyve_command.c
@@ -216,6 +216,7 @@ static int
Addition of the hostbridge device was mistakenly placed to
bhyveBuildNetArgStr(). This could result in hostbridge device not being
added to the commandline if there are no network devices specified, but
hostbridge device should be added unconditionally.
Fix by placing it to
Add a check that domain is active before attempting to destroy it.
---
src/bhyve/bhyve_driver.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 9dbb299..60d49de 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
We have to explicitly destroy TAP devices on FreeBSD because
they're not freed after being closed, otherwise we end up with
orphaned TAP devices after destroying a domain.
---
src/qemu/qemu_process.c | 14 --
src/util/virnetdevtap.h | 6 ++
2 files changed, 18 insertions(+), 2
of that patch.
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
While I'm still fighting with console on FreeBSD, I decided to sumbit that fix
as it seems to be useful on its own. With that change I'm able to run virsh on
FreeBSD to connect to libvirtd on Linux and get console working properly there.
Roman Bogorodskiy (1):
Fix locking in virsh console
vshRunConsole() uses virCondWait() which is a wrapper around
pthread_cond_wait(). On FreeBSD, pthread_cond_wait needs mutex to be
locked, otherwise it immediately fails with EPERM. On Linux, the
behaviour in this case is undefined.
So lock the mutex before calling virCondWait().
---
Daniel P. Berrange wrote:
On Mon, Mar 10, 2014 at 03:04:15PM +0400, Roman Bogorodskiy wrote:
vshRunConsole() uses virCondWait() which is a wrapper around
pthread_cond_wait(). On FreeBSD, pthread_cond_wait needs mutex to be
locked, otherwise it immediately fails with EPERM. On Linux
Add virFDStreamOpenPTY() function which is a wrapper around
virFDStreamOpenFileInternal() with putting the device it opens into a
raw mode.
Make virChrdevOpen() use virFDStreamOpenPTY() for
VIR_DOMAIN_CHR_TYPE_PTY devices.
This fixes mangled console output when libvirt runs on FreeBSD as it
the device into a
raw mode works indeed!
Roman Bogorodskiy
pgpuWktsTK9Ix.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Do not include test_libvirt_lockd.aug when configured without qemu
driver.
https://bugzilla.redhat.com/show_bug.cgi?id=1071777
---
src/Makefile.am | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 25d0370..e5cbad0 100644
---
up BSD compilation in the first
place. Meanwhile, do you want to file a bug report to the BSD folks to
fix their stdio.h?
I think it's worth to include that patch because it costs nothing and
helps not to occasionally spot this problem again in future.
I'll make a bug report.
Thanks,
Roman
placed into files/ directory of the port. It works for me (both
with qemu driver disabled and enabled).
Patch is attached.
Roman Bogorodskiy
--- src/Makefile.in.bak 2014-03-07 14:35:24.0 +0400
+++ src/Makefile.in 2014-03-07 14:38:32.0 +0400
@@ -288,9 +288,9
wrong with the terminal settings, but how
could that be debugged?
PS Worth to mention that 'cu' worked all the time for me on these
devices (both created by bhyve and qemu).
Roman Bogorodskiy
pgpyZJ1gNMPpS.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https
playing with bhyve console and do debugging with qemu/freebsd
only for now.
Roman Bogorodskiy
pgp1DYNgWD3oj.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Daniel P. Berrange wrote:
On Fri, Mar 07, 2014 at 06:15:24PM +0400, Roman Bogorodskiy wrote:
Daniel P. Berrange wrote:
All those mangled messages are being printed out by libvirt client
code, and it is totally expected that log messages libvirt prints
are mangled in this way
Daniel P. Berrange wrote:
On Fri, Mar 07, 2014 at 07:49:04PM +0400, Roman Bogorodskiy wrote:
Daniel P. Berrange wrote:
On Fri, Mar 07, 2014 at 06:15:24PM +0400, Roman Bogorodskiy wrote:
Daniel P. Berrange wrote:
All those mangled messages are being printed out
configure check for character devices lock path calls
AC_DEFINE_UNQUOTED for VIR_CHRDEV_LOCK_FILE_PATH even if
$with_chrdev_lock_files = no.
So the locking code in conf/virchrdev.c:
#ifdef VIR_CHRDEV_LOCK_FILE_PATH
is compiled in even if it shouldn't, because VIR_CHRDEV_LOCK_FILE_PATH
is
Daniel P. Berrange wrote:
On Wed, Mar 05, 2014 at 07:34:11PM +0400, Roman Bogorodskiy wrote:
configure check for character devices lock path calls
AC_DEFINE_UNQUOTED for VIR_CHRDEV_LOCK_FILE_PATH even if
$with_chrdev_lock_files = no.
So the locking code in conf/virchrdev.c
-option
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
don't want to bother with autotools, there's a workaround to
try:
In src/Makefile.in, find a piece like that:
@WITH_QEMU_TRUE@test_libvirt_lockd.aug: locking/test_libvirt_lockd.aug.in \
After this block, add:
@WITH_QEMU_FALSE@test_libvirt_lockd.aug:
And re-run configure. Does it work?
Roman
---
src/bhyve/bhyve_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 23fab90..9dbb299 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@ -335,6 +335,7 @@ bhyveDomainDefineXML(virConnectPtr conn, const char
---
docs/drivers.html.in | 1 +
docs/drvbhyve.html.in | 83 +++
docs/index.html.in| 3 ++
docs/sitemap.html.in | 4 +++
src/README| 1 +
5 files changed, 92 insertions(+)
create mode 100644 docs/drvbhyve.html.in
diff --git
* drvuml.html.in: (connected) s/toa PTY/to a PTY/
---
docs/drvuml.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/drvuml.html.in b/docs/drvuml.html.in
index fe7769d..03c04ef 100644
--- a/docs/drvuml.html.in
+++ b/docs/drvuml.html.in
@@ -65,7 +65,7 @@
Eric Blake wrote:
On 03/01/2014 01:21 AM, Roman Bogorodskiy wrote:
---
src/bhyve/bhyve_driver.c | 1 +
1 file changed, 1 insertion(+)
ACK, let's get this in 1.2.2
Pushed, thanks!
Roman Bogorodskiy
pgpBNq6xIrPfu.pgp
Description: PGP signature
--
libvir-list mailing list
libvir
Eric Blake wrote:
On 03/01/2014 02:09 AM, Roman Bogorodskiy wrote:
---
docs/drivers.html.in | 1 +
docs/drvbhyve.html.in | 83
+++
docs/index.html.in| 3 ++
docs/sitemap.html.in | 4 +++
src/README| 1 +
5
Implement domainUndefine and required helper functions:
- domainIsActive
- domainIsPersistent
---
src/bhyve/bhyve_driver.c | 79
src/bhyve/bhyve_utils.h | 1 +
2 files changed, 80 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c
Re-add domain undefine support. I have already implemented it in v9
of my initial bhyve patch, but, apparently, based v10 not on v9, but on v8,
so this change didn't make it into the tree (shame on me).
Roman Bogorodskiy (1):
bhyve: support domain undefine
src/bhyve/bhyve_driver.c | 79
Eric Blake wrote:
On 02/28/2014 12:30 PM, Roman Bogorodskiy wrote:
Implement domainUndefine and required helper functions:
- domainIsActive
- domainIsPersistent
---
src/bhyve/bhyve_driver.c | 79
src/bhyve/bhyve_utils.h | 1
We have to explicitly destroy TAP devices on FreeBSD because
they're not freed after being closed, otherwise we end up with
orphaned TAP devices after destroying a domain.
---
src/qemu/qemu_process.c | 7 +++
src/util/virnetdevtap.h | 6 ++
2 files changed, 13 insertions(+)
diff --git
Daniel P. Berrange wrote:
On Mon, Feb 24, 2014 at 11:12:33PM +0400, Roman Bogorodskiy wrote:
We have to explicitly destroy TAP devices on FreeBSD because
they're not freed after being closed, otherwise we end up with
orphaned TAP devices after destroying a domain.
---
src/qemu
Daniel P. Berrange wrote:
On Wed, Feb 26, 2014 at 09:12:11AM -0700, Eric Blake wrote:
On 02/26/2014 08:57 AM, Roman Bogorodskiy wrote:
Conceptually ok, but I fear this impl will result in the logs getting
polluted with cannot delete tap device or similar log messages on OS
where
version
so I would need compatible libvirt.
You can find download links here:
http://libvirt.org/downloads.html
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
- Implement nodeGetCPUStats using nodeGetCPUStats()
- Implement nodeGetMemoryStats using nodeGetMemoryStats()
---
src/bhyve/bhyve_driver.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 7c6500f..35171d2
Daniel P. Berrange wrote:
On Mon, Feb 24, 2014 at 12:30:38PM +0400, Roman Bogorodskiy wrote:
- Implement nodeGetCPUStats using nodeGetCPUStats()
- Implement nodeGetMemoryStats using nodeGetMemoryStats()
---
src/bhyve/bhyve_driver.c | 29 +
1 file changed
We have to explicitly destroy TAP devices on FreeBSD because
they're not freed after being closed, otherwise we end up with
orphaned TAP devices after destroying a domain.
---
src/qemu/qemu_process.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/qemu/qemu_process.c
available which I can use
to compile this library for QNX ?
Hi,
The instruction is available here:
http://libvirt.org/compiling.html#compiling
I'm not sure it compiles on QNX though.
PS 0.9.8 is quite old, you could consider getting more recent version.
Roman Bogorodskiy
--
libvir-list
Daniel P. Berrange wrote:
ACK, and pushed to GIT.
Great job getting this new driver up running, and welcome to
the libvirt committers team.
Superb! Thanks!
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
driver global objects in StateCleanup instead
of ConnectClose
Changes from v4:
- Set acpi and apic flags based on domain definition
- Add more detailed description about -H and -P flags
of bhyve to justify theirs usage
Roman Bogorodskiy (1):
bhyve: add a basic driver
configure.ac
(C) 2014 Roman Bogorodskiy
+dnl
+dnl This library is free software; you can redistribute it and/or
+dnl modify it under the terms of the GNU Lesser General Public
+dnl License as published by the Free Software Foundation; either
+dnl version 2.1 of the License, or (at your option) any later version
success/development !
Agreed.
It's still very basic and not intended for production use at this point,
both feature-wise and testing-wise.
My plan is to get fundamental things ready first and then move forward
incrementally, which should be good for both reviewing and development.
Roman
versions, since it took me until v9 to take a peek :)
Thanks for the thoughtful review! I've addressed issues Daniel and you
point out and uploaded v10. Hope I didn't miss anything, there were
quite a few changes.
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https
is
needed to make viraudit.{c,h} work on FreeBSD, and use domain_audit.c
for this.
Will do s/INFO/DEBUG/. I'll take a look at viraudit later too.
1:
http://www.freebsd.org/cgi/man.cgi?query=bhyveapropos=0sektion=0manpath=FreeBSD+10.0-RELEASEarch=defaultformat=html
Thanks for the review!
Roman
Copyright (C) 2014 Roman Bogorodskiy
+dnl
+dnl This library is free software; you can redistribute it and/or
+dnl modify it under the terms of the GNU Lesser General Public
+dnl License as published by the Free Software Foundation; either
+dnl version 2.1 of the License, or (at your option) any
detailed description about -H and -P flags
of bhyve to justify theirs usage
Roman Bogorodskiy (1):
bhyve: add a basic driver
configure.ac| 7 +
daemon/libvirtd.c | 9 +
include/libvirt/virterror.h | 1 +
m4/virt-driver-bhyve.m4 | 57
po/POTFILES.in
Copyright (C) 2014 Roman Bogorodskiy
+dnl
+dnl This library is free software; you can redistribute it and/or
+dnl modify it under the terms of the GNU Lesser General Public
+dnl License as published by the Free Software Foundation; either
+dnl version 2.1 of the License, or (at your option) any later
uname(3)
- Cleanup driver global objects in StateCleanup instead
of ConnectClose
Changes from v4:
- Set acpi and apic flags based on domain definition
- Add more detailed description about -H and -P flags
of bhyve to justify theirs usage
Roman Bogorodskiy (1):
bhyve: add a basic driver
these options for now.
I'd suggest this building is done before loading the domain
so you don't needlessly load the domain before we detect any
possible user configuration errors.
Good idea, appreciated it while testing incorrect disk type/bus checks.
Fixed in v8.
Thanks for the review!
Roman
objects in StateCleanup instead
of ConnectClose
Changes from v4:
- Set acpi and apic flags based on domain definition
- Add more detailed description about -H and -P flags
of bhyve to justify theirs usage
Roman Bogorodskiy (2):
bhyve: add a basic driver
bhyve: add ACL support
---
src/Makefile.am | 5 ++--
src/bhyve/bhyve_driver.c | 63
2 files changed, 61 insertions(+), 7 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 3567d13..d0aa18d 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@
Copyright (C) 2014 Roman Bogorodskiy
+dnl
+dnl This library is free software; you can redistribute it and/or
+dnl modify it under the terms of the GNU Lesser General Public
+dnl License as published by the Free Software Foundation; either
+dnl version 2.1 of the License, or (at your option) any later
David Shane Holden wrote:
On 02/08/14 01:26, Roman Bogorodskiy wrote:
--- a/configure.ac
+++ b/configure.ac
@@ -2704,6 +2710,7 @@ AC_MSG_NOTICE([ PHYP: $with_phyp])
AC_MSG_NOTICE([ ESX: $with_esx])
AC_MSG_NOTICE([ Hyper-V: $with_hyperv])
AC_MSG_NOTICE([Parallels
Reset line numbering on each input file in check-aclrules.pl. Otherwise
it reports wrong line numbers in its error messages.
Signed-off-by: Yuri Myasoedov ymyasoe...@yandex.ru
---
src/check-aclrules.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/check-aclrules.pl
Changes from v5:
- Obtain version using uname(3)
- Cleanup driver global objects in StateCleanup instead
of ConnectClose
Changes from v4:
- Set acpi and apic flags based on domain definition
- Add more detailed description about -H and -P flags
of bhyve to justify theirs usage
Roman
Copyright (C) 2014 Roman Bogorodskiy
+dnl
+dnl This library is free software; you can redistribute it and/or
+dnl modify it under the terms of the GNU Lesser General Public
+dnl License as published by the Free Software Foundation; either
+dnl version 2.1 of the License, or (at your option) any later
David Shane Holden wrote:
On 02/07/14 02:51, Roman Bogorodskiy wrote:
At this point it has a limited functionality and is highly
experimental. Supported domain operations are:
* define * start * destroy * dumpxml * dominfo
Tested this a bit and it works for me. I can define
limitations (i.e. missing firewalling part in bridge
driver, etc).
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Daniel P. Berrange wrote:
On Thu, Feb 06, 2014 at 12:07:10AM +0400, Roman Bogorodskiy wrote:
Daniel P. Berrange wrote:
+virCommandAddArg(cmd, -H); /* vmexit from guest on hlt */
+virCommandAddArg(cmd, -P); /* vmexit from guest on pause */
What's the functional
and looks good to me.
Now 'make check' works successfully on FreeBSD.
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Changes from v4:
- Set acpi and apic flags based on domain definition
- Add more detailed description about -H and -P flags
of bhyve to justify theirs usage
Roman Bogorodskiy (1):
bhyve: add a basic driver
configure.ac| 7 +
daemon/libvirtd.c | 9 +
include
Copyright (C) 2014 Roman Bogorodskiy
+dnl
+dnl This library is free software; you can redistribute it and/or
+dnl modify it under the terms of the GNU Lesser General Public
+dnl License as published by the Free Software Foundation; either
+dnl version 2.1 of the License, or (at your option) any later
and pause).
I guess it'd be better not to use it so bhyve process doesn't suddenly
vanish from libvirt radar?
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Ján Tomko wrote:
Rewrite the function to use an array instead of a struct,
translating the field names to int via an enum.
That works as expected on FreeBSD.
Thanks,
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Copyright (C) 2014 Roman Bogorodskiy
+dnl
+dnl This library is free software; you can redistribute it and/or
+dnl modify it under the terms of the GNU Lesser General Public
+dnl License as published by the Free Software Foundation; either
+dnl version 2.1 of the License, or (at your option) any later
Check for presence of sys/cpuset.h header and cpuset_getaffinity()
in configure instead of just using #ifdef __FreeBSD__ for that code.
---
configure.ac | 10 ++
src/util/virprocess.c | 7 +--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/configure.ac
Implementation obtains CPU usage information using
kern.cp_time and kern.cp_times sysctl(8)s and reports
CPU utilization.
---
include/libvirt/libvirt.h.in | 8
src/nodeinfo.c | 104 +++
tools/virsh-host.c | 11 -
3 files
A set of fields for CPU stats could vary on different platforms,
for example, FreeBSD doesn't report 'iowait'.
Make virsh print out only the fields that were actually filled.
---
tools/virsh-host.c | 119 -
1 file changed, 72 insertions(+), 47
way to
implement CPU stats on FreeBSD.
Meanwhile, I've uploaded an updated patch which revolves your comments.
Thanks,
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Some syntax-check rules use GNU sed specific regexps, so allow
to override which sed would be used to fix 'syntax-check' for
non GNU-userland systems.
---
cfg.mk | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index 207dfeb..bd984bd 100644
---
, as Eric pointed.
For sure, using portable regexps is better way, but I don't know how
much of effort that would be.
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Implement virProcess{Get,Set}Affinity() using cpuset_getaffinity()
and cpuset_setaffinity() calls. Quick search showed that they are
only available on FreeBSD, so placed it inside existing #ifdef
blocks for FreeBSD instead of adding configure checks.
---
src/util/virprocess.c | 39
cpuset -l 0-3 -p 1308
And check back again:
virsh # vcpuinfo qemu
VCPU: 0
CPU:0
State: running
CPU Affinity:
virsh #
Roman Bogorodskiy (1):
BSD: implement virProcess{Get,Set}Affinity
src/util/virprocess.c | 39 +--
1
100644
index 000..7b13722
--- /dev/null
+++ b/m4/virt-driver-bhyve.m4
@@ -0,0 +1,52 @@
+dnl The bhyve driver
+dnl
+dnl Copyright (C) 2014 Roman Bogorodskiy
+dnl
+dnl This library is free software; you can redistribute it and/or
+dnl modify it under the terms of the GNU Lesser General Public
+dnl
to bhyve_command.c
* Attempt to unload VM on errors
Roman Bogorodskiy (1):
bhyve: add a basic driver
configure.ac| 11 +
daemon/libvirtd.c | 9 +
include/libvirt/virterror.h | 1 +
m4/virt-driver-bhyve.m4 | 52
src/Makefile.am | 38 +++
src/bhyve
Implementation obtains CPU usage information using
kern.cp_time and kern.cp_times sysctl(8)s and reports
CPU utilization.
---
include/libvirt/libvirt.h.in | 8
src/nodeinfo.c | 104 +++
tools/virsh-host.c | 11 -
3 files
A set of fields for CPU stats could vary on different platforms,
for example, FreeBSD doesn't report 'iowait'.
Make virsh print out only the fields that were actually filled.
---
tools/virsh-host.c | 118 -
1 file changed, 71 insertions(+), 47
: 0,8%
system: 0,9%
idle:97,5%
intr: 0,8%
usage:2,5%
Includes intr, doesn't have iowait.
Roman Bogorodskiy (2):
BSD: implement nodeGetCPUStats
virsh: report only filled values in 'nodecpustats'
include/libvirt/libvirt.h.in | 8 +++
src
Roman Bogorodskiy wrote:
A set of fields for CPU stats could vary on different platforms,
for example, FreeBSD doesn't report 'iowait'.
Make virsh print out only the fields that were actually filled.
---
tools/virsh-host.c | 118
This is useful in certain circumstances, for example when
libvirtd is being executed by FreeBSD rc script, it cannot find
dmidecode installed from FreeBSD ports because it doesn't have
/usr/local (default prefix for ports) in PATH.
---
configure.ac | 4
src/util/virsysinfo.c | 2 +-
Implementation obtains CPU usage information using
kern.cp_time and kern.cp_times sysctl(8)s and reports
CPU utilization.
---
include/libvirt/libvirt.h.in | 8
src/nodeinfo.c | 104 +++
tools/virsh-host.c | 11 -
3 files
Daniel P. Berrange wrote:
On Tue, Jan 14, 2014 at 12:47:20PM +0400, Roman Bogorodskiy wrote:
I had doubts how to implement that. Looks like the current
implementation is tied to Linux CPU metrics:
user nice system idle iowait
That list is hardcoded into virsh-host.c. FreeBSD
time. I decided to go without
virsh-host.c modification and used VIR_NODE_CPU_STATS_UTILIZATION.
If you know better way of doing that, I'm open for suggestions.
Roman Bogorodskiy (1):
BSD: implement nodeGetCPUStats
src/nodeinfo.c | 85
Implementation obtains CPU usage information using
kern.cp_time and kern.cp_times sysctl(8)s and reports
CPU utilization.
---
src/nodeinfo.c | 85 ++
1 file changed, 85 insertions(+)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index
Daniel P. Berrange wrote:
On Tue, Jan 14, 2014 at 12:47:20PM +0400, Roman Bogorodskiy wrote:
I had doubts how to implement that. Looks like the current
implementation is tied to Linux CPU metrics:
user nice system idle iowait
That list is hardcoded into virsh-host.c. FreeBSD
John Ferlan wrote:
On 01/03/2014 01:35 PM, Roman Bogorodskiy wrote:
Add a BSD implementation of nodeGetMemoryStats based
on sysctl(3).
---
src/nodeinfo.c | 82
+-
1 file changed, 81 insertions(+), 1 deletion(-)
ACK
Hi
Add a BSD implementation of nodeGetMemoryStats based
on sysctl(3).
---
src/nodeinfo.c | 80 +-
1 file changed, 79 insertions(+), 1 deletion(-)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index 1838547..5e84e78 100644
--- a/src/nodeinfo.c
for checking that. I'll re-roll the patch then.
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Add a BSD implementation of nodeGetMemoryStats based
on sysctl(3).
---
src/nodeinfo.c | 82 +-
1 file changed, 81 insertions(+), 1 deletion(-)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index 1838547..05bc038 100644
--- a/src/nodeinfo.c
guests
+ *
+ * Copyright (C) 2013 Roman Bogorodskiy
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option
under #ifdef __FreeBSD__ only.
Roman Bogorodskiy (1):
BSD: implement nodeGetMemoryStats
src/nodeinfo.c | 73 ++
1 file changed, 73 insertions(+)
--
1.8.4.3
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman
Add a BSD implementation of nodeGetMemoryStats based
on sysctl(3).
---
src/nodeinfo.c | 73 ++
1 file changed, 73 insertions(+)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index 1838547..ecacfa4 100644
--- a/src/nodeinfo.c
+++
the missing #endif before I did a git commit
--amend so it didn't appear here. But if this is ACK'd rest assured, I've
fixed it locally.
Just for the record, this patch (with adding #endif) fixes build for me
as well.
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
= __import__('libvirt-override').__version__,
url = 'http://www.libvirt.org',
maintainer = 'Libvirt Maintainers',
maintainer_email = 'libvir-list@redhat.com',
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir
/bhyve/bhyve_driver.c
new file mode 100644
index 000..a155b1a
--- /dev/null
+++ b/src/bhyve/bhyve_driver.c
@@ -0,0 +1,529 @@
+/*
+ * bhyve_driver.c: core driver methods for managing bhyve guests
+ *
+ * Copyright (C) 2013 Roman Bogorodskiy
+ *
+ * This library is free software; you can redistribute
on secure
Roman Bogorodskiy (1):
bhyve: add a basic driver
configure.ac| 37
daemon/libvirtd.c | 9 +
include/libvirt/virterror.h | 1 +
src/Makefile.am | 35 +++
src/bhyve/bhyve_driver.c| 529
src
Eric Blake wrote:
With my help on IRC, Roman Bogorodskiy identified a bug where the
BSD autoconf wrapper script eats stdin[1], which in turn causes
autopoint from gettext 0.18.3 to fail to find AM_GNU_GETTEXT_VERSION
within configure.ac[2], with this error:
./bootstrap: autopoint --force
Eric Blake wrote:
On 08/11/2013 07:54 AM, Roman Bogorodskiy wrote:
Provide an implementation of virNetDev(Set|Clear)IPv4Address based on
BSD ifconfig tool in addition to 'ip' from Linux iproute2 package.
---
configure.ac | 15 +++
src/util/virnetdev.c | 24
Roman Bogorodskiy wrote:
Eric Blake wrote:
On 08/11/2013 07:54 AM, Roman Bogorodskiy wrote:
Provide an implementation of virNetDev(Set|Clear)IPv4Address based on
BSD ifconfig tool in addition to 'ip' from Linux iproute2 package.
---
configure.ac | 15
Roman Bogorodskiy wrote:
Implement networkEnableIpForwarding() using BSD style sysctl.
---
configure.ac| 7 ---
src/network/bridge_driver.c | 13 +
2 files changed, 17 insertions(+), 3 deletions(-)
ping?
Roman Bogorodskiy
pgphJ37aCW7yP.pgp
Description
Roman Bogorodskiy wrote:
Provide an implementation of virNetDev(Set|Clear)IPv4Address based on
BSD ifconfig tool in addition to 'ip' from Linux iproute2 package.
---
configure.ac | 15 +++
src/util/virnetdev.c | 24
2 files changed, 39
801 - 900 of 997 matches
Mail list logo
