Re: [libvirt] [PATCH v2 4/8] qemu: vfio-ccw device address generation

2018-05-15 Thread Shalini Chellathurai Saroja
On 05/14/2018 06:30 PM, John Ferlan wrote: On 05/14/2018 03:43 AM, Boris Fiuczynski wrote: On 05/10/2018 10:52 PM, John Ferlan wrote: On 05/07/2018 10:41 AM, Boris Fiuczynski wrote: From: Shalini Chellathurai Saroja <shal...@linux.vnet.ibm.com> Introduces the vfio-ccw model for me

[libvirt] [PATCH] tests: Update caps for QEMU 2.12.0 on s390x

2018-05-15 Thread Shalini Chellathurai Saroja
Let us update the existing xml and replies files for QEMU 2.12.0 on s390x. Signed-off-by: Shalini Chellathurai Saroja <shal...@linux.vnet.ibm.com> --- tests/domaincapsschemadata/qemu_2.12.0.s390x.xml | 99 +- .../qemucapabilitiesdata/caps_2.12.0.s390x.replies

Re: [libvirt] [PATCH] tests: Update caps for QEMU 2.12.0 on s390x

2018-05-16 Thread Shalini Chellathurai Saroja
On 05/16/2018 04:41 PM, John Ferlan wrote: On 05/16/2018 04:40 AM, Boris Fiuczynski wrote: On 05/15/2018 10:37 PM, John Ferlan wrote: On 05/15/2018 07:46 AM, Shalini Chellathurai Saroja wrote: Let us update the existing xml and replies files for QEMU 2.12.0 on s390x. Signed-off

[libvirt] [PATCH 4/8] qemu: vfio-ccw device address generation

2018-04-11 Thread Shalini Chellathurai Saroja
Introduces the vfio-ccw model for mediated devices and prime vfio-ccw devices such that CCW address will be generated. Signed-off-by: Shalini Chellathurai Saroja <shal...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiu

[libvirt] [PATCH 1/8] qemu: introduce capability for virtual-css-bridge

2018-04-11 Thread Shalini Chellathurai Saroja
on the existence of the QEMU type. Let us also add the capability QEMU_CAPS_CCW to the tests which require support for ccw devices. Signed-off-by: Shalini Chellathurai Saroja <shal...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiu

[libvirt] [PATCH 5/8] qemu: command line generation for vfio-ccw device

2018-04-11 Thread Shalini Chellathurai Saroja
Generates the QEMU command line for the vfio-ccw device. Signed-off-by: Shalini Chellathurai Saroja <shal...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Reviewed-by: Marc Hartmayer <mhart.

[libvirt] [PATCH 7/8] docs: documentation for vfio-ccw passthrough

2018-04-11 Thread Shalini Chellathurai Saroja
Signed-off-by: Shalini Chellathurai Saroja <shal...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- docs/drvnodedev.html.in | 21 - docs/formatdomain.html.in | 20 +

[libvirt] [PATCH 6/8] tests: tests for vfio-ccw passthrough

2018-04-11 Thread Shalini Chellathurai Saroja
Let us test the following functionalities of vfio-ccw in libvirt 1. Generation of QEMU command line from domain xml file 2. Generation of dump xml from domain xml file 3. Checks duplicate/invalid addresses for vfio-ccw devices. Signed-off-by: Shalini Chellathurai Saroja <s

[libvirt] [PATCH 0/8] vfio-ccw passthrough support

2018-04-11 Thread Shalini Chellathurai Saroja
Let us support the basic channel I/O passthrough infrastructure based on vfio, which have been introduced in QEMU 2.10. The current focus is to support dasd-eckd (cu_type/dev_type = 0x3990/0x3390) as the target device. Shalini Chellathurai Saroja (8): qemu: introduce capability for virtual-css

[libvirt] [PATCH 2/8] qemu: introduce vfio-ccw capability

2018-04-11 Thread Shalini Chellathurai Saroja
property. Signed-off-by: Shalini Chellathurai Saroja <shal...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- src/qemu/qemu_capabilities.c | 14 ++ src/qemu/q

Re: [libvirt] [PATCH 0/8] vfio-ccw passthrough support

2018-04-12 Thread Shalini Chellathurai Saroja
On 04/11/2018 05:49 PM, Shalini Chellathurai Saroja wrote: Let us support the basic channel I/O passthrough infrastructure based on vfio, which have been introduced in QEMU 2.10. The current focus is to support dasd-eckd (cu_type/dev_type = 0x3990/0x3390) as the target device

[libvirt] [PATCH 3/8] util: virhostdev: add virHostdevIsMdevDevice()

2018-04-15 Thread Shalini Chellathurai Saroja
Add the function virHostdevIsMdevDevice() which detects whether a hostdev is a mediated device or not. Also, replace all existing conditionals. Signed-off-by: Shalini Chellathurai Saroja <shal...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Bori

[libvirt] [PATCH 8/8] news: documentation of new feature

2018-04-15 Thread Shalini Chellathurai Saroja
Signed-off-by: Shalini Chellathurai Saroja <shal...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 798ab6da40..41bd2ab372 100644 --- a/d

Re: [libvirt] [PATCH 2/8] qemu: introduce vfio-ccw capability

2018-04-16 Thread Shalini Chellathurai Saroja
On 04/12/2018 10:44 AM, Cornelia Huck wrote: On Wed, 11 Apr 2018 17:49:53 +0200 Shalini Chellathurai Saroja <shal...@linux.vnet.ibm.com> wrote: Let us introduce the capability vfio-ccw for supporting the basic channel I/O passthrough, which have been introduced in QEMU 2.10. The c

Re: [libvirt] [PATCH 0/8] vfio-ccw passthrough support

2018-04-24 Thread Shalini Chellathurai Saroja
Polite ping. On 04/11/2018 05:49 PM, Shalini Chellathurai Saroja wrote: Let us support the basic channel I/O passthrough infrastructure based on vfio, which have been introduced in QEMU 2.10. The current focus is to support dasd-eckd (cu_type/dev_type = 0x3990/0x3390) as the target device

[PATCH libvirt v1 4/6] qemu: move ZPCI uid validation into device validation

2020-04-09 Thread Shalini Chellathurai Saroja
The ZPCI device validation is specific to qemu. So, let us move the ZPCI uid validation out of domain xml parsing into qemu domain device validation. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/conf/device_conf.c | 3 --- src

[PATCH libvirt v1 1/6] conf: fix ZPCI address validation on s390

2020-04-09 Thread Shalini Chellathurai Saroja
later code assume that invalid numerical values mean that they have been unspecified. Signed-off-by: Bjoern Walk Signed-off-by: Boris Fiuczynski Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/conf/device_conf.

[PATCH libvirt v1 6/6] tests: add test with PCI and CCW device

2020-04-09 Thread Shalini Chellathurai Saroja
Add test with a ZPCI host device and a CCW memballoon device to ensure that CCW address remains the default address assigned. Signed-off-by: Boris Fiuczynski Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- .../hostdev-vfio-zpci-ccw

[PATCH libvirt v1 3/6] conf: fix ZPCI address auto-generation on s390

2020-04-09 Thread Shalini Chellathurai Saroja
that both uid and fid are specified. This bug is fixed by identifying when the user specified ZPCI address is incomplete and auto-generating the missing ZPCI address. Signed-off-by: Boris Fiuczynski Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski

[PATCH libvirt v1 0/6] Fix ZPCI address auto-generation on s390

2020-04-09 Thread Shalini Chellathurai Saroja
following reasons 1. If uid = 0 or fid = 0 the code assumes that user has not specified the corresponding address 2. If either uid or fid is provided, the code assumes that both uid and fid addresses are specified by the user. This patch fixes these issues. Shalini Chellathurai Saroja (6

[PATCH libvirt v1 2/6] tests: qemu: add tests for ZPCI on s390

2020-04-09 Thread Shalini Chellathurai Saroja
Add test to verify ZPCI address validation with uid set to 0x0 Signed-off-by: Bjoern Walk Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- .../hostdev-vfio-zpci-uid-set-zero.xml| 20 +++ tests/qemuxml2argvtest.c

[PATCH libvirt v1 5/6] tests: qemu: add more tests for ZPCI on S390

2020-04-09 Thread Shalini Chellathurai Saroja
for parse error when both uid and fid are set to zero 6. Test for error while specifying uid and not providing ZPCI capability. Signed-off-by: Boris Fiuczynski Signed-off-by: Bjoern Walk Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski

Re: [PATCH libvirt v1 0/6] Fix ZPCI address auto-generation on s390

2020-04-29 Thread Shalini Chellathurai Saroja
Hi Andrea, Ping, in case you missed it. On 4/20/20 9:55 PM, Boris Fiuczynski wrote: On 4/10/20 2:06 PM, Andrea Bolognani wrote: On Thu, 2020-04-09 at 12:30 +0200, Shalini Chellathurai Saroja wrote: The ZPCI address validation or autogeneration does not work as expected in the following

Re: [PATCH libvirt v1 0/6] Fix ZPCI address auto-generation on s390

2020-06-02 Thread Shalini Chellathurai Saroja
On 6/1/20 6:49 PM, Andrea Bolognani wrote: On Wed, 2020-05-20 at 13:32 +0200, Boris Fiuczynski wrote: If I do not misinterpret Dan's last mail he agrees that specifying uid=0 should be considered as error. How do we proceed from here? Shalini series still can be applied on master cleanly. Do

Re: [PATCH 1/1] domain_conf.c: skip checking ZPCI address is incomplete if not present

2020-06-30 Thread Shalini Chellathurai Saroja
95fa160 CC: Bjoern Walk CC: Boris Fiuczynski CC: Shalini Chellathurai Saroja CC: Andrea Bolognani Signed-off-by: Daniel Henrique Barboza --- src/conf/domain_conf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

Re: [PATCH 1/1] domain_conf.c: skip checking ZPCI address is incomplete if not present

2020-07-01 Thread Shalini Chellathurai Saroja
Hi Daniel, Thank you for letting me know:-) Warm Regards Shalini C S On 6/30/20 7:44 PM, Daniel Henrique Barboza wrote: Hi Shalini, On 6/30/20 12:52 PM, Shalini Chellathurai Saroja wrote: Hi Daniel, Sorry for the incorrect code. Thank you for identifying and fixing it:-) Glad I could

Re: [PATCH libvirt v2 0/5] Fix zPCI address auto-generation on s390

2020-06-24 Thread Shalini Chellathurai Saroja
Ping, in case you missed it. On 6/18/20 10:25 AM, Shalini Chellathurai Saroja wrote: The zPCI address validation or autogeneration does not work as expected in the following scenarios 1. uid = 0 and fid = 0 2. uid = 0 and fid > 0 3. uid = 0 and fid not specified 4. uid not specified and fid

Re: [PATCH libvirt v2 2/5] conf: fix zPCI address auto-generation on s390

2020-06-26 Thread Shalini Chellathurai Saroja
On 6/25/20 7:43 PM, Andrea Bolognani wrote: First of all, this is much closer to what I had in mind. Good job! Hi Andrea, Thank you:-) We're not quite there yet, though: as you can see from the hunks above, there are still many scenarios in which we're either manipulating id->value and

Re: [PATCH libvirt v2 0/5] Fix zPCI address auto-generation on s390

2020-06-26 Thread Shalini Chellathurai Saroja
On 6/25/20 8:01 PM, Andrea Bolognani wrote: On Thu, 2020-06-18 at 10:25 +0200, Shalini Chellathurai Saroja wrote: Shalini Chellathurai Saroja (5): conf: use g_autofree to ensure automatic cleanup conf: fix zPCI address auto-generation on s390 qemu: move ZPCI uid validation into device

Re: [PATCH libvirt v1 3/6] conf: fix ZPCI address auto-generation on s390

2020-06-16 Thread Shalini Chellathurai Saroja
Hi Andrea, Thank you for the review. On 6/3/20 12:58 PM, Andrea Bolognani wrote: On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote: +++ b/src/conf/domain_addr.c @@ -145,12 +145,18 @@ static void virDomainZPCIAddressReleaseIds(virDomainZPCIAddressIdsPtr zpciIds

[PATCH libvirt v2 0/5] Fix zPCI address auto-generation on s390

2020-06-18 Thread Shalini Chellathurai Saroja
/archives/libvir-list/2020-April/msg00479.html Shalini Chellathurai Saroja (5): conf: use g_autofree to ensure automatic cleanup conf: fix zPCI address auto-generation on s390 qemu: move ZPCI uid validation into device validation tests: qemu: add more tests for ZPCI on S390 tests: add test

[PATCH libvirt v2 4/5] tests: qemu: add more tests for ZPCI on S390

2020-06-18 Thread Shalini Chellathurai Saroja
for parse error when both uid and fid are set to zero 6. Test for error while specifying uid and not providing ZPCI capability. Signed-off-by: Boris Fiuczynski Signed-off-by: Bjoern Walk Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski

[PATCH libvirt v2 2/5] conf: fix zPCI address auto-generation on s390

2020-06-18 Thread Shalini Chellathurai Saroja
e user specified ZPCI address is incomplete and auto-generating the missing ZPCI address. Signed-off-by: Bjoern Walk Signed-off-by: Boris Fiuczynski Signed-off-by: Shalini Chellathurai Saroja --- src/conf/device_conf.c| 33 src/conf/domain_

[PATCH libvirt v2 5/5] tests: add test with PCI and CCW device

2020-06-18 Thread Shalini Chellathurai Saroja
Add test with a ZPCI host device and a CCW memballoon device to ensure that CCW address remains the default address assigned. Signed-off-by: Boris Fiuczynski Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- .../hostdev-vfio-zpci-ccw

[PATCH libvirt v2 1/5] conf: use g_autofree to ensure automatic cleanup

2020-06-18 Thread Shalini Chellathurai Saroja
Signed-off-by: Bjoern Walk Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Boris Fiuczynski --- src/conf/device_conf.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 4dbd5c1a..1d06981a 100644

[PATCH libvirt v2 3/5] qemu: move ZPCI uid validation into device validation

2020-06-18 Thread Shalini Chellathurai Saroja
The ZPCI device validation is specific to qemu. So, let us move the ZPCI uid validation out of domain xml parsing into qemu domain device validation. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/conf/device_conf.c | 3 --- src

Re: [PATCH libvirt v1 5/6] tests: qemu: add more tests for ZPCI on S390

2020-06-08 Thread Shalini Chellathurai Saroja
Hi Andrea, Thank you for the review. On 6/3/20 2:45 PM, Andrea Bolognani wrote: On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote: +++ b/tests/qemuxml2argvtest.c @@ -1650,6 +1655,12 @@ mymain(void) DO_TEST("hostdev-vfio-zpci-autogen

Re: [PATCH libvirt v1 6/6] tests: add test with PCI and CCW device

2020-06-08 Thread Shalini Chellathurai Saroja
Hi Andrea, Thank you for the review. On 6/3/20 2:45 PM, Andrea Bolognani wrote: On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote: +++ b/tests/qemuxml2argvtest.c @@ -1676,6 +1676,10 @@ mymain(void) DO_TEST_PARSE_ERROR("hostdev-vfio-zpci-set

Re: [PATCH libvirt v1 4/6] qemu: move ZPCI uid validation into device validation

2020-06-08 Thread Shalini Chellathurai Saroja
Hi Andrea, Thank you for the review. On 6/3/20 2:15 PM, Andrea Bolognani wrote: On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote: +static bool +qemuDomainDeviceDefValidateZPCIUid(virZPCIDeviceAddressPtr zpci) +{ +if (zpci->uid_set && +

Re: [PATCH libvirt v1 2/6] tests: qemu: add tests for ZPCI on s390

2020-06-08 Thread Shalini Chellathurai Saroja
Hi Andrea, Thank you for the review. On 6/3/20 12:11 PM, Andrea Bolognani wrote: On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote: Add test to verify ZPCI address validation with uid set to 0x0 Signed-off-by: Bjoern Walk Signed-off-by: Shalini Chellathurai Saroja

Re: [PATCH libvirt v1 1/6] conf: fix ZPCI address validation on s390

2020-06-08 Thread Shalini Chellathurai Saroja
Hi Andrea, Thank you for the review. On 6/3/20 12:09 PM, Andrea Bolognani wrote: On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote: -if (uid && -virStrToLong_uip(uid, NULL, 0, ) < 0) { -virReportError(VIR_ERR_INTERNAL

Re: [PATCH libvirt v1] tests: add capabilities for QEMU 5.2.0 on s390x

2021-01-12 Thread Shalini Chellathurai Saroja
On 1/4/21 9:44 AM, Andrea Bolognani wrote: On Mon, 2020-12-28 at 12:41 +0100, Shalini Chellathurai Saroja wrote: On 12/17/20 12:19 PM, Andrea Bolognani wrote: On Wed, 2020-12-16 at 10:10 +0100, Shalini Chellathurai Saroja wrote: +++ b/tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml @@ -0,0

Re: [PATCH libvirt v1] tests: add capabilities for QEMU 5.2.0 on s390x

2021-01-12 Thread Shalini Chellathurai Saroja
On 1/12/21 11:09 AM, Andrea Bolognani wrote: On Tue, 2021-01-12 at 09:17 +0100, Shalini Chellathurai Saroja wrote: On 1/4/21 9:44 AM, Andrea Bolognani wrote: On Mon, 2020-12-28 at 12:41 +0100, Shalini Chellathurai Saroja wrote: On 12/17/20 12:19 PM, Andrea Bolognani wrote: On Wed, 2020-12

Re: [PATCH libvirt v4 00/12] Support AP card, AP queues and AP matrix

2020-12-07 Thread Shalini Chellathurai Saroja
On 12/4/20 11:24 AM, Erik Skultety wrote: On Thu, Dec 03, 2020 at 06:59:32PM +0100, Shalini Chellathurai Saroja wrote: Add support for AP card devices, AP queues and AP matrix devices in libvirt node device driver. --- v4: - Added virNodeDevAPAdapterParseXML function to extract the adapter

Re: [PATCH libvirt v2 06/11] nodedev: detect AP matrix device

2020-12-03 Thread Shalini Chellathurai Saroja
On 11/30/20 2:46 PM, Erik Skultety wrote: On Fri, Nov 13, 2020 at 03:45:33PM +0100, Shalini Chellathurai Saroja wrote: On 11/12/20 9:29 PM, Jonathon Jongsma wrote: diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index 6bbff571..5f57000e 100644 --- a/src

[PATCH libvirt v4 05/12] virsh: nodedev: Filter by AP card and AP queue capabilities

2020-12-03 Thread Shalini Chellathurai Saroja
From: Farhan Ali Add support to filter by 'ap_card' and 'ap_queue' capabilities. Signed-off-by: Farhan Ali Reviewed-by: Boris Fiuczynski Reviewed-by: Bjoern Walk Signed-off-by: Shalini Chellathurai Saroja --- docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-nodedev.h | 2

[PATCH libvirt v4 10/12] node_device: mdev matrix support

2020-12-03 Thread Shalini Chellathurai Saroja
Allow mdev devices to be created on the matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 5 - src/node_device/node_device_udev.c | 8 ++-- 2 files changed, 10 insertions(+), 3

[PATCH libvirt v4 04/12] tests: AP queue node device

2020-12-03 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP queues Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_07_0038.xml | 9 + tests/nodedevxml2xmltest.c

[PATCH libvirt v4 12/12] NEWS: mention node device driver support for AP devices

2020-12-03 Thread Shalini Chellathurai Saroja
Signed-off-by: Shalini Chellathurai Saroja --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 135c4e2f..5fa9d68f 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -13,6 +13,12 @@ v7.0.0 (unreleased) * **New features** + * nodedev: Add node device driver

[PATCH libvirt v4 11/12] node_device: detecting mdev_types capability on ap_matrix device

2020-12-03 Thread Shalini Chellathurai Saroja
From: Boris Fiuczynski Add detection of mdev_types capability to Adjunct Processor Matrix device. Signed-off-by: Boris Fiuczynski Reviewed-by: Shalini Chellathurai Saroja Reviewed-by: Jonathon Jongsma Signed-off-by: Shalini Chellathurai Saroja --- docs/formatnode.html.in

[PATCH libvirt v4 01/12] nodedev: detect AP card device

2020-12-03 Thread Shalini Chellathurai Saroja
Introduce support for the Adjunct Processor (AP) crypto card device. Udev already detects the device, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs

[PATCH libvirt v4 02/12] tests: AP card node device

2020-12-03 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP card device. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_card07.xml | 8 tests/nodedevxml2xmltest.c

[PATCH libvirt v4 09/12] node_device: refactor address retrieval of node device

2020-12-03 Thread Shalini Chellathurai Saroja
Use switch statements instead of if-else condition in the method nodeDeviceFindAddressByName to retrieve address of a node device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 30

[PATCH libvirt v4 06/12] nodedev: detect AP matrix device

2020-12-03 Thread Shalini Chellathurai Saroja
Add support for AP matrix device in libvirt node device driver. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/schemas/nodedev.rng | 7 +++ src/conf/node_device_conf.c| 9 + src/conf/node_device_conf.h

[PATCH libvirt v4 07/12] tests: AP matrix node device

2020-12-03 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_matrix.xml| 7

[PATCH libvirt v4 00/12] Support AP card, AP queues and AP matrix

2020-12-03 Thread Shalini Chellathurai Saroja
card and AP queue capabilities Shalini Chellathurai Saroja (10): nodedev: detect AP card device tests: AP card node device nodedev: detect AP queues tests: AP queue node device nodedev: detect AP matrix device tests: AP matrix node device virsh: nodedev: filter by AP Matrix capability

[PATCH libvirt v4 03/12] nodedev: detect AP queues

2020-12-03 Thread Shalini Chellathurai Saroja
Each AP card device can support upto 256 AP queues. AP queues are also detected by udev, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/formatnode.html.in

[PATCH libvirt v4 08/12] virsh: nodedev: filter by AP Matrix capability

2020-12-03 Thread Shalini Chellathurai Saroja
Add support to filter by 'ap_matrix' capability. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/formatnode.html.in | 3 +++ docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-nodedev.h | 1 + src/conf

Re: [PATCH libvirt v4 00/12] Support AP card, AP queues and AP matrix

2020-12-09 Thread Shalini Chellathurai Saroja
On 12/9/20 2:03 PM, Erik Skultety wrote: On Fri, Dec 04, 2020 at 11:24:12AM +0100, Erik Skultety wrote: On Thu, Dec 03, 2020 at 06:59:32PM +0100, Shalini Chellathurai Saroja wrote: Add support for AP card devices, AP queues and AP matrix devices in libvirt node device driver. --- v4

Re: [PATCH libvirt v3 01/11] nodedev: detect AP card device

2020-12-02 Thread Shalini Chellathurai Saroja
Hello Erik, I will make changes based on your comments in here and patch 03. Thank you very much for the review. On 11/30/20 3:20 PM, Erik Skultety wrote: On Tue, Nov 17, 2020 at 01:10:55PM +0100, Shalini Chellathurai Saroja wrote: Introduce support for the Adjunct Processor (AP) crypto

Re: [PATCH libvirt v1] tests: add capabilities for QEMU 5.1.0 on s390x

2020-12-14 Thread Shalini Chellathurai Saroja
On 12/14/20 10:10 AM, Andrea Bolognani wrote: On Wed, 2020-11-18 at 17:18 +0100, Shalini Chellathurai Saroja wrote: Signed-off-by: Shalini Chellathurai Saroja --- The replies file is removed from this patch and is available in https://gitlab.com/shalinichellathurai/libvirt/-/commit

Re: [PATCH libvirt v1] tests: add capabilities for QEMU 5.1.0 on s390x

2020-12-16 Thread Shalini Chellathurai Saroja
On 12/14/20 10:10 AM, Andrea Bolognani wrote: On Wed, 2020-11-18 at 17:18 +0100, Shalini Chellathurai Saroja wrote: Signed-off-by: Shalini Chellathurai Saroja --- The replies file is removed from this patch and is available in https://gitlab.com/shalinichellathurai/libvirt/-/commit

Re: [PATCH libvirt v2 01/11] nodedev: detect AP card device

2020-11-13 Thread Shalini Chellathurai Saroja
. Is there a reason for defining a different type? Yes, In definition apAdapterRange, the prefix '0x' is optional. -- Kind regards Shalini Chellathurai Saroja Linux on Z and Virtualization Development Dept 1419 Vorsitzende des Aufsichtsrats: Gregor Pillen Geschäftsführung: Dirk Wittkopp Sitz der

Re: [PATCH libvirt v2 01/11] nodedev: detect AP card device

2020-11-16 Thread Shalini Chellathurai Saroja
On 11/13/20 4:28 PM, Jonathon Jongsma wrote: On Fri, 13 Nov 2020 12:09:26 +0100 Shalini Chellathurai Saroja wrote: Hi Jonathon, Thank you for the quick review:-) On 11/12/20 5:27 PM, Jonathon Jongsma wrote: + + + + + + It seems that you're unnecessarily

Re: [PATCH libvirt v2 03/11] nodedev: detect AP queues

2020-11-16 Thread Shalini Chellathurai Saroja
On 11/13/20 4:50 PM, Jonathon Jongsma wrote: On Fri, 13 Nov 2020 15:19:11 +0100 Shalini Chellathurai Saroja wrote: On 11/12/20 6:01 PM, Jonathon Jongsma wrote: diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in index d10a79e3..45281363 100644 --- a/docs/formatnode.html.in +++ b

[PATCH libvirt v1] tests: add capabilities for QEMU 5.1.0 on s390x

2020-11-18 Thread Shalini Chellathurai Saroja
Signed-off-by: Shalini Chellathurai Saroja --- The replies file is removed from this patch and is available in https://gitlab.com/shalinichellathurai/libvirt/-/commit/1c34c07c434560d7f44212ce0bbbc8bf92490622 tests/domaincapsdata/qemu_5.1.0.s390x.xml | 230 + .../caps_5.1.0.s390x.replies

[PATCH libvirt v3 10/11] node_device: mdev matrix support

2020-11-17 Thread Shalini Chellathurai Saroja
Allow mdev devices to be created on the matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 5 - src/node_device/node_device_udev.c | 4 +++- 2 files changed, 7 insertions(+), 2

[PATCH libvirt v3 06/11] nodedev: detect AP matrix device

2020-11-17 Thread Shalini Chellathurai Saroja
Add support for AP matrix device in libvirt node device driver. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/schemas/nodedev.rng | 7 +++ src/conf/node_device_conf.c| 9 + src/conf/node_device_conf.h

[PATCH libvirt v3 08/11] virsh: nodedev: filter by AP Matrix capability

2020-11-17 Thread Shalini Chellathurai Saroja
Add support to filter by 'ap_matrix' capability. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/formatnode.html.in | 3 +++ docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-nodedev.h | 1 + src/conf

[PATCH libvirt v3 02/11] tests: AP card node device

2020-11-17 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP card device. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_card07.xml | 8 tests/nodedevxml2xmltest.c

[PATCH libvirt v3 09/11] node_device: refactor address retrieval of node device

2020-11-17 Thread Shalini Chellathurai Saroja
Use switch statements instead of if-else condition in the method nodeDeviceFindAddressByName to retrieve address of a node device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 30

[PATCH libvirt v3 00/11] Support AP card, AP queues and AP matrix

2020-11-17 Thread Shalini Chellathurai Saroja
): node_device: detecting mdev_types capability on ap_matrix device Farhan Ali (1): virsh: nodedev: Filter by AP card and AP queue capabilities Shalini Chellathurai Saroja (9): nodedev: detect AP card device tests: AP card node device nodedev: detect AP queues tests: AP queue node device nodedev

[PATCH libvirt v3 01/11] nodedev: detect AP card device

2020-11-17 Thread Shalini Chellathurai Saroja
Introduce support for the Adjunct Processor (AP) crypto card device. Udev already detects the device, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs

[PATCH libvirt v3 05/11] virsh: nodedev: Filter by AP card and AP queue capabilities

2020-11-17 Thread Shalini Chellathurai Saroja
From: Farhan Ali Add support to filter by 'ap_card' and 'ap_queue' capabilities. Signed-off-by: Farhan Ali Reviewed-by: Boris Fiuczynski Reviewed-by: Bjoern Walk Signed-off-by: Shalini Chellathurai Saroja --- docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-nodedev.h | 2

[PATCH libvirt v3 04/11] tests: AP queue node device

2020-11-17 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP queues Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_07_0038.xml | 9 + tests/nodedevxml2xmltest.c

[PATCH libvirt v3 07/11] tests: AP matrix node device

2020-11-17 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_matrix.xml| 7

[PATCH libvirt v3 11/11] node_device: detecting mdev_types capability on ap_matrix device

2020-11-17 Thread Shalini Chellathurai Saroja
From: Boris Fiuczynski Add detection of mdev_types capability to Adjunct Processor Matrix device. Signed-off-by: Boris Fiuczynski Reviewed-by: Shalini Chellathurai Saroja Reviewed-by: Jonathon Jongsma Signed-off-by: Shalini Chellathurai Saroja --- docs/formatnode.html.in

[PATCH libvirt v3 03/11] nodedev: detect AP queues

2020-11-17 Thread Shalini Chellathurai Saroja
Each AP card device can support upto 256 AP queues. AP queues are also detected by udev, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/formatnode.html.in

[PATCH libvirt v2 11/11] node_device: detecting mdev_types capability on ap_matrix device

2020-11-12 Thread Shalini Chellathurai Saroja
From: Boris Fiuczynski Add detection of mdev_types capability to Adjunct Processor Matrix device. Signed-off-by: Boris Fiuczynski Signed-off-by: Shalini Chellathurai Saroja --- docs/formatnode.html.in | 24 +++- docs/schemas/nodedev.rng | 4

[PATCH libvirt v2 08/11] virsh: nodedev: filter by AP Matrix capability

2020-11-12 Thread Shalini Chellathurai Saroja
Add support to filter by 'ap_matrix' capability. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/formatnode.html.in | 3 +++ docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-nodedev.h | 1 + src/conf

[PATCH libvirt v2 01/11] nodedev: detect AP card device

2020-11-12 Thread Shalini Chellathurai Saroja
Introduce support for the Adjunct Processor (AP) crypto card device. Udev already detects the device, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs

[PATCH libvirt v2 00/11] Support AP card, AP queues and AP matrix

2020-11-12 Thread Shalini Chellathurai Saroja
device Farhan Ali (1): virsh: nodedev: Filter by AP card and AP queue capabilities Shalini Chellathurai Saroja (9): nodedev: detect AP card device tests: AP card node device nodedev: detect AP queues tests: AP queue node device nodedev: detect AP matrix device tests: AP matrix node

[PATCH libvirt v2 03/11] nodedev: detect AP queues

2020-11-12 Thread Shalini Chellathurai Saroja
Each AP card device can support upto 256 AP queues. AP queues are also detected by udev, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/formatnode.html.in

[PATCH libvirt v2 06/11] nodedev: detect AP matrix device

2020-11-12 Thread Shalini Chellathurai Saroja
Add support for AP matrix device in libvirt node device driver. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/schemas/nodedev.rng | 7 +++ src/conf/node_device_conf.c| 11 ++- src/conf

[PATCH libvirt v2 09/11] node_device: refactor address retrieval of node device

2020-11-12 Thread Shalini Chellathurai Saroja
Use switch statements instead of if-else condition in the method nodeDeviceFindAddressByName to retrieve address of a node device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 30

[PATCH libvirt v2 02/11] tests: AP card node device

2020-11-12 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP card device. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_card07.xml | 8 tests/nodedevxml2xmltest.c

[PATCH libvirt v2 05/11] virsh: nodedev: Filter by AP card and AP queue capabilities

2020-11-12 Thread Shalini Chellathurai Saroja
From: Farhan Ali Add support to filter by 'ap_card' and 'ap_queue' capabilities. Signed-off-by: Farhan Ali Reviewed-by: Boris Fiuczynski Reviewed-by: Bjoern Walk Signed-off-by: Shalini Chellathurai Saroja --- docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-nodedev.h | 2

[PATCH libvirt v2 10/11] node_device: mdev matrix support

2020-11-12 Thread Shalini Chellathurai Saroja
Allow mdev devices to be created on the matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/node_device

[PATCH libvirt v2 07/11] tests: AP matrix node device

2020-11-12 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_matrix.xml| 7

[PATCH libvirt v2 04/11] tests: AP queue node device

2020-11-12 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP queues Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_07_0038.xml | 9 + tests/nodedevxml2xmltest.c

Re: [PATCH libvirt v2 10/11] node_device: mdev matrix support

2020-11-13 Thread Shalini Chellathurai Saroja
On 11/12/20 9:42 PM, Jonathon Jongsma wrote: On Thu, 12 Nov 2020 13:15:18 +0100 Shalini Chellathurai Saroja wrote: Allow mdev devices to be created on the matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src

Re: [PATCH libvirt v2 03/11] nodedev: detect AP queues

2020-11-13 Thread Shalini Chellathurai Saroja
is ap domain id. eg:/sys/bus/ap/devices/08.0001 */ -- Kind regards Shalini Chellathurai Saroja Vorsitzende des Aufsichtsrats: Gregor Pillen Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

Re: [PATCH libvirt v2 06/11] nodedev: detect AP matrix device

2020-11-13 Thread Shalini Chellathurai Saroja
trix), which is not very helpful, so we decided to go with ap_matrix instead. -- Kind regards Shalini Chellathurai Saroja Linux on Z and Virtualization Development Vorsitzende des Aufsichtsrats: Gregor Pillen Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

[PATCH libvirt v1 5/7] virsh: nodedev: filter by AP Matrix capability

2020-10-21 Thread Shalini Chellathurai Saroja
Add support to filter by 'ap_matrix' capability. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/formatnode.html.in | 3 +++ docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-nodedev.h | 1 + src/conf

[PATCH libvirt v1 7/7] node_device: mdev matrix support

2020-10-21 Thread Shalini Chellathurai Saroja
Allow mdev devices to be created on the matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/node_device

[PATCH libvirt v1 1/7] nodedev: Detect AP Card device

2020-10-21 Thread Shalini Chellathurai Saroja
From: Farhan Ali Introduce support for the Adjunct Processor (AP) Crypto Card device. Udev already detects the device, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski

[PATCH libvirt v1 3/7] virsh: nodedev: Filter by AP Card and AP Queue capabilities

2020-10-21 Thread Shalini Chellathurai Saroja
From: Farhan Ali Add support to filter by 'ap_card' and 'ap_queue' capabilities. Signed-off-by: Farhan Ali Reviewed-by: Boris Fiuczynski Reviewed-by: Bjoern Walk Signed-off-by: Shalini Chellathurai Saroja --- docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-nodedev.h | 2

[PATCH libvirt v1 2/7] nodedev: Detect AP Queues

2020-10-21 Thread Shalini Chellathurai Saroja
From: Farhan Ali Each AP Card device can support upto 256 AP Queues. AP Queues are also detected by udev, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs

[PATCH libvirt v1 4/7] nodedev: detect AP Matrix device

2020-10-21 Thread Shalini Chellathurai Saroja
Add support for AP matrix device in libvirt nodedev driver. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/schemas/nodedev.rng | 7 ++ src/conf/node_device_conf.c | 10 +++- src/conf

[PATCH libvirt v1 6/7] node_device: refactor address retrieval of node device

2020-10-21 Thread Shalini Chellathurai Saroja
Use switch statements instead of if-else condition in the method nodeDeviceFindAddressByName to retrieve address of a node device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 29

  1   2   >