On Wed, Nov 23, 2022 at 01:59:54PM +, Daniel P. Berrangé wrote:
> The poster child example of QEMU evolving is the block layer
> which has many syntax versions
Sure, those sorts of things have indeed changed an awful lot, and libvirt
obviously brings value in that interface. But that feels
On Wed, Nov 23, 2022 at 02:12:59PM +0100, Jiri Denemark wrote:
> Not to mention that QEMU changed names of several features and even deprecated
> the old spellings which is completely transparent to libvirt users as they can
> still use the old names no matter what version of QEMU they use. This
On Wed, Nov 23, 2022 at 01:45:37PM +, Daniel P. Berrangé wrote:
> Indeed, the very fact that libvirt exists and is widely used, is what
> allows QEMU to deprecated and rename stuff on a pretty aggressive
> schedule. If libvirt wasn't providing this isolation, then it is
> unlikely QEMU would
On Wed, Nov 23, 2022 at 11:48:17AM +, Daniel P. Berrangé wrote:
> > We're struggling to see what value the libvirt layer is bringing us in this
> > area, as opposed to a single-source-of-truth approach.
>
> Well libvirt's job is to insulate applications from the specific hypervisor
>
On Wed, Nov 23, 2022 at 12:29:24PM +0100, Jiri Denemark wrote:
> > I really don't think we should allow this, especially not for something
> > which is clearly intended to be used for production deployment. Our
> > hypervisor CLI passthrough is there to allow for short term workarounds
> > for
On Fri, Nov 18, 2022 at 10:52:32AM +0100, Jiri Denemark wrote:
> > * Qemu already provide an option 'enforce' to validate if features
> > with which vm is started is exactly same as one provided and nothing
> > is silently dropped.
>
> Right, but it's not enough. In addition to removed
From: John Levon
In 0895a0e, it was noted that the "sockets" value in the topology
section of capabilities reflects not the number of sockets per NUMA
node, not the total number.
Unfortunately, the fix was applied to the wrong place: the domain XML
format doc
The callback ID can be zero, not necessarily positive; correct the
comment to reflect this.
Signed-off-by: John Levon
---
src/libvirt-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index a197618673..53efb60406 100644
On Thu, Jan 13, 2022 at 03:43:12PM +0100, Michal Prívozník wrote:
> > switch ((virDomainChrSerialTargetModel) serial->targetModel) {
> > case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_ISA_SERIAL:
> > @@ -10750,11 +10752,24 @@ qemuBuildSerialChrDeviceProps(const virDomainDef
> > *def,
> >
On Thu, Jan 13, 2022 at 06:47:26PM +0530, Ani Sinha wrote:
> > > I preferred your previous style to this one.
> >
> > Below is cleaner IMO: we don't repeat code, and the flow is much clearer.
>
> If you look at other functions for example qemuBuildVirtioDevProps() etc they
> follow the previous
On Thu, Jan 13, 2022 at 03:11:51PM +0530, Ani Sinha wrote:
> > diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> > index d822533ccb..4130df0ed9 100644
> > --- a/src/qemu/qemu_command.c
> > +++ b/src/qemu/qemu_command.c
> > @@ -10718,6 +10718,8 @@ qemuBuildSerialChrDeviceProps(const
On Sat, Dec 11, 2021 at 07:57:47PM -0800, “Divya wrote:
> From: Divya Garg
>
> VM XML accepts target.port but this does not get passed while building the
> qemu
> command line for this VM.
Apologies, I failed to notice this had been sent out to the list; Re-posting
my comments from an
Hi, has anyone considered support for vfio-user devices in libvirt?
I was thinking of something like:
/path/to/vfio-user.sock
The main reason why this is useful is to get a PCI slot assigned for PCI-based
vfio-user.
Thoughts?
thanks
john
interface? Below is our current libvirt patch
regards
john
Support setting of vlan ID for network interfaces
Signed-off-by: John Levon john.le...@sun.com
Signed-off-by: Max Zhen max.z...@sun.com
diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
--- a/docs/schemas/domain.rng
+++ b/docs
On Wed, Apr 01, 2009 at 01:47:26PM +0100, Daniel P. Berrange wrote:
Finally, when starting the console print a message telling the user the
hotkey to quit
# virsh start --console VirtTest
Domain VirtTest started
Connecting to console, type Ctrl+] to quit
Can we please make this the
On Thu, Feb 26, 2009 at 03:26:34PM +0100, Pritesh Kothari wrote:
Is the XML format for defining the Domains common to all the hypervisors? If
not then how should I start about defining it for Virtualbox?
Hi Pritesh. The XML format is not exactly the same between the
hypervisors, but large
On Thu, Feb 26, 2009 at 05:20:55PM +0100, Pritesh Kothari wrote:
What exactly does the tag os_typexen/os_type exactly mean? how can
xen, hvm, etc be an os type?
It's a horrible wart. OS type really means v12n method, and it means
either paravirt or HVM here. Presumably vbox wouldn't
On Thu, Feb 26, 2009 at 05:00:47PM +0100, Pritesh Kothari wrote:
I think it depends on exactly how you are doing it - best to just post the
patches and we can discuss whether it looks reasonable then. Why did you
dlopen() instead of just linking to it directly ?
Basically my code depends
On Tue, Feb 24, 2009 at 05:09:31PM +0530, Amit Shah wrote:
This is an untested patch to make disk allocations faster and
non-fragmented. I'm using posix_fallocate() now but relying on glibc
This is not available everywhere - you need to make a configure.in test
regards
john
--
Libvir-list
On Thu, Feb 12, 2009 at 02:37:46PM -0500, Cole Robinson wrote:
The recent API additions virSaveLastError and virFreeError upset the
python bindings generator. Add a rule to explicitly skip them for the
bindings, since (as far as I can tell) the libvirtError class provides
everything we need.
On Wed, Feb 11, 2009 at 10:01:24AM +0100, Guido Günther wrote:
In the qemu driver, it is entirely hotplug/hotunplug, and deliberately
fails on an inactive domain. This patch seems to add offline support
We don't even persist the devices being hot{added,removed} into the
domain xml so
I wanted to bring this topic out of a patch review thread.
Dan recently stated that only patches that use upstream facilities are
acceptable, meaning the xend delivered by XenSource. I'd like to make a
few points on this note:
1. I'd like to hear from the other core maintainers if they agree
On Mon, Feb 09, 2009 at 04:29:56PM +0100, Jim Meyering wrote:
I'm applying these fixes to avoid make check failures:
I normally do a full install, syntax-check, and check. I must have
missed the latter this time round - sorry.
thanks
john
--
Libvir-list mailing list
Libvir-list@redhat.com
On Mon, Feb 09, 2009 at 04:54:51PM +, Daniel P. Berrange wrote:
2. I'd like to hear a rationale for this rule.
The number one rule is not to fork codebases in incompatible ways.
Agreed. Thankfully, we haven't done that.
Adding new features to a particular version of Xen and not making
On Thu, Feb 05, 2009 at 06:56:58AM +0100, Jim Meyering wrote:
xend can occassionally get itself confused. Avoid crashing libvirt in
this case.
The example I had looked like this:
(device (vif (backend 0)))
I'm not sure it's appropriate for a test case since it's strictly a bug.
On Thu, Feb 05, 2009 at 08:00:04AM +0100, Jim Meyering wrote:
Use virMacAddrCompare() in xs_internal.c
This solves a failure to look up a net device.
Please take the time to describe the failure scenario
in enough detail that someone (maybe me) can reproduce it.
OK. The problem was one
On Thu, Feb 05, 2009 at 11:53:37AM +, Daniel P. Berrange wrote:
Support recording the distro type and variant of a domain.
I don't really consider distro type variant as represented by
virt-install to be very satisfactory. It was intended to represent
the capabilities of the OS being
On Thu, Feb 05, 2009 at 12:34:32PM +, Daniel P. Berrange wrote:
+static void
+virshReportError(vshControl *ctl)
+{
+if (last_error == NULL)
+return;
+
+if (last_error-code == VIR_ERR_OK) {
+vshError(ctl, TRUE, %s, _(unknown error));
+return;
On Thu, Feb 05, 2009 at 11:56:59AM +, Daniel P. Berrange wrote:
It doesn't work quite right with a running domain. The 'new' will
correctly set the config, but the temporary config doesn't include the
new setting. So tests of the form set autostart; is it set? will fail.
I'm not sure
On Thu, Feb 05, 2009 at 05:00:41PM +, Daniel P. Berrange wrote:
Oh come on. Hacks for RHEL5 are OK, but anyone else has changes in their
system and it's not? Whatever happened to libvirt not being lowest
common denominator?
The changes put in RHEL5 are *backports* of existing
On Thu, Feb 05, 2009 at 05:00:41PM +, Daniel P. Berrange wrote:
there were RHEL-5 Xen features which were not already upstream in a newer
Xen version, we wouldn't include them in libvirt (they wouldn't be in
RHEL-5 Xen anyway, because we don't add stuff there unless it is already
in
On Thu, Feb 05, 2009 at 05:34:20PM +, Daniel P. Berrange wrote:
Ok, how about a slightly different virSaveLastError() call, avoiding
the need to do the pair of call virGetLastEror() + virCloneError()
Sounds reasonable to me.
Also, it is neccessary to free the error message/object
On Thu, Feb 05, 2009 at 06:03:48PM +, Daniel P. Berrange wrote:
Python API, you can see it returning False when it shouldn't.
You should be able to see it with 'virsh dominfo'
Yes, sorry. You do indeed see the wrong answer there.
The problem is that we're doing a new and xend is
# HG changeset patch
# User john.le...@sun.com
# Date 1233859424 28800
# Node ID dd8a1923aae38d9e36cb98a934af64450ecd85a2
# Parent 8086732c0e4250d26a4cfed2411e86b209712eb5
Introduce virCopyLastError()
Allow applications to store a copy of the last error reported.
Signed-off-by: John Levon
if the entire command fails.
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/virsh.c b/src/virsh.c
--- a/src/virsh.c
+++ b/src/virsh.c
@@ -93,22 +93,6 @@ typedef enum {
} vshErrorLevel;
/*
- * The error handler for virsh
- */
-static void
-virshErrorHandler(void *unused, virErrorPtr
On Thu, Feb 05, 2009 at 11:28:48AM -0800, john.le...@sun.com wrote:
Improve error reporting in virsh
Rather than verbosely printing every error, save the last error and
report that only if the entire command fails.
This version fixes up the memory leak issue Dan spotted. It's dependent
upon
On Thu, Feb 05, 2009 at 08:20:28PM +, Daniel P. Berrange wrote:
This actually still leaks the char * strings associated with the
error - we probably need to now add a virErrorFree() function to
go along with the new virSaveError function.
Yep, working on two new patches. Sorry about that.
On Thu, Feb 05, 2009 at 08:39:55PM +, Daniel P. Berrange wrote:
First, we'd need to make some changes to the libvirtd because it calls
into a number of APIs, both public entry points some of the internal
helpers directly, but does not reset the error in betweeen these calls.
Of
Running virsh with the remote driver (as it always is on Solaris), it
leaks pretty heavily:
thewhip:~ # yes start fewfewf | virsh /dev/null 21
[1] 6388
# prstat -c -p 6388
PID USERNAME SIZE RSS STATE PRI NICE TIME CPU PROCESS/NLWP
6388 root 10M 6788K sleep 590
-by: John Levon john.le...@sun.com
diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
--- a/include/libvirt/virterror.h
+++ b/include/libvirt/virterror.h
@@ -172,8 +172,10 @@ typedef void (*virErrorFunc) (void *user
*/
virErrorPtrvirGetLastError (void
if the entire command fails.
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/virsh.c b/src/virsh.c
--- a/src/virsh.c
+++ b/src/virsh.c
@@ -93,22 +93,6 @@ typedef enum {
} vshErrorLevel;
/*
- * The error handler for virsh
- */
-static void
-virshErrorHandler(void *unused, virErrorPtr
On Thu, Feb 05, 2009 at 07:23:36PM -0500, Jim Paris wrote:
Yeah, it seems there is no limit on the size of the readline history,
so it just grows forever. Try this?
Yep, that's a relief, thanks.
regards
john
--
Libvir-list mailing list
Libvir-list@redhat.com
# HG changeset patch
# User john.le...@sun.com
# Date 1233765613 28800
# Node ID 706a43692cceeba796e36c070e2b46f85d8cb4f0
# Parent bda41ea0cbbdea409447686c30b7afb10b9cae85
Report error for some xend operations on shutdown domain
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src
xend versions; for NICs, however, this requires a change in
netif.py to allow matching by MAC address. Preferring the device ID but
falling back to the device ref works best with all versions of xend.
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/xend_internal.c b/src
if the entire command fails. Additionally, avoid
over-writing an existing error in various places in the library.
Signed-off-by: John Levon john.le...@sun.com
diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
--- a/include/libvirt/virterror.h
+++ b/include/libvirt/virterror.h
On Wed, Feb 04, 2009 at 03:42:10PM -0800, john.le...@sun.com wrote:
Allow off-line removal of devices via xend
This patch is bogus, please ignore for now
thanks
john
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Jan 30, 2009 at 10:50:38AM -0800, john.le...@sun.com wrote:
Add distro to domain XML
Support recording the distro type and variant of a domain.
Comments? We obviously don't want to fork the XML, but consider being
able to record this for debugging purposes very important.
regards
On Thu, Jan 29, 2009 at 11:33:10AM +, Daniel P. Berrange wrote:
Hmm, current XenD may not mind having 'localtime' here, but I'm
worried older XenD may not be so forgiving. Will have to check
older source.
Any success?
Existing code unconditionally sets localtime=0 and localtime=1,
but
-by: John Levon john.le...@sun.com
diff --git a/src/xend_internal.c b/src/xend_internal.c
--- a/src/xend_internal.c
+++ b/src/xend_internal.c
@@ -1759,7 +1759,8 @@ xenDaemonParseSxprNets(virConnectPtr con
if (VIR_ALLOC(net) 0)
goto no_memory;
-if (tmp
# HG changeset patch
# User john.le...@sun.com
# Date 1233800565 28800
# Node ID 379763c63798c9f0c426facb9b9b61e34e6477e2
# Parent e6b17082b9b9440ce14ad76bd2f4c003ae2404db
Use virMacAddrCompare() in xs_internal.c
This solves a failure to look up a net device.
Signed-off-by: John Levon john.le
xend versions; for NICs, however, this requires a change in
netif.py to allow matching by MAC address. Preferring the device ID but
falling back to the device ref works best with all versions of xend.
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/xend_internal.c b/src
On Tue, Feb 03, 2009 at 11:14:24AM +, Daniel P. Berrange wrote:
I can't reproduce this problem with current CVS.
I made the following change to the 'dump' method in virsh.c
The difference is I have it /after/ the virDomainFree (actually in
virCommandRun). I hadn't noticed this before.
On Mon, Feb 02, 2009 at 07:17:29PM +0100, Jim Meyering wrote:
Thought note that we like continuation lines
to be aligned with the opening parenthesis, i.e.,
VIR_DEBUG(dconn=%p, cookie=%p, cookielen=%p, uri_in=%s, uri_out=%p,
flags=%lu, dname=%s, bandwidth=%lu, dconn,
If you edit virsh sources, you should find that on 'virsh dump Domain-0
/var/tmp/foo', the conn error is correctly set, but the thread-load
error is not set. Isn't this a bug?
regards
john
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Jan 30, 2009 at 03:25:36PM +, Daniel P. Berrange wrote:
Urgh, took me a while to understand what was going wrong there - a
little bizzarre contract for vshCommandOptString!
Yes, I'm completely lost as to the purpose of found to be honest.
regards
john
--
Libvir-list mailing list
On Fri, Jan 30, 2009 at 03:41:04PM +, Daniel P. Berrange wrote:
This is obviously impossible for xenmigr:///. As a result, virsh migrate
always returns an error code:
I'm not sure I understand why this is impossible ?
I thought the purpose of xenmigr:/// was to allow live migration
On Fri, Jan 30, 2009 at 04:19:06PM +, Daniel P. Berrange wrote:
I'm not sure I understand why this is impossible ?
I thought the purpose of xenmigr:/// was to allow live migration the
traditional way without needing a remotely accessible libvirtd. At
least, that's how we're using
On Fri, Jan 30, 2009 at 04:42:04PM +, Daniel P. Berrange wrote:
We're not going to *require* libvirtd to listen across the network when
there's an existing mechanism, so it sounds like we'll have to fork this
part.
You can use the xen+ssh://hostname/ URI for the destination if you
17) QEMU XML-2-ARGV disk-drive-shared ... FAILED
I have VIR_TEST_DEBUG set, but this is all I get. It's new
regards
john
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
# HG changeset patch
# User John Levon john.le...@sun.com
# Date 129660 28800
# Node ID 69992f43b6f634fa46c7ae2039666378ce378eea
# Parent 1b00b26880ad7feae71bb8df9ae86cfcaa428458
Fix empty declaration compiler error
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/domain_conf.c
It doesn't work quite right with a running domain. The 'new' will
correctly set the config, but the temporary config doesn't include the
new setting. So tests of the form set autostart; is it set? will fail.
Suggestions?
Also, why isn't this represented in the XML?
thanks,
john
--
Libvir-list
On Thu, Jan 29, 2009 at 11:33:10AM +, Daniel P. Berrange wrote:
+if (def-localtime xenXMConfigSetInt(conf, localtime, 1) 0)
+goto no_memory;
Existing code unconditionally sets localtime=0 and localtime=1,
but this only sets localtime=1, relying on XM defaults for
On Thu, Jan 29, 2009 at 11:35:19AM +, Daniel P. Berrange wrote:
Fix xend XML generation when CPU pinning is used
Signed-off-by: John Levon john.le...@sun.com
Am I right in thinking that the problem addressed here, is that if
the SEXPR has CPU pinning data, we'd be parsing
# HG changeset patch
# User john.le...@sun.com
# Date 1233280613 28800
# Node ID 59c231ad7e158acead0c236c3a52f60718b84605
# Parent b203988038c14f1160cbd250a48eda40d4613eca
Fix getpwuid_r() usage
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/util.c b/src/util.c
--- a/src/util.c
# HG changeset patch
# User john.le...@sun.com
# Date 1233282885 28800
# Node ID 6ee939f57a02bf9d332f094e07180e0149e85924
# Parent c60439e564f90b579c07f6349f8f0810a5da1032
Fix yet another printf(%s, NULL) case
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/libvirt.c b/src
On Thu, Jan 29, 2009 at 06:06:10PM -0800, john.le...@sun.com wrote:
+if (getpwuid_r(uid, pwbuf, strbuf, strbuflen, pw) != 0 || pw == NULL)
I didn't qrefresh, but the version I tested does indeed compile (missing
brace here) :)
regards
john
--
Libvir-list mailing list
# HG changeset patch
# User john.le...@sun.com
# Date 1233286638 28800
# Node ID 0934f4c2e1d446b1902d9ffcf14febf964af1e6a
# Parent 6ee939f57a02bf9d332f094e07180e0149e85924
Fix virsh migrateuri handling
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/virsh.c b/src/virsh.c
--- a/src
2675 * Returns the new domain object if the migration was successful,
2676 * or NULL in case of error. Note that the new domain object
2677 * exists in the scope of the destination connection (dconn).
This is obviously impossible for xenmigr:///. As a result, virsh migrate
always returns
On Wed, Jan 28, 2009 at 11:29:16AM +, Daniel P. Berrange wrote:
+device/vfb/vncdisplay);
+if (value != NULL)
+port = strtol(value, NULL, 0);
This isn't checking the return value of strtol, so it could have
parsed
the parsing of vncdisplay, which was broken due to strtol() (never
use this function!).
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/util.c b/src/util.c
--- a/src/util.c
+++ b/src/util.c
@@ -1041,6 +1041,7 @@ cleanup:
return rc;
}
+#endif /* PROXY */
/* Like strtol
that aren't supported by direct attach.
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/xend_internal.c b/src/xend_internal.c
--- a/src/xend_internal.c
+++ b/src/xend_internal.c
@@ -5018,14 +5018,26 @@ xenDaemonFormatSxprDisk(virConnectPtr co
* under the hvm (image (os)) block
# HG changeset patch
# User john.le...@sun.com
# Date 1233198416 28800
# Node ID 76d670ab6ea5476be96441ea88af94644c985201
# Parent f0247b9f4da199c01412d5bd0f9d7d888cbb84de
Solaris PV is localtime. Allow this setting through the conversions.
Signed-off-by: John Levon john.le...@sun.com
diff
# HG changeset patch
# User john.le...@sun.com
# Date 1233199841 28800
# Node ID 3f2af372963ddbae509bd0d1b2e7bdf3ebb4f217
# Parent 76d670ab6ea5476be96441ea88af94644c985201
Fix another printf(%s, NULL) case
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/libvirt.c b/src/libvirt.c
# HG changeset patch
# User john.le...@sun.com
# Date 1233203295 28800
# Node ID 9aac8028d5f266023c85338afe71ecabe26079f7
# Parent add5d46423d8cc24ac922373ba5cd1b3ea2e6f9f
Fix xend XML generation when CPU pinning is used
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src
. Solaris should be ignoring the invalid
protocol anyway, but this fix is correct regardless.
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/xend_internal.c b/src/xend_internal.c
--- a/src/xend_internal.c
+++ b/src/xend_internal.c
@@ -752,7 +752,11 @@ xenDaemonOpen_unix(virConnectPtr
# HG changeset patch
# User john.le...@sun.com
# Date 1233119659 28800
# Node ID cc848242fa810e8d0126b651849de715c7ef32e4
# Parent f91041f0c607be72c4b5695f081d20716521f6c5
Install schemas into correct location for Solaris
Signed-off-by: John Levon john.le...@sun.com
diff --git a/configure.in b
the parsing of vncdisplay, which was broken due to strtol() (never
use this function!).
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/xend_internal.c b/src/xend_internal.c
--- a/src/xend_internal.c
+++ b/src/xend_internal.c
@@ -612,7 +612,9 @@ sexpr_get(virConnectPtr xend, const char
On Mon, Jan 26, 2009 at 10:54:23AM +, Richard W.M. Jones wrote:
On Thu, Jan 22, 2009 at 05:49:12PM -0800, john.le...@sun.com wrote:
+/*
+ * If it's not running, we can't help.
+ */
+if (domain-id 0)
+return NULL;
NACK. Unfortunately you shouldn't return
On Mon, Jan 26, 2009 at 10:55:37AM +, Richard W.M. Jones wrote:
Does XenD actaully persist the schedinfo changes for inactive domains ?
Historically we've only considered the sched tunables API to be
relevant to active guests, and none of the drivers make any attempt
to persist the
On Mon, Jan 26, 2009 at 11:29:01AM +, Daniel P. Berrange wrote:
It isn't that simple. Tunables are not represented as part of the XML,
Good point, that would need to be fixed. I'd missed this.
So if we want to be able to set tunables on inactive domains, the
On Mon, Jan 26, 2009 at 12:28:47PM +, Richard W.M. Jones wrote:
No, surely we should fix the XML to represent it, and then it /would/
work. Must be better than another identical API.
Historically there has been a bit of a debate about this. It's not
clear if the XML is meant to
# HG changeset patch
# User John Levon john.le...@sun.com
# Date 1232970961 28800
# Node ID 839f1721d6d9c2cfdbc9327814a4c4a9564ff814
# Parent 26d337992a98a00d98f83247eb113ca3d729d8ef
Fix stderr spewage from docs/examples install
*.res don't exist, so shouldn't be in the generated Makefile.am
On Fri, Jan 23, 2009 at 10:34:14AM +, Daniel P. Berrange wrote:
Fix virsh sched-credit for xend
Need to pass domain in the xend op for shut-down domains.
(This also requires xend fixes, but this patch doesn't make things
worse.)
Does XenD actaully persist the schedinfo changes
On Fri, Jan 23, 2009 at 10:32:51AM +, Daniel P. Berrange wrote:
Am I right in thinking you're adding this because the
generic virsh schedinfo --set cap=123 command is hardcoding
the LLONG data type. If so, this is the wrong approach - virsh
is actually the one at fault.
OK, I'll look at
What are these files supposed to be? Dan V's 2105:ed8c8b0ec3c5 changeset
backed out my change:
install-data-local:
$(mkinstalldirs) $(DESTDIR)$(HTML_DIR)
-...@install@ -m 0644 $(srcdir)/*.html $(srcdir)/*.c
$(srcdir)/*.xml \
- $(srcdir)/*.xsl $(DESTDIR)$(HTML_DIR)
+
On Sat, Jan 24, 2009 at 04:04:28AM +0100, Daniel Veillard wrote:
- libxml2 uses the same doc/example stuff
- the Makefile.am is generated, it's actually indicated at the top
Ah, thanks! A file which generates a file which generates a file which
generates a
file, which is used to
On Thu, Jan 22, 2009 at 10:08:54AM +, Daniel P. Berrange wrote:
virNetworkRemoveInactive;
-virNetworkSaveConfigXML;
Actually this is a typo - it should be virNetworkSaveXML
I thought that when I read your patch, but virNetworkSaveXML isn't used
outside of network_conf.c, so I think
On Thu, Jan 22, 2009 at 08:31:46AM +0100, Jim Meyering wrote:
There are a couple of problems when doing it that way:
OK, try this version.
regards,
john
Add a rule for generating .hgignore
Also regenerate, and fix a missing entry.
Signed-off-by: John Levon john.le...@sun.com
diff --git
of xenStoreListDomains().
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/xs_internal.c b/src/xs_internal.c
--- a/src/xs_internal.c
+++ b/src/xs_internal.c
@@ -565,6 +565,46 @@ xenStoreNumOfDomains(virConnectPtr conn)
}
/**
+ * xenStoreDoListDomains:
+ * @conn: pointer to the hypervisor
.
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/xen_internal.c b/src/xen_internal.c
--- a/src/xen_internal.c
+++ b/src/xen_internal.c
@@ -1069,11 +1069,17 @@ xenHypervisorGetSchedulerType(virDomainP
}
priv = (xenUnifiedPrivatePtr) domain-conn-privateData;
-if (priv
# HG changeset patch
# User john.le...@sun.com
# Date 1232675291 28800
# Node ID ad7f82da983cc0ba07f7f4e94a2f23a4edc3be57
# Parent 3ef027308b88b47b2f3ca721bf88f2e606d8e3bc
xend driver: handle new-format sched-credit options
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src
On Wed, Jan 21, 2009 at 09:58:58AM +, Daniel P. Berrange wrote:
This is already initialized earlier on in the remoteOpen() method
so I don't think this chunk could have be the cause of the crashes.
This only became true with 2108:36cd5c7576ae. Yesterday, the hg mirror
was before that, but
was specified in the Xen domain config.
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/domain_conf.c b/src/domain_conf.c
--- a/src/domain_conf.c
+++ b/src/domain_conf.c
@@ -289,6 +289,7 @@ void virDomainNetDefFree(virDomainNetDef
case VIR_DOMAIN_NET_TYPE_BRIDGE:
VIR_FREE
of bridge type again.
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/domain_conf.c b/src/domain_conf.c
--- a/src/domain_conf.c
+++ b/src/domain_conf.c
@@ -288,6 +288,7 @@ void virDomainNetDefFree(virDomainNetDef
case VIR_DOMAIN_NET_TYPE_BRIDGE:
VIR_FREE(def
# HG changeset patch
# User john.le...@sun.com
# Date 1232563649 28800
# Node ID 256c8a54b46909dcdd6999d55538e64ec5931e4d
# Parent c109dd0801246b82aed8d5f9b1fa4196432868d0
Add .hgignore entries
Signed-off-by: John Levon john.le...@sun.com
diff --git a/.hgignore b/.hgignore
--- a/.hgignore
+++ b
# HG changeset patch
# User john.le...@sun.com
# Date 1232563649 28800
# Node ID 256c8a54b46909dcdd6999d55538e64ec5931e4d
# Parent c109dd0801246b82aed8d5f9b1fa4196432868d0
Add .hgignore entries
Signed-off-by: John Levon john.le...@sun.com
diff --git a/.hgignore b/.hgignore
--- a/.hgignore
+++ b
# HG changeset patch
# User john.le...@sun.com
# Date 1232574142 28800
# Node ID 0a35ce4ac7e0cf83df188dea0fc37818b4c39d48
# Parent fc06d88e4140cebc9d0b7795019c0c2741c3f8a9
Remove non-existent symbol from linker script
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src
# HG changeset patch
# User john.le...@sun.com
# Date 1232576262 28800
# Node ID c58822f94b2b5e87a363128a4bd36ec2846054fe
# Parent c109dd0801246b82aed8d5f9b1fa4196432868d0
Add a rule for generating .hgignore
Signed-off-by: John Levon john.le...@sun.com
diff --git a/Makefile.maint b
On Wed, Jan 21, 2009 at 07:56:35PM +0100, Jim Meyering wrote:
john.le...@sun.com wrote:
diff --git a/.hgignore b/.hgignore
Makefile.maint's sync-vcs-ignore-files already automatically
derives all .gitignore files from corresponding .cvsignore files,
so please do something similar for
-by: John Levon john.le...@sun.com
diff --git a/src/logging.c b/src/logging.c
--- a/src/logging.c
+++ b/src/logging.c
@@ -705,7 +705,10 @@ int virLogParseOutputs(const char *outpu
return(-1);
if (virLogAddOutputToSyslog(prio, name) == 0)
ret
1 - 100 of 264 matches
Mail list logo
