[libvirt] [PATCH] virhostcpu: Report correct topolgy info on host with deconfigured core

The host which has a deconfigured core is treated as though the topology is not correct and the SMT is not reliable. Which is not true, so report the topology correctly by detecting if the host is actually in a proper SMT mode with the deconfigured core. Signed-off-by: Nitesh Konkar <ni

Re: [libvirt] [PATCH] cpu_ppc64: Error out when model tag missing in virsh cpu-compare xml

Gentle ping. On Mon, Sep 18, 2017 at 10:27 PM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > libvirtd throws unhandled signal 11 on ppc while running > virsh cpu-compare with missing model tag in the xml. This > patch errors out in such situation. > > Signed-

[libvirt] [PATCH] cpu_ppc64: Error out when model tag missing in virsh cpu-compare xml

libvirtd throws unhandled signal 11 on ppc while running virsh cpu-compare with missing model tag in the xml. This patch errors out in such situation. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/cpu/cpu_ppc64.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [libvirt] [PATCH v2] virt-host-validate: Fix warning for IOMMU detection on PPC

} else { virHostMsgFail(level, "IOMMU capability not compiled into kernel. "); } return -1; } virHostMsgPass(); return 0; On Wed, Aug 23, 2017 at 7:06 PM, John Ferlan <jfer...@redhat.com> wrote: > > &

[libvirt] [PATCH v2] virt-host-validate: Fix warning for IOMMU detection on PPC

Fix the warning generated on PPC by virt-host-validate for IOMMU Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- tools/virt-host-validate-common.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/vir

[libvirt] [PATCH] virt-host-validate: Fix warning for IOMMU detection on PPC

Fix the warning generated on PPC by virt-host-validate for IOMMU Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- tools/virt-host-validate-common.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/vir

[libvirt] [PATCH] docs: Fix documentation related to memory locking

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index bceddd2..91195be 100644 --- a/docs/formatdomain.html.in +++

Re: [libvirt] [PATCH 0/5] qemu: process: Don't try to use NUMA nodes without memory from numad advice

Hello Peter, This is my first review. I tested the patch series on my system and it works fine. The refactoring part and the logic for autoCpuset and autoNodeset looks good. ACK from my side. Thanks, Nitesh. On Wed, Jul 12, 2017 at 7:14 PM, Peter Krempa wrote: > Cgroups

[libvirt] [PATCH] Fix guest boot failure when vcpu placement="auto" on memoryless numa node

When the vcpu placement is auto and we have memoryless numa nodes on the host, numad returns a list numa nodes with and without memory. When we try to write it to /sys/fs/cgroup/*/cpuset.mems it errors out as invlaid argument. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- n

[libvirt] [PATCH] qemu: Avoid parsing empty nodeset string

The advisory nodeset from numad is parsed irrespective of the string being empty or not. Avoid parsing an empty nodeset string. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sr

[libvirt] [PATCH v3] Regression: Report correct CPUs present on executing virsh nodecpumap

On executing the virsh nodecpumap command, the number of CPUs present was shown as (last cpu online id + 1). This patch fixes the issue by reporting the current number of CPUs present. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/util/virhostcpu.c | 2 +- 1 file chan

Re: [libvirt] [PATCH v2] Regression: Report correct CPUs present on executing virsh nodecpumap

On Thu, May 25, 2017 at 2:14 PM, Ján Tomko <jto...@redhat.com> wrote: > On Thu, May 25, 2017 at 02:04:16PM +0530, Nitesh Konkar wrote: > >> On executing the virsh nodecpumap command, the number >> of CPUs present was shown as (last cpu online id + 1). This >> patc

Re: [libvirt] [PATCH v2] Regression: Report correct CPUs present on executing virsh nodecpumap

Yes I did, limited to my knowledge. On Thu, May 25, 2017 at 2:08 PM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > Yes I did. > > On Thu, May 25, 2017 at 2:07 PM, Peter Krempa <pkre...@redhat.com> wrote: > >> On Thu, May 25, 2017 at 14:04

[libvirt] [PATCH v2] Regression: Report correct CPUs present on executing virsh nodecpumap

On executing the virsh nodecpumap command, the number of CPUs present was shown as (last cpu online id + 1). This patch fixes the issue by reporting the current number of CPUs present. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/util/virhostcpu.c | 2 +- 1 file chan

Re: [libvirt] [PATCH] Regression: Report correct CPUs present on executing virsh nodecpumap

On Wed, May 24, 2017 at 8:09 PM, Ján Tomko <jto...@redhat.com> wrote: > On Wed, May 24, 2017 at 07:46:00PM +0530, Nitesh Konkar wrote: > >> Recent changes to virbitmap.c file created a regression >> where on executing the virsh nodecpumap command, the number >> of C

[libvirt] [PATCH] Regression: Report correct CPUs present on executing virsh nodecpumap

Recent changes to virbitmap.c file created a regression where on executing the virsh nodecpumap command, the number of CPUs present was shown as (last cpu online id + 1). This patch fixes the issue. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/Makefile.am | 2 +

[libvirt] [PATCH] perf: remote: Compare perf nparams against the correct constant

Currently 'virsh perf domain' errors out as the perf nparams is incorrectly compared against REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX instead of REMOTE_DOMAIN_PERF_EVENTS_MAX. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- daemon/remote.c | 2 +- 1 file changed, 1 insertion

[libvirt] [PATCH] remote: Make Upper limit on list of memory parameters to 64

'virsh perf domain' errors out as the number of perf events now exceeds the previous memory parameter limit of 16. The fix is to set it to 64, as the upper limit on list of perf events, is also set to the same. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/

Re: [libvirt] [PATCH v2 00/10] perf: Add software perf events

On Wed, Mar 8, 2017 at 12:31 AM, John Ferlan <jfer...@redhat.com> wrote: > > > On 03/06/2017 02:55 PM, John Ferlan wrote: > > > > > > On 02/23/2017 09:55 AM, Nitesh Konkar wrote: > >> This patch series adds software perf events. > >> The perl an

[libvirt] [PATCH go v3] Add support for perf events

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- connect.go | 54 ++ domain.go | 54 ++ domain_compat.h | 36 3 files change

Re: [libvirt] [PATCH go v2] Add support for perf events

On Fri, Feb 24, 2017 at 3:32 PM, Peter Krempa <pkre...@redhat.com> wrote: > On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote: > > Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> > > --

Re: [libvirt] [PATCH go v2] Add support for perf events

On Fri, Feb 24, 2017 at 4:06 PM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Fri, Feb 24, 2017 at 11:02:33AM +0100, Peter Krempa wrote: > > On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote: > > > Signed-off-by: Nitesh Konkar <

[libvirt] [PATCH go v2] Add support for perf events

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- connect.go | 54 ++ domain.go | 54 ++ domain_compat.h | 36 3 files change

[libvirt] [PATCH perl v2] Add constants for new perf event support

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- Changes| 9 + Virt.xs| 9 + lib/Sys/Virt/Domain.pm | 54 ++ 3 files changed, 72 insertions(+) diff --git a/Changes b/Changes

[libvirt] [PATCH 10/10] news: Update the news.xml about perf events added

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 74dfe9a..9a5f4c5 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -130,6 +130,17 @@ driver wi

[libvirt] [PATCH v2 08/10] perf: add alignment_faults software perf event support

This patch adds support and documentation for the alignment_faults perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 8 docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-do

[libvirt] [PATCH v2 07/10] perf: add page_faults_maj software perf event support

This patch adds support and documentation for the page_faults_maj perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 9 + docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-do

[libvirt] [PATCH v2 06/10] perf: add page_faults_min software perf event support

This patch adds support and documentation for the page_faults_min perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 9 + docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-do

[libvirt] [PATCH v2 09/10] perf: add emulation_faults software perf event support

This patch adds support and documentation for the emulation_faults perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 9 + docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-do

[libvirt] [PATCH v2 05/10] perf: add cpu_migrations software perf event support

This patch adds support and documentation for the cpu_migrations perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 8 docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-domain.h

[libvirt] [PATCH v2 04/10] perf: add context_switches software perf event support

This patch adds support and documentation for the context_switches perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++ docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-do

[libvirt] [PATCH v2 03/10] perf: add page_faults software perf event support

This patch adds support and documentation for the page_faults perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 8 docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-domain.h

[libvirt] [PATCH v2 02/10] perf: add task_clock software perf event support

This patch adds support and documentation for the task_clock perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 8 docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-domain.h

[libvirt] [PATCH v2 01/10] perf: add cpu_clock software perf event support

This patch adds support and documentation for the cpu_clock perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 8 docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-domain.h

[libvirt] [PATCH v2 00/10] perf: Add software perf events

This patch series adds software perf events. The perl and go patches shall follow shortly. Nitesh Konkar (10): perf: add cpu_clock software perf event support perf: add task_clock software perf event support perf: add page_faults software perf event support perf: add context_switches

Re: [libvirt] [PATCH v2] Don't print extra newline in virsh domstats output

Polite PIng. On Fri, Feb 10, 2017 at 8:34 PM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> > --- > virsh domstats --perf > Domain: 'Fedora123' > perf.cache_misses=394986 > > Domain: 'Fed

[libvirt] [PATCH] nwfilter_gentech_driver: Fix indentation and typo

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/nwfilter/nwfilter_gentech_driver.c | 4 ++-- src/nwfilter/nwfilter_gentech_driver.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nw

Re: [libvirt] [PATCH 7/9] perf: add page_faults_maj software perf event support

On Mon, Feb 13, 2017 at 8:14 PM, John Ferlan <jfer...@redhat.com> wrote: > > > On 02/13/2017 01:49 AM, Nitesh Konkar wrote: > > > > > > > > On Fri, Feb 10, 2017 at 3:22 AM, John Ferlan <jfer...@redhat.com > > <mailto:jfer...@redhat.com>>

Re: [libvirt] [PATCH v2] Ensure disk names follow the disk name regex

ik <mpriv...@redhat.com> wrote: > On 02/15/2017 12:14 PM, Nitesh Konkar wrote: > > Currently disk names do not follow the > > (regex) /^[fhv]d[a-z]+[0-9]*$/ completely > > and hence one can assign disk names like > > vd2 etc. This patch ensures that the > > disk

[libvirt] [PATCH v2] Ensure disk names follow the disk name regex

Currently disk names do not follow the (regex) /^[fhv]d[a-z]+[0-9]*$/ completely and hence one can assign disk names like vd2 etc. This patch ensures that the disk names follow the regex mentioned. This patch also adds a testcase. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.

Re: [libvirt] [PATCH] Ensure disk names follow the disk name regex

On Tue, Feb 14, 2017 at 8:47 PM, Michal Privoznik <mpriv...@redhat.com> wrote: > On 02/03/2017 10:25 AM, Nitesh Konkar wrote: > > Currently disk names do not follow the > > (regex) /^[fhv]d[a-z]+[0-9]*$/ completely > > and hence one can assign disk names like >

Re: [libvirt] [PATCH] Ensure disk names follow the disk name regex

polite ping. On Fri, Feb 3, 2017 at 2:55 PM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > Currently disk names do not follow the > (regex) /^[fhv]d[a-z]+[0-9]*$/ completely > and hence one can assign disk names like > vd2 etc. This patch ensures that the > disk n

Re: [libvirt] [PATCH 1/9] perf: add cpu_clock software perf event support

On Fri, Feb 10, 2017 at 3:10 AM, John Ferlan <jfer...@redhat.com> wrote: > > > On 01/27/2017 06:01 AM, Nitesh Konkar wrote: > > This patch adds support and documentation for > > the cpu_clock perf event. > > > > Signed-off-by: Nitesh Konkar <nitk

Re: [libvirt] [PATCH 7/9] perf: add page_faults_maj software perf event support

On Fri, Feb 10, 2017 at 3:22 AM, John Ferlan <jfer...@redhat.com> wrote: > > > On 01/27/2017 06:01 AM, Nitesh Konkar wrote: > > This patch adds support and documentation > > for the page_faults_maj perf event. > > > > Signed-off-by: Nitesh Konkar <nitk

[libvirt] [PATCH v2] Don't print extra newline in virsh domstats output

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- virsh domstats --perf Domain: 'Fedora123' perf.cache_misses=394986 Domain: 'Fedora' perf.cache_misses=447017 virsh domstats Domain: 'Fedora123' state.state=1 state.reason=1 cpu.time=562472167198 cpu.user=228340

[libvirt] [PATCH] util: Fix indentation for virnetdevmacvlan

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/util/virnetdevmacvlan.c | 30 +++--- src/util/virnetdevmacvlan.h | 20 ++-- 2 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src/util/virnetdevmacvlan.c b/sr

[libvirt] [PATCH] Remove additional newline from virsh-domain-monitor.c

Currently "virsh domstats domainName" result ends with two blanklines. This shall remove the additional blank line. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- tools/virsh-domain-monitor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/virsh-domain-m

[libvirt] [PATCH] Mention the min duration for nodesuspend explicitly

Although currently this is documented in virsh man page and virsh help, the expicit mention in the error message is helful for tools using the API directly. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/util/virnodesuspend.c | 4 +++- 1 file changed, 3 insertions

[libvirt] [PATCH] Ensure disk names follow the disk name regex

Currently disk names do not follow the (regex) /^[fhv]d[a-z]+[0-9]*$/ completely and hence one can assign disk names like vd2 etc. This patch ensures that the disk names follow the regex mentioned. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/util/virutil.c | 2 +-

[libvirt] [PATCH] Fix indentation in datatypes.h

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/datatypes.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/datatypes.h b/src/datatypes.h index 5830482..d525835 100644 --- a/src/datatypes.h +++ b/src/datatypes.h @@ -696,11 +

[libvirt] [PATCH] qemu: Fix indentation in qemu_interface.h

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/qemu/qemu_interface.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_interface.h b/src/qemu/qemu_interface.h index 66ead2a..a7faa0b 100644 --- a/src/qemu/qemu_interface.h

[libvirt] [PATCH] [libvirt-perl PATCH] Add more PERF_ constants

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- Changes| 10 +- Virt.xs| 9 + lib/Sys/Virt/Domain.pm | 54 ++ 3 files changed, 72 insertions(+), 1 deletion(-) diff --git a/Cha

[libvirt] [PATCH] [PATCH go] Add support for more perf events

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- connect.go | 54 ++ domain.go | 54 ++ domain_compat.h | 36 3 files change

Re: [libvirt] [PATCH] [PATCH perl] Add support for more perf events

Note: This is actually for go bindings. Error in the commit's subject. Sending a v2 On Fri, Jan 27, 2017 at 6:29 PM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> > --- >

[libvirt] [PATCH] [PATCH perl] Add support for more perf events

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- connect.go | 54 ++ domain.go | 54 ++ domain_compat.h | 36 3 files change

[libvirt] [PATCH 9/9] perf: add emulation_faults software perf event support

This patch adds support and documentation for the emulation_faults perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++ docs/news.xml | 5 +++-- docs/schemas/domaincomm

[libvirt] [PATCH 8/9] perf: add alignment_faults software perf event support

This patch adds support and documentation for the alignment_faults perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++ docs/news.xml | 4 ++-- docs/schemas/domaincomm

[libvirt] [PATCH 5/9] perf: add cpu_migrations software perf event support

This patch adds support and documentation for the cpu_migrations perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 6 ++ docs/news.xml | 4 ++-- docs/schemas/domaincomm

[libvirt] [PATCH 4/9] perf: add context_switches software perf event support

This patch adds support and documentation for the context_switches perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 6 ++ docs/news.xml | 4 ++-- docs/schemas/domaincomm

[libvirt] [PATCH 3/9] perf: add page_faults software perf event support

This patch adds support and documentation for the page_faults perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 6 ++ docs/news.xml | 4 ++-- docs/schemas/domaincomm

[libvirt] [PATCH 6/9] perf: add page_faults_min software perf event support

This patch adds support and documentation for the page_faults_min perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++ docs/news.xml | 5 +++-- docs/schemas/domaincomm

[libvirt] [PATCH 7/9] perf: add page_faults_maj software perf event support

This patch adds support and documentation for the page_faults_maj perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++ docs/news.xml | 4 ++-- docs/schemas/domaincomm

[libvirt] [PATCH 0/9] perf: Add software perf events

This patch series adds software perf events. Nitesh Konkar (9): perf: add cpu_clock software perf event support perf: add task_clock software perf event support perf: add page_faults software perf event support perf: add context_switches software perf event support perf: add

[libvirt] [PATCH 1/9] perf: add cpu_clock software perf event support

This patch adds support and documentation for the cpu_clock perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 6 ++ docs/news.xml | 4 ++-- docs/schemas/domaincommon.rng

[libvirt] [PATCH 2/9] perf: add task_clock software perf event support

This patch adds support and documentation for the task_clock perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 6 ++ docs/news.xml | 5 +++-- docs/schemas/domaincomm

Re: [libvirt] [PATCH 0/7] perf: add CACHE_L1D perf event support

On Wed, Jan 25, 2017 at 9:55 PM, John Ferlan <jfer...@redhat.com> wrote: > > > On 01/18/2017 11:58 PM, Nitesh Konkar wrote: > > This patch series adds support and documentation for > > a generalized hardware cache event called CACHE_L1D > > perf event. This per

Re: [libvirt] [PATCH] perf: introduce option --reset

On Mon, Jan 23, 2017 at 7:34 PM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Mon, Jan 23, 2017 at 07:26:58PM +0530, Nitesh Konkar wrote: > > Hi Daniel, > > > > > > On Mon, Jan 23, 2017 at 4:08 PM, Daniel P. Berrange <berra...@redhat.com > > >

[libvirt] [PATCH] virnettlssessiontest.c: fix grammar

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- tests/virnettlssessiontest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/virnettlssessiontest.c b/tests/virnettlssessiontest.c index 0d2e106..24de212 100644 --- a/tests/virnettlssessiontest.c

[libvirt] [PATCH] perf: Prevent enabling of already enabled perf event

Currently, on every --enable perf_event command, a new event->fd is created and counting of perf event counter starts from zero and previous event->fd is lost. This patch prevents this behaviour. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/util/virperf.c | 3

Re: [libvirt] [PATCH] perf: introduce option --reset

Hi Daniel, On Mon, Jan 23, 2017 at 4:08 PM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Mon, Jan 23, 2017 at 04:03:21PM +0530, Nitesh Konkar wrote: > > > @@ -9570,16 +9570,17 @@ qemuDomainSetPerfEvents(virDomainPtr dom, > > if (def) { > >

[libvirt] [PATCH] perf: introduce option --reset

Currently you can either enable or disable a perf event. This patch allows you to reset the perf event using command line option --reset. Eg: virsh perf domainName --reset cpu_cycles Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- Example: virsh domstats Fedora --perf

[libvirt] [PATCH] docs: Reword virsh manpage for --uuid --name --details options

the correct meaning. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- tools/virsh.pod | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 290f508..fb62923 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3634,8 +

[libvirt] [PATCH 7/7] virsh: Fix manpage typo

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- tools/virsh.pod | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 467a7d6..bf5b93a 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -308,14 +308,14 @@

[libvirt] [PATCH 1/7] perf: add cache_l1dra perf event support

This patch adds support and documentation for a generalized hardware cache event named as cache_l1dra perf event for measuring read accesses on level 1 data cache Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++

[libvirt] [PATCH 4/7] perf: add cache_l1dwm perf event support

This patch adds support and documentation for a generalized hardware cache event named cache_l1dwm perf event for measuring write misses on level 1 data cache Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++ docs/ne

[libvirt] [PATCH 6/7] perf: add cache_l1dpm perf event support

This patch adds support and documentation for a generalized hardware cache event named cache_l1dpm perf event for measuring prefetch misses on level 1 data cache Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++ docs/ne

[libvirt] [PATCH 5/7] perf: add cache_l1dpa perf event support

This patch adds support and documentation for a generalized hardware cache event named cache_l1dpa perf event for measuring prefetch accesses on level 1 data cache Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++

[libvirt] [PATCH 0/7] perf: add CACHE_L1D perf event support

This patch series adds support and documentation for a generalized hardware cache event called CACHE_L1D perf event. This perf event is split into cache_l1dra, cache_l1drm, cache_l1dwa, cache_l1dwm, cache_l1dpa and cache_l1dpm perf events depending on the config value set. Nitesh Konkar (7

[libvirt] [PATCH 2/7] perf: add cache_l1drm perf event support

This patch adds support and documentation for a generalized hardware cache event named cache_l1drm perf event for measuring read misses on level 1 data cache Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++ docs/ne

[libvirt] [PATCH 3/7] perf: add cache_l1dwa perf event support

This patch adds support and documentation for a generalized hardware cache event named cache_l1dwa perf event for measuring write accesses on level 1 data cache Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++ docs/ne

[libvirt] [PATCH] virsh: Modify description for LIBVIRT_DEBUG=4 in manpage

As LIBVIRT_DEBUG=4 logs only error messages and there are no levels above it, adjusting the description in the man page accordingly. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vir

Re: [libvirt] [PATCH 1/2] perf: Compute cache_l1d config value correctly

a wrong value shall be displayed on enabling and displaying cache_l1d perf event. Thanks, Nitesh Konkar. On Sat, Jan 14, 2017 at 1:49 PM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > This patch computes the .attrConfig value for > cache_l1d correctly and updates the d

[libvirt] [PATCH 0/2] Add perf event support for Level 1 Data Cache

Compute the config value for cache_l1d (renamed to cache_l1dra) correctly and add another perf event support for cache_l1drm. Nitesh Konkar (2): perf: Compute cache_l1d config value correctly perf: add cache_l1drm perf event support docs/formatdomain.html.in | 19

[libvirt] [PATCH 2/2] perf: add cache_l1drm perf event support

This patch adds support and documentation for a generalized hardware cache event called cache_l1drm perf event for measuring read misses on level 1 data cache Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++ docs/ne

[libvirt] [PATCH 1/2] perf: Compute cache_l1d config value correctly

This patch computes the .attrConfig value for cache_l1d correctly and updates the documentation. The cache_l1d perf event now is renamed as cache_l1dra perf event for measuring read accesses for level 1 data cache Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> ---

[libvirt] [PATCH 2/2] docs: add news entry

Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/news.html.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/news.html.in b/docs/news.html.in index e544cfa..481ae39 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -46,8

[libvirt] [PATCH 1/2] perf: add cache_l1d perf event support

This patch adds support and documentation for a generalized hardware cache event called cache_l1d perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 7 +++ docs/schemas/domaincommon.rng | 1 + i

[libvirt] [PATCH] docs: Reword virsh manpage for --uuid --name --table options

The virsh manpage lists options --uuid and --name as mutually exclusive along option --table when actually the optoin --table is mutually exclusive and can't go with options --uuid and/or --name. This patch rewords the virsh manpage to state the correct meaning. Signed-off-by: Nitesh Konkar

Re: [libvirt] [PATCH] cmdPerf: Display enabled/disabled message on perf event enable/disable

I realized after sending the patch that the code I mentioned as "dead code" is not a dead code. I have sent a v2 for the same. On Wed, Dec 28, 2016 at 3:19 PM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > Currently, the code to display enabled/disabled message is &

[libvirt] [PATCH v2] cmdPerf: Display enabled/disabled message on perf event enable/disable

: disabled Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 3a6fa5c..287ca28 100644 --- a/tools/virsh-domain.c +++ b

[libvirt] [PATCH] cmdPerf: Display enabled/disabled message on perf event enable/disable

Currently, the code to display enabled/disabled message is a dead code as its misplaced in if block instead of else. This patch fixes that issue. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 17 + 1 file changed, 9 insertions

[libvirt] [PATCH 2/2] virsh: Fix English grammar in the virsh perf manpage

--- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index ef91223..9f9a0c6 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2274,7 +2274,7 @@ including context-switches, minor-faults, etc.. Now dozens of events from

[libvirt] [PATCH 1/2] perf: Refactor perf code

fixes this. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 3a6fa5c..91de532 100644 --- a/tools/virsh-domain.c +++ b/tools

[libvirt] [PATCH] perf: Consider all perf events mentioned in commandline

Currently 'virsh perf domainName --enable a,b' command fails to enable/disable perf event b if perf event a has failed to get enabled/disabled. This patch fixes this issue. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 4 ++-- 1 file chan

Re: [libvirt] [PATCH 0/4] Add generic perf event support

On Wed, Dec 14, 2016 at 4:12 AM, John Ferlan <jfer...@redhat.com> wrote: > > > On 12/13/2016 11:01 AM, Nitesh Konkar wrote: > > Add support and documentation for generic > > perf events like bus_cycles, stalled_cycles_frontend, > > stalled_cycles_backend and ref_

[libvirt] [PATCH 3/4] perf: add stalled_cycles_backend perf event support

This patch adds support and documentation for the stalled_cycles_backend perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 6 ++ docs/news.html.in | 3 ++- docs/schemas/domaincomm

[libvirt] [PATCH 1/4] perf: add bus_cycles perf event support

This patch adds support and documentation for the bus_cycles perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 6 ++ docs/news.html.in | 3 ++- docs/schemas/domaincommon.rng

[libvirt] [PATCH 0/4] Add generic perf event support

Add support and documentation for generic perf events like bus_cycles, stalled_cycles_frontend, stalled_cycles_backend and ref_cpu_cycles. Nitesh Konkar (4): perf: add bus_cycles perf event support perf: add stalled_cycles_frontend perf event support perf: add stalled_cycles_backend perf

[libvirt] [PATCH 4/4] perf: add ref_cpu_cycles perf event support

This patch adds support and documentation for the ref_cpu_cycles perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 6 ++ docs/news.html.in | 4 ++-- docs/schemas/domaincomm

[libvirt] [PATCH 2/4] perf: add stalled_cycles_frontend perf event support

This patch adds support and documentation for the stalled_cycles_frontend perf event. Signed-off-by: Nitesh Konkar <nitko...@linux.vnet.ibm.com> --- docs/formatdomain.html.in | 6 ++ docs/news.html.in | 6 +++--- docs/schemas/domaincomm

  1   2   >