Re: [PATCH 6/6] lib: Drop internal virXXXPtr typedefs

2021-03-16 Thread Michal Privoznik
On 3/12/21 8:59 AM, Michal Privoznik wrote: On 3/11/21 7:47 PM, Daniel P. Berrangé wrote: On Thu, Mar 11, 2021 at 06:54:20PM +0100, Michal Privoznik wrote: Historically, we declared pointer type to our types:    typedef struct _virXXX virXXX;    typedef virXXX *virXXXPtr; Also

Re: [PATCH 6/6] lib: Drop internal virXXXPtr typedefs

2021-03-12 Thread Jiri Denemark
On Thu, Mar 11, 2021 at 18:47:37 +, Daniel P. Berrangé wrote: > On Thu, Mar 11, 2021 at 06:54:20PM +0100, Michal Privoznik wrote: > > Historically, we declared pointer type to our types: > > > > typedef struct _virXXX virXXX; > > typedef virXXX *virXXXPtr; > > > > But usefulness of such

Re: [PATCH 6/6] lib: Drop internal virXXXPtr typedefs

2021-03-12 Thread Michal Privoznik
On 3/11/21 7:47 PM, Daniel P. Berrangé wrote: On Thu, Mar 11, 2021 at 06:54:20PM +0100, Michal Privoznik wrote: Historically, we declared pointer type to our types: typedef struct _virXXX virXXX; typedef virXXX *virXXXPtr; But usefulness of such declaration is questionable, at best.

Re: [PATCH 6/6] lib: Drop internal virXXXPtr typedefs

2021-03-11 Thread Daniel P . Berrangé
On Thu, Mar 11, 2021 at 06:54:20PM +0100, Michal Privoznik wrote: > Historically, we declared pointer type to our types: > > typedef struct _virXXX virXXX; > typedef virXXX *virXXXPtr; > > But usefulness of such declaration is questionable, at best. > Unfortunately, we can't drop every such

[PATCH 6/6] lib: Drop internal virXXXPtr typedefs

2021-03-11 Thread Michal Privoznik
Historically, we declared pointer type to our types: typedef struct _virXXX virXXX; typedef virXXX *virXXXPtr; But usefulness of such declaration is questionable, at best. Unfortunately, we can't drop every such declaration - we have to carry some over, because they are part of public API