Re: [PATCH v3 1/3] test_driver: Implement virDomainGetMessages

2021-07-12 Thread Martin Kletzander
On Mon, Jul 12, 2021 at 11:16:50AM +0800, Luke Yue wrote: On Fri, 2021-07-09 at 15:10 +0200, Martin Kletzander wrote: On Wed, Jun 30, 2021 at 10:53:44AM +0800, Luke Yue wrote: > Signed-off-by: Luke Yue > --- > src/test/test_driver.c | 53 > ++ > 1 file

Re: [PATCH v3 1/3] test_driver: Implement virDomainGetMessages

2021-07-11 Thread Luke Yue
On Fri, 2021-07-09 at 15:10 +0200, Martin Kletzander wrote: > On Wed, Jun 30, 2021 at 10:53:44AM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue > > --- > > src/test/test_driver.c | 53 > > ++ > > 1 file changed, 53 insertions(+) > > > > If you first

Re: [PATCH v3 1/3] test_driver: Implement virDomainGetMessages

2021-07-09 Thread Martin Kletzander
On Wed, Jun 30, 2021 at 10:53:44AM +0800, Luke Yue wrote: Signed-off-by: Luke Yue --- src/test/test_driver.c | 53 ++ 1 file changed, 53 insertions(+) If you first abstract the code from qemu driver then there's less code move to add this functionality.

[PATCH v3 1/3] test_driver: Implement virDomainGetMessages

2021-06-29 Thread Luke Yue
Signed-off-by: Luke Yue --- src/test/test_driver.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ef0ddab54d..35742fcde3 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@